GNU bug report logs - #38682
[PATCH] gnu: Add emacs-punpun-theme.

Previous Next

Package: guix-patches;

Reported by: Alex ter Weele <alex.ter.weele <at> gmail.com>

Date: Fri, 20 Dec 2019 01:48:02 UTC

Severity: normal

Tags: patch

Done: Brett Gilio <brettg <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38682 in the body.
You can then email your comments to 38682 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#38682; Package guix-patches. (Fri, 20 Dec 2019 01:48:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Alex ter Weele <alex.ter.weele <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 20 Dec 2019 01:48:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex ter Weele <alex.ter.weele <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-punpun-theme.
Date: Thu, 19 Dec 2019 20:46:56 -0500
[0001-gnu-Add-emacs-punpun-theme.patch (text/x-patch, inline)]
From 90fd350498ab548d2006e3e7c0c86ae5e87d1255 Mon Sep 17 00:00:00 2001
From: Alex ter Weele <alex.ter.weele <at> gmail.com>
Date: Thu, 19 Dec 2019 20:43:34 -0500
Subject: [PATCH] gnu: Add emacs-punpun-theme.

* gnu/packages/emacs-xyz.scm (emacs-punpun-theme): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8ff7a23f51..2241ed8989 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19876,6 +19876,31 @@ is cast on a light backdrop (Modus Operandi) and another where light text is
 displayed against a dark background (Modus Vivendi).")
     (license license:gpl3+)))
 
+(define-public emacs-punpun-theme
+  (let ((commit "2f78125609277b2478abdebd8f9d5ee10a823b65")
+        (revision "0"))
+    (package
+      (name "emacs-punpun-theme")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wasamasa/punpun-theme.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1sgxrj3igzq86h3whfymxf4qzv9kpvcrlhbvjmnp7fwrplys0n7d"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/wasamasa/punpun-theme")
+      (synopsis "Bleak Emacs theme")
+      (description
+       "A bleak theme.  Uses shades of gray and the occasional splash of
+color.  Designed for 256-color terminals.  Comes in light and dark!")
+      (license license:gpl3))))
+
+
 (define-public emacs-elixir-mode
   (package
     (name "emacs-elixir-mode")
-- 
2.24.1





Information forwarded to guix-patches <at> gnu.org:
bug#38682; Package guix-patches. (Fri, 20 Dec 2019 02:19:02 GMT) Full text and rfc822 format available.

Message #8 received at 38682 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Alex ter Weele <alex.ter.weele <at> gmail.com>, 38682 <at> debbugs.gnu.org
Subject: Re: [bug#38682] [PATCH] gnu: Add emacs-punpun-theme.
Date: Fri, 20 Dec 2019 02:18:45 +0000
Hi Alex,

Alex ter Weele <alex.ter.weele <at> gmail.com> writes:

> Subject: [PATCH] gnu: Add emacs-punpun-theme.
>
> * gnu/packages/emacs-xyz.scm (emacs-punpun-theme): New variable.
[...]
> +      (license license:gpl3))))

Based on the header in punpun-common.el [*], I think this should be
gpl3+.

[*] https://github.com/wasamasa/punpun-theme/blob/master/punpun-common.el#L13




Information forwarded to guix-patches <at> gnu.org:
bug#38682; Package guix-patches. (Fri, 20 Dec 2019 02:37:01 GMT) Full text and rfc822 format available.

Message #11 received at 38682 <at> debbugs.gnu.org (full text, mbox):

From: Alex ter Weele <alex.ter.weele <at> gmail.com>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 38682 <at> debbugs.gnu.org, Alex ter Weele <alex.ter.weele <at> gmail.com>
Subject: Re: [bug#38682] [PATCH] gnu: Add emacs-punpun-theme.
Date: Thu, 19 Dec 2019 21:36:33 -0500
[Message part 1 (text/plain, inline)]
Kyle Meyer <kyle <at> kyleam.com> writes:

> Based on the header in punpun-common.el [*], I think this should be
> gpl3+.

Good catch, here's an updated patch.

[0001-gnu-Add-emacs-punpun-theme.patch (text/x-patch, inline)]
From 965546778c1824eb7efe90c02ffc6878a1ed907e Mon Sep 17 00:00:00 2001
From: Alex ter Weele <alex.ter.weele <at> gmail.com>
Date: Thu, 19 Dec 2019 20:43:34 -0500
Subject: [PATCH] gnu: Add emacs-punpun-theme.

* gnu/packages/emacs-xyz.scm (emacs-punpun-theme): New variable.
---
 gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8ff7a23f51..45636f87f9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -19876,6 +19876,31 @@ is cast on a light backdrop (Modus Operandi) and another where light text is
 displayed against a dark background (Modus Vivendi).")
     (license license:gpl3+)))
 
+(define-public emacs-punpun-theme
+  (let ((commit "2f78125609277b2478abdebd8f9d5ee10a823b65")
+        (revision "0"))
+    (package
+      (name "emacs-punpun-theme")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/wasamasa/punpun-theme.git")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1sgxrj3igzq86h3whfymxf4qzv9kpvcrlhbvjmnp7fwrplys0n7d"))))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/wasamasa/punpun-theme")
+      (synopsis "Bleak Emacs theme")
+      (description
+       "A bleak theme.  Uses shades of gray and the occasional splash of
+color.  Designed for 256-color terminals.  Comes in light and dark!")
+      (license license:gpl3+))))
+
+
 (define-public emacs-elixir-mode
   (package
     (name "emacs-elixir-mode")
-- 
2.24.1


Information forwarded to guix-patches <at> gnu.org:
bug#38682; Package guix-patches. (Fri, 20 Dec 2019 04:02:01 GMT) Full text and rfc822 format available.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Gilio, Brett M" <brettg <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: Re: [bug#38682] [PATCH] gnu: Add emacs-punpun-theme.
Date: Thu, 19 Dec 2019 20:51:39 -0600
On 12/19/2019 8:36 PM, Alex ter Weele wrote:
> Kyle Meyer <kyle <at> kyleam.com> writes:
>
>> Based on the header in punpun-common.el [*], I think this should be
>> gpl3+.
> Good catch, here's an updated patch.

Looks good to me! I think this is ready for commit to master. I am 
unable to do this at this time, but if this is still open when I get 
home I will review it once more and push it.

Thanks!

-- 

Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>





Reply sent to Brett Gilio <brettg <at> gnu.org>:
You have taken responsibility. (Sat, 21 Dec 2019 05:03:02 GMT) Full text and rfc822 format available.

Notification sent to Alex ter Weele <alex.ter.weele <at> gmail.com>:
bug acknowledged by developer. (Sat, 21 Dec 2019 05:03:02 GMT) Full text and rfc822 format available.

Message #19 received at 38682-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Alex ter Weele <alex.ter.weele <at> gmail.com>
Cc: 38682-done <at> debbugs.gnu.org, Kyle Meyer <kyle <at> kyleam.com>
Subject: Re: [bug#38682] [PATCH] gnu: Add emacs-punpun-theme.
Date: Fri, 20 Dec 2019 23:02:46 -0600
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Pushed with 5613760aa40a157eb7f6666abbe8f5a9484c8b42. Thanks :)
- -- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE38DH957mDKeuVV4ZZyJDxKA/Du4FAl39p3YACgkQZyJDxKA/
Du6B2Q//eikAQdmnKZkd1AahVVJZ+SZ8EOhuVIU9+NLxwEPehJuY+z3Tuxlm1luK
t762vTPhBL3lSju+YT/xZeRSDoIOs5NBVA+YYvYTeYveYZ7JutU1b0ueMz6872hQ
sY1VULfmkBBiV2ayOPckWr09M9Fop+jaExBzgdsXiBmXknQ6W4lh3y4jSNuar7M6
eSHrsMyuO8HP0tF1HskN05508U+Axx/ihhW/sfQu18uK4A7REBAasVchSr1t5vpL
2012jCNrEFGCvYGi8W7UliE5uqELdS5DkCLxJ0DhuwH/7NnSN4QLtFi4VPE1qy6Q
BQb3NAe32hTDr08fSVoc30tP1JtLRl3p9Et8X4vAF/sVshQUPjdQAn1HzCBnwO7x
onqu2Qq9lXWyKtQMLBpq5F+zJxWL6FZkmFZy0v2xud53MTXvyB2t7ocznsCt+rX0
DvzGuapfSVresxMdXkZu/geKZyjyvUuNSPX/3oL8AMzqg5S8CQ8dDxMqDBUFe9C4
aEjNN2bvda48tSB52eu+IPT39rOaxiZhNxz3zzxP772y6k5BsLYFB58jzycuNMhU
OXkcF2E2UUZ5XfD42I6y9W6e26UoSuzkttoHzw69+eJCsQ7D02sbPo3gaYxzeFdS
MNjwLMMmBNRC7W205rdBwQoQa928F3x/V3EIlk+P0nSwes/sb6w=
=+XDB
-----END PGP SIGNATURE-----




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Jan 2020 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 150 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.