From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 13:58:32 2019 Received: (at submit) by debbugs.gnu.org; 19 Dec 2019 18:58:32 +0000 Received: from localhost ([127.0.0.1]:45512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii10J-0000mh-Pc for submit@debbugs.gnu.org; Thu, 19 Dec 2019 13:58:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:46036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihzve-0007aF-JO for submit@debbugs.gnu.org; Thu, 19 Dec 2019 12:49:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46810) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihzvb-0002A7-Tz for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 12:49:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihzva-00089o-68 for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 12:49:35 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42965) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihzv7-0007IW-Ao for bug-gnu-emacs@gnu.org; Thu, 19 Dec 2019 12:49:34 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 12EA2226C3 for ; Thu, 19 Dec 2019 12:49:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 19 Dec 2019 12:49:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=homonculus.net; h=from:content-type:mime-version:subject:message-id:date:to; s= fm2; bh=c7FLEcRfsT9NSOWjB4yO1bTJ9w5ToG2659fz/eFKTJQ=; b=NfFXAcu4 p86K45N1raP1x5JBx1m8R1HAODHzW3rzZdzsipYVlNAMJqw9yt2Qmyj1aMMCXfbL fzJzKf4os70jBZEMLqKfV2qAhqJQRS2+KIR00CflYFLIB+Q7UzB9tskf0xC8nAw5 Lm9zx4l186mRAF4DfGCZE3cA97h+1Mv1yEepCFvAS9RECzHQWwZkm9b5YlxrOjAE Pp2MK07RU9Xrv5E6vPYirx3RDTpVGvw+0JyuEj9NMSUs0Id6SC/2IF9qrLjVFErt VQoXvX9THvjC4CLs98PYHDieicLzhfJTIK+wH7/GsUFvjWoeSByGgYkvMHqC4wsn 8C8wVG6lhBeAJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=c7FLEcRfsT9NSOWjB4yO1bTJ9w5To G2659fz/eFKTJQ=; b=nOP1hNDscmbDXzXfsL1KNTKD4n1NEpop8+YJ7qWS/adHK lfVvm5Rb6KoklR4neSrBWVAYDonDEdYVvtOPio2qob5ADe4rFZS/eWPHqgflRXrP MXUWyb41bBzhtOKz221NpY6SMK+tLmophKFqHd+fMyLOicsN9FPqM4ydqxFSK00U BtzNTlxB4aZsUJfQOkBo7fDaG01lqBFxNVa2lsopjauqOxBwxpLGXcajBG4sXpXW zMTPSv4PDT9jh3FFLiEcoZ4feJs09rLacGgWvsXeX+2Au3PMZZVGSoaEUEhQTK/I qVOSNctiu5u0BRuMeNU0k3XuGm/1FfkyyJxIov/Kw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdduuddguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephfgtggfukfffvffosehmtdhmre hhtddvnecuhfhrohhmpeflrghmvghsucfhvghlihiguceulhgrtghkuceojhhfsgeshhho mhhonhgtuhhluhhsrdhnvghtqeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukf hppeejvddrudefkedrvdejrdduheegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjfhgs sehhohhmohhntghulhhushdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [172.16.2.252] (unknown [72.138.27.154]) by mail.messagingengine.com (Postfix) with ESMTPA id C67E48005B for ; Thu, 19 Dec 2019 12:49:02 -0500 (EST) From: James Felix Black Content-Type: multipart/mixed; boundary="Apple-Mail=_5D75CE6E-32A7-4ACB-8A41-039DBD45DBE9" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Subject: 27.0.50; define-obsolete-face-alias definition does not match documentation Message-Id: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> Date: Thu, 19 Dec 2019 12:49:01 -0500 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3608.40.2.2.4) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 19 Dec 2019 13:58:30 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --Apple-Mail=_5D75CE6E-32A7-4ACB-8A41-039DBD45DBE9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This was discovered in `haskell-mode` [1]. The documentation of = define-obsolete-face-alias claims that `when` is optional, but the macro = definition does not follow the docs. This patch fixes the problem. In GNU Emacs 27.0.50 (build 1, x86_64-apple-darwin19.2.0, NS = appkit-1894.20 Version 10.15.2 (Build 19C57)) of 2019-12-19 built on moomin.local Repository revision: f38e8a86650e8a7f72293d81a7392289c298ae5a Repository branch: fix_define-obsolete-face-alias_optional Windowing system distributor 'Apple', version 10.3.1894 System Description: Mac OS X 10.15.2 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. user-error: The mark is not set now, so there is no region Making completion list... Configured features: NOTIFY KQUEUE ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES THREADS PDUMPER LCMS2 GMP Important settings: value of $LANG: en_CA.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 43939 6393) (symbols 48 5909 1) (strings 32 15245 1247) (string-bytes 1 502913) (vectors 16 9297) (vector-slots 8 118962 11572) (floats 8 20 25) (intervals 56 185 0) (buffers 1000 12)) [1] https://github.com/haskell/haskell-mode/issues/1691 --Apple-Mail=_5D75CE6E-32A7-4ACB-8A41-039DBD45DBE9 Content-Disposition: attachment; filename=0001-Fix-macro-definition.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-macro-definition.patch" Content-Transfer-Encoding: quoted-printable =46rom=20f38e8a86650e8a7f72293d81a7392289c298ae5a=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20James=20Felix=20Black=20=0A= Date:=20Thu,=2019=20Dec=202019=2012:29:11=20-0500=0ASubject:=20[PATCH]=20= Fix=20macro=20definition=0A=0A`define-obsolete-face-alias`=20claims=20= not=20to=20require=20the=20third=20argument,=0A`when`.=20However,=20= `when`=20is=20not=20defined=20`&optional`.=20This=20patch=20addresses=0A= this.=0A---=0A=20lisp/emacs-lisp/byte-run.el=20|=202=20+-=0A=201=20file=20= changed,=201=20insertion(+),=201=20deletion(-)=0A=0Adiff=20--git=20= a/lisp/emacs-lisp/byte-run.el=20b/lisp/emacs-lisp/byte-run.el=0Aindex=20= 1115c09667..27aee3ed4e=20100644=0A---=20a/lisp/emacs-lisp/byte-run.el=0A= +++=20b/lisp/emacs-lisp/byte-run.el=0A@@=20-448,7=20+448,7=20@@=20= CURRENT-NAME,=20if=20it=20does=20not=20already=20have=20them:=0A=20;;=20= by=20the=20byte-compiler=20(would=20be=20nice=20if=20it=20could=20warn=20= about=20obsolete=0A=20;;=20faces,=20but=20it=20doesn't=20really=20do=20= anything=20special=20with=20faces).=0A=20;;=20It=20only=20really=20= affects=20M-x=20describe-face=20output.=0A-(defmacro=20= define-obsolete-face-alias=20(obsolete-face=20current-face=20when)=0A= +(defmacro=20define-obsolete-face-alias=20(obsolete-face=20current-face=20= &optional=20when)=0A=20=20=20"Make=20OBSOLETE-FACE=20a=20face=20alias=20= for=20CURRENT-FACE=20and=20mark=20it=20obsolete.=0A=20If=20provided,=20= WHEN=20should=20be=20a=20string=20indicating=20when=20the=20face=0A=20= was=20first=20made=20obsolete,=20for=20example=20a=20date=20or=20a=20= release=20number."=0A--=20=0A2.21.0=20(Apple=20Git-122.2)=0A=0A= --Apple-Mail=_5D75CE6E-32A7-4ACB-8A41-039DBD45DBE9-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 04:38:57 2019 Received: (at 38675) by debbugs.gnu.org; 21 Dec 2019 09:38:57 +0000 Received: from localhost ([127.0.0.1]:47614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iibDt-0001AK-K9 for submit@debbugs.gnu.org; Sat, 21 Dec 2019 04:38:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iibDs-0001A9-7N for 38675@debbugs.gnu.org; Sat, 21 Dec 2019 04:38:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iibDk-00053m-KY; Sat, 21 Dec 2019 04:38:51 -0500 Received: from [176.228.60.248] (port=2106 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iibDk-0000GS-3g; Sat, 21 Dec 2019 04:38:48 -0500 Date: Sat, 21 Dec 2019 11:38:36 +0200 Message-Id: <83sgleyq5f.fsf@gnu.org> From: Eli Zaretskii To: James Felix Black In-reply-to: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> (message from James Felix Black on Thu, 19 Dec 2019 12:49:01 -0500) Subject: Re: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation References: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38675 Cc: 38675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: James Felix Black > Date: Thu, 19 Dec 2019 12:49:01 -0500 > > This was discovered in `haskell-mode` [1]. The documentation of define-obsolete-face-alias claims that `when` is optional, but the macro definition does not follow the docs. This patch fixes the problem. I'm not sure this isn't a confusion caused by ambiguous wording of the doc string. I think by "if provided" it means that WHEN can be nil. The ELisp manual, btw, doesn't have this problem. Would it be okay to modify the doc string instead to say WHEN is required, but can be nil? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 12:55:06 2019 Received: (at 38675) by debbugs.gnu.org; 21 Dec 2019 17:55:06 +0000 Received: from localhost ([127.0.0.1]:48756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiiy1-0006YL-Op for submit@debbugs.gnu.org; Sat, 21 Dec 2019 12:55:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiixy-0006Xm-S6 for 38675@debbugs.gnu.org; Sat, 21 Dec 2019 12:55:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iiixt-0003fT-Dz; Sat, 21 Dec 2019 12:54:57 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1iiixr-0002CK-Sh; Sat, 21 Dec 2019 12:54:56 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation References: <728CF61C-FC25-4B59-BFC0-C6CBC5A626F8@homonculus.net> <83sgleyq5f.fsf@gnu.org> X-Spook: smuggle ANDVT Secure Border Initiative outage Cohiba X-Ran: )dLAks)Gle (Eli Zaretskii's message of "Sat, 21 Dec 2019 11:38:36 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38675 Cc: 38675@debbugs.gnu.org, James Felix Black X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) ced10a4c9f changed the arg spec but not the doc (or code). The intent seems clear: a proper "when" should always be provided. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 18:43:03 2019 Received: (at 38675) by debbugs.gnu.org; 21 Dec 2019 23:43:03 +0000 Received: from localhost ([127.0.0.1]:48934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iioOl-0007S2-Dd for submit@debbugs.gnu.org; Sat, 21 Dec 2019 18:43:03 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:37623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iinYZ-0002Hc-Fl for 38675@debbugs.gnu.org; Sat, 21 Dec 2019 17:49:07 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A8FE54A9; Sat, 21 Dec 2019 17:49:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 21 Dec 2019 17:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=homonculus.net; h=content-type:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; s=fm2; bh=uwKuQdjyO9JJFvBT+9ynoMGjo6/JEav57q31zVYeGC0=; b=aoxvRgzZapZX of5uFGit9z93ujJ1bau7tNtcVOHs0/auzyhmRw6MduoO4Wdcbu6SGD1TiM0OiM/Q HW3vEAJ3GD7ZanIa+aNgLTTDuP/4cYvNVueP5wajDPWgKHNXBCnI5u7y+TCnwRBP 8DsComrIIIdhRy2f+hvrsin9w3uPA+8Z+1uthJYt9JdA7vTCLq1OXPICZ3YdO5Cx Dbh17sa5NbfBnY1742xjq/IK9QMQG1yYN939vNRm6fl1igZkhoPbhC2SlFeSirjC /iKA7dKC23XVoJK/6Fk2+QStSQB+ETvqd3R2TpC+yqby7AQ39mbquWg6Nyeq5T+c YZGxGJB3+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=uwKuQdjyO9JJFvBT+9ynoMGjo6/JEav57q31zVYeG C0=; b=MqvHIEaVYWT88CSI7mqYLX71+Zq+GfWH9mWaW59YRAPvBqOXwXP+HemDa 8zUE1Fmwys2LyIZAfDtuMh+nRQZXQLCjeW/G7w2idAIcP73/xZ038w26+blj73UZ lz/CEzJtsTVqjZ34xCOV18zWG57m+umE7ubmh37au14+/S4V7TVdilm/v3h214CM E/XbcavS0tDcOMDd9v8vRWxxpnp8xo46iYMEJd709lZ9QT4VLkiSb1NmmNMXN+61 oGL77y/+2LW90AfhwI5CvzAlW2QW48ahCCVL8elcJgPggaSj3rEUvxdsGEyIm9gW cS/fqmbvJ1QZIIVZMc6DsWydpqG+Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdduiecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpegtgffhggfufffkfhgjvffosehtqhhmtdhhtdejnecuhfhrohhmpeflrghmvghsucfh vghlihiguceulhgrtghkuceojhhfsgeshhhomhhonhgtuhhluhhsrdhnvghtqeenucfkph epvddtkedrleekrddvvddvrdehieenucfrrghrrghmpehmrghilhhfrhhomhepjhhfsges hhhomhhonhgtuhhluhhsrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [10.164.95.64] (unknown [208.98.222.56]) by mail.messagingengine.com (Postfix) with ESMTPA id D317A8005B; Sat, 21 Dec 2019 17:49:00 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: James Felix Black Mime-Version: 1.0 (1.0) Subject: Re: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation Date: Sat, 21 Dec 2019 17:47:45 -0500 Message-Id: <16FD07C7-AEB6-4E43-8707-64F6B2FD8635@homonculus.net> References: <83sgleyq5f.fsf@gnu.org> In-Reply-To: <83sgleyq5f.fsf@gnu.org> To: Eli Zaretskii X-Mailer: iPhone Mail (17C54) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38675 X-Mailman-Approved-At: Sat, 21 Dec 2019 18:43:02 -0500 Cc: 38675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I=E2=80=99m easy either way. Do the usage and docs match the other =E2=80=9C= define-obsolete-=E2=80=9C macros? > On Dec 21, 2019, at 04:38, Eli Zaretskii wrote: >=20 > =EF=BB=BF >>=20 >> From: James Felix Black >> Date: Thu, 19 Dec 2019 12:49:01 -0500 >>=20 >> This was discovered in `haskell-mode` [1]. The documentation of define-o= bsolete-face-alias claims that `when` is optional, but the macro definition d= oes not follow the docs. This patch fixes the problem. >=20 > I'm not sure this isn't a confusion caused by ambiguous wording of the > doc string. I think by "if provided" it means that WHEN can be nil. > The ELisp manual, btw, doesn't have this problem. >=20 > Would it be okay to modify the doc string instead to say WHEN is > required, but can be nil? >=20 > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 04:15:18 2019 Received: (at 38675-done) by debbugs.gnu.org; 28 Dec 2019 09:15:18 +0000 Received: from localhost ([127.0.0.1]:57954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1il8Bq-0006zk-5b for submit@debbugs.gnu.org; Sat, 28 Dec 2019 04:15:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1il8Bo-0006zY-Ir for 38675-done@debbugs.gnu.org; Sat, 28 Dec 2019 04:15:16 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1il8Bi-0004x4-Cr; Sat, 28 Dec 2019 04:15:10 -0500 Received: from [176.228.60.248] (port=4997 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1il8Bh-0000qh-Ra; Sat, 28 Dec 2019 04:15:10 -0500 Date: Sat, 28 Dec 2019 11:15:09 +0200 Message-Id: <83tv5kolpe.fsf@gnu.org> From: Eli Zaretskii To: James Felix Black In-reply-to: <16FD07C7-AEB6-4E43-8707-64F6B2FD8635@homonculus.net> (message from James Felix Black on Sat, 21 Dec 2019 17:47:45 -0500) Subject: Re: bug#38675: 27.0.50; define-obsolete-face-alias definition does not match documentation References: <83sgleyq5f.fsf@gnu.org> <16FD07C7-AEB6-4E43-8707-64F6B2FD8635@homonculus.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38675-done Cc: 38675-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: James Felix Black > Date: Sat, 21 Dec 2019 17:47:45 -0500 > Cc: 38675@debbugs.gnu.org > > I’m easy either way. Do the usage and docs match the other “define-obsolete-“ macros? I fixed the documentation to fit the advertised calling convention, and I'm therefore closing this bug report. Thanks. From unknown Sat Aug 16 14:31:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Jan 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator