From unknown Thu Jun 19 14:05:30 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38670 <38670@debbugs.gnu.org> To: bug#38670 <38670@debbugs.gnu.org> Subject: Status: [PATCH] Fix audio/video in icecat Reply-To: bug#38670 <38670@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:05:30 +0000 retitle 38670 [PATCH] Fix audio/video in icecat reassign 38670 guix-patches submitter 38670 Julien Lepiller severity 38670 normal tag 38670 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 08:59:46 2019 Received: (at submit) by debbugs.gnu.org; 19 Dec 2019 13:59:46 +0000 Received: from localhost ([127.0.0.1]:44395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihwLC-0007ub-5F for submit@debbugs.gnu.org; Thu, 19 Dec 2019 08:59:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:53620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihwLA-0007uU-M8 for submit@debbugs.gnu.org; Thu, 19 Dec 2019 08:59:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihwL8-0000iu-Lb for guix-patches@gnu.org; Thu, 19 Dec 2019 08:59:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihwL7-00058C-4W for guix-patches@gnu.org; Thu, 19 Dec 2019 08:59:42 -0500 Received: from lepiller.eu ([2a00:5884:8208::1]:56302) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihwL6-0004gG-D7 for guix-patches@gnu.org; Thu, 19 Dec 2019 08:59:41 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id ebfbf303 for ; Thu, 19 Dec 2019 13:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type; s=dkim; bh=aYh 49jEQ/CSSdm4LHxxnbjgxXtE=; b=CiN9CGasDHw3MVcYzp9ml7ADdnv5liVbl1N YnNTtuVCEcA2hJNPw8VWWtQeLhY7ZbiY/xvsnHrwAXFYFPJBrLKy+piFcjBE1cYq fhs2VQvF4WoOOV2+cb8xSeJBwy207RpOdF8sMOyPnQildpeH2d0RBu5vpnlHg6Ck BD9MG1Q/KYQtyo0imTIZCmJeM+JaEiuRrveT/q2rkm61Jud5EkgcpZnpbhszQ46i b5RTZXfcWCKz0xNV/ylOZq4iS/pgGvX2FpLkc5JDGahiVCh6vFTh/EmDrCZOv9xP lmjw6MJKJrGrKfLL19RW58eqULgn14RX3O29CnfBZIXthYZNCFg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 5f4466d6 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Thu, 19 Dec 2019 13:59:35 +0000 (UTC) Date: Thu, 19 Dec 2019 14:59:22 +0100 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] Fix audio/video in icecat Message-ID: <20191219145922.715720ad@sybil.lepiller.eu> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Qd9/oJpq8Xir1WYsCYqSUTq" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:5884:8208::1 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --MP_/Qd9/oJpq8Xir1WYsCYqSUTq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi guix, since the update to icecat 68, mpeg decoding doesn't work in IceCat (mp3/mp4 would not play, breaking a lot of online media players). This patch addresses that issue, that was caused by IceCat not finding ffmpeg's library. It was dlopening libavcodec.so, but could not find it. I replaced it with an absolute reference to the library in the store, which now allows IceCat to load the library at runtime. It also adds ffmpeg to icecat's closure, ensuring it will always find it. --MP_/Qd9/oJpq8Xir1WYsCYqSUTq Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-icecat-Fix-linking-with-ffmpeg.patch >From c144cf973235d2e633daeeedbac45fcf61da04a1 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Thu, 19 Dec 2019 13:02:34 +0100 Subject: [PATCH] gnu: icecat: Fix linking with ffmpeg. * gnu/packages/gnuzilla.scm (icecat): Use absolute path for ffmpeg library loading. --- gnu/packages/gnuzilla.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 2f15beecc7..ce63f6762e 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -950,7 +950,7 @@ from forcing GEXP-PROMISE." )) #t)) (add-after 'remove-bundled-libraries 'link-libxul-with-libraries - (lambda _ + (lambda* (#:key inputs #:allow-other-keys) ;; libxul.so dynamically opens libraries, so here we explicitly ;; link them into libxul.so instead. ;; @@ -963,6 +963,9 @@ from forcing GEXP-PROMISE." 'GL', 'gnome-2', 'canberra', 'Xss', 'cups', 'gssapi_krb5', 'avcodec', 'avutil', 'pulse' ]\n\n" all))) + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec.so.[0-9]*") + (string-append (assoc-ref inputs "ffmpeg") "/lib/libavcodec.so"))) #t)) (replace 'bootstrap (lambda _ -- 2.24.0 --MP_/Qd9/oJpq8Xir1WYsCYqSUTq-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 17:49:22 2019 Received: (at 38670) by debbugs.gnu.org; 21 Dec 2019 22:49:22 +0000 Received: from localhost ([127.0.0.1]:48877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iinYn-0002Ia-VA for submit@debbugs.gnu.org; Sat, 21 Dec 2019 17:49:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iinYl-0002IE-4s for 38670@debbugs.gnu.org; Sat, 21 Dec 2019 17:49:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iinYe-00079M-DV; Sat, 21 Dec 2019 17:49:12 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=33174 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iinYd-0007e1-IE; Sat, 21 Dec 2019 17:49:12 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat References: <20191219145922.715720ad@sybil.lepiller.eu> Date: Sat, 21 Dec 2019 23:49:08 +0100 In-Reply-To: <20191219145922.715720ad@sybil.lepiller.eu> (Julien Lepiller's message of "Thu, 19 Dec 2019 14:59:22 +0100") Message-ID: <87k16pmh0b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38670 Cc: Mark H Weaver , 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Julien, Julien Lepiller skribis: > since the update to icecat 68, mpeg decoding doesn't work in IceCat > (mp3/mp4 would not play, breaking a lot of online media players). This > patch addresses that issue, that was caused by IceCat not finding > ffmpeg's library. It was dlopening libavcodec.so, but could not find > it. I replaced it with an absolute reference to the library in the > store, which now allows IceCat to load the library at runtime. It also > adds ffmpeg to icecat's closure, ensuring it will always find it. Great that you found out! >>>From c144cf973235d2e633daeeedbac45fcf61da04a1 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Thu, 19 Dec 2019 13:02:34 +0100 > Subject: [PATCH] gnu: icecat: Fix linking with ffmpeg. > > * gnu/packages/gnuzilla.scm (icecat): Use absolute path for ffmpeg > library loading. LGTM! (Cc=E2=80=99ing Mark for a heads-up.) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 23:53:47 2019 Received: (at 38670) by debbugs.gnu.org; 22 Dec 2019 04:53:47 +0000 Received: from localhost ([127.0.0.1]:49017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iitFS-0006B1-Uj for submit@debbugs.gnu.org; Sat, 21 Dec 2019 23:53:47 -0500 Received: from world.peace.net ([64.112.178.59]:50084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iitFQ-0006Ao-Fz for 38670@debbugs.gnu.org; Sat, 21 Dec 2019 23:53:45 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iitFO-0003wO-Qe; Sat, 21 Dec 2019 23:53:43 -0500 From: Mark H Weaver To: Julien Lepiller Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat In-Reply-To: <87k16pmh0b.fsf@gnu.org> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> Date: Sat, 21 Dec 2019 23:52:08 -0500 Message-ID: <87lfr57yi4.fsf@netris.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38670 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Julien, Thanks very much for investigating and producing a working fix for this issue! It is a great relief to remove this item from my TODO list :) I have a few minor nits, and am currently testing a slight variant of your proposed patch, attached below. I made the following changes: * I added a new phase instead of augmenting the existing 'link-libxul-with-libraries' phase, since the name of the existing phase doesn't match what's being done here. * I leave the numeric suffixes (version number) of the shared library names unchanged, instead of stripping them as you did. * I used "\\." in the regexp to strictly match that character. * I moved the rationale comment from the commit log into the code. What do you think? Thanks again! Mark --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-icecat-Fix-linking-with-ffmpeg.patch Content-Description: [PATCH] gnu: icecat: Fix linking with ffmpeg >From eed217b25cea8926680308c8e21522417fe13cf4 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Thu, 19 Dec 2019 13:02:07 +0100 Subject: [PATCH] gnu: icecat: Fix linking with ffmpeg. * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add 'fix-ffmpeg-runtime-linker' phase. Co-authored-by: Mark H Weaver . --- gnu/packages/gnuzilla.scm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 8bfa6c2a55..46fc7928a0 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -968,6 +968,13 @@ from forcing GEXP-PROMISE." 'avcodec', 'avutil', 'pulse' ]\n\n" all))) #t)) + (add-after 'link-libxul-with-libraries 'fix-ffmpeg-runtime-linker + (lambda* (#:key inputs #:allow-other-keys) + ;; Arrange to load libavcodec.so by its absolute file name. + (substitute* "dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp" + (("libavcodec\\.so") + (string-append (assoc-ref inputs "ffmpeg") "/lib/libavcodec.so"))) + #t)) (replace 'bootstrap (lambda _ (invoke "sh" "-c" "autoconf old-configure.in > old-configure") -- 2.24.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 02:07:51 2019 Received: (at 38670) by debbugs.gnu.org; 22 Dec 2019 07:07:51 +0000 Received: from localhost ([127.0.0.1]:49042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iivLD-0001No-0C for submit@debbugs.gnu.org; Sun, 22 Dec 2019 02:07:51 -0500 Received: from mout01.posteo.de ([185.67.36.65]:40679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iivLB-0001NW-2b for 38670@debbugs.gnu.org; Sun, 22 Dec 2019 02:07:49 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id C3A5916005E for <38670@debbugs.gnu.org>; Sun, 22 Dec 2019 08:07:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1576998461; bh=MeZajgpGOwUpAewq0jvXrywYrPiPCKtlLWbL6BBUPJM=; h=Date:From:To:Cc:Subject:From; b=XYgPCPG5oaYF3wlceaBIzSHJTeKQK5EhGOAg+191ERWha9mbMPegfBUsAGk7pOSCK kTYb3TsL/r4JS6sEU8v33IaI04HQAflfpnVJzn0z+JcVQLBsjbCA4NqeHAESgkBpiY YHN2Egs/TDIcx0Yu8+LG2WzcQkan+WtDPu36babZG4kQtYDoJvgZzScqvuNStcaGED JaNSw6XK3WlthEoSZncEiGGJDbTK5vnWACip7e0j9lo80DMaB4fB9zt9RR19+lBeg2 jKAYAXLyxKnaOQ+JCYbSK+qE2Jz6s6QHaDPCI6ernTWQQ+G4Gn0H93W2DItAx7krXe 0SaJyAT1uwXHA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47gYTS1G02z6tm8; Sun, 22 Dec 2019 08:07:39 +0100 (CET) Date: Sun, 22 Dec 2019 07:07:37 +0000 (UTC) From: Brett Gilio To: Mark H Weaver Message-ID: In-Reply-To: <87lfr57yi4.fsf@netris.org> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org> Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Correlation-ID: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38670 Cc: Julien Lepiller , =?UTF-8?Q?Ludovic_Court=C3=A8s?= , 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Dec 21, 2019 10:54:14 PM Mark H Weaver : > Hi Julien, > > Thanks very much for investigating and producing a working fix for this > issue! It is a great relief to remove this item from my TODO list :) > > I have a few minor nits, and am currently testing a slight variant of > your proposed patch, attached below. I made the following changes: > > * I added a new phase instead of augmenting the existing > 'link-libxul-with-libraries' phase, since the name of the existing > phase doesn't match what's being done here. > > * I leave the numeric suffixes (version number) of the shared library > names unchanged, instead of stripping them as you did. > > * I used "\\." in the regexp to strictly match that character. > > * I moved the rationale comment from the commit log into the code. > > What do you think? > > Thanks again! > Mark > I think with Mark's changes this is looking pretty much perfect. -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE] From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 05:00:34 2019 Received: (at 38670) by debbugs.gnu.org; 22 Dec 2019 10:00:34 +0000 Received: from localhost ([127.0.0.1]:49081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiy2M-0005Lo-GJ for submit@debbugs.gnu.org; Sun, 22 Dec 2019 05:00:34 -0500 Received: from lepiller.eu ([89.234.186.109]:41228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiy2J-0005Ld-T7 for 38670@debbugs.gnu.org; Sun, 22 Dec 2019 05:00:32 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 16b6e31d; Sun, 22 Dec 2019 10:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=nCGp+UmrC5Tq zE08SMgom9+Uw94=; b=ZEHtDcKNF1cz3m8DbVdwN0Hd1iyN66eZUmTOrh1usg1N w4m2MSmCmQTPFRb2jSsnH5gAEAydICoRvfmTpmkT+3wiMvwgj3ra8tyjD2bAq5mW SoFB/SqtATpAxhU21C23YsnK01s5jXDFPsOa1qY3SEdL53+RQ6oOcoH9QviIm6pv LvlFqdpO0Ug66FaDu8qgV5flns4wwe/ufu+/xOx566vw/g4+z5FxjwvdsqlC/VLK fH/nHRQ7HETArQfaw0o1a2smw+qWf2zvqc1WcfyD8pyU54/WlY2GPkX9ftNNEmYY UwNq8mkdMuEMiJ1D7PmPUMvYscWVCgreVVqDvIi2PQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id f1d8c4f3 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 22 Dec 2019 10:00:28 +0000 (UTC) Date: Sun, 22 Dec 2019 11:00:24 +0100 From: Julien Lepiller To: Mark H Weaver Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat Message-ID: <20191222105928.53f03e2c@sybil.lepiller.eu> In-Reply-To: <87lfr57yi4.fsf@netris.org> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38670 Cc: 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Sat, 21 Dec 2019 23:52:08 -0500, Mark H Weaver a =C3=A9crit : > Hi Julien, >=20 > Thanks very much for investigating and producing a working fix for > this issue! It is a great relief to remove this item from my TODO > list :) >=20 > I have a few minor nits, and am currently testing a slight variant of > your proposed patch, attached below. I made the following changes: >=20 > * I added a new phase instead of augmenting the existing > 'link-libxul-with-libraries' phase, since the name of the existing > phase doesn't match what's being done here. >=20 > * I leave the numeric suffixes (version number) of the shared library > names unchanged, instead of stripping them as you did. >=20 > * I used "\\." in the regexp to strictly match that character. >=20 > * I moved the rationale comment from the commit log into the code. >=20 > What do you think? Looks very good! Can you push it, or should I do it? >=20 > Thanks again! > Mark >=20 >=20 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 15:35:02 2019 Received: (at 38670) by debbugs.gnu.org; 22 Dec 2019 20:35:02 +0000 Received: from localhost ([127.0.0.1]:50290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij7wM-0002IW-AD for submit@debbugs.gnu.org; Sun, 22 Dec 2019 15:35:02 -0500 Received: from world.peace.net ([64.112.178.59]:51922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij7wJ-0002I3-On for 38670@debbugs.gnu.org; Sun, 22 Dec 2019 15:35:00 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ij7wF-0005Br-EO; Sun, 22 Dec 2019 15:34:57 -0500 From: Mark H Weaver To: Julien Lepiller Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat In-Reply-To: <20191222105928.53f03e2c@sybil.lepiller.eu> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org> <20191222105928.53f03e2c@sybil.lepiller.eu> Date: Sun, 22 Dec 2019 15:33:13 -0500 Message-ID: <87fthc85i3.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38670 Cc: 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Julien, Julien Lepiller wrote: > Looks very good! Can you push it, or should I do it? Would you be willing to try building IceCat with my variant of your patch and confirm that it works for you? If it does, please push it. The reason I ask is because although I built it myself, I'm not sure that it's working for me. It might be that the specific sites I tried are failing to work for other reasons, e.g. the privacy enhancements in IceCat's default configuration. Or, it might be that my decision to keep the shared library version numbers intact somehow broke it. Thank you! Mark From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 18:04:37 2019 Received: (at 38670) by debbugs.gnu.org; 22 Dec 2019 23:04:37 +0000 Received: from localhost ([127.0.0.1]:50354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijAH6-0005ws-U7 for submit@debbugs.gnu.org; Sun, 22 Dec 2019 18:04:37 -0500 Received: from lepiller.eu ([89.234.186.109]:41522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijAH3-0005wc-3S for 38670@debbugs.gnu.org; Sun, 22 Dec 2019 18:04:35 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 0e465000; Sun, 22 Dec 2019 23:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=7KKBtvB80OXjkHgUw8EPFVLQ3ps=; b=S5bkMFkEsSU/8MWpZub7owk 0wI4z3tG8LR98fP3Gnxo+uQ2+FxhdtkkW/wgTDoOXHcGCl2t1meHAY/4nsTgOHb6 IdqZSzrdxnlypvBf7cIKkL4M2wmapKTSPocA8iYF0d5vsMBombjpOGmB6IaOzcSp O4jyDNFw18lRdvH0IUtjWo/X1dKHqwZD7HDkbPijPE18QSaeyTvtVSDqVRSSf1hg BsvpYitNYU/+k9K5Dc6bV39B9DIPGhkHkQBZpMPE00gqPBMVjTE7C9h4HIkk9M54 JwQJOQHa/k7esGsr2nvATQWUbsv+3qkiVW0a5p0AFYXGoffFnI7kIs/NKey2qCw= = Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3e7cfd64 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 22 Dec 2019 23:04:27 +0000 (UTC) Date: Mon, 23 Dec 2019 00:04:23 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <87fthc85i3.fsf@netris.org> References: <20191219145922.715720ad@sybil.lepiller.eu> <87k16pmh0b.fsf@gnu.org> <87lfr57yi4.fsf@netris.org> <20191222105928.53f03e2c@sybil.lepiller.eu> <87fthc85i3.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat To: Mark H Weaver From: Julien Lepiller Message-ID: <839D186B-8322-4AFC-9516-21F4B9F81309@lepiller.eu> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38670 Cc: 38670@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le 22 d=C3=A9cembre 2019 21:33:13 GMT+01:00, Mark H Weaver a =C3=A9crit : >Hi Julien, > >Julien Lepiller wrote: >> Looks very good! Can you push it, or should I do it? > >Would you be willing to try building IceCat with my variant of your >patch and confirm that it works for you? If it does, please push it=2E > >The reason I ask is because although I built it myself, I'm not sure >that it's working for me=2E It might be that the specific sites I tried >are failing to work for other reasons, e=2Eg=2E the privacy enhancements = in >IceCat's default configuration=2E Or, it might be that my decision to >keep the shared library version numbers intact somehow broke it=2E > > Thank you! > Mark Sure, I'jl do that tomorrow morning=2E I have ajready tried a few variants= of my own patch, and it worked well both with anl without the version numb= er=2E However, I'll build and check your patch before pushing=2E I'm basically testing the default html5 player on an mp3 file, which didn'= t work before (you can see in the browser console it says mpeg is unsupport= ed) and worked after applying the patch (and no more erron in the console)= =2E From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 23 06:50:44 2019 Received: (at 38670-done) by debbugs.gnu.org; 23 Dec 2019 11:50:44 +0000 Received: from localhost ([127.0.0.1]:50600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijMEV-0001gs-Gl for submit@debbugs.gnu.org; Mon, 23 Dec 2019 06:50:43 -0500 Received: from lepiller.eu ([89.234.186.109]:41880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijMER-0001gh-Gx for 38670-done@debbugs.gnu.org; Mon, 23 Dec 2019 06:50:40 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id f045ea9e for <38670-done@debbugs.gnu.org>; Mon, 23 Dec 2019 11:50:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=9A8dE6k8KVJN FhxGkGLdNpoTv0w=; b=SbGf0eXOFDoI3BsNjlLQ+4U/g7oqXolWZGSDQ62znYg4 WDLArhHW/EIGalkGBj0ImtLFc1PnTwKAO351ZGTo959JojI4jpv0EBIwUjv2+bO2 1pa5Wkl/FPxUBAzmjfTkTZi0TJsUwSd4fosIg3lvXThudP7rdvwAIznZA3CUB8OG aSvJ2DRATsyjG3A6YOqWMr/BRlOBaBvp0jU28C/wAC306vDNItqWMG1HAlEufqyc mzh5YOOdOIOtHUgIoY7cMuuRgSAAGu96THYgUtSuKpYAIis77Qmz3/kmWhtt1je/ qYS1c7NIr3xirf0+SdxulMWH7Z0dGWE09yn0BLFCQg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 84535287 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <38670-done@debbugs.gnu.org>; Mon, 23 Dec 2019 11:50:36 +0000 (UTC) Date: Mon, 23 Dec 2019 12:50:32 +0100 From: Julien Lepiller To: 38670-done@debbugs.gnu.org Subject: Re: [bug#38670] [PATCH] Fix audio/video in icecat Message-ID: <20191223125032.086d7ab2@sybil.lepiller.eu> In-Reply-To: <20191219145922.715720ad@sybil.lepiller.eu> References: <20191219145922.715720ad@sybil.lepiller.eu> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38670-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed Mark's version as 8e5567195f5d29301d571612085b5afdb460619d. From unknown Thu Jun 19 14:05:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Jan 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator