GNU bug report logs - #38665
[PATCH] Add nosqueeze for fill-paragraph

Previous Next

To reply to this bug, email your comments to 38665 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jefferson Carpenter <jefferson <at> aoeu2code.com>
To: "bug-gnu-emacs" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Add nosqueeze for fill-paragraph
Date: Wed, 18 Dec 2019 22:29:22 +0000

[Message part 1 (text/plain, inline)]

Just added this patch for myself, thought I would pass it along for comments and/or for merging should you think it a good idea.



Use case: I'm writing markdown text that goes something like 



    Outputs a 12-character string  blah blah blah blah or if blah blah blah, returns `"            "`.



In which the markdown contains a literal string with 12 spaces.  When I run fill-paragraph on that, the spaces get collapsed down to 1 space, so I added a customization option to keep the 12-space string unchanged.



Jefferson

[Message part 2 (text/html, inline)]

[0001-Add-nosqueeze-for-fill-paragraph.patch (application/octet-stream, attachment)]

Message #10 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Jefferson Carpenter <jefferson <at> aoeu2code.com>
Cc: 38665 <at> debbugs.gnu.org
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Mon, 18 May 2020 21:13:27 -0700

Jefferson Carpenter <jefferson <at> aoeu2code.com> writes:

> Just added this patch for myself, thought I would pass it along for comments and/or for merging should you think it a good idea.
>
> Use case: I'm writing markdown text that goes something like
>
>     Outputs a 12-character string blah blah blah blah or if blah blah blah, returns `"            "`.
>
> In which the markdown contains a literal string with 12 spaces.  When I run fill-paragraph on that, the spaces get collapsed down to 1 space, so I added a customization option to keep the 12-space string unchanged.

Thanks for the patch, and sorry for the much the delayed response.

I think this could go in, if some people find it useful.

Any other opinions?

Best regards,
Stefan Kangas

Message #13 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 38665 <at> debbugs.gnu.org, jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Tue, 19 May 2020 17:15:50 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Mon, 18 May 2020 21:13:27 -0700
> Cc: 38665 <at> debbugs.gnu.org
> 
> > Use case: I'm writing markdown text that goes something like
> >
> >     Outputs a 12-character string blah blah blah blah or if blah blah blah, returns `"            "`.
> >
> > In which the markdown contains a literal string with 12 spaces.  When I run fill-paragraph on that, the spaces get collapsed down to 1 space, so I added a customization option to keep the 12-space string unchanged.
> 
> Thanks for the patch, and sorry for the much the delayed response.
> 
> I think this could go in, if some people find it useful.

It sounds strange to me to have a defcustom for this.  Are you saying
that you want this no-squeeze variant for all or many M-q commands or
for prolonged periods of time?  It sounds like a one-off feature, so
perhaps some special value of the prefix argument, like zero or maybe
"C-u C-u", would be a better UI, as that would allow one to activate
this option for a specific command.

Message #16 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 38665 <at> debbugs.gnu.org, jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Tue, 19 May 2020 07:22:15 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> It sounds like a one-off feature, so perhaps some special value of the
> prefix argument, like zero or maybe "C-u C-u", would be a better UI,
> as that would allow one to activate this option for a specific
> command.

Agreed.  Jefferson, would you like to work on an updated patch?

Best regards,
Stefan Kangas

Message #19 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 38665 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Wed, 20 May 2020 11:59:02 +1200

On 2020-05-20 02:22, Stefan Kangas wrote:
> Eli Zaretskii <eliz <at> gnu.org> writes:
>> It sounds like a one-off feature, so perhaps some special value of
>> the prefix argument, like zero or maybe "C-u C-u", would be a
>> better UI, as that would allow one to activate this option for a
>> specific command.
> 
> Agreed.  Jefferson, would you like to work on an updated patch?

To complicate things slightly, I have a patch languishing in my
"get back to at some point" pile for enhancing the use of prefix
arguments when filling text:

https://lists.gnu.org/r/emacs-devel/2016-11/msg00300.html

Reviewing that thread, employing C-u C-u arose:
https://lists.gnu.org/r/emacs-devel/2016-11/msg00313.html

My suggestion there for C-u C-u was:

>>> That could mean "prompt for the fill-prefix, and use the default
>>> column and justify values", but it might be more useful to instead
>>> make it prompt for *everything* -- justify, fill-column,
>>> fill-prefix, and maybe left-margin too.
>>> 
>>> The default value would be provided in each case, so you could
>>> just RET your way past the ones you didn't want to change.

I think we could blend the 'nosqueeze' option into all this, but if
the new changes could happen in a way which wouldn't create any serious
conflicts for the other changes I'm still hoping to get made, that
would be grand.

Or if someone is motivated, please feel free to run with what I'd
already done.  I may have some more-recent local WIP on my other
machine; I'll have a look for that later.


-Phil

Message #24 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Phil Sainty <psainty <at> orcon.net.nz>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 38665 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Thu, 21 May 2020 13:51:04 +1200

On 2020-05-20 11:59, Phil Sainty wrote:
> I may have some more-recent local WIP on my other machine;
> I'll have a look for that later.

Having checked this, I do have a fairly sizeable WIP diff
against my initial patch, and it all still applies with
only one minor context change.  That's all I've checked
though -- I haven't tried to work out exactly where I got
to with the changes, or which problems still needed to be
figured out.

The additional changes are very much WIP and messy, so
there's not a nice patch to put anywhere; but if someone
is interested in actively working on this feature in the
near future, and didn't mind picking through some mess,
then let me know.

-Phil

Message #27 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Phil Sainty <psainty <at> orcon.net.nz>
Cc: 38665 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 jefferson <at> aoeu2code.com, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Thu, 01 Oct 2020 04:44:26 +0200

Phil Sainty <psainty <at> orcon.net.nz> writes:

> My suggestion there for C-u C-u was:
>
>>>> That could mean "prompt for the fill-prefix, and use the default
>>>> column and justify values", but it might be more useful to instead
>>>> make it prompt for *everything* -- justify, fill-column,
>>>> fill-prefix, and maybe left-margin too.
>>>> The default value would be provided in each case, so you could
>>>> just RET your way past the ones you didn't want to change.
>
> I think we could blend the 'nosqueeze' option into all this, but if
> the new changes could happen in a way which wouldn't create any serious
> conflicts for the other changes I'm still hoping to get made, that
> would be grand.
>
> Or if someone is motivated, please feel free to run with what I'd
> already done.  I may have some more-recent local WIP on my other
> machine; I'll have a look for that later.

I think the idea is sound -- there's so many variations of what you'd
possibly want this command to do, so prompting seems good: Neither user
options nor adding more prefix combinations would help, I think.

If you could finish up the WIP and post the patch, that'd be great.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #30 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Phil Sainty <psainty <at> orcon.net.nz>, 38665 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>, jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Thu, 24 Nov 2022 17:36:48 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Phil Sainty <psainty <at> orcon.net.nz> writes:
>
>> My suggestion there for C-u C-u was:
>>
>>>>> That could mean "prompt for the fill-prefix, and use the default
>>>>> column and justify values", but it might be more useful to instead
>>>>> make it prompt for *everything* -- justify, fill-column,
>>>>> fill-prefix, and maybe left-margin too.
>>>>> The default value would be provided in each case, so you could
>>>>> just RET your way past the ones you didn't want to change.
>>
>> I think we could blend the 'nosqueeze' option into all this, but if
>> the new changes could happen in a way which wouldn't create any serious
>> conflicts for the other changes I'm still hoping to get made, that
>> would be grand.
>>
>> Or if someone is motivated, please feel free to run with what I'd
>> already done.  I may have some more-recent local WIP on my other
>> machine; I'll have a look for that later.
>
> I think the idea is sound -- there's so many variations of what you'd
> possibly want this command to do, so prompting seems good: Neither user
> options nor adding more prefix combinations would help, I think.
>
> If you could finish up the WIP and post the patch, that'd be great.

That was 2 years ago.  Phil, did you make any progress with your patch?

Message #33 received at 38665 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Phil Sainty <psainty <at> orcon.net.nz>, 38665 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>, jefferson <at> aoeu2code.com
Subject: Re: bug#38665: [PATCH] Add nosqueeze for fill-paragraph
Date: Wed, 10 Jan 2024 14:16:56 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> Phil Sainty <psainty <at> orcon.net.nz> writes:
>>
>>> My suggestion there for C-u C-u was:
>>>
>>>>>> That could mean "prompt for the fill-prefix, and use the default
>>>>>> column and justify values", but it might be more useful to instead
>>>>>> make it prompt for *everything* -- justify, fill-column,
>>>>>> fill-prefix, and maybe left-margin too.
>>>>>> The default value would be provided in each case, so you could
>>>>>> just RET your way past the ones you didn't want to change.
>>>
>>> I think we could blend the 'nosqueeze' option into all this, but if
>>> the new changes could happen in a way which wouldn't create any serious
>>> conflicts for the other changes I'm still hoping to get made, that
>>> would be grand.
>>>
>>> Or if someone is motivated, please feel free to run with what I'd
>>> already done.  I may have some more-recent local WIP on my other
>>> machine; I'll have a look for that later.
>>
>> I think the idea is sound -- there's so many variations of what you'd
>> possibly want this command to do, so prompting seems good: Neither user
>> options nor adding more prefix combinations would help, I think.
>>
>> If you could finish up the WIP and post the patch, that'd be great.
>
> That was 2 years ago.  Phil, did you make any progress with your patch?

Friendly "one year later" ping.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.