From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2019 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38632@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.157647868532130 (code B ref -1); Mon, 16 Dec 2019 06:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Dec 2019 06:44:45 +0000 Received: from localhost ([127.0.0.1]:37661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igk7Y-0008M8-Pf for submit@debbugs.gnu.org; Mon, 16 Dec 2019 01:44:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:35832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igk7X-0008Lw-1D for submit@debbugs.gnu.org; Mon, 16 Dec 2019 01:44:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60086) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igk7V-0006H3-Qx for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 01:44:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igk7U-0005Wb-Om for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 01:44:41 -0500 Received: from mail-yw1-xc2e.google.com ([2607:f8b0:4864:20::c2e]:45829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igk7U-0005WK-JX for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2019 01:44:40 -0500 Received: by mail-yw1-xc2e.google.com with SMTP id d7so1425401ywl.12 for ; Sun, 15 Dec 2019 22:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=pQvqq/O8fpnpAY2Nzt+dO1uIQIM4BAJ2LvuYV9TQlp0=; b=ZvRBgOU8QeoSnjHWPecKvmjF7v2BRCXCZsPBu5b2XaKNKn0o/0U6jVfRoZ249ZiheL pPQsoQZiu6HkYgR3GJmCaiJoZ0wHqXzmq5LreQAdeeQy5HsGnOebzOa6hFOpI/+se4yB RgE5wJWE44lWhHaR9Bx7/iQex2ANZKhZS4S/IltJK1G/poyp5M/fGSmAShCDYx1LyCS9 QRMZjygtejoyxish+S5OVAruCA0fFhuZXAKzS9EmfE5SRB/Euc2yr5wxy25/CJF5FCum HMzSpvO9y9UhpvvWXA/hQ54lpFNO1XB9+pz80TGPqPWF8Pgxx5kGIIAXoRs6KLsn7NUg 1f1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=pQvqq/O8fpnpAY2Nzt+dO1uIQIM4BAJ2LvuYV9TQlp0=; b=QG2QyIeQPzldPpmhDG2SpQ+DbJaANWeykTrBPieYpALh3ns9A7r96ucnAHmih+RsHm fzHcmD8q4UYPdlQh/pfVYb1/pBKRgz5VK75Wp45+xW0yRpu7kPreWkgqUnGIeELYxPSo OgdwxEvOa2bqHcokyaZMRRkTqA4YixF3myseFVF3kIo8qFYnzqv+KnFK55032R4AvecC gEfeNjLce2UGB10iqJ384oAHuOt4UVB+ktK+bWUBDq1UDAFPcxJptSG9WKzsg09hvADt IWU6d1vjFjf5WYdsU+GF+wodit9V81oA1wwnohVqR2lnooc8dEKla9chjPbXi3NVLcXF Ih+g== X-Gm-Message-State: APjAAAWNT+/EX/riQVvTrvVc6YgImEq54yQpUG3FZPuvsFXtJwD6E/Ie sud7Wol6WFOD5pk6aCD0bX1UnOx1zwKYbw== X-Google-Smtp-Source: APXvYqw50xWhXDHHySqK0MxAQ2DNEPijwOtOXi7tkOk68IG8K+SMbOajrt+VFIx/FYvPz6pY/FEhJg== X-Received: by 2002:a81:9bc2:: with SMTP id s185mr18052335ywg.55.1576478679371; Sun, 15 Dec 2019 22:44:39 -0800 (PST) Received: from localhost ([5.226.137.4]) by smtp.gmail.com with ESMTPSA id o69sm7429205ywd.38.2019.12.15.22.44.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 22:44:38 -0800 (PST) From: Ihor Radchenko Date: Mon, 16 Dec 2019 14:42:38 +0800 Message-ID: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c2e X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Observed behaviour: When I try to create a named thread like (make-thread (lambda () (+ 1 2)) "test-emacs-async") the emacs process gets renamed to "test-emacs-async" even after the thread returns. Making another thread with different name renames emacs process again. Expected behaviour: Emacs process name remains unchanged. Note: by process name, I mean "COMMAND" field in top output. Best, Ihor In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0) of 2019-12-16 built on yantar92-laptop Repository revision: 7254b6346229a7b71b69f71e2d8eee113f02585a Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12005000 System Description: Gentoo/Linux From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Dec 2019 20:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ihor Radchenko Cc: 38632@debbugs.gnu.org Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.15766131738036 (code B ref 38632); Tue, 17 Dec 2019 20:07:02 +0000 Received: (at 38632) by debbugs.gnu.org; 17 Dec 2019 20:06:13 +0000 Received: from localhost ([127.0.0.1]:42411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihJ6i-00025Y-Ty for submit@debbugs.gnu.org; Tue, 17 Dec 2019 15:06:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihJ6h-00025M-Cq for 38632@debbugs.gnu.org; Tue, 17 Dec 2019 15:06:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihJ6c-0000Ax-AP; Tue, 17 Dec 2019 15:06:06 -0500 Received: from [176.228.60.248] (port=2516 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihJ6b-0006V3-AB; Tue, 17 Dec 2019 15:06:05 -0500 Date: Tue, 17 Dec 2019 22:05:52 +0200 Message-Id: <83y2va3efz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> (message from Ihor Radchenko on Mon, 16 Dec 2019 14:42:38 +0800) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Date: Mon, 16 Dec 2019 14:42:38 +0800 > > When I try to create a named thread like > > (make-thread (lambda () (+ 1 2)) "test-emacs-async") > > the emacs process gets renamed to "test-emacs-async" even after the > thread returns. Making another thread with different name renames emacs > process again. I think, instead of calling prctl in systhread.c, we should call pthread_set_name_np, and the configure-time test for prctl should be replaced with a test for pthread_set_name_np. Patches welcome. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, Ihor Radchenko Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.15766599724653 (code B ref 38632); Wed, 18 Dec 2019 09:07:01 +0000 Received: (at 38632) by debbugs.gnu.org; 18 Dec 2019 09:06:12 +0000 Received: from localhost ([127.0.0.1]:42662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihVHX-0001Cz-M6 for submit@debbugs.gnu.org; Wed, 18 Dec 2019 04:06:11 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:40504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihVHS-0001CP-It for 38632@debbugs.gnu.org; Wed, 18 Dec 2019 04:06:10 -0500 Received: by mail-wr1-f46.google.com with SMTP id c14so1369105wrn.7 for <38632@debbugs.gnu.org>; Wed, 18 Dec 2019 01:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=DFu2sGFf2G91Xoxx0XtU6y1LrGi9l9MgMHNmQJe8GM8=; b=bBCEWPtOZpG8A6kQulR0cxFzBBUbJSrOk3dKAOVtSgKGCb0ZiwEX6iG42QsQiTE5Mu tozimzxsv000sgbq8TmQpX+SBzN1rejct6oneil7Exd1mHxrDzPyawn9J90MVJfZrg+Y BPRyiYQQVcLvJBaXV7P7z6oFtpgr9jui4zj1zGxZBn7ooQ8nXKGz5BQv4Gx6iC3T7WQX g8jmfhdrsrdpw0cUol+vRwDwD12+dH6KkxRrF+rX3Rn2HobkJhOC7AqpbB9PfI8V2HAR nPg7SuntyxJQMtHL5JKZoUF64MWAUdrG864VQbGaOc+gnhIupEzLz6BFuMnJ7ipegqNp uwuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=DFu2sGFf2G91Xoxx0XtU6y1LrGi9l9MgMHNmQJe8GM8=; b=CCE70mB+PFOpfTU4VI7rvFeTH/MAB+z1uWIEDHrhq4unMB395sPdXc4+ZIuAl/ZuXF 5xUsnqqOkv8rtoOA5UtYlXnCGBuQOjIxxN+HDOgrdMpMTNvPxpTBVZbb6DuRmO+XIC/5 2oltxHVzOs9HzGaK6IaXFrZZolzEXpitHdFe8La1ug3vgDT+eIEtT6vFDRCRSd9NWhYz 5QaTbJFk0dk275p55BQAZ0QI3pdhPJS2U0A18lgQBU+s6YYXzR3jXzXcP3N10eQH5Hdl avj3W1EzrS8JU1rqGNCjNVh7f1j73fa7WNjUxjZf1DTDwe99v/0CfsiSDQzJ1ncndyNR Qh2g== X-Gm-Message-State: APjAAAWQG2Nf6kz1R/sZqujYIhiixoma9+m0TOds+57ITE5QcFlzywza M+uDSirrp8jLTFm97cTL+qI//ipl4Mk= X-Google-Smtp-Source: APXvYqySVMwjeHIOuVe5iRo+rIc7cBsCr/f6H4akj3ea8TvBTdZPGdsTo9rRo8eaGRSQf9T0Jqhlkg== X-Received: by 2002:a5d:670a:: with SMTP id o10mr1552448wru.227.1576659960416; Wed, 18 Dec 2019 01:06:00 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id t25sm1691531wmj.19.2019.12.18.01.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 01:05:59 -0800 (PST) From: Robert Pluim References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> Gmane-Reply-To-List: yes Date: Wed, 18 Dec 2019 10:05:58 +0100 In-Reply-To: <83y2va3efz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 17 Dec 2019 22:05:52 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 17 Dec 2019 22:05:52 +0200, Eli Zaretskii said: >> From: Ihor Radchenko >> Date: Mon, 16 Dec 2019 14:42:38 +0800 >> >> When I try to create a named thread like >> >> (make-thread (lambda () (+ 1 2)) "test-emacs-async") >> >> the emacs process gets renamed to "test-emacs-async" even after the >> thread returns. Making another thread with different name renames emacs >> process again. Eli> I think, instead of calling prctl in systhread.c, we should call Eli> pthread_set_name_np, and the configure-time test for prctl should be Eli> replaced with a test for pthread_set_name_np. Would it not be easier to call prctl in the context of the created thread? That way it deals with the name length issues for us: pthread_setname_np fails if strlen(name) >= 16, wherease prctl truncates. Robert From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157668444819254 (code B ref 38632); Wed, 18 Dec 2019 15:55:02 +0000 Received: (at 38632) by debbugs.gnu.org; 18 Dec 2019 15:54:08 +0000 Received: from localhost ([127.0.0.1]:43807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihbeJ-00050U-Mk for submit@debbugs.gnu.org; Wed, 18 Dec 2019 10:54:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihbeI-0004zy-Ej for 38632@debbugs.gnu.org; Wed, 18 Dec 2019 10:54:06 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihbeC-0004Wh-4w; Wed, 18 Dec 2019 10:54:00 -0500 Received: from [176.228.60.248] (port=2797 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihbeB-0001LT-BP; Wed, 18 Dec 2019 10:53:59 -0500 Date: Wed, 18 Dec 2019 17:53:49 +0200 Message-Id: <83v9qd3a0i.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Wed, 18 Dec 2019 10:05:58 +0100) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Ihor Radchenko , 38632@debbugs.gnu.org > Date: Wed, 18 Dec 2019 10:05:58 +0100 > > Eli> I think, instead of calling prctl in systhread.c, we should call > Eli> pthread_set_name_np, and the configure-time test for prctl should be > Eli> replaced with a test for pthread_set_name_np. > > Would it not be easier to call prctl in the context of the created > thread? That way it deals with the name length issues for us: > pthread_setname_np fails if strlen(name) >= 16, wherease prctl > truncates. AFAIU, prctl is Linux-specific, whereas pthread_setname_np is supported on other Posix platforms that provide pthreads. Also, prctl has another disadvantage, in that it requires you to pass the name to the thread being created, or put it in some global. OTOH, truncating a string is not exactly rocket science, we can do that ourselves before calling the API. (Btw, the limitation is 16 bytes, including the terminating null, so truncation needs to be clever about non-ASCII characters, and I wonder what does prctl do when 15 bytes end in the middle of a multibyte sequence.) From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157668870526251 (code B ref 38632); Wed, 18 Dec 2019 17:06:02 +0000 Received: (at 38632) by debbugs.gnu.org; 18 Dec 2019 17:05:05 +0000 Received: from localhost ([127.0.0.1]:43863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihckz-0006pL-4R for submit@debbugs.gnu.org; Wed, 18 Dec 2019 12:05:05 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:38895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihckw-0006ol-T0 for 38632@debbugs.gnu.org; Wed, 18 Dec 2019 12:05:03 -0500 Received: by mail-wr1-f52.google.com with SMTP id y17so3113475wrh.5 for <38632@debbugs.gnu.org>; Wed, 18 Dec 2019 09:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=KHr8kubl1Nk70vn5k+LxI4mzeyBFagxBVHGMdbqHYic=; b=CF9frTYfuMKiklD48vivv8Px95fRxo5TW9neI1nP6GMNrm4LYH4yRI8li7lBDKUk7P b7HMZrH7p7JkzB9hkVJBOn5r61LlXJOlYKUoZiDokyE3J3FneOusxJvYU5JpO0x86cNr ZvE+LWeUrOLgUbqL0RucRjQuhQrUzME6auMhguddqTphqfZBqkjCtdOMUyUziM3H3GU9 s+QcyX60WbJ0FJqrlNBF0GmQYm5FZ+e9Etu9ZbCenVa4SfEQRIcWBXFVL2DCofnymNIh EN1DIepo5Q8Lkw5X2wtKKv8ji1q9+T1+zXfc5e+Q9WvwnCCQOGDevhN69qPlEVrUScCK k1wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=KHr8kubl1Nk70vn5k+LxI4mzeyBFagxBVHGMdbqHYic=; b=Pn0dHhrQTfqZbWAIKs3O3WwCBPZxHd4wSn4fvGVwyOlsTw3OTXYTLWOlvZvWPV28TN XFt5fTaR9DOvqsmDW8xsIuB+ukZY8PKeIKM/wo/y1Q3JyGTVxbDoArgXlco69KzWeJVW gBuCkYP6+WofXE4/5o0/h/iFRrsO2NkWygE126CfGI916MI7oLBl0uoZ/0HzO1fEg+RV dyO+ucD4Fj1m5WL0C+4w3HvG/GDpRsZ+jV4L5XI4+oiaywBSOYoFwjhMIuF0go/CfOfL T5T7u6OZswoywvRf76kd19jedD5WH2vyZ7/sE7RFQWZYIIAKZr+g+MZwsfkYlViHpyn9 O0Yw== X-Gm-Message-State: APjAAAWhAVHFvPjHw3yk0dJffOwqgbT96fYVTLYCo+rlpii/wkH6aR2v ltZtqPD4idNrvA7PEYkYeFI+U2iqLBk= X-Google-Smtp-Source: APXvYqw9JpHkh1xxf5W9cuVMp9K9xfLEGTnjLZDY3x3WNWm7PHrRLiOm8+haR+qB6dwdgP1XlxlmzA== X-Received: by 2002:a5d:4dc9:: with SMTP id f9mr3696645wru.297.1576688695567; Wed, 18 Dec 2019 09:04:55 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id c5sm3114796wmb.9.2019.12.18.09.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 09:04:54 -0800 (PST) From: Robert Pluim References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> Date: Wed, 18 Dec 2019 18:04:53 +0100 In-Reply-To: <83v9qd3a0i.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Dec 2019 17:53:49 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 18 Dec 2019 17:53:49 +0200, Eli Zaretskii said: Eli> AFAIU, prctl is Linux-specific, whereas pthread_setname_np is Eli> supported on other Posix platforms that provide pthreads. Also, p= rctl Eli> has another disadvantage, in that it requires you to pass the name= to Eli> the thread being created, or put it in some global. OTOH, truncat= ing Eli> a string is not exactly rocket science, we can do that ourselves Eli> before calling the API. We already use a wrapper function to call the user-supplied function, so prctl could be added there, but the wider availability of pthread_setname_np weighs in its favour. Eli> (Btw, the limitation is 16 bytes, including the terminating null, = so Eli> truncation needs to be clever about non-ASCII characters, and I wo= nder Eli> what does prctl do when 15 bytes end in the middle of a multibyte Eli> sequence.) It does exactly what you'd expect, it drops the extraneous bytes, so putting eg =C3=BC on the boundary results in a name ending in =C3=83 (#xc3). In any case, if emacs or prctl truncates, then the name as reported by 'list-threads' will be out of sync with pthread_getname_np, unless you'd want to adjust that too. Robert From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157668956227615 (code B ref 38632); Wed, 18 Dec 2019 17:20:01 +0000 Received: (at 38632) by debbugs.gnu.org; 18 Dec 2019 17:19:22 +0000 Received: from localhost ([127.0.0.1]:43872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihcyn-0007BL-NR for submit@debbugs.gnu.org; Wed, 18 Dec 2019 12:19:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihcym-0007B7-PV for 38632@debbugs.gnu.org; Wed, 18 Dec 2019 12:19:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihcyc-0000AS-Pw; Wed, 18 Dec 2019 12:19:13 -0500 Received: from [176.228.60.248] (port=4014 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihcyZ-0005HO-SK; Wed, 18 Dec 2019 12:19:08 -0500 Date: Wed, 18 Dec 2019 19:18:57 +0200 Message-Id: <83mubp362m.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Wed, 18 Dec 2019 18:04:53 +0100) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: yantar92@gmail.com, 38632@debbugs.gnu.org > Date: Wed, 18 Dec 2019 18:04:53 +0100 > > Eli> (Btw, the limitation is 16 bytes, including the terminating null, so > Eli> truncation needs to be clever about non-ASCII characters, and I wonder > Eli> what does prctl do when 15 bytes end in the middle of a multibyte > Eli> sequence.) > > It does exactly what you'd expect, it drops the extraneous bytes, so > putting eg ü on the boundary results in a name ending in à (#xc3). So it is one more reason to do or own truncation, so we do it right. > In any case, if emacs or prctl truncates, then the name as reported > by 'list-threads' will be out of sync with pthread_getname_np, unless > you'd want to adjust that too. We need to truncate the names we store in the thread object (and document that). From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 21:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157670462512414 (code B ref 38632); Wed, 18 Dec 2019 21:31:01 +0000 Received: (at 38632) by debbugs.gnu.org; 18 Dec 2019 21:30:25 +0000 Received: from localhost ([127.0.0.1]:44036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihgtk-0003E9-RO for submit@debbugs.gnu.org; Wed, 18 Dec 2019 16:30:25 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:34788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihgti-0003Dv-LP for 38632@debbugs.gnu.org; Wed, 18 Dec 2019 16:30:23 -0500 Received: by mail-wr1-f48.google.com with SMTP id t2so3871479wrr.1 for <38632@debbugs.gnu.org>; Wed, 18 Dec 2019 13:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Q85kKO8bmJAewJV5rggKuZ/C47xDfccRO9YEOu2XoDc=; b=GJdZAcE1kEY9h3RiPZ4KAj9/TVdAXpkfVQ3EK4x35ijjEHsjxGCWuoWoKntuj1JHfK mNsomvE9bwVTGGhEzg2krmJnPj0XE1NvWUjqz4gSpcYa1xJ8Tmv7EfK3QWSTsqKEYbgv ujHf5bi5sK1w3F1LEb06Dn4Y/xmpoBy9+N4Ti9bI9puv+Tt3Pbu93z2HdsK2ZnA6cuNR 1KToAEzKGFWpF4g6/pTwPQBoEvwbPdZUJBaEeEapbCA2Oj3kpJjWoXxklK0FxZvDknj8 7gIJGpRMQa4qF3Jpem43LsoW9TgnaxP23ug+N6AuKDuHQQUaJV6mUP2LXcPk74L6r0ar KDDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=Q85kKO8bmJAewJV5rggKuZ/C47xDfccRO9YEOu2XoDc=; b=jtfhGXciQrZaQjgbAxHHttJmo/2lRLOlsEc+qYQPSpmbDzPz0qhAub31JZAvcfKV/t EbI0VNoCeZsMzKqAN4PnsY4ZRviWnwj1Wr7dojkITPSSSwnsps5SAvn4IzXHXmgaO89N yT5DbH6usmEaGWnWEMRmX0jTnFimsz9Z7yt6wPGrludD6ZmP33ZtemWHfR+i0/pBHwSu 09ZnAke8lSqdec7tkoPoAnv1HHDS32gr8n9FmzkHb5RCCQtKpACczJAf5ikzj6cl1Hdh LWxOcF2yhpWUjZfx8rISKfM9fJlGsvKAPyYIZesVYqKKjZZYxosU6QC/ur7uM5XdQlIq fC9g== X-Gm-Message-State: APjAAAVdlluMiKDq8SunD8KZNm0echI6xDPBr3kKoLuCWqOLwDbo/l6i BcjiG+VctVu+SN8g8HimkfM= X-Google-Smtp-Source: APXvYqzjRRGRioCLIkRqO2l8X8CNxdxKM6W/KIxbgDW+shIMAqyg55WwlHy76cHvhlGXiIggpwmCQQ== X-Received: by 2002:adf:fe8c:: with SMTP id l12mr4821362wrr.215.1576704616592; Wed, 18 Dec 2019 13:30:16 -0800 (PST) Received: from rpluim-mac ([2a01:e34:ecfc:a860:31d4:e642:d23e:967c]) by smtp.gmail.com with ESMTPSA id 60sm4075997wrn.86.2019.12.18.13.30.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2019 13:30:15 -0800 (PST) From: Robert Pluim References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> Gmane-Reply-To-List: yes Date: Wed, 18 Dec 2019 22:30:14 +0100 In-Reply-To: <83mubp362m.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 18 Dec 2019 19:18:57 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 18 Dec 2019 19:18:57 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: yantar92@gmail.com, 38632@debbugs.gnu.org >> Date: Wed, 18 Dec 2019 18:04:53 +0100 >>=20 Eli> (Btw, the limitation is 16 bytes, including the terminating null, = so Eli> truncation needs to be clever about non-ASCII characters, and I wo= nder Eli> what does prctl do when 15 bytes end in the middle of a multibyte Eli> sequence.) >>=20 >> It does exactly what you'd expect, it drops the extraneous bytes, so >> putting eg =C3=BC on the boundary results in a name ending in =C3=83= (#xc3). Eli> So it is one more reason to do or own truncation, so we do it righ= t. OK. Is there a useful function that would help for that? I can cook up something based on NEXT_CHAR_BOUNDARY and/or BYTES_BY_CHAR_HEAD, but I=CA= =BCd expect there to be something already. >> In any case, if emacs or prctl truncates, then the name as reported >> by 'list-threads' will be out of sync with pthread_getname_np, unless >> you'd want to adjust that too. Eli> We need to truncate the names we store in the thread object (and Eli> document that). That=CA=BCs the easy part. I=CA=BCm assuming mswindows doesn=CA=BCt truncat= e. Robert From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2019 15:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.15767683005550 (code B ref 38632); Thu, 19 Dec 2019 15:12:01 +0000 Received: (at 38632) by debbugs.gnu.org; 19 Dec 2019 15:11:40 +0000 Received: from localhost ([127.0.0.1]:45388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihxSm-0001RR-Bu for submit@debbugs.gnu.org; Thu, 19 Dec 2019 10:11:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihxSl-0001RF-67 for 38632@debbugs.gnu.org; Thu, 19 Dec 2019 10:11:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihxSf-00017w-SK; Thu, 19 Dec 2019 10:11:33 -0500 Received: from [176.228.60.248] (port=4824 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihxSf-0000hx-24; Thu, 19 Dec 2019 10:11:33 -0500 Date: Thu, 19 Dec 2019 17:11:24 +0200 Message-Id: <8336dg2vvn.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Wed, 18 Dec 2019 22:30:14 +0100) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 38632@debbugs.gnu.org, yantar92@gmail.com > Date: Wed, 18 Dec 2019 22:30:14 +0100 > > >> It does exactly what you'd expect, it drops the extraneous bytes, so > >> putting eg ü on the boundary results in a name ending in à (#xc3). > > Eli> So it is one more reason to do or own truncation, so we do it right. > > OK. Is there a useful function that would help for that? I can cook up > something based on NEXT_CHAR_BOUNDARY and/or BYTES_BY_CHAR_HEAD, but Iʼd > expect there to be something already. No, the above two and their ilk (PREV_CHAR_BOUNDARY etc.) are what we use. > >> In any case, if emacs or prctl truncates, then the name as reported > >> by 'list-threads' will be out of sync with pthread_getname_np, unless > >> you'd want to adjust that too. > > Eli> We need to truncate the names we store in the thread object (and > Eli> document that). I think I'm going to change my mind on that. The complication here is that the name should be encoded by ENCODE_SYSTEM before we pass it to pthread_setname_np etc., and if the locale-coding-system is not UTF-8 and not single-byte, we don't really know where a character will end after encoding. And encoding one character at a time sounds too gross. So perhaps we should just truncate the bytes, and leave this to the application to make sure the result makes sense, and also disregard the difference between list-threads and the thread name as the OS and debuggers see it. Doing that will also avoid the complication of having the thread name return to the caller different from what the caller used. WDYT? > Iʼm assuming mswindows doesnʼt truncate. MS-Windows currently doesn't support setting thread names at all; maybe I'll write something soon to fix that. But yes, I cannot find any documentation stating any limits there. GDB on Windows reads the first 1024 bytes of the thread name, so maybe we should document that this is the recommended maximum on any platform. Thanks. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2019 16:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157677377522752 (code B ref 38632); Thu, 19 Dec 2019 16:43:02 +0000 Received: (at 38632) by debbugs.gnu.org; 19 Dec 2019 16:42:55 +0000 Received: from localhost ([127.0.0.1]:45456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihyt5-0005ut-0d for submit@debbugs.gnu.org; Thu, 19 Dec 2019 11:42:55 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:39008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihyt0-0005ua-9p for 38632@debbugs.gnu.org; Thu, 19 Dec 2019 11:42:53 -0500 Received: by mail-wr1-f45.google.com with SMTP id y11so6659314wrt.6 for <38632@debbugs.gnu.org>; Thu, 19 Dec 2019 08:42:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:mime-version; bh=rss0myROeTiubFL8+ytZn1uac4VP46HCS4d6OGI8AGA=; b=CCD9qGD19G3KCq26DDFDimBcEV3pLZCVEbVBc04bH+EI8DVA+0WVWFblmvpcVHGVmI 4tBSYzwNKx13jkPYmNmNTWRUO+jDrIbjaez+k4e9bij5wEO9D5adoPGJMzQV0hBatUTO MwtxhvKj0WWimdpWC7CyK/1uHnbOnhh6AB+5SbGCaVdrwxI6Xn3epagR+gxId1KJwNv4 ho7HvTtthNVnAQtXpqkzWxuOCyzil5W0JvHNyJIsjwRv7+iL6rLq9V3CCFoIv8U8akM8 BSFc56lBwovUNj/cCVWyp6g/ZPmOabPtaaOSDFPH/VImtLJjJugSydd5TDfWAeYG/1Ub PsWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=rss0myROeTiubFL8+ytZn1uac4VP46HCS4d6OGI8AGA=; b=uFbLU83ahBbiScVxEj2BNcSpe07VXbUBfXBERGRsU5amT3JNeXgdSF84AoEjKBcP6D K9P+JJvlAi2e6rS0pd4YGcspHUqSnok6v65WxGYpsoHuqGJq7jfP0zwdQ8hQPMtQmDrb 4XONR64DOwILDfrvuMNYoCkCAkXfztH539KnDp57yvbB0HMiD4OjsiuwAOJ0rTv5B3jZ gLCvLOnzdCfelPEEnubr7+lpDBcy25pMTG+R/fos+r7WDbujBNX9OAKj2Jwci8ZiF9pQ xJe2GBxnSh8sF+UDEVnzbAmQasFRpJl4QHBSJjxIwt+EZRzVZG5BG8ttz5Mv4apXB4Dz DltA== X-Gm-Message-State: APjAAAVsYJVRZ5stLJ1MrUwic/PdZ4Yipv5ykvuNKD7u93aruPJnC5iL UL/ZPfPidtAgAEyDsmvmJdI= X-Google-Smtp-Source: APXvYqzcRuy5LsNpEqXxzPoOgEkK7FTo7ludTLHtQ+X+6WY0vD3iZeLkxMmZ5qti4aIHyGy28RkwDg== X-Received: by 2002:a5d:4a91:: with SMTP id o17mr11041676wrq.232.1576773764243; Thu, 19 Dec 2019 08:42:44 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id 16sm6586480wmi.0.2019.12.19.08.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 08:42:43 -0800 (PST) From: Robert Pluim References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> <8336dg2vvn.fsf@gnu.org> Gmane-Reply-To-List: yes Date: Thu, 19 Dec 2019 17:42:41 +0100 In-Reply-To: <8336dg2vvn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 19 Dec 2019 17:11:24 +0200") Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Thu, 19 Dec 2019 17:11:24 +0200, Eli Zaretskii said: Eli> We need to truncate the names we store in the thread object (and Eli> document that). Eli> I think I'm going to change my mind on that. The complication her= e is Eli> that the name should be encoded by ENCODE_SYSTEM before we pass it= to Eli> pthread_setname_np etc., and if the locale-coding-system is not UT= F-8 Eli> and not single-byte, we don't really know where a character will e= nd Eli> after encoding. And encoding one character at a time sounds too Eli> gross. Eli> So perhaps we should just truncate the bytes, and leave this to the Eli> application to make sure the result makes sense, and also disregard Eli> the difference between list-threads and the thread name as the OS = and Eli> debuggers see it. Doing that will also avoid the complication of Eli> having the thread name return to the caller different from what the Eli> caller used. Here=CA=BCs what it looks like. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Use-pthread_setname_np-to-set-thread-name.patch >From bbb7e7837fcad3bac10aef69a1b331243c2b1c4c Mon Sep 17 00:00:00 2001 From: Robert Pluim Date: Thu, 19 Dec 2019 17:33:16 +0100 Subject: [PATCH] Use pthread_setname_np to set thread name * configure.ac: Remove check for sys/prctl.h and prctl, check for pthread_setname_np instead. * systhread.c: Remove sys/prctl.h include. (sys_thread_create) [HAVE_PTHREAD_SETNAME_NP]: Use pthread_setname_np to set the name of the newly created thread (Bug#38632). --- configure.ac | 4 ++-- src/systhread.c | 17 +++++++++++------ 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/configure.ac b/configure.ac index 3b6a2a6d16..34a2654494 100644 --- a/configure.ac +++ b/configure.ac @@ -1767,7 +1767,7 @@ AC_DEFUN sys/sysinfo.h coff.h pty.h sys/resource.h - sys/utsname.h pwd.h utmp.h util.h sys/prctl.h) + sys/utsname.h pwd.h utmp.h util.h) AC_CACHE_CHECK([for ADDR_NO_RANDOMIZE], [emacs_cv_personality_addr_no_randomize], @@ -4180,7 +4180,7 @@ AC_DEFUN sendto recvfrom getsockname getifaddrs freeifaddrs \ gai_strerror sync \ getpwent endpwent getgrent endgrent \ -cfmakeraw cfsetspeed __executable_start log2 prctl) +cfmakeraw cfsetspeed __executable_start log2 pthread_setname_np) LIBS=$OLD_LIBS dnl No need to check for posix_memalign if aligned_alloc works. diff --git a/src/systhread.c b/src/systhread.c index 6f4de536fb..55bde837e3 100644 --- a/src/systhread.c +++ b/src/systhread.c @@ -98,10 +98,6 @@ sys_thread_yield (void) #include -#ifdef HAVE_SYS_PRCTL_H -#include -#endif - void sys_mutex_init (sys_mutex_t *mutex) { @@ -227,9 +223,18 @@ sys_thread_create (sys_thread_t *thread_ptr, const char *name, if (!pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED)) { result = pthread_create (thread_ptr, &attr, func, arg) == 0; -#if defined (HAVE_SYS_PRCTL_H) && defined (HAVE_PRCTL) && defined (PR_SET_NAME) +#ifdef HAVE_PTHREAD_SETNAME_NP if (result && name != NULL) - prctl (PR_SET_NAME, name); + { + /* We need to truncate here otherwise pthread_setname_np + fails to set the name. TASK_COMM_LEN is what the length + is called in the Linux kernel headers (Bug#38632). */ +#define TASK_COMM_LEN 16 + char p_name[TASK_COMM_LEN]; + strncpy (p_name, name, TASK_COMM_LEN - 1); + p_name[TASK_COMM_LEN - 1] = '\0'; + pthread_setname_np (*thread_ptr, p_name); + } #endif } -- 2.23.0 --=-=-=-- From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Dec 2019 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.15767818102852 (code B ref 38632); Thu, 19 Dec 2019 18:57:02 +0000 Received: (at 38632) by debbugs.gnu.org; 19 Dec 2019 18:56:50 +0000 Received: from localhost ([127.0.0.1]:45509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii0yg-0000jv-CT for submit@debbugs.gnu.org; Thu, 19 Dec 2019 13:56:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ii0ye-0000jd-MI for 38632@debbugs.gnu.org; Thu, 19 Dec 2019 13:56:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ii0yZ-00033W-Cr; Thu, 19 Dec 2019 13:56:43 -0500 Received: from [176.228.60.248] (port=2915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ii0yY-0005x6-BO; Thu, 19 Dec 2019 13:56:42 -0500 Date: Thu, 19 Dec 2019 20:56:33 +0200 Message-Id: <83mubo16vy.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Thu, 19 Dec 2019 17:42:41 +0100) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> <8336dg2vvn.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 38632@debbugs.gnu.org, yantar92@gmail.com > Date: Thu, 19 Dec 2019 17:42:41 +0100 > > Hereʼs what it looks like. Thanks, but I think we need to change thread.c to use ENCODE_SYSTEM instead of ENCODE_UTF_8, since the name should be passed encoded in the locale's codeset. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Dec 2019 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: rpluim@gmail.com Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157686925422520 (code B ref 38632); Fri, 20 Dec 2019 19:15:02 +0000 Received: (at 38632) by debbugs.gnu.org; 20 Dec 2019 19:14:14 +0000 Received: from localhost ([127.0.0.1]:47254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiNj4-0005rA-82 for submit@debbugs.gnu.org; Fri, 20 Dec 2019 14:14:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiNj1-0005qw-U3 for 38632@debbugs.gnu.org; Fri, 20 Dec 2019 14:14:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iiNiw-0007cQ-RG; Fri, 20 Dec 2019 14:14:06 -0500 Received: from [176.228.60.248] (port=1040 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iiNiu-0003UV-LQ; Fri, 20 Dec 2019 14:14:05 -0500 Date: Fri, 20 Dec 2019 21:13:59 +0200 Message-Id: <835zia24js.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8336dg2vvn.fsf@gnu.org> (message from Eli Zaretskii on Thu, 19 Dec 2019 17:11:24 +0200) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> <8336dg2vvn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 19 Dec 2019 17:11:24 +0200 > From: Eli Zaretskii > Cc: 38632@debbugs.gnu.org, yantar92@gmail.com > > MS-Windows currently doesn't support setting thread names at all; > maybe I'll write something soon to fix that. Now done. I'd appreciate testing on 64-bit Windows and in particular on Windows 10. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 14:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157832183026407 (code B ref 38632); Mon, 06 Jan 2020 14:44:01 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 14:43:50 +0000 Received: from localhost ([127.0.0.1]:45357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTbh-0006rq-RT for submit@debbugs.gnu.org; Mon, 06 Jan 2020 09:43:50 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:36524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTbf-0006rc-L8 for 38632@debbugs.gnu.org; Mon, 06 Jan 2020 09:43:48 -0500 Received: by mail-wm1-f48.google.com with SMTP id p17so15520063wma.1 for <38632@debbugs.gnu.org>; Mon, 06 Jan 2020 06:43:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=eQgxU8wO1U44Q4JX1oNkJ/ZGBsyXe/ab6Z3dDIySkKU=; b=lxqx15qHJToA1J5MtX9YNISbTu5newLdlDNGZpHxstLOzGXqLMZ8eNugl9rZnyhNiH hzlmsNqvXctiVUiMtvHi7C2SXu0u0bqAUrSgUFuWnzBxbs8mmlAaDhMy0ESZXpKWI61I JVKj45u4ptnkZsWNLMRqFJl/RyJstO6CLHnod9Nd4WiL6Bra6ffz4nPAkyabnpQfe2bh i7l8FVj4ZZGtfx8/KtZDLwyeLXbXdTZ3EMCmdmN8hvkdK1uEdwfgtsphU8xCCpZUNVX4 r546+1Y574XswN9NC5W4rT+74UlJ4DkOhAFkNpZSPPqTvFmJHixFysuXHAk/ZVZ4hULt i/iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=eQgxU8wO1U44Q4JX1oNkJ/ZGBsyXe/ab6Z3dDIySkKU=; b=a86MQ81ilG9pyIn2GRK7O1gTsOUzEcUaNfdFPPojMnVtdbka9iJzYWqgmHgTH94Ve/ +VZio4qU8O8pSx6+6E90KgcZry26HTQztm1d2rx6AJGiR0jxXTWNckn+n1Tq63xQANvH i9DnddbZevzvOVGI7kvhFbEoIsdkkcgbGMh0XpaiJO8Tz7QDnuRQUIXWAJeNwMQVaiUf g6Gt4OJOy7PWXI509P1TRgkblorDCtEfNrwAqMS9j0TnhMLF8h0rQTBaI04upxVpuYNs EAF/9BAxWNVQ74M1Y77fCn7lUJFp63xx+ZmqDSJbv786TNMYKRReLxK3hT0DAMZ2Pff9 SuBg== X-Gm-Message-State: APjAAAWIk3eUK24de1uLkJ7OdrPbX73IQSL/e27zMZg8lek8H/zrEZEW yId1jzT5dOiEQeeGA7f7gJE= X-Google-Smtp-Source: APXvYqz+3JFuNnawZLSaq4aQUjkGKxKk14SrIqu0lpmqBL9qew6M819EA30xebgqQzBs9S5QuxQ97Q== X-Received: by 2002:a1c:cc06:: with SMTP id h6mr32838729wmb.118.1578321821706; Mon, 06 Jan 2020 06:43:41 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id d8sm73984102wre.13.2020.01.06.06.43.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 06:43:40 -0800 (PST) From: Robert Pluim References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> <8336dg2vvn.fsf@gnu.org> <835zia24js.fsf@gnu.org> Date: Mon, 06 Jan 2020 15:43:39 +0100 In-Reply-To: <835zia24js.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Dec 2019 21:13:59 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 20 Dec 2019 21:13:59 +0200, Eli Zaretskii said: >> Date: Thu, 19 Dec 2019 17:11:24 +0200 >> From: Eli Zaretskii >> Cc: 38632@debbugs.gnu.org, yantar92@gmail.com >> >> MS-Windows currently doesn't support setting thread names at all; >> maybe I'll write something soon to fix that. Eli> Now done. Eli> I'd appreciate testing on 64-bit Windows and in particular on Windows Eli> 10. It builds fine on Windows 10 using mingw64, and I can create a thread with a name, which 'info threads' in gdb then displays correctly. GNU/Linux version pushed to emacs-27. Robert From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 06 09:45:39 2020 Received: (at control) by debbugs.gnu.org; 6 Jan 2020 14:45:39 +0000 Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTdT-0006vT-5U for submit@debbugs.gnu.org; Mon, 06 Jan 2020 09:45:39 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioTdR-0006v7-DP for control@debbugs.gnu.org; Mon, 06 Jan 2020 09:45:37 -0500 Received: by mail-wr1-f41.google.com with SMTP id g17so49852942wro.2 for ; Mon, 06 Jan 2020 06:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject; bh=DPAUl97fF/PWlMgrz9UyD29K63v5AWnd6W9k8I367gU=; b=ohg5Eclcvu5Qs2lOQnYVXGeEb567k5B2eKsQud9PAGHcJJ7V91W6u9F3XyY/e1WOSO RM1PRh7o/DGPQJbvxsQDfzURkFvA7PevYE18yJ62fkyxbWCGsJNcUfQhuT6cO8qazMyW ClB8ylSlxNIvh9bSajIfubd6+5G3I5ceeldxvM2yORFX5aehtXTwB9E90BPPpllcobBn R/3dZvRYlZKZK+fWLL8ngR5K1Iesf9/as+wChHwcex6bOo/SV3CtrLsfYMZ+94P2DoGZ gsUodMOW7RP5sl7cI3RFVIsuOiXRJ/k0xrP9oQqdKh5ykf4P2MsXcCr7sAFLAoxBOpm+ CFaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject; bh=DPAUl97fF/PWlMgrz9UyD29K63v5AWnd6W9k8I367gU=; b=IxIs+evHqdACPqAfPoklyf0npChBr03N7bKgcokL53eK+rlkXFH3Udh99QT8oQVy+1 +7oaYXcqkNjWIRmsYN67D9gsIlmcmOl2jANTk1j+Mt+VVDmorhh2NtJj1FIIqv7Zvldc OIsNpZgMvTJbN/FGQxKtjo+1Oh4MxjfM8u39nCuZVnI/SF/6fOsatWMf/HeVrsSCgi0n GHos0RI3SHCOHKtt5sknOTiSOjKoUzXAMZn/LIqc+uc6WS1Z5jCz7omPT/EOpcnLHwFs 56WLXU46kxB+j0L2ATXfHzox5LXfohdHh4oNk6nQbXTe8uW5BdISxt+ctM4OGT3x//ee jX8A== X-Gm-Message-State: APjAAAUFTBQ8FqH6SlMp+kURgPmHQ5b6WU5n2Hk9k+eOnD6Y0E+V5x2K knoVHcTBrLkdj1GkAPCgNVaWvDs9 X-Google-Smtp-Source: APXvYqyE3Wupn4lekq3nJyMO4KN9kElM4oRALPpuAr2h6+Vwh+YERBefSS6U5kxspTmtWTgbptybpA== X-Received: by 2002:adf:ea88:: with SMTP id s8mr103929874wrm.293.1578321931423; Mon, 06 Jan 2020 06:45:31 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id s65sm23660462wmf.48.2020.01.06.06.45.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 06:45:30 -0800 (PST) Date: Mon, 06 Jan 2020 15:45:30 +0100 Message-Id: To: control@debbugs.gnu.org From: Robert Pluim Subject: control message for bug #38632 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 38632 27.1 quit From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 38632@debbugs.gnu.org, yantar92@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157832775127969 (code B ref 38632); Mon, 06 Jan 2020 16:23:01 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 16:22:31 +0000 Received: from localhost ([127.0.0.1]:46555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioV9D-0007H3-5a for submit@debbugs.gnu.org; Mon, 06 Jan 2020 11:22:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioV9B-0007Go-Tu for 38632@debbugs.gnu.org; Mon, 06 Jan 2020 11:22:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ioV96-0002cJ-OZ; Mon, 06 Jan 2020 11:22:24 -0500 Received: from [176.228.60.248] (port=2513 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ioV95-0000R8-Jq; Mon, 06 Jan 2020 11:22:24 -0500 Date: Mon, 06 Jan 2020 18:22:32 +0200 Message-Id: <83pnfweerb.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Robert Pluim on Mon, 06 Jan 2020 15:43:39 +0100) References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> <83y2va3efz.fsf@gnu.org> <83v9qd3a0i.fsf@gnu.org> <83mubp362m.fsf@gnu.org> <8336dg2vvn.fsf@gnu.org> <835zia24js.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 38632@debbugs.gnu.org, yantar92@gmail.com > Date: Mon, 06 Jan 2020 15:43:39 +0100 > > Eli> I'd appreciate testing on 64-bit Windows and in particular on Windows > Eli> 10. > > It builds fine on Windows 10 using mingw64, and I can create a > thread with a name, which 'info threads' in gdb then displays > correctly. > > GNU/Linux version pushed to emacs-27. Great, thanks (on both counts). From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread References: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> In-Reply-To: <87bls8ojoh.fsf@yantar92-laptop.i-did-not-set--mail-host-address--so-tickle-me> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 19:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38632@debbugs.gnu.org Cc: Eli Zaretskii , Robert Pluim Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157834025724325 (code B ref 38632); Mon, 06 Jan 2020 19:51:01 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 19:50:57 +0000 Received: from localhost ([127.0.0.1]:46844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioYOv-0006KB-9Y for submit@debbugs.gnu.org; Mon, 06 Jan 2020 14:50:57 -0500 Received: from mail1477c50.megamailservers.eu ([91.136.14.77]:54792 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioYOs-0006JV-Ee; Mon, 06 Jan 2020 14:50:55 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578340247; bh=N6ji9sDsrLAwVrSuhmSnLNKRA9xkF362JoVSVHUeXFY=; h=From:Date:Subject:Cc:To:From; b=KfIFkUFS75Z6NJTtCN+tYitiUbWV2WyhieA+v9q3QwY1HDWmZ18lUMoNERLeRRA38 RxiQjqYYY202tVleByl/Sbg/mWm6Hx2Tn9uey14yKnOhWPIHsW0OnRHtusdqbpRHCG 4nwqPlemXB50Dh78Omsq0C6EA3KoSknws8OYRcpU= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 006Jojdf025527; Mon, 6 Jan 2020 19:50:46 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Mon, 6 Jan 2020 20:50:44 +0100 Message-Id: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020E.5E138F97.002D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=dLXYZ9Rb c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=Xu4fbJhMLVsA:10 a=M51BFTxLslgA:10 a=uwLj2Jfez93LV_EVfpsA:9 a=CjuIK1q_8ugA:10 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=jd6J4Gguk5HxikPWLKER:22 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) reopen 38632 stop The committed patch fails to compile on macOS (10.14). Here, and = probably BSD in general, pthread_setname_np takes a single argument (the = name) and applies to the current thread. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 21:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38632@debbugs.gnu.org Cc: Eli Zaretskii , Robert Pluim Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157834791711880 (code B ref 38632); Mon, 06 Jan 2020 21:59:01 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 21:58:37 +0000 Received: from localhost ([127.0.0.1]:46926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioaOT-00035Y-8S for submit@debbugs.gnu.org; Mon, 06 Jan 2020 16:58:37 -0500 Received: from mail1467c50.megamailservers.eu ([91.136.14.67]:50092 helo=mail268c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioaOR-00035H-47 for 38632@debbugs.gnu.org; Mon, 06 Jan 2020 16:58:36 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578347908; bh=rv07485o8H62mBgbLrpWn3vIalwoRclbqr/qPYWtEro=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=CfCN6bT6zm1hWoNzVJ2wG5B7YTe3cT4EXldJ1FjYqG3nlt+8Wh+Ev2+PG2d41MMWo /D5eiBp6iQ0azwkKCw/IClcxlM4R1dIBbOF+v2GJyiXDOX5qCkhYLNaKwu42/vuERU riWyX8P2bufPpQm3Or7W7tXZCQk2e5ZoKBxRQTik= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail268c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 006LwPxR004628; Mon, 6 Jan 2020 21:58:27 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_AC979AAC-638F-452F-8A80-1145AC9D8C9F" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Mon, 6 Jan 2020 22:58:25 +0100 In-Reply-To: References: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0212.5E13AD84.001F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=J53UEzvS c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=xKR4U9U0X0AW0op-uYYA:9 a=CjuIK1q_8ugA:10 a=vohCn5ePn4EUMMBJDXIA:9 a=De_Ol2h6w80A:10 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_AC979AAC-638F-452F-8A80-1145AC9D8C9F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Here is a quick-and-dirty patch that repairs the macOS/BSD builds. Not = tested on anything else. --Apple-Mail=_AC979AAC-638F-452F-8A80-1145AC9D8C9F Content-Disposition: attachment; filename=pthread-setname.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="pthread-setname.diff" Content-Transfer-Encoding: 7bit diff --git a/configure.ac b/configure.ac index de4710f150..068ef5c20c 100644 --- a/configure.ac +++ b/configure.ac @@ -4183,6 +4183,23 @@ AC_DEFUN cfmakeraw cfsetspeed __executable_start log2 pthread_setname_np) LIBS=$OLD_LIBS +if test "$ac_cv_func_pthread_setname_np" = "yes"; then + AC_CACHE_CHECK( + [whether pthread_setname_np takes a single argument], + [emacs_cv_pthread_setname_np_1arg], + [AC_COMPILE_IFELSE( + [AC_LANG_PROGRAM( + [[#include ]], + [[pthread_setname_np ("a");]])], + [emacs_cv_pthread_setname_np_1arg=yes], + [emacs_cv_pthread_setname_np_1arg=no])]) + if test "$emacs_cv_pthread_setname_np_1arg" = "yes"; then + AC_DEFINE( + HAVE_PTHREAD_SETNAME_NP_1ARG, 1, + [Define to 1 if pthread_setname_np takes a single argument.]) + fi +fi + dnl No need to check for posix_memalign if aligned_alloc works. AC_CHECK_FUNCS([aligned_alloc posix_memalign], [break]) AC_CHECK_DECLS([aligned_alloc], [], [], [[#include ]]) diff --git a/src/systhread.c b/src/systhread.c index 1dda036cc2..19fc9e1596 100644 --- a/src/systhread.c +++ b/src/systhread.c @@ -200,9 +200,28 @@ sys_thread_equal (sys_thread_t t, sys_thread_t u) return pthread_equal (t, u); } +void +sys_thread_set_name (const char *name) +{ +#ifdef HAVE_PTHREAD_SETNAME_NP + /* We need to truncate here otherwise pthread_setname_np + fails to set the name. TASK_COMM_LEN is what the length + is called in the Linux kernel headers (Bug#38632). */ +#define TASK_COMM_LEN 16 + char p_name[TASK_COMM_LEN]; + strncpy (p_name, name, TASK_COMM_LEN - 1); + p_name[TASK_COMM_LEN - 1] = '\0'; + #ifdef HAVE_PTHREAD_SETNAME_NP_1ARG + pthread_setname_np (p_name); + #else + pthread_setname_np (pthread_self (), p_name); + #endif +#endif +} + bool -sys_thread_create (sys_thread_t *thread_ptr, const char *name, - thread_creation_function *func, void *arg) +sys_thread_create (sys_thread_t *thread_ptr, thread_creation_function *func, + void *arg) { pthread_attr_t attr; bool result = false; @@ -221,22 +240,7 @@ sys_thread_create (sys_thread_t *thread_ptr, const char *name, } if (!pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED)) - { - result = pthread_create (thread_ptr, &attr, func, arg) == 0; -#ifdef HAVE_PTHREAD_SETNAME_NP - if (result && name != NULL) - { - /* We need to truncate here otherwise pthread_setname_np - fails to set the name. TASK_COMM_LEN is what the length - is called in the Linux kernel headers (Bug#38632). */ -#define TASK_COMM_LEN 16 - char p_name[TASK_COMM_LEN]; - strncpy (p_name, name, TASK_COMM_LEN - 1); - p_name[TASK_COMM_LEN - 1] = '\0'; - pthread_setname_np (*thread_ptr, p_name); - } -#endif - } + result = pthread_create (thread_ptr, &attr, func, arg) == 0; out: ; int error = pthread_attr_destroy (&attr); @@ -455,7 +459,11 @@ w32_set_thread_name (DWORD thread_id, const char *name) (ULONG_PTR *) &tninfo); } -static thread_creation_function *thread_start_address; +void +sys_thread_set_name (const char *name) +{ + w32_set_thread_name (GetCurrentThreadId (), name); +} /* _beginthread wants a void function, while we are passed a function that returns a pointer. So we use a wrapper. See the command in @@ -463,20 +471,12 @@ w32_set_thread_name (DWORD thread_id, const char *name) static void ALIGN_STACK w32_beginthread_wrapper (void *arg) { - /* FIXME: This isn't very clean: systhread.c is not supposed to know - that ARG is a pointer to a thread_state object, or be familiar - with thread_state object's structure in general. */ - struct thread_state *this_thread = arg; - - if (this_thread->thread_name) - w32_set_thread_name (GetCurrentThreadId (), this_thread->thread_name); - (void)thread_start_address (arg); } bool -sys_thread_create (sys_thread_t *thread_ptr, const char *name, - thread_creation_function *func, void *arg) +sys_thread_create (sys_thread_t *thread_ptr, thread_creation_function *func, + void *arg) { /* FIXME: Do threads that run Lisp require some minimum amount of stack? Zero here means each thread will get the same amount as diff --git a/src/systhread.h b/src/systhread.h index 5368acfb52..005388fd5a 100644 --- a/src/systhread.h +++ b/src/systhread.h @@ -112,10 +112,11 @@ #define SYSTHREAD_H extern bool sys_thread_equal (sys_thread_t, sys_thread_t) ATTRIBUTE_WARN_UNUSED_RESULT; -extern bool sys_thread_create (sys_thread_t *, const char *, - thread_creation_function *, void *) +extern bool sys_thread_create (sys_thread_t *, thread_creation_function *, + void *) ATTRIBUTE_WARN_UNUSED_RESULT; extern void sys_thread_yield (void); +extern void sys_thread_set_name (const char *); #endif /* SYSTHREAD_H */ diff --git a/src/thread.c b/src/thread.c index f7e39dc427..c7fe061426 100644 --- a/src/thread.c +++ b/src/thread.c @@ -725,6 +725,9 @@ run_thread (void *state) self->m_stack_bottom = self->stack_top = (char *) &stack_pos; self->thread_id = sys_thread_self (); + if (self->thread_name) + sys_thread_set_name (self->thread_name); + acquire_global_lock (self); /* Put a dummy catcher at top-level so that handlerlist is never NULL. @@ -832,7 +835,7 @@ DEFUN ("make-thread", Fmake_thread, Smake_thread, 1, 2, 0, else new_thread->thread_name = NULL; sys_thread_t thr; - if (! sys_thread_create (&thr, c_name, run_thread, new_thread)) + if (! sys_thread_create (&thr, run_thread, new_thread)) { /* Restore the previous situation. */ all_threads = all_threads->next_thread; --Apple-Mail=_AC979AAC-638F-452F-8A80-1145AC9D8C9F-- From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 22:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, Eli Zaretskii Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157834927913964 (code B ref 38632); Mon, 06 Jan 2020 22:22:01 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 22:21:19 +0000 Received: from localhost ([127.0.0.1]:46931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioakR-0003dA-97 for submit@debbugs.gnu.org; Mon, 06 Jan 2020 17:21:19 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:53729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ioakN-0003cu-En for 38632@debbugs.gnu.org; Mon, 06 Jan 2020 17:21:18 -0500 Received: by mail-wm1-f41.google.com with SMTP id m24so16807569wmc.3 for <38632@debbugs.gnu.org>; Mon, 06 Jan 2020 14:21:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=ka4QH+qKLsfVSLWckh8vl04/ZRJUxHc5YLtUx0NoHWc=; b=tjnFB3VlUlS+UEtIyVFXN1qAIQyMkpAeA0Mtx8kPw8JzI9B18/hRbAMeodEqtMK9rS A3+sS04hN6QxMp9M5BIWp2ViSbFBBCgKPfCq+dszz4Ga0ziSywUjpuNjwbvClBD50mto DvskLxbiwmjCIlIuiosqhqovyjP6Ux/624LleCgG1Cauu1q+6+mrCsbnKjt2aMavP9CL IcurKYsTkzjTEin8MMH3Bgke8ksWoJEsX+QmowDF/+BYJhLrBOEf/+2KRT7GUHGn1bhe Ky/RLXOsCWwF3ZMh35UtEu7265Eo4puShdrdUH6y23zb8/myEii5C+KhKKzd+N3Pd8FE m9Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=ka4QH+qKLsfVSLWckh8vl04/ZRJUxHc5YLtUx0NoHWc=; b=c858tkt+aN2pMua8i3mlO+wS2CdulBubxqM2UsMO0UbEAtg2xk/VKojpyao55v6g1q hXsi32Izmd53YYSsaGQamLqZpMXceLRoqWaRDlcjcBbqSOZTrbuNTJKxoLH0crnYwRbC b2L9UdfCl47Wr6H2ApOOabsSNnoTxKIBteUwC5sOZ0Vh7hnFC2JKTabYXwvqK6EfVlB+ 7zu3lyy+f3RsIuwlD0dEFppY8hkxWMaKWbZMJJWk3tmYcQLhzLWz25oCugoKuxqrqCJG NHH6btNLGKGL3UT2/QnMJ3+S7IAOF8mMoOdxcoAityRfy4n3MaIsqRp1wG7Umt79kvrc kDRQ== X-Gm-Message-State: APjAAAX+qIAfd2AoYn1tYLExGPBiGlvIY1JpsDJZ59g1RM5Q0CTsl6Y/ jyEg6mI26kTy7MauX5vtJlc= X-Google-Smtp-Source: APXvYqw3Wi4MM0qbgZdE6ZWfuBwEPeIpAOmJQhgL4Mwgt2HN6upbaPfkMdQ4OuUgoFAV+3//sdkUMQ== X-Received: by 2002:a1c:9c4c:: with SMTP id f73mr38218693wme.125.1578349269610; Mon, 06 Jan 2020 14:21:09 -0800 (PST) Received: from rpluim-mac ([2a01:e34:ecfc:a860:1979:b7b6:bfde:4f63]) by smtp.gmail.com with ESMTPSA id h17sm77351838wrs.18.2020.01.06.14.21.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 14:21:08 -0800 (PST) From: Robert Pluim References: Date: Mon, 06 Jan 2020 23:21:07 +0100 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 6 Jan 2020 20:50:44 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 6 Jan 2020 20:50:44 +0100, Mattias Engdeg=C3=A5rd said: Mattias> reopen 38632 Mattias> stop Mattias> The committed patch fails to compile on macOS (10.14). Here, a= nd Mattias> probably BSD in general, pthread_setname_np takes a single arg= ument Mattias> (the name) and applies to the current thread. Bother. Eli, what do you want to do here? I can rework the configure test to check for the 2-arg version of pthread_setname_np, or we could revert the change. Robert From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jan 2020 23:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, Eli Zaretskii Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157835197018216 (code B ref 38632); Mon, 06 Jan 2020 23:07:02 +0000 Received: (at 38632) by debbugs.gnu.org; 6 Jan 2020 23:06:10 +0000 Received: from localhost ([127.0.0.1]:46973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iobRq-0004jk-0c for submit@debbugs.gnu.org; Mon, 06 Jan 2020 18:06:10 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:33458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iobRo-0004jV-Kr for 38632@debbugs.gnu.org; Mon, 06 Jan 2020 18:06:08 -0500 Received: by mail-wr1-f45.google.com with SMTP id b6so51845134wrq.0 for <38632@debbugs.gnu.org>; Mon, 06 Jan 2020 15:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=QRFZtQusV/DcEBpKYFHxbt2G7W63I62VPaI67S0xghQ=; b=uv4H2BzgEcExvJz9a+CfZGLnluzwP4sVvd1q3wmVqlsE7UfyqRcpPg570VPGbWLiI5 +hsH3BMlK4e8VA51IfR8ZASWclDuugf4py2SJn0CiwLYZhOi4G8P93Uf+Ya6M3JTa5Z1 Cp7qAdFNBPCKFZGO2lPUWzyTWNtcsDYoFYMJ7OZiphEtF8HpUJZJwpwmz26Wc71ht48f E1MAfjbOPHycKL0AXtx7RwtuAB/LfbELhL8TIY2Z0K57gvob1zKL82DwdT3a76ywG/Qz sqlSchkiEKRa1XqHPbgVLnPdGf1dynRlSjYwAJNLyKpG3B8hMmeeNvFKPUsgRZNiYJiS 6f3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=QRFZtQusV/DcEBpKYFHxbt2G7W63I62VPaI67S0xghQ=; b=Nx1jsR2JEZWfoNv/hUBpQt1IEYVo1UdEFGc94KnWVrgRoFS2Vltk67Arvm9i/cweTV j9+gZn8ivx/QQsc2cTT5AsQesZwrfNmtko1iD2f2bUK6EtoRU/wavF+ztv8SJXzftIIC YW+YxfDaQpboYU1inmhJb4LZ3varuFpc+FyG4VzOEmgvL8ufLnmsLuQtSLF5fNGAOJiB Dt8TcdkkmgDtCCHQSb20cHseW7jHltENvBPGIHNW7XyqTkWbDqsTf9iHGKIf6GSm0xKq 1hXK5p4JOeox7nozZiZKPKyj2MY56L28mwzq2eb6rIaZq5OMOilSe/dFs4QOAp3mb+79 fKyg== X-Gm-Message-State: APjAAAUomBEAVasCVtt8c27xJ8/naqvCeY0lkOVH2AY7TWtJliVCmO84 bQTbaIJ4HcmZ3FqGsmgiQkU= X-Google-Smtp-Source: APXvYqyDlvxgLED5b2w0lP7is0juW5Y85B5Yw86GWv8NB+oiaDghqNsf3rZAgePAsl9ww4Uwq4H4yQ== X-Received: by 2002:a5d:6708:: with SMTP id o8mr106951781wru.296.1578351962998; Mon, 06 Jan 2020 15:06:02 -0800 (PST) Received: from rpluim-mac ([2a01:e34:ecfc:a860:1979:b7b6:bfde:4f63]) by smtp.gmail.com with ESMTPSA id u7sm24396061wmj.3.2020.01.06.15.06.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 15:06:02 -0800 (PST) From: Robert Pluim References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> Date: Tue, 07 Jan 2020 00:06:00 +0100 In-Reply-To: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 6 Jan 2020 22:58:25 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 6 Jan 2020 22:58:25 +0100, Mattias Engdeg=C3=A5rd said: Mattias> Here is a quick-and-dirty patch that repairs the macOS/BSD bui= lds. Not tested on anything else. That builds and works fine for me on Fedora. Thanks for fixing that. Robert From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 07:14:32 2020 Received: (at control) by debbugs.gnu.org; 7 Jan 2020 12:14:33 +0000 Received: from localhost ([127.0.0.1]:47478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ionkm-0000j8-Os for submit@debbugs.gnu.org; Tue, 07 Jan 2020 07:14:32 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:52679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ionkl-0000iu-I0 for control@debbugs.gnu.org; Tue, 07 Jan 2020 07:14:31 -0500 Received: by mail-wm1-f48.google.com with SMTP id p9so18701529wmc.2 for ; Tue, 07 Jan 2020 04:14:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject; bh=Up0Oy1BifNDLt1yRl8BMwccUJ3BFqKO90Y5h3Gxp5FU=; b=ckhmsVdWhir8QYhDLytR3K05mj9pT0HAe2svD7460lLtK5s0NGsQJQI4HG5pWGIl3V aoRGo4D3Scky9xqdIQEYXDatasomocbNzA5XJrleX4MVjknd6OUCuwJgP+VsoHyzHWYk ONGaCGT9vW5DXr9kehKoFXh9ctiyZTTbyy3qmTs6Od932l5EZwkMYsdMcS88f+ZKdVm8 kOtp0Gi/zehO+RLAXSocXUC1Ja4WHY9iS0gI8mW9KcDS8hX0CUHTQ4MUVZg+3AKvDTOG nGvX9IyUfuGMXQA0Jn4/DJ4WThBtAt896f3APwrEa+DiwOvcwd3w6KsWvMQqZSuGZVsa 09Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject; bh=Up0Oy1BifNDLt1yRl8BMwccUJ3BFqKO90Y5h3Gxp5FU=; b=r5OwXMVXoMWoR00CDo3N5RVBH6YDd/b1qTjkH/BLowOOzxpm+CqRFl4yYqChuEXtOj qadrKVIEUmA/8PBgiPTol+MhnIVCVJ2/3YHFWdcRd+laJt4atbuz8R9Rheu4JT7l9Yf2 BCspIn3DtX4CiYhT7niaOo+wiN0GHwtRKtqbTqDTytoDcw3kFGQik9uZdvCJ98KltksV EIklY556m+OoZ1LJvJABzLpoknluxcxfMSvkSBVTTq9DqVCvZwsFXqILYZfOr7E93wTz CuM4vBVcMuUPvR6LneTbYMebueuLTKNCSIQ3vUMiz0hQgjXeVsMRm6ljt0WLwXXsfdNj FbZQ== X-Gm-Message-State: APjAAAX/sRxKIOsP0lfnGka2Z6yUWOB+6A5ig21y3BX9g7TgteZmBBqf jlpk44aOqndIcicg4ka0xMtAoPji X-Google-Smtp-Source: APXvYqzEg7GzGHySAoRlHcUgApkvpLI5JeCS1HRh1lp2cdp6YyocV7ei5/u+jIZkeF7BHMUiVLelTQ== X-Received: by 2002:a1c:4e03:: with SMTP id g3mr41416401wmh.22.1578399265538; Tue, 07 Jan 2020 04:14:25 -0800 (PST) Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id b17sm74017575wrp.49.2020.01.07.04.14.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 04:14:24 -0800 (PST) Date: Tue, 07 Jan 2020 13:14:24 +0100 Message-Id: To: control@debbugs.gnu.org From: Robert Pluim Subject: control message for bug #39003 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) merge 39003 38632 quit From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.15784119466994 (code B ref 38632); Tue, 07 Jan 2020 15:46:01 +0000 Received: (at 38632) by debbugs.gnu.org; 7 Jan 2020 15:45:46 +0000 Received: from localhost ([127.0.0.1]:49042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ior3B-0001ok-RH for submit@debbugs.gnu.org; Tue, 07 Jan 2020 10:45:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ior3A-0001oX-CW for 38632@debbugs.gnu.org; Tue, 07 Jan 2020 10:45:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ior34-0005XN-Ob; Tue, 07 Jan 2020 10:45:38 -0500 Received: from [176.228.60.248] (port=4223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ior2r-0006P4-HV; Tue, 07 Jan 2020 10:45:26 -0500 Date: Tue, 07 Jan 2020 17:45:36 +0200 Message-Id: <83tv57clsv.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 6 Jan 2020 22:58:25 +0100) References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Mon, 6 Jan 2020 22:58:25 +0100 > Cc: Eli Zaretskii , Robert Pluim > > Here is a quick-and-dirty patch that repairs the macOS/BSD builds. Not tested on anything else. Thanks. This is fine for the emacs-27 branch, but it needs some minor cleanup: > -static thread_creation_function *thread_start_address; This line cannot be deleted, as it will cause systhread.c fail to compile on MS-Windows. And this comment on thread.h: /* Thread's name in the locale encoding. Actually used only on WINDOWSNT. */ char *thread_name; is no longer accurate, so it needs to be updated to reflect the modified code. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 16:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157841561617966 (code B ref 38632); Tue, 07 Jan 2020 16:47:02 +0000 Received: (at 38632) by debbugs.gnu.org; 7 Jan 2020 16:46:56 +0000 Received: from localhost ([127.0.0.1]:49135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ios0O-0004fT-0n for submit@debbugs.gnu.org; Tue, 07 Jan 2020 11:46:56 -0500 Received: from mail231c50.megamailservers.eu ([91.136.10.241]:49822 helo=mail37c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ios0M-0004dc-2D for 38632@debbugs.gnu.org; Tue, 07 Jan 2020 11:46:55 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578415612; bh=vooWOJbTWyJBedqBGuD0sg/hjh0h8Y2dHKS8z7LbwsE=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=GEYOeP4zmrpCfGSZTLItT4kzk9XrnrTYYTQNisRecHa50AjNQLYav5/6+0Vx7TAcH lbruOLRGuRCnOwLFADq0PqCZTA/Oz5rkcbtYplyXxLGWxeBnwS4+SzNVs7aXDSwLzf 91PXoFxhc8r5ujD+njnOPOoaXyRxsvvuRy8kRIuc= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail37c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 007Gknlf011978; Tue, 7 Jan 2020 16:46:51 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_D606763C-C3E5-42A1-8820-0B3C0C653954" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Date: Tue, 7 Jan 2020 17:46:49 +0100 In-Reply-To: <83tv57clsv.fsf@gnu.org> References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0201.5E14B5FC.000A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=eN1tc0h1 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=KgOrj3LDPA-uksuyswYA:9 a=PJkFRpEzO4GG2giW:21 a=m5qhEjNOqaVB0tYR:21 a=CjuIK1q_8ugA:10 a=ejTQb-k67XKm5VBlOyIA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Apple-Mail=_D606763C-C3E5-42A1-8820-0B3C0C653954 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 7 jan. 2020 kl. 16.45 skrev Eli Zaretskii : > This line cannot be deleted, as it will cause systhread.c fail to > compile on MS-Windows. Oops! Reinstated. However, isn't thread_start_address inherently racy? It doesn't matter = much since it will only ever have a single value (run_thread), but it = does violate layering. That problem won't be addressed in this patch, = however. > And this comment on thread.h: Edited. Thanks for the review! Patch updated. --Apple-Mail=_D606763C-C3E5-42A1-8820-0B3C0C653954 Content-Disposition: attachment; filename=0001-Fix-BSD-and-macOS-builds-w.r.t.-pthread_setname_np-b.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-BSD-and-macOS-builds-w.r.t.-pthread_setname_np-b.patch" Content-Transfer-Encoding: quoted-printable =46rom=20f69ecf1c239c3ed90d4265b0b41c9881387c49dd=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Tue,=207=20Jan=202020=2017:08:25=20+0100=0A= Subject:=20[PATCH]=20Fix=20BSD=20and=20macOS=20builds=20w.r.t.=20= pthread_setname_np=0A=20(bug#38632)=0A=0Apthread_setname_np=20takes=20= only=20a=20single=20argument=20on=20BSD=20and=20macOS,=0Aand=20affects=20= the=20current=20thread=20only.=0A=0A*=20configure.ac:=20Add=20check=20= for=20single-argument=20pthread_setname_np=0A*=20src/systhread.c=20= (sys_thread_set_name):=20New=20(w32=20and=20pthread=20versions).=0A= (sys_thread_create):=20Remove=20name=20argument=20and=20name-setting.=0A= (w32_beginthread_wrapper):=20Remove=20name-setting.=0A*=20= src/systhread.h=20(sys_thread_create,=20sys_thread_set_name):=0AUpdate=20= prototypes.=0A*=20src/thread.c=20(run_thread):=20Call=20= sys_thread_set_name.=0A(Fmake_thread):=20Adapt=20call=20to=20= sys_thread_create.=0A*=20src/thread.h=20(struct=20thread_state):=20= Adjust=20comment.=0A---=0A=20configure.ac=20=20=20=20|=2017=20= +++++++++++++++=0A=20src/systhread.c=20|=2058=20= +++++++++++++++++++++++++------------------------=0A=20src/systhread.h=20= |=20=205=20+++--=0A=20src/thread.c=20=20=20=20|=20=205=20++++-=0A=20= src/thread.h=20=20=20=20|=20=203=20+--=0A=205=20files=20changed,=2055=20= insertions(+),=2033=20deletions(-)=0A=0Adiff=20--git=20a/configure.ac=20= b/configure.ac=0Aindex=20de4710f150..068ef5c20c=20100644=0A---=20= a/configure.ac=0A+++=20b/configure.ac=0A@@=20-4183,6=20+4183,23=20@@=20= AC_DEFUN=0A=20cfmakeraw=20cfsetspeed=20__executable_start=20log2=20= pthread_setname_np)=0A=20LIBS=3D$OLD_LIBS=0A=20=0A+if=20test=20= "$ac_cv_func_pthread_setname_np"=20=3D=20"yes";=20then=0A+=20=20= AC_CACHE_CHECK(=0A+=20=20=20[whether=20pthread_setname_np=20takes=20a=20= single=20argument],=0A+=20=20=20[emacs_cv_pthread_setname_np_1arg],=0A+=20= =20=20[AC_COMPILE_IFELSE(=0A+=20=20=20=20=20[AC_LANG_PROGRAM(=0A+=20=20=20= =20=20=20=20[[#include=20]],=0A+=20=20=20=20=20=20=20= [[pthread_setname_np=20("a");]])],=0A+=20=20=20=20=20= [emacs_cv_pthread_setname_np_1arg=3Dyes],=0A+=20=20=20=20=20= [emacs_cv_pthread_setname_np_1arg=3Dno])])=0A+=20=20if=20test=20= "$emacs_cv_pthread_setname_np_1arg"=20=3D=20"yes";=20then=0A+=20=20=20=20= AC_DEFINE(=0A+=20=20=20=20=20=20HAVE_PTHREAD_SETNAME_NP_1ARG,=201,=0A+=20= =20=20=20=20=20[Define=20to=201=20if=20pthread_setname_np=20takes=20a=20= single=20argument.])=0A+=20=20fi=0A+fi=0A+=0A=20dnl=20No=20need=20to=20= check=20for=20posix_memalign=20if=20aligned_alloc=20works.=0A=20= AC_CHECK_FUNCS([aligned_alloc=20posix_memalign],=20[break])=0A=20= AC_CHECK_DECLS([aligned_alloc],=20[],=20[],=20[[#include=20]])=0A= diff=20--git=20a/src/systhread.c=20b/src/systhread.c=0Aindex=20= 1dda036cc2..2c3a060a17=20100644=0A---=20a/src/systhread.c=0A+++=20= b/src/systhread.c=0A@@=20-200,9=20+200,28=20@@=20sys_thread_equal=20= (sys_thread_t=20t,=20sys_thread_t=20u)=0A=20=20=20return=20pthread_equal=20= (t,=20u);=0A=20}=0A=20=0A+void=0A+sys_thread_set_name=20(const=20char=20= *name)=0A+{=0A+#ifdef=20HAVE_PTHREAD_SETNAME_NP=0A+=20=20/*=20We=20need=20= to=20truncate=20here=20otherwise=20pthread_setname_np=0A+=20=20=20=20=20= fails=20to=20set=20the=20name.=20=20TASK_COMM_LEN=20is=20what=20the=20= length=0A+=20=20=20=20=20is=20called=20in=20the=20Linux=20kernel=20= headers=20(Bug#38632).=20=20*/=0A+#define=20TASK_COMM_LEN=2016=0A+=20=20= char=20p_name[TASK_COMM_LEN];=0A+=20=20strncpy=20(p_name,=20name,=20= TASK_COMM_LEN=20-=201);=0A+=20=20p_name[TASK_COMM_LEN=20-=201]=20=3D=20= '\0';=0A+=20#ifdef=20HAVE_PTHREAD_SETNAME_NP_1ARG=0A+=20=20= pthread_setname_np=20(p_name);=0A+=20#else=0A+=20=20pthread_setname_np=20= (pthread_self=20(),=20p_name);=0A+=20#endif=0A+#endif=0A+}=0A+=0A=20bool=0A= -sys_thread_create=20(sys_thread_t=20*thread_ptr,=20const=20char=20= *name,=0A-=09=09=20=20=20thread_creation_function=20*func,=20void=20= *arg)=0A+sys_thread_create=20(sys_thread_t=20*thread_ptr,=20= thread_creation_function=20*func,=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20void=20*arg)=0A=20{=0A=20=20=20pthread_attr_t=20= attr;=0A=20=20=20bool=20result=20=3D=20false;=0A@@=20-221,22=20+240,7=20= @@=20sys_thread_create=20(sys_thread_t=20*thread_ptr,=20const=20char=20= *name,=0A=20=20=20=20=20}=0A=20=0A=20=20=20if=20= (!pthread_attr_setdetachstate=20(&attr,=20PTHREAD_CREATE_DETACHED))=0A-=20= =20=20=20{=0A-=20=20=20=20=20=20result=20=3D=20pthread_create=20= (thread_ptr,=20&attr,=20func,=20arg)=20=3D=3D=200;=0A-#ifdef=20= HAVE_PTHREAD_SETNAME_NP=0A-=20=20=20=20=20=20if=20(result=20&&=20name=20= !=3D=20NULL)=0A-=20=20=20=20=20=20=20=20{=0A-=20=20=20=20=20=20=20=20=20=20= /*=20We=20need=20to=20truncate=20here=20otherwise=20pthread_setname_np=0A= -=20=20=20=20=20=20=20=20=20=20=20=20=20fails=20to=20set=20the=20name.=20= =20TASK_COMM_LEN=20is=20what=20the=20length=0A-=20=20=20=20=20=20=20=20=20= =20=20=20=20is=20called=20in=20the=20Linux=20kernel=20headers=20= (Bug#38632).=20=20*/=0A-#define=20TASK_COMM_LEN=2016=0A-=20=20=20=20=20=20= =20=20=20=20char=20p_name[TASK_COMM_LEN];=0A-=20=20=20=20=20=20=20=20=20=20= strncpy=20(p_name,=20name,=20TASK_COMM_LEN=20-=201);=0A-=20=20=20=20=20=20= =20=20=20=20p_name[TASK_COMM_LEN=20-=201]=20=3D=20'\0';=0A-=20=20=20=20=20= =20=20=20=20=20pthread_setname_np=20(*thread_ptr,=20p_name);=0A-=20=20=20= =20=20=20=20=20}=0A-#endif=0A-=20=20=20=20}=0A+=20=20=20=20result=20=3D=20= pthread_create=20(thread_ptr,=20&attr,=20func,=20arg)=20=3D=3D=200;=0A=20= =0A=20=20out:=20;=0A=20=20=20int=20error=20=3D=20pthread_attr_destroy=20= (&attr);=0A@@=20-457,26=20+461,24=20@@=20w32_set_thread_name=20(DWORD=20= thread_id,=20const=20char=20*name)=0A=20=0A=20static=20= thread_creation_function=20*thread_start_address;=0A=20=0A+void=0A= +sys_thread_set_name=20(const=20char=20*name)=0A+{=0A+=20=20= w32_set_thread_name=20(GetCurrentThreadId=20(),=20name);=0A+}=0A+=0A=20= /*=20_beginthread=20wants=20a=20void=20function,=20while=20we=20are=20= passed=20a=20function=0A=20=20=20=20that=20returns=20a=20pointer.=20=20= So=20we=20use=20a=20wrapper.=20=20See=20the=20command=20in=0A=20=20=20=20= w32term.h=20about=20the=20need=20for=20ALIGN_STACK=20attribute.=20=20*/=0A= =20static=20void=20ALIGN_STACK=0A=20w32_beginthread_wrapper=20(void=20= *arg)=0A=20{=0A-=20=20/*=20FIXME:=20This=20isn't=20very=20clean:=20= systhread.c=20is=20not=20supposed=20to=20know=0A-=20=20=20=20=20that=20= ARG=20is=20a=20pointer=20to=20a=20thread_state=20object,=20or=20be=20= familiar=0A-=20=20=20=20=20with=20thread_state=20object's=20structure=20= in=20general.=20=20*/=0A-=20=20struct=20thread_state=20*this_thread=20=3D=20= arg;=0A-=0A-=20=20if=20(this_thread->thread_name)=0A-=20=20=20=20= w32_set_thread_name=20(GetCurrentThreadId=20(),=20= this_thread->thread_name);=0A-=0A=20=20=20(void)thread_start_address=20= (arg);=0A=20}=0A=20=0A=20bool=0A-sys_thread_create=20(sys_thread_t=20= *thread_ptr,=20const=20char=20*name,=0A-=09=09=20=20=20= thread_creation_function=20*func,=20void=20*arg)=0A+sys_thread_create=20= (sys_thread_t=20*thread_ptr,=20thread_creation_function=20*func,=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20void=20*arg)=0A=20{=0A= =20=20=20/*=20FIXME:=20Do=20threads=20that=20run=20Lisp=20require=20some=20= minimum=20amount=20of=0A=20=20=20=20=20=20stack?=20=20Zero=20here=20= means=20each=20thread=20will=20get=20the=20same=20amount=20as=0Adiff=20= --git=20a/src/systhread.h=20b/src/systhread.h=0Aindex=20= 5368acfb52..005388fd5a=20100644=0A---=20a/src/systhread.h=0A+++=20= b/src/systhread.h=0A@@=20-112,10=20+112,11=20@@=20#define=20SYSTHREAD_H=0A= =20extern=20bool=20sys_thread_equal=20(sys_thread_t,=20sys_thread_t)=0A=20= =20=20ATTRIBUTE_WARN_UNUSED_RESULT;=0A=20=0A-extern=20bool=20= sys_thread_create=20(sys_thread_t=20*,=20const=20char=20*,=0A-=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20thread_creation_function=20*,=20void=20*)=0A+extern=20bool=20= sys_thread_create=20(sys_thread_t=20*,=20thread_creation_function=20*,=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20void=20*)=0A=20=20=20ATTRIBUTE_WARN_UNUSED_RESULT;=0A= =20=0A=20extern=20void=20sys_thread_yield=20(void);=0A+extern=20void=20= sys_thread_set_name=20(const=20char=20*);=0A=20=0A=20#endif=20/*=20= SYSTHREAD_H=20*/=0Adiff=20--git=20a/src/thread.c=20b/src/thread.c=0A= index=20f7e39dc427..c7fe061426=20100644=0A---=20a/src/thread.c=0A+++=20= b/src/thread.c=0A@@=20-725,6=20+725,9=20@@=20run_thread=20(void=20= *state)=0A=20=20=20self->m_stack_bottom=20=3D=20self->stack_top=20=3D=20= (char=20*)=20&stack_pos;=0A=20=20=20self->thread_id=20=3D=20= sys_thread_self=20();=0A=20=0A+=20=20if=20(self->thread_name)=0A+=20=20=20= =20sys_thread_set_name=20(self->thread_name);=0A+=0A=20=20=20= acquire_global_lock=20(self);=0A=20=0A=20=20=20/*=20Put=20a=20dummy=20= catcher=20at=20top-level=20so=20that=20handlerlist=20is=20never=20NULL.=0A= @@=20-832,7=20+835,7=20@@=20DEFUN=20("make-thread",=20Fmake_thread,=20= Smake_thread,=201,=202,=200,=0A=20=20=20else=0A=20=20=20=20=20= new_thread->thread_name=20=3D=20NULL;=0A=20=20=20sys_thread_t=20thr;=0A-=20= =20if=20(!=20sys_thread_create=20(&thr,=20c_name,=20run_thread,=20= new_thread))=0A+=20=20if=20(!=20sys_thread_create=20(&thr,=20run_thread,=20= new_thread))=0A=20=20=20=20=20{=0A=20=20=20=20=20=20=20/*=20Restore=20= the=20previous=20situation.=20=20*/=0A=20=20=20=20=20=20=20all_threads=20= =3D=20all_threads->next_thread;=0Adiff=20--git=20a/src/thread.h=20= b/src/thread.h=0Aindex=20e96a063a10..a09929fa44=20100644=0A---=20= a/src/thread.h=0A+++=20b/src/thread.h=0A@@=20-169,8=20+169,7=20@@=20= #define=20getcjmp=20(current_thread->m_getcjmp)=0A=20=20=20=20=20=20= interrupter=20should=20broadcast=20to=20this=20condition.=20=20*/=0A=20=20= =20sys_cond_t=20*wait_condvar;=0A=20=0A-=20=20/*=20Thread's=20name=20in=20= the=20locale=20encoding.=20=20Actually=20used=20only=20on=0A-=20=20=20=20= =20WINDOWSNT.=20=20*/=0A+=20=20/*=20Thread's=20name=20in=20the=20locale=20= encoding.=20=20*/=0A=20=20=20char=20*thread_name;=0A=20=0A=20=20=20/*=20= This=20thread=20might=20have=20released=20the=20global=20lock.=20=20If=20= so,=20this=20is=0A--=20=0A2.21.0=20(Apple=20Git-122.2)=0A=0A= --Apple-Mail=_D606763C-C3E5-42A1-8820-0B3C0C653954-- From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157841675022477 (code B ref 38632); Tue, 07 Jan 2020 17:06:02 +0000 Received: (at 38632) by debbugs.gnu.org; 7 Jan 2020 17:05:50 +0000 Received: from localhost ([127.0.0.1]:49147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosIf-0005qT-VB for submit@debbugs.gnu.org; Tue, 07 Jan 2020 12:05:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosId-0005qG-He for 38632@debbugs.gnu.org; Tue, 07 Jan 2020 12:05:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iosIY-0006il-DR; Tue, 07 Jan 2020 12:05:42 -0500 Received: from [176.228.60.248] (port=1444 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iosIX-0003se-2z; Tue, 07 Jan 2020 12:05:41 -0500 Date: Tue, 07 Jan 2020 19:05:53 +0200 Message-Id: <83a76zci32.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 7 Jan 2020 17:46:49 +0100) References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 7 Jan 2020 17:46:49 +0100 > Cc: 38632@debbugs.gnu.org, rpluim@gmail.com > > Thanks for the review! Patch updated. LGTM, thanks. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157841682022589 (code B ref 38632); Tue, 07 Jan 2020 17:07:01 +0000 Received: (at 38632) by debbugs.gnu.org; 7 Jan 2020 17:07:00 +0000 Received: from localhost ([127.0.0.1]:49151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosJo-0005sH-BJ for submit@debbugs.gnu.org; Tue, 07 Jan 2020 12:07:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosJm-0005s4-UZ for 38632@debbugs.gnu.org; Tue, 07 Jan 2020 12:06:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iosJh-0007Jf-Rm; Tue, 07 Jan 2020 12:06:53 -0500 Received: from [176.228.60.248] (port=1517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iosJg-0000Qs-Mx; Tue, 07 Jan 2020 12:06:53 -0500 Date: Tue, 07 Jan 2020 19:07:05 +0200 Message-Id: <838smjci12.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 7 Jan 2020 17:46:49 +0100) References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 7 Jan 2020 17:46:49 +0100 > Cc: 38632@debbugs.gnu.org, rpluim@gmail.com > > However, isn't thread_start_address inherently racy? It doesn't matter much since it will only ever have a single value (run_thread), but it does violate layering. That problem won't be addressed in this patch, however. Yes, that should be a separate cleanup (and yes, we always set it to the same function, so the race shouldn't matter in practice). From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2020 17:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 38632@debbugs.gnu.org, rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157841755723811 (code B ref 38632); Tue, 07 Jan 2020 17:20:01 +0000 Received: (at 38632) by debbugs.gnu.org; 7 Jan 2020 17:19:17 +0000 Received: from localhost ([127.0.0.1]:49167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosVh-0006Bz-2q for submit@debbugs.gnu.org; Tue, 07 Jan 2020 12:19:17 -0500 Received: from mail1474c50.megamailservers.eu ([91.136.14.74]:52634 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iosVe-0006Bi-Hl for 38632@debbugs.gnu.org; Tue, 07 Jan 2020 12:19:15 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578417547; bh=vXgUyfNwmsri3sR11Y0A3jOwUhdko/NT88/rT7dYtTQ=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=POcG6ntaQisnAv6YO43SV1hmBmuAFOlaqdWN6Din7epnJ0VACL6YAt9QoNYeYiKoH LsApNbpLWMujZ0lJFg3RVY9YwQrMj5MtVG7GsS1R9t5ZWz/1VpUDw9Zo8S2iL4UQf9 4iq373NSd73wJ7slIlezD2OHRXsVwwanR5HwZlVw= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 007HJ5wO015592; Tue, 7 Jan 2020 17:19:07 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <838smjci12.fsf@gnu.org> Date: Tue, 7 Jan 2020 18:19:04 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> <838smjci12.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0213.5E14BD8B.0038, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Q8qsHL+a c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=8spTWwBcbWR13H6i2VYA:9 a=CjuIK1q_8ugA:10 a=ncZ9vwaUYPMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 7 jan. 2020 kl. 18.07 skrev Eli Zaretskii : > Yes, that should be a separate cleanup (and yes, we always set it to > the same function, so the race shouldn't matter in practice). Right. Just to be clear, I'm not going to do that since I don't have a = Windows development setup. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 13:06:38 2020 Received: (at control) by debbugs.gnu.org; 7 Jan 2020 18:06:38 +0000 Received: from localhost ([127.0.0.1]:49233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iotFW-0007dB-J3 for submit@debbugs.gnu.org; Tue, 07 Jan 2020 13:06:38 -0500 Received: from mail1437c50.megamailservers.eu ([91.136.14.37]:46408 helo=mail263c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iotFU-0007cw-8m for control@debbugs.gnu.org; Tue, 07 Jan 2020 13:06:37 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1578420389; bh=EZtCSLt+CgPzS8KJr2iY6oJ82Q6aioPI9o9zQXSZc64=; h=From:Subject:Date:To:From; b=hGQXsTU68plogfke5xMXxl2nG0nDzVdobhYtPs1rSi5/m7yZlfZBSc2fPAtZOXDvK oIOBcuTnGVJxCXFlQei5ogdwQh7XO5LZjs2h1nIQhu0/DiKJ9on+PWnZ2Pw26/WtmV 9eCacax0L+2yfmSDfpznTtlm7Y2MkBQzxd7Jl+Ww= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail263c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 007I6Rf8018200 for ; Tue, 7 Jan 2020 18:06:29 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Message-Id: Date: Tue, 7 Jan 2020 19:06:27 +0100 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0212.5E14C8A5.0026, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=II989TnG c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=SVa3MfjQrP_3OpKi9K8A:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 38632 27.1 Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [91.136.14.37 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 38632 27.1 Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [91.136.14.37 listed in list.dnswl.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager close 38632 27.1 From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2020 18:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38632@debbugs.gnu.org, Eli Zaretskii , rpluim@gmail.com Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157850798922064 (code B ref 38632); Wed, 08 Jan 2020 18:27:02 +0000 Received: (at 38632) by debbugs.gnu.org; 8 Jan 2020 18:26:29 +0000 Received: from localhost ([127.0.0.1]:51284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipG2G-0005jo-Pv for submit@debbugs.gnu.org; Wed, 08 Jan 2020 13:26:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipG2F-0005jX-EV for 38632@debbugs.gnu.org; Wed, 08 Jan 2020 13:26:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipG2A-0006ae-5z; Wed, 08 Jan 2020 13:26:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ipG25-0006JX-Gr; Wed, 08 Jan 2020 13:26:17 -0500 From: Glenn Morris References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> X-Spook: al-Qa'ida cypherpunk diwn Chemical spill Janet Reno emc X-Ran: Up0+"tcwEtdQ}W?g7ZKbAN"0I:.Nfajq:-fft9vyb%IgJZ3Uv,6I#9,-M!)ilS1@T7brH^ X-Hue: brightred X-Attribution: GM Date: Wed, 08 Jan 2020 13:26:16 -0500 In-Reply-To: <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Tue, 7 Jan 2020 17:46:49 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) 73fd8a4 fails to build on some GNU/Linux hosts, ref eg https://hydra.nixos.org/build/109904668 systhread.c:86:1: error: conflicting types for 'sys_thread_create' sys_thread_create (sys_thread_t *t, const char *name, ^~~~~~~~~~~~~~~~~ In file included from thread.h:33:0, from lisp.h:2163, from systhread.c:23: systhread.h:115:13: note: previous declaration of 'sys_thread_create' was here extern bool sys_thread_create (sys_thread_t *, thread_creation_function *, ^~~~~~~~~~~~~~~~~ make[1]: *** [Makefile:402: systhread.o] Error 1 From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2020 18:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: mattiase@acm.org, rpluim@gmail.com, 38632@debbugs.gnu.org Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157850965924736 (code B ref 38632); Wed, 08 Jan 2020 18:55:02 +0000 Received: (at 38632) by debbugs.gnu.org; 8 Jan 2020 18:54:19 +0000 Received: from localhost ([127.0.0.1]:51292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipGTD-0006Qr-A0 for submit@debbugs.gnu.org; Wed, 08 Jan 2020 13:54:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipGTA-0006Qc-Mt for 38632@debbugs.gnu.org; Wed, 08 Jan 2020 13:54:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipGT5-0007CX-En; Wed, 08 Jan 2020 13:54:11 -0500 Received: from [176.228.60.248] (port=4170 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ipGT3-0002rQ-PG; Wed, 08 Jan 2020 13:54:10 -0500 Date: Wed, 08 Jan 2020 20:54:22 +0200 Message-Id: <834kx5bwyp.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Glenn Morris on Wed, 08 Jan 2020 13:26:16 -0500) References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Glenn Morris > Cc: Eli Zaretskii , 38632@debbugs.gnu.org, rpluim@gmail.com > Date: Wed, 08 Jan 2020 13:26:16 -0500 > > > 73fd8a4 fails to build on some GNU/Linux hosts, ref eg > > https://hydra.nixos.org/build/109904668 > > systhread.c:86:1: error: conflicting types for 'sys_thread_create' > sys_thread_create (sys_thread_t *t, const char *name, > ^~~~~~~~~~~~~~~~~ > In file included from thread.h:33:0, > from lisp.h:2163, > from systhread.c:23: > systhread.h:115:13: note: previous declaration of 'sys_thread_create' was here > extern bool sys_thread_create (sys_thread_t *, thread_creation_function *, > ^~~~~~~~~~~~~~~~~ > make[1]: *** [Makefile:402: systhread.o] Error 1 Thanks, should be fixed now. From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2020 19:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: mattiase@acm.org, rpluim@gmail.com, 38632@debbugs.gnu.org Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157851209828958 (code B ref 38632); Wed, 08 Jan 2020 19:35:02 +0000 Received: (at 38632) by debbugs.gnu.org; 8 Jan 2020 19:34:58 +0000 Received: from localhost ([127.0.0.1]:51356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipH6Y-0007X0-09 for submit@debbugs.gnu.org; Wed, 08 Jan 2020 14:34:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipH6V-0007Wn-Tc for 38632@debbugs.gnu.org; Wed, 08 Jan 2020 14:34:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipH6Q-0004Ta-La; Wed, 08 Jan 2020 14:34:50 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ipH6O-00043r-LD; Wed, 08 Jan 2020 14:34:48 -0500 From: Glenn Morris References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> <834kx5bwyp.fsf@gnu.org> X-Spook: Disaster assistance Mena Hamas cypherpunk Extremism Nerve X-Ran: oow-@_nf]nn'yOS1-=2V:=aE[PmI (Eli Zaretskii's message of "Wed, 08 Jan 2020 20:54:22 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Now a different problem: thread.o: In function `run_thread': /build/1rjrmrn0sv17hak6ql2igch5f221shf2-source/src/thread.c:729: undefined reference to `sys_thread_set_name' Ref: https://hydra.nixos.org/build/109906136 From unknown Sun Jun 22 22:44:03 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38632: 27.0.50; Emacs process name is changed permanently upon creating a named thread Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jan 2020 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: mattiase@acm.org, rpluim@gmail.com, 38632@debbugs.gnu.org Received: via spool by 38632-submit@debbugs.gnu.org id=B38632.157851370731439 (code B ref 38632); Wed, 08 Jan 2020 20:02:01 +0000 Received: (at 38632) by debbugs.gnu.org; 8 Jan 2020 20:01:47 +0000 Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipHWV-0008B1-DD for submit@debbugs.gnu.org; Wed, 08 Jan 2020 15:01:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipHWU-0008Ao-41 for 38632@debbugs.gnu.org; Wed, 08 Jan 2020 15:01:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ipHWO-0003Qj-Pn; Wed, 08 Jan 2020 15:01:40 -0500 Received: from [176.228.60.248] (port=4291 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ipHWN-0000Y1-6n; Wed, 08 Jan 2020 15:01:39 -0500 Date: Wed, 08 Jan 2020 22:01:53 +0200 Message-Id: <831rs9btu6.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Glenn Morris on Wed, 08 Jan 2020 14:34:48 -0500) References: <4612F422-B860-4864-BB60-EA18468BCCDB@acm.org> <83tv57clsv.fsf@gnu.org> <7FDF4517-978D-4500-9905-F41D9C16306D@acm.org> <834kx5bwyp.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Glenn Morris > Cc: mattiase@acm.org, 38632@debbugs.gnu.org, rpluim@gmail.com > Date: Wed, 08 Jan 2020 14:34:48 -0500 > > Now a different problem: > > thread.o: In function `run_thread': > /build/1rjrmrn0sv17hak6ql2igch5f221shf2-source/src/thread.c:729: > undefined reference to `sys_thread_set_name' Fixed.