GNU bug report logs - #3863
23.1.50; possible save-match-data in copyright.el

Previous Next

Full log

Message #40 received at 3863 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 3863 <at> debbugs.gnu.org, Chong Yidong <cyd <at> stupidchicken.com>,
        Kevin Ryde <user42 <at> zip.com.au>
Subject: Re: bug#3863: 23.1.50; possible save-match-data in copyright.el
Date: Thu, 16 Jul 2009 23:23:29 -0400

> I don't think I understand, but it sounds like this is a reason why
> y-or-n-p should save match-data...

Here we go again:

All functions destroy the match-data except for a few rare exceptions,
which are simple functions doing little work.

> Is there any reason not to let y-or-n-p save match data?

If you think y-or-n-p deserves saving the match-data then pretty much
all other functions deserve that change as well.  And since
save-match-data is somewhat costly, it would imply a singificant
performance impact.


        Stefan


PS: Worse yet: during y-or-n-p, the buffer might be completely changed
by the code run asynchronously, so the "saved" match data may not even
have any meaning any more.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.