From unknown Sun Aug 10 16:51:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38628 <38628@debbugs.gnu.org> To: bug#38628 <38628@debbugs.gnu.org> Subject: Status: Character literals unsupported in source 'snippets' Reply-To: bug#38628 <38628@debbugs.gnu.org> Date: Sun, 10 Aug 2025 23:51:50 +0000 retitle 38628 Character literals unsupported in source 'snippets' reassign 38628 guix submitter 38628 Marius Bakke severity 38628 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:27:20 2019 Received: (at submit) by debbugs.gnu.org; 15 Dec 2019 20:27:20 +0000 Received: from localhost ([127.0.0.1]:37228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaU4-0003zH-5m for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:27:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:55735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaU3-0003zA-6I for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:27:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36193) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igaU0-0001VM-Um for bug-guix@gnu.org; Sun, 15 Dec 2019 15:27:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igaTz-00085i-Pi for bug-guix@gnu.org; Sun, 15 Dec 2019 15:27:16 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:36847) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1igaTz-00084B-Cz for bug-guix@gnu.org; Sun, 15 Dec 2019 15:27:15 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id DDABF223C4 for ; Sun, 15 Dec 2019 15:27:14 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 15 Dec 2019 15:27:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:date:message-id:mime-version:content-type; s= fm1; bh=/zYA+odAIui9HXG6fxmv8u1+bemUKdZ9aT8wqHU1fDM=; b=SVtOQosW xof4pQCj7iGHy/aGV3BkRq9NAoeZEiQ8343RvUQ7OulgN+GYmZ5RWQtQaiwBDAWc Nh87TFaU+dWMl8xFMdQialzXQseROVQYtoSCForJ+3e2OkIvtrSeBNMiHcwaEyE2 vpzMMDesRk5OyQazkPTFB0i8hb8FE3SFWSrdqVvL0Nq1EVGVghSPiHOabAoB/wuc yD8mhWz6nkfOmLhrnNN2cUZRVq8j4SEaf8fhaDvekelnsUpOBxX4jtSKa00MuO5m xok5f+SsMKXXoSFTHNLS87BYB4noXrD6qA3Sn8YD3MjVE1Gndq3WRrU6HLfgrqu/ p1QVPfh+FcA+lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=/zYA+odAIui9HXG6fxmv8u1+bemUK dZ9aT8wqHU1fDM=; b=O7XtqEnQdjajhR6ZdOH6IwbihCN+RtEZuexXHdCnfzN// QiOJ+BmnamNc80e0/42h8BkB2Ps8A+kxIoHb5bU9Xj5vvI/RC2DxKh6uE0bV2ye5 /j/jzi3oR96WVdyvH6VowGR/Md/X5QWdQGj+1AoNTpNk8poMRaX1J5aGjtfw+a8q STnpP9x9E6H3odSWeES0dj2mEMJwpy1KBZ7/lJRn2FVTZlB6RTPCxriX35BwpREV dyrD6IiUU6IG7FerundQihQSXenNfp2kzoC/RFzO049HtEXjO39ODJNl/2XJIoL5 70lVKbYvkUv3MLAuDTCP58z9osaOA9DJVOeRwStlA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtfedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufgffffkgggtsehgtderre dtreejnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucfkphepiedvrdduiedrudelvddrudehtdenucfrrghrrghmpe hmrghilhhfrhhomhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id 657DC80059 for ; Sun, 15 Dec 2019 15:27:14 -0500 (EST) From: Marius Bakke To: bug-guix@gnu.org Subject: Character literals unsupported in source 'snippets' User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sun, 15 Dec 2019 21:27:08 +0100 Message-ID: <87y2vdcp2b.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.111.4.25 X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Guix, If you try to use a character literal in a source 'snippet', Guix will complain about an "unsupported input". I.e. adding the following to the 'hello' package definition: (snippet '(begin #\!)) Results in: guix build: error: /home/marius/guix/gnu/packages/base.scm:73:2: package `h= ello@2.10' has an invalid input: #\! This is a fairly recent regression. I tracked it down to the following com= mit: commit 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c Author: Ludovic Court=C3=A8s Date: Mon Sep 23 22:17:39 2019 +0200 gexp: Catch and report non-self-quoting gexp inputs. =20=20=20=20 Previously we would, for example, generate build scripts in the store; when trying to run them, we'd get a 'read' error due to the presence of # syntax in there. =20=20=20=20 * guix/gexp.scm (gexp->sexp)[self-quoting?]: New procedure. [reference->sexp]: Check whether the argument in a box is self-quoting. Raise a '&gexp-input-error' condition if it's not. * tests/gexp.scm ("lower-gexp, non-self-quoting input"): New test. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl32lxwACgkQoqBt8qM6 VPpfPQgAuFcxcDqsqVTMpLD6DsxSVuNAasrXzJTM31O12nfzPSQr3mHhIDlUz+jx UYhwmZ3NYqm4xHTnSllckFcyR8HjtnJ1CCani5aWwrkw19MrNuG8UrrzUaPqEIMv 8vQMw0xNEduBrpt5qjgzyvsqb3JDX/ij6DA+ev07X6Fh5WDHvzGpPzpJdwJ9tq1v 2Cuho35izU3cUZWtKujAD7pIzDO+s3xvvEhekTv/poQ8g+h1yEE0CZd2XvOdaO54 MmHJ1TOrvg2wEbIQ9fH4i8coLJ+ujtGKc7y3iIy/G0LeOBNlP+qvUnwNCedjM65h Qmid8siF92ku2XQlV1cxFg5X5sofJQ== =LMP9 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:35:22 2019 Received: (at 38628) by debbugs.gnu.org; 15 Dec 2019 20:35:22 +0000 Received: from localhost ([127.0.0.1]:37245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igabq-0005tV-ER for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:35:22 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:60619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igabp-0005s5-2Z for 38628@debbugs.gnu.org; Sun, 15 Dec 2019 15:35:21 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 86F25223EA for <38628@debbugs.gnu.org>; Sun, 15 Dec 2019 15:35:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 15 Dec 2019 15:35:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:date:message-id:mime-version :content-transfer-encoding; s=fm1; bh=KrShyCq4KbYxeW7mB8z2a7Rbgy 6Y+Fb4il262mm1s6M=; b=FqqoxWLrcUKOEImCh0P1h6XGNV+kgBn1cl3Aak/NaS ZJmrx+ALBM4mX3873bDSfHHpTITI+CjewzPT2/fmLeVoIE378YaSdcRtfwJ1Lkqv Fn8v9KaeXfDYfn7JELbsmmykvByLFA+olm4uCbKwpCTkAZ+WKuTFfJERnZifh/pQ ZO4fDFjH6DXJU3JKBj97ft87QJJjcidCTx5vWe3DOOcoaNvHCfgsmY4rjkbb8cZs rFjxBjZkyCebBBkqnY6qOzRPauhzJZfwHM7Y7dJqyd9pjiMdRvJuNhzo1UvriiUA JmnvACLnPcSwpsIXv1yPIWkGwJTF93exkOL7Mej4I4Kw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KrShyCq4KbYxeW7mB 8z2a7Rbgy6Y+Fb4il262mm1s6M=; b=nH7SxzAfsuLYeOmfAHn3nwdh3xUdZtF17 5NrwcSWMuPWdN00b86zP7RBrBJMPCq2/QAPz8qcO/tTF5nI+uYtuJcO/JiAyIabg SjQmSsQJU0zTS4hxUX8h5boStPvWhB+CPiyVJV4jgJg7iIj4SIfotlin5ZMcYOHD RDU/FEt2qQ3mlo8rhusyn/KBn+6eZt3wnwASYmq5X5QF4YCCpO41X5zi28NeIPjU D8IuqwrEV99LZsugzWUmYsvqDnnh3+2fJpNH2lbbdR2LzKuMvuTzUzQAueTLmB2i BES5VHjI3nVdViYWaG/TpyVW9B2vwJIuOFRFE0s7owGwZLB7n7yFQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtfedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucffohhmrghinhepghhnuhdrohhrghenucfkphepiedvrdduie drudelvddrudehtdenucfrrghrrghmpehmrghilhhfrhhomhepmhgsrghkkhgvsehfrghs thhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (ti0006q161-0149.bb.online.no [62.16.192.150]) by mail.messagingengine.com (Postfix) with ESMTPA id ED7878005B for <38628@debbugs.gnu.org>; Sun, 15 Dec 2019 15:35:14 -0500 (EST) From: Marius Bakke To: 38628@debbugs.gnu.org Subject: [PATCH] gexp: Allow character literals in GEXP->SEXP. Date: Sun, 15 Dec 2019 21:35:13 +0100 Message-Id: <20191215203513.27831-1-mbakke@fastmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38628 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Fixes * guix/gexp.scm (gexp->sexp)[self-quoting?]: Add CHAR? to the tested types. --- guix/gexp.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index a96592ac76..411f0844ff 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -1028,7 +1028,7 @@ and in the current monad setting (system type, etc.)" (or (pred x) (one-of rest ...)))))) (one-of symbol? string? keyword? pair? null? array? - number? boolean?))) + number? boolean? char?))) (define* (reference->sexp ref #:optional native?) (with-monad %store-monad -- 2.24.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 16:51:31 2019 Received: (at 38628) by debbugs.gnu.org; 16 Dec 2019 21:51:31 +0000 Received: from localhost ([127.0.0.1]:40423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igyH4-00050d-Pr for submit@debbugs.gnu.org; Mon, 16 Dec 2019 16:51:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igyH3-00050Q-06 for 38628@debbugs.gnu.org; Mon, 16 Dec 2019 16:51:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1igyGx-00066t-Pu; Mon, 16 Dec 2019 16:51:23 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42934 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1igyGx-0006By-6O; Mon, 16 Dec 2019 16:51:23 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP. References: <87y2vdcp2b.fsf@devup.no> <20191215203513.27831-1-mbakke@fastmail.com> Date: Mon, 16 Dec 2019 22:51:21 +0100 In-Reply-To: <20191215203513.27831-1-mbakke@fastmail.com> (Marius Bakke's message of "Sun, 15 Dec 2019 21:35:13 +0100") Message-ID: <878sncdjmu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38628 Cc: 38628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Marius Bakke skribis: > Fixes > > * guix/gexp.scm (gexp->sexp)[self-quoting?]: Add CHAR? to the tested type= s. Oops, good catch, LGTM! Could you also fix the occurrences of the =E2=80=98one-of=E2=80=99 macro in= (gnu tests) and (guix repl)? (I know, this shouldn=E2=80=99t be duplicated in the first place but (guix = repl) has to be self-contained=E2=80=A6) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 16:53:19 2019 Received: (at 38628) by debbugs.gnu.org; 16 Dec 2019 21:53:19 +0000 Received: from localhost ([127.0.0.1]:40427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igyIp-00055u-7Z for submit@debbugs.gnu.org; Mon, 16 Dec 2019 16:53:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igyIn-00055h-LC for 38628@debbugs.gnu.org; Mon, 16 Dec 2019 16:53:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1igyIi-0000Xu-FN; Mon, 16 Dec 2019 16:53:12 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42938 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1igyIi-0006Id-1d; Mon, 16 Dec 2019 16:53:12 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP. References: <87y2vdcp2b.fsf@devup.no> <20191215203513.27831-1-mbakke@fastmail.com> <878sncdjmu.fsf@gnu.org> Date: Mon, 16 Dec 2019 22:53:10 +0100 In-Reply-To: <878sncdjmu.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Mon, 16 Dec 2019 22:51:21 +0100") Message-ID: <874ky0djjt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38628 Cc: 38628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Also it would be nice to add a tiny test close to the one that 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 14:00:14 2019 Received: (at 38628) by debbugs.gnu.org; 18 Dec 2019 19:00:14 +0000 Received: from localhost ([127.0.0.1]:43911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iheYQ-0005d4-79 for submit@debbugs.gnu.org; Wed, 18 Dec 2019 14:00:14 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iheYP-0005cm-2L for 38628@debbugs.gnu.org; Wed, 18 Dec 2019 14:00:13 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D1A942208A; Wed, 18 Dec 2019 14:00:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 18 Dec 2019 14:00:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=ItLOV7d3NxWgXszKftmqjwxGuP mNJrbdENTdfMhd/e0=; b=EvkcL9fy+tXipLz2c2y0qXXJeZnNPayuAW+zC3QYF2 /WUAOpeId4wTDjL6FEv2AhlsKN4zBEGGIwBzPEA59PMPpVfZRHKZ9cWejN+ew1Yc z4tx55AMawZ4dFiiolLnc4NWtra89xOLczV1GGe12x/7T+nBjDb6h44jwx9+vbHp dDJ/bc41dSHkDseiYu5O71/TQ961ae8zcXP+5GPT+IgxorMmo6C69zTY9jONEfK5 x9zEtMHFygVPatTOULyQuQ+0w67bcm5LRE75z3Rox+na1YzpZj4/jt2gtrcBcV9y E3nQlyUN5eF6Pq0CmhoeDGVhCzXSJ4W0wTCKPicsxo0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ItLOV7 d3NxWgXszKftmqjwxGuPmNJrbdENTdfMhd/e0=; b=rSTYn7k1SkM4rwM7k1BH8h xQ97PgQu1X7bIx3vWueVgzgcnIp9o/cRTzGioEOvk5kIrV4eJr12FzJjrgNRBkU9 /h/saOp/GC770PL5llcPfOttOG7saaiocBwcAl38va6NuQvYzaCCASMJHj00DjnA Z82v43bTz8MxJROMb6WIG37TDEOFecx+sIU7x82k8/U+56KconQpLvOBkpKGoTPZ ebaX3cwiaS/ExYfoAurJ0Dya950hbop7Dbffdxx9/C4R85GzFu81ZKRgbk8dVUDb vXBXxj7sFQ6hhjIinfXN3T+U+/dR5awuTVDu7huhxt7gr1v7BRgp+grtwO/a3Lrg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtledgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertderjeenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecukfhppe ekgedrvddtvddrieelrddvheefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhk vgesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id EBE1A8006C; Wed, 18 Dec 2019 14:00:06 -0500 (EST) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP. In-Reply-To: <874ky0djjt.fsf@gnu.org> References: <87y2vdcp2b.fsf@devup.no> <20191215203513.27831-1-mbakke@fastmail.com> <878sncdjmu.fsf@gnu.org> <874ky0djjt.fsf@gnu.org> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 18 Dec 2019 19:59:59 +0100 Message-ID: <87mubpcvdc.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38628 Cc: 38628@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Also it would be nice to add a tiny test close to the one that > 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added. Good idea. I came up with this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/tests/gexp.scm b/tests/gexp.scm index 84c16422c2..8b1596f66d 100644 --- a/tests/gexp.scm +++ b/tests/gexp.scm @@ -886,6 +886,12 @@ (run-with-store %store (lower-gexp #~(foo #$+))))) +(test-equal "lower-gexp, character literal" + '(#\+) + (lowered-gexp-sexp + (run-with-store %store + (lower-gexp #~(#\+))))) + (test-assertm "gexp->derivation #:references-graphs" (mlet* %store-monad ((one (text-file "one" (random-text))) --=-=-= Content-Type: text/plain WDYT? --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl36dy8ACgkQoqBt8qM6 VPrgsgf+JoBk+sQR1w01jqAyYbPN3a1HyqTt/saW5h5veRJ365EfesdqIa2A9QJD y4w+ibZFBjei68Y7wfTGxPDK9rBvqDs9ruKVIASBD4K/k7RzF/uOXub85hOv2Bts xfiEMsN/YmAegXTTnOLD5ejF2zBxRMIVjXH6+GlDKwPAMSgrHcKJTeqTax+7XNAB CFwx1b0RDfS1T0CpwdH542OD8+vfbrWZqic1SH7IUr8LUOO+GkklO2esNhe9qTr+ ACNEl/cCQkI42cGvAZnGo/5y5eGsuXMU2kIoSXdlsHzvDnH3kNEQ3DGI+QSIpP+9 K5zhv70+qpasN6LxuLsecI/o6HXOmw== =xrAY -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 17:06:30 2019 Received: (at 38628-done) by debbugs.gnu.org; 18 Dec 2019 22:06:30 +0000 Received: from localhost ([127.0.0.1]:44072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihhSg-00049e-IC for submit@debbugs.gnu.org; Wed, 18 Dec 2019 17:06:30 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihhSe-00049P-Mw for 38628-done@debbugs.gnu.org; Wed, 18 Dec 2019 17:06:29 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7000120C69; Wed, 18 Dec 2019 17:06:23 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 18 Dec 2019 17:06:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm1; bh=89M2WzlWWNlrgIlysUGgdg2BtP v/pqiHfvzneuNi5sQ=; b=SxYEIiqmX7i/IOiGU3mY5chdEe5B3B6nmSKAFWdWuM 8jRhaiiYRiAUo5YpKx+YfZF6o3XXIsq/xI+2qzj9YxIVU3gFYr5QJVhqG77zLwoP ftF6sActLYLyO7Up9PqoiZl+N439WSehv+ZJpQ9Dy1Kiy6feiTkwBcXQIi4C+Tip LUpK4RaIPP2ZFSjBgXn6CIMBCVh2Fgj86rigJlJ5BLqihoXPnqeHhS4gsrQY26tO oirRM7+o5/cdzszoN91nDaSDQfxghV/okVPE9Tupalkjxnib4NCRTgtYsLwcl4zH kg+PmC581vnP7g1JjftPNCshlQi9DGd70uUm7zR4VKYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=89M2Wz lWWNlrgIlysUGgdg2BtPv/pqiHfvzneuNi5sQ=; b=ZTKqRfp+ujFtumxV6LAxiw sfDb05+BzMfQNauA+WmRJGiy9fTcExWX+bH2dZS+W+iCM4O4W6Em4r69HHE98Orv gDUcR6uAkIMKbGQyN8qNsYgT+usi7lizVyMC0QfwAUGYUmg/CdYf8L3zq0zSjNtC aZdwAe2oa0bDEt/dWQ7wWhoXFIKhAyvBh/uNNrpVx3khHTMX5MlrPU7FTuxUAfzu tM6M//oVUSwngq+wrYffLO6Q3X+dVCj+rL5xyIdF/7uYMWQXIFDFub+yBhQ50g9h AgRHQm2QameklyZJ1p47Xcf2FsGUppozUN6zuGtJZmVSqPN3oyLPsQjpjYx0/pvg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtledgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertderjeenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecukfhppe ekgedrvddtvddrieelrddvheefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhk vgesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (ti0006q161-3035.bb.online.no [84.202.69.253]) by mail.messagingengine.com (Postfix) with ESMTPA id D96668005A; Wed, 18 Dec 2019 17:06:22 -0500 (EST) From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP. In-Reply-To: <87mubpcvdc.fsf@devup.no> References: <87y2vdcp2b.fsf@devup.no> <20191215203513.27831-1-mbakke@fastmail.com> <878sncdjmu.fsf@gnu.org> <874ky0djjt.fsf@gnu.org> <87mubpcvdc.fsf@devup.no> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Wed, 18 Dec 2019 23:06:21 +0100 Message-ID: <877e2tcmqq.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38628-done Cc: 38628-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Marius Bakke writes: > Ludovic Court=C3=A8s writes: > >> Also it would be nice to add a tiny test close to the one that >> 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added. > > Good idea. I came up with this: > > diff --git a/tests/gexp.scm b/tests/gexp.scm > index 84c16422c2..8b1596f66d 100644 > --- a/tests/gexp.scm > +++ b/tests/gexp.scm > @@ -886,6 +886,12 @@ > (run-with-store %store > (lower-gexp #~(foo #$+))))) >=20=20 > +(test-equal "lower-gexp, character literal" > + '(#\+) > + (lowered-gexp-sexp > + (run-with-store %store > + (lower-gexp #~(#\+))))) > + > (test-assertm "gexp->derivation #:references-graphs" > (mlet* %store-monad > ((one (text-file "one" (random-text))) > > WDYT? I ended up pushing this in ab7010af1f1077c056529769a53a380147c3933f, even though I suspect there is an easier test that could reveal this problem without involving the store, somewhere. Improvements welcome. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl36ot0ACgkQoqBt8qM6 VPo8rQf/aW7skmVCzWzSjvZbm/0kcnOr0U498EVAN1rzVO1KT5FtGHjzMzTJ7Byn 65vZSw8Jj7Uc9YdZ9F9+pOOeASOnk/uJvN6uZC6i3uBna9A2OzBJjUVjmlhP5Jvm LKTll2coyic3ZGMQv+J65IaJxYaLw4R8oD4AqGmwAMmsgQbuDH3XGycYGoajseRs LUT+VnHUAKz7DGBlwzajhPjNT0IojyEi3MUs/c62wIqavaUcoFqq5NXQ17xtj3jR ST8qgadNxxdnsc5PNUmD7m3NENQnF48pt7qM34/f5qaBmKrspjBlOX954hJkT95d aOSOsd1+YJHZZfKI9XinjyX8SkVU8A== =uQI6 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 06:11:54 2019 Received: (at 38628-done) by debbugs.gnu.org; 19 Dec 2019 11:11:54 +0000 Received: from localhost ([127.0.0.1]:44317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihtik-0001uI-CV for submit@debbugs.gnu.org; Thu, 19 Dec 2019 06:11:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihtii-0001u1-EQ for 38628-done@debbugs.gnu.org; Thu, 19 Dec 2019 06:11:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ihtic-00024L-RK; Thu, 19 Dec 2019 06:11:47 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=44008 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ihtib-0001sW-Ck; Thu, 19 Dec 2019 06:11:46 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: bug#38628: [PATCH] gexp: Allow character literals in GEXP->SEXP. References: <87y2vdcp2b.fsf@devup.no> <20191215203513.27831-1-mbakke@fastmail.com> <878sncdjmu.fsf@gnu.org> <874ky0djjt.fsf@gnu.org> <87mubpcvdc.fsf@devup.no> <877e2tcmqq.fsf@devup.no> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Frimaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 19 Dec 2019 12:11:44 +0100 In-Reply-To: <877e2tcmqq.fsf@devup.no> (Marius Bakke's message of "Wed, 18 Dec 2019 23:06:21 +0100") Message-ID: <87pngktvrj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38628-done Cc: 38628-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Marius, Marius Bakke skribis: > Marius Bakke writes: > >> Ludovic Court=C3=A8s writes: >> >>> Also it would be nice to add a tiny test close to the one that >>> 24ab804ce11fe12ff49cd144a3d9c4bfcf55b41c added. >> >> Good idea. I came up with this: >> >> diff --git a/tests/gexp.scm b/tests/gexp.scm >> index 84c16422c2..8b1596f66d 100644 >> --- a/tests/gexp.scm >> +++ b/tests/gexp.scm >> @@ -886,6 +886,12 @@ >> (run-with-store %store >> (lower-gexp #~(foo #$+))))) >>=20=20 >> +(test-equal "lower-gexp, character literal" >> + '(#\+) >> + (lowered-gexp-sexp >> + (run-with-store %store >> + (lower-gexp #~(#\+))))) >> + >> (test-assertm "gexp->derivation #:references-graphs" >> (mlet* %store-monad >> ((one (text-file "one" (random-text))) >> >> WDYT? > > I ended up pushing this in ab7010af1f1077c056529769a53a380147c3933f, > even though I suspect there is an easier test that could reveal this > problem without involving the store, somewhere. Improvements welcome. We could have called =E2=80=98gexp->sexp=E2=80=99 directly, but we=E2=80=99= d still need the store anyway, so IMO that=E2=80=99s good! Thanks, Ludo=E2=80=99. From unknown Sun Aug 10 16:51:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Jan 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator