Subject: Re: [bug#38625] [PATCH] music.scm: Add glyr

From: Ricardo Wurmus <[email-masked]>
Date: Sun, 15 Dec 2019 23:31:55 +0100

Hi Riku,

thank you for your contribution.
Could you please resend this as a git formatted patch?  See the
Contributing section in the manual for more information on the workflow.

>>     (source
>>      (origin
>>        (method url-fetch)
>>        (uri (string-append "https://github.com/sahib/glyr/archive/"
>>                            version ".tar.gz"))

These /archive tarballs are automatically generated, so they can change
in place without prior notice.  Please use git-fetch instead.

>>     (arguments
>>      '(#:tests? #f)) ; no check target))

Please remove the trailing “))”.

>>     (inputs
>>      `(("glib" ,glib)
>>        ("curl" ,curl)
>>        ("sqlite" ,sqlite)
>>        ("pkg-config" ,pkg-config)))

pkg-config should be a native-input.

>>     (home-page "https://github.com/sahib/glyr")
>>     (synopsis "Search engine for music related metadata")
>>     (description
>>      "It comes both in a command-line interface tool (@command{glyrc})
> and as a C library (libglyr), both […]

Please “reflow” the description to fit 80 columns and perhaps shorten it
a little.

>>     (license license:lgpl3)))

Only version 3 or also any other version?

-- 
Ricardo