From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 14 16:01:21 2019 Received: (at submit) by debbugs.gnu.org; 14 Dec 2019 21:01:21 +0000 Received: from localhost ([127.0.0.1]:35810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igEXR-0002YU-6c for submit@debbugs.gnu.org; Sat, 14 Dec 2019 16:01:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:58488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igEXP-0002YM-C4 for submit@debbugs.gnu.org; Sat, 14 Dec 2019 16:01:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49892) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igEXN-0001lz-MK for guix-patches@gnu.org; Sat, 14 Dec 2019 16:01:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igEXM-0005Ic-Cw for guix-patches@gnu.org; Sat, 14 Dec 2019 16:01:17 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:51362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1igEXM-0005ES-2F for guix-patches@gnu.org; Sat, 14 Dec 2019 16:01:16 -0500 Received: by mail-wm1-x330.google.com with SMTP id d73so2491173wmd.1 for ; Sat, 14 Dec 2019 13:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=user-agent:from:to:subject:date:message-id:mime-version; bh=DaMSgNhyBN4dlpRJ0HnYuGqPqNXcIMlYOy9XGqybzlA=; b=pNFxh4dZ9nXBCbrkvWBEHoCCssEGn7L+xGGqAM2Y/rsfWkZCFz57xZwsq7h53pNfXm 3rvI0MvWDVdSMvStbuprvuoJRY4aqz9Ru96tvpDnA9kiEiWMqtVzPry/IM2SDbDwTg+g zrI4rnJnYN8VArF6q4oRqUElp8yEilH8YzZ89LfGJAjBDAhiePzuvEI/aIrKL611D4cy H+TGLPnta93HId8mafZARKYtTaH1vLOssiSr/tGw9o4xJ/GHH7hFks804Q9UKWC0enfH rfOlLHaauJJxXdFNyKBhlq0M5F1MPZg8swIDhG0hyZGXQXWPPDNvR7h6ylvczNfKoYKe aViA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:user-agent:from:to:subject:date:message-id :mime-version; bh=DaMSgNhyBN4dlpRJ0HnYuGqPqNXcIMlYOy9XGqybzlA=; b=C3tw01nuK1z1HSIzMRNpDVmuq2gkZ4uJXWIusuT3nQvGoiZKQpJWwuG04//sObXgJZ mKcEuvLnFuw8k1+mSvd6jaL3g5la2/nYlXlK/F/ICldUPGiU1Hm3p/V3Jz3R6W29pCYf Y5g13ZNF+3SsLXynaUPW6EL2fTc5VAwe7746w3Wh0b6UWz45ZSMRUyrhwpJyFbk7jIfY FpltLwmqHQt9V1c8i7d7YJf388RTuTtzEBENKtMEeMgy2OqZ0X0q0hg1UGA0aXDmHnt7 U5XBMJpA/qIHWURiiai3J8/cTkqokjRRD1Ft2+rVHNJDcmV4BaU5rYn/64SJaszZdGg/ Be3w== X-Gm-Message-State: APjAAAVr5Ep6DoWH1K3F1iuvoR412JzHxYh/g6bV+euw3kE/d6X9ED2r Z7i6Kc+YDhgKFKG1jfMHCRRAfEFk X-Google-Smtp-Source: APXvYqznC312jfKoXLoG8kSeYBaO+gZfGDqtPaTtSr4RCdZy0Jq/OhbgyIQmXHGOnhnuRkfi75wQ/w== X-Received: by 2002:a05:600c:2c44:: with SMTP id r4mr19760852wmg.140.1576344102974; Sat, 14 Dec 2019 09:21:42 -0800 (PST) Received: from cervin ([2a01:e0a:fa:a50:7432:4a59:232e:bf96]) by smtp.gmail.com with ESMTPSA id r5sm14086937wrt.43.2019.12.14.09.21.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2019 09:21:41 -0800 (PST) User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: guix-patches@gnu.org Subject: Pass system and target arguments to gexp->file. Date: Sat, 14 Dec 2019 18:21:40 +0100 Message-ID: <87a77ug6vv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::330 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello, The attached patch fixes issues encountered when cross-compiling a system. gexps passed to gexp->file were not honoring target argument. Mathieu --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-gexp-Add-system-and-target-support-to-gexp-file.patch Content-Transfer-Encoding: quoted-printable >From 67c3982503c4d9ab4c77b5df295957abbe60dfeb Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 14 Dec 2019 17:52:53 +0100 Subject: [PATCH] gexp: Add system and target support to gexp->file. * guix/gexp.scm (gexp->file): Add system and target arguments and pass them= to gexp->derivation and load-path-expression calls, (scheme-file-compiler): adapt accordingly to pass system and target argumen= ts. --- guix/gexp.scm | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index a96592ac76..ca436b5a66 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -2,6 +2,7 @@ ;;; Copyright =C2=A9 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Court=C3= =A8s ;;; Copyright =C2=A9 2018 Cl=C3=A9ment Lassieur ;;; Copyright =C2=A9 2018 Jan Nieuwenhuizen +;;; Copyright =C2=A9 2019 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -456,7 +457,10 @@ This is the declarative counterpart of 'gexp->file'." ;; Compile FILE by returning a derivation that builds the file. (match file (($ name gexp splice?) - (gexp->file name gexp #:splice? splice?)))) + (gexp->file name gexp + #:splice? splice? + #:system system + #:target target)))) =20 ;; Appending SUFFIX to BASE's output file name. (define-record-type @@ -1603,7 +1607,9 @@ imported modules in its search path. Look up EXP's m= odules in MODULE-PATH." (define* (gexp->file name exp #:key (set-load-path? #t) (module-path %load-path) - (splice? #f)) + (splice? #f) + (system (%current-system)) + target) "Return a derivation that builds a file NAME containing EXP. When SPLIC= E? is true, EXP is considered to be a list of expressions that will be splice= d in the resulting file. @@ -1626,10 +1632,14 @@ Lookup EXP's modules in MODULE-PATH." exp (gexp ((ungexp exp))))= ))))) #:local-build? #t - #:substitutable? #f) + #:substitutable? #f + #:system system + #:target target) (mlet %store-monad ((set-load-path (load-path-expression modules module-path - #:extensions extensions))) + #:extensions extensions + #:system system + #:target target))) (gexp->derivation name (gexp (call-with-output-file (ungexp output) @@ -1642,7 +1652,9 @@ Lookup EXP's modules in MODULE-PATH." (gexp ((ungexp exp))= ))))))) #:module-path module-path #:local-build? #t - #:substitutable? #f)))) + #:substitutable? #f + #:system system + #:target target)))) =20 (define* (text-file* name #:rest text) "Return as a monadic value a derivation that builds a text file containi= ng --=20 2.24.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 09:50:51 2019 Received: (at 38612) by debbugs.gnu.org; 15 Dec 2019 14:50:51 +0000 Received: from localhost ([127.0.0.1]:36065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igVER-0002Qy-Fu for submit@debbugs.gnu.org; Sun, 15 Dec 2019 09:50:51 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igVEP-0002Qj-Q8 for 38612@debbugs.gnu.org; Sun, 15 Dec 2019 09:50:50 -0500 Received: by mail-wr1-f53.google.com with SMTP id c14so4117364wrn.7 for <38612@debbugs.gnu.org>; Sun, 15 Dec 2019 06:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version; bh=Ay9jY6j1gjclwgVGdGTQPgzIh1DxXTFImcJMZSi+664=; b=DmidmqCGIJSC8nWPJsLoooK7TWVP21EdDmwclpMsImI8obSxhtXJLbR4K3Bh9ReyBs 57zjlLiJ4BwyQitv/IN77QBt3yh/U6l6alhH6zjfb2PrBtcU3W9NOkcyQsg9MnKfWezQ WNKqqN4VIo2vYRn24o6fbfbHooHjQ2RwrZ0y+Yqkwa4OtR4G4o/4v2AOg9NxC06iLdVV OWFDdDU4wXLud8t4jHSBEJYdP7qRFY2J54q5M1xPJNBE3KVB7ktX5y7GEyLpfiB7QpyM qAo4cz1oO4E657SVTMAnpn+UpdztYgGAsaKFvgrW9XlYx6DoxCgKbWd+6NPB83fSaelr hJQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version; bh=Ay9jY6j1gjclwgVGdGTQPgzIh1DxXTFImcJMZSi+664=; b=n14+O/hxDceQ+DWv0gLHXcYsoLXbRfgVfSAVmcIqLqmgb++w5XWV+kMQ9yR4CZknHZ aYJnBZJSAzBkFG7XOOjQikyaLXbDvP1oAWcQ1bOEQ0YzJBVX3Bo0aqCR+Ogrcdlj6ga5 qOm1Gqj6OHrvCLWleyj/EjhiWZoPUt0+KEdRX58iC64abq0bHUM0Qm/TiewhV0GRFtF2 XhCmCC6DFyGBDbz/OQihR1pK9NIh7eOqwFX3XMOADCAvF5TIGdEHBtj+7vhwNP1yqDm5 t/XHQCpG+UYgse++hpKHH7h+95gr856qezjjjGI8dz/G4zJHxfukcPrfTgIwRWFWSiiJ EGQg== X-Gm-Message-State: APjAAAUAuUGAKwEygT2PFvwOVSgqdUTreMmpEn34AAKkWPOkSsZ8yNMq lni/YuffvXfsbyh0SWSKjhCVRIVn X-Google-Smtp-Source: APXvYqw0tsxx669FQqQX+s3oCWyhbQG7ObDwh/wJLjjOefkPGOeR3Hm7LvMnfdJrJzlTGIoS7sIrHw== X-Received: by 2002:a5d:6703:: with SMTP id o3mr26336094wru.235.1576421443914; Sun, 15 Dec 2019 06:50:43 -0800 (PST) Received: from cervin ([2a01:e0a:fa:a50:7432:4a59:232e:bf96]) by smtp.gmail.com with ESMTPSA id c15sm17453784wrt.1.2019.12.15.06.50.42 for <38612@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Dec 2019 06:50:42 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: 38612@debbugs.gnu.org Subject: Re: Pass system and target arguments to gexp->file. In-reply-to: <87a77ug6vv.fsf@gmail.com> Date: Sun, 15 Dec 2019 15:50:41 +0100 Message-ID: <8736dl8wxq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain In the same spirit, here's another patch to fix profile-derivation. Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-profile-derivation-Use-current-system-and-target.patch >From 964f14a8bbd420f0f9207f1a666badaaaf625e3e Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 14 Dec 2019 18:39:59 +0100 Subject: [PATCH] profile-derivation: Use current system and target. * guix/profiles.scm (profile-derivation): Use current system and target. --- guix/profiles.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/profiles.scm b/guix/profiles.scm index 616605151e..a328e40687 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -1438,7 +1438,8 @@ MANIFEST." (locales? #t) (allow-collisions? #f) (relative-symlinks? #f) - system target) + (system (%current-system)) + (target (%current-target-system))) "Return a derivation that builds a profile (aka. 'user environment') with the given MANIFEST. The profile includes additional derivations returned by the monadic procedures listed in HOOKS--such as an Info 'dir' file, etc. -- 2.24.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 16:41:37 2019 Received: (at 38612) by debbugs.gnu.org; 20 Dec 2019 21:41:37 +0000 Received: from localhost ([127.0.0.1]:47328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiQ1g-0000t6-US for submit@debbugs.gnu.org; Fri, 20 Dec 2019 16:41:37 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiQ1f-0000su-HZ for 38612@debbugs.gnu.org; Fri, 20 Dec 2019 16:41:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iiQ1a-00010u-4j; Fri, 20 Dec 2019 16:41:30 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59798 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iiQ1Z-0006xW-OS; Fri, 20 Dec 2019 16:41:29 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> Date: Fri, 20 Dec 2019 22:41:26 +0100 In-Reply-To: <87a77ug6vv.fsf@gmail.com> (Mathieu Othacehe's message of "Sat, 14 Dec 2019 18:21:40 +0100") Message-ID: <87h81uptdl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Mathieu Othacehe skribis: >>>From 67c3982503c4d9ab4c77b5df295957abbe60dfeb Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 14 Dec 2019 17:52:53 +0100 > Subject: [PATCH] gexp: Add system and target support to gexp->file. > > * guix/gexp.scm (gexp->file): Add system and target arguments and pass th= em to > gexp->derivation and load-path-expression calls, > (scheme-file-compiler): adapt accordingly to pass system and target argum= ents. Good catch, LGTM! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 16:45:35 2019 Received: (at 38612) by debbugs.gnu.org; 20 Dec 2019 21:45:35 +0000 Received: from localhost ([127.0.0.1]:47332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiQ5X-0000z1-Er for submit@debbugs.gnu.org; Fri, 20 Dec 2019 16:45:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiQ5V-0000yo-RC for 38612@debbugs.gnu.org; Fri, 20 Dec 2019 16:45:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iiQ5Q-00083P-Km; Fri, 20 Dec 2019 16:45:28 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59802 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iiQ5O-0007Co-KA; Fri, 20 Dec 2019 16:45:27 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> Date: Fri, 20 Dec 2019 22:45:24 +0100 In-Reply-To: <8736dl8wxq.fsf@gmail.com> (Mathieu Othacehe's message of "Sun, 15 Dec 2019 15:50:41 +0100") Message-ID: <87d0cipt6z.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe skribis: > --- a/guix/profiles.scm > +++ b/guix/profiles.scm > @@ -1438,7 +1438,8 @@ MANIFEST." > (locales? #t) > (allow-collisions? #f) > (relative-symlinks? #f) > - system target) > + (system (%current-system)) > + (target (%current-target-system))) > "Return a derivation that builds a profile (aka. 'user environment') w= ith > the given MANIFEST. The profile includes additional derivations returne= d by > the monadic procedures listed in HOOKS--such as an Info 'dir' file, etc. AFAICS this change is unnecessary and even incorrect: the (mlet* %store-monad ((system (if system (return system) (current-system))) trick ensures that we get the system that current at the time of the monadic bind, whereas your change get the system and target that are current at the time of the call. It=E2=80=99s a terrible pitfall, I know=E2=80=A6 Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 09:08:32 2019 Received: (at 38612) by debbugs.gnu.org; 24 Dec 2019 14:08:32 +0000 Received: from localhost ([127.0.0.1]:52022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijkrQ-0005YK-0B for submit@debbugs.gnu.org; Tue, 24 Dec 2019 09:08:32 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:40942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijkrO-0005Y7-JM for 38612@debbugs.gnu.org; Tue, 24 Dec 2019 09:08:31 -0500 Received: by mail-wm1-f48.google.com with SMTP id t14so2584803wmi.5 for <38612@debbugs.gnu.org>; Tue, 24 Dec 2019 06:08:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=0SpjvUYKR6gHntLndch14dHbofxntZBC38z2GgMEbRo=; b=D5O+8B1X1GWE9OUFo0rXTQELJll0sQbmP04ktIZqvWPTdtgTlgRs1aEkYVr31RKj+J NXq+JlwA9EETUMIizWUzB4o7ZbXunG7gBp4XH31sfL5/YazM4kLDTIfTn7b77Pw8X9HJ fWSJyc2rP2d3G93IHSLA/H/ab8BDat3NTWXFadDCXtFULddlide4ybHC+op37fya+xiq ak+54iTty+NSX2n1o+Tr0YuGNDTo9WFtGlOTZaA1zqRgr1bLxKjLbkQDOniEGeuQEXCD SkvfC9YvxNpsxWEC9S39fZ9xhnIQ4rioCCyoy7cu5RLrbtkDOl943rMCQ4UmUDLwcbsW rOkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=0SpjvUYKR6gHntLndch14dHbofxntZBC38z2GgMEbRo=; b=Ro33HkxyoYCEWsb04LuQGlk51B7H2qpMDyVCDjrKppWjF9E6+A1Of7q7O/nO5iBGZ+ GzEQ1PseLfhpaxnV5GRSE5k6GoV/dmkbwV3SyYRQdi6HgtLzFeNyOvGz/SAtlh40tkWW eVlpBeX9DpKNI02mjbKRxJkFUdCRhhl/iJmXjU4/KPB2JrE1WyEyeJ/iOjWLcQE+bPoj g+NJJxYh2FBINODZy5APaqo8tuCKEOVUwI5mzSqNelCdta4VRH0HQUvSVgYu2bPaym+9 GYWMYcR/HerToc+eyXYiL/vTSR4YRGmma5AQpZlS9Vtg6GSWqCcLSg9adMKxanlwUwma g2Ew== X-Gm-Message-State: APjAAAXLE6LFKFgK2mFzIXNg2ygnUGEOgK1+4LI2F37+5viOcn1fsRd6 +sWQPyrAzBnQc/lXKnKRiKhFROpH X-Google-Smtp-Source: APXvYqxXXyYSZBvPgk5+6tg7syA8rPEAB6ZAVmIPSnq2/sjvmXLCOgrAJHOX1pXHu8e9Vo9Tk2ndlw== X-Received: by 2002:a1c:407:: with SMTP id 7mr4357202wme.29.1577196504495; Tue, 24 Dec 2019 06:08:24 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:a14b:cea0:a27:c884]) by smtp.gmail.com with ESMTPSA id v188sm2799896wma.10.2019.12.24.06.08.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2019 06:08:23 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <87h81uptdl.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87h81uptdl.fsf@gnu.org> Date: Tue, 24 Dec 2019 15:08:21 +0100 Message-ID: <87sgl97r56.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Good catch, LGTM! Pushed, thanks! Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 24 09:11:23 2019 Received: (at 38612) by debbugs.gnu.org; 24 Dec 2019 14:11:23 +0000 Received: from localhost ([127.0.0.1]:52027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijkuB-0005ci-Dq for submit@debbugs.gnu.org; Tue, 24 Dec 2019 09:11:23 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:43871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ijku9-0005cS-1y for 38612@debbugs.gnu.org; Tue, 24 Dec 2019 09:11:22 -0500 Received: by mail-wr1-f45.google.com with SMTP id d16so19906689wre.10 for <38612@debbugs.gnu.org>; Tue, 24 Dec 2019 06:11:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=USzQ/t+4sro1ZsP/siaQu0Gk3JDSrXPHRe2sR4TykYM=; b=fTclHS/UmLQE3KQi+y7cSrZu0v1YfmZ62//z9AJuFSsnx8KuuaHgDfs4sPOhAVSu91 T9uuT1hOB/bU/ApEx7M/YlCG9stXJMAsoWImzbbGkaRjE0WvIzfbCi87UFGqPJjmJtlh oWO4SLf6FlvuJ92suaFjbP+xD9WDl7eZnt/kfNrikwwpganDkhmg4LpB7FZ8U/MN2+Ol 20mVFQ0Dw7HnBJlnQK9FRTxQYfHGn4ENlfmePmR18IkmOu19CBFZrDYzufg25fMgflV5 sznqI5cbAKSmdrH1uJmxqLfGGqN7FXYvrAQG6WsgE6mVR/ubJOOah6r7yUOIo13yHgTA McFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=USzQ/t+4sro1ZsP/siaQu0Gk3JDSrXPHRe2sR4TykYM=; b=rHxaoHWgZ329gokIYK2R3NDLvPbSEkT55E47zrKIo944NnpIup71i3F86tRBt/1B+4 UGZ7C30HysPsDIJcInYiGVRcfoV6vEKm8wU6d2M18shQ+c46IXGKuGS+jRQyobqSOr1V pcDkQLiviDgV3n3HOS9s8XuHbaK/SxqZOzsR/7I9mGWMeaRUNUtR22g5+weN744xqVOg s0APFgJPrvboULoh1f/w88zukJfej/T2mhTz1spmENEkAl9RHwNdV7xzHNWxudnwI/E+ VGOQ5tiyocvbx7FV5E+895RwwLWy3kz4fUzG0DuMxGW0yDHLgHi4aLu90+n/UZqhNQuD jigg== X-Gm-Message-State: APjAAAXw1ufS19CHa0LzkTJBDhJ2uz+gyIhR9UpljAVxhZs42LaXf3CJ xFso9BOba19Ml5zgZGcMOHtcEplc X-Google-Smtp-Source: APXvYqxYH5NgPVIwUdDU/pFaWC5kxp26mO3kN92vkXmi5GElbUOe1eY3bY4PAnRkc4hDH5ObRiqB0A== X-Received: by 2002:adf:d184:: with SMTP id v4mr35494347wrc.76.1577196675070; Tue, 24 Dec 2019 06:11:15 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:a14b:cea0:a27:c884]) by smtp.gmail.com with ESMTPSA id y6sm23922324wrl.17.2019.12.24.06.11.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2019 06:11:14 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87d0cipt6z.fsf@gnu.org> Date: Tue, 24 Dec 2019 15:11:08 +0100 Message-ID: <87r20t7r0j.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, > trick ensures that we get the system that current at the time of the > monadic bind, whereas your change get the system and target that are > current at the time of the call. > > It=E2=80=99s a terrible pitfall, I know=E2=80=A6 Ok, then, I used the same trick to read %current-target-system at bind time. With this trick, target is set to the value passed to the guix system command (it is #f otherwise). WDYT? Mathieu --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-profiles-Fix-profile-derivation-cross-compilation.patch Content-Transfer-Encoding: quoted-printable >From c8b0e65d9b264bd484c7c6571c2ce3d68173b057 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 24 Dec 2019 15:04:57 +0100 Subject: [PATCH] profiles: Fix profile-derivation cross-compilation. * guix/store.scm (current-target-system): New exported monadic procedure. * guix/profiles.scm (profile-derivation): Set target at bind time using the above procedure. --- guix/profiles.scm | 4 ++++ guix/store.scm | 7 +++++++ 2 files changed, 11 insertions(+) diff --git a/guix/profiles.scm b/guix/profiles.scm index 987bab4e7f..d20f06e7b3 100644 --- a/guix/profiles.scm +++ b/guix/profiles.scm @@ -9,6 +9,7 @@ ;;; Copyright =C2=A9 2017 Huang Ying ;;; Copyright =C2=A9 2017 Maxim Cournoyer ;;; Copyright =C2=A9 2019 Kyle Meyer +;;; Copyright =C2=A9 2019 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -1459,6 +1460,9 @@ are cross-built for TARGET." (mlet* %store-monad ((system (if system (return system) (current-system))) + (target (if target + (return target) + (current-target-system))) (ok? (if allow-collisions? (return #t) (check-for-collisions manifest system diff --git a/guix/store.scm b/guix/store.scm index cf25d347fc..f99fa581a8 100644 --- a/guix/store.scm +++ b/guix/store.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovi= c Court=C3=A8s ;;; Copyright =C2=A9 2018 Jan Nieuwenhuizen +;;; Copyright =C2=A9 2019 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -159,6 +160,7 @@ %guile-for-build current-system set-current-system + current-target-system text-file interned-file interned-file-tree @@ -1816,6 +1818,11 @@ the store." (lambda (state) (values (%current-system system) state))) =20 +(define-inlinable (current-target-system) + ;; Consult the %CURRENT-TARGET-SYSTEM fluid at bind time. + (lambda (state) + (values (%current-target-system) state))) + (define %guile-for-build ;; The derivation of the Guile to be used within the build environment, ;; when using 'gexp->derivation' and co. --=20 2.24.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 04:42:59 2019 Received: (at 38612) by debbugs.gnu.org; 25 Dec 2019 09:42:59 +0000 Received: from localhost ([127.0.0.1]:53296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik3By-0000Lq-WA for submit@debbugs.gnu.org; Wed, 25 Dec 2019 04:42:59 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ik3Bx-0000Ld-F7 for 38612@debbugs.gnu.org; Wed, 25 Dec 2019 04:42:58 -0500 Received: by mail-wr1-f52.google.com with SMTP id z3so21518786wru.3 for <38612@debbugs.gnu.org>; Wed, 25 Dec 2019 01:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=TwdAzxsNwH7+LENQg3nruwAWsqLTxKSBhLOY40Yobqk=; b=hNGc7M2fQTqvAupwSGdgqBImd39AwcRBGeaCb/y6hxsdI5F/tn36FFhADHiHJl+Sxj 0bZYR2gTzzSb6SKXPgXkHpP4UKh89n/of5LEBiInN28QFcqyV60ETVWSmCxQ9hS5/31w RthX8eBva+1VuUHxvwEV+B4Xn1YCJVbZzcq9VHcWcbRdZbQQ6TJ4cITW9l5+I4UDNcjm p8PZlGI1dt/4zwDhfSvY94z6oCk/rA3fqSxpWymJKUuTMLNLvSCrFuHhjWNBuh85VCJA 8maWt3ryIeLEOTnzUpswBKojTRAhPcACYuNEOvHZd2TXji3numl18aPiyIYg0Aq19iBy Yynw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=TwdAzxsNwH7+LENQg3nruwAWsqLTxKSBhLOY40Yobqk=; b=o31nBUE/LpPzXclQ+FxwNdf5Yobim3ot4KKMM7cvQg5N6uCTZat3PK5m3T+5Cleopm lQ2CJ+BD/lytHgq0kyY1YYHjeh/DJG5SAXZGz0uGaAqfa2PTtSrcXiR8slD3NBLaYdgK YnwWj8wNqvXqewSmBPwgYBkmtA5OoSAUjdbKoLHp+l7atgDYn9dZox3XwLJDtIsX0nOE 0rt4uXI40IUQRTtCca2bbvzlxmNhCbHGuEVAxtnR9yoLxDDw+Cw0ektRwU5XrOuSRUK5 1c+BbzZsrBI04WMDRnzx4eg4jigEwHZJ6DUR2Wf6Kywx//qe/ZSAyUv3Cp8l+uFq2qbx T1gw== X-Gm-Message-State: APjAAAUa7+fnZkFRIIoHVwFSKh9iN8GK/KyyLnjRp578fSew9sNhhxsk wQsTmlDc+aDGNf3gjx2BIeBrvrZj X-Google-Smtp-Source: APXvYqxX9xTRDgE0/tMk0H80OY7NXUE9xb6HZKiC+iM4YBYb+5vxghZpxSOL8b2Wp29DyKzfpHZYUw== X-Received: by 2002:adf:cd0a:: with SMTP id w10mr38680022wrm.107.1577266971164; Wed, 25 Dec 2019 01:42:51 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:a14b:cea0:a27:c884]) by smtp.gmail.com with ESMTPSA id n1sm26571131wrw.52.2019.12.25.01.42.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Dec 2019 01:42:49 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87r20t7r0j.fsf@gmail.com> Date: Wed, 25 Dec 2019 10:42:48 +0100 Message-ID: <87imm468rr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello, Turns out two more patches in the same vein are needed in (gnu services) and (gnu system). They are attached here. Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-system-operating-system-boot-parameters-file-Fix-cro.patch >From a05baf4f4328ce2ca6da6860f6e596cd7559a08a Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 24 Dec 2019 18:24:37 +0100 Subject: [PATCH 1/2] system: operating-system-boot-parameters-file: Fix cross-compilation. * gnu/system.scm (operating-system-boot-parameters-file): Add system and target arguments and pass them to gexp->file call, (operating-system-directory-base-entries): pass current system and target to operating-system-boot-parameters-file procedure. --- gnu/system.scm | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gnu/system.scm b/gnu/system.scm index abdbb081e6..e7af7e7b47 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -470,7 +470,10 @@ value of the SYSTEM-SERVICE-TYPE service." (let ((locale (operating-system-locale-directory os))) (mlet %store-monad ((kernel -> (operating-system-kernel os)) (initrd -> (operating-system-initrd-file os)) - (params (operating-system-boot-parameters-file os))) + (params (operating-system-boot-parameters-file + os + #:system (%current-system) + #:target (%current-target-system)))) (return `(("kernel" ,kernel) ("parameters" ,params) ("initrd" ,initrd) @@ -1048,8 +1051,12 @@ such as '--root' and '--load' to ." (_ device))) -(define* (operating-system-boot-parameters-file os - #:key system-kernel-arguments?) +(define* (operating-system-boot-parameters-file + os + #:key + system-kernel-arguments? + system + target) "Return a file that describes the boot parameters of OS. The primary use of this file is the reconstruction of GRUB menu entries for old configurations. @@ -1085,7 +1092,9 @@ being stored into the \"parameters\" file)." (device #$(device->sexp (boot-parameters-store-device params))) (mount-point #$(boot-parameters-store-mount-point params)))) - #:set-load-path? #f))) + #:set-load-path? #f + #:system system + #:target target))) (define-gexp-compiler (operating-system-compiler (os ) system target) -- 2.24.1 --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0002-services-Fix-cross-compilation.patch Content-Transfer-Encoding: quoted-printable >From 0ce67afc4f33074e20824751c22ba01cf6a3e184 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Wed, 25 Dec 2019 09:49:53 +0100 Subject: [PATCH 2/2] services: Fix cross-compilation. * gnu/services.scm (system-derivation): Pass current system and target at b= ind time to lower-object, (compute-boot-script): also pass current system and target at bind time to gexp->file. --- gnu/services.scm | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/gnu/services.scm b/gnu/services.scm index e7a3a95e43..e6f8ae0fb0 100644 --- a/gnu/services.scm +++ b/gnu/services.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2015, 2016, 2017, 2018, 2019 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2016 Chris Marusich +;;; Copyright =C2=A9 2019 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -321,11 +322,15 @@ This is a shorthand for (map (lambda (svc) ...) %base= -services)." (define (system-derivation mentries mextensions) "Return as a monadic value the derivation of the 'system' directory containing the given entries." - (mlet %store-monad ((entries mentries) + (mlet %store-monad ((system (current-system)) + (target (current-target-system)) + (entries mentries) (extensions (sequence %store-monad mextensions))) (lower-object (file-union "system" - (append entries (concatenate extensions)))))) + (append entries (concatenate extensions))) + system + #:target target))) =20 (define system-service-type ;; This is the ultimate service type, the root of the service DAG. The @@ -346,9 +351,13 @@ system profile, boot script, and so on."))) ;; order. That is, user extensions would come first, and extensions add= ed ;; by 'essential-services' (e.g., running shepherd) are guaranteed to co= me ;; last. - (gexp->file "boot" - ;; Clean up and activate the system, then spawn shepherd. - #~(begin #$@(reverse gexps)))) + (mlet %store-monad ((system (current-system)) + (target (current-target-system))) + (gexp->file "boot" + ;; Clean up and activate the system, then spawn shepherd. + #~(begin #$@(reverse gexps)) + #:system system + #:target target))) =20 (define (boot-script-entry mboot) "Return, as a monadic value, an entry for the boot script in the system --=20 2.24.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 12:59:03 2019 Received: (at 38612) by debbugs.gnu.org; 26 Dec 2019 17:59:04 +0000 Received: from localhost ([127.0.0.1]:56208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXPb-0007Yi-Of for submit@debbugs.gnu.org; Thu, 26 Dec 2019 12:59:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXPZ-0007Y5-H6 for 38612@debbugs.gnu.org; Thu, 26 Dec 2019 12:59:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ikXPU-0003MF-AV; Thu, 26 Dec 2019 12:58:56 -0500 Received: from [2a01:e35:2ffd:930:f25f:2121:7012:6c8e] (port=57238 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ikXPT-00069l-0y; Thu, 26 Dec 2019 12:58:55 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 26 Dec 2019 18:58:53 +0100 In-Reply-To: <87r20t7r0j.fsf@gmail.com> (Mathieu Othacehe's message of "Tue, 24 Dec 2019 15:11:08 +0100") Message-ID: <87k16jhste.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Mathieu Othacehe skribis: > From c8b0e65d9b264bd484c7c6571c2ce3d68173b057 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Tue, 24 Dec 2019 15:04:57 +0100 > Subject: [PATCH] profiles: Fix profile-derivation cross-compilation. > > * guix/store.scm (current-target-system): New exported monadic procedure. > * guix/profiles.scm (profile-derivation): Set target at bind time using t= he > above procedure. LGTM! Does it fix something for you? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 13:04:39 2019 Received: (at 38612) by debbugs.gnu.org; 26 Dec 2019 18:04:39 +0000 Received: from localhost ([127.0.0.1]:56220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXV0-0007nJ-SN for submit@debbugs.gnu.org; Thu, 26 Dec 2019 13:04:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXUz-0007n0-VI for 38612@debbugs.gnu.org; Thu, 26 Dec 2019 13:04:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ikXUu-00065Q-JX; Thu, 26 Dec 2019 13:04:32 -0500 Received: from [2a01:e35:2ffd:930:f25f:2121:7012:6c8e] (port=57256 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ikXUt-0003GV-UQ; Thu, 26 Dec 2019 13:04:32 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 6 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 26 Dec 2019 19:04:30 +0100 In-Reply-To: <87imm468rr.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 25 Dec 2019 10:42:48 +0100") Message-ID: <87d0cbhsk1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Mathieu Othacehe skribis: > From a05baf4f4328ce2ca6da6860f6e596cd7559a08a Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Tue, 24 Dec 2019 18:24:37 +0100 > Subject: [PATCH 1/2] system: operating-system-boot-parameters-file: Fix > cross-compilation. > > * gnu/system.scm (operating-system-boot-parameters-file): Add system and > target arguments and pass them to gexp->file call, > (operating-system-directory-base-entries): pass current system and target= to > operating-system-boot-parameters-file procedure. > --- > gnu/system.scm | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/gnu/system.scm b/gnu/system.scm > index abdbb081e6..e7af7e7b47 100644 > --- a/gnu/system.scm > +++ b/gnu/system.scm > @@ -470,7 +470,10 @@ value of the SYSTEM-SERVICE-TYPE service." > (let ((locale (operating-system-locale-directory os))) > (mlet %store-monad ((kernel -> (operating-system-kernel os)) > (initrd -> (operating-system-initrd-file os)) > - (params (operating-system-boot-parameters-fil= e os))) > + (params (operating-system-boot-parameters-file > + os > + #:system (%current-system) > + #:target (%current-target-system)))) In general, in monadic code, we should refer to (current-system) and (current-target-system), not to the SRFI-39 parameters. > -(define* (operating-system-boot-parameters-file os > - #:key system-kernel-argu= ments?) > +(define* (operating-system-boot-parameters-file > + os > + #:key > + system-kernel-arguments? > + system > + target) > "Return a file that describes the boot parameters of OS. The primary= use of > this file is the reconstruction of GRUB menu entries for old configurati= ons. >=20=20 > @@ -1085,7 +1092,9 @@ being stored into the \"parameters\" file)." > (device > #$(device->sexp (boot-parameters-store-device para= ms))) > (mount-point #$(boot-parameters-store-mount-point p= arams)))) > - #:set-load-path? #f))) > + #:set-load-path? #f > + #:system system > + #:target target))) By default, =E2=80=98gexp->file=E2=80=99 now uses the current system and ta= rget, so this change shouldn=E2=80=99t be necessary if you just want to use those. Am I missing something? The general guideline is that it would be good if only primitives (monadic procedures in (guix gexp) as well as gexp compilers) would have an explicit #:system and #:target parameter. > From 0ce67afc4f33074e20824751c22ba01cf6a3e184 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Wed, 25 Dec 2019 09:49:53 +0100 > Subject: [PATCH 2/2] services: Fix cross-compilation. > > * gnu/services.scm (system-derivation): Pass current system and target at= bind > time to lower-object, > (compute-boot-script): also pass current system and target at bind time to > gexp->file. [...] > (define (system-derivation mentries mextensions) > "Return as a monadic value the derivation of the 'system' directory > containing the given entries." > - (mlet %store-monad ((entries mentries) > + (mlet %store-monad ((system (current-system)) > + (target (current-target-system)) > + (entries mentries) > (extensions (sequence %store-monad mextensions))) Please alight the RHS of =E2=80=98mlet=E2=80=99 bindings. :-) > (lower-object > (file-union "system" > - (append entries (concatenate extensions)))))) > + (append entries (concatenate extensions))) > + system > + #:target target))) I guess this is needed here because =E2=80=98lower-object=E2=80=99 has #:ta= rget default to #f. > + (mlet %store-monad ((system (current-system)) > + (target (current-target-system))) > + (gexp->file "boot" > + ;; Clean up and activate the system, then spawn shepherd. > + #~(begin #$@(reverse gexps)) > + #:system system > + #:target target))) This one is unnecessary now that =E2=80=98gexp->file=E2=80=99 honors the cu= rrent system and target, right? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 13:19:17 2019 Received: (at 38612) by debbugs.gnu.org; 26 Dec 2019 18:19:17 +0000 Received: from localhost ([127.0.0.1]:56236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXjA-0008En-Q4 for submit@debbugs.gnu.org; Thu, 26 Dec 2019 13:19:16 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:37143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikXj8-0008EY-KW for 38612@debbugs.gnu.org; Thu, 26 Dec 2019 13:19:14 -0500 Received: by mail-wr1-f51.google.com with SMTP id w15so11617672wru.4 for <38612@debbugs.gnu.org>; Thu, 26 Dec 2019 10:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=0W1EqEufFBQJLsuX6NMueDKKoYHlqm1NLnfylpFtJ68=; b=tFbVdTLkk1lunsaLVac3AyRRhfNSAKbiCndc3K/FRYqm6xCzbCG22MPNT9stFvwpHD ZohHf1VUFJnfbdgzjAUTA/rTgV/H0Q6g/TJ7bqlmKrEM3V62YJ1dUU4IMP236hQT4L2i t9HnYDdQezrnU/P825Gj/ZwhFdZPlPElOWJjmYyfzb6HUhlN/7BD1YzlY0z0gCO2eqbR ikTkoekxxJkUtwyR28TbjATnUvWzVBuEGI0MEGFHO9+osmwpfQwSK+dRGcAkdd+qS8Tc 347M0fzXDMZreJ+rPLo2A+lWUEwmj5VMB5wR1FcEe557+BMhRtnfW6DdV8T6J+XhfB+n F2MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=0W1EqEufFBQJLsuX6NMueDKKoYHlqm1NLnfylpFtJ68=; b=CzWNSF+a0KThWrGqOqpU+HuYX8kZ2UZqhOkCRtfKYJKSd4CzD1HJR8DqyoJVrP/uk4 khz0E7q9TqlDp9oAUuL8C/+QrDEZNEUfOkrGC8GMHSCR6eugJ8Ef84r2EwyHnzesWdZQ jHuXrlyckKczLujEuN7oeI8dZtY+cykjRDxWpxrdRnYgGizItz2z+kWQhis6J9kRUE3t bOfFKVMtOJLOP7AVu1BDCMTXogHvlo9MDfHUdTrUM86t9I4ZfcQi1n0kc25lCwEhmLuD 2FWmD/vanaQgbNID8BZqj1ZfHcjoi8Pu4nD/KIvJwTAK2FXkQbN1uOeF2OGaBLiggoDb /Jew== X-Gm-Message-State: APjAAAWctm/aq05K27frf4VBi90+tv5BBAZnMHXQQZtJ/TEQn6BLdTz+ hc3V4s2VS16ZndFwQqRV1+y4uGUX X-Google-Smtp-Source: APXvYqwd9kBXVLb6DjSFbmA/WVZrEfsRk231YQhWMM6yhh4AJI7yexrZXTY6AjxS4UAZEeU7VLqqDg== X-Received: by 2002:adf:c74f:: with SMTP id b15mr46105143wrh.272.1577384348633; Thu, 26 Dec 2019 10:19:08 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:a14b:cea0:a27:c884]) by smtp.gmail.com with ESMTPSA id h8sm33406799wrx.63.2019.12.26.10.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2019 10:19:08 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87k16jhste.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87k16jhste.fsf@gnu.org> Date: Thu, 26 Dec 2019 19:19:06 +0100 Message-ID: <87o8vvhrvp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey Ludo, > LGTM! > > Does it fix something for you? Thanks for your review :) Yes, without this patch, all operating-system-packages are built for host system instead of target, when cross-compiling a Guix System. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 13:54:55 2019 Received: (at 38612) by debbugs.gnu.org; 26 Dec 2019 18:54:55 +0000 Received: from localhost ([127.0.0.1]:56248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikYHf-0000ed-0i for submit@debbugs.gnu.org; Thu, 26 Dec 2019 13:54:55 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:32960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikYHd-0000eQ-HW for 38612@debbugs.gnu.org; Thu, 26 Dec 2019 13:54:54 -0500 Received: by mail-wm1-f53.google.com with SMTP id d139so5543178wmd.0 for <38612@debbugs.gnu.org>; Thu, 26 Dec 2019 10:54:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=nTIMpZdSvulpIXgdGkPVjlcEVlhFWm6lX9EjxduaYxM=; b=rdQe5Q2Q9z+trQ+yXCTVJ4mCDnvg4EszwxZCaYT6AjO1oawQFZGW4WDYZHn/io5o4q H5MMA+hrXi0sJmIYrIKGbkeaSYDF3fEqTJytVrzQFGwvXhT7JUAuSMfmHZDB1Yj0bYPW Kv9Pc8nGTB3XjuaCmIX1ZjvCWStUV9RYuuDpK/rt9206xW4ImF51Fz2+Il4CQWuhiqYP Y8CfzGkpBWCycNZ2Xn+M9CGvjXSrTG64jJvaY/jrsstKfFgaQWHcnh5FZM6teK87ah+z NlP19ekJbQSWrsgEeVcOZAmRrCQB5ZYmn82OXsrrPCq4WA8+aLJZ14fbfEoA9FfGs/ke VsFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=nTIMpZdSvulpIXgdGkPVjlcEVlhFWm6lX9EjxduaYxM=; b=DD8h2vc4tEC3PSvXEeKJA81Z7Oo4QLSQZDgEUdAjgkbO36eOZGIutRTEjudnRTmyPI 0axzPBiFs2L29ZUBiTDhj6Jl4/bDPVD+ki0Tbq70ds2ZI0br7knp+WI3G9HVpGBh1aKE k/5iPHia9+7ECEYccklM6vPuoVJAo4ZDfhA+obTd5g66zvp0cYco0mg4XU5Gq7Y8a/56 0pqwr6Nk6lYVSS5M8UfEDgqyGcwQatnXzpiggZ6VN3K/f93+8hAR6TkxOiOxpsaaObOh 5UsJ1sjcAbp6HS/zl+ZBRJ8qadRe4bLgTqnmz0nB/woBkHz53HCUDrupTB91Bv4QGahS R8vg== X-Gm-Message-State: APjAAAVuo9QLij8PFoCzj9AiwvdeI4K2QbEeDFIKC65pfd9mAhvdMw5k wRbxLTByktgapYLgbX0XkcgkE1qz X-Google-Smtp-Source: APXvYqy3YFv/IXNQivSDytkC9VWwaQKl6mMmN+8ccqcHEImarTHGLB1M1EmXi9nCWDCVX7OOKLw6Dg== X-Received: by 2002:a05:600c:211:: with SMTP id 17mr15206353wmi.60.1577386487306; Thu, 26 Dec 2019 10:54:47 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:a14b:cea0:a27:c884]) by smtp.gmail.com with ESMTPSA id y6sm31264308wrl.17.2019.12.26.10.54.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2019 10:54:46 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 27.0.50 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87d0cbhsk1.fsf@gnu.org> Date: Thu, 26 Dec 2019 19:54:45 +0100 Message-ID: <87mubej4sq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey, > In general, in monadic code, we should refer to (current-system) and > (current-target-system), not to the SRFI-39 parameters. Ok! > By default, =E2=80=98gexp->file=E2=80=99 now uses the current system and = target, so this > change shouldn=E2=80=99t be necessary if you just want to use those. Am I > missing something? Well turns out that gexp->file takes #f as default target (as gexp->script and lower-object). Using %current-target-system as default target argument (as gexp->sexp) makes those two patches useless. Would you have any objection to use %current-target-system as default target argument in gexp->file and lower-object? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 13:06:22 2019 Received: (at 38612) by debbugs.gnu.org; 27 Dec 2019 18:06:22 +0000 Received: from localhost ([127.0.0.1]:57770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iku0D-00005i-PD for submit@debbugs.gnu.org; Fri, 27 Dec 2019 13:06:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iku0B-00005V-Gs for 38612@debbugs.gnu.org; Fri, 27 Dec 2019 13:06:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iktzs-0005Od-HK; Fri, 27 Dec 2019 13:06:07 -0500 Received: from [2a01:e35:2ffd:930:f25f:2121:7012:6c8e] (port=59012 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iktzr-0006Yl-7e; Fri, 27 Dec 2019 13:05:59 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> <87mubej4sq.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 27 Dec 2019 19:05:55 +0100 In-Reply-To: <87mubej4sq.fsf@gmail.com> (Mathieu Othacehe's message of "Thu, 26 Dec 2019 19:54:45 +0100") Message-ID: <87a77dhce4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Mathieu Othacehe skribis: >> In general, in monadic code, we should refer to (current-system) and >> (current-target-system), not to the SRFI-39 parameters. > > Ok! > >> By default, =E2=80=98gexp->file=E2=80=99 now uses the current system and= target, so this >> change shouldn=E2=80=99t be necessary if you just want to use those. Am= I >> missing something? > > Well turns out that gexp->file takes #f as default target (as > gexp->script and lower-object). Oh, right. > Using %current-target-system as default target argument (as gexp->sexp) > makes those two patches useless. > > Would you have any objection to use %current-target-system as default > target argument in gexp->file and lower-object? As written above, it should default to =E2=80=98current-target-system=E2=80= =99 rather than =E2=80=98%current-target-system=E2=80=99. Kind of annoying, but heh= =E2=80=A6 Also, we should probably get rid of the monadic style in (gnu services). That would simplify things, but there are compatibility considerations=E2= =80=A6 Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 04:33:31 2019 Received: (at 38612) by debbugs.gnu.org; 29 Dec 2019 09:33:31 +0000 Received: from localhost ([127.0.0.1]:59242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilUx1-0004IV-1z for submit@debbugs.gnu.org; Sun, 29 Dec 2019 04:33:31 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:35101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilUwz-0004II-42 for 38612@debbugs.gnu.org; Sun, 29 Dec 2019 04:33:29 -0500 Received: by mail-wr1-f43.google.com with SMTP id g17so30189702wro.2 for <38612@debbugs.gnu.org>; Sun, 29 Dec 2019 01:33:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=fliPIeVpwZkYxvO97xtUfMef3sHHxGeQa/lNUu4IZYw=; b=LeZiv549BDuyfZZxzv5OWNt9I3Jo6xBDQ6BMueD+wUFm+bknu56rt8nnaKtPZd1YnT ab81Zlp6uKHv4gHmGgW+e1+C8YUV+COrcPcjl3mJzv0rysCYyzA7M5ODhuEys3BQOhJ3 0RsxlI4AUKcYxe1TFeqY78HetSdBrQZkQoVSdCeN+Daqa/DHraiyk2qEnu1d9I/4qPCP d2qWNifOcKXD5t0rCozpHzKZCyRu31i6ri1KGtTMO7qmC5bhZOQAnBXjF6UKhc3q+DrB g1UZ4CO8QeKX+Jcybg2pwkDVm9iLuJVqo8+plcYraC/KdwJX5hBT3qc60FV4he6w1iRu hh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=fliPIeVpwZkYxvO97xtUfMef3sHHxGeQa/lNUu4IZYw=; b=IUmuVKb9aSwct76ccJTbz61qvnVIjWNRK31CjJO6bvIx5hVMPel+VvI1ckQ6Dr4on5 NPZ8I8kbpmDp5H7w04OJvDE9vbHhhwaFMUJ05Wvhd3WLdo5ThGdJSfxUiia8vyx8z6CE VzeRAhLpZU4/GBLI0UhA1ohTsZ2ze41PmceRYoZZsTMmCau5BY4JfqiNFEx01oMaW82i nbVEi3JxE2xLLg56OMA0jpQauuT/gMCsj3/LW+TfkI0LY9ANz7v0XWDlHruyJdmQBabD XAMtZVmvPzDjbDkX1yPiTglNZBWR46dx3Zfyj3GoXSEOADNj6H4+97OpGxWb7eE6oaiB chFQ== X-Gm-Message-State: APjAAAXf5NU2cUpofDoWlJqLcuS5EuhLkBaweeYbVph8X3jIn2iny3La QufC+9MQMXmuBMxYfMcuzMqefMYt X-Google-Smtp-Source: APXvYqw/eUE5xqnJWpkcr7rQjYCbZj1CJYwIeabnC+9V/MQ4v+prncqZdLojT67rqdj/BzQ3Vy1YPA== X-Received: by 2002:adf:f1d0:: with SMTP id z16mr58277020wro.209.1577612002911; Sun, 29 Dec 2019 01:33:22 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:fc44:c711:5fe:9e86]) by smtp.gmail.com with ESMTPSA id d8sm41747628wre.13.2019.12.29.01.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Dec 2019 01:33:21 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> <87mubej4sq.fsf@gmail.com> <87a77dhce4.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87a77dhce4.fsf@gnu.org> Date: Sun, 29 Dec 2019 10:33:20 +0100 Message-ID: <878smvtr1b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hey Ludo, Then, here's a patch that set the default target to 'current in lower-object, gexp->file and gexp->script. Then, (current-target-system) is used at bind time if target is 'current (same way as gexp->derivation and lower-gexp). An additionnal patch is needed because lower-object is called without a default target in lower-gexp, when lowering extensions. WDYT? Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gexp-Default-to-current-target.patch >From f5d773dc0a627ba6059f1025189d33a9e0d083b5 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 28 Dec 2019 21:29:06 +0100 Subject: [PATCH 1/2] gexp: Default to current target. * guix/gexp.scm (lower-object): Set target argument to 'current by default and look for the current target system at bind time if needed, (gexp->file): ditto, (gexp->script): ditto. --- guix/gexp.scm | 87 ++++++++++++++++++++++++++++++--------------------- 1 file changed, 51 insertions(+), 36 deletions(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index 12331052a6..11d4e86037 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -215,7 +215,7 @@ procedure to expand it; otherwise return #f." (define* (lower-object obj #:optional (system (%current-system)) - #:key target) + #:key (target 'current)) "Return as a value in %STORE-MONAD the derivation or store item corresponding to OBJ for SYSTEM, cross-compiling for TARGET if TARGET is true. OBJ must be an object that has an associated gexp compiler, such as a @@ -225,7 +225,10 @@ OBJ must be an object that has an associated gexp compiler, such as a (raise (condition (&gexp-input-error (input obj))))) (lower ;; Cache in STORE the result of lowering OBJ. - (mlet %store-monad ((graft? (grafting?))) + (mlet %store-monad ((target (if (eq? target 'current) + (current-target-system) + (return target))) + (graft? (grafting?))) (mcached (let ((lower (lookup-compiler obj))) (lower obj system target)) obj @@ -1571,16 +1574,19 @@ are searched for in PATH. Return #f when MODULES and EXTENSIONS are empty." #:key (guile (default-guile)) (module-path %load-path) (system (%current-system)) - target) + (target 'current)) "Return an executable script NAME that runs EXP using GUILE, with EXP's imported modules in its search path. Look up EXP's modules in MODULE-PATH." - (mlet %store-monad ((set-load-path - (load-path-expression (gexp-modules exp) - module-path - #:extensions - (gexp-extensions exp) - #:system system - #:target target))) + (mlet* %store-monad ((target (if (eq? target 'current) + (current-target-system) + (return target))) + (set-load-path + (load-path-expression (gexp-modules exp) + module-path + #:extensions + (gexp-extensions exp) + #:system system + #:target target))) (gexp->derivation name (gexp (call-with-output-file (ungexp output) @@ -1609,7 +1615,7 @@ imported modules in its search path. Look up EXP's modules in MODULE-PATH." (module-path %load-path) (splice? #f) (system (%current-system)) - target) + (target 'current)) "Return a derivation that builds a file NAME containing EXP. When SPLICE? is true, EXP is considered to be a list of expressions that will be spliced in the resulting file. @@ -1620,36 +1626,45 @@ Lookup EXP's modules in MODULE-PATH." (define modules (gexp-modules exp)) (define extensions (gexp-extensions exp)) - (if (or (not set-load-path?) - (and (null? modules) (null? extensions))) - (gexp->derivation name - (gexp - (call-with-output-file (ungexp output) - (lambda (port) - (for-each (lambda (exp) - (write exp port)) - '(ungexp (if splice? - exp - (gexp ((ungexp exp))))))))) - #:local-build? #t - #:substitutable? #f - #:system system - #:target target) - (mlet %store-monad ((set-load-path - (load-path-expression modules module-path - #:extensions extensions - #:system system - #:target target))) + (mlet* %store-monad + ((target (if (eq? target 'current) + (current-target-system) + (return target))) + (no-load-path? -> (or (not set-load-path?) + (and (null? modules) + (null? extensions)))) + (set-load-path + (or (return no-load-path?) + (load-path-expression modules module-path + #:extensions extensions + #:system system + #:target target)))) + (if no-load-path? + (gexp->derivation name + (gexp + (call-with-output-file (ungexp output) + (lambda (port) + (for-each + (lambda (exp) + (write exp port)) + '(ungexp (if splice? + exp + (gexp ((ungexp exp))))))))) + #:local-build? #t + #:substitutable? #f + #:system system + #:target target) (gexp->derivation name (gexp (call-with-output-file (ungexp output) (lambda (port) (write '(ungexp set-load-path) port) - (for-each (lambda (exp) - (write exp port)) - '(ungexp (if splice? - exp - (gexp ((ungexp exp))))))))) + (for-each + (lambda (exp) + (write exp port)) + '(ungexp (if splice? + exp + (gexp ((ungexp exp))))))))) #:module-path module-path #:local-build? #t #:substitutable? #f -- 2.24.1 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-gexp-lower-gexp-Do-not-pass-default-target-to-lower-.patch >From 21af4b796fb638c0c70a4b73d9add53ee2e9747e Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 28 Dec 2019 21:53:05 +0100 Subject: [PATCH 2/2] gexp: lower-gexp: Do not pass default target to lower-object. Default target argument of lower-object is no longer #f but the current target system. However, even if %current-target-system is set, we do not want to cross-compile gexp extensions. * guix/gexp.scm (lower-gexp): Make sure that extensions are not cross-built by passing #f as target argument of lower-object. --- guix/gexp.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/guix/gexp.scm b/guix/gexp.scm index 11d4e86037..027701a201 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -756,7 +756,8 @@ derivations--e.g., code evaluated for its side effects." (extensions -> (gexp-extensions exp)) (exts (mapm %store-monad (lambda (obj) - (lower-object obj system)) + (lower-object obj system + #:target #f)) extensions)) (modules+compiled (imported+compiled-modules %modules system -- 2.24.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 17:37:02 2019 Received: (at 38612) by debbugs.gnu.org; 29 Dec 2019 22:37:02 +0000 Received: from localhost ([127.0.0.1]:60323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilhBG-0006GA-BM for submit@debbugs.gnu.org; Sun, 29 Dec 2019 17:37:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilhBD-0006Fk-RS for 38612@debbugs.gnu.org; Sun, 29 Dec 2019 17:37:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilhB8-0002LR-MP; Sun, 29 Dec 2019 17:36:54 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43742 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilhB8-00014l-5A; Sun, 29 Dec 2019 17:36:54 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> <87mubej4sq.fsf@gmail.com> <87a77dhce4.fsf@gnu.org> <878smvtr1b.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?utf-8?Q?Niv=C3=B4se?= an 228 de la =?utf-8?Q?R?= =?utf-8?Q?=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 29 Dec 2019 23:36:52 +0100 In-Reply-To: <878smvtr1b.fsf@gmail.com> (Mathieu Othacehe's message of "Sun, 29 Dec 2019 10:33:20 +0100") Message-ID: <87k16e92t7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: > Then, here's a patch that set the default target to 'current in > lower-object, gexp->file and gexp->script. Then, (current-target-system) > is used at bind time if target is 'current (same way as gexp->derivation > and lower-gexp). > > An additionnal patch is needed because lower-object is called without a > default target in lower-gexp, when lowering extensions. > > WDYT? > > Mathieu > > From f5d773dc0a627ba6059f1025189d33a9e0d083b5 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 28 Dec 2019 21:29:06 +0100 > Subject: [PATCH 1/2] gexp: Default to current target. > > * guix/gexp.scm (lower-object): Set target argument to 'current by defaul= t and > look for the current target system at bind time if needed, > (gexp->file): ditto, > (gexp->script): ditto. Uh, it=E2=80=99s =E2=80=9Cthe right thing=E2=80=9D but it=E2=80=99s getting= ugly. :-/ If we take a step back, what=E2=80=99s the minimal change that would solve = the problem you=E2=80=99re looking at? Apologies for the back-and-forth, it=E2=80=99s a tricky area! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 03:40:11 2019 Received: (at 38612) by debbugs.gnu.org; 30 Dec 2019 08:40:11 +0000 Received: from localhost ([127.0.0.1]:60477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilqax-0005tZ-Bq for submit@debbugs.gnu.org; Mon, 30 Dec 2019 03:40:11 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:54473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilqav-0005tF-07 for 38612@debbugs.gnu.org; Mon, 30 Dec 2019 03:40:10 -0500 Received: by mail-wm1-f44.google.com with SMTP id b19so13336924wmj.4 for <38612@debbugs.gnu.org>; Mon, 30 Dec 2019 00:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=Yx7tJhc3iHwD67s9pOo4dBUHiX4ODCqOiUCv6dv8nMQ=; b=YYjwO3ofX2Juw1TUkX8UJ7E916P1+IGbMvHonBDiMjUKrnk099ivKqVE4r+Qg7KL9g GtAzqQsSqKuSh4goaD6k0kk3Se5q9xLpLN1Ct6IEGYx2rtpzRgoKlMFhm8J80Fi8WAM6 Lkgfrk2mBdJcvAhsLA656wU2f5je42B0BWWGRO9OYNtGP2Ko2Rm8cJ1Sfb9jY67epK2z VemYnee8MIpX07CpERtJeH/+bpVv3gvq0Aynljb4AFHl+uN0VEyiRhOkyf5CR8uFYD88 Etv2KwVr+yj96vNxu7wATpZ0BjmCjtiui8wzbyPlzzIqTmHrMb0/ItWIHzCPEyAl2PQF 4Z+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=Yx7tJhc3iHwD67s9pOo4dBUHiX4ODCqOiUCv6dv8nMQ=; b=TSGuX8mGOlzw8vKmsQaL3r7c15LcAuAn/pAJAWGWXt6nMr6fYA+BcZOv7bB3rz9qHA gSBACnlBpkTS3oLPnrlD/J/Azn39YwtBxo1z9yJUnMtvRNEDj4O5pjYOq5c/laWkofyN qLJOsB3ljDL1pT5XFhmNxvIWvFG1Yam8U/BQSk7XaowCU9X/ysH8dmXKW5CPsvyZnyy/ kEPi8ln+sQor+2d78DXmIXDf9+FRnNohLJjRVK2uHmpb49cPYTXQ5yGZQH+wRSYyZHim imQy2T1xlIfKbkDtPXa/B9G21SRPnlj3Iv0EChf/74TG0zE1N6gmpOP40mENoFzm5Xhl 9tVQ== X-Gm-Message-State: APjAAAXkx+Z/9TDYBb3Vzo1ZZUkGFfYLedruseu+bpKtEY7PlypCvCEM 0v879rcmNuDZJmoqgktPmeRU503i X-Google-Smtp-Source: APXvYqylM4xVbFr0JkEIryeBcTvudR4zXxzPzmwSv0f9rD2zzcOjsw+4YjDx4mSzzKw8kEKNtBULlg== X-Received: by 2002:a1c:62c1:: with SMTP id w184mr34654736wmb.150.1577695202655; Mon, 30 Dec 2019 00:40:02 -0800 (PST) Received: from cervin ([2a01:cb18:832e:5f00:fc44:c711:5fe:9e86]) by smtp.gmail.com with ESMTPSA id s15sm45820037wrp.4.2019.12.30.00.40.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2019 00:40:02 -0800 (PST) References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> <87mubej4sq.fsf@gmail.com> <87a77dhce4.fsf@gnu.org> <878smvtr1b.fsf@gmail.com> <87k16e92t7.fsf@gnu.org> User-agent: mu4e 1.2.0; emacs 26.3 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#38612] Pass system and target arguments to gexp->file. In-reply-to: <87k16e92t7.fsf@gnu.org> Date: Mon, 30 Dec 2019 09:40:00 +0100 Message-ID: <87eewm6wbj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38612 Cc: 38612@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey, > Uh, it=E2=80=99s =E2=80=9Cthe right thing=E2=80=9D but it=E2=80=99s getti= ng ugly. :-/ > > If we take a step back, what=E2=80=99s the minimal change that would solv= e the > problem you=E2=80=99re looking at? > > Apologies for the back-and-forth, it=E2=80=99s a tricky area! I'm glad I can have your support on this topic :) Here's a small recap of the situation. As you may know I'm trying to get "guix system build install.scm --target=3Dxxx" to work. My board needs specific initrd kernel modules to boot. As target is not passed to lower-object in system-derivation procedure of (gnu services), raw-initrd will try to locate those (arm specific) modules in the host x86 kernel, where they do not exist, and fail. The same thing happens for operating-system-boot-parameters-file which contains a gexp->file call. Now, while this problem is quite specific, we need to find a generic solution to those target issues. Forcing the user of (guix gexp) to pass a target argument implies the use of monadic style to read %current-target-system safely. On the other hand, defaulting to the current target inside (guix gexp) as proposed in my patch is kinda ugly as you noticed :p Could %current-target-system be set outside of the monadic context so that we can access it from wherever we want? That would also solve the issue I have with canonical-package procedure[1], that read %current-target-system outside of the monadic context, where is is always #f. Thanks for your help, Mathieu [1]: https://lists.gnu.org/archive/html/guix-devel/2019-12/msg00353.html From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 30 11:24:58 2020 Received: (at control) by debbugs.gnu.org; 30 Jul 2020 15:24:58 +0000 Received: from localhost ([127.0.0.1]:36557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1AQU-00060S-6j for submit@debbugs.gnu.org; Thu, 30 Jul 2020 11:24:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k1AQT-00060F-54 for control@debbugs.gnu.org; Thu, 30 Jul 2020 11:24:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39779) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k1AQN-0008Gm-K4 for control@debbugs.gnu.org; Thu, 30 Jul 2020 11:24:51 -0400 Received: from [2a01:cb18:832e:5f00:e0a7:8073:f3be:5cd4] (port=50738 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k1AQM-0001ME-Sv for control@debbugs.gnu.org; Thu, 30 Jul 2020 11:24:51 -0400 From: Mathieu Othacehe To: control@debbugs.gnu.org Subject: closing Date: Thu, 30 Jul 2020 17:24:48 +0200 Message-ID: <877dul81q7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 38612 From unknown Mon Jun 23 06:00:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Aug 2020 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator