Subject: Re: bug#38602: 26.3; gnutls-negotiate fails to handle :verify-error being set to t

From: Lars Ingebrigtsen <[email-masked]>
Date: Fri, 02 Oct 2020 04:51:40 +0200

Alexis <[email-masked]> writes:

> Robert Pluim <[email-masked]> writes:
>

[...]

>> +    ;; Only add :hostname if `verify-error' is not t, since t
>> +    ;; means "include :hostname" Bug#38602.
>> +    (and verify-hostname-error
>> +         (not (eq verify-error t))
>> +         (push :hostname verify-error))

This looks "obviously correct" to me, so I've now applied it to Emacs 28.

> Thank you for your prompt response - sorry to have taken so long to
> get back to you.
>
> Unfortunately, this diff didn't work for me - it results in the error:
>
>    STARTTLS negotation failed: GnuTLS error: #<process jabber>,
>    nil

That's a different error than the original one, at least.

> Would you like me to try with a public host, and let you know the
> results?

Yes, please do.  And if you could give a complete recipe, starting from
emacs -Q on how to reproduce the bug, that'd be nice.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no