From unknown Sat Jun 21 10:42:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38599: 27.0.50; org-agenda lists invalid Diary entries Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38599 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38599@debbugs.gnu.org Cc: Justin Abrahms X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15762752642347 (code B ref -1); Fri, 13 Dec 2019 22:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Dec 2019 22:14:24 +0000 Received: from localhost ([127.0.0.1]:34724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCa-0000bn-Ac for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:41545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCY-0000be-TV for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iftCX-0005U6-Hh for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iftCW-0000SS-6G for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:21 -0500 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:39437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iftCV-0000Ow-RW for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:20 -0500 Received: by mail-qt1-x82a.google.com with SMTP id i12so348837qtp.6 for ; Fri, 13 Dec 2019 14:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=x2a0QBzqO5txjM1V+ffFSIj+Wk9ulbMHIgTpHqmcT9xkvzd9p96zonfD0hJr8HliYq W/1+4R1AiOjxCKNn4HFJ75wClaOgmYze7uBq4T+dDj5iDRZwixO/irtrBZpu0BaiGJAR JKMvpqigBm9FvMWJkdIVdBB2Nr1ZpNj/SstIsM4hIfRNLYvy568J/6wjKJpKYnAsDY9E BQe8uI5obEuRp0g3aufc8IQyTYVV4zd4sa03lFONIM8Xx6CHDDhnUzX1r143FASP+w5T mywZBm/fH7UmH1NaM/NldsvgBDgT20MmxFap3unJ6pP2GVeF8BHY6tc5wGGncW+0FGHf EiqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=jNfnfVjM3BR1bCAQImTyyE1A1Z8LoF/Wv+R04RzbSIpknfMD+1D0CVquhHHVTwUDQJ MADxyi+pLRp/ttQRIBJdR5LzIGUxZTeQmuwgfv3aAG//q/cj3gSLkfuYnduLv7McOf6I qxGuK8swwS/huw8OOpcCyDuAB48mPd0FL9MYQO1h9B2vuI6/o8eTr0nlyB1oaeTtiT4Y OQP2QeyVqN9OWYAwAETi/mr1pVGa9bLftR9X8l9Y/mzDevQsIq8QOuvNc237wQcgaftL Uzq7pY5bHOM7nzc9ovRpsqtcvYqWdC9Lb7LSPSBwrjhqPREl237lyFIMvL0KeXXfx+La D5uQ== X-Gm-Message-State: APjAAAU1+j58r/C+omCmi33ad7WqycrOV6MY3A7XzR/RCux0XBOzrDPb OhxWsSQPj+7QkrOSD3E76s+ONoyr31g= X-Google-Smtp-Source: APXvYqzt9Wx47zZYK6jy1snlEL+KA41YuPeH/3ZMmiTgqqCyKqlqQHcSLXsRoNg5+bpNx1G/xJezyQ== X-Received: by 2002:ac8:2bca:: with SMTP id n10mr14823136qtn.251.1576275258783; Fri, 13 Dec 2019 14:14:18 -0800 (PST) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id z6sm3193593qkz.101.2019.12.13.14.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 14:14:17 -0800 (PST) From: Thomas Fitzsimmons Date: Fri, 13 Dec 2019 17:14:16 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82a X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi, Justin reported to me a bug he found while using Excorporate. In Justin's setup, Excorporate retrieves meeting details from a server then writes them to a Diary file. Org agenda reads from that Diary file. In the failing case, the meeting details happened to contain lines whose middles matched diary-time-regexp, e.g. any URL containing 0-9 and then 'h'. Those non-entry lines were displayed as Diary: entries in the Org agenda, when they shouldn't have been. Justin confirmed the attached patch fixes the problem for him. Can an Org mode maintainer review it? Thanks, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-time-regexp-in-org-get-entries-from-diary.patch >From 938be223a8bfd75df61a703d392d2154b6c479c4 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 13 Dec 2019 15:57:28 -0500 Subject: [PATCH] Fix time regexp in org-get-entries-from-diary * lisp/org/org-agenda.el (org-get-entries-from-diary): Make time regular expression more precise. Reported-by: Justin Abrahms --- lisp/org/org-agenda.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el index 2404ca43dc..05c35b8ac3 100644 --- a/lisp/org/org-agenda.el +++ b/lisp/org/org-agenda.el @@ -5135,6 +5135,7 @@ org-get-entries-from-diary (cons 'org-diary-default-entry diary-list-entries-hook)) (diary-file-name-prefix nil) ; turn this feature off (diary-modify-entry-list-string-function 'org-modify-diary-entry-string) + (diary-time-regexp (concat "^" diary-time-regexp)) entries (org-disable-agenda-to-diary t)) (save-excursion -- 2.24.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 12:57:56 2019 Received: (at control) by debbugs.gnu.org; 21 Dec 2019 17:57:56 +0000 Received: from localhost ([127.0.0.1]:48760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iij0m-0006cc-8Z for submit@debbugs.gnu.org; Sat, 21 Dec 2019 12:57:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iij0j-0006cL-Qs for control@debbugs.gnu.org; Sat, 21 Dec 2019 12:57:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iij0e-0005iX-Hs for control@debbugs.gnu.org; Sat, 21 Dec 2019 12:57:48 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1iij0Y-0002aJ-4Z for control@debbugs.gnu.org; Sat, 21 Dec 2019 12:57:42 -0500 Subject: control message for bug 38599 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 21 Dec 2019 12:57:42 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) reassign 38599 org-mode From unknown Sat Jun 21 10:42:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Thomas Fitzsimmons Subject: bug#38599: closed (Re: bug#38599: 27.0.50; org-agenda lists invalid Diary entries) Message-ID: References: X-Gnu-PR-Message: they-closed 38599 X-Gnu-PR-Package: org-mode Reply-To: 38599@debbugs.gnu.org Date: Sat, 28 Dec 2019 20:23:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1577564581-5838-1" This is a multi-part message in MIME format... ------------=_1577564581-5838-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #38599: 27.0.50; org-agenda lists invalid Diary entries which was filed against the org-mode package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38599@debbugs.gnu.org. --=20 38599: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38599 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1577564581-5838-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 38599-done) by debbugs.gnu.org; 28 Dec 2019 20:22:22 +0000 Received: from localhost ([127.0.0.1]:58962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilIbO-0001V2-Ch for submit@debbugs.gnu.org; Sat, 28 Dec 2019 15:22:22 -0500 Received: from mail-qk1-f178.google.com ([209.85.222.178]:43541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilIbK-0001Um-Bt for 38599-done@debbugs.gnu.org; Sat, 28 Dec 2019 15:22:20 -0500 Received: by mail-qk1-f178.google.com with SMTP id t129so23830851qke.10 for <38599-done@debbugs.gnu.org>; Sat, 28 Dec 2019 12:22:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3zNUDqacRLbqVDpT88ptQJK8dpJ6jy/MLaMBRdOMmEo=; b=mZWKi8nQdON/8fsuiq6W5PQTNCVADlQp7IidS37nke97dyMEqmQlzrJNvDBMxsvpPQ fsusjdLGonIvQz+axSsgECKH/7OWlA1DqkBLljrJfTgMi6hMQ1ITy4nYgWKACnI4ABrj VVBbfoMacdypVRhfLSU5zAUOA2o1yAMTyXZrRjuLRkl6cYGx+lZX4+cJiIoIoz5E5TZP 2zrno9McE4zd+haHCFvO2kcWZhx4o9FjMHpXpq2E8958qanBjqVvj2K6Zz8YKrxUO89R XqIfaU2kzRgo3N4YjwVjCNcG4oEfseiIaYUGFqSPIbwjanRNzh4+WG8q4VmFkwuazDT0 z3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3zNUDqacRLbqVDpT88ptQJK8dpJ6jy/MLaMBRdOMmEo=; b=H5wsg93z7dBzH+Ewfv84EUbnootAmXm6B13bKa7L21e9ZPgJoh/rz8C7Mu7knwhpKc V9pBXiTrlY79PxrCpbBPewMWNyWyTW4spRzShdOHgfmlkKfB6HNPUls67AscLKhShuGP omfCOpas/nDG8ABb7yc5I5qBioXvW9Ka4j7XWmnjv0+XXYxU0RboKniUchfF1uKtnZq7 BoG6kSxAPcWAB03jIxo74Hohe2/bF2D/dvOK1Y6hBU6YJkYftiPZiNCVVG29f3MwySKa vsxaOCGWCncasfXVPGwDNHfjnafBVDIdlzzZ9r1vEeQWVRUF9mjACcnG33rCb3kMjD2r X0UA== X-Gm-Message-State: APjAAAVIQucTiFNi7c37oBOPPx6EG22eKCo0ectyDeI8cY8OjDsE/d1W v+0mZ2SCFbUGmMhrZDaHu2tjcWLpnAQ= X-Google-Smtp-Source: APXvYqy5X1O9yHBt8vfeWmH38yZuEvXTxoDi0Jkr6OzSSgFPzQEHi/yK1GbDFNvi8zFkTcYQcUOpqg== X-Received: by 2002:a37:60d:: with SMTP id 13mr49366615qkg.32.1577564532862; Sat, 28 Dec 2019 12:22:12 -0800 (PST) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id f23sm10874299qke.104.2019.12.28.12.22.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Dec 2019 12:22:12 -0800 (PST) From: Thomas Fitzsimmons To: 38599-done@debbugs.gnu.org Subject: Re: bug#38599: 27.0.50; org-agenda lists invalid Diary entries References: Date: Sat, 28 Dec 2019 15:22:11 -0500 In-Reply-To: (Thomas Fitzsimmons's message of "Fri, 13 Dec 2019 17:14:16 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38599-done Cc: Justin Abrahms X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Thomas Fitzsimmons writes: [...] > Justin confirmed the attached patch fixes the problem for him. Can an > Org mode maintainer review it? I also reported this upstream to the Org maintainers and they accepted the fix. Org 9.3.1, which contains the fix, has been released. You can install it from GNU ELPA. I'm marking this bug as done. Thomas ------------=_1577564581-5838-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Dec 2019 22:14:24 +0000 Received: from localhost ([127.0.0.1]:34724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCa-0000bn-Ac for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:41545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCY-0000be-TV for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iftCX-0005U6-Hh for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iftCW-0000SS-6G for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:21 -0500 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:39437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iftCV-0000Ow-RW for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:20 -0500 Received: by mail-qt1-x82a.google.com with SMTP id i12so348837qtp.6 for ; Fri, 13 Dec 2019 14:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=x2a0QBzqO5txjM1V+ffFSIj+Wk9ulbMHIgTpHqmcT9xkvzd9p96zonfD0hJr8HliYq W/1+4R1AiOjxCKNn4HFJ75wClaOgmYze7uBq4T+dDj5iDRZwixO/irtrBZpu0BaiGJAR JKMvpqigBm9FvMWJkdIVdBB2Nr1ZpNj/SstIsM4hIfRNLYvy568J/6wjKJpKYnAsDY9E BQe8uI5obEuRp0g3aufc8IQyTYVV4zd4sa03lFONIM8Xx6CHDDhnUzX1r143FASP+w5T mywZBm/fH7UmH1NaM/NldsvgBDgT20MmxFap3unJ6pP2GVeF8BHY6tc5wGGncW+0FGHf EiqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=jNfnfVjM3BR1bCAQImTyyE1A1Z8LoF/Wv+R04RzbSIpknfMD+1D0CVquhHHVTwUDQJ MADxyi+pLRp/ttQRIBJdR5LzIGUxZTeQmuwgfv3aAG//q/cj3gSLkfuYnduLv7McOf6I qxGuK8swwS/huw8OOpcCyDuAB48mPd0FL9MYQO1h9B2vuI6/o8eTr0nlyB1oaeTtiT4Y OQP2QeyVqN9OWYAwAETi/mr1pVGa9bLftR9X8l9Y/mzDevQsIq8QOuvNc237wQcgaftL Uzq7pY5bHOM7nzc9ovRpsqtcvYqWdC9Lb7LSPSBwrjhqPREl237lyFIMvL0KeXXfx+La D5uQ== X-Gm-Message-State: APjAAAU1+j58r/C+omCmi33ad7WqycrOV6MY3A7XzR/RCux0XBOzrDPb OhxWsSQPj+7QkrOSD3E76s+ONoyr31g= X-Google-Smtp-Source: APXvYqzt9Wx47zZYK6jy1snlEL+KA41YuPeH/3ZMmiTgqqCyKqlqQHcSLXsRoNg5+bpNx1G/xJezyQ== X-Received: by 2002:ac8:2bca:: with SMTP id n10mr14823136qtn.251.1576275258783; Fri, 13 Dec 2019 14:14:18 -0800 (PST) Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id z6sm3193593qkz.101.2019.12.13.14.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 14:14:17 -0800 (PST) From: Thomas Fitzsimmons To: bug-gnu-emacs@gnu.org Subject: 27.0.50; org-agenda lists invalid Diary entries Date: Fri, 13 Dec 2019 17:14:16 -0500 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82a X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Justin Abrahms X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hi, Justin reported to me a bug he found while using Excorporate. In Justin's setup, Excorporate retrieves meeting details from a server then writes them to a Diary file. Org agenda reads from that Diary file. In the failing case, the meeting details happened to contain lines whose middles matched diary-time-regexp, e.g. any URL containing 0-9 and then 'h'. Those non-entry lines were displayed as Diary: entries in the Org agenda, when they shouldn't have been. Justin confirmed the attached patch fixes the problem for him. Can an Org mode maintainer review it? Thanks, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-time-regexp-in-org-get-entries-from-diary.patch >From 938be223a8bfd75df61a703d392d2154b6c479c4 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 13 Dec 2019 15:57:28 -0500 Subject: [PATCH] Fix time regexp in org-get-entries-from-diary * lisp/org/org-agenda.el (org-get-entries-from-diary): Make time regular expression more precise. Reported-by: Justin Abrahms --- lisp/org/org-agenda.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el index 2404ca43dc..05c35b8ac3 100644 --- a/lisp/org/org-agenda.el +++ b/lisp/org/org-agenda.el @@ -5135,6 +5135,7 @@ org-get-entries-from-diary (cons 'org-diary-default-entry diary-list-entries-hook)) (diary-file-name-prefix nil) ; turn this feature off (diary-modify-entry-list-string-function 'org-modify-diary-entry-string) + (diary-time-regexp (concat "^" diary-time-regexp)) entries (org-disable-agenda-to-diary t)) (save-excursion -- 2.24.0 --=-=-=-- ------------=_1577564581-5838-1-- From unknown Sat Jun 21 10:42:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38599: 27.0.50; org-agenda lists invalid Diary entries Resent-From: "Justin Abrahms" Original-Sender: "Debbugs-submit" Resent-CC: emacs-orgmode@gnu.org Resent-Date: Sat, 28 Dec 2019 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38599 X-GNU-PR-Package: org-mode X-GNU-PR-Keywords: To: "Thomas Fitzsimmons" , 38599-done@debbugs.gnu.org Received: via spool by 38599-done@debbugs.gnu.org id=D38599.157757012614242 (code D ref 38599); Sat, 28 Dec 2019 21:56:02 +0000 Received: (at 38599-done) by debbugs.gnu.org; 28 Dec 2019 21:55:26 +0000 Received: from localhost ([127.0.0.1]:59036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilK3S-0003hd-DY for submit@debbugs.gnu.org; Sat, 28 Dec 2019 16:55:26 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilJ3W-0002DN-Si for 38599-done@debbugs.gnu.org; Sat, 28 Dec 2019 15:51:27 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 665B921B84; Sat, 28 Dec 2019 15:51:21 -0500 (EST) Received: from imap5 ([10.202.2.55]) by compute7.internal (MEProxy); Sat, 28 Dec 2019 15:51:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=abrah.ms; h= mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm3; bh=hOY6rijPSxkjMF80RcGa8dDSdEacCja 8hkhZ5ms3P+c=; b=B2dJzfMJyTpNstCnEBzL4WYYdYQMIH9/iRZLxrI3/AYOxB2 unk50bbtF1ZLZ/RIpQHjkX9hQ156yiAMdNdVxW9++c3MS+bPc7WTWUpmdh6bPynE I3LVxKtbDCRYBt5FtNnXZpzVTroSAzUgTNP9uTT9fgTYroISnUnGr/MVrO4xNjA9 ygttFeHLHCkWeTjg+k49XFhDnn3lh0UzlNn0s7DBKL2M7BhVxghrWzN+IEwV7WDx ijDYvBHz/h1LqRcyMfs7eE7iSI/3I+IcJ9ym0HLw47YZMMKLaBOgrVMvL4foimiT GaH3W0geUKqVn7CfbYH9HQxTyJ47vVOfWozIKSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hOY6ri jPSxkjMF80RcGa8dDSdEacCja8hkhZ5ms3P+c=; b=TNH3rANcIEpqCh/uDYcQpy UN1+nedGPKrQJu+o2nkQaIpTb5AigJ+LWk9XJV0n+dxu09AbxeiGv+ll80ifPQxn AVuLhnQKnRWfKq/LAP+eMYv3+A8OH4g0B2S/TaCDKp/oxxkgHUsAzexmxMu+R09U 0kkTjRNsAuMULHdoIshMyNphKgYkdzkRraRQgEMTrymtabyTQGPusxNYKcNMxjnE 992bEWv05ev2m8hkDoWlxJeVO54irRQT9EcMASg2lwO2w11yoSFaDYOqiARGPo2W /Nrz1HzKcZFcHki9CUSs/quNGcRJ+ayMWvsLwJVPg5werc+TTh73JLIQjCTmnmmA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdeftddgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvufgtsegrtderreerredtnecuhfhrohhmpedflfhu shhtihhnucetsghrrghhmhhsfdcuoehjuhhsthhinhesrggsrhgrhhdrmhhsqeenucffoh hmrghinhepfhhigidrohhrghenucfrrghrrghmpehmrghilhhfrhhomhepjhhushhtihhn segrsghrrghhrdhmshenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A67B25C0099; Sat, 28 Dec 2019 15:51:20 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-694-gd5bab98-fmstable-20191218v1 Mime-Version: 1.0 Message-Id: <6f8f2117-288f-424f-a3a9-a511584bb22b@www.fastmail.com> In-Reply-To: References: Date: Sat, 28 Dec 2019 12:51:00 -0800 From: "Justin Abrahms" Content-Type: multipart/alternative; boundary=35787878ad0f446cb52ee2569a35bb16 X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Sat, 28 Dec 2019 16:55:25 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --35787878ad0f446cb52ee2569a35bb16 Content-Type: text/plain Thank you so much! On Sat, Dec 28, 2019, at 12:22 PM, Thomas Fitzsimmons wrote: > Hi, > > Thomas Fitzsimmons writes: > > [...] > > > Justin confirmed the attached patch fixes the problem for him. Can an > > Org mode maintainer review it? > > I also reported this upstream to the Org maintainers and they accepted > the fix. Org 9.3.1, which contains the fix, has been released. You can > install it from GNU ELPA. I'm marking this bug as done. > > Thomas > --35787878ad0f446cb52ee2569a35bb16 Content-Type: text/html
Thank you so much!

On Sat, Dec 28, 2019, at 12:22 PM, Thomas Fitzsimmons wrote:
Hi,

Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:

[...]

> Justin confirmed the attached patch fixes the problem for him.  Can an
> Org mode maintainer review it?

I also reported this upstream to the Org maintainers and they accepted
the fix.  Org 9.3.1, which contains the fix, has been released.  You can
install it from GNU ELPA.  I'm marking this bug as done.

Thomas

--35787878ad0f446cb52ee2569a35bb16--