GNU bug report logs - #38554
[PATCH 0/5] Update python-hy to 0.17.0

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38554 in the body.
You can then email your comments to 38554 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: guix-patches mailing list <guix-patches <at> gnu.org>
Subject: [PATCH 0/5]  Update python-hy to 0.17.0
Date: Mon, 09 Dec 2019 19:29:58 -0700

The next five patches:
- add dependencies for python-hy 0.17.0 (patches 1,2)
- update python-hy from 0.13.0 to 0.17.0 (patch 3)
- add dependencies for python2-hy 0.17.0 (patches 4,5)


This will be the last version of python-hy to support python 2. If it is
better to drop python2-hy now, simply omit patches 4 and 5, and remove
python2-hy.

-- 
-Jesse

Message #8 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <at> debbugs.gnu.org
Subject: [PATCH 1/5] Add python-fastentrypoints
Date: Mon, 09 Dec 2019 19:35:31 -0700

[Message part 1 (text/plain, inline)]

[0001-gnu-add-python-fastentrypoints.patch (text/x-patch, attachment)]

Message #11 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <at> debbugs.gnu.org
Subject: [PATCH 2/5]  Add python-funcparserlib
Date: Mon, 09 Dec 2019 19:36:41 -0700

[Message part 1 (text/plain, inline)]

[0002-gnu-Add-python-funcparserlib.patch (text/x-patch, attachment)]

Message #14 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <at> debbugs.gnu.org
Subject: [PATCH 3/5] Update python-hy to 0.17.0
Date: Mon, 09 Dec 2019 19:37:17 -0700

[Message part 1 (text/plain, inline)]

[0003-gnu-python-hy-Update-to-0.17.0.patch (text/x-patch, attachment)]

Message #17 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <at> debbugs.gnu.org
Subject: [PATCH 4/5]  Add python2-fastentrypoints
Date: Mon, 09 Dec 2019 19:37:58 -0700

[Message part 1 (text/plain, inline)]

[0004-gnu-Add-python2-fastentrypoints.patch (text/x-patch, attachment)]

Message #20 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <at> debbugs.gnu.org
Subject: [PATCH 5/5]  Add python2-funcparserlib
Date: Mon, 09 Dec 2019 19:38:40 -0700

[Message part 1 (text/plain, inline)]

[0005-gnu-Add-python2-funcparserlib.patch (text/x-patch, attachment)]

Message #23 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 38554 <at> debbugs.gnu.org
Subject: Re: [bug#38554] [PATCH 0/5]  Update python-hy to 0.17.0
Date: Mon, 09 Dec 2019 22:25:34 -0600

Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:

> The next five patches:
> - add dependencies for python-hy 0.17.0 (patches 1,2)
> - update python-hy from 0.13.0 to 0.17.0 (patch 3)
> - add dependencies for python2-hy 0.17.0 (patches 4,5)
>
>
> This will be the last version of python-hy to support python 2. If it is
> better to drop python2-hy now, simply omit patches 4 and 5, and remove
> python2-hy.

Hy Jesse! (Haha.)

Thank you for your patch series. I am sorry for the delay and the lack
of communication regarding your bug report. I could imagine this is
really frustrating. There are some corrections that I think need to be
made before we go forward, and for the sake of education I would like to
propose some revisions. Once we get these revisions, I think we will be
golden for a push to master! So bare with me.

First off, _USUALLY_ we have the package-for-python2 derivatives in the
same commits as the package indicating the original. Thus, your
python2-* patches (4 & 5) can be squashed into their originating commits
(1 & 2) respectively.

In patch 1: You indicate your copyright email as such:

--8<---------------cut here---------------start------------->8---
;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
--8<---------------cut here---------------end--------------->8---

Is this correct? Just seems odd to me.

Also in that patch you have too many white space return indications between the
preceeding package, and you have white space return at the EOF. This should be
reduced to one and none, respectively. Next, if you could run `guix
lint` on this package. Your synopsis and description sections are
identical and do not conform to our guidelines. I suspect this was just
the default from running `guix import pypi`.

If you need help with making synopsis and descriptions, here is the
relevant documentation:
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

In patch 2: There should be a white space return before the package in
this case, but was likely cut off from the improper EOF return in patch
1. Otherwise, this package looks okay aside from the issue with the
synopsis and description.

Lastly, all of the commit messages need a period at the end. And the
sub-header message for the patch which bumps Hy to 0.17 needs a period
as well. You could also remove the redundant [inputs] section and simply
make a comma-separated-list of new inputs. Also, if you could add
something like,

--8<---------------cut here---------------start------------->8---
Fixes: <link-to-original-bug-report>.
--8<---------------cut here---------------end--------------->8---

to the patch that updates Hy, that way we can know where this patch
series is predicated from. That would be superb!

Once we get these easy changes done we will push! If you could send your
revisions with something like:

--8<---------------cut here---------------start------------->8---
[PATCH v2 x/3]
--8<---------------cut here---------------end--------------->8---


Again, I apologize for the radio silence.

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

Message #26 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: Brett Gilio <brettg <at> posteo.net>
Cc: 38554 <at> debbugs.gnu.org
Subject: Re: [bug#38554] [PATCH 0/5]  Update python-hy to 0.17.0
Date: Tue, 10 Dec 2019 14:59:52 -0700

On Mon, 2019-12-09 at 22:25 -0600, Brett Gilio wrote:
> Jesse Gibbons <jgibbons2357 <at> gmail.com> writes:
> 
> > The next five patches:
> > - add dependencies for python-hy 0.17.0 (patches 1,2)
> > - update python-hy from 0.13.0 to 0.17.0 (patch 3)
> > - add dependencies for python2-hy 0.17.0 (patches 4,5)
> > 
> > 
> > This will be the last version of python-hy to support python 2. If it is
> > better to drop python2-hy now, simply omit patches 4 and 5, and remove
> > python2-hy.
> 
> Hy Jesse! (Haha.)
> 
> Thank you for your patch series. I am sorry for the delay and the lack
> of communication regarding your bug report. I could imagine this is
> really frustrating. There are some corrections that I think need to be
> made before we go forward, and for the sake of education I would like to
> propose some revisions. Once we get these revisions, I think we will be
> golden for a push to master! So bare with me.
I feel the need to automate producing these patches because there are a lot
of things my poor memory needs to remember. I'll make some commit scripts
and share them later. Or maybe I can write a local git hook to do all those
things for me.
> 
> First off, _USUALLY_ we have the package-for-python2 derivatives in the
> same commits as the package indicating the original. Thus, your
> python2-* patches (4 & 5) can be squashed into their originating commits
> (1 & 2) respectively.
I tried to figure this out, but it has been so long since a python package
has been added, and we anticipate python2 EOL, so I thought I would keep
them separate in case it wasn't worth adding the python2 versions as their
own patches. I'll fix this.
> 
> In patch 1: You indicate your copyright email as such:
> 
> --8<---------------cut here---------------start------------->8---
> ;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
> --8<---------------cut here---------------end--------------->8---
> 
> Is this correct? Just seems odd to me.

Yes, this is correct. As I understand it, names and email addresses are
added to the copyright section to allow someone to initiate contact with
each of the copyright holders regarding their copyright. The address looks
odd (and doesn't match some of the more common regexps for email addresses)
because it takes advantage of a feature that gives me (theoretically)
infinite email addresses that go to the same inbox. I use it to filter my
email, so I will know (in this case) an email is about a contribution I made
to guix, and my email client can filter it accordingly. I add the same email
address by my name in the copyright region when I send a major patch to
guix, and would rather not change it for this reason.

FMI see https://www.wikihow.com/Use-Plus-Addressing-in-Gmail
> 
> Also in that patch you have too many white space return indications
> between the preceeding package, and you have white space return at the
> EOF. This should be reduced to one and none, respectively.
Ok. So do I understand correctly patch 1 should have a single white space
after the package, but not patch 2?

> Next, if you could run `guix lint` on this package. Your synopsis and
> description sections are identical and do not conform to our guidelines. I
> suspect this was just the default from running `guix import pypi`.
> 
> If you need help with making synopsis and descriptions, here is the
> relevant documentation:
> https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
I forgot to change the synopsis and descriptions. I'll make sure I do that
before I send the fixed patches.
> 
> In patch 2: There should be a white space return before the package in
> this case, but was likely cut off from the improper EOF return in patch
> 1. Otherwise, this package looks okay aside from the issue with the
> synopsis and description.
> 
> Lastly, all of the commit messages need a period at the end. And the
> sub-header message for the patch which bumps Hy to 0.17 needs a period
> as well. You could also remove the redundant [inputs] section and simply
> make a comma-separated-list of new inputs. Also, if you could add
> something like,
> 
> --8<---------------cut here---------------start------------->8---
> Fixes: <link-to-original-bug-report>.
> --8<---------------cut here---------------end--------------->8---
> 
> to the patch that updates Hy, that way we can know where this patch
> series is predicated from. That would be superb!
Ok. I will make sure that happens.
> 
> Once we get these easy changes done we will push! If you could send your
> revisions with something like:
> 
> --8<---------------cut here---------------start------------->8---
> [PATCH v2 x/3]
> --8<---------------cut here---------------end--------------->8---
> 
In response to this email, or simply to 38554 <at> debbugs.gnu.org? I'm guessing
either will work, but you are more likely to see a response to this email.
> 
> Again, I apologize for the radio silence.
> 
Not to worry. I had (and still have) other work to do, and this was a low-
priority task. I might not be able to send the fixed patches until possibly
the 18th or 19th. I'll send the corrected patches, and possibly contribute
other pending package definitions and/or bug reports as well.

Message #29 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 38554 <at> debbugs.gnu.org
Subject: Re: [bug#38554] [PATCH 4/5] Add python2-fastentrypoints
Date: Thu, 12 Dec 2019 18:18:59 +0100

Hi Jesse,

Thank you for your patches.

As you have maybe seen, I have file a bug [1] to track the Python
packages and the end-of-file of Python 2. Here you add a new Python 2
entry. My question is: do we absolutely need it?

I have seen your bug report about the broken Hy REPL and this series
fixes it. My question is just: can we continue to add
`package-with-python2` packages?


All the best,
simon

[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38420

Message #32 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: Brett Gilio <brettg <at> posteo.net>, 38554 <at> debbugs.gnu.org
Subject: Re: [bug#38554] [PATCH 0/5] Update python-hy to 0.17.0
Date: Thu, 12 Dec 2019 18:23:54 +0100

Hi,

On Tue, 10 Dec 2019 at 23:01, Jesse Gibbons <jgibbons2357 <at> gmail.com> wrote:

> > Once we get these easy changes done we will push! If you could send your
> > revisions with something like:
> >
> > --8<---------------cut here---------------start------------->8---
> > [PATCH v2 x/3]
> > --8<---------------cut here---------------end--------------->8---
> >
> In response to this email, or simply to 38554 <at> debbugs.gnu.org? I'm guessing
> either will work, but you are more likely to see a response to this email.

Yes to 38554 <at> debbugs.gnu.org using the Git option --reroll-count=2 :-)

Thank you for your patches. Hy is really fun. :-)

All the best,
simon

Message #35 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 38554 <at> debbugs.gnu.org
Subject: Re: [bug#38554] [PATCH 4/5] Add python2-fastentrypoints
Date: Sun, 15 Dec 2019 17:37:15 -0700

On Thu, 2019-12-12 at 18:18 +0100, zimoun wrote:
> Hi Jesse,
> 
> Thank you for your patches.
> 
> As you have maybe seen, I have file a bug [1] to track the Python
> packages and the end-of-file of Python 2. Here you add a new Python 2
> entry. My question is: do we absolutely need it?
> 
> I have seen your bug report about the broken Hy REPL and this series
> fixes it. My question is just: can we continue to add
> `package-with-python2` packages?
> 
> 
> All the best,
> simon
> 
> [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=38420
This concern is why I added the python2 packages in separate patches
contrary to tradition. I wanted to know what others thought of it. We don't
necessarily need to add the python2 packages, especially when the repository
says this will be the last version of hy to support python2 and those
packages are only added to support hy in python2. I recommend you start a
discussion with Brett, who reviewed the patches and told me to combine patch
1 with 4 and 2 with 5. 
I have too much going on to create and send updated patches before Tuesday,
so I guess now is the time for such discussion.

Message #38 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <38554 <at> debbugs.gnu.org>
Subject: [PATCH v2 1/3] gnu: Add python-fastentrypoints.
Date: Sat, 21 Dec 2019 10:14:05 -0700

* gnu/packages/python-xyz.scm (python-fastentrypoints): New variable.
---
 gnu/packages/python-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 520de4607d..9243272dc9 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -68,6 +68,7 @@
 ;;; Copyright © 2019 Wiktor Żelazny <wzelazny <at> vurv.cz>
 ;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
 ;;; Copyright © 2019 Mădălin Ionel Patrașcu <
madalinionel.patrascu <at> mdc-berlin.de>
+;;; Copyright © 2019 Jesse Gibbons <jgibbons2357+guix <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -16972,3 +16973,28 @@ as @command{which} and @command{find}.  These
commands allow automated
 discovery of what has been installed on an operating system, and where the
 essential tools are located.")
     (license license:bsd-3)))
+
+(define-public python-fastentrypoints
+  (package
+    (name "python-fastentrypoints")
+    (version "0.12")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "fastentrypoints" version))
+       (sha256
+        (base32
+         "02s1j8i2dzbpbwgq2a3fiqwm3cnmhii2qzc0k42l0rdxd4a4ya7z"))))
+    (build-system python-build-system)
+    (home-page
+     "https://github.com/ninjaaron/fast-entry_points")
+    (synopsis
+     "Makes entry_points specified in setup.py load more quickly")
+    (description
+     "Using entry_points in your setup.py makes scripts that start really
slowly
+because it imports pkg_resources.  This package allows such setup scripts
to
+load entry points more quickly.")
+    (license license:bsd-3)))
+
+(define-public python2-fastentrypoints
+  (package-with-python2 python-fastentrypoints))

Message #41 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <38554 <at> debbugs.gnu.org>
Subject: [PATCH v2 2/3] gnu: Add python-funcparserlib.
Date: Sat, 21 Dec 2019 10:14:21 -0700

* gnu/packages/python-xyz.scm (python-funcparserlib): New variable.
---
 gnu/packages/python-xyz.scm | 49 +++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9243272dc9..906bd9c8d2 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -16998,3 +16998,52 @@ load entry points more quickly.")
 
 (define-public python2-fastentrypoints
   (package-with-python2 python-fastentrypoints))
+
+(define-public python-funcparserlib
+  (package
+    (name "python-funcparserlib")
+    (version "0.3.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "funcparserlib" version))
+       (sha256
+        (base32
+         "07f9cgjr3h4j2m67fhwapn8fja87vazl58zsj4yppf9y3an2x6dp"))))
+    (native-inputs
+     `(("python-tox" ,python-tox)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (invoke "tox"))))))
+    (build-system python-build-system)
+    (home-page
+     "https://github.com/vlasovskikh/funcparserlib")
+    (synopsis
+     "Recursive descent parsing library based on functional combinators")
+    (description
+     "This package is a recurisve descent parsing library for Python based
on
+functional combinators.  Parser combinators are just higher-order functions
that
+take parsers as their arguments and return them as result values.  Parser
+combinators are:
+
+@itemize @bullet
+@item First-class values
+@item Extremely composable
+@item Tend to make the code quite compact
+@item Resemble the readable notation of xBNF grammars
+@end itemize
+
+Parsers made with funcparserlib are pure-Python LL(*) parsers.  It means
that
+it's very easy to write them without thinking about look-aheads and all
that
+hardcore parsing stuff.  But the recursive descent parsing is a rather slow
+method compared to LL(k) or LR(k) algorithms.
+
+So the primary domain for funcparserlib is parsing little languages or
external
+DSLs (domain specific languages).")
+    (license license:expat)))
+
+(define-public python2-funcparserlib
+  (package-with-python2 python-funcparserlib))

Message #44 received at 38554 <at> debbugs.gnu.org (full text, mbox):

From: Jesse Gibbons <jgibbons2357 <at> gmail.com>
To: 38554 <38554 <at> debbugs.gnu.org>
Subject: [PATCH v2 3/3] gnu: python-hy: Update to 0.17.0.
Date: Sat, 21 Dec 2019 10:14:36 -0700

* gnu/packages/python-xyz.scm (python-hy): Update to 0.17.0.
[inputs]: Add python-fastentrypoints, python-funcparserlib.
Fixes: https://lists.gnu.org/archive/html/bug-guix/2019-12/msg00034.html.
---
 gnu/packages/python-xyz.scm | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 906bd9c8d2..c5dc022475 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -8514,20 +8514,20 @@ with a new public API, and RPython support.")
 (define-public python-hy
   (package
     (name "python-hy")
-    (version "0.13.0")
+    (version "0.17.0")
     (source (origin
               (method url-fetch)
               (uri (pypi-uri "hy" version))
               (sha256
                (base32
-                "19sfymaksx9jhksfnb15ahid46mzrhdfzz6yy2craz2qnzvpmky8"))))
+                "1gdbqsirsdxj320wnp7my5awzs1kfs6m4fqmkzbd1zd47qzj0zfi"))))
     (build-system python-build-system)
     (arguments
      '(#:phases
        (modify-phases %standard-phases
-	 (add-before 'install 'set-HOME
-	   (lambda _
-	     (setenv "HOME" "/tmp")))
+         (add-before 'install 'set-HOME
+           (lambda _
+             (setenv "HOME" "/tmp")))
          (replace 'check
            (lambda _
              ;; Tests require write access to HOME.
@@ -8539,8 +8539,10 @@ with a new public API, and RPython support.")
     (propagated-inputs
      `(("python-astor" ,python-astor)
        ("python-clint" ,python-clint)
-       ("python-rply" ,python-rply)))
-    (home-page "http://hylang.org/")
+       ("python-rply" ,python-rply)
+       ("python-fastentrypoints" ,python-fastentrypoints)
+       ("python-funcparserlib" ,python-funcparserlib)))
+    (home-page "http://docs.hylang.org/")
     (synopsis "Lisp frontend to Python")
     (description
      "Hy is a dialect of Lisp that's embedded in Python.  Since Hy
transforms

Message #49 received at 38554-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> gnu.org>
To: Jesse Gibbons <jgibbons2357 <at> gmail.com>
Cc: 38554 <38554-done <at> debbugs.gnu.org>
Subject: Re: [bug#38554] [PATCH v2 3/3] gnu: python-hy: Update to 0.17.0.
Date: Wed, 25 Dec 2019 01:27:32 -0600

Hy Jesse! (ha).

Thank you for taking the time to do the revisions I suggested. I
actually could not apply your patches cleanly (not your fault). So I
went through and manually added and modified the patches as
necessary. You are listed as the author on all of the commits.

I tested the resultant Hy package, and it looks and works fine! I do
think eventually we should maybe consider moving Hy to its own file
though? With a name that is just "hy" and not "python-hy". Maybe a
discussion for a different day.

6b520177734e1c144fd6394f801919d0b54fa23e
c5eb8cf844148fb99934c3fedc3b4a0da55f9d8e
c215051dcf30b11c755aea4e2527b4d3d91c34bb

Thanks! Closing.

-- 
Brett M. Gilio
GNU Guix, Contributor | GNU Project, Webmaster
[DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]
<brettg <at> gnu.org> <brettg <at> posteo.net>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.