GNU bug report logs - #38552
[PATCH 0/1] Dynamically-link Ruby

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38552 in the body.
You can then email your comments to 38552 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/1] Dynamically-link Ruby
Date: Mon, 09 Dec 2019 14:53:01 -0600

[0000-cover-letter.patch (text/x-patch, inline)]

From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Mon, 9 Dec 2019 14:50:51 -0600
Subject: [PATCH 0/1] Dynamically-link Ruby
To: guix-patches <at> gnu.org

This patch solves #38500. The current behavior of Ruby is to compile against libruby-static.a

Brett Gilio (1):
  gnu: ruby: Configure for dynamic linking.

 gnu/packages/ruby.scm | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.24.0

Message #8 received at 38552 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: 38552 <at> debbugs.gnu.org
Subject: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
Date: Mon, 09 Dec 2019 14:54:42 -0600

[0001-gnu-ruby-Configure-for-dynamic-linking.patch (text/x-patch, inline)]

From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
From: Brett Gilio <brettg <at> posteo.net>
Date: Mon, 9 Dec 2019 14:46:47 -0600
Subject: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
To: guix-patches <at> gnu.org

* gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to properly
  enable dynamic linking instead of using libruby-static.a. Solves #38500.

Reported-by: Vicente Eduardo <vic798 <at> gmail.com>
---
 gnu/packages/ruby.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 70b59e9156..a4b9bc6968 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -19,6 +19,7 @@
 ;;; Copyright © 2019 Brian Leung <bkleung89 <at> gmail.com>
 ;;; Copyright © 2019 Collin J. Doering <collin <at> rekahsoft.ca>
 ;;; Copyright © 2019 Diego N. Barbato <dnbarbato <at> posteo.de>
+;;; Copyright © 2019 Brett Gilio <brettg <at> posteo.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -95,6 +96,7 @@
     (build-system gnu-build-system)
     (arguments
      `(#:test-target "test"
+       #:configure-flags '("--enable-shared") ; dynamic linking
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'replace-bin-sh-and-remove-libffi
-- 
2.24.0

Message #11 received at 38552 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: 38552 <at> debbugs.gnu.org
Subject: Re: [bug#38552] [PATCH 0/1] Dynamically-link Ruby
Date: Mon, 09 Dec 2019 14:55:56 -0600

Brett Gilio <brettg <at> posteo.net> writes:

>>From 36e56ea5d882d112f24d49050813066eece98af2 Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg <at> posteo.net>
> Date: Mon, 9 Dec 2019 14:50:51 -0600
> Subject: [PATCH 0/1] Dynamically-link Ruby
> To: guix-patches <at> gnu.org
>
> This patch solves #38500. The current behavior of Ruby is to compile against libruby-static.a
>
> Brett Gilio (1):
>   gnu: ruby: Configure for dynamic linking.
>
>  gnu/packages/ruby.scm | 2 ++
>  1 file changed, 2 insertions(+)

I forgot to mention that this should go in core-update since it triggers
a rebuild of 3000+ packages. I am happy to push this to core-updates if
everything looks alright.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #14 received at 38552 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: Brett Gilio <brettg <at> posteo.net>, 38552 <at> debbugs.gnu.org
Subject: Re: [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
Date: Mon, 9 Dec 2019 22:12:52 +0100

On 09.12.19 21:54, Brett Gilio wrote:
> Subject: [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
> To: guix-patches <at> gnu.org
>
> * gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to properly
>   enable dynamic linking instead of using libruby-static.a. Solves #38500.
>
> Reported-by: Vicente Eduardo <vic798 <at> gmail.com>

Maybe change the commit format a little:

Fixes <https://bugs.gnu.org/38500>.
Reported-by: Vicente Eduardo <vic798 <at> gmail.com>

* gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to
properly enable dynamic linking instead of using libruby-static.a.

Message #17 received at 38552 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 38552 <at> debbugs.gnu.org
Subject: Re: [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
Date: Mon, 09 Dec 2019 16:13:30 -0600

Jonathan Brielmaier <jonathan.brielmaier <at> web.de> writes:
>
> Maybe change the commit format a little:
>
> Fixes <https://bugs.gnu.org/38500>.
> Reported-by: Vicente Eduardo <vic798 <at> gmail.com>
>
> * gnu/packages/ruby.scm (ruby)[arguments]: Use #:configure-flags to
> properly enable dynamic linking instead of using libruby-static.a.


Sounds like a good idea. Consider it done.

I will wait for more eyes before pushing to core-updates. Thank you Jonathan.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Message #22 received at 38552-done <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: 38552-done <at> debbugs.gnu.org
Subject: Re: [bug#38552] [PATCH 1/1] gnu: ruby: Configure for dynamic linking.
Date: Thu, 12 Dec 2019 21:49:47 -0600

Pushed to core-updates with fd248cb815d571043c3a0c52a01c9b3e368a069e.

Closing.

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.