Subject: [PATCH] services: dhcp-client: Ignore interfaces that need non-free firmware.

From: Brice Waegeneire <[email-masked]>
Date: Fri, 13 Dec 2019 22:56:08 +0100

* gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces
that need non-free firmware.
---
 gnu/services/networking.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm
index 93d9b6a15e..7a57e33974 100644
--- a/gnu/services/networking.scm
+++ b/gnu/services/networking.scm
@@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n")
                  (define valid?
                    (lambda (interface)
                      (and (arp-network-interface? interface)
-                          (not (loopback-network-interface? interface)))))
+                          (not (loopback-network-interface? interface))
+                          ;; XXX: Make sure the interfaces are up so that
+                          ;; 'dhclient' can actually send/receive over them.
+                          (false-if-exception
+                           (set-network-interface-up interface)))))
                  (define ifaces
                    (filter valid? (all-network-interface-names)))
 
-                 ;; XXX: Make sure the interfaces are up so that 'dhclient' can
-                 ;; actually send/receive over them.
-                 (for-each set-network-interface-up ifaces)
-
                  (false-if-exception (delete-file #$pid-file))
                  (let ((pid (fork+exec-command
                              (cons* #$dhclient "-nw"
-- 
2.19.2