From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 08 03:59:19 2019 Received: (at submit) by debbugs.gnu.org; 8 Dec 2019 08:59:19 +0000 Received: from localhost ([127.0.0.1]:50473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idsPO-0002PU-Ld for submit@debbugs.gnu.org; Sun, 08 Dec 2019 03:59:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:57511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idsPN-0002PN-0C for submit@debbugs.gnu.org; Sun, 08 Dec 2019 03:59:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44911) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idsPL-0006Tg-JB for bug-guix@gnu.org; Sun, 08 Dec 2019 03:59:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idsPJ-00040g-FX for bug-guix@gnu.org; Sun, 08 Dec 2019 03:59:14 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:51907) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1idsPI-0003s9-38 for bug-guix@gnu.org; Sun, 08 Dec 2019 03:59:12 -0500 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPA id 4C6E460005 for ; Sun, 8 Dec 2019 08:59:08 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 08 Dec 2019 09:59:08 +0100 From: Brice Waegeneire To: bug-guix@gnu.org Subject: 'dhcp-client-service' crash when non-libre networking interface is present Message-ID: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 217.70.183.195 X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The 'dhcp-client-service' fail to start when a non-libre network interface (here 148f:3070) is plugged-in even though there is an libre networking interface (here 01:00.0) available. Removing the non-libre networking interface from the system allow 'dhcp-client-service' to start correctly on the libre networking interface. I think the service shouldn't crash when there is an non-libre network interface connected, it should just skip it and maybe throw an error message. Allowing to specify the network interfaces on which 'dhcp-client-service' should run can also somewhat resolve the issue. #+begin_src sh $ sudo herd start networking [ 2758.305139] 1-3:1.0: Missing Free firmware (non-Free firmware loading is disabled) [ 2758.395791] ieee80211 phy0: rt2x00lib_request_firmware: Error - Failed to request Firmware herd: exception caught while executing 'start' on service 'networking': In procedure set-network-interface-flags: set-network-interface-flags on wlp0s20f0u3: No such file or directory $ ip a s 1: lo: mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000 link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 inet 127.0.0.1/8 scope host lo valid_lft forever preferred_lft forever inet6 ::1/128 scope host valid_lft forever preferred_lft forever 2: enp1s0: mtu 1500 qdisc pfifo_fast state DOWN group default qlen 1000 link/ether 00:e0:4c:68:67:77 brd ff:ff:ff:ff:ff:ff 3: wlp0s20f0u3: mtu 1500 qdisc noop state DOWN group default qlen 1000 link/ether 00:c0:ca:77:05:e7 brd ff:ff:ff:ff:ff:ff $ lsusb Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub Bus 001 Device 002: ID 148f:3070 Ralink Technology, Corp. RT2870/RT3070 Wireless Adapter Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub $ lspci 00:00.0 Host bridge: Intel Corporation Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers (rev 02) 00:02.0 VGA compatible controller: Intel Corporation HD Graphics 620 (rev 02) 00:08.0 System peripheral: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/7th Gen Core Processor Gaussian Mixture Model 00:14.0 USB controller: Intel Corporation Sunrise Point-LP USB 3.0 xHCI Controller (rev 21) 00:14.2 Signal processing controller: Intel Corporation Sunrise Point-LP Thermal subsystem (rev 21) 00:17.0 SATA controller: Intel Corporation Sunrise Point-LP SATA Controller [AHCI mode] (rev 21) 00:1c.0 PCI bridge: Intel Corporation Sunrise Point-LP PCI Express Root Port #3 (rev f1) 00:1e.0 Signal processing controller: Intel Corporation Sunrise Point-LP Serial IO UART Controller #0 (rev 21) 00:1e.4 SD Host controller: Intel Corporation Device 9d2b (rev 21) 00:1e.6 SD Host controller: Intel Corporation Sunrise Point-LP Secure Digital IO Controller (rev 21) 00:1f.0 ISA bridge: Intel Corporation Sunrise Point-LP LPC Controller (rev 21) 00:1f.2 Memory controller: Intel Corporation Sunrise Point-LP PMC (rev 21) 00:1f.3 Audio device: Intel Corporation Sunrise Point-LP HD Audio (rev 21) 00:1f.4 SMBus: Intel Corporation Sunrise Point-LP SMBus (rev 21) 01:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller (rev 07) #+end_src #+begin_src scheme (services (append (list (service openssh-service-type) (service dhcp-client-service-type)) %base-services))) #+end_src From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 12:11:54 2019 Received: (at 38524) by debbugs.gnu.org; 10 Dec 2019 17:11:54 +0000 Received: from localhost ([127.0.0.1]:56518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iej3C-0001J3-EJ for submit@debbugs.gnu.org; Tue, 10 Dec 2019 12:11:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iej39-0001Io-Rh for 38524@debbugs.gnu.org; Tue, 10 Dec 2019 12:11:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iej32-000734-1T; Tue, 10 Dec 2019 12:11:44 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=53700 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iej31-00042f-HL; Tue, 10 Dec 2019 12:11:43 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brice Waegeneire Subject: Re: bug#38524: 'dhcp-client-service' crash when non-libre networking interface is present References: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 20 Frimaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Dec 2019 18:11:41 +0100 In-Reply-To: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> (Brice Waegeneire's message of "Sun, 08 Dec 2019 09:59:08 +0100") Message-ID: <871rtcm7g2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38524 Cc: 38524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Brice, Brice Waegeneire skribis: > The 'dhcp-client-service' fail to start when a non-libre network=20 > interface (here 148f:3070) is plugged-in even though there is an libre=20 > networking interface (here 01:00.0) available. > Removing the non-libre networking interface from the system allow=20 > 'dhcp-client-service' to start correctly on the libre networking=20 > interface. By =E2=80=9Cnon-libre interface=E2=80=9D, I guess you mean a network interf= ace that relies on non-free firmware, right? > $ sudo herd start networking > [ 2758.305139] 1-3:1.0: Missing Free firmware (non-Free firmware loading= =20 > is disabled) > [ 2758.395791] ieee80211 phy0: rt2x00lib_request_firmware: Error -=20 > Failed to request Firmware > herd: exception caught while executing 'start' on service 'networking': So here the problem is that Linux-libre fails to load the non-free firmware. Could you bring it up on the Linux-libre development mailing list? I believe Linux-libre aims to allow people who want it to use non-free firmware=E2=80=94it just disables it by default. Now, I=E2=80=99d encourag= e you to consider using hardware that does not rely on non-free firmware. :-) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 16:25:39 2019 Received: (at 38524) by debbugs.gnu.org; 10 Dec 2019 21:25:39 +0000 Received: from localhost ([127.0.0.1]:56702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ien0k-0000PC-S3 for submit@debbugs.gnu.org; Tue, 10 Dec 2019 16:25:39 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ien0j-0000P1-1J for 38524@debbugs.gnu.org; Tue, 10 Dec 2019 16:25:37 -0500 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPA id 409B91BF20A; Tue, 10 Dec 2019 21:25:35 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 10 Dec 2019 22:25:34 +0100 From: Brice Waegeneire To: =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: bug#38524: 'dhcp-client-service' crash when non-libre networking interface is present In-Reply-To: <871rtcm7g2.fsf@gnu.org> References: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> <871rtcm7g2.fsf@gnu.org> Message-ID: <24efa7c98f8b2b64129104cc5ed05ab0@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38524 Cc: 38524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2019-12-10 18:11, Ludovic Courtès wrote: > So here the problem is that Linux-libre fails to load the non-free > firmware. Could you bring it up on the Linux-libre development mailing > list? Doing some research on how linux-libre behave it seems normal that it doesn't allow the loading of non-free firmware. So I think the issue is on the Guix side; in dhcp-client-service stopping on an error and not continuing to try other interface. If you don't think so what should I bring up to the linux-libre mailing list? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 12 08:07:49 2019 Received: (at 38524) by debbugs.gnu.org; 12 Dec 2019 13:07:49 +0000 Received: from localhost ([127.0.0.1]:59167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifOC5-0001wJ-C0 for submit@debbugs.gnu.org; Thu, 12 Dec 2019 08:07:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifOC3-0001w0-BF for 38524@debbugs.gnu.org; Thu, 12 Dec 2019 08:07:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ifOBy-0002dY-1c; Thu, 12 Dec 2019 08:07:42 -0500 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=43160 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ifOBx-0001Zp-KL; Thu, 12 Dec 2019 08:07:41 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brice Waegeneire Subject: Re: bug#38524: 'dhcp-client-service' crash when non-libre networking interface is present References: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> <871rtcm7g2.fsf@gnu.org> <24efa7c98f8b2b64129104cc5ed05ab0@waegenei.re> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Frimaire an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 12 Dec 2019 14:07:40 +0100 In-Reply-To: <24efa7c98f8b2b64129104cc5ed05ab0@waegenei.re> (Brice Waegeneire's message of "Tue, 10 Dec 2019 22:25:34 +0100") Message-ID: <87tv658zfn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38524 Cc: 38524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Brice Waegeneire skribis: > On 2019-12-10 18:11, Ludovic Court=C3=A8s wrote: >> So here the problem is that Linux-libre fails to load the non-free >> firmware. Could you bring it up on the Linux-libre development mailing >> list? > Doing some research on how linux-libre behave it seems normal that it > doesn't allow the loading of non-free firmware. It obviously doesn=E2=80=99t do it by default, but my understanding is that= the goal is to allow it (you could check with them). > So I think the issue is on the Guix side; in dhcp-client-service > stopping on an error and not continuing to try other interface. If you > don't think so what should I bring up to the linux-libre mailing list? =E2=80=98dhcp-client-service=E2=80=99 passes the DHCP client the list of in= terfaces that are =E2=80=9Cvalid=E2=80=9D (see gnu/services/networking.scm). Could you f= ind out why yours is considered =E2=80=9Cvalid=E2=80=9D when it shouldn=E2=80=99t? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 16:56:32 2019 Received: (at 38524) by debbugs.gnu.org; 13 Dec 2019 21:56:32 +0000 Received: from localhost ([127.0.0.1]:34712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifsvI-0008Jo-J0 for submit@debbugs.gnu.org; Fri, 13 Dec 2019 16:56:32 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifsvG-0008Jf-2W for 38524@debbugs.gnu.org; Fri, 13 Dec 2019 16:56:31 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A346D60003 for <38524@debbugs.gnu.org>; Fri, 13 Dec 2019 21:56:27 +0000 (UTC) From: Brice Waegeneire To: 38524@debbugs.gnu.org Subject: [PATCH] services: dhcp-client: Ignore interfaces that need non-free Date: Fri, 13 Dec 2019 22:56:07 +0100 Message-Id: <20191213215608.19193-1-brice@waegenei.re> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38524 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This patch allow dhcp-client-service to start even when an interface that require non free-software is present; such device will be skipped. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 16:56:43 2019 Received: (at 38524) by debbugs.gnu.org; 13 Dec 2019 21:56:43 +0000 Received: from localhost ([127.0.0.1]:34715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifsvS-0008KD-PY for submit@debbugs.gnu.org; Fri, 13 Dec 2019 16:56:43 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifsvQ-0008K2-CP for 38524@debbugs.gnu.org; Fri, 13 Dec 2019 16:56:40 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id ED758FF804 for <38524@debbugs.gnu.org>; Fri, 13 Dec 2019 21:56:36 +0000 (UTC) From: Brice Waegeneire To: 38524@debbugs.gnu.org Subject: [PATCH] services: dhcp-client: Ignore interfaces that need non-free firmware. Date: Fri, 13 Dec 2019 22:56:08 +0100 Message-Id: <20191213215608.19193-2-brice@waegenei.re> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20191213215608.19193-1-brice@waegenei.re> References: <20191213215608.19193-1-brice@waegenei.re> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38524 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces that need non-free firmware. --- gnu/services/networking.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 93d9b6a15e..7a57e33974 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n") (define valid? (lambda (interface) (and (arp-network-interface? interface) - (not (loopback-network-interface? interface))))) + (not (loopback-network-interface? interface)) + ;; XXX: Make sure the interfaces are up so that + ;; 'dhclient' can actually send/receive over them. + (false-if-exception + (set-network-interface-up interface))))) (define ifaces (filter valid? (all-network-interface-names))) - ;; XXX: Make sure the interfaces are up so that 'dhclient' can - ;; actually send/receive over them. - (for-each set-network-interface-up ifaces) - (false-if-exception (delete-file #$pid-file)) (let ((pid (fork+exec-command (cons* #$dhclient "-nw" -- 2.19.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 23:39:57 2019 Received: (at 38524) by debbugs.gnu.org; 14 Dec 2019 04:39:57 +0000 Received: from localhost ([127.0.0.1]:34863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifzDh-00078t-4Y for submit@debbugs.gnu.org; Fri, 13 Dec 2019 23:39:57 -0500 Received: from mout02.posteo.de ([185.67.36.66]:41635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifzDe-00078W-IR for 38524@debbugs.gnu.org; Fri, 13 Dec 2019 23:39:55 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DEB692400FB for <38524@debbugs.gnu.org>; Sat, 14 Dec 2019 05:39:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1576298387; bh=CeKh3yXX/G+j9numrG8H4wL0Hzx5cv9xyXgxrHGUAc0=; h=Date:From:To:Cc:Subject:From; b=jijwhuKXPwYVrccSla/4nHPk4xDIpnFQOOqjSZDSUxjKIoArljsZ44+APBdrkPjni 4DEqMUFRT6z3kuyI6P/7Ux4FCrCv01k2C9FK78iw5HwdQF0IhWLwjXxib0CTgGoJ6A 7uNPT00Xle+A76vUBu8CcqJrd9D7dtdlP5XVmKOVmMjNWW6fpBAvJEJaO6agqb+t1L y/US4VpeWG/Ni2rZM9049D6i6PgQFA+peseHSBwNHOycwq3EEnu6wiR6uNeFw6wU1f Vt0li7Byzr8KLOhFOTO8EEsFgcAnYOgGpjsmoEWn2PvBkeL/PTnHsVuOLFxrs0f8TA SSQ0Vy4EAZZYg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47ZZZV4l1Wz9rxT; Sat, 14 Dec 2019 05:39:46 +0100 (CET) Date: Sat, 14 Dec 2019 04:39:33 +0000 (UTC) From: Brett Gilio To: Brice Waegeneire Message-ID: <6d2807a3-a796-4c14-b24d-515f3c7fbe52@localhost> In-Reply-To: <20191213215608.19193-2-brice@waegenei.re> References: <20191213215608.19193-1-brice@waegenei.re> <20191213215608.19193-2-brice@waegenei.re> Subject: Re: bug#38524: [PATCH] services: dhcp-client: Ignore interfaces that need non-free firmware. MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Correlation-ID: <6d2807a3-a796-4c14-b24d-515f3c7fbe52@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38524 Cc: 38524@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This LGTM, though I'd add a comment noting this bug report or something so it is known why this behavior was adjusted. Dec 13, 2019 3:57:14 PM Brice Waegeneire : > * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces > that need non-free firmware. > --- > gnu/services/networking.scm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm > index 93d9b6a15e..7a57e33974 100644 > --- a/gnu/services/networking.scm > +++ b/gnu/services/networking.scm > @@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n") > (define valid? > (lambda (interface) > (and (arp-network-interface? interface) > - (not (loopback-network-interface? interface))))) > + (not (loopback-network-interface? interface)) > + ;; XXX: Make sure the interfaces are up so that > + ;; 'dhclient' can actually send/receive over them. > + (false-if-exception > + (set-network-interface-up interface))))) > (define ifaces > (filter valid? (all-network-interface-names))) > > - ;; XXX: Make sure the interfaces are up so that 'dhclient' can > - ;; actually send/receive over them. > - (for-each set-network-interface-up ifaces) > - > (false-if-exception (delete-file #$pid-file)) > (let ((pid (fork+exec-command > (cons* #$dhclient "-nw" > -- > 2.19.2 > From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 14 02:23:34 2019 Received: (at 38524) by debbugs.gnu.org; 14 Dec 2019 07:23:34 +0000 Received: from localhost ([127.0.0.1]:34904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig1m2-0004Bs-GR for submit@debbugs.gnu.org; Sat, 14 Dec 2019 02:23:34 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig1m0-0004Bf-7j for 38524@debbugs.gnu.org; Sat, 14 Dec 2019 02:23:33 -0500 X-Originating-IP: 78.237.113.178 Received: from localhost (luy13-1-78-237-113-178.fbx.proxad.net [78.237.113.178]) (Authenticated sender: brice@waegenei.re) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 50BAA1BF205 for <38524@debbugs.gnu.org>; Sat, 14 Dec 2019 07:23:30 +0000 (UTC) From: Brice Waegeneire To: 38524@debbugs.gnu.org Subject: [PATCH v2] services: dhcp-client: Ignore interfaces that need non-free firmware. Date: Sat, 14 Dec 2019 08:23:26 +0100 Message-Id: <20191214072326.7570-1-brice@waegenei.re> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38524 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Fixes bug #38524 (see: https://bugs.gnu.org/38524). * gnu/services/networking.scm (dhcp-client-service-type): Filter interfaces that need non-free firmware. --- This patch version contains a link to the issue as Brett asked. gnu/services/networking.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gnu/services/networking.scm b/gnu/services/networking.scm index 93d9b6a15e..7a57e33974 100644 --- a/gnu/services/networking.scm +++ b/gnu/services/networking.scm @@ -223,14 +223,14 @@ fe80::1%lo0 apps.facebook.com\n") (define valid? (lambda (interface) (and (arp-network-interface? interface) - (not (loopback-network-interface? interface))))) + (not (loopback-network-interface? interface)) + ;; XXX: Make sure the interfaces are up so that + ;; 'dhclient' can actually send/receive over them. + (false-if-exception + (set-network-interface-up interface))))) (define ifaces (filter valid? (all-network-interface-names))) - ;; XXX: Make sure the interfaces are up so that 'dhclient' can - ;; actually send/receive over them. - (for-each set-network-interface-up ifaces) - (false-if-exception (delete-file #$pid-file)) (let ((pid (fork+exec-command (cons* #$dhclient "-nw" -- 2.19.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 11:50:25 2019 Received: (at 38524-done) by debbugs.gnu.org; 29 Dec 2019 16:50:25 +0000 Received: from localhost ([127.0.0.1]:60122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilblp-0000Vz-JY for submit@debbugs.gnu.org; Sun, 29 Dec 2019 11:50:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43139) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilbln-0000Vl-TT for 38524-done@debbugs.gnu.org; Sun, 29 Dec 2019 11:50:24 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ilbli-0004IS-Ck; Sun, 29 Dec 2019 11:50:18 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=41308 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ilblh-0005IE-Sj; Sun, 29 Dec 2019 11:50:18 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brice Waegeneire Subject: Re: bug#38524: [PATCH v2] services: dhcp-client: Ignore interfaces that need non-free firmware. References: <975fd0999fa4f6fab542a11dd761fb6e@waegenei.re> <20191214072326.7570-1-brice@waegenei.re> Date: Sun, 29 Dec 2019 17:50:15 +0100 In-Reply-To: <20191214072326.7570-1-brice@waegenei.re> (Brice Waegeneire's message of "Sat, 14 Dec 2019 08:23:26 +0100") Message-ID: <87a77b9iuw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38524-done Cc: 38524-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Brice, Brice Waegeneire skribis: > Fixes bug #38524 (see: https://bugs.gnu.org/38524). > > * gnu/services/networking.scm (dhcp-client-service-type): Filter interfac= es > that need non-free firmware. I adjusted the commit log (I=E2=80=99m not applying it just because it helps with non-free firmware but rather because it seems more accurate and generally useful), and finally committed. Thank you! Ludo=E2=80=99. From unknown Sat Sep 06 07:59:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Jan 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator