From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 14:02:29 2019 Received: (at submit) by debbugs.gnu.org; 4 Dec 2019 19:02:29 +0000 Received: from localhost ([127.0.0.1]:42685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icZuu-0000UV-OB for submit@debbugs.gnu.org; Wed, 04 Dec 2019 14:02:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:58297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icZus-0000UL-TX for submit@debbugs.gnu.org; Wed, 04 Dec 2019 14:02:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50093) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icZur-0000vq-3B for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2019 14:02:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icZun-0000xv-Ja for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2019 14:02:24 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:43047) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icZul-0000v9-Pg for bug-gnu-emacs@gnu.org; Wed, 04 Dec 2019 14:02:21 -0500 Received: by mail-wr1-x436.google.com with SMTP id d16so463548wre.10 for ; Wed, 04 Dec 2019 11:02:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=G9uCAk3iTWnFuSHw/VNpI5xEXC+t2fOozyZO7TUr38Y=; b=Dr9rvUsQbnPr5xyyEmOoddXjC4vMxmbf0UKBgEEp3vBFoiHcRcGdiYQ6dLpnfCuIys i91Jv6kuVyVLEr1w9qxdWr2TYj0ayNmapPrdPSVW4pK+Wdn4yQ7Yb74DivhFg50GlFER LqrzceHgCw39EsjfnwzsmbyecqtbnhovUignLlMfgcyzMpGtun6DiZVLKY1t+eMqbeSN iZ3GQuEwGkNbB9RfGYRa8g4AspsUaNgs7wUfyzgWln0LfjkdrKG25D6dCjbRuYmnujit Eioj2vGusKPySVi6V/NLlbo+yj0FE8soD+jaqpMHYA2lVUeF+Usur9cLxfmT90Q7ThwS 84xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=G9uCAk3iTWnFuSHw/VNpI5xEXC+t2fOozyZO7TUr38Y=; b=qmuxQIDdaSEw46oNj49qva7eZ+mUafj8b4TT2yciMhEegrZ52Bqr+4FBAnGUs5QVN/ 0K3cCWVR6cZH5zkurA7lA8Ybj+9x0319PvySYhHCr4xrPxgYfOatp3mR3GABf3xVWBye hyk5AlGfaS2ZKYfyKfwPHFpO8NaTE3bwV+uZxmmGP5B0tchB45orOJ0Tvwlvpk/JYBfj 7YG30Ko2dg9YADdgWsdPuA39jIGnyY7hfjCiumh4GaTCLbyN3jLTRkHVYRTASTDfa0i+ TQ4AO4CijDzfjirmyIbjeXaUUydl2Mf63BRekpfMxEt8/GEr0/7lpLsFTdpE+8EB0ksK 0EAA== X-Gm-Message-State: APjAAAWnixfUR9ZshjRC3jfvpPQTkxRnOmodSaifCFwQ3ceCidsKImep 2z2ZF21qpWxYMNwlZyH1Hdvi6nCh X-Google-Smtp-Source: APXvYqwbmNkkfSmjDz8C1e6u27vEs/JE9c0V0Uc/Bi+KkSkStX/o47HuYjYTWkmXNk2iqxwC+bqrRA== X-Received: by 2002:adf:f1cb:: with SMTP id z11mr5534727wro.375.1575486136888; Wed, 04 Dec 2019 11:02:16 -0800 (PST) Received: from little-buster (2a01cb04010fc800a9966e0b19f92b66.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:a996:6e0b:19f9:2b66]) by smtp.gmail.com with ESMTPSA id z64sm8400715wmg.30.2019.12.04.11.02.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 11:02:15 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: bug-gnu-emacs@gnu.org Subject: 27.0.50; Warn pdumper users when pure space has been overflowed Date: Wed, 04 Dec 2019 20:02:12 +0100 Message-ID: <87o8wnj4nf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello, For some reason, one of my setups[1] experiences a pure storage overflow with the current master[2]. Searching previous bug reports for the warning[3] led me to understand that increasing BASE_PURESIZE in src/puresize.h would solve the issue; since I didn't have the patience to recompile possibly multiple times, I tried to find a way to know exactly how much I should increase this value. I noticed that Fdump_emacs uses check_pure_size from alloc.c to print a warning before dumping when this happens. The following patch exposes check_pure_size when we HAVE_PDUMPER, so that Fdump_emacs_portable can use it too. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Warn-pdumper-users-when-pure-space-has-been-overflow.patch >From 02a48f2388932ae78460a76f74e27202212994d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Le=20Gouguec?= Date: Wed, 4 Dec 2019 18:22:29 +0100 Subject: [PATCH] Warn pdumper users when pure space has been overflowed * src/alloc.c (check_pure_size): Expose when using the portable dumper. * src/pdumper.c (Fdump_emacs_portable): Use it. --- src/alloc.c | 2 +- src/pdumper.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/alloc.c b/src/alloc.c index 9fbd0d0573..52ea87c7b7 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -5125,7 +5125,7 @@ pure_alloc (size_t size, int type) } -#ifdef HAVE_UNEXEC +#if defined HAVE_UNEXEC || defined HAVE_PDUMPER /* Print a warning if PURESIZE is too small. */ diff --git a/src/pdumper.c b/src/pdumper.c index 74f198c4ae..721d23e696 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -4004,6 +4004,8 @@ DEFUN ("dump-emacs-portable", { eassert (initialized); + check_pure_size (); + if (will_dump_with_unexec_p ()) error ("This Emacs instance was started under the assumption " "that it would be dumped with unexec, not the portable " -- 2.20.1 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable That gets me a helpful error message at compile-time[4] (as well as an intriguing warning[5]) that let me figure out how much I should increase BASE_PURESIZE by, recompile Emacs and run it with no further warnings about pure storage overflow. Would it make sense to apply this? (Maybe not as-is: e.g. I don't know if the #if guard is still useful at this point; maybe the call to check_pure_size should be moved somewhere else=E2=80=A6) Thank you for your time. [1] Debian Buster on Samsung NC10 (32-bit, 2GB RAM). [2] 8bea7e9ab4453da71d9766d582089154f31de907 [3] Warning (initialization): Building Emacs overflowed pure space. (See t= he node Pure Storage in the Lisp manual for details.) [4] emacs:0:Pure Lisp storage overflow (approx. 2005404 bytes needed) [5] alloc.c:5136:14: warning: format =E2=80=98%d=E2=80=99 expects argument = of type =E2=80=98int=E2=80=99, but argument 2 has type =E2=80=98intmax_t=E2= =80=99 {aka =E2=80=98long long int=E2=80=99} [-Wformat=3D] message (("emacs:0:Pure Lisp storage overflow (approx. %"pI"d" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ " bytes needed)"), ~~~~~~~~~~~~~~~~~ I tried to puzzle this one out by looking at the definition for pI in lisp.h, but I am not sure how to proceed. The warning suggests that pI is defined as "" since the final format is %d, which means that I should look into this snippet: # elif INTPTR_MAX <=3D INT_MAX && !defined WIDE_EMACS_INT typedef int EMACS_INT; typedef unsigned int EMACS_UINT; enum { EMACS_INT_WIDTH =3D INT_WIDTH, EMACS_UINT_WIDTH =3D UINT_WIDTH }; # define EMACS_INT_MAX INT_MAX # define pI "" =E2=80=A6 I can probably dig into this to see what's wrong on my setup[= 1], but I'll bank on someone more experienced going "Oh well duh" and fixing whatever needs fixing (assuming the problem isn't on my end). In GNU Emacs 27.0.50 (build 11, i686-pc-linux-gnu, GTK+ Version 3.24.5, cai= ro version 1.16.0) of 2019-11-17 built on little-buster Repository revision: 1c29ba034092660e73bce8c6ff459c75ff2c2d72 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --with-xwidgets --with-cairo' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Features: (shadow sort mail-extr emacsbug sendmail etags fileloop generator xref vc-mtn vc-hg mule-util warnings filecache markdown-mode rx color noutline outline help-fns radix-tree magit-extras sh-script smie flyspell ispell executable cus-edit wid-edit whitespace notifications dbus xml misearch multi-isearch bug-reference cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs thingatpt magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process magit-mode git-commit magit-git magit-section magit-utils crm log-edit message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log with-editor async-bytecomp async shell pcomplete server dash vc-git vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs project delight eighters-theme rg rg-info-hack advice rg-menu transient cl-extra format-spec rg-ibuffer rg-result wgrep-rg wgrep s rg-history rg-header ibuf-ext ibuffer ibuffer-loaddefs grep compile comint ansi-color ring quail help-mode edmacro kmacro disp-table paren mb-depth icomplete page-break-lines elec-pair diff-hl-flydiff diff diff-hl vc-dir ewoc vc vc-dispatcher diff-mode easy-mmode delsel cus-start cus-load tex-site info package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting xwidget-internal cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 8 330562 41453) (symbols 24 23104 2) (strings 16 73924 11567) (string-bytes 1 2445511) (vectors 8 42019) (vector-slots 4 959888 63404) (floats 8 281 269) (intervals 28 21802 357) (buffers 568 52)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 11:15:45 2019 Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 16:15:45 +0000 Received: from localhost ([127.0.0.1]:46927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGGe-00052P-P6 for submit@debbugs.gnu.org; Fri, 06 Dec 2019 11:15:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGGa-00050y-2c for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 11:15:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idGGN-0002J4-BE; Fri, 06 Dec 2019 11:15:27 -0500 Received: from [176.228.60.248] (port=2445 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1id8jF-0003fM-Bp; Fri, 06 Dec 2019 03:12:45 -0500 Date: Fri, 06 Dec 2019 10:12:44 +0200 Message-Id: <83blslhnyb.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?K=E9vin?= Le Gouguec , Daniel Colascione In-reply-to: <87o8wnj4nf.fsf@gmail.com> (message from =?iso-8859-1?Q?K=E9v?= =?iso-8859-1?Q?in?= Le Gouguec on Wed, 04 Dec 2019 20:02:12 +0100) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Kévin Le Gouguec > Date: Wed, 04 Dec 2019 20:02:12 +0100 > > For some reason, one of my setups[1] experiences a pure storage overflow > with the current master[2]. Searching previous bug reports for the > warning[3] led me to understand that increasing BASE_PURESIZE in > src/puresize.h would solve the issue; since I didn't have the patience > to recompile possibly multiple times, I tried to find a way to know > exactly how much I should increase this value. > > I noticed that Fdump_emacs uses check_pure_size from alloc.c to print a > warning before dumping when this happens. The following patch exposes > check_pure_size when we HAVE_PDUMPER, so that Fdump_emacs_portable can > use it too. I'm not sure we should care about overflowing the pure space in pdumped Emacs. Why does it matter? It mattered in unexec'ed Emacs, that's why we warned about it. Maybe the right solution is to remove the warning from startup.el instead. Daniel, what are your thoughts about this? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 11:38:01 2019 Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 16:38:01 +0000 Received: from localhost ([127.0.0.1]:46964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGcD-000624-Ad for submit@debbugs.gnu.org; Fri, 06 Dec 2019 11:38:01 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:36229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGcB-00061o-KP for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 11:38:00 -0500 Received: by mail-wr1-f52.google.com with SMTP id z3so8492406wru.3 for <38492@debbugs.gnu.org>; Fri, 06 Dec 2019 08:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mHMJGkGy6K46LjX9NJmAWoEhJt46OoDSiHRVUhlKrAM=; b=D2rkaKtbsjy8DdHipxYf+XW4AKgFuydF2SiY/hYfaDfJb6neny0qxpssbUDK/KXRq8 303TKPLm1i91pCI9IbxJG5i+gux/ZvTNWeDueMVmP5esES3HcqacjiasPBrERoNDsW2T dJLPeCDuZ7jjlSpCuXhBAagVkoTXdrx33WVT55Op1BzikNuSJACKLDQ82GNtH/o2tC+d N03XwL2jqKdHaQAuDbyB3nMUanVG9/CnoP+A+G4f8wQU/4btvMt/mbVG02bXHcxti+9K MT19gvnIkDzhwA29IvfEVMa+nE+fy4X/pIf7u+LBKtRqZrlcth9QeBH7CarL6iUxUCfm lxIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=mHMJGkGy6K46LjX9NJmAWoEhJt46OoDSiHRVUhlKrAM=; b=K0a4qsqGFG1ai+q6HCyw92YLlVOebpDGO9we16bEmUkMQjEHzY8Xz7m3RTCbQ96gtC qGmI0P1KQj2Pdd8HVXiDtO0dlPKC1/8fkV4nki40n/UZo8wUFVShucOKd5F/+xJ+GZmD fr/n2NT7ekXn4HMOm5IQYsILLCdo+GBY6lQGT+UV5c5u02wZDsqaEEcptPetfU/mtu38 mVoiMvihQ0czvrndFzDowYSXyHS5v70XjhZ+YyiF+zd+F+gn02QeQ7A32jgatcTicf2f PfPQnUwdmuuBqQLErG1rMnKinpR5pFnf3Tkd2uDVZyZJR+Fphoo3xQSx/sE6kedApxeh IMLQ== X-Gm-Message-State: APjAAAUS6vh7SWlp3M1/Mn8avNCmskSsCDtpjUkLUwnouOMQ6cNkd7kl a3DDOWIkHMzcdPZ43esaoS20ZUwU/CM= X-Google-Smtp-Source: APXvYqyWlU9jRxjDO86YgeoSuCTFNnIP1z/NAlBx5mIXTGcmY1Q8NgbZD/zZ9qzEdwXWqWZe7tDHYA== X-Received: by 2002:adf:c74f:: with SMTP id b15mr16581738wrh.272.1575650273193; Fri, 06 Dec 2019 08:37:53 -0800 (PST) Received: from little-buster (2a01cb04010fc800344a427cd486b589.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:344a:427c:d486:b589]) by smtp.gmail.com with ESMTPSA id g69sm4067593wmg.13.2019.12.06.08.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2019 08:37:52 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Eli Zaretskii Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <83blslhnyb.fsf@gnu.org> Date: Fri, 06 Dec 2019 17:37:49 +0100 In-Reply-To: <83blslhnyb.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 06 Dec 2019 10:12:44 +0200") Message-ID: <87muc5wgte.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, Daniel Colascione X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I'm not sure we should care about overflowing the pure space in > pdumped Emacs. Why does it matter? It mattered in unexec'ed Emacs, > that's why we warned about it. Maybe the right solution is to remove > the warning from startup.el instead. Sorry for the false alarm then. I took the startup warning at face value; I didn't see anything in (elisp)Pure Storage suggesting that the portable dumper invalidated it. Had I tried to run garbage-collect manually, I would have noticed that the return value was non-nil, suggesting that GC wasn't disabled=E2=80=A6 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 11:49:10 2019 Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 16:49:10 +0000 Received: from localhost ([127.0.0.1]:46972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGn0-0006qa-CX for submit@debbugs.gnu.org; Fri, 06 Dec 2019 11:49:10 -0500 Received: from dancol.org ([96.126.100.184]:39642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idGmx-0006qI-3t for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 11:49:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XasBjEo0N52GWtJevVyMNriWE0cr0TUzRYSkHlzLZD4=; b=qI2KkRsOeGV/Aq2SzH5SjYiIzm AOQ8w9Bx61WewMYlO4ipOAylWWwY8h9CcPyh2GpVBJ3ry9Sr9FW8S52PZnIT58IFfuTcMwnCGRmCF snFhTnCNI7nr9wwhFW6cTGOxThsPDxBy8eLcHwIh17oD1T0U6FFq1/Of8NWWe9Z8CrUmHdKs9blBK 4AH7QkDaizsxCXlUGfaTBtXOkFKlVz2rCHSP9M3vJNX4BbkNyENRmXs6uLlBHOHN2oRyKZPlZGJCO G6rjvQH982JCZYK5/XBnLO7huIxo9U7bpS0lKps4g6vjGWr02P45D5nH6qiwPdoGIXyzvlA1u8v9v F9+ZuKGw==; Received: from [2604:4080:1321:9a00:e13c:266:1dc4:1cfa] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1idGmw-0000o1-0X; Fri, 06 Dec 2019 08:49:06 -0800 Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed To: =?UTF-8?Q?K=c3=a9vin_Le_Gouguec?= , Eli Zaretskii References: <87o8wnj4nf.fsf@gmail.com> <83blslhnyb.fsf@gnu.org> <87muc5wgte.fsf@gmail.com> From: Daniel Colascione Message-ID: Date: Fri, 6 Dec 2019 08:49:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <87muc5wgte.fsf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/6/19 8:37 AM, KĂ©vin Le Gouguec wrote: > Eli Zaretskii writes: > >> I'm not sure we should care about overflowing the pure space in >> pdumped Emacs. Why does it matter? It mattered in unexec'ed Emacs, >> that's why we warned about it. Maybe the right solution is to remove >> the warning from startup.el instead. > > Sorry for the false alarm then. I took the startup warning at face > value; I didn't see anything in (elisp)Pure Storage suggesting that the > portable dumper invalidated it. > > Had I tried to run garbage-collect manually, I would have noticed that > the return value was non-nil, suggesting that GC wasn't disabled… We should probably consider just removing the pure space mechanism at some point. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 13:52:01 2019 Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 18:52:01 +0000 Received: from localhost ([127.0.0.1]:47071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIhs-0007ce-V6 for submit@debbugs.gnu.org; Fri, 06 Dec 2019 13:52:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIhr-0007c3-UR for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 13:52:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idIhm-0000oa-J6; Fri, 06 Dec 2019 13:51:54 -0500 Received: from [176.228.60.248] (port=1870 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idIhl-0006Cj-W8; Fri, 06 Dec 2019 13:51:54 -0500 Date: Fri, 06 Dec 2019 20:51:54 +0200 Message-Id: <83wob9ffsl.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-reply-to: (message from Daniel Colascione on Fri, 6 Dec 2019 08:49:04 -0800) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <83blslhnyb.fsf@gnu.org> <87muc5wgte.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 38492@debbugs.gnu.org > From: Daniel Colascione > Date: Fri, 6 Dec 2019 08:49:04 -0800 > > We should probably consider just removing the pure space mechanism at > some point. Does this mean you agree with removing the warning in startup.el about overflowed pure space? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 14:02:35 2019 Received: (at 38492) by debbugs.gnu.org; 6 Dec 2019 19:02:35 +0000 Received: from localhost ([127.0.0.1]:47076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIs6-0000Lb-UN for submit@debbugs.gnu.org; Fri, 06 Dec 2019 14:02:35 -0500 Received: from dancol.org ([96.126.100.184]:41956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIs5-0000LT-CP for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 14:02:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From: In-Reply-To:Message-ID:Subject:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CP1FGYYG/R51H64F4KVRbHmfbwRlt+50bhdac7SPYwQ=; b=rQdu5swU6vkBEoAgasTQMJJqU/ 67wgC4Al4vCBWEVpwsO584cfPaumX6JBRu9+oycb8hzJabg20ksv2i5+8ProKTcicHYlHGgXK7BrC DztUMPFqii2ZrXtaULNeSzxACJ8V6/uAxa86dx+qp11FBr1ocHA4PjvRZ3PGbCMFIPeTJ2GI516GM fQ/Xpg5GLjO+Hby4/SpqNQki95vX9Tdnqnsglr1t4GsaenGGvDTQzPts+XpWdvW0KHJ9XUcmzuHUg yr3o4WuGH1LCVVy6EI52li6HdObWIxevAqlImgsiP9mExnVa5Phx9bLMoK2Am3mMMYfnZHSFP3RaP tFEqTB9g==; Received: from [2620:0:1009:fd00:d0d2:6925:4e6f:110f] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1idIs3-0002zH-0W; Fri, 06 Dec 2019 11:02:31 -0800 Date: Fri, 06 Dec 2019 11:02:28 -0800 Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Message-ID: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> X-Android-Message-ID: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> In-Reply-To: <83wob9ffsl.fsf@gnu.org> From: dancol@dancol.org To: Eli Zaretskii Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Dec 6, 2019 10:51 AM, Eli Zaretskii wrote: > > > Cc: 38492@debbugs.gnu.org > > From: Daniel Colascione > > Date: Fri, 6 Dec 2019 08:49:04 -0800 > > > > We should [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Dec 6, 2019 10:51 AM, Eli Zaretskii wrote: > > > Cc: 38492@debbugs.gnu.org > > From: Daniel Colascione > > Date: Fri, 6 Dec 2019 08:49:04 -0800 > > > > We should [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 HTML_MESSAGE BODY: HTML included in message 0.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 1.8 MISSING_MIMEOLE Message has X-MSMail-Priority, but no X-MimeOLE PHAgZGlyPSJsdHIiPk9uIERlYyA2LCAyMDE5IDEwOjUxIEFNLCBFbGkgWmFyZXRza2lpICZsdDtl bGl6QGdudS5vcmcmZ3Q7IHdyb3RlOjxicj4KJmd0Ozxicj4KJmd0OyAmZ3Q7IENjOiAzODQ5MkBk ZWJidWdzLmdudS5vcmcgPGJyPgomZ3Q7ICZndDsgRnJvbTogRGFuaWVsIENvbGFzY2lvbmUgJmx0 O2RhbmNvbEBkYW5jb2wub3JnJmd0OyA8YnI+CiZndDsgJmd0OyBEYXRlOiBGcmksIDYgRGVjIDIw MTkgMDg6NDk6MDQgLTA4MDAgPGJyPgomZ3Q7ICZndDsgPGJyPgomZ3Q7ICZndDsgV2Ugc2hvdWxk IHByb2JhYmx5IGNvbnNpZGVyIGp1c3QgcmVtb3ZpbmcgdGhlIHB1cmUgc3BhY2UgbWVjaGFuaXNt IGF0IDxicj4KJmd0OyAmZ3Q7IHNvbWUgcG9pbnQuIDxicj4KJmd0Ozxicj4KJmd0OyBEb2VzIHRo aXMgbWVhbiB5b3UgYWdyZWUgd2l0aCByZW1vdmluZyB0aGUgd2FybmluZyBpbiBzdGFydHVwLmVs IDxicj4KJmd0OyBhYm91dCBvdmVyZmxvd2VkIHB1cmUgc3BhY2U/PC9wPgo8cCBkaXI9Imx0ciI+ WWVzLiA8YnI+PC9wPgo= From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 23:48:32 2019 Received: (at 38492) by debbugs.gnu.org; 7 Dec 2019 04:48:32 +0000 Received: from localhost ([127.0.0.1]:47264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idS19-00060Q-Bs for submit@debbugs.gnu.org; Fri, 06 Dec 2019 23:48:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idS17-000604-N2 for 38492@debbugs.gnu.org; Fri, 06 Dec 2019 23:48:29 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idS12-0005DD-3J; Fri, 06 Dec 2019 23:48:24 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1idS10-0003Z2-N0; Fri, 06 Dec 2019 23:48:22 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: dancol@dancol.org In-Reply-To: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> (dancol@dancol.org) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Message-Id: Date: Fri, 06 Dec 2019 23:48:22 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, eliz@gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] With portable dumping. I think pure space provides no benefit. So it would be fine to turn off use of it in that case. But I think it would be a mistake to delete the code for pure space until we are sure that everything other than portable dumpimng is obsolete. -- Dr Richard Stallman Founder, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 08 02:46:54 2019 Received: (at 38492) by debbugs.gnu.org; 8 Dec 2019 07:46:54 +0000 Received: from localhost ([127.0.0.1]:50420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idrHJ-00057f-Tq for submit@debbugs.gnu.org; Sun, 08 Dec 2019 02:46:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idrHI-00057T-Bs for 38492@debbugs.gnu.org; Sun, 08 Dec 2019 02:46:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idV07-0008RU-Ao; Sat, 07 Dec 2019 02:59:39 -0500 Received: from [176.228.60.248] (port=1804 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idUzy-0004HJ-MB; Sat, 07 Dec 2019 02:59:31 -0500 Date: Sat, 07 Dec 2019 09:59:22 +0200 Message-Id: <83immsftwl.fsf@gnu.org> From: Eli Zaretskii To: rms@gnu.org In-reply-to: (message from Richard Stallman on Fri, 06 Dec 2019 23:48:22 -0500) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, dancol@dancol.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Richard Stallman > Cc: eliz@gnu.org, 38492@debbugs.gnu.org, kevin.legouguec@gmail.com > Date: Fri, 06 Dec 2019 23:48:22 -0500 > > With portable dumping. I think pure space provides no benefit. > So it would be fine to turn off use of it in that case. > > But I think it would be a mistake to delete the code for pure space > until we are sure that everything other than portable dumpimng is > obsolete. We are not going to delete the pure space code in Emacs 27, because we still support unexec there. I think I will just remove the warning in startup.el about pure-space overflow. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 14 06:42:29 2019 Received: (at 38492-done) by debbugs.gnu.org; 14 Dec 2019 11:42:29 +0000 Received: from localhost ([127.0.0.1]:34996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig5oa-0006TI-VK for submit@debbugs.gnu.org; Sat, 14 Dec 2019 06:42:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig5oa-0006T3-5Y for 38492-done@debbugs.gnu.org; Sat, 14 Dec 2019 06:42:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ig5oU-0002mb-DS; Sat, 14 Dec 2019 06:42:22 -0500 Received: from [176.228.60.248] (port=2421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ig5oS-0002IG-O5; Sat, 14 Dec 2019 06:42:21 -0500 Date: Sat, 14 Dec 2019 13:42:07 +0200 Message-Id: <838snf6smo.fsf@gnu.org> From: Eli Zaretskii To: dancol@dancol.org In-reply-to: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> (dancol@dancol.org) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492-done Cc: 38492-done@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 06 Dec 2019 11:02:28 -0800 > From: dancol@dancol.org > Cc: kevin.legouguec@gmail.com, 38492@debbugs.gnu.org > > > > We should probably consider just removing the pure space mechanism at > > > some point. > > > > Does this mean you agree with removing the warning in startup.el > > about overflowed pure space? > > Yes. Thanks, I removed the warning in a pdumper build, and I'm closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 14 09:10:09 2019 Received: (at 38492-done) by debbugs.gnu.org; 14 Dec 2019 14:10:09 +0000 Received: from localhost ([127.0.0.1]:35052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig87V-0004ul-20 for submit@debbugs.gnu.org; Sat, 14 Dec 2019 09:10:09 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:34144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ig87T-0004uM-1B for 38492-done@debbugs.gnu.org; Sat, 14 Dec 2019 09:10:07 -0500 Received: by mail-wm1-f51.google.com with SMTP id f4so1470947wmj.1 for <38492-done@debbugs.gnu.org>; Sat, 14 Dec 2019 06:10:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=+aus0dpCw8F50vV/INmnPsgrB273e+IwrRctdMjugHI=; b=ADwMAC54jP4epLDSMTgc9EC9lOQWYJzKQxm2afdbYYYlAqXxflV9zziAYzmwDslmyY JBx8VqDa4F+MVldltRwIZgyUQkRrGB4qtCOyi8b7zc/9ci5bY2OyZxW6rdDq9beZa6la vbdD+efV4+u6S5C56zlkc9qiR+BpqcIF5zzWZpz3NIO18S7qOzfLRqdZZx9Ii05WoHIP y+ZFuo2fxlpndKlEc1RMCLdzomnvxxTd9fTfuKesVArJxDo7sWH01PhF9TtMBQAU+9IE nJat3nVziL/bdpgJDKj8R34GX+IKjh2HWPxesXv/Spk+EB2D+G2KGCB9mC0Y8sE9KhBM 48Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=+aus0dpCw8F50vV/INmnPsgrB273e+IwrRctdMjugHI=; b=l4w568cNgfgbYwHM0VAeACImDRmbbKd5uUTrIDSA96vVHXdhoRnyQHav4TklUI/2N/ kU+2MkyiglfWKPN1XaNnxsJPJvSa+YbdekLz22c7D9+F1BBsWlmCrkK5QcEFwy4aBThv rVDhHLN1aOfsW0pU368XxFCLJCTPfx8gWJS6zS5OqOYW1uVh6JvUheXLy3DsQ/RwfW4h wY5xgOnBsN71Ndg7FhdIUMAtqOBSyGU2ThIoXucaNQ717ukMy47cznd+ZXcGa7o3KMwd HCkVmFFOlgf3XdBp5fFmBYs+fzKgBxwhJ4l/ZWUrlBEwNqlrYPr3sVS9DxhBPi2CNDIC BaaA== X-Gm-Message-State: APjAAAXBXH85j3eBn8wsKNa0w71g0SbS9RbuSQ1HwCysPieVLVCz83JR tLLP9OgIfJWbGs1P8d0igImt877C X-Google-Smtp-Source: APXvYqyu+CYhrssCLr/c6hkZbhVSeKXPV+rHf3DF4cI4p5ElfF8abId1W+IGmZjIKwwJKilu4lDXBw== X-Received: by 2002:a1c:a543:: with SMTP id o64mr19857109wme.108.1576332600729; Sat, 14 Dec 2019 06:10:00 -0800 (PST) Received: from little-buster (2a01cb04010fc8006518877a6103706a.ipv6.abo.wanadoo.fr. [2a01:cb04:10f:c800:6518:877a:6103:706a]) by smtp.gmail.com with ESMTPSA id u10sm13808269wmd.1.2019.12.14.06.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Dec 2019 06:09:59 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Eli Zaretskii Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> <838snf6smo.fsf@gnu.org> Date: Sat, 14 Dec 2019 15:09:44 +0100 In-Reply-To: <838snf6smo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Dec 2019 13:42:07 +0200") Message-ID: <87blsbt2vr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38492-done Cc: dancol@dancol.org, 38492-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, I removed the warning in a pdumper build, and I'm closing this > bug report. Thanks! I had started looking at the ifs and whens in startup.el, but wasn't sure how to translate "have we been dumped with pdumper" into Lisp: dumped_with_pdumper_p is not callable from Lisp, I wasn't sure about pdumper-stats's perennity, and dump-mode is only non-nil when Emacs is dumping itself. I'm glad you solved this conundrum for me :) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:33:40 2019 Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:33:40 +0000 Received: from localhost ([127.0.0.1]:37239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaaC-0005YP-3P for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:33:40 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igaaA-0005Wz-W0 for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:33:39 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 88EF580B9B; Sun, 15 Dec 2019 15:33:33 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F28E7810B1; Sun, 15 Dec 2019 15:33:31 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1576442012; bh=v9T+Ztk1QbqrBflTXbKpW0KKq8LVAhCCAbdBxvmUHJc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gsSMSWCyFPPF8kXetEQNdpCxfqZ1brGa/RebldTNyvtDdq2o1SAkMMNlXmu1N/6Du 6gbnVtAoWDIgOzpxkDeni1T91SkEAae2TZ9bdFMWpFhPYeasRPbH1D6dJmsHUTMyc+ akX2CyfzAZUZNAXSBGa4VYXbBG+0NYJHOQXr1VQ1qUiEcTXMSeF4tuJJsjMvu3h+QO JpPPoZXmLSWZAdTOGebtCL6QjfPz22QR9TbLZ1+fif02J6jHuLMxhGLPoOXsFxJJcz DO2RdpMXHQ92ZfBYe3NMiT/WftXs/zTlPW56vw4WHdIoJ4WTPaFLllnJlS9rI6KCJs +53/HYVkpE+CA== Received: from pastel (unknown [45.72.153.183]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BB03512120D; Sun, 15 Dec 2019 15:33:31 -0500 (EST) From: Stefan Monnier To: dancol@dancol.org Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Message-ID: References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Date: Sun, 15 Dec 2019 15:33:30 -0500 In-Reply-To: <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> (dancol@dancol.org's message of "Fri, 06 Dec 2019 11:02:28 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, Eli Zaretskii , kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > We should probably consider just removing the pure space mechanism at >> > some point. >> Does this mean you agree with removing the warning in startup.el >> about overflowed pure space? > Yes. Why? This warning was placed because we needed to disable GC in dumps that had overflown the purespace, so the dumped Emacs was not fully functional. I see that with the current pdump we don't disable GC in dumps that overflew the purespace. Why is that? IIRC, the problem with running GC in an Emacs with overflown purespace is that overflowing the purespace created pointers from the purespace to the heap and those aren't traced by the GC so it resulted in core dumps. I can't exactly remember the cases where this happened, but I can't see why the pdumper would be less affected than the unexec code. I see that the code has a slightly different explanation: /* Can't GC if pure storage overflowed because we can't determine if something is a pure object or not. */ garbage_collection_inhibited++; but that comment similarly seems to apply to pdump just as much as it applies to unexec. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:41:15 2019 Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:41:15 +0000 Received: from localhost ([127.0.0.1]:37253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahW-0006Ka-VQ for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:15 -0500 Received: from dancol.org ([96.126.100.184]:57098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahV-0006KR-CE for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From: Subject:Date:References:In-Reply-To:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5s0JjjeeuecM3S8LSDviMoSAdcfdWeulps9HtbKdNNM=; b=HtiPdnWSU0jK2u9TtNB23mtKOT bwl+3Vi/0ps22cEMPO2XZEfbVOMP67Os+w25//YgS0aeAFm6Jw73GGKCbuFLhuj+JlfQg8EchykTi xa5SS/nzPaykiKX3dgotfFdouIUKw4QF/2Jgw26WBpAzj6KDU6sV8KVZIQyLOjmNIKhvG/P7pRnly poUABo22YDS5Hm/2adC2D8uM8bp3fMddq14JcPWCd54dRlX+tC7ygHANDrIJmD5NpjAwVlnMDvdMC ecfKRfZfDvy1wELBT+1ogZW7OnK78VbIT5+etnYrDcGUCE07OqVumnvDtZQeWMIkIQugZtIi81cGD xmW1al/g==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.89) (envelope-from ) id 1igahO-0006Hs-Gr; Sun, 15 Dec 2019 12:41:06 -0800 Received: from 127.0.0.1 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Sun, 15 Dec 2019 12:41:06 -0800 Message-ID: <9bf76c35d7c57f0b181615614147d1f8.squirrel@dancol.org> In-Reply-To: References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Date: Sun, 15 Dec 2019 12:41:06 -0800 Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed From: "Daniel Colascione" To: "Stefan Monnier" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, Eli Zaretskii , dancol@dancol.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> > We should probably consider just removing the pure space mechanism at >>> > some point. >>> Does this mean you agree with removing the warning in startup.el >>> about overflowed pure space? >> Yes. > > Why? > > This warning was placed because we needed to disable GC in dumps that > had overflown the purespace, so the dumped Emacs was not > fully functional. > > I see that with the current pdump we don't disable GC in dumps that > overflew the purespace. Why is that? > > IIRC, the problem with running GC in an Emacs with overflown purespace > is that overflowing the purespace created pointers from the purespace to > the heap and those aren't traced by the GC so it resulted in core dumps. > > I can't exactly remember the cases where this happened, but I can't see > why the pdumper would be less affected than the unexec code. > > I see that the code has a slightly different explanation: > > /* Can't GC if pure storage overflowed because we can't determine > if something is a pure object or not. */ > garbage_collection_inhibited++; > > but that comment similarly seems to apply to pdump just as much as it > applies to unexec. In a pdumped Emacs, we don't have anything in purespace on pdumper load, so we can GC normally. We do disable GC during dump operation itself if we overflow, true, and we shouldn't do that, but this problem affects only the build. We should just make sure Vpurify_flag is off if we're going to make a pdumper image. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:41:43 2019 Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:41:43 +0000 Received: from localhost ([127.0.0.1]:37257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahz-0006LF-7s for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:43 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igahx-0006L3-QJ for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:41:42 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6176344D128; Sun, 15 Dec 2019 15:41:36 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 1F5B944D125; Sun, 15 Dec 2019 15:41:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1576442495; bh=4iQXNHS7UAtWQthYo29OufpCQZJRZsQNWlaNDn1DPkE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iudjG4tOmzTLofUzu2toGpex1u3bTMMFDZ2Xcfywlb/RynQGQrbk1Mm2e0+rMMQDZ pxsipddUcBt+ANXt6faAUbOlHY8v+/RTUcCz8yYmbHm33w1QH7GEadgTx+IV+WRPul Srk8itLxDGWXSod3fGSE1iqbksHWEVn429nwlHcedoMDyRTdr1vIsfIQFIoqzyt4AC X2apyX4n/ap3NkFWRF0Vvs1ebepGqQOh5j406Dv4ahkrdSYOZSg/xDZDi1cCqC8kKh Q2K8bFLpyRZr69VHhygJdIb/q/cDdbLKaumjsa7Hhp0XP9ehAbjqIS1bXr+mHfjYrF lPiMJeembrxiw== Received: from pastel (unknown [45.72.153.183]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BC7EC121187; Sun, 15 Dec 2019 15:41:34 -0500 (EST) From: Stefan Monnier To: Richard Stallman Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed Message-ID: References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Date: Sun, 15 Dec 2019 15:41:33 -0500 In-Reply-To: (Richard Stallman's message of "Fri, 06 Dec 2019 23:48:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.910 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, eliz@gnu.org, dancol@dancol.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > With portable dumping. I think pure space provides no benefit. AFAICT, the purespace provides the same benefit with portable dumping as it does with unexec. The benefit is to save time during the GC by not traversing the purespace. It's basically an "old" generation in a kind of very restricted form of generational GC. Maybe purespace is too small compared to typical heap sizes to make a significant difference, nowadays. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 15:45:04 2019 Received: (at 38492) by debbugs.gnu.org; 15 Dec 2019 20:45:04 +0000 Received: from localhost ([127.0.0.1]:37262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igalD-0006Sa-OH for submit@debbugs.gnu.org; Sun, 15 Dec 2019 15:45:03 -0500 Received: from dancol.org ([96.126.100.184]:57148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igalB-0006Rq-L1 for 38492@debbugs.gnu.org; Sun, 15 Dec 2019 15:45:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:To:From: Subject:Date:References:In-Reply-To:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=asQnC63SpRwTynXk/dxrk3Rgurlt3KE8bw2GF3IBm2k=; b=DcN+vHz1oKaCG0m5toB0eQmRYg qEtHrWg91h82OITSrpQjcSQhzQsRoePSa6pAMD6aNekTll5QcEjCCqC13HcbahcoiT5Mj/s2RSIUP YLnfTVDQ0Jp60ckn1sLhIKJxCwjj7OfKBZ8I78PfQGHuFBsOqF88ddha0oAVyEaMDU0j9HttlD1yT FAl/rVZyG50A36BKZwhPw4LVDLxZU9NzqgEX5yogoK9TbsA7QMy4D+TBhxbvwO1q+pWBrGm/FcW/t YrDBla0j1YSSJPvjnxdDrp2hBDPWyeFuiGAgoZ+p7TRoz0LUpDuCNDoI0OXcWmgUGNpvWxssTdROD KGfpFL2g==; Received: from localhost ([127.0.0.1] helo=dancol.org) by dancol.org with esmtp (Exim 4.89) (envelope-from ) id 1igalA-0006Lc-2G; Sun, 15 Dec 2019 12:45:00 -0800 Received: from 2604:4080:1321:9a00:92cd:c8cc:97ad:3100 (SquirrelMail authenticated user dancol) by dancol.org with HTTP; Sun, 15 Dec 2019 12:45:00 -0800 Message-ID: <68c7ed2d3ff837fcfa46cf854551d3fb.squirrel@dancol.org> In-Reply-To: References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Date: Sun, 15 Dec 2019 12:45:00 -0800 Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed From: "Daniel Colascione" To: "Stefan Monnier" User-Agent: SquirrelMail/1.4.23 [SVN] MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, eliz@gnu.org, dancol@dancol.org, Richard Stallman , kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> With portable dumping. I think pure space provides no benefit. > > AFAICT, the purespace provides the same benefit with portable dumping as > it does with unexec. The benefit is to save time during the GC by not > traversing the purespace. It's basically an "old" generation in a kind > of very restricted form of generational GC. > > Maybe purespace is too small compared to typical heap sizes to make > a significant difference, nowadays. I think the ratio of dumped-heap to runtime-heap is high enough these days that the pure optimization you're describing doesn't really matter. I think we need a better general-purpose GC that does generational tracking even after the dump and without purespace's restriction against intergenerational pointers. Whether that's something we reuse or write, I don't know yet, but I have some ideas for how we can combine these techniques with our conservative stack scanning. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 22:09:48 2019 Received: (at 38492) by debbugs.gnu.org; 17 Dec 2019 03:09:48 +0000 Received: from localhost ([127.0.0.1]:40590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ih3F5-0007p1-Ps for submit@debbugs.gnu.org; Mon, 16 Dec 2019 22:09:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ih3F4-0007om-3a for 38492@debbugs.gnu.org; Mon, 16 Dec 2019 22:09:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ih3Ey-0007MM-OO; Mon, 16 Dec 2019 22:09:40 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ih3Ex-00036B-1K; Mon, 16 Dec 2019 22:09:39 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 15 Dec 2019 15:41:33 -0500) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Message-Id: Date: Mon, 16 Dec 2019 22:09:39 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > AFAICT, the purespace provides the same benefit with portable dumping as > it does with unexec. The benefit is to save time during the GC by not > traversing the purespace. It's basically an "old" generation in a kind > of very restricted form of generational GC. I never thought about it that way, but I guess you are right. (The original intended benefit was to share memory between Emacs processes.) Perhaps for this reason we should keep pure space. It would be interesting to measure the effect on eliminating pure space on the speed of a GC-intensive task. -- Dr Richard Stallman Founder, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 22:09:50 2019 Received: (at 38492) by debbugs.gnu.org; 17 Dec 2019 03:09:50 +0000 Received: from localhost ([127.0.0.1]:40592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ih3F8-0007pG-4w for submit@debbugs.gnu.org; Mon, 16 Dec 2019 22:09:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ih3F5-0007op-L0 for 38492@debbugs.gnu.org; Mon, 16 Dec 2019 22:09:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ih3F0-0007Ni-90; Mon, 16 Dec 2019 22:09:42 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ih3Ez-00036R-Cv; Mon, 16 Dec 2019 22:09:41 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 15 Dec 2019 15:33:30 -0500) Subject: Re: bug#38492: 27.0.50; Warn pdumper users when pure space has been overflowed References: <87o8wnj4nf.fsf@gmail.com> <66439438-e275-49cd-8b84-a70a4d1b2087@email.android.com> Message-Id: Date: Mon, 16 Dec 2019 22:09:41 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38492 Cc: 38492@debbugs.gnu.org, dancol@dancol.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > >> > We should probably consider just removing the pure space mechanism at > >> > some point. > >> Does this mean you agree with removing the warning in startup.el > >> about overflowed pure space? > > Yes. > Why? > This warning was placed because we needed to disable GC in dumps that > had overflown the purespace, so the dumped Emacs was not > fully functional. If pure space provides some benefit with portable dumping, so we keep it, we need something to inform developers that we need to increase the size of pure space. That warning is the way we do that. -- Dr Richard Stallman Founder, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From unknown Fri Jun 13 11:24:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Jan 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator