GNU bug report logs - #38480
[PATCH] gnu: Add lolcat

Previous Next

Full log

Message #17 received at 38480 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38480 <at> debbugs.gnu.org, Brett Gilio <brettg <at> posteo.net>
Subject: Re: [bug#38480] [PATCH] gnu: Add lolcat
Date: Sun, 15 Dec 2019 01:10:30 +0100

[Message part 1 (text/plain, inline)]

Hello!

Am Sonntag, den 15.12.2019, 00:28 +0100 schrieb Ludovic Courtès:
> Hello!
> 
> Leo Prikler <leo.prikler <at> student.tugraz.at> skribis:
> 
> > From: Leo Prikler <leo.prikler <at> student.tugraz.at>
> > Date: Wed,  4 Dec 2019 02:46:44 +0100
> > Subject: [PATCH] gnu: Add lolcat
> > 
> > * gnu/packages/games.scm (lolcat): New package.
> 
> [...]
> 
> > +           (replace 'install
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (let ((dest (map (lambda (path) (string-append path
> > "/bin"))
> > +                                (list (assoc-ref outputs "out")
> > +                                      (assoc-ref outputs
> > "censor")))))
> > +                 (for-each mkdir-p dest)
> > +                 (install-file "lolcat" (car dest))
> > +                 (install-file "censor" (cadr dest))
> > +                 #t))))))
> > +      (outputs (list "out" "censor"))
> 
> Can’t we keep them both in the same output?  Separate outputs are
> normally only used when it helps save space, but I don’t think that’s
> a
> concern here.  :-)
Of course we can.  I initially separated them, because it's really two
very different programs put into one git repo, but of course the
separation serves no real purpose.

> > +      (home-page "https://github.com/jaseg/lolcat")
> > +      (synopsis "Rainbow coloring effect for text console
> > display")
> > +      (description "Lolcat concatenates files and streams like
> > regular cat,
>                        ^                                             
>      ^
> Maybe @command{cat} and @command{lolcat}.
Not sure about @command{lolcat}, since it's at the start of the
sentence, but okay.

> Could you send an updated patch?
> 
> Thanks,
> Ludo’.
Patch is attached.

Regards,
Leo

[0001-gnu-Add-lolcat.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.