GNU bug report logs - #38477
[PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.

Previous Next

Full log

View this message in rfc822 format

From: Brett Gilio <brettg <at> posteo.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 38477 <at> debbugs.gnu.org
Subject: [bug#38477] [PATCH] services: SSH services: Provide 'ssh' and 'sshd' Shepherd services.
Date: Tue, 03 Dec 2019 21:06:28 -0600

Leo Famulari <leo <at> famulari.name> writes:

> This should improve the "user experience" when querying the status of
> the SSH service.  We could even add program specific strings like
> "lshd", "dropbear", and "openssh".  Thoughts?

I think this is a good idea. It would add a lot of granular
control. However, we would need to make sure this is a standard used for
other SSH options in the future.

> * gnu/services/ssh.scm (lsh-shepherd-service, dropbear-shepherd-service,
> openssh-sheperd-service): Add 'ssh' and 'sshd' to provision.
> ---
>  gnu/services/ssh.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/services/ssh.scm b/gnu/services/ssh.scm
> index ced1991fba..7e25810eff 100644
> --- a/gnu/services/ssh.scm
> +++ b/gnu/services/ssh.scm
> @@ -174,7 +174,7 @@
>  
>    (list (shepherd-service
>           (documentation "GNU lsh SSH server")
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (requirement requires)
>           (start #~(make-forkexec-constructor (list #$@lsh-command)))
>           (stop  #~(make-kill-destructor)))))
> @@ -511,7 +511,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "OpenSSH server.")
>           (requirement '(syslogd loopback))
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$openssh-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor))
> @@ -620,7 +620,7 @@ of user-name/file-like tuples."
>    (list (shepherd-service
>           (documentation "Dropbear SSH server.")
>           (requirement requires)
> -         (provision '(ssh-daemon))
> +         (provision '(ssh-daemon ssh sshd))
>           (start #~(make-forkexec-constructor #$dropbear-command
>                                               #:pid-file #$pid-file))
>           (stop #~(make-kill-destructor)))))

LGTM! Very simple solution. Should be easy to cross-implement to other uses.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.