From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH] Telega test suite and change in revision Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2019 21:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15753224084198 (code B ref -1); Mon, 02 Dec 2019 21:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2019 21:33:28 +0000 Received: from localhost ([127.0.0.1]:39051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtJw-00015e-If for submit@debbugs.gnu.org; Mon, 02 Dec 2019 16:33:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:49988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtJu-00015W-HA for submit@debbugs.gnu.org; Mon, 02 Dec 2019 16:33:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37370) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibtJs-0002xe-Un for guix-patches@gnu.org; Mon, 02 Dec 2019 16:33:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_20,RCVD_IN_DNSWL_MED, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibtJr-0003de-J0 for guix-patches@gnu.org; Mon, 02 Dec 2019 16:33:24 -0500 Received: from mout02.posteo.de ([185.67.36.66]:39633) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibtJp-0003ZR-EJ for guix-patches@gnu.org; Mon, 02 Dec 2019 16:33:21 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 46A7D2400E6 for ; Mon, 2 Dec 2019 22:33:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575322396; bh=agpI8IrcfvpTD4e4Sca1YhdwLQxtP0psEZRmXISTO18=; h=From:To:Subject:Date:From; b=Mdq8wlsJ6+wIJdsJ2vM7UeyzA9wDagkk2ui5XBnwPnb6j8DznlcQhkV9MbkK/5NgA etnLvWWIq3pEKUq1Jhva9XaG8VkPhlIbyln5va5w0PdTJv0G/SBOlRDDXF2akVNSey XAxHZXFI4KwoOwJOZzaRJObe2VfD+dW4TudrJTrXmUyUsWyQ63xbw3LM5VwSyYjdUd GUIaSp5UaDTNNVZjuSDusTggQJDsWbgroxqj34N12Y92KXghKbPvKq9/oLF+/hT3rv EelR+m1rFSshF1hSsSlxQ+ta/8XGTkwjHqcRuVEMF0I3gcuffIsFRgZy4YG5WY1PwW xJEW7dsYsjLXQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47RddR24dvz9rxM for ; Mon, 2 Dec 2019 22:33:15 +0100 (CET) From: Brett Gilio Date: Mon, 02 Dec 2019 15:33:18 -0600 Message-ID: <87r21mh0pt.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.66 X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi all, the following patches modify the emacs-telega package to carefully use the ert and server test suites it has, and also includes an increase in the revision to use a newer commit. Let me know what you think! -- Brett M. Gilio https://git.sr.ht/~brettgilio/ From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 1/2] gnu: emacs-telega: Use test suites. References: <87r21mh0pt.fsf@posteo.net> In-Reply-To: <87r21mh0pt.fsf@posteo.net> Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2019 21:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.15753224884334 (code B ref 38463); Mon, 02 Dec 2019 21:35:01 +0000 Received: (at 38463) by debbugs.gnu.org; 2 Dec 2019 21:34:48 +0000 Received: from localhost ([127.0.0.1]:39056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtLD-00017p-TG for submit@debbugs.gnu.org; Mon, 02 Dec 2019 16:34:48 -0500 Received: from mout02.posteo.de ([185.67.36.66]:48721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtLC-00017c-B9 for 38463@debbugs.gnu.org; Mon, 02 Dec 2019 16:34:46 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 64D862400FB for <38463@debbugs.gnu.org>; Mon, 2 Dec 2019 22:34:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575322480; bh=2Kznb2MfaMHzkYxvZPx8Zt6RizMTgwPG1KP11Ib1fj4=; h=From:To:Subject:Date:From; b=FeTP6ozFXwij1uFkK2Z+dW1y9wS7VqBeRVLACQzq7ENGkpVues3CpQHomE6LiQEun u1Kdn1ppVK6JQSeoXLRr9axcG+Dc4Woz0S5bFd5wVQbEH0JXMqHF7Peta+D7iFl0C3 MxPgrRh9hDVOPTN/YByGnHYQefEEI/rFXWFgBWh+DZj+xSqhDXLqwewrpWu5xqz6Gj F19bRHYwEl6paVjoFggVz1//blAd3ujj6LubqmQ19QwVAG6IUbJ+kYabVagAxaY/0Y +OynpaTg0e00nTY8hDpaFBjgWLuHpQ0Zo5/4ddPdoURRVHGEzQ1RoZ6BX4KVGvS8fy gsdOEjsIhrZww== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47Rdg20nMpz9rxB for <38463@debbugs.gnu.org>; Mon, 2 Dec 2019 22:34:37 +0100 (CET) From: Brett Gilio Date: Mon, 02 Dec 2019 15:34:48 -0600 Message-ID: <87mucah0nb.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain -- Brett M. Gilio https://git.sr.ht/~brettgilio/ --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-emacs-telega-Use-test-suites.patch Content-Description: [PATCH 1/2] gnu: emacs-telega: Use test suites. >From 03a2617b29c92dc83828495305d73ec4074a5102 Mon Sep 17 00:00:00 2001 From: Brett Gilio Date: Mon, 2 Dec 2019 15:26:27 -0600 Subject: [PATCH 1/2] gnu: emacs-telega: Use test suites. * gnu/packages/emacs-xyz.scm (emacs-telega)[arguments]: Adds support for running the ert and server test suites. --- gnu/packages/emacs-xyz.scm | 39 +++++++++++++++++++++++++++++++++----- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 8efa4a17c8..ad78209ebb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -19974,7 +19974,7 @@ fish-completion. It can be used in both Eshell and M-x shell.") (file-name (git-file-name name version)))) (build-system gnu-build-system) (arguments - `(#:tests? #f + `(#:test-target "test" #:modules ((guix build gnu-build-system) ((guix build emacs-build-system) #:prefix emacs:) (guix build utils) @@ -19984,17 +19984,45 @@ fish-completion. It can be used in both Eshell and M-x shell.") (guix build emacs-utils)) #:phases (modify-phases %standard-phases - (add-after 'unpack 'unpack-patch + (add-after 'unpack 'prefix-patch (lambda _ (substitute* "server/Makefile" (("CC=cc") "CC=gcc") (("INSTALL_PREFIX=\\$\\(HOME\\)/.telega") (string-append "INSTALL_PREFIX=" (assoc-ref %outputs "out") - "/bin"))) + "/bin")) + ;; Manually invoke `run_tests.py` after install phase. + (("python3 run_tests.py") + "")) + #t)) + ;; The telega test suite checks for a version of Emacs + ;; compiled with imagemagick and svg support. Since we + ;; are using `emacs-minimal`, this step will fail. + ;; Grok the failing test, and remove problematic assertions. + (add-after 'unpack 'ert-suite-patch + (lambda _ + (substitute* "telega-core.el" + (("\\(image-type-available-p 'imagemagick\\) nil") + "t") + (("\\(image-type-available-p 'svg\\) nil") + "t")) + #t)) + ;; The server test suite has a hardcoded path. + ;; Reset this behavior to use the proper path. + (add-after 'unpack 'server-suite-patch + (lambda _ + (substitute* "server/run_tests.py" + (("~/.telega/telega-server") + (string-append (assoc-ref %outputs "out") + "/bin/telega-server"))) + #t)) + (add-after 'install 'run-server-suite + (lambda _ + (invoke "python3" "server/run_tests.py") #t)) (delete 'configure) - + ;; Build emacs-side using `emacs-build-system' (add-after 'compress-documentation 'emacs-add-source-to-load-path (assoc-ref emacs:%standard-phases 'add-source-to-load-path)) @@ -20008,7 +20036,8 @@ fish-completion. It can be used in both Eshell and M-x shell.") `(("emacs-visual-fill-column" ,emacs-visual-fill-column))) (native-inputs `(("tdlib" ,tdlib) - ("emacs" ,emacs-minimal))) + ("emacs" ,emacs-minimal) + ("python" ,python))) (synopsis "GNU Emacs client for the Telegram messenger") (description "Telega is full-featured, unofficial client for the Telegram messaging -- 2.24.0 --=-=-=-- From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 2/2] gnu: emacs-telega: Update to 0.4.4-2 References: <87r21mh0pt.fsf@posteo.net> In-Reply-To: <87r21mh0pt.fsf@posteo.net> Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2019 21:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.15753225004361 (code B ref 38463); Mon, 02 Dec 2019 21:35:02 +0000 Received: (at 38463) by debbugs.gnu.org; 2 Dec 2019 21:35:00 +0000 Received: from localhost ([127.0.0.1]:39059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtLQ-00018G-7p for submit@debbugs.gnu.org; Mon, 02 Dec 2019 16:35:00 -0500 Received: from mout02.posteo.de ([185.67.36.66]:43649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibtLO-000181-C3 for 38463@debbugs.gnu.org; Mon, 02 Dec 2019 16:34:58 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id AECB52400FF for <38463@debbugs.gnu.org>; Mon, 2 Dec 2019 22:34:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575322492; bh=cKmsSnkPMuvloN2uiogBHEkYJw8ziajdQon655/mgMk=; h=From:To:Subject:Date:From; b=HzKrZ3D91K/6cG+6K1eJ24W4BcrUFCsLDJfWyb3D2Wp+kAupBD498cIL5vb7qNTH/ o27J+vG6Jl4f6ZW9tCOtm5JJOQfhzdehkEBQL+Bsw3rG6QstDoeQD/nklIGfFNIQbS KytvdE6l2yvGVfbs/iQbpREns1C/NaUc4NHelN7wiB65FrlWF/7tV2fSO/cBOucEPH neC+QZSJY0Vv79e7ZVdmuB3BJYg6pUjmx1WndAK5Xr3VHqWKO9D/0eXIshcBs5AmEk uCU2goUlu2jnJT4HnnlzbgDzoTSQjrEFuKWJnk2Zi8jEu/URwzjS2ngc3SKcAkq7ns 95kTXxWkOs1jw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47RdgH5c3kz9rxM for <38463@debbugs.gnu.org>; Mon, 2 Dec 2019 22:34:51 +0100 (CET) From: Brett Gilio Date: Mon, 02 Dec 2019 15:35:02 -0600 Message-ID: <87immyh0mx.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain -- Brett M. Gilio https://git.sr.ht/~brettgilio/ --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0002-gnu-emacs-telega-Update-to-0.4.4-2.patch Content-Description: [PATCH 2/2] gnu: emacs-telega: Update to 0.4.4-2 >From 04e417466dcd7e1a39ce69d04b9afc60c41bd603 Mon Sep 17 00:00:00 2001 From: Brett Gilio Date: Mon, 2 Dec 2019 15:28:39 -0600 Subject: [PATCH 2/2] gnu: emacs-telega: Update to 0.4.4-2 * gnu/packages/emacs-xyz.scm (emacs-telega): Bump the package to use a newer git revision, which includes additional client features. --- gnu/packages/emacs-xyz.scm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index ad78209ebb..4fa5cafd8d 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -19956,8 +19956,8 @@ fish-completion. It can be used in both Eshell and M-x shell.") (license license:gpl3+)))) (define-public emacs-telega - (let ((commit "019e923f933370d75dbe0a8473a18eb66fe94c0e") - (revision "1") + (let ((commit "56aef884921d99e5170d5425dbe0fce645620511") + (revision "2") (version "0.4.4")) (package (name "emacs-telega") @@ -19970,7 +19970,7 @@ fish-completion. It can be used in both Eshell and M-x shell.") (commit commit))) (sha256 (base32 - "058814agkq8mp9ajpj8sz51rm9nigs2xpsdij05wjkxhfq30kqva")) + "0a8k3j20nz4xwswg9qp9xpaakk3q3ibiz8mkryk92zmrdmaah5mi")) (file-name (git-file-name name version)))) (build-system gnu-build-system) (arguments -- 2.24.0 --=-=-=-- From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH] Telega test suite and change in revision Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 00:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157550620914925 (code B ref 38463); Thu, 05 Dec 2019 00:37:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 00:36:49 +0000 Received: from localhost ([127.0.0.1]:42799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icf8S-0003sf-Vr for submit@debbugs.gnu.org; Wed, 04 Dec 2019 19:36:49 -0500 Received: from mout02.posteo.de ([185.67.36.66]:48973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icf8R-0003sO-Dy for 38463@debbugs.gnu.org; Wed, 04 Dec 2019 19:36:48 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 680A22400FE for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 01:36:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575506199; bh=G3NiG02hOuEs6rjWMwdtFXVGp3pv6Y1sV2SCUNCq4Wk=; h=From:To:Subject:Date:From; b=jQta5lCjbMbOZr/7k3+3L8AyZvsyjOL+pPN/nhUk3aungS0nHXd5uLsoBwTdSdYXY kt7Bf0DT5T0HMCzntr28By8hVsklNVDY/C4tXoRAAgg46bjuhWjjvA/clCgNFaWHh5 zFDMfl0Ns7gcCAqC4GqovfVyx15ft23LdX5SoAzQYJ3rAJPQt+pHPzlYqVRwYQTPN/ xCifioHBNJxN5NBS0hNIqSLnChbB2vJdbfydTQbzopuZLynW3lIt59gCI0c123ix0o l7r/0IU+kdKx32SARy4ayxK0Ecpq1JxjkJgo7BQS/t0GhfRe9WiHqEDGbOCa1e/szj L4OlziZBHMZ0Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47Sxc62bstz9rxB for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 01:36:38 +0100 (CET) From: Brett Gilio References: <87r21mh0pt.fsf@posteo.net> Date: Wed, 04 Dec 2019 18:36:35 -0600 In-Reply-To: <87r21mh0pt.fsf@posteo.net> (Brett Gilio's message of "Mon, 02 Dec 2019 15:33:18 -0600") Message-ID: <87k17b6224.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brett Gilio writes: > Hi all, the following patches modify the emacs-telega package to > carefully use the ert and server test suites it has, and also includes > an increase in the revision to use a newer commit. Let me know what > you think! Is there any critique of this patch? Sorry for pestering! -- Brett M. Gilio https://git.sr.ht/~brettgilio/ From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. References: <87r21mh0pt.fsf@posteo.net> In-Reply-To: <87r21mh0pt.fsf@posteo.net> Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157555387327243 (code B ref 38463); Thu, 05 Dec 2019 13:52:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 13:51:13 +0000 Received: from localhost ([127.0.0.1]:43371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icrXE-00075K-Mv for submit@debbugs.gnu.org; Thu, 05 Dec 2019 08:51:12 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icrXC-00074r-1V for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 08:51:11 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 908FB160061 for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 14:51:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575553863; bh=9iZPwl6LQqYqY3yqCgd/InaqLBl/SbbipYaDQAsfROg=; h=From:To:Subject:Date:From; b=Wo9har1iEkQhZdrFrWrMQEI9g1YBwJ0AAGfbV927Yxfe81Hye7ntloXlpyiVvGjJJ jOhbSRJJnBt0syEZVipmyicEgVttGLhFizQSysjSFxK7FGDC4AY6E/mZf5X8T8cUyl 40cAeyhjdKuuJtVRNiXWmzj+O78sIzaMdClJybgc3fCFSbWCT4mgGm9fNQLTGOufZ2 l6K1qrDRkXEcQykBUxyNrEc+/GortJVCrE7XoYogP9B2lzMHL0R31b2/i59sOGJur8 ygyX/Lc5wIGVcXbAsTRdeXw7pUsNz3oKem2RoU3Qvtl4xFpg+VNK2qCa0enmTv+e0k ImLYa1WPl27IQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47THDk0rb2z6tmP for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 14:51:01 +0100 (CET) From: Brett Gilio Date: Thu, 05 Dec 2019 07:50:54 -0600 Message-ID: <877e3ax4n5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/x-patch Content-Disposition: inline; filename=0003-gnu-emacs-telega-Properly-install-alists.patch Content-Description: [PATCH 3/3] gnu: emacs-telega: Properly install alists. X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >From 5b4430dce26b607cc0ebf443a33a3607a3b33eb1 Mon Sep 17 00:00:00 2001 From: Brett Gilio Date: Thu, 5 Dec 2019 07:48:30 -0600 Subject: [PATCH 3/3] gnu: emacs-telega: Properly install alists. * gnu/packages/emacs-xyz.scm (emacs-telega)[arguments]: Telega has an etc directory that needs to be installed to emacs site-lisp dir. This patch adds that functionality. --- gnu/packages/emacs-xyz.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 60d27ca3de..d5110e96da 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -20019,11 +20019,23 @@ fish-completion. It can be used in both Eshell and M-x shell.") ;; Build emacs-side using `emacs-build-system' (add-after 'compress-documentation 'emacs-add-source-to-load-path (assoc-ref emacs:%standard-phases 'add-source-to-load-path)) - (add-after 'emacs-set-emacs-load-path 'emacs-install + (add-after 'emacs-add-source-to-load-path 'emacs-install (assoc-ref emacs:%standard-phases 'install)) - (add-after 'emacs-install 'emacs-build + ;; This step adds subdir /etc to the site-lisp dir + ;; which is needed for images, notification sounds, + ;; and various alists. + ;; TODO: Replace with `#:include' method used by + ;; emacs-build-system. + (add-after 'emacs-install 'emacs-install-etc + (lambda* (#:key outputs #:allow-other-keys) + (with-directory-excursion "." + (invoke "cp" "-r" "etc/" + (string-append (assoc-ref outputs "out") + "/share/emacs/site-lisp/"))) + #t)) + (add-after 'emacs-install-etc 'emacs-build (assoc-ref emacs:%standard-phases 'build)) - (add-after 'emacs-install 'emacs-make-autoloads + (add-after 'emacs-build 'emacs-make-autoloads (assoc-ref emacs:%standard-phases 'make-autoloads))))) (propagated-inputs `(("emacs-visual-fill-column" ,emacs-visual-fill-column))) -- 2.24.0 From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. References: <87r21mh0pt.fsf@posteo.net> Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 17:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: brettg@posteo.net Cc: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157556709918048 (code B ref 38463); Thu, 05 Dec 2019 17:32:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 17:31:39 +0000 Received: from localhost ([127.0.0.1]:45128 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icuyZ-0004h1-2U for submit@debbugs.gnu.org; Thu, 05 Dec 2019 12:31:39 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:2053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icuyW-0004gq-PH for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 12:31:38 -0500 Received: from nijino.local (213-240-64-42.hdsl.highway.telekom.at [213.240.64.42]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 47TN78324tz3wl4; Thu, 5 Dec 2019 18:31:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1575567092; bh=GuxFhBHZlFovsm4nYoOHWSeCDnUlORRudhYPXZV8Fc0=; h=Subject:From:To:Cc:Date:In-Reply-To; b=HflRkMSrpj+jUw5r52vf5KYvcPdO/U5NAheFt8TQUcJM7Q/kyOBUK+5oBqXcTi2yQ mVRVm41Fv9cJSONYRRsPvdT37T/KuxwWLS7deysqpb8BGacWzfw14QXMv5V/Pcnj9W VLSewGPP3saiegBiMGbGP9d9OcybOGx4lzOsm74U= Message-ID: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 05 Dec 2019 18:31:26 +0100 In-Reply-To: 877e3ax4n5.fsf@posteo.net Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Brett, Am Donnerstag, den 05.12.2019, 07:48 -0600 schrieb Brett Gilio > * gnu/packages/emacs-xyz.scm (emacs-telega)[arguments]: Telega has an > etc > directory that needs to be installed to emacs site-lisp dir. This > patch adds > that functionality. Out of curiosity, would it be possible to make this a subfolder of the telega installation directory? It appears, as though these files are accessed via telega-etc-file in telega-util.el, so it should still function in the same way with the right substitutions. Regards, Leo From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 18:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157556884823554 (code B ref 38463); Thu, 05 Dec 2019 18:01:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 18:00:48 +0000 Received: from localhost ([127.0.0.1]:45149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvQl-00067a-OQ for submit@debbugs.gnu.org; Thu, 05 Dec 2019 13:00:47 -0500 Received: from mout01.posteo.de ([185.67.36.65]:52056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvQi-0005zM-KP for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 13:00:46 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8AE3D160061 for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 19:00:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575568835; bh=LIP23QzrYOiA53jQKCrl9Yb/vh3wsLnCEorG2ncsBgQ=; h=From:To:Cc:Subject:Date:From; b=BZGeJsSZ4PGlAopvlPB48apaZJyhBCQHLa8q29crq08t88OWrrEPFi6dM4KFfLELA 1q0xSNMSgrrLbnGUnGSNrSG/WH3/m2hgL1EXABvKa3Jzjr1y8bzTN8mbVo8pRog2jm v8DuEqN12D0Jdtv04v5DZep81xT/1T4sILsey+E01vfZh/apeU/ASwkkAK1cEyrq6V dT6hhWN9eDEnT3GX69lz2LeNqVjO6ggD4npX3bOYDpax2LE+t/117T5uBQ1+FetJFg FMnVhf8a7RNcUfdpk7nVoOcyXs2A2SbBUWhcewisxvABUwEogACQKEKuWBURH+TwAm sJRndKcEjjK1w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47TNmc3qMTz6tmQ; Thu, 5 Dec 2019 19:00:32 +0100 (CET) From: Brett Gilio References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> Date: Thu, 05 Dec 2019 12:00:28 -0600 In-Reply-To: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> (Leo Prikler's message of "Thu, 05 Dec 2019 18:31:26 +0100") Message-ID: <87fthyd54z.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Leo Prikler writes: > Out of curiosity, would it be possible to make this a subfolder of the > telega installation directory? It appears, as though these files are > accessed via telega-etc-file in telega-util.el, so it should still > function in the same way with the right substitutions. > > Regards, > Leo > Hi Leo, I want to make sure I understand clearly what you are saying. The telega installation directory seems to be just the /share/emacs/site-lisp. What subdirectory are you speaking of exactly? I will send a revised patch once I get some more information :). Thanks! -- Brett M. Gilio https://git.sr.ht/~brettgilio/ From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157556991930496 (code B ref 38463); Thu, 05 Dec 2019 18:19:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 18:18:39 +0000 Received: from localhost ([127.0.0.1]:45158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvi3-0007vo-IL for submit@debbugs.gnu.org; Thu, 05 Dec 2019 13:18:39 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:34610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvi1-0007vd-00 for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 13:18:38 -0500 Received: from nijino.local (213-240-64-42.hdsl.highway.telekom.at [213.240.64.42]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 47TP9N6Bgzz3wbj; Thu, 5 Dec 2019 19:18:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1575569913; bh=xlpmfucU9uf/SqgwK4D2LrKXHLLqwEAhHmvjq+oNYaw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Q+v4b0kFdi9HoGOiGjxK1xU+ZmiEdFy6oRyOpCZyTFlJeLfWYnbnvDjJEdMhPpRrS 0rY95qHNQtDkpe5f5uRYKbMnpgJNek9SaHgv73zxlIb80vX4tRTb6i7/h/aiY9hhei RDdSR3Ou1fmJNIBPnTDG0ZgHxVVdy7zb4AtsDy44= Message-ID: <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 05 Dec 2019 19:18:27 +0100 In-Reply-To: <87fthyd54z.fsf@posteo.net> References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> <87fthyd54z.fsf@posteo.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Donnerstag, den 05.12.2019, 12:00 -0600 schrieb Brett Gilio: > Leo Prikler writes: > > > Out of curiosity, would it be possible to make this a subfolder of > > the > > telega installation directory? It appears, as though these files > > are > > accessed via telega-etc-file in telega-util.el, so it should still > > function in the same way with the right substitutions. > > > > Regards, > > Leo > > > > Hi Leo, > > I want to make sure I understand clearly what you are saying. The > telega > installation directory seems to be just the > /share/emacs/site-lisp. What subdirectory are you speaking > of > exactly? I will send a revised patch once I get some more information > :). > > Thanks! Hi Brett, That's my bad, I haven't looked at the structure of share/emacs/site- lisp since the last change has been made. I expected, that packages still had their own folders, just with guix.d in the middle being removed, but just now found out that everything is at top-level. I still don't feel comfortable with data being at the top of site-lisp, though. Perhaps something similar to emacs-yasnippet-snippets, where you store the data in share/emacs/telega-data would be more appropriate. WDYT? Leo From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Cc: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.15755716391058 (code B ref 38463); Thu, 05 Dec 2019 18:48:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 18:47:19 +0000 Received: from localhost ([127.0.0.1]:45190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icw9m-0000Gw-VK for submit@debbugs.gnu.org; Thu, 05 Dec 2019 13:47:19 -0500 Received: from mout02.posteo.de ([185.67.36.66]:36895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icw9j-0000Gg-RP for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 13:47:17 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id EA113240108 for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 19:47:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575571628; bh=g65GQWSpdiOJu8cQ5Pw6D0dyQeW88k6woHw9cI11V/A=; h=From:To:Cc:Subject:Date:From; b=Hd874wuU03/X7HRa9i1XoO7B0BKhxwcMRQfRJtXHL+rz1jWzldkJlGx0d7sqFrvu4 h1TI3ykvFZVMoHCggxLkIrFOtmzqg2o1wZqQSMDgICpFOCSBM1EY7/OQSOXDrc3Tfe a2sW9JLYUlabZgB40yEx9hiN9VSX7LoZikNmEBtxsHm0o1Yub0a1qvRfUjA9lxpFD6 4UQgXDLu1FJZlncquEeRdOR9L5O5WNYTSywo+nQeLUvlimw/k7ACNY7UtZ6EIB+jYt 0ia/D0XIle7w3i2Lfq+779oodR7D2ZqqqhNSRckfuxPX/oxPzqKJmZxf9PvMt8B4NW df/8pgRz+Pz2g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47TPpL4rl0z9rxG; Thu, 5 Dec 2019 19:47:06 +0100 (CET) From: Brett Gilio References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> <87fthyd54z.fsf@posteo.net> <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> Date: Thu, 05 Dec 2019 12:46:55 -0600 In-Reply-To: <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> (Leo Prikler's message of "Thu, 05 Dec 2019 19:18:27 +0100") Message-ID: <877e3ad2zk.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Leo Prikler writes: > > Hi Brett, > > That's my bad, I haven't looked at the structure of share/emacs/site- > lisp since the last change has been made. I expected, that packages > still had their own folders, just with guix.d in the middle being > removed, but just now found out that everything is at top-level. I know how you feel. The recent changes has thrown me into a whirlpool of confusion. That is why I made the note about eventually replacing the installation of that directory to use the system usually used by `emacs-build-system` because I figure this would cause less issues in the future if for some reason the emacs site-lisp directory structure were to change again. --8<---------------cut here---------------start------------->8--- ;; TODO: Replace with `#:include' method used by ;; emacs-build-system. --8<---------------cut here---------------end--------------->8--- But I don't think it is a pressing issue to do it so cleanly. Or maybe it is. Idk. > I still don't feel comfortable with data being at the top of site-lisp, > though. Perhaps something similar to emacs-yasnippet-snippets, where > you store the data in share/emacs/telega-data would be more > appropriate. I was ACTUALLY going to do it this way originally, but I was really uncertain of it so I just sent the patch as is. I like the idea more, so I am going to revise the patch. Otherwise, once I get this revision in everything should be good to go. I'll also substitute the functions to reflect that changed path. While I am at it, I want to do a shameless plug for Evgeny Zajcev who has been supportive of me making additions to his repository to include instructions on installing `telega` from Guix, including a local-build `guix.scm`, adding a tag for Guix on the repo description, and adding an issue label for Guix as well. If any of you are reading this and use Telegram as a messaging client, join https://t.me/emacs_telega and give him (@zevlg) and I (@brettmg) a hello. The work he has been doing has been great, even though the build recipe for it for Guix is well over 100 LoC now. Ha. Alright, carry on! Patch will be available soon. -- Brett M. Gilio https://git.sr.ht/~brettgilio/ From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp. References: <87r21mh0pt.fsf@posteo.net> In-Reply-To: <87r21mh0pt.fsf@posteo.net> Resent-From: Brett Gilio Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157557609510074 (code B ref 38463); Thu, 05 Dec 2019 20:02:02 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 20:01:35 +0000 Received: from localhost ([127.0.0.1]:45242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icxJe-0002cQ-VQ for submit@debbugs.gnu.org; Thu, 05 Dec 2019 15:01:35 -0500 Received: from mout02.posteo.de ([185.67.36.66]:49525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icxJc-0002c3-Se for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 15:01:34 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id DC04A240110 for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 21:01:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575576085; bh=JlpCC0OBM9r0i7ANrhiGyrdGHapbRY6DwskRACpn1IU=; h=From:To:Subject:Date:From; b=mmsrxq5BXyVoPF0gLL7jfoGuUaJme5mtfIv/fSYJHYAZzUD9onRXqIuHHbzdICXWq bNmyA9K09wc0tDWJW3PTC+Zjbe9hygR45N5nqKH3Otfr92hDbz8Hms5JZ2TAs8QlYi FQo8lKTsR7hAmq7Aix+eaWybDeE4qK80aE2Sdxhwrne65aBxuPoAq2OTAJXxzYbG2+ B8FF02uTAqpt3e9KIFsSjFZn9ACWQG17uAMFq+yo/quflx0AQG8stXzaWDwFjySE8r A3VLYwk///l2wF/b3maGlHhqL6gWDF0B3ZgOG7wCohRPnOFvn//2MwtylCbsDQc2ln ECjyk+4MDpsvA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47TRS41vJZz9rxp for <38463@debbugs.gnu.org>; Thu, 5 Dec 2019 21:01:24 +0100 (CET) From: Brett Gilio Date: Thu, 05 Dec 2019 14:01:13 -0600 Message-ID: <87fthyzgmu.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain This patch is a reworked version of [PATCH 3/3] sent earlier in the list. Thanks to Leo Prikler who I have marked as a co-author for their help. Everything should be good to merge now! -- Brett M. Gilio https://git.sr.ht/~brettgilio/ --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch Content-Description: [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp. >From 62ad3f8a8a62fddc4e83cdbc43d2701dcd476224 Mon Sep 17 00:00:00 2001 From: Brett Gilio Date: Thu, 5 Dec 2019 13:51:14 -0600 Subject: [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp. * gnu/packages/emacs-xyz.scm (emacs-telega)[arguments]: This commit revises a previous patch and gives the source etc/ directory a unique installation pth in the site-lisp directory stucture. Co-authored-by: Leo Prikler --- gnu/packages/emacs-xyz.scm | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 60d27ca3de..1c0a5acc38 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -19989,6 +19989,13 @@ fish-completion. It can be used in both Eshell and M-x shell.") (("python3 run_tests.py") "")) #t)) + ;; Modify telega-util to reflect unique dir name in + ;; `telega-install-data' phase. + (add-after 'unpack 'telega-data-patch + (lambda _ + (substitute* "telega-util.el" + (("etc/") "telega-data/")) + #t)) ;; The telega test suite checks for a version of Emacs ;; compiled with imagemagick and svg support. Since we ;; are using `emacs-minimal`, this step will fail. @@ -20019,11 +20026,24 @@ fish-completion. It can be used in both Eshell and M-x shell.") ;; Build emacs-side using `emacs-build-system' (add-after 'compress-documentation 'emacs-add-source-to-load-path (assoc-ref emacs:%standard-phases 'add-source-to-load-path)) - (add-after 'emacs-set-emacs-load-path 'emacs-install + (add-after 'emacs-add-source-to-load-path 'emacs-install (assoc-ref emacs:%standard-phases 'install)) - (add-after 'emacs-install 'emacs-build + ;; This step adds subdir /etc to the site-lisp dir and + ;; gives it a unique name which is needed for images, + ;; notification sounds, and various alists. + ;; TODO: Replace with `#:include' method used by + ;; emacs-build-system. + (add-after 'emacs-install 'telega-install-data + (lambda* (#:key outputs #:allow-other-keys) + (with-directory-excursion "." + (invoke "cp" "-r" "etc/" + (string-append (assoc-ref outputs "out") + "/share/emacs/site-lisp/" + "telega-data/"))) + #t)) + (add-after 'telega-install-data 'emacs-build (assoc-ref emacs:%standard-phases 'build)) - (add-after 'emacs-install 'emacs-make-autoloads + (add-after 'emacs-build 'emacs-make-autoloads (assoc-ref emacs:%standard-phases 'make-autoloads))))) (propagated-inputs `(("emacs-visual-fill-column" ,emacs-visual-fill-column))) -- 2.24.0 --=-=-=-- From unknown Sun Aug 17 10:23:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Properly install alists. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 05 Dec 2019 22:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38463 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brett Gilio Cc: 38463@debbugs.gnu.org Received: via spool by 38463-submit@debbugs.gnu.org id=B38463.157558652311728 (code B ref 38463); Thu, 05 Dec 2019 22:56:01 +0000 Received: (at 38463) by debbugs.gnu.org; 5 Dec 2019 22:55:23 +0000 Received: from localhost ([127.0.0.1]:45389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1id01q-000335-M2 for submit@debbugs.gnu.org; Thu, 05 Dec 2019 17:55:23 -0500 Received: from mailrelay.tugraz.at ([129.27.2.202]:55515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1id01n-00032u-Vj for 38463@debbugs.gnu.org; Thu, 05 Dec 2019 17:55:21 -0500 Received: from nijino.local (213-240-64-42.hdsl.highway.telekom.at [213.240.64.42]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 47TWJg3RmMz3wV3; Thu, 5 Dec 2019 23:55:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1575586515; bh=CjiHpGY6b9cAbL/qBvd57N/xDGtXU1mW5tAzRSXMJu4=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=hbXf5uJW2zDyUQpK9seeWtn7uR/4llVTdWoMIZHTSHbbPPUA32h9ZaCNC8AMjGQyX rk8/YVCTELg9d61T4ImIhJyfoGWiHiw05YTldnLrNYlTyIvw/w1SBH3x2LR2ilOKGP fPIBYYv3MLPCKQhZw+soaRsJWstvQlnrb4pQJFyw= Message-ID: <24b5011d36a76fbb4a64e16d8eeaf540b4ba92df.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 05 Dec 2019 23:55:09 +0100 In-Reply-To: <877e3ad2zk.fsf@posteo.net> References: <3566e38523f0ff4badf50ade8c1498006f1cb872.camel@student.tugraz.at> <87fthyd54z.fsf@posteo.net> <3a8ad02f296ee82a82149e949ba7d5c367950df8.camel@student.tugraz.at> <877e3ad2zk.fsf@posteo.net> Content-Type: multipart/mixed; boundary="=-xqjyJqD25Y6ifULSgcBP" User-Agent: Evolution 3.30.5 MIME-Version: 1.0 X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-xqjyJqD25Y6ifULSgcBP Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Am Donnerstag, den 05.12.2019, 12:46 -0600 schrieb Brett Gilio: > That is why I made the note about eventually replacing the > installation of that directory to use the system usually used by > `emacs-build-system` because I figure this would cause less issues in > the future if for some reason the emacs site-lisp directory structure > were to change again. > > --8<---------------cut here---------------start------------->8--- > ;; TODO: Replace with `#:include' method used by > ;; emacs-build-system. > --8<---------------cut here---------------end--------------->8--- > > But I don't think it is a pressing issue to do it so cleanly. > Or maybe it is. Idk. Perhaps you're right, but as far as I can see the Emacs build system does not yet tell us how to proceed with data. It also has a unique way of handling documentation, first putting it into site-lisp before moving it to share/info where it should belong. > > I still don't feel comfortable with data being at the top of site- > > lisp, > > though. Perhaps something similar to emacs-yasnippet-snippets, > > where > > you store the data in share/emacs/telega-data would be more > > appropriate. > > I was ACTUALLY going to do it this way originally, but I was really > uncertain of it so I just sent the patch as is. I like the idea more, > so > I am going to revise the patch. Otherwise, once I get this revision > in > everything should be good to go. I'll also substitute the functions > to > reflect that changed path. > > [...] > > Alright, carry on! Patch will be available soon. Looking at your revised patch, I still feel a bit uneasy about putting data into the load-path. I therefore proprose a revised revised (R^2, if you will) patch, which I've attached to this message. Regards, Leo --=-xqjyJqD25Y6ifULSgcBP Content-Disposition: attachment; filename="0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch" Content-Type: text/x-patch; name="0003-gnu-emacs-telega-Install-telega-data-to-site-lisp.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSA1OTkxOGQ0YTQ4NmM0NTM0NjNlNmM1OTQ4NzA0NzE3N2YzYjU0MjA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmV0dCBHaWxpbyA8YnJldHRnQHBvc3Rlby5uZXQ+CkRhdGU6 IFRodSwgNSBEZWMgMjAxOSAxMzo1MToxNCAtMDYwMApTdWJqZWN0OiBbUEFUQ0ggMy8zXSBnbnU6 IGVtYWNzLXRlbGVnYTogSW5zdGFsbCB0ZWxlZ2EtZGF0YSB0byBzaXRlLWxpc3AuCgoqIGdudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtIChlbWFjcy10ZWxlZ2EpW2FyZ3VtZW50c106IFRoaXMgY29t bWl0IHJldmlzZXMgYQogIHByZXZpb3VzIHBhdGNoIGFuZCBnaXZlcyB0aGUgc291cmNlIGV0Yy8g ZGlyZWN0b3J5IGEgdW5pcXVlIGluc3RhbGxhdGlvbiBwdGgKICBpbiB0aGUgc2l0ZS1saXNwIGRp cmVjdG9yeSBzdHVjdHVyZS4KCkNvLWF1dGhvcmVkLWJ5OiBMZW8gUHJpa2xlciA8bGVvLnByaWts ZXJAc3R1ZGVudC50dWdyYXouYXQ+Ci0tLQogZ251L3BhY2thZ2VzL2VtYWNzLXh5ei5zY20gfCAy NSArKysrKysrKysrKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZW1hY3MteHl6 LnNjbSBiL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCmluZGV4IGY4ZjY1ZjBlN2UuLmM0YWE0 NGQ4ZDAgMTAwNjQ0Ci0tLSBhL2dudS9wYWNrYWdlcy9lbWFjcy14eXouc2NtCisrKyBiL2dudS9w YWNrYWdlcy9lbWFjcy14eXouc2NtCkBAIC0xOTk4OSw2ICsxOTk4OSwxNiBAQCBmaXNoLWNvbXBs ZXRpb24uICBJdCBjYW4gYmUgdXNlZCBpbiBib3RoIEVzaGVsbCBhbmQgTS14IHNoZWxsLiIpCiAg ICAgICAgICAgICAgICAgICgoInB5dGhvbjMgcnVuX3Rlc3RzLnB5IikKICAgICAgICAgICAgICAg ICAgICIiKSkKICAgICAgICAgICAgICAgICN0KSkKKyAgICAgICAgICAgOzsgTW9kaWZ5IHRlbGVn YS11dGlsIHRvIHJlZmxlY3QgdW5pcXVlIGRpciBuYW1lIGluCisgICAgICAgICAgIDs7IGB0ZWxl Z2EtaW5zdGFsbC1kYXRhJyBwaGFzZS4KKyAgICAgICAgICAgKGFkZC1hZnRlciAndW5wYWNrICd0 ZWxlZ2EtZGF0YS1wYXRjaAorICAgICAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgICAgICAg KHN1YnN0aXR1dGUqICJ0ZWxlZ2EtdXRpbC5lbCIKKyAgICAgICAgICAgICAgICAgKCgiXFwoY29u Y2F0IFwiZXRjL1wiIGZpbGVuYW1lXFwpIHRlbGVnYS0tbGliLWRpcmVjdG9yeSIpCisgICAgICAg ICAgICAgICAgICAiKGNvbmNhdCBcInRlbGVnYS1kYXRhL1wiIGZpbGVuYW1lKQorICAgICAgICAg ICAgICAgICAgICAobG9jYXRlLWRvbWluYXRpbmctZmlsZSB0ZWxlZ2EtLWxpYi1kaXJlY3RvcnkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXCJ0ZWxlZ2EtZGF0 YVwiKSIpKQorICAgICAgICAgICAgICAgI3QpKQogICAgICAgICAgICA7OyBUaGUgdGVsZWdhIHRl c3Qgc3VpdGUgY2hlY2tzIGZvciBhIHZlcnNpb24gb2YgRW1hY3MKICAgICAgICAgICAgOzsgY29t cGlsZWQgd2l0aCBpbWFnZW1hZ2ljayBhbmQgc3ZnIHN1cHBvcnQuIFNpbmNlIHdlCiAgICAgICAg ICAgIDs7IGFyZSB1c2luZyBgZW1hY3MtbWluaW1hbGAsIHRoaXMgc3RlcCB3aWxsIGZhaWwuCkBA IC0yMDAxOSwxMSArMjAwMjksMjAgQEAgZmlzaC1jb21wbGV0aW9uLiAgSXQgY2FuIGJlIHVzZWQg aW4gYm90aCBFc2hlbGwgYW5kIE0teCBzaGVsbC4iKQogICAgICAgICAgICA7OyBCdWlsZCBlbWFj cy1zaWRlIHVzaW5nIGBlbWFjcy1idWlsZC1zeXN0ZW0nCiAgICAgICAgICAgIChhZGQtYWZ0ZXIg J2NvbXByZXNzLWRvY3VtZW50YXRpb24gJ2VtYWNzLWFkZC1zb3VyY2UtdG8tbG9hZC1wYXRoCiAg ICAgICAgICAgICAgKGFzc29jLXJlZiBlbWFjczolc3RhbmRhcmQtcGhhc2VzICdhZGQtc291cmNl LXRvLWxvYWQtcGF0aCkpCi0gICAgICAgICAgIChhZGQtYWZ0ZXIgJ2VtYWNzLXNldC1lbWFjcy1s b2FkLXBhdGggJ2VtYWNzLWluc3RhbGwKKyAgICAgICAgICAgKGFkZC1hZnRlciAnZW1hY3MtYWRk LXNvdXJjZS10by1sb2FkLXBhdGggJ2VtYWNzLWluc3RhbGwKICAgICAgICAgICAgICAoYXNzb2Mt cmVmIGVtYWNzOiVzdGFuZGFyZC1waGFzZXMgJ2luc3RhbGwpKQotICAgICAgICAgICAoYWRkLWFm dGVyICdlbWFjcy1pbnN0YWxsICdlbWFjcy1idWlsZAorICAgICAgICAgICA7OyBUaGlzIHN0ZXAg aW5zdGFsbHMgc3ViZGlyIC9ldGMsIHdoaWNoIGNvbnRhaW5zIGltYWdlcywgc291bmRzIGFuZAor ICAgICAgICAgICA7OyB2YXJpb3VzIG90aGVyIGRhdGEsIG5leHQgdG8gdGhlIHNpdGUtbGlzcCBk aXIuCisgICAgICAgICAgIChhZGQtYWZ0ZXIgJ2VtYWNzLWluc3RhbGwgJ3RlbGVnYS1pbnN0YWxs LWRhdGEKKyAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyAjOmFsbG93LW90aGVy LWtleXMpCisgICAgICAgICAgICAgICAoY29weS1yZWN1cnNpdmVseQorICAgICAgICAgICAgICAg ICJldGMiCisgICAgICAgICAgICAgICAgKHN0cmluZy1hcHBlbmQgKGFzc29jLXJlZiBvdXRwdXRz ICJvdXQiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvc2hhcmUvZW1hY3MvdGVs ZWdhLWRhdGEvIikpCisgICAgICAgICAgICAgICAjdCkpCisgICAgICAgICAgIChhZGQtYWZ0ZXIg J3RlbGVnYS1pbnN0YWxsLWRhdGEgJ2VtYWNzLWJ1aWxkCiAgICAgICAgICAgICAgKGFzc29jLXJl ZiBlbWFjczolc3RhbmRhcmQtcGhhc2VzICdidWlsZCkpCi0gICAgICAgICAgIChhZGQtYWZ0ZXIg J2VtYWNzLWluc3RhbGwgJ2VtYWNzLW1ha2UtYXV0b2xvYWRzCisgICAgICAgICAgIChhZGQtYWZ0 ZXIgJ2VtYWNzLWJ1aWxkICdlbWFjcy1tYWtlLWF1dG9sb2FkcwogICAgICAgICAgICAgIChhc3Nv Yy1yZWYgZW1hY3M6JXN0YW5kYXJkLXBoYXNlcyAnbWFrZS1hdXRvbG9hZHMpKSkpKQogICAgICAg KHByb3BhZ2F0ZWQtaW5wdXRzCiAgICAgICAgYCgoImVtYWNzLXZpc3VhbC1maWxsLWNvbHVtbiIg LGVtYWNzLXZpc3VhbC1maWxsLWNvbHVtbikpKQotLSAKMi4yNC4wCgo= --=-xqjyJqD25Y6ifULSgcBP-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 23:31:54 2019 Received: (at control) by debbugs.gnu.org; 10 Dec 2019 04:31:54 +0000 Received: from localhost ([127.0.0.1]:54683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieXBi-0004L9-Am for submit@debbugs.gnu.org; Mon, 09 Dec 2019 23:31:54 -0500 Received: from mout02.posteo.de ([185.67.36.66]:54743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ieXBg-0004Ku-FG for control@debbugs.gnu.org; Mon, 09 Dec 2019 23:31:52 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 493B82400E6 for ; Tue, 10 Dec 2019 05:31:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1575952306; bh=Ai1sY6qHyteQANnz4kPneKoob8mHltx2Q0agUvbSyh4=; h=From:To:Subject:Date:From; b=R2dmXoTQImMF7VIdrsSLcgWtRhoVS7UzEawFUQ97hXy7Mp2j6bZQkWGjZ4YANCTeS KhKyn1H9aHDg6Fsr0EB1T4nu46gIPEVhONzo68VL+NkgVKms6vgIMw08nKE7xWofNl FiuMv8/YJcvv25Nupbo16mhF07OLwKYMSaeLl1n8UONN6wru6jT+JoPYVTknxLAJvI uiT+HzAwJb4Py9aLvh8kgq8CmFarVrVjIFA8mRewcGlZUptt7y7ejT4WQHDgxZ5c2R b3G9b+PQNDy7qtIvuJWGPxS/ddVO6vInLDX67j8WHexbo+89tbLwWpuFj++LpjVHeg wBPsiaDGatTlw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 47X6b52zhzz9rxH for ; Tue, 10 Dec 2019 05:31:45 +0100 (CET) From: Brett Gilio To: control@debbugs.gnu.org Subject: Re: [bug#38463] [PATCH 3/3] gnu: emacs-telega: Install telega-data to site-lisp. References: <87r21mh0pt.fsf@posteo.net> <87fthyzgmu.fsf@posteo.net> Date: Mon, 09 Dec 2019 22:31:44 -0600 In-Reply-To: <87fthyzgmu.fsf@posteo.net> (Brett Gilio's message of "Thu, 05 Dec 2019 14:01:13 -0600") Message-ID: <87h828n6mn.fsf@posteo.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 38463 thanks