GNU bug report logs - #38445
Guix CI evaluation broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38445 in the body.
You can then email your comments to 38445 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: bug-guix <at> gnu.org, ludo <at> gnu.org
Subject: Guix CI evaluation broken
Date: Sun, 01 Dec 2019 18:20:24 +0100

Hi,

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5

broke Guix CI.

The reason is:

    (local-file (string-append "" "../some-file"))

now differs from

    (local-file "../some-file")

And in gnu/system/install.scm (line 246) there's a STRING-APPEND.

We could probably do an easy fix by changing (string-append
"exemples/" ...) to (string-append "gnu/system/exemples/" ...) but
still, I find that new behaviour weird.

Clément

Message #8 received at 38445 <at> debbugs.gnu.org (full text, mbox):

From: Bengt Richter <bokr <at> bokr.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 38445 <at> debbugs.gnu.org, ludo <at> gnu.org
Subject: Re: bug#38445: Guix CI evaluation broken
Date: Sun, 1 Dec 2019 19:33:38 -0800

On +2019-12-01 18:20:24 +0100, Clément Lassieur wrote:
> Hi,
> 
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5
> 
> broke Guix CI.
> 
> The reason is:
> 
>     (local-file (string-append "" "../some-file"))
> 
> now differs from
> 
>     (local-file "../some-file")
> 
> And in gnu/system/install.scm (line 246) there's a STRING-APPEND.
> 
> We could probably do an easy fix by changing (string-append
┌──────────────────────────────────────────────────────────────────────┐
│               Would s/exemples/examples/g do any good?               │
├──────────────────────────────────────────────────────────────────────┤
│ > "exemples/" ...) to (string-append "gnu/system/exemples/" ...) but │
│ > still, I find that new behaviour weird.                            │
└──────────────────────────────────────────────────────────────────────┘
> 
> Clément
> 
> 
> 
-- 
Regards,
Bengt Richter

Message #11 received at 38445 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Bengt Richter <bokr <at> bokr.com>
Cc: 38445 <at> debbugs.gnu.org, ludo <at> gnu.org
Subject: Re: bug#38445: Guix CI evaluation broken
Date: Mon, 02 Dec 2019 10:04:20 +0100

Bengt Richter <bokr <at> bokr.com> writes:

> Would s/exemples/examples/g do any good?

Definitely.

Message #16 received at 38445-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Bengt Richter <bokr <at> bokr.com>
Cc: 38445-done <at> debbugs.gnu.org,
 Clément Lassieur <clement <at> lassieur.org>
Subject: Re: bug#38445: Guix CI evaluation broken
Date: Mon, 02 Dec 2019 10:24:40 +0100

Hi Clément & Bengt,

Bengt Richter <bokr <at> bokr.com> skribis:

> On +2019-12-01 18:20:24 +0100, Clément Lassieur wrote:
>> Hi,
>> 
>> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5
>> 
>> broke Guix CI.
>> 
>> The reason is:
>> 
>>     (local-file (string-append "" "../some-file"))
>> 
>> now differs from
>> 
>>     (local-file "../some-file")
>> 
>> And in gnu/system/install.scm (line 246) there's a STRING-APPEND.
>> 
>> We could probably do an easy fix by changing (string-append

Sorry for the breakage!  I noticed it yesterday and fixed it in
33d1c970c323971da8d70a662748c7b1b520d6b6.

Let me know if you think anything else is wrong!

Thanks,
Ludo’.

Message #19 received at 38445-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Ludovic Courtès <ludo <at> gnu.org>, guix-devel <at> gnu.org
Cc: 38445-done <at> debbugs.gnu.org
Subject: Re: bug#38445: Guix CI evaluation broken
Date: Mon, 02 Dec 2019 10:33:01 +0100

Hi Ludo,

Ludovic Courtès <ludo <at> gnu.org> writes:

> Sorry for the breakage!  I noticed it yesterday and fixed it in
> 33d1c970c323971da8d70a662748c7b1b520d6b6.
>
> Let me know if you think anything else is wrong!

I find the initial commit[1] counterintuitive and would have loved a
discussion before the fix.

I defy anyone to understand why commit 33d1c97[2] would fix anything.

Adding guix-devel.

Clément

[1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5
[2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=33d1c970c323971da8d70a662748c7b1b520d6b6

Message #22 received at 38445-done <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Ludovic Courtès <ludo <at> gnu.org>, guix-devel <at> gnu.org
Cc: 38445-done <at> debbugs.gnu.org
Subject: Re: bug#38445: Guix CI evaluation broken
Date: Mon, 02 Dec 2019 10:59:39 +0100

Sorry for my tone, it might sound harsh, it's not what I meant, I just
didn't have coffee yet ;)

Clément Lassieur <clement <at> lassieur.org> writes:

> Hi Ludo,
>
> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Sorry for the breakage!  I noticed it yesterday and fixed it in
>> 33d1c970c323971da8d70a662748c7b1b520d6b6.
>>
>> Let me know if you think anything else is wrong!
>
> I find the initial commit[1] counterintuitive and would have loved a
> discussion before the fix.
>
> I defy anyone to understand why commit 33d1c97[2] would fix anything.
>
> Adding guix-devel.
>
> Clément
>
> [1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=99c45877a984dd0148151b2e304afef6fb04f1a5
> [2]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=33d1c970c323971da8d70a662748c7b1b520d6b6

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.