GNU bug report logs - #38440
[PATCH 0/5] Add the `qt` build-system.

Previous Next

Full log

Message #23 received at 38440 <at> debbugs.gnu.org (full text, mbox):

From: Brett Gilio <brettg <at> posteo.net>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Cc: 38440 <at> debbugs.gnu.org
Subject: Re: [bug#38440] [PATCH 0/5] Add the `qt` build-system.
Date: Sat, 30 Nov 2019 16:15:30 -0600

Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:

> Works and is a good substitude for `wrap-program` from `qt-utils`. This
> `wrap-program` is still kept, since some packagins not using the
> cmake-build-syttem use it.
>
> Like `wrap-program`, this implementation has one deficit: The
> wrapper collects paths from *all* inputs, thus e.g. cmake will become a
> dependency of *every* binary packages using qt-build-system.
>
> But contraty to `wrap-program` this implementation does not use env-vars to
> build the paths, but inputs. Thus it will be easier to solve the issue by
> filtering inputs.
>
> Comments on the code are heardy welcome.
>
> Also see
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00386.html>
> <https://lists.gnu.org/archive/html/guix-devel/2019-11/msg00391.html>
>
> Hartmut Goebel (5):
>   guix: Add the 'qt' build system.
>   gnu: sddm: Use qt-build-system.
>   gnu: ktouch: Use qt-build-system.
>   gnu: kdeconnect: Use qt-build-system.
>   gnu: quaternion: Use qt-build-system.
>
>  Makefile.am                       |   2 +
>  doc/guix.texi                     |  21 ++-
>  gnu/packages/display-managers.scm |  18 +-
>  gnu/packages/education.scm        |  17 +-
>  gnu/packages/kde.scm              |  18 +-
>  gnu/packages/messaging.scm        |  17 +-
>  guix/build-system/qt.scm          | 295 ++++++++++++++++++++++++++++++
>  guix/build/qt-build-system.scm    | 109 +++++++++++
>  8 files changed, 440 insertions(+), 57 deletions(-)
>  create mode 100644 guix/build-system/qt.scm
>  create mode 100644 guix/build/qt-build-system.scm

Hartmut,

LGTM! Thanks for your work.

-- 
Brett M. Gilio
https://git.sr.ht/~brettgilio/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.