GNU bug report logs - #38408
[PATCH 0/3] (WIP) Semantic version aware recusive importer for crates

Previous Next

Package: guix-patches;

Reported by: Martin Becze <mjbecze <at> riseup.net>

Date: Thu, 28 Nov 2019 00:14:01 UTC

Severity: normal

Tags: patch

Merged with 44560, 44694

Fixed in version 44560

Done: Hartmut Goebel <h.goebel <at> crazy-compilers.com>

Bug is archived. No further changes may be made.

Full log


Message #337 received at 38408 <at> debbugs.gnu.org (full text, mbox):

From: Martin Becze <mjbecze <at> riseup.net>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 38408 <at> debbugs.gnu.org
Subject: Re: [PATCH v16 3/6] import: crate: Use guile-semver to resolve module
 versions.
Date: Tue, 17 Nov 2020 15:51:36 -0600
Hartmut, I just saw you v17 I think that is probably better then what I 
have attached.

On 11/17/20 3:43 PM, Martin Becze wrote:
> 
> 
> On 11/10/20 4:13 PM, Hartmut Goebel wrote:
>> Please add a brief change description for crate-recursive-import.
> 
> Done
> 
>>
> 
>> I could not spot this change. has this been reverted in one of the many
> 
>> version of this series?
> 
> 
> I added a better description in the attached commit.
> 
>> Does this still fetch the latest version? Or is it the latest version
> 
>> matching a semver range, or the latest non-beta version?
> 
> 
> The latest version including beta versions
> 
>> Is this change in the last line intended? Another patch of this series
> 
>> reverts this change.
> 
> No, nice catch. Changing this creates conflicts so I will update the 
> patch set.
> 
>> Does this still fetch the latest version? Or is it the latest version
> 
>> matching a semver range, or the latest non-beta version?
> 
> 
> I will add more advance tests in a separate commit at the end.
> 
> Attached is the updated patch set. I believe it address everything 
> brought up but please let me know if there is anything else. Thanks a 
> lot for looking at this.




This bug report was last modified 4 years and 161 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.