GNU bug report logs - #38408
[PATCH 0/3] (WIP) Semantic version aware recusive importer for crates

Previous Next

Full log

View this message in rfc822 format

From: Martin Becze <mjbecze <at> riseup.net>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 38408 <at> debbugs.gnu.org
Subject: [bug#38408] [PATCH v16 3/6] import: crate: Use guile-semver to resolve module versions.
Date: Tue, 17 Nov 2020 15:43:20 -0600

[Message part 1 (text/plain, inline)]

On 11/10/20 4:13 PM, Hartmut Goebel wrote:
> Please add a brief change description for crate-recursive-import.

Done

> 

> I could not spot this change. has this been reverted in one of the many

> version of this series?


I added a better description in the attached commit.

> Does this still fetch the latest version? Or is it the latest version

> matching a semver range, or the latest non-beta version?


The latest version including beta versions

> Is this change in the last line intended? Another patch of this series

> reverts this change.

No, nice catch. Changing this creates conflicts so I will update the 
patch set.

> Does this still fetch the latest version? Or is it the latest version

> matching a semver range, or the latest non-beta version?


I will add more advance tests in a separate commit at the end.

Attached is the updated patch set. I believe it address everything 
brought up but please let me know if there is anything else. Thanks a 
lot for looking at this.

[0007-test-Update-tests-to-cover-semver.patch (text/x-patch, attachment)]

[0006-import-crate-Parameterized-importing-of-dev-dependen.patch (text/x-patch, attachment)]

[0005-import-utils-Trim-patch-version-from-names.patch (text/x-patch, attachment)]

[0004-import-crate-Memorize-crate-guix-package.patch (text/x-patch, attachment)]

[0003-import-crate-Use-guile-semver-to-resolve-module-vers.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.