GNU bug report logs - #38402
[PATCH] Fix empty/incorrect GTK menus on HiDPI monitors with window scaling factor > 1

Previous Next

Package: emacs;

Reported by: Tobias Bading <tbading <at> web.de>

Date: Wed, 27 Nov 2019 16:00:02 UTC

Severity: normal

Tags: patch

Done: Tobias Bading <tbading <at> web.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38402 in the body.
You can then email your comments to 38402 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#38402; Package emacs. (Wed, 27 Nov 2019 16:00:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Tobias Bading <tbading <at> web.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 27 Nov 2019 16:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Bading <tbading <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix empty/incorrect GTK menus on HiDPI monitors with window
 scaling factor > 1
Date: Wed, 27 Nov 2019 16:59:39 +0100

[Message part 1 (text/plain, inline)]
This should fix Bug#31223, Bug#28106, Bug#23672 as well as Ubuntu bug
https://bugs.launchpad.net/ubuntu/+source/emacs25/+bug/1695228

Also fixes the formerly unscaled Y value returned by
frame-monitor-workarea (and display-monitor-attributes-list).

For details on why some GTK menus were empty please see thread
https://lists.gnu.org/archive/html/emacs-devel/2019-11/msg01061.html

* src/gtkutil.c
  (menubar_map_cb): properly scale req.height so that the menu bar's
  height is in device pixels as expected
  (xg_update_frame_menubar): dito
  (xg_event_is_for_menubar): properly scale rec.x and rec.y so that
  gtk_widget_intersect() works as intended
* src/xfns.c
  (Fx_display_monitor_attributes_list): properly scale work.x and work.y


[0001-Fix-empty-incorrect-GTK-menus-on-HiDPI-monitors.patch (text/x-patch, attachment)]
bug closed, send any further explanations to 38402 <at> debbugs.gnu.org and Tobias Bading <tbading <at> web.de> Request was from Tobias Bading <tbading <at> web.de> to control <at> debbugs.gnu.org. (Wed, 27 Nov 2019 16:23:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 26 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 171 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.