GNU bug report logs - #38400
[PATCH] gnu: feh: Adapt tests for imlib2 1.6.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38400: closed ([PATCH] gnu: feh: Adapt tests for imlib2 1.6.)
Date: Wed, 27 Nov 2019 23:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 28 Nov 2019 00:36:37 +0100
with message-id <87imn47uyi.fsf <at> devup.no>
and subject line Re: [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
has caused the debbugs.gnu.org bug report #38400,
regarding [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38400: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38400
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
Date: Wed, 27 Nov 2019 10:49:48 +0000

[Message part 3 (text/plain, inline)]

Hello Guix!

Since we updated imlib2 to version 1.6 the feh test suite was failing,
however it looks harmless. The output expectation just needs tweaking a
little.

I've reported it upstream https://github.com/derf/feh/issues/497 but in
the meantime, here's a patch for downstream! I don't think such a patch
is suitable upstream as it would mean the tests would fail on previous
versions of imlib2.

[0001-gnu-feh-Adapt-tests-for-imlib2-1.6.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

Thanks,
Pierre

[Message part 6 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: Pierre Langlois <pierre.langlois <at> gmx.com>, 38400-done <at> debbugs.gnu.org
Subject: Re: [bug#38400] [PATCH] gnu: feh: Adapt tests for imlib2 1.6.
Date: Thu, 28 Nov 2019 00:36:37 +0100

[Message part 7 (text/plain, inline)]

Pierre Langlois <pierre.langlois <at> gmx.com> writes:

> Hello Guix!
>
> Since we updated imlib2 to version 1.6 the feh test suite was failing,
> however it looks harmless. The output expectation just needs tweaking a
> little.
>
> I've reported it upstream https://github.com/derf/feh/issues/497 but in
> the meantime, here's a patch for downstream! I don't think such a patch
> is suitable upstream as it would mean the tests would fail on previous
> versions of imlib2.

Thanks!  Pushed in 9943d238e9f07dccae973b641eb7738637ce95fb.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.