GNU bug report logs - #38397
27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Subject: bug#38397: closed (Re: bug#38397: 27.0.50; [PATCH] vc-hg: log
 incoming/outgoing must call vc-setup-buffer)
Date: Wed, 27 Nov 2019 12:18:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38397 <at> debbugs.gnu.org.

-- 
38397: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38397
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>, 38397-done <at> debbugs.gnu.org
Subject: Re: bug#38397: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must
 call vc-setup-buffer
Date: Wed, 27 Nov 2019 14:17:39 +0200

On 27.11.2019 9:04, Andrii Kolomoiets wrote:
> 1. emacs -Q
> 2. 'C-x v d' and open hg repository directory
> 3. 'I' to open incoming log
> 4. 'g' to revert *vc-incoming* buffer
> 
> Output is added to buffer content instead of replacing it.
> Same with outgoing log.
> 
> vc-hg-log-incoming and vc-hg-log-outgoing must call vc-setup-buffer
> 
> * lisp/vc/vc-hg.el (vc-hg-log-incoming, vc-hg-log-outgoing): Call
>    vc-setup-buffer.

Thanks, installed (e7b4c248a6). But please send patches as attachments. 
I had to make all the changes my hand this time.

Also see the changes in the commit message.

[Message part 3 (message/rfc822, inline)]

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call
 vc-setup-buffer
Date: Wed, 27 Nov 2019 09:04:19 +0200

1. emacs -Q
2. 'C-x v d' and open hg repository directory
3. 'I' to open incoming log
4. 'g' to revert *vc-incoming* buffer

Output is added to buffer content instead of replacing it.
Same with outgoing log.

vc-hg-log-incoming and vc-hg-log-outgoing must call vc-setup-buffer

* lisp/vc/vc-hg.el (vc-hg-log-incoming, vc-hg-log-outgoing): Call
  vc-setup-buffer.

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 17d38fa400..5ff1a6204b 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -1378,10 +1378,12 @@ vc-hg-dir-extra-headers
      )))

(defun vc-hg-log-incoming (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "incoming" "-n" (unless (string= remote-location "")
                                                remote-location)))

(defun vc-hg-log-outgoing (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "outgoing" "-n" (unless (string= remote-location "")
                                                remote-location)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.