GNU bug report logs - #38397
27.0.50; [PATCH] vc-hg: log incoming/outgoing must call vc-setup-buffer

Previous Next

Package: emacs;

Reported by: Andrii Kolomoiets <andreyk.mad <at> gmail.com>

Date: Wed, 27 Nov 2019 07:05:02 UTC

Severity: normal

Tags: patch

Found in version 27.0.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] vc-hg: log incoming/outgoing must call
 vc-setup-buffer
Date: Wed, 27 Nov 2019 09:04:19 +0200
1. emacs -Q
2. 'C-x v d' and open hg repository directory
3. 'I' to open incoming log
4. 'g' to revert *vc-incoming* buffer

Output is added to buffer content instead of replacing it.
Same with outgoing log.

vc-hg-log-incoming and vc-hg-log-outgoing must call vc-setup-buffer

* lisp/vc/vc-hg.el (vc-hg-log-incoming, vc-hg-log-outgoing): Call
  vc-setup-buffer.

diff --git a/lisp/vc/vc-hg.el b/lisp/vc/vc-hg.el
index 17d38fa400..5ff1a6204b 100644
--- a/lisp/vc/vc-hg.el
+++ b/lisp/vc/vc-hg.el
@@ -1378,10 +1378,12 @@ vc-hg-dir-extra-headers
      )))

(defun vc-hg-log-incoming (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "incoming" "-n" (unless (string= remote-location "")
                                                remote-location)))

(defun vc-hg-log-outgoing (buffer remote-location)
+  (vc-setup-buffer buffer)
   (vc-hg-command buffer 1 nil "outgoing" "-n" (unless (string= remote-location "")
                                                remote-location)))



This bug report was last modified 5 years and 173 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.