From unknown Fri Aug 15 15:56:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#38395 <38395@debbugs.gnu.org> To: bug#38395 <38395@debbugs.gnu.org> Subject: Status: [PATCH] gnu: mumble: Update to 1.3.0. Reply-To: bug#38395 <38395@debbugs.gnu.org> Date: Fri, 15 Aug 2025 22:56:28 +0000 retitle 38395 [PATCH] gnu: mumble: Update to 1.3.0. reassign 38395 guix-patches submitter 38395 Ivan Vilata i Balaguer severity 38395 normal tag 38395 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 20:49:46 2019 Received: (at submit) by debbugs.gnu.org; 27 Nov 2019 01:49:46 +0000 Received: from localhost ([127.0.0.1]:53243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZmSZ-0007Zm-4t for submit@debbugs.gnu.org; Tue, 26 Nov 2019 20:49:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:43661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZmST-0007ZY-3i for submit@debbugs.gnu.org; Tue, 26 Nov 2019 20:49:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49408) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZmSQ-0003jj-Ud for guix-patches@gnu.org; Tue, 26 Nov 2019 20:49:32 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZmKr-0005gL-Gg for guix-patches@gnu.org; Tue, 26 Nov 2019 20:41:43 -0500 Received: from lev.selidor.net ([66.246.138.156]:48293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZmKr-0005fn-Ap for guix-patches@gnu.org; Tue, 26 Nov 2019 20:41:41 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:dccb:8091:c691:2577]) by lev.selidor.net (Postfix) with ESMTP id BD6E5C83E; Wed, 27 Nov 2019 01:41:39 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id C7E969A00C7; Tue, 26 Nov 2019 20:40:38 -0500 (EST) Date: Tue, 26 Nov 2019 20:40:38 -0500 From: Ivan Vilata i Balaguer To: guix-patches@gnu.org Subject: [PATCH] gnu: mumble: Update to 1.3.0. Message-ID: <20191127014038.GD17004@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IU5/I01NYhRvwH70" Content-Disposition: inline User-Agent: Mutt/1.12.2 (2019-09-21) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 66.246.138.156 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --IU5/I01NYhRvwH70 Content-Type: multipart/mixed; boundary="ZJcv+A0YCCLh2VIg" Content-Disposition: inline --ZJcv+A0YCCLh2VIg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! This patch updates Mumble to 1.3.0. It came about as a fix to , but I'm posting it here directly since fixing that issue was just a byproduct of the version update. Notes from the patch comment indicating other differences with the previous package version: > Besides the update in itself, bundled software components are enabled as > long as they are not already implemented in an existing package (in which > case the package is used instead). Some comments were added to indicate = why > bundled software components are kept or removed, why features are disable= d, > and the reason to include each license. Cheers! --=20 Ivan Vilata i Balaguer -- https://elvil.net/ --ZJcv+A0YCCLh2VIg Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-mumble-Update-to-1.3.0.patch" Content-Transfer-Encoding: quoted-printable =46rom 987f03ca1721c1aa54a078a9be143abbac82bf11 Mon Sep 17 00:00:00 2001 =46rom: Ivan Vilata-i-Balaguer Date: Fri, 22 Nov 2019 01:15:53 -0500 Subject: [PATCH] gnu: mumble: Update to 1.3.0. Besides the update in itself, bundled software components are enabled as lo= ng as they are not already implemented in an existing package (in which case t= he package is used instead). Some comments were added to indicate why bundled software components are kept or removed, why features are disabled, and the reason to include each license. * gnu/packages/telephony.scm (mumble): Update to 1.3.0. * gnu/packages/patches/mumble-1.2.19-abs.patch: Remove file. --- gnu/packages/patches/mumble-1.2.19-abs.patch | 31 ----- gnu/packages/telephony.scm | 114 ++++++++++++------- 2 files changed, 70 insertions(+), 75 deletions(-) delete mode 100644 gnu/packages/patches/mumble-1.2.19-abs.patch diff --git a/gnu/packages/patches/mumble-1.2.19-abs.patch b/gnu/packages/pa= tches/mumble-1.2.19-abs.patch deleted file mode 100644 index 683325f4bc..0000000000 --- a/gnu/packages/patches/mumble-1.2.19-abs.patch +++ /dev/null @@ -1,31 +0,0 @@ -From ea861fe86743c8402bbad77d8d1dd9de8dce447e Mon Sep 17 00:00:00 2001 -From: Mikkel Krautz -Date: Fri, 29 Dec 2017 14:47:25 +0100 -Subject: [PATCH] AudioOutput: do not use non-existant template version of - std::abs. - -This change fixes AudioOutput to use the float overload of std::abs: - - float std::abs(float); - -instead of a non-existant template version (for newer Boost 1.66). - -Fixes mumble-voip/mumble#3281 - ---- - src/mumble/AudioOutput.cpp | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/mumble/AudioOutput.cpp b/src/mumble/AudioOutput.cpp -index cbe0c0e2b..7a0a5e2ab 100644 ---- a/src/mumble/AudioOutput.cpp -+++ b/src/mumble/AudioOutput.cpp -@@ -437,7 +437,7 @@ bool AudioOutput::mix(void *outbuff, unsigned int nsam= p) { - top[2] =3D 0.0f; - } -=20 -- if (std::abs(front[0] * top[0] + front[1] * top[1] + front[2] = * top[2]) > 0.01f) { -+ if (std::abs(front[0] * top[0] + front[1] * top[1] + front[2] * top[2= ]) > 0.01f) { - // Not perpendicular. Assume Y up and rotate 90 degrees. -=20 - float azimuth =3D 0.0f; diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index abb68f62b2..e1ad2f90f5 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -12,6 +12,7 @@ ;;; Copyright =A9 2018 Jovany Leandro G.C ;;; Copyright =A9 2018 Tim Gesthuizen ;;; Copyright =A9 2019 Pierre Neidhardt +;;; Copyright =A9 2019 Ivan Vilata i Balaguer ;;; ;;; This file is part of GNU Guix. ;;; @@ -43,6 +44,7 @@ #:use-module (gnu packages file) #:use-module (gnu packages protobuf) #:use-module (gnu packages gettext) + #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gnupg) @@ -378,30 +380,34 @@ address of one of the participants.") (define-public mumble (package (name "mumble") - (version "1.2.19") + (version "1.3.0") (source (origin (method url-fetch) (uri (string-append "https://mumble.info/snapshot/" name "-" version ".tar.gz")) (sha256 (base32 - "1s60vaici3v034jzzi20x23hsj6mkjlc0glipjq4hffrg9qgnizh")) - (patches (search-patches "mumble-1.2.19-abs.patch")) + "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs")) (modules '((guix build utils))) (snippet `(begin ;; Remove bundled software. - (for-each delete-file-recursively '("3rdparty" - "speex" - "speexbuild" - "opus-build" - "opus-src" - "sbcelt-helper-build" - "sbcelt-lib-build" - "sbcelt-src")) - ;; TODO: Celt is still bundled. It has been merged into = Opus - ;; and will be removed after 1.3.0. - ;; https://github.com/mumble-voip/mumble/issues/1999 + ;; Keep arc4random, celt-0.7.0, celt-0.11.0, qqbonjour, = rnnoise, smallft. + (for-each delete-file-recursively '("3rdparty/GL" ; in m= esa + "3rdparty/mach-overr= ide-build" ; for macx + "3rdparty/mach-overr= ide-src" + "3rdparty/minhook-bu= ild" ; for win32 + "3rdparty/minhook-sr= c" + "3rdparty/opus-build= " ; in opus + "3rdparty/opus-src" + "3rdparty/sbcelt-hel= per-build" ; not enabled + "3rdparty/sbcelt-lib= -build" + "3rdparty/sbcelt-src" + "3rdparty/speex-buil= d" ; in speex + "3rdparty/speex-src" + "3rdparty/speexdsp-s= rc" ; in speexdsp + "3rdparty/xinputchec= k-build" ; for win32 + "3rdparty/xinputchec= k-src")) #t)))) (build-system gnu-build-system) (arguments @@ -409,23 +415,25 @@ address of one of the participants.") #:phases (modify-phases %standard-phases (replace 'configure - (lambda* (#:key outputs #:allow-other-keys) - (invoke "qmake" "main.pro" "-recursive" + (lambda* (#:key inputs outputs #:allow-other-keys) + (invoke "qmake" "main.pro" "QMAKE_LRELEASE=3Dlrelease" + (string-append "MUMBLE_PYTHON=3D" + (string-append (assoc-ref inputs "pyth= on") "/bin/python3")) (string-append "CONFIG+=3D" (string-join - (list "no-update" - "no-ice" + ;; Options used are listed in the sam= e order + ;; as in the "INSTALL" file + ;; (plus the final "packaged" and "re= lease"). + (list "no-bundled-speex" ; in speex + "no-bundled-opus" ; in opus + "no-g15" ; not packaged + "no-jackaudio" ; use pulse + "no-oss" ; use pulse + "no-alsa" ; use pulse + "no-update" "no-embed-qt-translations" - "no-bundled-speex" - "pch" - "no-bundled-opus" - "no-celt" - "no-alsa" - "no-oss" - "no-portaudio" - "speechd" - "no-g15" - "no-bonjour" + "no-ice" ; not packaged + "packaged" "release"))) (string-append "DEFINES+=3D" "PLUGIN_PATH=3D" @@ -435,6 +443,10 @@ address of one of the participants.") (lambda _ (substitute* "src/mumble/TextToSpeech_unix.cpp" (("libspeechd.h") "speech-dispatcher/libspeechd.h")))) + (add-before 'install 'disable-murmur-ice + (lambda _ + (substitute* "scripts/murmur.ini.system" + (("^ice=3D") ";ice=3D")))) (replace 'install ; install phase does not exist (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -462,24 +474,38 @@ address of one of the participants.") (for-each (lambda (file) (install-file file lib)) (find-files "." "\\.so\\.")) (for-each (lambda (file) (install-file file lib)) - (find-files "release/plugins" "\\.so$")))))))) + (find-files "release/plugins" "\\.so$"))))) + (add-after 'install 'wrap-executable + ;; Add path to plugins for SVG support (otherwise many icons ar= e not shown). + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each (lambda (program) + (wrap-program (string-append out "/bin/" progra= m) + `("QT_PLUGIN_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs la= bel) + "/lib/qt5/plugins")) + '("qtbase" "qtsvg"))))) + '("mumble" "mumble-overlay")))))))) (inputs `(("avahi" ,avahi) - ("protobuf" ,protobuf-3.5) - ("openssl" ,openssl) - ("libsndfile" ,libsndfile) ("boost" ,boost) - ("opus" ,opus) - ("speex" ,speex) - ("speexdsp" ,speexdsp) - ("speech-dispatcher" ,speech-dispatcher) - ("libx11" ,libx11) + ("libsndfile" ,libsndfile) ("libxi" ,libxi) - ("qt-4" ,qt-4) - ("alsa-lib" ,alsa-lib) - ("pulseaudio" ,pulseaudio))) + ("mesa" ,mesa) ; avoid bundled + ("openssl" ,openssl) + ("opus" ,opus) ; avoid bundled + ("protobuf" ,protobuf) + ("pulseaudio" ,pulseaudio) + ("qtbase" ,qtbase) + ("qtsvg" ,qtsvg) + ("speech-dispatcher" ,speech-dispatcher) + ("speex" ,speex) ; avoid bundled + ("speexdsp" ,speexdsp))) ; avoid bundled (native-inputs - `(("pkg-config" ,pkg-config))) + `(("pkg-config" ,pkg-config) + ("python" ,python) + ("qttools" ,qttools))) (synopsis "Low-latency, high quality voice chat software") (description "Mumble is an low-latency, high quality voice chat @@ -487,9 +513,9 @@ software primarily intended for use while gaming. Mumble consists of two applications for separate usage: @code{mumble} for the client, and @code{murmur} for the server.") (home-page "https://wiki.mumble.info/wiki/Main_Page") - (license (list license:bsd-3 - ;; The bundled celt is bsd-2. Remove after 1.3.0. - license:bsd-2)))) + (license (list license:bsd-3 ; mumble celt-0.7.0 qqbonjour rnnoise sma= llft + license:bsd-2 ; celt-0.11.0 + license:isc)))) ; arc4random =20 (define-public twinkle (package --=20 2.24.0 --ZJcv+A0YCCLh2VIg-- --IU5/I01NYhRvwH70 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEHpvwBPZcchIQr6TuPezBBfXdI4IFAl3d1BIACgkQPezBBfXd I4LNvg//QFyyixO0fj/BPv3zmym1Cb4h9/jaHHTYs488nO90jD9fEQP4WWaYNk/0 p/JLamF+Cp+nQOvvSunDDlEZYDVHHAJyWE7yCtCbVwz+CsEr+dYgpUgQ1jJOju/Z l+z4k4CTRJ6pyCanIr/l30RN0xgVIek+eF+0d31o7CUmsa844br5obOOmZ/abu1e wkqp0/BOEAKDaMfg1NiCiQD8S2hbTleJtmOcFMsPwULVgZl5th3CZuBxkA4GqwRo rPlpmXsMsY8CQdvDnFLRgMFNJ+jRUoluSFGJt+jK3B9UL8TOCWgGFMS/hWqFJaiR VVDKPwiUV9iHMgPgOCpXLQQsUZxeZ69P9e7XC1u5sxc+yrYQ/A1luTz6rEmIdxQa uSKykYfcTCyBaTjKFR36N/Mkk/8w+ZfZfiX/uds5+L/r/HU5l8HriB0Baz6GAkyj DYmkjZdlL3dyYv+rdSXudPDz+RolllLlXWIxDO8nka2REM3rJ3OieS6WXpVNCDCH rUdTObCiE9Ko3xYCkkyMsSewG+ppKkdi/6G4HtgJYM57XUFE0VhKSsm5Af4+3ry3 PHxFA2dBrZwFC/b1YauglhP4TNODj9UeSHVkgZNHN+nPLS6O8EDajnxFH+DFKu5I cKn3y01DSsVRWQbRq9/zI5CnntFRtPhM3MuZuSyj/epYF0Y4Cjo= =NCMe -----END PGP SIGNATURE----- --IU5/I01NYhRvwH70-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 15:18:23 2019 Received: (at 38395) by debbugs.gnu.org; 4 Dec 2019 20:18:23 +0000 Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icb6M-0003N4-SV for submit@debbugs.gnu.org; Wed, 04 Dec 2019 15:18:23 -0500 Received: from lev.selidor.net ([66.246.138.156]:59785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icb6K-0003Mw-6k for 38395@debbugs.gnu.org; Wed, 04 Dec 2019 15:18:20 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:fcc2:3bce:3e59:f23d]) by lev.selidor.net (Postfix) with ESMTP id 9DBE8C830; Wed, 4 Dec 2019 20:18:19 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 1F6AA9A00BE; Wed, 4 Dec 2019 15:17:18 -0500 (EST) Date: Wed, 4 Dec 2019 15:17:18 -0500 From: Ivan Vilata i Balaguer To: 38395@debbugs.gnu.org Subject: Re: bug#38395: Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191204201718.GA17141@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Is there anything still missing in the patch that I could work on for it to get merged? Thanks! -- Ivan Vilata i Balaguer -- https://elvil.net/ From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 04 18:24:29 2019 Received: (at submit) by debbugs.gnu.org; 4 Dec 2019 23:24:29 +0000 Received: from localhost ([127.0.0.1]:42784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ice0S-0001vN-RV for submit@debbugs.gnu.org; Wed, 04 Dec 2019 18:24:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:34050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ice0Q-0001vD-S9 for submit@debbugs.gnu.org; Wed, 04 Dec 2019 18:24:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41874) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ice0P-00014o-Sm for guix-patches@gnu.org; Wed, 04 Dec 2019 18:24:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ice0O-0004cs-SY for guix-patches@gnu.org; Wed, 04 Dec 2019 18:24:25 -0500 Received: from dustycloud.org ([2600:3c02::f03c:91ff:feae:cb51]:41326) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ice0O-0004QW-8D for guix-patches@gnu.org; Wed, 04 Dec 2019 18:24:24 -0500 Received: from twig (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 1AB932661E; Wed, 4 Dec 2019 18:24:17 -0500 (EST) References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> User-agent: mu4e 1.2.0; emacs 26.3 From: Christopher Lemmer Webber To: guix-patches@gnu.org Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) In-reply-to: <20191204201718.GA17141@sax.terramar.selidor.net> Date: Wed, 04 Dec 2019 18:24:16 -0500 Message-ID: <87a787y8rj.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c02::f03c:91ff:feae:cb51 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 38395@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ivan Vilata i Balaguer writes: > Is there anything still missing in the patch that I could work on for it to > get merged? Thanks! Hi! I tried getting it to run but I ran into errors compiling it. But then I didn't get around to posting what they were to the list and something else came up and I don't remember what they were. :\ I can see if I can find time to look again soon but I can't promise anything. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 05 04:03:19 2019 Received: (at 38395) by debbugs.gnu.org; 5 Dec 2019 09:03:19 +0000 Received: from localhost ([127.0.0.1]:42977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icn2d-0004pc-6x for submit@debbugs.gnu.org; Thu, 05 Dec 2019 04:03:19 -0500 Received: from flashner.co.il ([178.62.234.194]:42382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icn2Y-0004oh-8Y for 38395@debbugs.gnu.org; Thu, 05 Dec 2019 04:03:17 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id C354B402CA; Thu, 5 Dec 2019 09:03:07 +0000 (UTC) Date: Thu, 5 Dec 2019 11:02:36 +0200 From: Efraim Flashner To: Ivan Vilata i Balaguer Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191205090236.GQ15280@E5400> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jigfid2yHjNFZUTO" Content-Disposition: inline In-Reply-To: <20191204201718.GA17141@sax.terramar.selidor.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote: > Is there anything still missing in the patch that I could work on for it to > get merged? Thanks! > With the 'staging' branch being merged into master the patch no longer cleanly applies. Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: local.mk] 1.0 PDS_BTC_MSGID Bitcoin ID with T_MSGID_NOFQDN2 0.5 PDS_BTC_ID FP reduced Bitcoin ID X-Debbugs-Envelope-To: 38395 Cc: 38395@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --jigfid2yHjNFZUTO Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote: > Is there anything still missing in the patch that I could work on for it = to > get merged? Thanks! >=20 With the 'staging' branch being merged into master the patch no longer cleanly applies. Also, since you've removed a patch from the gnu/packages/patches folder you need to remove it also from gnu/local.mk. The two other things are the commit message doesn't list all of the changes and with the new qt-build-system that would probably be a better choice than wrapping the binaries yourself, but with an updated patch without that I can help work on that since it is such a new change. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --jigfid2yHjNFZUTO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3ox6kACgkQQarn3Mo9 g1FfJQ/+Jy4pZwyjl+rsRfO/uUL3jCRdb9dt8FccCvgMWyqkshsOyFkAPgSDzVal jeiQ/7Lp/+iEAp5myeE+z5T7OcVk3TdkjZVpkegMul7Q5vIB5gqVRne2g/hHd8/Q Yv5BOAcd9mKBAIuY/Wn140FunyIVprj87NGTQW6Du6gLapftkfzkvEvBgAI7uxSt ZNiVD1jN1HynMfW79Yp/QOPGT5y49Q5qRnorgTwHVj2l2SV1LoiBqVFO7XiP40BN u28aj5Y9pzaugIWkkj4r1mpmDUvGQHtmoEyDlio62n2/iQF/2Vu/X4L0FeyiEj6p 5ZhvjrowYA8GyFnYFQ/CimNUSXWVWUl2fRHgBsiWGlIAccWhVtiUREYqHhjpTaHd vdIYFPK5a/33aXcv2TFm9ZkXbZ09cCQ25Gj1fXEB+uzFzGWYTmYQVuiNdxrhWZnv lyKwq+Q5xQK9d+nrRDZ8sui9CG2P8SwISloypY6idlcqseqsTgHLL64aUb07ngcH m3rjwKfqcHbwW42oqMj7Uc48p1QMaNpYoeNOmjzrHomX6/ObI22wJ9B+e/XdDgDA rRpGSKJ3oCzeH3PHsITViofh9DPhrxxD7QuOWVsewzc5kMfS8ifiJNcTWr5u+Bia Z0oloxgNLx6eXq6Ntr4PEOolKaq4h6wJnxVv0l9ECzlsDFwKm1E= =aC5F -----END PGP SIGNATURE----- --jigfid2yHjNFZUTO-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 06 13:29:33 2019 Received: (at 38395) by debbugs.gnu.org; 6 Dec 2019 18:29:33 +0000 Received: from localhost ([127.0.0.1]:47049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIM9-0005bW-8b for submit@debbugs.gnu.org; Fri, 06 Dec 2019 13:29:33 -0500 Received: from lev.selidor.net ([66.246.138.156]:40471) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idIM5-0005bL-6D for 38395@debbugs.gnu.org; Fri, 06 Dec 2019 13:29:32 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:8536:fc75:e15c:1671]) by lev.selidor.net (Postfix) with ESMTP id A28E1C89C; Fri, 6 Dec 2019 18:29:28 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 6CF6C9A3791; Fri, 6 Dec 2019 13:28:26 -0500 (EST) Date: Fri, 6 Dec 2019 13:28:26 -0500 From: Ivan Vilata i Balaguer To: Efraim Flashner Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191206182826.GD17141@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191205090236.GQ15280@E5400> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395 Cc: 38395@debbugs.gnu.org, Ivan Vilata i Balaguer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner (2019-12-05 11:02:36 +0200) wrote: > On Wed, Dec 04, 2019 at 03:17:18PM -0500, Ivan Vilata i Balaguer wrote: > > Is there anything still missing in the patch that I could work on for it to > > get merged? Thanks! > > > > With the 'staging' branch being merged into master the patch no longer > cleanly applies. > > Also, since you've removed a patch from the gnu/packages/patches folder > you need to remove it also from gnu/local.mk. The two other things are > the commit message doesn't list all of the changes and with the new > qt-build-system that would probably be a better choice than wrapping the > binaries yourself, but with an updated patch without that I can help > work on that since it is such a new change. Thanks Efraim for the info! I don't think I'll have time to work on this during the next week, but I'll try again ASAP and get back to you. Cheers, -- Ivan Vilata i Balaguer -- https://elvil.net/ From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 15 20:45:30 2019 Received: (at 38395) by debbugs.gnu.org; 16 Dec 2019 01:45:30 +0000 Received: from localhost ([127.0.0.1]:37547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igfRp-0005Yr-Nu for submit@debbugs.gnu.org; Sun, 15 Dec 2019 20:45:30 -0500 Received: from lev.selidor.net ([66.246.138.156]:41763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igfRl-0005Ye-9Q for 38395@debbugs.gnu.org; Sun, 15 Dec 2019 20:45:20 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:8536:fc75:e15c:1671]) by lev.selidor.net (Postfix) with ESMTP id 1A10AC82F; Mon, 16 Dec 2019 01:45:16 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 42B1D9A3791; Sun, 15 Dec 2019 20:44:11 -0500 (EST) Date: Sun, 15 Dec 2019 20:44:11 -0500 From: Ivan Vilata i Balaguer To: Efraim Flashner Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191216014411.GC1392584@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Km1U/tdNT/EmXiR1" Content-Disposition: inline In-Reply-To: <20191205090236.GQ15280@E5400> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395 Cc: 38395@debbugs.gnu.org, Ivan Vilata i Balaguer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Km1U/tdNT/EmXiR1 Content-Type: multipart/mixed; boundary="qjNfmADvan18RZcF" Content-Disposition: inline --qjNfmADvan18RZcF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Efraim Flashner (2019-12-05 11:02:36 +0200) wrote: > With the 'staging' branch being merged into master the patch no longer > cleanly applies. >=20 > Also, since you've removed a patch from the gnu/packages/patches folder > you need to remove it also from gnu/local.mk. The two other things are > the commit message doesn't list all of the changes and with the new > qt-build-system that would probably be a better choice than wrapping the > binaries yourself, but with an updated patch without that I can help > work on that since it is such a new change. Hi! I'm attaching a reviewed set of patches. The first patch updates the original one to fix the copyright line (so it applies cleanly again), the `local.mk` line removal and commit message completeness. The second patch adds the update to `qt-build-system`. From the comments in `guix/build-system/qt.scm` I gather that no other changes are missing, but I may be wrong. Thanks! --=20 Ivan Vilata i Balaguer -- https://elvil.net/ --qjNfmADvan18RZcF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: attachment; filename="0001-gnu-mumble-Update-to-1.3.0.patch" Content-Transfer-Encoding: quoted-printable =46rom aea8a70894c170d3c825c26d25f83b3ef05f2820 Mon Sep 17 00:00:00 2001 =46rom: Ivan Vilata-i-Balaguer Date: Sun, 15 Dec 2019 14:22:08 -0500 Subject: [PATCH 1/2] gnu: mumble: Update to 1.3.0. Besides the update in itself, bundled software components are enabled as lo= ng as they are not already implemented in an existing package (in which case t= he package is used instead). Some comments were added to indicate why bundled software components are kept or removed, why features are disabled, and the reason to include each license. * gnu/packages/telephony.scm: Add import of (gnu packages gl). * gnu/packages/telephony.scm (mumble): Update to 1.3.0. * gnu/packages/patches/mumble-1.2.19-abs.patch: Remove file. * gnu/local.mk (dist_patch_DATA): Remove it. --- gnu/local.mk | 1 - gnu/packages/patches/mumble-1.2.19-abs.patch | 31 ----- gnu/packages/telephony.scm | 114 ++++++++++++------- 3 files changed, 70 insertions(+), 76 deletions(-) delete mode 100644 gnu/packages/patches/mumble-1.2.19-abs.patch diff --git a/gnu/local.mk b/gnu/local.mk index 32b2c141fa..1034e0198d 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1158,7 +1158,6 @@ dist_patch_DATA =3D \ %D%/packages/patches/mrrescue-support-love-11.patch \ %D%/packages/patches/mrustc-0.8.0-fix-variable-length-integer-receiving.= patch \ %D%/packages/patches/mtools-mformat-uninitialized.patch \ - %D%/packages/patches/mumble-1.2.19-abs.patch \ %D%/packages/patches/mumps-build-parallelism.patch \ %D%/packages/patches/mumps-shared-libseq.patch \ %D%/packages/patches/mumps-shared-mumps.patch \ diff --git a/gnu/packages/patches/mumble-1.2.19-abs.patch b/gnu/packages/pa= tches/mumble-1.2.19-abs.patch deleted file mode 100644 index 683325f4bc..0000000000 --- a/gnu/packages/patches/mumble-1.2.19-abs.patch +++ /dev/null @@ -1,31 +0,0 @@ -From ea861fe86743c8402bbad77d8d1dd9de8dce447e Mon Sep 17 00:00:00 2001 -From: Mikkel Krautz -Date: Fri, 29 Dec 2017 14:47:25 +0100 -Subject: [PATCH] AudioOutput: do not use non-existant template version of - std::abs. - -This change fixes AudioOutput to use the float overload of std::abs: - - float std::abs(float); - -instead of a non-existant template version (for newer Boost 1.66). - -Fixes mumble-voip/mumble#3281 - ---- - src/mumble/AudioOutput.cpp | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/mumble/AudioOutput.cpp b/src/mumble/AudioOutput.cpp -index cbe0c0e2b..7a0a5e2ab 100644 ---- a/src/mumble/AudioOutput.cpp -+++ b/src/mumble/AudioOutput.cpp -@@ -437,7 +437,7 @@ bool AudioOutput::mix(void *outbuff, unsigned int nsam= p) { - top[2] =3D 0.0f; - } -=20 -- if (std::abs(front[0] * top[0] + front[1] * top[1] + front[2] = * top[2]) > 0.01f) { -+ if (std::abs(front[0] * top[0] + front[1] * top[1] + front[2] * top[2= ]) > 0.01f) { - // Not perpendicular. Assume Y up and rotate 90 degrees. -=20 - float azimuth =3D 0.0f; diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index 5b6c578fce..53911f4a94 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -13,6 +13,7 @@ ;;; Copyright =A9 2018 Tim Gesthuizen ;;; Copyright =A9 2019 Pierre Neidhardt ;;; Copyright =A9 2019 Jan Wielkiewicz +;;; Copyright =A9 2019 Ivan Vilata i Balaguer ;;; ;;; This file is part of GNU Guix. ;;; @@ -44,6 +45,7 @@ #:use-module (gnu packages file) #:use-module (gnu packages protobuf) #:use-module (gnu packages gettext) + #:use-module (gnu packages gl) #:use-module (gnu packages glib) #:use-module (gnu packages gnome) #:use-module (gnu packages gnupg) @@ -379,30 +381,34 @@ address of one of the participants.") (define-public mumble (package (name "mumble") - (version "1.2.19") + (version "1.3.0") (source (origin (method url-fetch) (uri (string-append "https://mumble.info/snapshot/" name "-" version ".tar.gz")) (sha256 (base32 - "1s60vaici3v034jzzi20x23hsj6mkjlc0glipjq4hffrg9qgnizh")) - (patches (search-patches "mumble-1.2.19-abs.patch")) + "03dqg5yf6d7ilc1wydpshnv1ndssppcbadqcq20jm5j4fdaf53cs")) (modules '((guix build utils))) (snippet `(begin ;; Remove bundled software. - (for-each delete-file-recursively '("3rdparty" - "speex" - "speexbuild" - "opus-build" - "opus-src" - "sbcelt-helper-build" - "sbcelt-lib-build" - "sbcelt-src")) - ;; TODO: Celt is still bundled. It has been merged into = Opus - ;; and will be removed after 1.3.0. - ;; https://github.com/mumble-voip/mumble/issues/1999 + ;; Keep arc4random, celt-0.7.0, celt-0.11.0, qqbonjour, = rnnoise, smallft. + (for-each delete-file-recursively '("3rdparty/GL" ; in m= esa + "3rdparty/mach-overr= ide-build" ; for macx + "3rdparty/mach-overr= ide-src" + "3rdparty/minhook-bu= ild" ; for win32 + "3rdparty/minhook-sr= c" + "3rdparty/opus-build= " ; in opus + "3rdparty/opus-src" + "3rdparty/sbcelt-hel= per-build" ; not enabled + "3rdparty/sbcelt-lib= -build" + "3rdparty/sbcelt-src" + "3rdparty/speex-buil= d" ; in speex + "3rdparty/speex-src" + "3rdparty/speexdsp-s= rc" ; in speexdsp + "3rdparty/xinputchec= k-build" ; for win32 + "3rdparty/xinputchec= k-src")) #t)))) (build-system gnu-build-system) (arguments @@ -410,23 +416,25 @@ address of one of the participants.") #:phases (modify-phases %standard-phases (replace 'configure - (lambda* (#:key outputs #:allow-other-keys) - (invoke "qmake" "main.pro" "-recursive" + (lambda* (#:key inputs outputs #:allow-other-keys) + (invoke "qmake" "main.pro" "QMAKE_LRELEASE=3Dlrelease" + (string-append "MUMBLE_PYTHON=3D" + (string-append (assoc-ref inputs "pyth= on") "/bin/python3")) (string-append "CONFIG+=3D" (string-join - (list "no-update" - "no-ice" + ;; Options used are listed in the sam= e order + ;; as in the "INSTALL" file + ;; (plus the final "packaged" and "re= lease"). + (list "no-bundled-speex" ; in speex + "no-bundled-opus" ; in opus + "no-g15" ; not packaged + "no-jackaudio" ; use pulse + "no-oss" ; use pulse + "no-alsa" ; use pulse + "no-update" "no-embed-qt-translations" - "no-bundled-speex" - "pch" - "no-bundled-opus" - "no-celt" - "no-alsa" - "no-oss" - "no-portaudio" - "speechd" - "no-g15" - "no-bonjour" + "no-ice" ; not packaged + "packaged" "release"))) (string-append "DEFINES+=3D" "PLUGIN_PATH=3D" @@ -436,6 +444,10 @@ address of one of the participants.") (lambda _ (substitute* "src/mumble/TextToSpeech_unix.cpp" (("libspeechd.h") "speech-dispatcher/libspeechd.h")))) + (add-before 'install 'disable-murmur-ice + (lambda _ + (substitute* "scripts/murmur.ini.system" + (("^ice=3D") ";ice=3D")))) (replace 'install ; install phase does not exist (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) @@ -463,24 +475,38 @@ address of one of the participants.") (for-each (lambda (file) (install-file file lib)) (find-files "." "\\.so\\.")) (for-each (lambda (file) (install-file file lib)) - (find-files "release/plugins" "\\.so$")))))))) + (find-files "release/plugins" "\\.so$"))))) + (add-after 'install 'wrap-executable + ;; Add path to plugins for SVG support (otherwise many icons ar= e not shown). + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out"))) + (for-each (lambda (program) + (wrap-program (string-append out "/bin/" progra= m) + `("QT_PLUGIN_PATH" ":" prefix + ,(map (lambda (label) + (string-append (assoc-ref inputs la= bel) + "/lib/qt5/plugins")) + '("qtbase" "qtsvg"))))) + '("mumble" "mumble-overlay")))))))) (inputs `(("avahi" ,avahi) - ("protobuf" ,protobuf-3.5) - ("openssl" ,openssl) - ("libsndfile" ,libsndfile) ("boost" ,boost) - ("opus" ,opus) - ("speex" ,speex) - ("speexdsp" ,speexdsp) - ("speech-dispatcher" ,speech-dispatcher) - ("libx11" ,libx11) + ("libsndfile" ,libsndfile) ("libxi" ,libxi) - ("qt-4" ,qt-4) - ("alsa-lib" ,alsa-lib) - ("pulseaudio" ,pulseaudio))) + ("mesa" ,mesa) ; avoid bundled + ("openssl" ,openssl) + ("opus" ,opus) ; avoid bundled + ("protobuf" ,protobuf) + ("pulseaudio" ,pulseaudio) + ("qtbase" ,qtbase) + ("qtsvg" ,qtsvg) + ("speech-dispatcher" ,speech-dispatcher) + ("speex" ,speex) ; avoid bundled + ("speexdsp" ,speexdsp))) ; avoid bundled (native-inputs - `(("pkg-config" ,pkg-config))) + `(("pkg-config" ,pkg-config) + ("python" ,python) + ("qttools" ,qttools))) (synopsis "Low-latency, high quality voice chat software") (description "Mumble is an low-latency, high quality voice chat @@ -488,9 +514,9 @@ software primarily intended for use while gaming. Mumble consists of two applications for separate usage: @code{mumble} for the client, and @code{murmur} for the server.") (home-page "https://wiki.mumble.info/wiki/Main_Page") - (license (list license:bsd-3 - ;; The bundled celt is bsd-2. Remove after 1.3.0. - license:bsd-2)))) + (license (list license:bsd-3 ; mumble celt-0.7.0 qqbonjour rnnoise sma= llft + license:bsd-2 ; celt-0.11.0 + license:isc)))) ; arc4random =20 (define-public twinkle (package --=20 2.24.0 --qjNfmADvan18RZcF Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0002-gnu-mumble-Use-qt-build-system.patch" Content-Transfer-Encoding: quoted-printable =46rom b94d83ed7b9ed7fe009e6aa4920970a8ebfa4276 Mon Sep 17 00:00:00 2001 =46rom: Ivan Vilata-i-Balaguer Date: Sun, 15 Dec 2019 20:12:34 -0500 Subject: [PATCH 2/2] gnu: mumble: Use qt-build-system. * gnu/packages/telephony.scm: Add import of (guix build-system qt). * gnu/packages/telephony.scm (mumble): Use qt-build-system. : Base on phases from qt-build-system. {wrap-executable}: Remove. --- gnu/packages/telephony.scm | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm index 53911f4a94..e0168d2345 100644 --- a/gnu/packages/telephony.scm +++ b/gnu/packages/telephony.scm @@ -79,7 +79,8 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix build-system cmake) - #:use-module (guix build-system gnu)) + #:use-module (guix build-system gnu) + #:use-module (guix build-system qt)) =20 (define-public commoncpp (package @@ -410,11 +411,11 @@ address of one of the participants.") "3rdparty/xinputchec= k-build" ; for win32 "3rdparty/xinputchec= k-src")) #t)))) - (build-system gnu-build-system) + (build-system qt-build-system) (arguments `(#:tests? #f ; no "check" target #:phases - (modify-phases %standard-phases + (modify-phases (@ (guix build qt-build-system) %standard-phases) (replace 'configure (lambda* (#:key inputs outputs #:allow-other-keys) (invoke "qmake" "main.pro" "QMAKE_LRELEASE=3Dlrelease" @@ -475,19 +476,7 @@ address of one of the participants.") (for-each (lambda (file) (install-file file lib)) (find-files "." "\\.so\\.")) (for-each (lambda (file) (install-file file lib)) - (find-files "release/plugins" "\\.so$"))))) - (add-after 'install 'wrap-executable - ;; Add path to plugins for SVG support (otherwise many icons ar= e not shown). - (lambda* (#:key inputs outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - (for-each (lambda (program) - (wrap-program (string-append out "/bin/" progra= m) - `("QT_PLUGIN_PATH" ":" prefix - ,(map (lambda (label) - (string-append (assoc-ref inputs la= bel) - "/lib/qt5/plugins")) - '("qtbase" "qtsvg"))))) - '("mumble" "mumble-overlay")))))))) + (find-files "release/plugins" "\\.so$")))))))) (inputs `(("avahi" ,avahi) ("boost" ,boost) --=20 2.24.0 --qjNfmADvan18RZcF-- --Km1U/tdNT/EmXiR1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEHpvwBPZcchIQr6TuPezBBfXdI4IFAl324VwACgkQPezBBfXd I4Lmqg/+IE+UzySJJr63bIzcjP/eSLA8TGEBN6ToM6YF0/lGstEIQZbfvTiC130l uPQw4LAFX3GUxF+YFpKXL992mvRnh03zGIhno/ClVPLsW05NF6N3SGmUoe1uVWAw +58G9dWrJTDTInIQ0/jB8OTechYf23RjBRYmkn7W4Vh8cUQveVCoUgFBzaDqS/BH Ii4X7SoK8ZBcWbPspmOxhMvEEF4YdLRZpgcbra8mjBvVjCjSm7ZQD9W2V/E0EE3q lSAvUDEuGgOGcpHpo9qfTOw54pFt2iLtQQx0M7mSFE1dpWennFQdpRO3UZzwuWm1 W3xEtlQGXrVfazh/ztiXiA4PZiJ6UBhXazkJmBvduwSaLpBNOBmWHyxiE3hvtusw R2z4NhekYOl9ZXZf7TtrnEcR8Ld0EFx7AiET4DDOET6ZHx4n0Kp0a6WatRIqJksY t6Y57gXGpHAftUVPaflSM9gyRNrvwiGOXO0X3qXGdB/AZsAmmG0OIZR2kDO4SRUC BCca9KhcJzjnFXA76uBuuuzuQ5AsfqFbe8545demag5aCtcfPkTL1CWg065KYd7g N6I85NnyGEY8GyPFOjr2BEQkhdj2OT95T+PuBiOaaqmdjSAeJBraWuufuMJJMocG K3IR3F4mZ49Kpjn1pGSusU4NR0zAcZW3+JjM/jb9AvKWMDzDqSU= =NWTE -----END PGP SIGNATURE----- --Km1U/tdNT/EmXiR1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 08:03:51 2019 Received: (at 38395-done) by debbugs.gnu.org; 19 Dec 2019 13:03:51 +0000 Received: from localhost ([127.0.0.1]:44360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihvT5-0006ah-El for submit@debbugs.gnu.org; Thu, 19 Dec 2019 08:03:51 -0500 Received: from flashner.co.il ([178.62.234.194]:45272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihvT3-0006aN-8Z; Thu, 19 Dec 2019 08:03:49 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id 2EBE54018C; Thu, 19 Dec 2019 13:03:43 +0000 (UTC) Date: Thu, 19 Dec 2019 15:03:11 +0200 From: Efraim Flashner To: Ivan Vilata i Balaguer Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191219130311.GH917@E5400> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+9faIjRurCDpBc7U" Content-Disposition: inline In-Reply-To: <20191216014411.GC1392584@sax.terramar.selidor.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38395-done Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --+9faIjRurCDpBc7U Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I merged the two patches together, made sure all the phases returned #t and flushed out the commit message some more. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --+9faIjRurCDpBc7U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl37dQwACgkQQarn3Mo9 g1EJHhAArIOxS6xnbUoNg6UC1Xbj3PNZtePNeN6BAa+qG/eDAw3MFsv4dH2rnZEv dZx7RhumaYoDpuanEaceFjJYHoT7ndjwabelUEhPQc6MGcXWyAwh6jvd38xdURJi gt+fckzi2VoTPIUZyuPeLQNcyoSEDHt4CyZ+NLmJp0HWdR+j0/MaEHWorKNpQ1eJ UhdlIRZO2nGmHugB6FcBSFASmprOqhq5cIUmQ2V56bBZpqMCo2f4obE9LsPpNZn6 Fwy/pqLrYXvFsUWqLoeFo66vrYpsqkr46/KMNe1xNNcTD55CoLrUeY2+e/l/URRQ BcKU7H02WMa1qIBKwEs/gmzGM6FSMyLknu2AlrEhLncWISmWUmTOFXEVUJGpRUYU xKp43fKw7oYT7q03rHiVR+92eeb7W4i0c6DGLVtpDLdpb7X6GzeF8KMIeJ2UyrJ9 iMLmCuJo4qKS9aLiACRQnN5o7eMbCdKnk7en8Teg2T3QJK+hM9vMfcZo6h+yHG6b WgegGU/RXhcOv4gcfgNIV4Rl4vMLlZQoJe+FcxtL9SeWn5cUyfvs/f8zY6EpqqDl 6VD4zotyXjyVHE55+uJAKT75y+ARblmmQBJmkwsHrgQY4jhXvlBYzHrhggbZv1Sm mJO60l1OkkkRVccYqCFiragnuf3+EhGX9Rx8HRbBJhWZdCnfCDE= =9pio -----END PGP SIGNATURE----- --+9faIjRurCDpBc7U-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 11:53:03 2019 Received: (at 38395-done) by debbugs.gnu.org; 19 Dec 2019 16:53:04 +0000 Received: from localhost ([127.0.0.1]:45462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihz2t-0006Cf-Ke for submit@debbugs.gnu.org; Thu, 19 Dec 2019 11:53:03 -0500 Received: from lev.selidor.net ([66.246.138.156]:60769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihz2r-0006CA-8W; Thu, 19 Dec 2019 11:53:02 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:986e:30ea:5320:94d4]) by lev.selidor.net (Postfix) with ESMTP id 6EC0CC83D; Thu, 19 Dec 2019 16:53:00 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 934219A0109; Thu, 19 Dec 2019 11:51:55 -0500 (EST) Date: Thu, 19 Dec 2019 11:51:55 -0500 From: Ivan Vilata i Balaguer To: Efraim Flashner Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191219165155.GF1392584@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> <20191219130311.GH917@E5400> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191219130311.GH917@E5400> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395-done Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org, Ivan Vilata i Balaguer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner (2019-12-19 15:03:11 +0200) wrote: > I merged the two patches together, made sure all the phases returned #t > and flushed out the commit message some more. Thanks a lot! Comparing your final patch against mine was also very instructive. `:)` -- Ivan Vilata i Balaguer -- https://elvil.net/ From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 11:09:07 2019 Received: (at 38395-done) by debbugs.gnu.org; 20 Dec 2019 16:09:07 +0000 Received: from localhost ([127.0.0.1]:47198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiKpu-0001L4-S3 for submit@debbugs.gnu.org; Fri, 20 Dec 2019 11:09:07 -0500 Received: from lev.selidor.net ([66.246.138.156]:54311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiKps-0001Kq-H8; Fri, 20 Dec 2019 11:09:05 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:a8e4:5455:b667:635a]) by lev.selidor.net (Postfix) with ESMTP id E88C6C82E; Fri, 20 Dec 2019 16:09:03 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 63D909A00C5; Fri, 20 Dec 2019 11:07:58 -0500 (EST) Date: Fri, 20 Dec 2019 11:07:58 -0500 From: Ivan Vilata i Balaguer To: Ivan Vilata i Balaguer Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191220160758.GA2604844@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> <20191219130311.GH917@E5400> <20191219165155.GF1392584@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191219165155.GF1392584@sax.terramar.selidor.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395-done Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org, Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote: > Efraim Flashner (2019-12-19 15:03:11 +0200) wrote: > > > I merged the two patches together, made sure all the phases returned #t > > and flushed out the commit message some more. > > Thanks a lot! Comparing your final patch against mine was also very > instructive. `:)` Before you close this issue, I upgraded my `mumble` package and many icons are missing. I didn't yet have time to further investigate it, but maybe it's because of a difference I noticed between your patch: (modify-phases %standard-phases and mine: (modify-phases (@ (guix build qt-build-system) %standard-phases) So maybe the problem is that the final, wrapping phase of `qt-build-system` is not being run. Actually I see that `mumble` is a plain binary while in the output from my patch, it was a wrapper script. Thanks! -- Ivan Vilata i Balaguer -- https://elvil.net/ From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 05:56:43 2019 Received: (at 38395-done) by debbugs.gnu.org; 22 Dec 2019 10:56:43 +0000 Received: from localhost ([127.0.0.1]:49096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiyuh-0006nv-BH for submit@debbugs.gnu.org; Sun, 22 Dec 2019 05:56:43 -0500 Received: from flashner.co.il ([178.62.234.194]:53396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iiyuf-0006na-PL; Sun, 22 Dec 2019 05:56:42 -0500 Received: from localhost (unknown [141.226.13.108]) by flashner.co.il (Postfix) with ESMTPSA id CCE5240230; Sun, 22 Dec 2019 10:56:35 +0000 (UTC) Date: Sun, 22 Dec 2019 12:56:04 +0200 From: Efraim Flashner To: Ivan Vilata i Balaguer Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191222105604.GD1115@E5400> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> <20191219130311.GH917@E5400> <20191219165155.GF1392584@sax.terramar.selidor.net> <20191220160758.GA2604844@sax.terramar.selidor.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="76DTJ5CE0DCVQemd" Content-Disposition: inline In-Reply-To: <20191220160758.GA2604844@sax.terramar.selidor.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 38395-done Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --76DTJ5CE0DCVQemd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote: > Ivan Vilata i Balaguer (2019-12-19 11:51:55 -0500) wrote: >=20 > > Efraim Flashner (2019-12-19 15:03:11 +0200) wrote: > >=20 > > > I merged the two patches together, made sure all the phases returned = #t > > > and flushed out the commit message some more. > >=20 > > Thanks a lot! Comparing your final patch against mine was also very > > instructive.=C2=A0`:)` >=20 > Before you close this issue, I upgraded my `mumble` package and many icon= s are > missing. I didn't yet have time to further investigate it, but maybe it's > because of a difference I noticed between your patch: >=20 > (modify-phases %standard-phases >=20 > and mine: >=20 > (modify-phases (@ (guix build qt-build-system) %standard-phases) >=20 > So maybe the problem is that the final, wrapping phase of `qt-build-syste= m` is > not being run. Actually I see that `mumble` is a plain binary while in t= he > output from my patch, it was a wrapper script. >=20 I'm not sure what happened with the wrapping phase, but I changed it back and now everything should be working as expected. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --76DTJ5CE0DCVQemd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl3/S8QACgkQQarn3Mo9 g1ES3w//dkVOxofsOOeFn05eRCVyre0KA9u5L49/zkR86p7z/XxwChN5YblHramu +kzlwhpGgUfqgIwf933+mBlaAK/7zMoFqZ/6OTxuD4uUTpT9l+crAhcHLOG/uWSD YwkmTmJTcUdVNZ5xJlP9WY+fJgjxeYqu2pkq6vJqTK6fN5waZvU5SB3BrRIknm/c HK87576/E4qhayEr6Dwuf0kcgrijpnH2kbTzcqUwad//UfZ67yM9fhJRTn0p82Gu EU8+co6+69TAFYBmw8VRWfwCmxGjiDTgkQHNCbQ/uk+AR9xPs+t90wEOS1S2IsWJ ghSibyfJdHQ0sV7UUOSaRnxDh7E0g2Ij3YeGc5ENdD1s02BQ4CmXtJ0esKQNdR1N xwhsdCFGGjsZcZLj3E18MgpngpL+ucdWK20LYuyuQciDmb0qZAuQyjuGHGd8cckw 8GT5ZAAJlRDKce+AzQ6ulGVOpwUB33AR004y9eCrsEobsOxmC8jEJ4YKsBHpMzfe 108P03+Fid6/9r2IQkPf/php1gPzr1er7zzKS5aR9hIICcxMRqzuoPnTEG7zyeBO Y4jiYKsRFYuLNMpGp8wrGAjTtVfmQMCCCjuTyIYMjsCHpz9i8Ot2Hvel0BvjFaIN Exc1etBatzwvfesyDlJb6Yn84ON/AlodlP8opyUlDRkskLqbf+I= =ra/V -----END PGP SIGNATURE----- --76DTJ5CE0DCVQemd-- From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 22 13:17:50 2019 Received: (at 38395-done) by debbugs.gnu.org; 22 Dec 2019 18:17:50 +0000 Received: from localhost ([127.0.0.1]:50219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij5na-0005Lj-JJ for submit@debbugs.gnu.org; Sun, 22 Dec 2019 13:17:50 -0500 Received: from lev.selidor.net ([66.246.138.156]:46635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ij5nY-0005LS-3W; Sun, 22 Dec 2019 13:17:48 -0500 Received: from sax.terramar.selidor.net (unknown [IPv6:2600:3c03:e001:114e:a8e4:5455:b667:635a]) by lev.selidor.net (Postfix) with ESMTP id 15B38C83E; Sun, 22 Dec 2019 18:17:45 +0000 (UTC) Received: by sax.terramar.selidor.net (Postfix, from userid 1000) id 3F3F69A0109; Sun, 22 Dec 2019 13:16:38 -0500 (EST) Date: Sun, 22 Dec 2019 13:16:38 -0500 From: Ivan Vilata i Balaguer To: Efraim Flashner Subject: Re: [bug#38395] Acknowledgement ([PATCH] gnu: mumble: Update to 1.3.0.) Message-ID: <20191222181638.GI1392584@sax.terramar.selidor.net> References: <20191127014038.GD17004@sax.terramar.selidor.net> <20191204201718.GA17141@sax.terramar.selidor.net> <20191205090236.GQ15280@E5400> <20191216014411.GC1392584@sax.terramar.selidor.net> <20191219130311.GH917@E5400> <20191219165155.GF1392584@sax.terramar.selidor.net> <20191220160758.GA2604844@sax.terramar.selidor.net> <20191222105604.GD1115@E5400> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191222105604.GD1115@E5400> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38395-done Cc: 38054-done@debbugs.gnu.org, 38395-done@debbugs.gnu.org, Ivan Vilata i Balaguer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Efraim Flashner (2019-12-22 12:56:04 +0200) wrote: > On Fri, Dec 20, 2019 at 11:07:58AM -0500, Ivan Vilata i Balaguer wrote: > > > > Before you close this issue, I upgraded my `mumble` package and many icons are > > missing. I didn't yet have time to further investigate it, but maybe it's > > because of a difference I noticed between your patch: > > > > (modify-phases %standard-phases > > > > and mine: > > > > (modify-phases (@ (guix build qt-build-system) %standard-phases) > > > > So maybe the problem is that the final, wrapping phase of `qt-build-system` is > > not being run. Actually I see that `mumble` is a plain binary while in the > > output from my patch, it was a wrapper script. > > I'm not sure what happened with the wrapping phase, but I changed it > back and now everything should be working as expected. Works indeed now, than you! `:)` -- Ivan Vilata i Balaguer -- https://elvil.net/ From unknown Fri Aug 15 15:56:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Jan 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator