From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 07:08:56 2019 Received: (at submit) by debbugs.gnu.org; 26 Nov 2019 12:08:56 +0000 Received: from localhost ([127.0.0.1]:50698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZZeJ-0001zC-Op for submit@debbugs.gnu.org; Tue, 26 Nov 2019 07:08:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:53925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZZeI-0001z4-6z for submit@debbugs.gnu.org; Tue, 26 Nov 2019 07:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49209) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZZeG-0007n6-Hy for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 07:08:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, FREEMAIL_REPLY,HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZZeE-0007ly-G9 for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 07:08:52 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]:35425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZZeE-0007lE-7q for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 07:08:50 -0500 Received: by mail-qt1-x82b.google.com with SMTP id n4so21129625qte.2 for ; Tue, 26 Nov 2019 04:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kPW29HRch793ELH/8jWDcpBsde0EvFFBquWRX5QMgZo=; b=p+KciwY6g71f597AF+Ee452dx8TtlUfdZHp9/3AGcj5kQoiX4gTG6fHwjMsnPUc1EW JNWMDaiHpjQYbeUUtpJPc0r0bQBfnrovIK1sq+4Fsc3HQfZjhUlbbJfQCxcvGfkZf/X7 hQywy6IF5+N7/S6kvdf/3TNSK44bHMjggsag0OjPyt38HSm7DaN2FNggv76nNXa5AAaY fowtUUt83DIIEfqW2hvIH0dlv4jIfrGnnCeyIEaB/z6Zsw2a9t/03dfd0gFultxGbVp2 LHiL3tN94URU0omN9AUhoUUYzTX4hY6VWYwfjuRH90JGW9MZkFETpCEtUlTiS2FxPOEb vrDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kPW29HRch793ELH/8jWDcpBsde0EvFFBquWRX5QMgZo=; b=qFfen64/+QNPjI1bzzIbx1Z1y9mM9a5awTupemBuPYc1/bZzh9GN4OIVHQYf3b1TPB OYEEj58TMdQuCkOmxXxzOZahMKrDRx+rK6+cOnq/K+cDIQXB0G4o2cG7f+/ZzGsM6TTk reAVVZYWNRnwsAhBhYxjRftyC4DHPpXe6Dul+wEaE+vIkdbLMWEtSmvbiN09BoH8d16X xsWBgX6//nofPSfLntMw2dVvuYTwcPI2Toorx8zOtrOccK0SeVCxliMzVcQruK/1qDHm hugJzJPX5fkdD+YWmUoPGNnB5ixB2ksFDiEFMfjQgvfVNdjvZc4yh/iYiNG7bgJnGzm/ R60A== X-Gm-Message-State: APjAAAW5/VIu14rmrAIgDbZsquT5aFZXDGB2spmvh/6A2/Onec2us9VD deC/uR58Fs6k9AQH2Otrx7Gp4xllgRN6f9J5s4rxFcpe X-Google-Smtp-Source: APXvYqyd+iJZZf4h2GYlL8OSksl4hbOyZ8sLaAZuBoNeyv2jd1gu5RTAOj4bV4bgzH8SrqHoiGhB0REY6rCxu1btFXI= X-Received: by 2002:ac8:230d:: with SMTP id a13mr31089977qta.354.1574770129207; Tue, 26 Nov 2019 04:08:49 -0800 (PST) MIME-Version: 1.0 From: Juanma Barranquero Date: Tue, 26 Nov 2019 13:08:12 +0100 Message-ID: Subject: (next|previous)-buffer silent about not switching To: Bug-Gnu-Emacs Content-Type: multipart/mixed; boundary="00000000000027ad5105983ebea4" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::82b X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Package: emacs Severity: minor Tags: patch X-Debbugs-Cc: rudalics@gmx.at In some circumstances, next-buffer and previous-buffer do not have any buffer to switch to, and in that case they silently do nothing. (Strictly speaking, they call switch-to-(next|prev)-buffer, which [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gmx.at] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (lekktu[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 HTML_MESSAGE BODY: HTML included in message 1.0 FREEMAIL_REPLY From and body contain different freemails 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000027ad5105983ebea4 Content-Type: multipart/alternative; boundary="00000000000027ad4e05983ebea2" --00000000000027ad4e05983ebea2 Content-Type: text/plain; charset="UTF-8" Package: emacs Severity: minor Tags: patch X-Debbugs-Cc: rudalics@gmx.at In some circumstances, next-buffer and previous-buffer do not have any buffer to switch to, and in that case they silently do nothing. (Strictly speaking, they call switch-to-(next|prev)-buffer, which do nothing and return nil). I think they should throw a user-error, to inform the user about the situation. --00000000000027ad4e05983ebea2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Package: emacs
Severity: minor
Tags: patch
X-Debb= ugs-Cc: rudalics@gmx.at

=
In some circumstances, next-buffer and previous-buffer do not ha= ve any buffer to switch to, and in that case they silently do nothing.=C2= =A0 (Strictly speaking, they call switch-to-(next|prev)-buffer, which do no= thing and return nil).

I think they should throw a= user-error, to inform the user about the situation.


--00000000000027ad4e05983ebea2-- --00000000000027ad5105983ebea4 Content-Type: application/octet-stream; name="window.patch" Content-Disposition: attachment; filename="window.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k3ftfvjx0 ZGlmZiAtLWdpdCBpL2xpc3Avd2luZG93LmVsIHcvbGlzcC93aW5kb3cuZWwKaW5kZXggNDlmYWQ3 NWQzYy4uYzhhNTgxNmI4YyAxMDA2NDQKLS0tIGkvbGlzcC93aW5kb3cuZWwKKysrIHcvbGlzcC93 aW5kb3cuZWwKQEAgLTQ4NTAsNyArNDg1MCw4IEBAIG5leHQtYnVmZmVyCiAgICAgKHVzZXItZXJy b3IgIldpbmRvdyBpcyBzdHJvbmdseSBkZWRpY2F0ZWQgdG8gaXRzIGJ1ZmZlciIpKQogICAgKHQK ICAgICAoZG90aW1lcyAoXyAob3IgYXJnIDEpKQotICAgICAgKHN3aXRjaC10by1uZXh0LWJ1ZmZl cikpKSkpCisgICAgICAodW5sZXNzIChzd2l0Y2gtdG8tbmV4dC1idWZmZXIpCisgICAgICAgICh1 c2VyLWVycm9yICJObyBuZXh0IGJ1ZmZlciIpKSkpKSkKIAogKGRlZnVuIHByZXZpb3VzLWJ1ZmZl ciAoJm9wdGlvbmFsIGFyZykKICAgIkluIHNlbGVjdGVkIHdpbmRvdyBzd2l0Y2ggdG8gQVJHdGgg cHJldmlvdXMgYnVmZmVyLgpAQCAtNDg2NCw3ICs0ODY1LDggQEAgcHJldmlvdXMtYnVmZmVyCiAg ICAgKHVzZXItZXJyb3IgIldpbmRvdyBpcyBzdHJvbmdseSBkZWRpY2F0ZWQgdG8gaXRzIGJ1ZmZl ciIpKQogICAgKHQKICAgICAoZG90aW1lcyAoXyAob3IgYXJnIDEpKQotICAgICAgKHN3aXRjaC10 by1wcmV2LWJ1ZmZlcikpKSkpCisgICAgICAodW5sZXNzIChzd2l0Y2gtdG8tcHJldi1idWZmZXIp CisgICAgICAgICh1c2VyLWVycm9yICJObyBwcmV2aW91cyBidWZmZXIiKSkpKSkpCiAKIChkZWZ1 biBkZWxldGUtd2luZG93cy1vbiAoJm9wdGlvbmFsIGJ1ZmZlci1vci1uYW1lIGZyYW1lKQogICAi RGVsZXRlIGFsbCB3aW5kb3dzIHNob3dpbmcgQlVGRkVSLU9SLU5BTUUuCg== --00000000000027ad5105983ebea4-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 08:42:18 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 13:42:18 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZb6g-0006OZ-Ir for submit@debbugs.gnu.org; Tue, 26 Nov 2019 08:42:18 -0500 Received: from mout.gmx.net ([212.227.17.22]:38135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZb6e-0006OM-HI for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 08:42:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574775729; bh=vkONuktAywD/jClGpNKiixB40D2oHTmGl43FLMj9y+c=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=hVFJRJKkSNWD+r3oSpacn2UvNK2yrwtFFW2doJtAG8L1AIE06q1n5eXr1/evHvKAq QEjMnKpAy0I7Z+sUVs0gZ9G8VxlxT9Ovs/ANJtWfMtpN3PpzR3CqyauFI4upnWWdvi 8Hxov50nlY64MFn7MgEJoKgoWuW20H5vNus7EzQQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.22]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWRRT-1iKVsw2MDD-00Xswq; Tue, 26 Nov 2019 14:42:09 +0100 Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Juanma Barranquero , 38384@debbugs.gnu.org References: From: martin rudalics Message-ID: <7ccf3f3a-2b3b-ad8c-1bc0-eae0108feb44@gmx.at> Date: Tue, 26 Nov 2019 14:42:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:PzJPt7dsevNESDI3AL9qX9eX99NH2CTy6IrrJgH7cbkUpDpd7fo Sk1M+IZU3235wFpX8pmmdHFIuDQF6WrNd0AmJ1ZBLwJErvo5yDNZhV+ycCS+BTlnJW465vQ GouXcy5LUtoVRfw+FnmlHaon6KbUBWYWXKccjQTLzFWTyIZjP/kl1ED8jpcsyqdgiAM2Rym +poNR1ak3wujEDrRDnQbw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bv0aw89mQ18=:1FPRNrb0/vSrvWhPIaGIi6 yRUtU04I1+kDoAb2tITLa2FcuobbW59tIiVhikUt542hl1NpQWOKydbhSi3Dz4QX3ADrAN9oM T/j4zBsUoi0j/6rygbw9PwiliMIoJkBNZSAwGNC0NBZgr4fgu/VMmO+Zi1K4VA77e0SWk/6wD C9lyEuhrRrbNK69x06ZuyssUAKQfJiE9SODHlWYOcUYykhI5D/qS8QAr8HUQWD5cvCRFnuHer mDxZJU0KAhpm7+Y0TVTPY27yLhVyd/stHNp6wxrwYcGeq33XGXxTy5p3d2lLCs3/g9AiGpoTe 7HDc946n/mM+4TFLxTNQcuB+eYkxrR/qlaS2t3J+ORx18Cw5BqTeHohDqqe32NRNHgbLiQcdf s4wjtdpyi9dJ1AjJqUFfhbKRr6tgp8ybLrwpeZ8MVu4bzrxOUqO3JJFxF5vB5nt1QRPx3wdWc u9dB2pJGojDwGaz/r9kKKfpt/oGmHkyprhjN27zoH/6IvIFc04qZT3qtbqeifpkNE0j70Y7ph 2MjbRrrbcab6Dbx5ptX+bmtte6XaFo7zWT8v4G+Bu8gpHuCj2qshpJKwUiN04ORM0e/xLGN1N K/T4cJTrl0wNM5oeS7MHm1UiDBYIR2BqRLMeyUiyc4ivHd/C52VOE3RRQf0AJbYPzqsrfjqLW Cp+PzACBEngYzfxlx9cKfYoUvSAZdRDoJ0ng1Uy/tp78d/Ykv7R7qNp0NEu5aSk8da7V7znaK dk95CtRPE4AcT2KvO3Wue0J8ZJ99nlx+4IzsMuV1hKp97hbLtSp9rx/KKvGCVCEJJ4l2ufpVh opOtmOZcTnwCSUQtnGAy7NXKpX/wH6iKQsJB18LdyMijCTSeAEgrFeXRKJqtKPZ8LdGvvznDe uX1JAhqzrvj/FtN7puTQZLcbu58S2Y0dCX/Nc5NlLq6uLNJSbwAhAji8+3KlMtemaE0t511zY U++HgXAoOdq990B8wOJ+DZC1+MFlHFbpB4hFcvrjnXdbqy5bY0mwemoi6eRC5u/mdrCSAw+3Q FnnydFbP6zZiP3sPTCEq8aZDYiuHvOBmATqr516USzbnf+boTNqTSwe3xPisRXuG3s2/e63wb CAcz2E+JbVTTYi6lqr89Bd8nciszTjowMl/ESq6Nxr2HmYgzah3WwODQwo7N+3xxVHv+1Wcab RLEnNIRVVSOD0lN9b0hnFgWmD5YAbO6WmS/kCp2QYPXaBbrMP2XQ2a2KTrtVxW+Cv7+/sekvY KMFiv1hzhN3RtjvhcFhImjfNwepA5y1k42A6x10sZyeVOvJGO2LwYuv38XTM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38384 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > In some circumstances, next-buffer and previous-buffer do not have any > buffer to switch to, and in that case they silently do nothing. (Strictly > speaking, they call switch-to-(next|prev)-buffer, which do nothing and > return nil). > > I think they should throw a user-error, to inform the user about the > situation. Right. Please install your patch. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 09:06:31 2019 Received: (at 38384-done) by debbugs.gnu.org; 26 Nov 2019 14:06:31 +0000 Received: from localhost ([127.0.0.1]:50950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZbU7-0006yd-9G for submit@debbugs.gnu.org; Tue, 26 Nov 2019 09:06:31 -0500 Received: from mail-qv1-f54.google.com ([209.85.219.54]:44577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZbU3-0006yP-SM for 38384-done@debbugs.gnu.org; Tue, 26 Nov 2019 09:06:29 -0500 Received: by mail-qv1-f54.google.com with SMTP id d3so7288810qvs.11 for <38384-done@debbugs.gnu.org>; Tue, 26 Nov 2019 06:06:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tNXo/hMJ9UAvt2ZzavTrMeq401604Pgqh6m7ep4vewo=; b=SkQqeowuc6GAW9TwSANf4g+AldVn1FL85iAfzRmZ7EpnsRFfXsDKZsjPzKh+pIyNpo X2Jzs6Puex+TgTWaL28YgV3eqy58JM4fUYlUg2QXD34GntEfm2uEXEZSXNz47yNqKmNC 1k+a2UeklMfmNEp/OBH75stktjyTYMU5EomzN6xxfWNp16APafXIeztw7hqOs5ZbV+TC gQQZwvWlUY06byriKdQvtZKzm1gv8uoqsDFIOLqrBmytc9o1QnDXbCw9+9S6+OohHc1Y QBJKues12+BIsZB2WWQM71PqVc0F6KZnKLaJZE1OZ54qn0mQxS1ygYY61CuaEQh8zgT5 CPBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tNXo/hMJ9UAvt2ZzavTrMeq401604Pgqh6m7ep4vewo=; b=im3siLm3wRa2W30G2UlRe72SExzf2hei698b4FiorgnpJzNXcIOtL6XE9wXS+T2x+h qeV1ODEq7E9e3AB8+eZhjnGebWHdVuoLEZvR9SbP1LpU0ZkO8ug7gNntPsIBVlurP645 VAqn7FuyaKsU/G7pBIVGd2ldnKDRpV7VTxn37TOv7oEK2SOftdS2Kgmp8cEyV/t9RAVH sHSSdfDOBQDvZbgODuIMvM4b1BE2wKlCtcLo0WR1CY/SH4C0fWYEmaBQ1ol6xb3RMVL3 9UWRYHbcSFyZ1Y6sfUKPUv7elJYzIzEE450DWd2eWA3uywZXvGdfV81DwwrmLqF7szFg hEsA== X-Gm-Message-State: APjAAAVljzbJf7GqhHUNuZjLFxSjFIxaM74GVu+AHlu1nLdwB2lf0zAe wgaqTH6uEHcvgd9MfJje9nrBTOtONOShnZhPpDQ= X-Google-Smtp-Source: APXvYqz05063AYd3w9NrPM2hEdDm3C8lkEsqMiN55+NbkEYqdAdDBkCtCfePkivhmbld9Z5CJPbVRZMBkqpNIMWtwtY= X-Received: by 2002:ad4:450a:: with SMTP id k10mr16895959qvu.136.1574777182189; Tue, 26 Nov 2019 06:06:22 -0800 (PST) MIME-Version: 1.0 References: <7ccf3f3a-2b3b-ad8c-1bc0-eae0108feb44@gmx.at> In-Reply-To: <7ccf3f3a-2b3b-ad8c-1bc0-eae0108feb44@gmx.at> From: Juanma Barranquero Date: Tue, 26 Nov 2019 15:05:45 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: martin rudalics Content-Type: multipart/alternative; boundary="0000000000008b7ae7059840623a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384-done Cc: 38384-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008b7ae7059840623a Content-Type: text/plain; charset="UTF-8" Committed as e495dbea7035bcb1f26ed82f0d56a5abc90974fa --0000000000008b7ae7059840623a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Committed=C2=A0as=C2=A0e495dbea7035bcb1f26ed82f0d56a5abc90= 974fa
--0000000000008b7ae7059840623a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:42:46 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 15:42:46 +0000 Received: from localhost ([127.0.0.1]:52760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZczG-0003Cg-4j for submit@debbugs.gnu.org; Tue, 26 Nov 2019 10:42:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZczF-0003CO-5W for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 10:42:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZczA-0005no-0D; Tue, 26 Nov 2019 10:42:40 -0500 Received: from [176.228.60.248] (port=4503 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZcz9-0008Jj-Hr; Tue, 26 Nov 2019 10:42:39 -0500 Date: Tue, 26 Nov 2019 17:42:45 +0200 Message-Id: <83lfs2sky2.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 13:08:12 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 13:08:12 +0100 > > In some circumstances, next-buffer and previous-buffer do not have any buffer to switch to, and in that case > they silently do nothing. (Strictly speaking, they call switch-to-(next|prev)-buffer, which do nothing and return > nil). > > I think they should throw a user-error, to inform the user about the situation. Could that disrupt noninteractive calls? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 10:55:39 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 15:55:39 +0000 Received: from localhost ([127.0.0.1]:52771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZdBj-0003Vz-DC for submit@debbugs.gnu.org; Tue, 26 Nov 2019 10:55:39 -0500 Received: from mail-qt1-f173.google.com ([209.85.160.173]:38940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZdBh-0003Vm-VW for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 10:55:38 -0500 Received: by mail-qt1-f173.google.com with SMTP id g1so12547907qtj.6 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 07:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mcdD0OG6YkPfeY+btOazkS/oe2sUKNtj/VKUDo3cAqo=; b=E6qyLk6NhUV6RNdPXBAfCqF5i1iX+g4wAkAM3TWh1aq/lJUyQGsjtfJ654qaLfxu5i 8gbaGwVzyvSdv/zH+XGxVpMJH1+9LF4j183tl7TSigTsL7qgfAtQtLv3bKLuNd3OSIb7 uYoGBAX3lM0Nj1BfcXG6cVOMCdZB56+2FIJUyEjh1x9b3TsRSBoZS+dDq6L+e5FpHfIU DNAHZuBOX5E03VqtakgM31ejjkYxz1DQRQi62CsYS3TZZvGzgdc9IyRSmKGiAu/lkCOX EH9ieoxdiGKO24aVIxVaRoa/pm/kuHrpaJ1aAyGWXSEBr/R8t8i7JHV+YkgJ5neMfskS Ebtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mcdD0OG6YkPfeY+btOazkS/oe2sUKNtj/VKUDo3cAqo=; b=DD0acitDUUengDp0nRdb90uEMLj/Zc5DkARE/jIJQRNlWh6UkjPZHAvsuszMpsAUap qkWqQE4BWDCVS6+JipcWFXSMtobKsxQNcLWRqJAwx5Kk+BGFFu3KUP0cznaTKSCaHt6n elIba44Jp53+1SL6y92NFFJEkSjNgPYjzlhS7DcVtgCibc9iAum8Ef4WEKO54rjk4kWX NexP3dWQtU9USZbPhO4fLvYbZCk5ujkbV0X2WEa3voKAL4GCFu/E5ZYmw13mlPVytoYX P7mKuLI/WYd/Wn8nRLPH85fu8J3qHGOw059kOD54GRtxteAomTg+kvJDBHrZGQAkqguo clkg== X-Gm-Message-State: APjAAAWflkNgjP9Xgm2DbndAdW1lMGgW0mNRyGtpFGPaPRk0KUTz4b72 KOve5V+/UodUE8z1XNC6gL6GCW5PCNgCKtWPcRg= X-Google-Smtp-Source: APXvYqy2EaKRS2LqrDxXA6I3GHx02ZK8J9vOugUHZmsDTy69rpEo/h3vA3K9ZluO5ncW5uhLo5MqmH6TwspYe80YENY= X-Received: by 2002:ac8:71c9:: with SMTP id i9mr32942112qtp.287.1574783732196; Tue, 26 Nov 2019 07:55:32 -0800 (PST) MIME-Version: 1.0 References: <83lfs2sky2.fsf@gnu.org> In-Reply-To: <83lfs2sky2.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 26 Nov 2019 16:54:56 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000f4a8f3059841e87a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f4a8f3059841e87a Content-Type: text/plain; charset="UTF-8" On Tue, Nov 26, 2019 at 4:42 PM Eli Zaretskii wrote: > Could that disrupt noninteractive calls? Yes, that's why added the notice in NEWS in the "Incompatible Lisp Changes". But, on one hand, programs should perhaps be using switch-to-(prev|next)-buffer. AFAICS, next-buffer and previous-buffer aren't even documented in the Elisp manual (they are briefly mentioned in the Emacs manual). And on the other, if code is using (next|prev)-buffer, silently getting the same buffer is likely a subtle bug anyway. At least now they get notice. --000000000000f4a8f3059841e87a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Nov 26, 2019 at 4:42 PM Eli Zaretskii <= eliz@gnu.org> wrote:

>= ; Could that disrupt noninteractive calls?

Yes, th= at's why added the notice in NEWS in the "Incompatible Lisp Change= s".

But, on one hand, programs should perhaps be using switch-t= o-(prev|next)-buffer. AFAICS, next-buffer and previous-buffer aren't ev= en documented in the Elisp manual (they are briefly=C2=A0mentioned in the E= macs manual).

=C2=A0And on the other, if code is u= sing (next|prev)-buffer, silently getting the same buffer is likely a subtl= e bug anyway. At least now they get notice.

--000000000000f4a8f3059841e87a-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 11:01:19 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 16:01:19 +0000 Received: from localhost ([127.0.0.1]:52785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZdHD-0003gn-BE for submit@debbugs.gnu.org; Tue, 26 Nov 2019 11:01:19 -0500 Received: from mail-qk1-f177.google.com ([209.85.222.177]:46175) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZdHB-0003gb-Ev for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 11:01:17 -0500 Received: by mail-qk1-f177.google.com with SMTP id h15so16473964qka.13 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 08:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kGppk+hdXlpV9X6p8inS/7tfu1i3VJgAy9fOiZf+xZc=; b=JbF0NzHW1ArB06BDx9v0xMZXaSYNC6eY354/TXPVpmAq24lkq+OKRWypry62JGyoQu M4CSplhWATW/rK0lWRrLqE/q0d/VdOs6jaKafqSyqDv+YN6vV1LAXaqkxKHfgn/okPar +i31KSBMi2pOH8wM6kgdPTyMgk/hFvSYsiyFDlH4FljrAAbHnMnx1zbh4Bun8qvcrbiW oZRWslHJswuL41cIFjOFBNVRbAcqucR2lRc/p2jrJOxb18PnS0TKPTNUq5tKjzI1KvY5 QP7q22Lip3BTT7XwkFesjZIbQkFEJEBt1AHhV9WXbwtNCh2fQjK512VAtOvmajevyGr9 9mvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kGppk+hdXlpV9X6p8inS/7tfu1i3VJgAy9fOiZf+xZc=; b=m8bbEOpz1M9ABzqfQ6wtJrWt+oM0jIR8E8NQ3eqpjwfBKB4DcxLMvgzSDjtEeK3YTu SaQF87HvJojNVPk7fJHx380PnggAZ2a4C/Rr9ecvP98ehPYpjYKg/IfSwrS7nhZPOxf+ 3PwuP0gThTY4eNA4X8rzPvIZqa2t3GOW9wvDNVxdAvhtmN+bNKN77AG1pvBIq6UmUhf5 YqYvq/8OCkO8tjYEB1QGt/33qpTr4PRxhbKKG4tMkLeLVFTPimlNkqWpte3doIr1wrdl 47PQpMRNQSV09suOlPL+v9v16tgEM/kUPaxQEH40o2y5yBF2xYJGCrbulfiIfPyDf/sZ PiPA== X-Gm-Message-State: APjAAAXj7EliRxTJwN1XhJttOnTD0OqHVr6F6CWMnLIcQ4PAB6CPAbJv vIdn00H1cFO5MCynxBgStqLfxuh83hL1SsA3LXc/IA== X-Google-Smtp-Source: APXvYqyeWKYl7xU+pCzwbDq45sH+QckXVjojDM87Rm24/8dDGrrexccu+ajk30cp7lyNtQ0MIBSB4sfAlH/BBleeQsQ= X-Received: by 2002:a37:48d2:: with SMTP id v201mr15866663qka.277.1574784071663; Tue, 26 Nov 2019 08:01:11 -0800 (PST) MIME-Version: 1.0 References: <83lfs2sky2.fsf@gnu.org> In-Reply-To: From: Juanma Barranquero Date: Tue, 26 Nov 2019 17:00:35 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000308f2c059841fdb5" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000308f2c059841fdb5 Content-Type: text/plain; charset="UTF-8" After a cursory glance, I find only one instance of (next-buffer) called from elisp in our sources, and it's in mode-line-next-buffer. And in that case, clicking on the buffer name in the modeline and getting a message "no next buffer" seems like an improvement to me over the silent treatment ;-) --000000000000308f2c059841fdb5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
After a cursory glance, I find only one instance of (next-= buffer) called from elisp in our sources, and it's in mode-line-next-bu= ffer.=C2=A0 And in that case, clicking on the buffer name in the modeline a= nd getting a message=C2=A0"no next buffer" seems like an improvem= ent to me over the silent treatment ;-)

--000000000000308f2c059841fdb5-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:00:37 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 17:00:37 +0000 Received: from localhost ([127.0.0.1]:52843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZeCb-00056K-6V for submit@debbugs.gnu.org; Tue, 26 Nov 2019 12:00:37 -0500 Received: from mout.gmx.net ([212.227.17.22]:52707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZeCZ-000566-7M for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 12:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574787628; bh=SiRbZEKgGgzwJQyvae+GbGeMaaL75VTQoM98AqNTjxs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=IaqxAGJEJ9BPKbMZJxb9gUAp8oNSwHl6KNicDi/VFkkYB7l7muAihLJ2f16vAPr4u shJ8lE1ZUyE/3Lk/M4OC3ZrM/Vmv4c4uWKhwxpf8F3cEcEdsKehP25cQ4Gsnbc1gvA 1VdhLA4kKyPyXX1jFtYlKbBwTpYuGt4vWLG+06gY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.153]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mwwdf-1hcZKp0RlD-00yU3p; Tue, 26 Nov 2019 18:00:28 +0100 Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Juanma Barranquero , Eli Zaretskii References: <83lfs2sky2.fsf@gnu.org> From: martin rudalics Message-ID: <87f04a08-3860-07f7-17ce-e6fff7c8b456@gmx.at> Date: Tue, 26 Nov 2019 18:00:27 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:7BjQSrcPTZCIfLWkQOvNHF7L+VcmOu4WpMN5MkdVUJCvEa61iB6 mrrm02ZeDDtnBmdVpABGnTrr41awSGQ9ZFyaP9d/5B1ntobwFBuBmBgTUba9lPHc/blnDFL X71ai+NM1JnYoquYxxSZH+0TLwEtPkj4d3byKWC53w84Pgau064llwSxouvc6PcyOSjrFdI odxpClDuMwxgHoVO22eWw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:GW91G+/UxHg=:FsLtF/yO6cNcJVXWow1mW0 cMakO2RWZGPN462BDDv5mYnzRXSgoYFnNZL+yno7jyKVOiNUl3s/BUcbX3fAQbbS55sKOvCFd 37l9jzpi0WMg6abnegOJaiKkDNKZjw49xmg1DpoVfuAiLgjI23OnenJuuGmD97njDtDQWGVR4 shKocBjKDPBTuS96E3hppL5j381EzjLhTvPkAgarpjsKGZ0/WIlIsdeet8RlPWhYgY2VoBq5m QXVthw3kr4h4XNfYG8Zb+lHevUt4DRk+3UMa9LWD1EMd9l1emjI0NND7a9uGV1tqwLWoDBr24 R/SiDJD9aCy3Bo5wG8+3FGvJ6bNLuCdkhIiPioi8DaJ5f/nReWJRPCyWbnlXIZFPdFTo4XPaH fpB0jmMIuBLmqXWd1In0GXk8DTuBO8u35Xkzo9tJUJFpCR6bBJv96qlaJ+v1yzRtC0BMs/Th2 h1BjdyxTFby6kCibwR1kNk6CDoJKxtyHvtEn2wB6KfQMqQ3UnCiONHik0rWBjSJpZFFtVXRhU 7vjvc1QjfaSoxycHSs2Zu6XfcOLZAknfHu04vuE/UgBaNYTSxvt80NvnQTCilnTmWRc8D+FjK TFD5bLYmENtfkTSFqnM8cGMHHNMjURFm5uufGY3C9vKQjt2/j+8yVMez+HFMT5TKUj15kHmLl cSWRq57GAeN5uZXFpI11EKA1olE/G+dB4jRKs5W2xv31/cOwklGuikzf39A2XuJ5s6h+rAJNe wFBq/CQUTMv7iEnO6rSEoq0wTo8O1KKo0sQC7pHkDXEIMx8FaEiA/DpLmomtxpq65iBX4MJID +ixTVRzxAxPBJHhRV1ej8JT8CnUTS9JbDqDmNfsm14RPZqZbH6Xb6UE4RZivkIq0UkUc8+viR cuduXFHH0dhsR9NSmzU5CkFi/+xvBuAftFUd2XrcxKVeQYl3vvQaUzRNnIAwCep+XB1jyiI6t Lj0vdEU3XLGvug63lTVt1TxaSiS6T9zc99iO9Vk4/W6Cx1one0+baBwuUwvkg0Nb2VCdmfWc2 z38tn2crzUFlqSUgvjDLJOH+fp6B/5RD/KR1liBsjPArJyin/VEf82nV2Vne/WehC2iZ7VOtP TeqzKBusxEvaVkM7cPguZbel66tW95bHxAabuwM1UVYnJjHi2aWcONeRIwqBwkfCLvSblOiNG fGjSlZ0u0d2Ie+YJqE4ZENGi+lURBWuNiP8QSD9rRKJqwEfUb7kja66jTfStcuh4ZZU5AtTbU 0e1+Z0wN2IP/V10FQ8hQzQNvpzWrgAtoxcGUmp1DkdkvapoyoN/mISDZ/o+4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Could that disrupt noninteractive calls? > > Yes, that's why added the notice in NEWS in the "Incompatible Lisp Changes". > > But, on one hand, programs should perhaps be using > switch-to-(prev|next)-buffer. AFAICS, next-buffer and previous-buffer > aren't even documented in the Elisp manual (they are briefly mentioned in > the Emacs manual). > > And on the other, if code is using (next|prev)-buffer, silently getting > the same buffer is likely a subtle bug anyway. At least now they get notice. Right. 'previous-buffer' and 'next-buffer' are intended for interactive use only. Maybe we should add appropriate warnings to their doc-strings. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:00:49 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 17:00:49 +0000 Received: from localhost ([127.0.0.1]:52846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZeCn-00056j-FY for submit@debbugs.gnu.org; Tue, 26 Nov 2019 12:00:49 -0500 Received: from mout.gmx.net ([212.227.17.20]:45033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZeCl-00056W-9k for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 12:00:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574787640; bh=9iHVv/E2QjxK0/+M/15h8Wsz0ZHH8hewwNrQozev4kE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=h4+ia3FDEv82VQxXKEUX4Cy1lCNcHyz3ot1kQC5IOe0Lv17QHwS/nhr+B21dIhXid nyRF8IMjE8F6JGeiHfgy7ZTXBC+dnSRbNH0KVZnSp1VIjYPV+8Ar3bBztop/0FDHWN /qipomud4Fubf4d3x5UTwCjrf/nU7Pcmg3YSDCIA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.153]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2mBQ-1hoRxU277k-0136Kq; Tue, 26 Nov 2019 18:00:40 +0100 Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Juanma Barranquero , Eli Zaretskii References: <83lfs2sky2.fsf@gnu.org> From: martin rudalics Message-ID: <3fb98b78-5453-662b-a23b-548e607b543b@gmx.at> Date: Tue, 26 Nov 2019 18:00:39 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:yvwSpy8mNFRMJYNAXU0dBrXgBWHe1xVUcnDYTrPVaQnlFeF7yrm 0IyoSNQlhkB96Xu9tZAUUVlUp63F4Y+GnB+suj9tdtGcgErKU5M3FJ03m/tj9fdVhnivmjm vc6NQ37k+E6FzPmSjQ6gofp7bNHEDtiTqA9YQyuTj4MLeABfLGW0OJm37HQxqQy8gjupKFE ZUrS551LQe5mdVzG1bdRA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:smQKoqSDYZE=:FaueKyutTfUqiswq96mcLC M6yWiRS7B4V/NMBOBDTi7KsgKvTmT4qCCTIjyWyoqPRJUGxVUHwtSiAILNhm3NOWH0sis3XfW gHJ5z3RNa+yPQalaXLK6XZFT214duakamDoN8SWMn4/aKBykjGAEMv7XjcPdfbYcQbSwCFdc2 fsfih4Q1rZoy36mJpwxgGA3CFCjxB6L9itb9fWle8sWntsG5ZGiZDWO7DzQ/YrhHIKNE5IN9D JqdlumXYROuPsvsNzkWOINBVqzh+EHukn1qT8xfBkWaaVwR48cgEPjc044+RNrpd8xzYBeCkJ YkGRbbscYEMvUlHDWH6Dw+86M7qa4b4M7/UCBf1w4aeOQLbDHkHydHwAwoPJvExGPeibejNK8 lr5s6ntsUYXTv39Pbv5ZIKjGakC0uXfCBE0Mi44E65C8dBoeXlK/J5x1s9ukL6fdjyfg50SFR xGO5E0FKsbqF0/YsXZFTg6pIa/JMtWw85SJPbVIL8fk52gY33i9jaOQna1d53nXlsTF/Zm07H O9+v1lgnPGNBQKFkJzmhf9uTu+ojkISDNQ1iU6G4Z1VsjQS3EShCkpWvBkZuwLmX5ZrjkEyN/ Qf4PsEbJnwAaRrgHyZf2ie5gs9xRU2HP3272ddm4D08hM7BhRYdIW08vblSBHKaDhDtUjkBoM oZkkO2OhUWUZ0WOKMxoyVc27YgTiJgLMyxLkzGXw8yvWxuT52fl02xOnyB+rUbQDFsuomvk2p U1615ueeJJw3Px7vG1f8PM9sjncNrNSY2FEkKqOV2Qd1JeSzFd8aQBAopceqMzYzGcDEPyx+O nQGvvMTpHE/vCJ5zTeE/KQZFncKpi8QqOiWcb19CYKy8iT+A/fcUQ6pCcgCCTPxFIoQ69lFhR HsFjSEfNgnwMB5CIk0QMQA8cr2tLhAmTHWikZnlHsUB5XjX2W1O9ZtuLUzj34Yy8QAtFcNdQ5 MtkJ/RPo9amn9jluKW0tRwvlqJlPHRgZyM5zNaSespf08GsZJrARSNCS+tY9zC+rKlRx37yUf KHE0f6UgUp1XQrB5eM56WDbdY06yDTbwd+ebz3r1YuKhaKkP/i4Z1W20YsAItWRHaIdZX7Mvt 0m/GXZsRSSzxlKEUnoKvcUiJkwNVzswTaooGuOShi8HYU3avIGxehWrnepkswyhJOacj7u/qC OsF3zB0XI91zf5c1/8BwQhrh4atLT/PbIHstPn2pJGl+VlNUPhBfTSZhUDehre+EWxxM6EnrK I97vn7WAU3VXu6Hq9sbtUt1rAkq9AOmOi8bbvFDP6ZmOBT7bEphiu+u/LmM8= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > After a cursory glance, I find only one instance of (next-buffer) called > from elisp in our sources, and it's in mode-line-next-buffer. And in that > case, clicking on the buffer name in the modeline and getting a message "no > next buffer" seems like an improvement to me over the silent treatment ;-) Right again. The same holds for 'mode-line-previous-buffer'. martin From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 13:03:06 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:03:06 +0000 Received: from localhost ([127.0.0.1]:52882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfB4-0006YA-58 for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:03:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfB2-0006Xf-AO for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:03:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZfAw-0000k3-Nz; Tue, 26 Nov 2019 13:02:59 -0500 Received: from [176.228.60.248] (port=1462 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZfAv-0005dt-RG; Tue, 26 Nov 2019 13:02:58 -0500 Date: Tue, 26 Nov 2019 20:03:04 +0200 Message-Id: <83blsyseg7.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 16:54:56 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: <83lfs2sky2.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 16:54:56 +0100 > Cc: 38384@debbugs.gnu.org > > > Could that disrupt noninteractive calls? > > Yes, that's why added the notice in NEWS in the "Incompatible Lisp Changes". Then how about signaling user-error only in interactive calls? > But, on one hand, programs should perhaps be using switch-to-(prev|next)-buffer. AFAICS, next-buffer and > previous-buffer aren't even documented in the Elisp manual (they are briefly mentioned in the Emacs > manual). > > And on the other, if code is using (next|prev)-buffer, silently getting the same buffer is likely a subtle bug > anyway. At least now they get notice. IMO, if we can improve the diagnostics only in interactive invocations, we have all the advantages without any disadvantages (and can move this out of the "incompatible changes" section). From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 13:04:22 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:04:22 +0000 Received: from localhost ([127.0.0.1]:52886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfCI-0006a7-Hq for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:04:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfCH-0006Zp-69 for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:04:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZfCB-0001Jd-ND; Tue, 26 Nov 2019 13:04:16 -0500 Received: from [176.228.60.248] (port=1538 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZfC8-0004EJ-9R; Tue, 26 Nov 2019 13:04:13 -0500 Date: Tue, 26 Nov 2019 20:04:19 +0200 Message-Id: <83a78isee4.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 17:00:35 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: <83lfs2sky2.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 17:00:35 +0100 > Cc: 38384@debbugs.gnu.org > > After a cursory glance, I find only one instance of (next-buffer) called from elisp in our sources, and it's in > mode-line-next-buffer. And in that case, clicking on the buffer name in the modeline and getting a message > "no next buffer" seems like an improvement to me over the silent treatment ;-) Granted, I'm worried mainly about code outside of the Emacs tree. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 13:24:39 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:24:39 +0000 Received: from localhost ([127.0.0.1]:52916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfVu-00074f-QQ for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:24:38 -0500 Received: from mail-qk1-f176.google.com ([209.85.222.176]:41557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfVs-00074T-TV for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:24:37 -0500 Received: by mail-qk1-f176.google.com with SMTP id m125so16968806qkd.8 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 10:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fkVPv17P6PsxNgDMumS3B+1OS9aIF+1qXc/eetAybe0=; b=fpUXXnb6gzPEuqOMPeGu6By3eXWMlKsy4AcCgs6dAT1tJImNsYvvG88OjXV4B+EMJZ CBrCHnV9CrMwYjiG7md/6qAbZVbunWNcufqqEZTkXvrJ1Ynxt0RzjvPePH23xKMH8hY5 WIcg6iC4ZrSFc6VdalhCJu3DfAQn4LLQlLRg5PYNCPcrylEZdugXC37AjjbphkbSjbt0 Lgo7utPzpmOu8/Ld8KXFcTJer9hKUjL0e6tCfQlR52FWW736lQLRG4GIKw1trNbg6cdT cGmoTysoLktfbOrXL28bDqUQQriUG4u6YUzLfYaqZXDH5ktUYrYNTmsZ3tw8h07R4b2b JBYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fkVPv17P6PsxNgDMumS3B+1OS9aIF+1qXc/eetAybe0=; b=aS6bONvKQ/Lq2J6fOGOQgKvFORgokvWFC49UDpf91Hiw5+o3IaClVGqAuXTvTyoJ1O I4pRUpxVTl1xxCd0QuJnQd0yzdZeWBngsenrtVpdCYemGUy4i7X2W7svbzOXusbYxkFL GjvBidpEg9iU5KLTHKdxHwDMWhpUUPRSuNH46gbJwFcxMJQ/N+wvgFe/lsh8L51EW8Yc KlDZneQbSBkDfQ2v9CzLTn1iLlSr1SviBOpAMPK0WTtg3NF6U6VfNxuUWRle/Dhq0TkX VhDjejw4P1rS1BQTGkFuxmgYDEPyeILM96ccuczUv31jGcBnjxRrKj5x5HPE/BZRFdyy A7xA== X-Gm-Message-State: APjAAAW7YkBzNpAJMLf+OgNSlNa4bSHqVxEGYCgHa3CRL4MQ+f+NdUWu CRbq/O43pZ4YA1g3OSeAuC96mgOGyqt/mKsETlY= X-Google-Smtp-Source: APXvYqwRiSkyBSrvMyQA3ZpuK4gjkAPare/9UzdAbxM/+FjTBMJCfOCYmTvClMNlnrPzJSWXrDBa5TtNz0LZTb5Ckyg= X-Received: by 2002:a37:48d2:: with SMTP id v201mr16637103qka.277.1574792671262; Tue, 26 Nov 2019 10:24:31 -0800 (PST) MIME-Version: 1.0 References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> In-Reply-To: <83a78isee4.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 26 Nov 2019 19:23:55 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000c3ff4f059843fda3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c3ff4f059843fda3 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 26, 2019 at 7:04 PM Eli Zaretskii wrote: > Granted, I'm worried mainly about code outside of the Emacs tree. Even before my patch, both functions can in some situations signal user-error without checking for interactive use. (cond ((window-minibuffer-p) (user-error "Cannot switch buffers in minibuffer window")) ((eq (window-dedicated-p) t) (user-error "Window is strongly dedicated to its buffer")) --000000000000c3ff4f059843fda3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Nov 26, 2019 at 7:04 PM Eli Zaretskii <= eliz@gnu.org> wrote:

> Gra= nted, I'm worried mainly about code outside of the Emacs tree.

=
Even before my patch, both functions can in some situations sign= al user-error without checking for interactive use.

=C2=A0 (cond
= =C2=A0 =C2=A0((window-minibuffer-p)
=C2=A0 =C2=A0 (user-error "Cann= ot switch buffers in minibuffer window"))
=C2=A0 =C2=A0((eq (window= -dedicated-p) t)
=C2=A0 =C2=A0 (user-error "Window is strongly dedi= cated to its buffer"))


--000000000000c3ff4f059843fda3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 13:44:15 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:44:15 +0000 Received: from localhost ([127.0.0.1]:52941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfot-0007Zd-LQ for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:44:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48226) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfos-0007ZL-KP for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:44:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZfon-0002t8-EQ; Tue, 26 Nov 2019 13:44:09 -0500 Received: from [176.228.60.248] (port=3952 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZfom-0008OE-MW; Tue, 26 Nov 2019 13:44:09 -0500 Date: Tue, 26 Nov 2019 20:44:15 +0200 Message-Id: <8336eascjk.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 19:23:55 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 19:23:55 +0100 > Cc: 38384@debbugs.gnu.org > > On Tue, Nov 26, 2019 at 7:04 PM Eli Zaretskii wrote: > > > Granted, I'm worried mainly about code outside of the Emacs tree. > > Even before my patch, both functions can in some situations signal user-error without checking for interactive > use. > > (cond > ((window-minibuffer-p) > (user-error "Cannot switch buffers in minibuffer window")) > ((eq (window-dedicated-p) t) > (user-error "Window is strongly dedicated to its buffer")) I don't see how this is relevant to the issue at hand, what did I miss? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 13:52:33 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 18:52:34 +0000 Received: from localhost ([127.0.0.1]:52949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfwv-0007mY-Nl for submit@debbugs.gnu.org; Tue, 26 Nov 2019 13:52:33 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:33851) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZfwu-0007mM-4A for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 13:52:32 -0500 Received: by mail-qt1-f176.google.com with SMTP id i17so22576509qtq.1 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 10:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4nfTnMOSkuaRHr1b/C188vLOBHHPGGu2ndGU8OD0SAg=; b=tAwIxKlTDf/w6q5UtVfz2hrlTSbhSJAL4Lgfwhxv41gk+ahFuzkfspKhnUaFDriBA4 xBTjgO1T9qN3h2YjsBUJhrWME/SuOYKLTVTyAkytFKVBvJ/th2rFrUA4K3qSItAJy70A 1mflglde6B1bwHxebDLfLRiyudkxCh4D8S6niTnptpu5O3hy/9Zr0/pKe3N1duyaA8uA NxGbRyqVhl07yTPOOPd4LlPH1s+D8276KOky8fTkGHsXZF52hwU24w4AeuAe1n7Ip2sI o+Sh6y8FvCfM510phtvdFBFlWthzyhaVPhn8hu0vJVN9gHxyu8TREQsqZ6mhqmSVg3nD SgvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4nfTnMOSkuaRHr1b/C188vLOBHHPGGu2ndGU8OD0SAg=; b=Dr7jJTOIgvYi3B7/kAyxs6OBZG3pC8Zoz3VFEDSjfMQkvGoNAjL1nXJ79rLhJIxza5 KCG40/Z4X6lBHlpUkouV3s8SHFcgGWMfW8nQYcoIRlVs15O9SyHQvajw/9dXu0YiyBg5 CE0PWv7VMaWOQo+pvT0vTzh6DVMLurjrSImsTzLgfWRlRfYX5vFvADYDUs88eWOA2Cqy Pauwqym8LYW+6hnVsHttGm7JmuOIwZ6FymD9KxuoKy960hpa5nJBOO02p8jnLM/5mMxP usyS5HqAH+kXDnlyIN0JlF8e/PUOrAuA250l3RX+rvwX30nlz0ry8+/sqk/3fpLRvS3j 2vHg== X-Gm-Message-State: APjAAAWY/pUcub5ZJ2OV9wFRGKSvOx9vgEOYR2k4jp55VrcvKPtqA1mB lZtIO1q3N7MWWfYxR9LduQqf7eszKQOwdSa/oJyYVg== X-Google-Smtp-Source: APXvYqz6kZd8OvYvQuXDy6sDmLXNrLA+383Lq3401uCo4qF72QRYCCkzEQWyj+XlTynxj5D7e+ztU/TeLWYSoac+jdQ= X-Received: by 2002:ac8:230d:: with SMTP id a13mr33262621qta.354.1574794346442; Tue, 26 Nov 2019 10:52:26 -0800 (PST) MIME-Version: 1.0 References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> <8336eascjk.fsf@gnu.org> In-Reply-To: <8336eascjk.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 26 Nov 2019 19:51:50 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000009d3eb20598446184" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009d3eb20598446184 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 26, 2019 at 7:44 PM Eli Zaretskii wrote: > I don't see how this is relevant to the issue at hand, what did I > miss? Sorry, I fail to see how could it not be relevant. Lisp code calling (next|previous)-buffer already has to defend itself against a user-error. My code just adds one specific case (that of the window's buffer list having only one buffer) in which user-error is also signaled. Am I missing something? --0000000000009d3eb20598446184 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Nov 26, 2019 at 7:44 PM Eli Zaretskii <eliz@gnu.org> wrote:

> I = don't see how this is relevant to the issue at hand, what did I
>= miss?

Sorry, I fail to see how could it not be relevant. Lisp code = calling (next|previous)-buffer already has to defend itself against a user-= error. My code just adds one specific case (that of the window's buffer= list having only one buffer) in which user-error is also signaled. Am I mi= ssing something?

--0000000000009d3eb20598446184-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 14:37:03 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 19:37:03 +0000 Received: from localhost ([127.0.0.1]:52984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgdy-0000TP-Tl for submit@debbugs.gnu.org; Tue, 26 Nov 2019 14:37:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgdx-0000Sd-HL for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 14:37:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZgds-0001Os-7q; Tue, 26 Nov 2019 14:36:56 -0500 Received: from [176.228.60.248] (port=3659 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZgdr-0004th-JB; Tue, 26 Nov 2019 14:36:56 -0500 Date: Tue, 26 Nov 2019 21:37:02 +0200 Message-Id: <83y2w2qvj5.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 19:51:50 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> <8336eascjk.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 19:51:50 +0100 > Cc: 38384@debbugs.gnu.org > > > I don't see how this is relevant to the issue at hand, what did I > > miss? > > Sorry, I fail to see how could it not be relevant. Lisp code calling (next|previous)-buffer already has to defend > itself against a user-error. My code just adds one specific case (that of the window's buffer list having only one > buffer) in which user-error is also signaled. Am I missing something? We previously signaled user-error in situations where we couldn't continue at all. Your addition is in a situation where nothing particularly bad happened, so from the POV of a caller, we are now signaling a user-error gratuitously. I'm bothered only by the change whereby we signal a user-error with the purpose of attracting the user's attention, not because we cannot continue. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 14:57:26 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 19:57:26 +0000 Received: from localhost ([127.0.0.1]:53003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgxi-000104-AN for submit@debbugs.gnu.org; Tue, 26 Nov 2019 14:57:26 -0500 Received: from mail-qk1-f172.google.com ([209.85.222.172]:44606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgxg-0000zp-Mr for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 14:57:25 -0500 Received: by mail-qk1-f172.google.com with SMTP id m16so17253391qki.11 for <38384@debbugs.gnu.org>; Tue, 26 Nov 2019 11:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FF4+qYoTWfCVXzLQS1FLskTrsfWdoNTBecOo9UIIQBo=; b=bh3PXm6vkuVbAcxZlfx7vpK7EMQ5nA8mHWKO2qCYEDIB0OAjH03SkUyMJXSEPzCoo1 qI+5Sxa+WsW5VpCRgXYfXM45Xh1UjV3WseFoG71RHgxJaSjm/f8YeXIt81GMfR286dwE +zNME/q1TvzYOxlpGbF68z7+Shfp77zuKoW/p1C5Y5o4PUsBoZcbTUMln0uX8Eqb90Hq IBn+uIID/zrxEGpk80N5s8h0L649pUIkpaxSAjDazt3spWckRXPFiCnnXsdjqb9swaOk iJPFBl39j7kDXPgdJpPjKrEFSVm9OgvUz8fBG8PZ5cL0p7xp57fuWUYUpeIY2zeYqV+/ EpgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FF4+qYoTWfCVXzLQS1FLskTrsfWdoNTBecOo9UIIQBo=; b=OQnQn37a+c7NhT+1sxZjFScXUMzM1qInj5WIgQO35NXlLtTQXfveNuUnni3LJ1rhZr yUVZNajK+FQj8BhNLJDzgNNU4pYTw5Gg8mmWJHAQ+K2av8f0V5MybN58jZgJQFB6NBzd SP+zZJ2f0pzO9iJDrE1yOnO2CeWd2PYfa9UyJglR/N64aRL4r07C79uXsQEyBe2yhulr ImcY4AfpgvcWeMdb90lyjZGzKbbcmivWDi8GEzF7/PuVV5fYhNDgNvR8U15hn5HkX2c8 jWpoqXLlFXImwZrCCboQtx5r6QwsQ4vFlNokimBvpyBVAgIJuB1eAeWVMoJxkzEH0Fk9 Bvpg== X-Gm-Message-State: APjAAAW0n8unKKSQDh8494LprCcDm/oKugErKuN5kActl23xGtW/44IP tS6JFHKMoS7zDW+DtFamIdWKDZ3FSUioz02m6zU= X-Google-Smtp-Source: APXvYqzCeOyNtZsCYvtX69BZqYb4Dqba2nbTaELl7n1gLrAvLzuidQpX/rsm2rnrfkHwOKhqBqGi3Xx/tTrOMOYCX1U= X-Received: by 2002:a05:620a:11b1:: with SMTP id c17mr149150qkk.496.1574798238877; Tue, 26 Nov 2019 11:57:18 -0800 (PST) MIME-Version: 1.0 References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> <8336eascjk.fsf@gnu.org> <83y2w2qvj5.fsf@gnu.org> In-Reply-To: <83y2w2qvj5.fsf@gnu.org> From: Juanma Barranquero Date: Tue, 26 Nov 2019 20:56:42 +0100 Message-ID: Subject: Re: bug#38384: (next|previous)-buffer silent about not switching To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000009f0dd5059845499f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000009f0dd5059845499f Content-Type: text/plain; charset="UTF-8" On Tue, Nov 26, 2019 at 8:36 PM Eli Zaretskii wrote: > We previously signaled user-error in situations where we couldn't > continue at all. Your addition is in a situation where nothing > particularly bad happened, so from the POV of a caller, we are now > signaling a user-error gratuitously. I'm bothered only by the change > whereby we signal a user-error with the purpose of attracting the > user's attention, not because we cannot continue. I don't really see much difference. In the two cases that already signal user-error, "continuing" would mean doing nothing; there would be no other bad consequence. In the case I've changed, continuing means the same: doing nothing. In all three cases, signaling, instead of continuing, is purely to attract the user's attention. In my opinion, such code should call switch-to-(prev|next)-buffer instead. Anyway, there's no point in arguing this; if you feel strongly that the last case should depend on called-interactively-p, I'll change it. But I think we should instead leave it as it is and educate code writers to use the documented calls instead of the user-level commands. --0000000000009f0dd5059845499f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Nov 26, 2019 at 8:36 PM Eli Zaretskii <eliz@gnu.org> wrote:

> We pr= eviously signaled user-error in situations where we couldn't
> co= ntinue at all.=C2=A0 Your addition is in a situation where nothing
> = particularly bad happened, so from the POV of a caller, we are now
> = signaling a user-error gratuitously.=C2=A0 I'm bothered only by the cha= nge
> whereby we signal a user-error with the purpose of attracting t= he
> user's attention, not because we cannot continue.

I = don't really see much difference.

In the two cases that already = signal user-error, "continuing" would mean doing nothing; there w= ould be no other bad consequence. In the case I've changed, continuing = means the same: doing nothing. In all three cases, signaling, instead of co= ntinuing, is purely to attract the user's attention.

= In my opinion, such code should call switch-to-(prev|next)-buffer instead.<= br>
Anyway, there's no point in arguing this; if you feel strongly t= hat the last case should depend on called-interactively-p, I'll change = it. But I think we should instead leave it as it is and educate code writer= s to use the documented calls instead of the user-level commands.
--0000000000009f0dd5059845499f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 15:07:39 2019 Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 20:07:39 +0000 Received: from localhost ([127.0.0.1]:53019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZh7a-0001GT-QU for submit@debbugs.gnu.org; Tue, 26 Nov 2019 15:07:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZh7Z-0001GH-7x for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 15:07:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZh7U-0003Ya-4E; Tue, 26 Nov 2019 15:07:32 -0500 Received: from [176.228.60.248] (port=1547 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZh7R-0007tG-AN; Tue, 26 Nov 2019 15:07:29 -0500 Date: Tue, 26 Nov 2019 22:07:35 +0200 Message-Id: <83tv6qqu48.fsf@gnu.org> From: Eli Zaretskii To: Juanma Barranquero In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 20:56:42 +0100) Subject: Re: bug#38384: (next|previous)-buffer silent about not switching References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> <8336eascjk.fsf@gnu.org> <83y2w2qvj5.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38384 Cc: 38384@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 20:56:42 +0100 > Cc: 38384@debbugs.gnu.org > > > We previously signaled user-error in situations where we couldn't > > continue at all. Your addition is in a situation where nothing > > particularly bad happened, so from the POV of a caller, we are now > > signaling a user-error gratuitously. I'm bothered only by the change > > whereby we signal a user-error with the purpose of attracting the > > user's attention, not because we cannot continue. > > I don't really see much difference. Well, I do. > Anyway, there's no point in arguing this; if you feel strongly that the last case should depend on > called-interactively-p, I'll change it. Please do, and thanks. From unknown Mon Jun 23 02:24:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Dec 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator