GNU bug report logs - #38381
27.0.50; Bump Gnus version to 5.14, properly encode group names on disk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38381 in the body.
You can then email your comments to 38381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Bump Gnus version to 5.14, properly encode group names on
 disk
Date: Mon, 25 Nov 2019 15:56:55 -0800

[Message part 1 (text/plain, inline)]

As part of switching Gnus group names to fully-decoded strings, I left
some code (really horrible code) in place to make sure that the group
names stayed in their previous encoding in Gnus' save files, so that
people running Emacs from git builds could switch back and forth without
worrying about the save files becoming unreadable. Right now, there are
several routines in place that decode non-ascii group names on file
read, and re-encode them on file write. This only has an effect on
non-ascii group names.

Now Emacs 27.1 is on its way, and I would really like to make this
change permanent. The attached patch moves all the ugly compatibility
code into an upgrade routine as part of `gnus-convert-old-newsrc'. Users
will be prompted once to upgrade, and then the various files will be
fixed to use properly encoded group names, and you won't be able to go
back.

Again, this only affects users who had non-ascii group names to begin with.

[0001-Encode-Gnus-group-names-properly-on-disk-bump-Gnus-v.patch (text/x-patch, attachment)]

Message #8 received at 38381 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 38381 <at> debbugs.gnu.org
Subject: Re: bug#38381: 27.0.50; Bump Gnus version to 5.14, properly encode
 group names on disk
Date: Tue, 26 Nov 2019 01:02:37 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Now Emacs 27.1 is on its way, and I would really like to make this
> change permanent. The attached patch moves all the ugly compatibility
> code into an upgrade routine as part of `gnus-convert-old-newsrc'. Users
> will be prompted once to upgrade, and then the various files will be
> fixed to use properly encoded group names, and you won't be able to go
> back.

I don't think that's a good idea.  The .newsrc.eld file should remain
backwards compatible -- people do move back and forth between newer and
older versions of Emacs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 38381 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38381 <at> debbugs.gnu.org
Subject: Re: bug#38381: 27.0.50; Bump Gnus version to 5.14, properly encode
 group names on disk
Date: Mon, 25 Nov 2019 16:50:11 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Now Emacs 27.1 is on its way, and I would really like to make this
>> change permanent. The attached patch moves all the ugly compatibility
>> code into an upgrade routine as part of `gnus-convert-old-newsrc'. Users
>> will be prompted once to upgrade, and then the various files will be
>> fixed to use properly encoded group names, and you won't be able to go
>> back.
>
> I don't think that's a good idea.  The .newsrc.eld file should remain
> backwards compatible -- people do move back and forth between newer and
> older versions of Emacs.

Okay, but there is a whole upgrade mechanism in place that's
specifically for upgrading the .newsrc.eld file to a new version, so
this wouldn't be the first time it's happened.

That said, the current situation seems to be working fine; if we've got
to keep it, we've got to keep it. I'd like to keep this bug report open,
though.

Eric

Message #14 received at 38381 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 38381 <at> debbugs.gnu.org
Subject: Re: bug#38381: 27.0.50; Bump Gnus version to 5.14, properly encode
 group names on disk
Date: Tue, 26 Nov 2019 02:11:45 +0100

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Okay, but there is a whole upgrade mechanism in place that's
> specifically for upgrading the .newsrc.eld file to a new version, so
> this wouldn't be the first time it's happened.

It's only been used once, back in...  what...  1996?  (There's other
converters for agentey stuff, but that's not very impactful.)  And if I
remember correctly, it wasn't backwards-incompatible...  just
forwards-incompatible.

> That said, the current situation seems to be working fine; if we've got
> to keep it, we've got to keep it. I'd like to keep this bug report open,
> though.

If we're not going to do conversion like that, I don't see much point in
keeping the bug report open?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 38381 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38381 <at> debbugs.gnu.org
Subject: Re: bug#38381: 27.0.50; Bump Gnus version to 5.14, properly encode
 group names on disk
Date: Mon, 25 Nov 2019 20:26:40 -0800

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Okay, but there is a whole upgrade mechanism in place that's
>> specifically for upgrading the .newsrc.eld file to a new version, so
>> this wouldn't be the first time it's happened.
>
> It's only been used once, back in...  what...  1996?  (There's other
> converters for agentey stuff, but that's not very impactful.)  And if I
> remember correctly, it wasn't backwards-incompatible...  just
> forwards-incompatible.
>
>> That said, the current situation seems to be working fine; if we've got
>> to keep it, we've got to keep it. I'd like to keep this bug report open,
>> though.
>
> If we're not going to do conversion like that, I don't see much point in
> keeping the bug report open?

One can hope...

Never mind.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.