GNU bug report logs - #38370
26.2; Confusing message 'Hunk already applied' in diff-mode

Previous Next

Package: emacs;

Reported by: ndame <emacsuser <at> freemail.hu>

Date: Mon, 25 Nov 2019 21:33:40 UTC

Severity: minor

Tags: fixed

Found in version 26.2

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 38370 <at> debbugs.gnu.org, ndame <emacsuser <at> freemail.hu>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode
Date: Fri, 21 Aug 2020 02:32:56 +0300
>>> Yeah, I've always found that messaging to be confusing and worrisome, as
>>> if I had entered a command to change the source code instead of just
>>> moving around in it.
>>
>> Hmm... I liked having that information without having to remember how to
>> run `diff-test-hunk`.  I agree it was more harmful than useful when moving
>> around as in the OP's case, but it was handy when using RET.
>
> Hm...  perhaps we should just change the message instead so it doesn't
> sound so much like a warning?  For instance...  Uhm...  No, I can't
> think of anything short that can't be interpreted as warning right
> now...

Maybe add this message to the default value of 'ignored-messages'
from bug#42865.  Then it could be easily removed with

  (delete-from-list 'ignored-messages "^Hunk already applied")




This bug report was last modified 4 years and 276 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.