From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 08:11:53 2019 Received: (at submit) by debbugs.gnu.org; 25 Nov 2019 13:11:53 +0000 Received: from localhost ([127.0.0.1]:47886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZE9g-0005tb-Iu for submit@debbugs.gnu.org; Mon, 25 Nov 2019 08:11:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:56950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZE9e-0005tT-JF for submit@debbugs.gnu.org; Mon, 25 Nov 2019 08:11:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40069) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZE9Z-0001Ag-6O for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 08:11:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZE9X-00011E-Sp for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 08:11:44 -0500 Received: from fmfe26.onbox.hu ([46.107.16.231]:50362 helo=web-out.onbox.hu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZE9V-0000qI-Rb for bug-gnu-emacs@gnu.org; Mon, 25 Nov 2019 08:11:43 -0500 X-fm-smtp-source: yes Received: from localhost (localhost [94.21.75.79]) by web-out.onbox.hu (Postfix) with SMTP id 47M6qk2krNzQ9x for ; Mon, 25 Nov 2019 14:11:30 +0100 (CET) From: ndame Message-ID: Subject: 26.2; Confusing message 'Hunk already applied' in diff-mode MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_7115_2016646518.1574687408095" To: "bug-gnu-emacs@gnu.org" X-AccountId: 57978162 X-Originating-Ip: 94.21.75.79 Date: Mon, 25 Nov 2019 14:11:30 +0100 (CET) X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrudeiuddghedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpucfhtffggffotefknfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhkffugggtvfhiffesrgdtregstddtjeenucfhrhhomhepnhgurghmvgcuoegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhuqeenucfkphepleegrddvuddrjeehrdejleenucfrrghrrghmpehhvghloheppdhinhgvthepleegrddvuddrjeehrdejledpmhgrihhlfhhrohhmpegvmhgrtghsuhhsvghrsehfrhgvvghmrghilhdrhhhupdhrtghpthhtohepsghughdqghhnuhdqvghmrggtshesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/relaxed; t=1574687490; s=20181004; d=freemail.hu; h=From:Message-ID:Subject:MIME-Version:Content-Type:To:Date; l=2325; bh=KiQ30sSqUqnxtc68HWbOOqsrDBWo8T/uOj9Kx1PATsc=; b=fpk4+OzfBsfCqK/Q7WX2dGOs5AX4r6txS2JOPmminIWY/WRTi+qnmb7MqyBWk6lw 4TzOyYpdkXEllTuWDulOwsBtz3keieqtrkRXpqNYqbH2VJnXitI93epstEIZp4Lg9tG JQa1khXnC8XFFnLsk4uGHe55VGTjh2XDm1I21rg07oSu+a2CqZWjbml1cDR8O2UzxpZ EMerqsEHAEBUmC/4Ck3mmFtQF5hGwbCSXk4SV3OvEwN0yRaTv1t6EO9RsxcP45HaQ5L pVN2roeXAZsDcRpfZa7u2yZrEnjdzJ9N3rGd3BianXKvWlhURR0q13hVEmo8WOZeyiT rmP6WOrGmA== X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 46.107.16.231 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ------=_Part_7115_2016646518.1574687408095 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Recently I turned on next-error-follow-minor-mode in diff buffers, so the source context is shown automatically as I move around in the diff buffer. It works well, but after a while I noticed there is always a 'Hunk already applied' message in the echo area. I investigated and turns out the message comes from here: =C2=A0 =C2=A0 next-error =C2=A0 =C2=A0 next-error-function =C2=A0 =C2=A0 diff-next-error =C2=A0 =C2=A0 diff-goto-source =C2=A0 =C2=A0 diff-hunk-status-msg So goto source prints this message every time, even if one just presses RET in a diff buffer. I found it confusing, because I was just moving around, I didn't try to apply anything, so this message wasn't really informative, it stopped my flow with its unwanted appearance and reference to an other operation. Shouldn't this 'Hunk already applied' message appear only if the user actually tries to apply something? ------=_Part_7115_2016646518.1574687408095 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Recently I turned on next-error-follow-minor-mode in diff buffers, so
the source context is shown automatically as I move around in the diff
buffer.

It works well, but after a while I noticed there is always a 'Hunk
already applied' message in the echo area.

I investigated and turns out the message comes from here:

    next-error
    next-error-function
    diff-next-error
    diff-goto-source
    diff-hunk-status-msg


So goto source prints this message every time, even if one just
presses RET in a diff buffer.

I found it confusing, because I was just moving around, I didn't try
to apply anything, so this message wasn't really informative, it
stopped my flow with its unwanted appearance and reference to an other
operation.

Shouldn't this 'Hunk already applied' message appear only if the user
actually tries to apply something? ------=_Part_7115_2016646518.1574687408095-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 20 10:55:07 2020 Received: (at 38370) by debbugs.gnu.org; 20 Aug 2020 14:55:07 +0000 Received: from localhost ([127.0.0.1]:43400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8ly7-0003QS-82 for submit@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8ly5-0003PP-SS for 38370@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fs6h3q8BXn4A3kPsyJHGfQC3tlki1sG3KrnTwa5Wz7Y=; b=aDP/LCkr1I2efVvG0psXv6qu46 io6hBqW9R/y85nS5lyTMkZxiT44ECD6JbQnRZ+7rA4HAl63pqb4rg7p+2AMf9RUQavNW0oGrF5LyR WSM5lKAEOOSA4lj35TnJidHhYdp5rlUg5jFZ0rlDG8ZJTk+c3RtWqn3rdhAf0uKJTuRI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8lxt-0004iy-BJ; Thu, 20 Aug 2020 16:54:59 +0200 From: Lars Ingebrigtsen To: ndame Subject: Re: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode References: X-Now-Playing: Ved Buens Ende...'s _Written in Waters_: "Coiled In Wings" Date: Thu, 20 Aug 2020 16:54:51 +0200 In-Reply-To: (ndame's message of "Mon, 25 Nov 2019 14:11:30 +0100 (CET)") Message-ID: <871rk1tlj8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: ndame writes: > Recently I turned on next-error-follow-minor-mode in diff buffers, so > the source context is shown automatically as I move around in the diff > buffer. > > It works well, but after a while I notice [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38370 Cc: 38370@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ndame writes: > Recently I turned on next-error-follow-minor-mode in diff buffers, so > the source context is shown automatically as I move around in the diff > buffer. > > It works well, but after a while I noticed there is always a 'Hunk > already applied' message in the echo area. [...] > I found it confusing, because I was just moving around, I didn't try > to apply anything, so this message wasn't really informative, it > stopped my flow with its unwanted appearance and reference to an other > operation. > > Shouldn't this 'Hunk already applied' message appear only if the user > actually tries to apply something? Yeah, I've always found that messaging to be confusing and worrisome, as if I had entered a command to change the source code instead of just moving around in it. I've now removed it. Looking at the code in diff-mode, as far as I can see, the actual "apply" functions will still output the hunk status. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 20 10:55:14 2020 Received: (at control) by debbugs.gnu.org; 20 Aug 2020 14:55:14 +0000 Received: from localhost ([127.0.0.1]:43403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8lyD-0003Qk-F8 for submit@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8lyB-0003QL-Ns for control@debbugs.gnu.org; Thu, 20 Aug 2020 10:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SYLsL8VqYBrfnwMFv1WAMuYTzXKWvcrR3doQ/yL6nzY=; b=G+sCzWQ/ZWy5MFIbIqXAL1ObLd k1vY/GnxIHIDS3EGkWBGUgaVJCtQV3cXeqwn83BMkvrKuRYYhTYXrbWnnnmgEgaof0LDUSoYrL0Tp oTEMlSAyQ3Zf6jDnF4SR+HCn7+rsqLlD15gvHz/QNrZL7waCGjywHvmt6asSc31Hidzo=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8ly3-0004jD-T8 for control@debbugs.gnu.org; Thu, 20 Aug 2020 16:55:06 +0200 Date: Thu, 20 Aug 2020 16:55:02 +0200 Message-Id: <87zh6ps6yh.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38370 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38370 fixed close 38370 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38370 fixed close 38370 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 20 11:30:02 2020 Received: (at 38370) by debbugs.gnu.org; 20 Aug 2020 15:30:02 +0000 Received: from localhost ([127.0.0.1]:43570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mVu-0000R9-CR for submit@debbugs.gnu.org; Thu, 20 Aug 2020 11:30:02 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mVs-0000QG-JJ for 38370@debbugs.gnu.org; Thu, 20 Aug 2020 11:30:00 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0A4B71003BD; Thu, 20 Aug 2020 11:29:55 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 251641003B4; Thu, 20 Aug 2020 11:29:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1597937393; bh=FAvnJMnb2UUm9yOhem3sAsNDKxsVObnWFmYWMCgmzgw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NO76wIYGrwS2golb9nHGnhzai8XI2LiRmr62eLhlGnrneVy1X47viHNz7D6qGuia2 +/yqW9snBeFspU1udZaTjORBjxzOjrdW8lbqQQoWZzrJ1K/6NfCCXpXV5qjCvg4fov clpI2T125wQ6pXl6+oIb9Aqghzy8ufI4FULBSQZmbhJGxA0nntEzU9sUKcpozb1ih3 sWirm9HitcgfC9TaHVjCglnoKtFFAzI+Gvwa3vogZoLdbanZbFhlx0OhrYzJXi5DNR gRsM6c0HubHHu3mLWI1Carwne4rfN9TLdEk2lbBJuQ8nutXkRoipb8iw3KP+E4pvYG qIcXzFZo/8lXw== Received: from alfajor (unknown [45.72.246.108]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB84C1204C0; Thu, 20 Aug 2020 11:29:52 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode Message-ID: References: <871rk1tlj8.fsf@gnus.org> Date: Thu, 20 Aug 2020 11:29:51 -0400 In-Reply-To: <871rk1tlj8.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Aug 2020 16:54:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38370 Cc: 38370@debbugs.gnu.org, ndame X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Yeah, I've always found that messaging to be confusing and worrisome, as > if I had entered a command to change the source code instead of just > moving around in it. Hmm... I liked having that information without having to remember how to run `diff-test-hunk`. I agree it was more harmful than useful when moving around as in the OP's case, but it was handy when using RET. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 20 11:44:08 2020 Received: (at 38370) by debbugs.gnu.org; 20 Aug 2020 15:44:08 +0000 Received: from localhost ([127.0.0.1]:43586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mjX-0000mN-Jn for submit@debbugs.gnu.org; Thu, 20 Aug 2020 11:44:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8mjQ-0000lg-8b for 38370@debbugs.gnu.org; Thu, 20 Aug 2020 11:44:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4zYW1rnLHdeoMhI0LgseJR0o4z44MjHryx9i6ihsuoU=; b=F5xGPzrVJxUbQ9kl6PkQjPmG56 /q+aXDZCJgC/P8DIMxx+bqcLfhL9riU2RcYeJV2DfPNWHudVkOoNSzX0QhXNDcLiyEyYQwPg5KVvR fOv+nSJ/fJ/DFLXhOrlLpgrjmf+ZQq/gCvlhrOO7cpRzZ5cd0VLlUprl+y+V6Ls2h4OY=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8mjG-0005HC-D5; Thu, 20 Aug 2020 17:43:53 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode References: <871rk1tlj8.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEUySCyxqa3c2dL1 8epATTvFw72mmqSViJWHeYZmWWaBcn5EOEYhHCT///97BQpkAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QIFA8pIa15sLUAAAFvSURBVDjLrdRBUsIwFAbgLjiAxbHoThu8ANWDIMPoFhno2nGGgrpxVTrs oaFcgPECZF4u0EkO5UuwkrRUXfh3l2/ea5u81nGcpq9CSMcv0nZ0ekE5Bbil9AoIIzvPdTD8G8wx x2CeUErXcQWmCQUARrUMbw6QZFIFtBgwpVwtA4g0tmC20QWCS5bawOWXCGxmQKJWWaaYVUCk4UcF triSv/utjRQK2hbsSHD1ihVzE/BpxSMexAN2XBmAryGWBOGeV4Cpc+x4XObWPRZ8pwqCLr6htYkL YMchAd2qi63SEsCI4C3OpYgtmGV8OcD5uNjD5R5IGL1knKXeWf9N5pEFUwoClgPcElaCLe5sDkLC yoZIHbnaYRaXAA8d1DSkehJNwGYI6/34mKAGiNL4CCB9T2IJDrP7K3iuNzZzuocGqXxqRUUNNH6A 29UkfBq3JkN35LpNs8In1/pbx8snf2lVA0ENOAP9O+gfcnfi/Gs+AejfWZ5yZIrMAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTA4LTIwVDE1OjQxOjMzKzAwOjAwsV28FwAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0wOC0yMFQxNTo0MTozMyswMDowMMAABKsAAAAASUVORK5CYII= X-Now-Playing: Panoptique Electrical's _Quiet Ecology_: "Upon A Map" Date: Thu, 20 Aug 2020 17:43:48 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 20 Aug 2020 11:29:51 -0400") Message-ID: <87d03ls4p7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> Yeah, I've always found that messaging to be confusing and worrisome, as >> if I had entered a command to change the source code instead of just >> moving around in it. > > Hmm... I liked having th [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38370 Cc: 38370@debbugs.gnu.org, ndame X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: >> Yeah, I've always found that messaging to be confusing and worrisome, as >> if I had entered a command to change the source code instead of just >> moving around in it. > > Hmm... I liked having that information without having to remember how to > run `diff-test-hunk`. I agree it was more harmful than useful when moving > around as in the OP's case, but it was handy when using RET. Hm... perhaps we should just change the message instead so it doesn't sound so much like a warning? For instance... Uhm... No, I can't think of anything short that can't be interpreted as warning right now... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 20 19:43:47 2020 Received: (at 38370) by debbugs.gnu.org; 20 Aug 2020 23:43:47 +0000 Received: from localhost ([127.0.0.1]:44447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8uDi-0007yM-Lj for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:43:47 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:36063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8uDg-0007y8-9R for 38370@debbugs.gnu.org; Thu, 20 Aug 2020 19:43:45 -0400 X-Originating-IP: 91.129.102.47 Received: from mail.gandi.net (m91-129-102-47.cust.tele2.ee [91.129.102.47]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id AE21E1C0002; Thu, 20 Aug 2020 23:43:35 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#38370: 26.2; Confusing message 'Hunk already applied' in diff-mode Organization: LINKOV.NET References: <871rk1tlj8.fsf@gnus.org> <87d03ls4p7.fsf@gnus.org> Date: Fri, 21 Aug 2020 02:32:56 +0300 In-Reply-To: <87d03ls4p7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 20 Aug 2020 17:43:48 +0200") Message-ID: <87d03kj33z.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 38370 Cc: 38370@debbugs.gnu.org, ndame , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Yeah, I've always found that messaging to be confusing and worrisome, as >>> if I had entered a command to change the source code instead of just >>> moving around in it. >> >> Hmm... I liked having that information without having to remember how to >> run `diff-test-hunk`. I agree it was more harmful than useful when moving >> around as in the OP's case, but it was handy when using RET. > > Hm... perhaps we should just change the message instead so it doesn't > sound so much like a warning? For instance... Uhm... No, I can't > think of anything short that can't be interpreted as warning right > now... Maybe add this message to the default value of 'ignored-messages' from bug#42865. Then it could be easily removed with (delete-from-list 'ignored-messages "^Hunk already applied") From unknown Sat Jun 21 05:18:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 18 Sep 2020 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator