GNU bug report logs - #38320
Cuirass: Allow to use authenticated Git repositories as inputs

Previous Next

Full log

Message #58 received at 38320 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 38320 <at> debbugs.gnu.org, Erik Edrosa <erik.edrosa <at> gmail.com>,
 Clément Lassieur <clement <at> lassieur.org>
Subject: Re: bug#38320: Cuirass: Allow to use authenticated Git repositories
 as inputs
Date: Wed, 05 Feb 2020 22:24:42 +0100

Hi!

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> Here's a version with optional authentication support. I do not find it
> too intrusive, but let me know what you think!

Yup, looks good!

> From 4554baf59564eb0c31cfe235acd078d54afef6d7 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <m.othacehe <at> gmail.com>
> Date: Mon, 3 Feb 2020 18:05:02 +0100
> Subject: [PATCH] git: Add ssh authentication support.
>
> SSH agent authentication method is used.
>
> * guix/git.scm (auth-method): New variable,
> (clone*): pass previous variable in clone options,
> (update-cached-checkout): pass previous variable in fetch options.

[...]

> +;; Default authentication method.
> +(define auth-method (and auth-supported?
> +                         (%make-auth-ssh-agent)))

Perhaps we should not call it at the top level, in case it throws an
exception or has unwanted side effects?  I’d suggest moving it to
the procedures where it’s used.  Thoughts?

Apart from that it LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.