GNU bug report logs - #38301
[PATCH 0/4] Allow for multiple '--manifest' options

Previous Next

Package: guix-patches;

Reported by: Ludovic Courtès <ludo <at> gnu.org>

Date: Wed, 20 Nov 2019 13:43:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38301: closed ([PATCH 0/4] Allow for multiple '--manifest'
 options)
Date: Fri, 22 Nov 2019 14:17:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 22 Nov 2019 15:15:48 +0100
with message-id <874kyw80a3.fsf <at> gnu.org>
and subject line Re: [bug#38301] [PATCH 4/4] pack: Allow multiple '--manifest' options.
has caused the debbugs.gnu.org bug report #38301,
regarding [PATCH 0/4] Allow for multiple '--manifest' options
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38301: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38301
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Konrad Hinsen <konrad.hinsen <at> fastmail.net>,
 Pierre Neidhardt <mail <at> ambrevar.xyz>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH 0/4] Allow for multiple '--manifest' options
Date: Wed, 20 Nov 2019 14:42:13 +0100
Hello Guix!

As discussed on guix-devel, this patch series ensures that one can
pass multiple ‘--manifest’ options to ‘guix package’, ‘guix pack’,
and ‘guix environment’ (which already supported it actually!).

Feedback welcome!

Ludo’.

Ludovic Courtès (4):
  environment: Document that '--manifest' can be repeated.
  profiles: Add 'concatenate-manifests'.
  package: Allow multiple '--manifest' options.
  pack: Allow multiple '--manifest' options.

 doc/guix.texi             |  9 ++++---
 guix/profiles.scm         |  5 ++++
 guix/scripts/pack.scm     | 17 +++++++++----
 guix/scripts/package.scm  | 50 ++++++++++++++++++++-------------------
 tests/guix-environment.sh | 23 ++++++++++++++++++
 tests/guix-pack.sh        | 11 +++++++++
 tests/guix-package.sh     | 13 ++++++++++
 tests/profiles.scm        |  5 ++++
 8 files changed, 101 insertions(+), 32 deletions(-)

-- 
2.24.0



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: brettg <at> posteo.net, Konrad Hinsen <konrad.hinsen <at> fastmail.net>
Cc: Pierre Neidhardt <mail <at> ambrevar.xyz>, 38301-done <at> debbugs.gnu.org
Subject: Re: [bug#38301] [PATCH 4/4] pack: Allow multiple '--manifest' options.
Date: Fri, 22 Nov 2019 15:15:48 +0100
Hi,

brettg <at> posteo.net skribis:

> At last! This feature is going to be available.
>
> These patches LGTM!

Konrad Hinsen <konrad.hinsen <at> fastmail.net> skribis:

> Looks good. And very nice to have!

Pushed!

  ca541f9ce6 pack: Allow multiple '--manifest' options.
  bf9206d8ed package: Allow multiple '--manifest' options.
  ce30a0eb7e profiles: Add 'concatenate-manifests'.
  d76df98fa5 environment: Document that '--manifest' can be repeated.

Thanks for your feedback,
Ludo’.


This bug report was last modified 5 years and 184 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.