From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 03:57:06 2019 Received: (at submit) by debbugs.gnu.org; 20 Nov 2019 08:57:06 +0000 Received: from localhost ([127.0.0.1]:48964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXLnL-0004aS-0h for submit@debbugs.gnu.org; Wed, 20 Nov 2019 03:57:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:37626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXLnJ-0004a3-Lp for submit@debbugs.gnu.org; Wed, 20 Nov 2019 03:57:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37814) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXLnI-0002a3-CP for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:57:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXLnF-0003Et-TO for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:57:00 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:50520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXLnD-00037y-LK for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2019 03:56:56 -0500 Received: by mail-wm1-x32b.google.com with SMTP id l17so6107665wmh.0 for ; Wed, 20 Nov 2019 00:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=c7hG6Ch/G92qcCTc6TNkznR3sjDS0WaJOPFJq41eOvA=; b=tDwLyy3H5Rxvg39GuP04aKsPZrA3MuwR1LdDr5oxd31SU+nEbZlKGFGr1G7z13KGmp 7URxaTEm6BRwH/0eJ56VZusm5oaZ07vkgkNc1GJROomnfPgphC/eE0Ne4WblnfqQcHMh vaCRAFoAYfGd5tuMk4/s830jlIFVCbyiW6pislvyX+URBYNgfEjCY8h4nBAKDRKupU88 atJbe0ESvCy/hRDjbxXkseB4aupM/4jV95AWr8xSzsxmbAZL37xbe2DjT5Mm/6nSkykx p+CZd8F0UZS811/yhZ7MjCiKmTCptfbZgXpSb/4fvqpu2R66gOlOQm5iUn+VBxLHaR6d hD5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=c7hG6Ch/G92qcCTc6TNkznR3sjDS0WaJOPFJq41eOvA=; b=BdEQT+yvog81GXQ42DRpJN194jxDDmcx2CYO16kD9lbdq9KGIxhHsNd5NEHTpK+nyR a6qHE7EOJa43LoxiJBhQKxlDnf48QU5mNzziD4k3UbyT+8vX1g/jgdB1Z/8esnHKdSPw Fu1FosLmMSh/wSc6XIl+hCsQVfe9zmfPJ9uR63HorB6WP0e/Bss51PM9i9jHCtd1oxl6 ZI1yh+AD2JyzZjvidROxm0TY0UCmjmyh52+2S25pSBYbOw1/yCjJyAI4cYtZ+FPANI2L o1fdZMDJEodXSeeQc8rk/RieawRKHzZeOqf7okLk9MhaTHB3PE4FgSWLferaWPuwo1Gp gyAA== X-Gm-Message-State: APjAAAVltCJU99PBD9567DsgBsnJ6cRClD6OBhKfwvyc4FTiLhTHDsZp P2WEi2cIr3IwJRGeyMalyJMDLU4y X-Google-Smtp-Source: APXvYqyO4CAATQFYVa8l/jmpqikD4pEkoaLMy8O7tZboiSwXxY6Wf92BDPx7lCeGYz9C7zmfe3Q3Sw== X-Received: by 2002:a05:600c:2253:: with SMTP id a19mr1799018wmm.97.1574240211447; Wed, 20 Nov 2019 00:56:51 -0800 (PST) Received: from ZALANDO-31298 ([185.85.220.254]) by smtp.gmail.com with ESMTPSA id d7sm30885720wrx.11.2019.11.20.00.56.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 00:56:50 -0800 (PST) From: Dario Gjorgjevski To: bug-gnu-emacs@gnu.org Subject: [PATCH] Handle killing of virtual buffers in Ido Date: Wed, 20 Nov 2019 09:56:43 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Currently, =E2=80=98ido-kill-buffer=E2=80=99 does essentially nothing to vi= rtual buffers. (They are visited and then immediately killed.) The attached patch changes that so that they are instead removed from =E2=80=98recentf-l= ist=E2=80=99, akin to =E2=80=98ido-kill-buffer-at-head=E2=80=99. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Handle-killing-of-virtual-buffers-in-Ido.patch Content-Description: Handle killing of virtual buffers in Ido >From 4295cac14ea280d43c0aa493520543aa403a4c2e Mon Sep 17 00:00:00 2001 From: Dario Gjorgjevski Date: Wed, 20 Nov 2019 09:34:58 +0100 Subject: [PATCH] Handle killing of virtual buffers in Ido To: bug-gnu-emacs@gnu.org * lisp/ido.el (ido-buffer-internal): Handle killing of virtual buffers as a special case. (ido-visit-buffer): Document the special case. --- lisp/ido.el | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lisp/ido.el b/lisp/ido.el index 79f259b819..bf3f57883d 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -2286,7 +2286,10 @@ ido-buffer-internal ((and ido-enable-virtual-buffers ido-virtual-buffers (setq filename (assoc buf ido-virtual-buffers))) - (ido-visit-buffer (find-file-noselect (cdr filename)) method t)) + (if (eq method 'kill) + (setq recentf-list + (delete (cdr filename) recentf-list)) + (ido-visit-buffer (find-file-noselect (cdr filename)) method t))) ((and (eq ido-create-new-buffer 'prompt) (null require-match) @@ -4128,6 +4131,8 @@ ido-visit-buffer (setq buffer (buffer-name buffer))) (let (win newframe) (cond + ;; "killing" of virtual buffers is handled in + ;; `ido-buffer-internal' ((eq method 'kill) (if record (ido-record-command 'kill-buffer buffer)) -- 2.17.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 13:41:16 2020 Received: (at 38294) by debbugs.gnu.org; 20 Jan 2020 18:41:16 +0000 Received: from localhost ([127.0.0.1]:46032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itbz5-0006Hd-G7 for submit@debbugs.gnu.org; Mon, 20 Jan 2020 13:41:16 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:33444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itbz0-0006Gy-0U for 38294@debbugs.gnu.org; Mon, 20 Jan 2020 13:41:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oD2xRiu35UiBmZC1ALz5gZHrSu204R+j5r6XZ4zlyZc=; b=r/lzVkM82XeIj+c1QzcCHyXzCw jg+hY6gLXWODA3+RuLQ0Y+jKdoxvxkpJQ+rf2408XQ5Qiv9McbDGzOu4OMaz9rtdGCGwO4hR/iUwa ToHbLgFngGkcD32/O98NBJNKmlG1Poubv8gnU3G8GyMWt+89HDTSrugRbWIcWae/01c2OVc9CrGMW 1F4aWlB2M9QO6SEtEdNKX3EjNwBeYcumc0Hx7vjsVag93eJyTJJBAVmcY7G66isXCOQ6IX4ky4dx0 +98MTsHCuDn/ia99TA2cdtdMrT5P3rLiBft+JJXHDmp83YEbfCWLihERZiPj8z3FsgP4ipyh0GV5z pEGgB/bQ==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:54546 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itbyu-001kTF-5P; Mon, 20 Jan 2020 13:41:00 -0500 From: Stefan Kangas To: Dario Gjorgjevski Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido In-Reply-To: (Dario Gjorgjevski's message of "Wed, 20 Nov 2019 09:56:43 +0100") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 20 Jan 2020 19:40:57 +0100 Message-ID: <87a76it1hi.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: > Currently, =E2=80=98ido-kill-buffer=E2=80=99 does essentially nothing to = virtual > buffers. (They are visited and then immediately killed.) The attached > patch changes that so that they are instead removed from =E2=80=98recentf= -list=E2=80=99, > akin to =E2=80=98ido-kill-buffer-at-head=E2=80=99. I noticed that you have gotten no reply here. Could you please describe what problem it is you are solving, is this fixing a bug or adding a new feature? How can I test that this code works as advertised, preferably starting from "emacs -Q"? Please give a step by step description, including a description of what happens before and after applying your patch. Thanks in advance. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 03:21:40 2020 Received: (at 38294) by debbugs.gnu.org; 22 Jan 2020 08:21:40 +0000 Received: from localhost ([127.0.0.1]:48939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuBGd-0008MD-Ot for submit@debbugs.gnu.org; Wed, 22 Jan 2020 03:21:40 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:33252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuBGc-0008Lw-Qf for 38294@debbugs.gnu.org; Wed, 22 Jan 2020 03:21:39 -0500 Received: by mail-wr1-f53.google.com with SMTP id b6so6265843wrq.0 for <38294@debbugs.gnu.org>; Wed, 22 Jan 2020 00:21:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=ULotQItEuXeDnJaOSZ+z7JjNIoJj8RQ5EoGcEh5tgYc=; b=Dys0120FvZERDfSY965vqyJu7xV/0SXpYNJD82CEWfzKMzbDyc1iwkGDAsLszZIUdz ff67E9KRriWTXu6TRLham6JWguCLOMuhCoSse6YZDNJbg70YdLSDg3iWOFYpFFFJsgT1 0eeIuZT61O2OOTKlgJHjVyMltR6HDVRooLiHhyxr/UdvsX2bY+2uorklTsTj5ncjLZGC lz5HL3AZDevJgHoitPdOscs/2PAQ1+DaT48w7+5vTEf0j2O8IIZ0fE4ICg+CsVvK+N05 MfYwnVOzkrqwQaKMCnygx6DMuaqLkQjbRnZUi99OuKm2pFNFvJjwtX3Uo5gDuTJjCqUJ nIjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=ULotQItEuXeDnJaOSZ+z7JjNIoJj8RQ5EoGcEh5tgYc=; b=se/DejVP14KN/2f/VisIMBmRWIa0MzePdnH3wI5bQy8/CcKiXZeCjE2nIPxOEtSdhH BnBNK8n8mMcVLs/mgriSeOJMXnjq3//ezmFez7wQbVCtFZxTx9xoo0uGL+qBbw84z51t AK3KDhtkAmNuQCTl45MvlaHSXAZQv9mHcQtH0X94Oy7RTAEfMKxBp1QXXICm02U+9EDT z0SYah9IF7Nws4G5kk2qPmYyBEPo0yDCUC1F05Z9kKT0T1f22OlQQ1fkxf3c97FfCBdR WIJLCWru6XAcmW7JsVhrEDY4kZV4JQTUakj/Yv58RYaY1AiuJRfueCD83EO8286sS7ah x1zA== X-Gm-Message-State: APjAAAWgmrO7GhP9+tqNVIBjDRGPw5TxXMBM9+/PwwRbpmxyli+gHbcx LZNR2FRnRCJoaBDefRJrBLTuTb/M X-Google-Smtp-Source: APXvYqyqEpCj7fDdqmPXQDT4VwBJ2v+js+euWBcdjUEZcGYbMCRFqirfKNp+4KVN5v2eSL2ZaWPt1w== X-Received: by 2002:a05:6000:367:: with SMTP id f7mr9682295wrf.174.1579681292504; Wed, 22 Jan 2020 00:21:32 -0800 (PST) Received: from ZALANDO-31298 ([185.85.220.254]) by smtp.gmail.com with ESMTPSA id z11sm472224wmg.30.2020.01.22.00.21.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Jan 2020 00:21:31 -0800 (PST) From: Dario Gjorgjevski To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> Date: Wed, 22 Jan 2020 09:21:30 +0100 In-Reply-To: <87a76it1hi.fsf@marxist.se> (Stefan Kangas's message of "Mon, 20 Jan 2020 19:40:57 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, Thanks a lot for getting back to me. > I noticed that you have gotten no reply here. Could you please > describe what problem it is you are solving, is this fixing a bug or > adding a new feature? I would say this neither fixes a bug nor introduces a new feature; merely makes =E2=80=98ido-kill-buffer=E2=80=99 behave as I expect it to. > How can I test that this code works as advertised, preferably starting > from "emacs -Q"? Please give a step by step description, including a > description of what happens before and after applying your patch. What follows is a way to reproduce this scenario, assuming the file =E2=80=98foo=E2=80=99 does not exist. Start by M-x recentf-mode M-x ido-mode M-: (setq ido-use-virtual-buffers t) C-x C-f foo C-x C-s C-x k Now, =E2=80=98foo=E2=80=99 is a _virtual buffer_ in the terminology of Ido,= and since we have =E2=80=98ido-use-virtual-buffers=E2=80=99 set to t, we should be able = to operate on it: switch to it or kill it. Switching works fine; however, *killing is a no-op*. At this point, when you do C-x k foo you will notice that =E2=80=98foo=E2=80=99 remains in the list of buffers, = despite being =E2=80=9Ckilled.=E2=80=9D You will still see when doing C-x b or C-x k. I= n fact, you can repeat the above step ad infinitum. What this patch changes is exactly this behavior: once a virtual buffer has been =E2=80=9Ckilled=E2=80=9D from C-x k, it no longer appears in the l= ist of buffers. Let me know if this makes sense. Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371' From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 04:00:36 2020 Received: (at 38294) by debbugs.gnu.org; 22 Jan 2020 09:00:36 +0000 Received: from localhost ([127.0.0.1]:48971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuBsK-0000wS-Fr for submit@debbugs.gnu.org; Wed, 22 Jan 2020 04:00:36 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:46584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iuBsI-0000wF-IM for 38294@debbugs.gnu.org; Wed, 22 Jan 2020 04:00:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GQccKrFT7rcBga6eVDNhLINzNdGaxUYOG/RTVa8lmFA=; b=W8HbwoTrDefiL5EoGcxdHmCB7p 8CL815kEQ6NCq9pO05IYo03U+XlK7XTu5abW6A6ZzPbw734Y7m1uW2XVF2tXO1MurOp+rPIl6xRzI Ou/ykuW649+qbmTAXJtEbZuSiWu338vIEQu6oVoPQIbQvz5GPBMdPOFlP5QhAi/YrXeOaeeGagpVy tX9m/EK1OC4NkC4I68vQ9THnjhTMP9W7YxXAI8plTyKAczqIrBjkbxkXj09pQARZS00i9i8tqc/Ku 5uJ4pqpzBDFueTx9WUzHnr+aU/Xl+qD3UGB3QP65W/niJORmiz3AJc0umrmslr3FAPZLHIfdezrMd 4fO9fKqA==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52530 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iuBsA-000WNL-7U; Wed, 22 Jan 2020 04:00:26 -0500 From: Stefan Kangas To: Dario Gjorgjevski Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido In-Reply-To: (Dario Gjorgjevski's message of "Wed, 22 Jan 2020 09:21:30 +0100") References: <87a76it1hi.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Wed, 22 Jan 2020 10:00:24 +0100 Message-ID: <87wo9jkgrb.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dario, Dario Gjorgjevski writes: > What follows is a way to reproduce this scenario, assuming the file > =E2=80=98foo=E2=80=99 does not exist. > > Start by > > M-x recentf-mode > M-x ido-mode > M-: (setq ido-use-virtual-buffers t) > C-x C-f foo > C-x C-s > C-x k > > Now, =E2=80=98foo=E2=80=99 is a _virtual buffer_ in the terminology of Id= o, and since we > have =E2=80=98ido-use-virtual-buffers=E2=80=99 set to t, we should be abl= e to operate on > it: switch to it or kill it. Switching works fine; however, *killing is > a no-op*. > > At this point, when you do > > C-x k foo > > you will notice that =E2=80=98foo=E2=80=99 remains in the list of buffers= , despite being > =E2=80=9Ckilled.=E2=80=9D You will still see when doing C-x b or C-x k. = In fact, you > can repeat the above step ad infinitum. Thank you for the detailed explanation. > What this patch changes is exactly this behavior: once a virtual buffer > has been =E2=80=9Ckilled=E2=80=9D from C-x k, it no longer appears in the= list of > buffers. > > Let me know if this makes sense. I think the current behaviour makes sense, but I can very much see that some users would want what you suggest. Both choices here are valid. Given that Ido has behaved like this for a long time, I would be wary of changing the default behaviour at this point. It risks surprising users. My suggestion would theferefore be to add a new option to enable the behaviour you suggest. It could perhaps be named something like ido-kill-removes-virtual-buffers, and should be disabled by default. What do you think? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 14 21:25:19 2020 Received: (at control) by debbugs.gnu.org; 15 Apr 2020 01:25:20 +0000 Received: from localhost ([127.0.0.1]:35025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOWnn-0005X9-Ky for submit@debbugs.gnu.org; Tue, 14 Apr 2020 21:25:19 -0400 Received: from mail-qk1-f179.google.com ([209.85.222.179]:38733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jOWnl-0005Ww-DY for control@debbugs.gnu.org; Tue, 14 Apr 2020 21:25:17 -0400 Received: by mail-qk1-f179.google.com with SMTP id o19so8314737qkk.5 for ; Tue, 14 Apr 2020 18:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=YrFNMfRp5vvnaVqCbwm146LEJXx4/25or/Yo5rvEGUM=; b=jr9tH2T8fADoIYnZwqQWWIhj8wIpzDHaLyMVG8nqkHhUOYVIzZQAKZvB3C00a6rng2 oSQ65sXCGpu+QbX+wiZ/lX53ldz3FgZodyT10k6i2Zsj2II18nl10qNLaaBjfwZ/yDXf BvVsVxkx8i/r9RSDSOn2DTVfJ0JP7/0DGlDz/X+VyJI2oYNBfx7H9ckUk26zG3GVGeJz 9LlMNne7qKiJW74wzVgdOxdarfb2Kb4zv3sH3V9rcbqt/1lcuZrhad80QePPcQDoFRfz ci9yjoneTwJD/xxbhOsRN1HPJZOWiyNGKYq0NZSa0rdunkgu2pEQo9a6qi1JITVCpAGD 9I6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=YrFNMfRp5vvnaVqCbwm146LEJXx4/25or/Yo5rvEGUM=; b=pL/ZE0jtJlffMiI268OxaijStAxN5c0xD8r1ihy+GgadhplIrO/3mCGzqg9V84aORA tZ0Dp/AAWEUWs6SRltXf9rVuttU3TFFHxu2or9ESyXLwZFFItc4ueNvdIvA4soDshWSv 6GmqNyvek6EE5CSk+Xy/in0hBEAn4yQrNzk2bcLKxBhZdmicLDbXcyM7ShD6b13QgbKX cREdeT4BhRa0tMdJCv/wLTMaCwfL7deKYDIPzQc3FvAP3B+6Y+FHZ6XILN5IYwNNigG0 VlC9lWDwYejev4B0cITFT2X51wJly8W8q8C18ly9vMbWhDNvnrAaUyvdC+K5izyhdbTi DISg== X-Gm-Message-State: AGi0PubZPtaqn2WKyIwPgUMFs4EgRYOiwKhfV1owv0/qMVnknfopekfM geTdH1FQd3WAf8GMwKZZyNVcfb6b X-Google-Smtp-Source: APiQypKaoJ4vYI4pVoBYntAln5ZlEUMKRH2cFjrvEmxKJTy7yiwfaT1oaV1UfK++a1o+xY9gZsNupw== X-Received: by 2002:a05:620a:16d0:: with SMTP id a16mr22646300qkn.300.1586913911800; Tue, 14 Apr 2020 18:25:11 -0700 (PDT) Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id u15sm12214515qte.91.2020.04.14.18.25.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Apr 2020 18:25:11 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #38665 Date: Tue, 14 Apr 2020 21:25:05 -0400 Message-ID: <871rop4k26.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) severity 38665 wishlist severity 39185 wishlist severity 38294 wishlist severity 37847 wishlist # patch causes some problems tags 15998 - patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 09 09:20:34 2020 Received: (at 38294) by debbugs.gnu.org; 9 Aug 2020 13:20:34 +0000 Received: from localhost ([127.0.0.1]:60357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lFa-0002JT-HK for submit@debbugs.gnu.org; Sun, 09 Aug 2020 09:20:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4lFW-0002JB-Mp for 38294@debbugs.gnu.org; Sun, 09 Aug 2020 09:20:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qTSBcyveXCRAOxKCDncVFi+tSqSo6gOQMSdsOBBPQ+U=; b=qhSujf/i26l0Cq4e4rzbJI77jx TudjmGXLzwX0GD6xkIF1VkkQgSVIlWYdiQ8zrOsW71nZjBzD9/95O3tSjRNjfhfG7GZtkLKV/Hk9S yK2BYZi/2/la3ELQMjKdviFOUAC4y0XWzcS5N7FZxjpH/w78/X/lWOCbYPGPr51h3r2s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4lFL-0002K0-CF; Sun, 09 Aug 2020 15:20:22 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> Date: Sun, 09 Aug 2020 15:20:17 +0200 In-Reply-To: <87wo9jkgrb.fsf@marxist.se> (Stefan Kangas's message of "Wed, 22 Jan 2020 10:00:24 +0100") Message-ID: <874kpcrm5q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: >> What this patch changes is exactly this behavior: once a virtual buffer >> has been “killed” from C-x k, it no longer appears in the list of >> buffers. >> >> Let me know if this makes sense. > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Dario Gjorgjevski , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: >> What this patch changes is exactly this behavior: once a virtual buffer >> has been =E2=80=9Ckilled=E2=80=9D from C-x k, it no longer appears in th= e list of >> buffers. >> >> Let me know if this makes sense. > > I think the current behaviour makes sense, but I can very much see > that some users would want what you suggest. Both choices here are > valid. I think so, too, but I don't use this combination of features, so I'm not sure. It does seem natural that killing a buffer would remove it from the list of buffers ido-mode offers up, though, so I'm not totally sure whether any ido users really expect this behaviour, or if they've just lived with it as a bug. Any opinions here? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 18:01:27 2020 Received: (at 38294) by debbugs.gnu.org; 12 Aug 2020 22:01:27 +0000 Received: from localhost ([127.0.0.1]:45755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5yoI-0004Ha-QE for submit@debbugs.gnu.org; Wed, 12 Aug 2020 18:01:27 -0400 Received: from mail-yb1-f170.google.com ([209.85.219.170]:37515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5yoG-0004HB-8H for 38294@debbugs.gnu.org; Wed, 12 Aug 2020 18:01:25 -0400 Received: by mail-yb1-f170.google.com with SMTP id e14so2200372ybf.4 for <38294@debbugs.gnu.org>; Wed, 12 Aug 2020 15:01:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=C4xK/r5eQIBuywKScjftpCQ/3G1tla5ApGmbe71svXo=; b=aLI/nQdr9nSLG+l2rfP3UpSegjXd6mj2zFlDhKFQKokHAEhAFhWSGrdyrcWdi0ft1U 3hENA1c6nvy4v9/MHIgchJ2o0eM+D1BlGAK4x+RWU5hfXL5W1VLLy51A7pXax+GO2wUN aN+qiDPczgX2XnTNJGEXJHcRNimxlE+YTDuu/UTnO7uZM2dW/20VMdFCcV2uMJWZKHTU Ygr/kMJdhOAr1FaSgjCvQwCc8qxbkuF1MLU5OBstvP1dCXjY7+KCP/umuwoEyIDqWsnG UeiZDr3NWHMMPK8/FzG7V72el1/U+yjaWPCzwO7XuKRo5exKFeA/DZqpoFgUhhegnaGE 7Bzg== X-Gm-Message-State: AOAM531KDTRLCi515//AQ5hBy/kHpF9P7TUtfxkoVCFSKM406iHPClah ilZVM5W+Uki2nUplZE0YtMO163IsUxRvC+D0JBE= X-Google-Smtp-Source: ABdhPJwVYHtPVuAdE4wucS3kSYJ/lAd8DbbmrWgeQbOZGeOIlziCBac8fl0m5oUzJi1KeTJ8maKQcAI9Vq7J6AP+D/o= X-Received: by 2002:a25:880e:: with SMTP id c14mr2185504ybl.181.1597269678386; Wed, 12 Aug 2020 15:01:18 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Aug 2020 15:01:18 -0700 From: Stefan Kangas In-Reply-To: <874kpcrm5q.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> MIME-Version: 1.0 Date: Wed, 12 Aug 2020 15:01:17 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Dario Gjorgjevski , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Stefan Kangas writes: > >>> What this patch changes is exactly this behavior: once a virtual buffer >>> has been =E2=80=9Ckilled=E2=80=9D from C-x k, it no longer appears in t= he list of >>> buffers. >>> >>> Let me know if this makes sense. >> >> I think the current behaviour makes sense, but I can very much see >> that some users would want what you suggest. Both choices here are >> valid. > > I think so, too, but I don't use this combination of features, so I'm > not sure. > > It does seem natural that killing a buffer would remove it from the list > of buffers ido-mode offers up, though, so I'm not totally sure whether > any ido users really expect this behaviour, or if they've just lived > with it as a bug. > > Any opinions here? The idea specifically with ido-use-virtual-buffers (from reading its doc string, not from being a user) is that one shouldn't have to worry about whether or not the buffer is open or not. To my mind, that implies that it means that even when manually killing buffers, I should still be able to switch to it. (It also seems a bit too surprising to now change the long-standing default behaviour.) However, if some users specifically want this behaviour only for auto-cleaned buffers (e.g. by midnight), I don't see why we couldn't provide it optionally. Anyways, I don't know if there is anything useful in the above or if I'm just rambling. I agree that it would be good to hear the opinion of someone else who actually uses this. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 04:16:57 2020 Received: (at 38294) by debbugs.gnu.org; 13 Aug 2020 08:16:57 +0000 Received: from localhost ([127.0.0.1]:46711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68Px-0002QR-Gp for submit@debbugs.gnu.org; Thu, 13 Aug 2020 04:16:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68Ps-0002Hf-EW for 38294@debbugs.gnu.org; Thu, 13 Aug 2020 04:16:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zLA8cESZQM12Uftnlf+/0yYHeD/1gzZQHSe086bXGHg=; b=afwnvlk7yP5dead5kjsbsa6NA9 X/IEzpZgJ8VLS9lauiA+lTZGEB2myRkSyppDQ5JLHL72g9fhcziwZJPiTsGSyEX7do5/0LEh4L+RR 92WjqxcSA4GoeEsOzMDX3+KqZBsjjcIijhZN1eXHxQ5si3HfSBKkjK2HgdZA9YNuwqVg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k68Pe-0003tl-Uu; Thu, 13 Aug 2020 10:16:45 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> Date: Thu, 13 Aug 2020 10:16:37 +0200 In-Reply-To: (Stefan Kangas's message of "Wed, 12 Aug 2020 15:01:17 -0700") Message-ID: <87imdnhsey.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > The idea specifically with ido-use-virtual-buffers (from reading its doc > string, not from being a user) is that one shouldn't have to worry about > whether or not the buffer is open or not. To my [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Dario Gjorgjevski , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > The idea specifically with ido-use-virtual-buffers (from reading its doc > string, not from being a user) is that one shouldn't have to worry about > whether or not the buffer is open or not. To my mind, that implies that > it means that even when manually killing buffers, I should still be able > to switch to it. > > (It also seems a bit too surprising to now change the long-standing > default behaviour.) Yeah, that sounds reasonable. The only question is whether manual killing should be handled differently than automatic killing (i.e., by midnight.el). But... that would be a kinda finicky interface, with C-x k working one way, and indirect calls to it another. So I agree with you that this is probably not something we want.... > However, if some users specifically want this behaviour only for > auto-cleaned buffers (e.g. by midnight), I don't see why we couldn't > provide it optionally. An option for something as obscure as this seems like overkill. > Anyways, I don't know if there is anything useful in the above or if I'm > just rambling. I agree that it would be good to hear the opinion of > someone else who actually uses this. It would. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 04:38:06 2020 Received: (at 38294) by debbugs.gnu.org; 13 Aug 2020 08:38:06 +0000 Received: from localhost ([127.0.0.1]:46788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68kQ-0005od-DE for submit@debbugs.gnu.org; Thu, 13 Aug 2020 04:38:06 -0400 Received: from mail-yb1-f179.google.com ([209.85.219.179]:33444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68kO-0005o9-D9 for 38294@debbugs.gnu.org; Thu, 13 Aug 2020 04:38:04 -0400 Received: by mail-yb1-f179.google.com with SMTP id p191so2910284ybg.0 for <38294@debbugs.gnu.org>; Thu, 13 Aug 2020 01:38:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=4VYiqvlZgnLbKc5u4XsCAfNQxX/p2FTVZG1RfrI/oLI=; b=qNsC9L7ykWLATKAEvBLWmVNKcXV4b8LcKlKWjOrLUC0VBPuICe9rNbjEwLQa5SXM/4 s66pEHHrZbkvWFU9lrtEnH0Au0Ryi8jZagfSqIPSqW/UlowocpPs+pcxZ0TCSH7IcQ64 oR2w1i79sN6M4QHuwcLWawkbbBeaA6NFxpedFVufMuFrmaMpNFsfPYEKKD/afa4U5+10 6PUwKMez91TU0MNK685ZtvJw0MWanke28zNqXo/IC0hYZg3Xmuy0s5YSmCHgr8nAcZ6o lZd6S0vbGjkz6CCyE7ZF9XSgjLmcnsqApjA/GlvyyTKMnNpxRHpSjaDwdj0HBREDozwY IrQA== X-Gm-Message-State: AOAM532OvvSicCFgn0flPpCojuOTgPx4fV4KcR71fgB6OeVqtpAqfZhc 9cxkwB+v7Chmq9h4UIqkPizseC8ljMEMYUJvKPc= X-Google-Smtp-Source: ABdhPJyXQKkzpRENEmUdPw1DugI/sixJkKFuEgl+NzDR9Fi/knsh0oC0uJj9qXYSCoraerNs0KKgJ4CKEpSCLIELIYA= X-Received: by 2002:a25:880e:: with SMTP id c14mr4973227ybl.181.1597307878960; Thu, 13 Aug 2020 01:37:58 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 01:37:58 -0700 From: Stefan Kangas In-Reply-To: <87imdnhsey.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87imdnhsey.fsf@gnus.org> MIME-Version: 1.0 Date: Thu, 13 Aug 2020 01:37:58 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Dario Gjorgjevski , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > An option for something as obscure as this seems like overkill. Agreed. >> Anyways, I don't know if there is anything useful in the above or if I'm >> just rambling. I agree that it would be good to hear the opinion of >> someone else who actually uses this. > > It would. :-) I guess we could give it N more weeks or days for anyone to chime in before closing this as wontfix. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 04:39:23 2020 Received: (at 38294) by debbugs.gnu.org; 13 Aug 2020 08:39:23 +0000 Received: from localhost ([127.0.0.1]:46795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68le-0005qx-VJ for submit@debbugs.gnu.org; Thu, 13 Aug 2020 04:39:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k68ld-0005qj-6X for 38294@debbugs.gnu.org; Thu, 13 Aug 2020 04:39:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SmUMvz033RC+Y29avEXCDJKAmd1y2OgdR7YuqKkdHfM=; b=E9GCc+8sCUFqrucQwhqKn3qTV3 DNI/gUYLEwYFMOF5+O2I7pAXinam3CfBHknMIEaXgtMZ5lhiASMnFVc/LQbhdsQPJRDlTFV+DoUE+ tva4ov0wDnVpM91gq+IVPgXfluclSRitCh0pjsadpyoFUZyou/YCf66uy8eSCzoVfNqw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k68lU-000455-5i; Thu, 13 Aug 2020 10:39:14 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87imdnhsey.fsf@gnus.org> Date: Thu, 13 Aug 2020 10:39:10 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 13 Aug 2020 01:37:58 -0700") Message-ID: <878sejhrdd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I guess we could give it N more weeks or days for anyone to chime in > before closing this as wontfix. Yup. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Dario Gjorgjevski , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I guess we could give it N more weeks or days for anyone to chime in > before closing this as wontfix. Yup. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 05:50:20 2020 Received: (at 38294) by debbugs.gnu.org; 13 Aug 2020 09:50:21 +0000 Received: from localhost ([127.0.0.1]:46944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69sK-0001t8-Nb for submit@debbugs.gnu.org; Thu, 13 Aug 2020 05:50:20 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:43652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k69sH-0001sp-Hu for 38294@debbugs.gnu.org; Thu, 13 Aug 2020 05:50:19 -0400 Received: by mail-ed1-f53.google.com with SMTP id cq28so3701580edb.10 for <38294@debbugs.gnu.org>; Thu, 13 Aug 2020 02:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=DM8+e0IvwXilGl48ZGqoLw2xUWtjoE1TIPmNBWuhQFM=; b=vUQu0vrVXdKd2GCVLBxjw+9G50/zQaolRbNASwhWvzp76q6DDivIZSHQ4cEfHEZlyJ 7XXSWZnYnIZAAOsYz0kabyciXCutqYej0FYYwlKhEpJUjrHcdptSj57REMuS/PFgwTZ2 IbualRRh3N0Sr8uIpR43v0rLF2ufizM3fDY1r6Li219f+fD5912590EE64m8S5wskVSz kIuS3l4UxjFqas6dATjZNnHTTFeWQLb8mmJytLM7Z0C4BTofbdgqxACv7LUukDdKj8lT idIQBX+UkghwFE0q1FC+Cm3X7SMrjVkXc9DH3GHxi1CDcEEpUyIEtpuBVz+lVzY/Vg5/ +gug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=DM8+e0IvwXilGl48ZGqoLw2xUWtjoE1TIPmNBWuhQFM=; b=UwAGQwKjNax5OrhfEyIsNiiXC9AoAEY2CEzm0cLM2ggJbXZO6sX5yBQx5slg+oTzFx u/kWQkhBP5c9fTY0wRUQ5U8wbrvHNytgdMnhpbTeYpyXPd4DCBTvGpJvDEjXBUEk5dum 3VeilMnZ15K+PN3TLPREBjL4GBJeCANwbqCuvmKvdf97MzDunKAkBBvceEbIg/vr/T2k pHrNMzzIbDXlrkB4ecy1unp4GfGiSoNWuvCiWNcbQMW/7ASuDT+YTDnXG7A//b04oYj5 aXZ50Si9KbqnIaaKuZWRbVDf6r4lFd+AWY1XfG35QMeBrHycVzJI15mzC7otVBFBg+/Q 6OYA== X-Gm-Message-State: AOAM533jbjh8hUJzlqLYecQHPeE9pKTrkNYMBbkXdGvfl+Nu5IgIlIZE 3uL2qBZtXmJcx2VLAFdiCMyd/92Q X-Google-Smtp-Source: ABdhPJw6yovYNYcbdRj3l9he5+6scA8ZF9ZEMxZPvBD3sVtURuYW/5S856/Qm/MnllzZr531dgUNmQ== X-Received: by 2002:a05:6402:13d9:: with SMTP id a25mr3915268edx.141.1597312211346; Thu, 13 Aug 2020 02:50:11 -0700 (PDT) Received: from ZALANDO-31298 ([79.140.114.121]) by smtp.gmail.com with ESMTPSA id c7sm3173762edf.1.2020.08.13.02.50.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Aug 2020 02:50:10 -0700 (PDT) From: Dario Gjorgjevski To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> Date: Thu, 13 Aug 2020 11:50:10 +0200 In-Reply-To: (Stefan Kangas's message of "Wed, 12 Aug 2020 15:01:17 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, hi Lars, > The idea specifically with ido-use-virtual-buffers (from reading its doc > string, not from being a user) is that one shouldn't have to worry about > whether or not the buffer is open or not. To my mind, that implies that > it means that even when manually killing buffers, I should still be able > to switch to it. I agree with this. In that case, should we prevent virtual buffers from being listed in =E2=80=98ido-kill-buffer=E2=80=99 in the first place? Sele= cting one of them to be =E2=80=9Ckilled=E2=80=9D results in a no-op anyway, so why give = people the impression that something happens? Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371' From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 13 07:04:25 2020 Received: (at 38294) by debbugs.gnu.org; 13 Aug 2020 11:04:25 +0000 Received: from localhost ([127.0.0.1]:47119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6B21-0006Yz-EI for submit@debbugs.gnu.org; Thu, 13 Aug 2020 07:04:25 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:44493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6B1z-0006Yi-4w for 38294@debbugs.gnu.org; Thu, 13 Aug 2020 07:04:24 -0400 Received: by mail-yb1-f182.google.com with SMTP id i10so3065497ybt.11 for <38294@debbugs.gnu.org>; Thu, 13 Aug 2020 04:04:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=qhi3tet/Jfkdm94DZvOfcfuBJ+XcewCP7IalwI148UQ=; b=qjaZv7GJi3XlcjO8HNaARjJrplsuTUvOyjcWsvqmezARV2HN4Wu/mgAW26mXOj3iv5 3T/6QoKjEGzHlYnXT7Tekcu/UkvzJt9ugyOWUeeYrPstqE4q6PbdglNQkB3jJZzTs2T3 xVZ9lnGYVqzXgVz6eHq87ftlNIm4z63o88DK8GmgpFELP55uQpc72nf5bplDv7OKDAo4 xZ7U2xCVXRMCpqDrH/IKLtXfgbg29a5b7kHidg3By6fC7/zEAAu3b2vDk+pAlgazPntM 5ZuyrPl66DLI5jV9Q2I/uxIWWy4GxIq8fhSTL02nb5nPydy7Hth3UAED/13lHjIAdSdp tBrQ== X-Gm-Message-State: AOAM5327uBk2eWMx24QJTTLaHf/xdNQP4b/lEhfNzSQ4eX2NClmwNau5 acqcX9FvLz/q453/1uc2mKIO2QGukVkUBs156UE= X-Google-Smtp-Source: ABdhPJwb9xyniKcwfa15QfjCU3hNoPoPqZ/qNHjT/zpYxEBI+Muh04+gpvvMna+Sfl5lUYF6Hm/H/JJ8w0qF87sN27g= X-Received: by 2002:a25:b88b:: with SMTP id w11mr5944988ybj.129.1597316656948; Thu, 13 Aug 2020 04:04:16 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Aug 2020 04:04:16 -0700 From: Stefan Kangas In-Reply-To: References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> MIME-Version: 1.0 Date: Thu, 13 Aug 2020 04:04:16 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Dario Gjorgjevski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: > I agree with this. In that case, should we prevent virtual buffers from > being listed in =E2=80=98ido-kill-buffer=E2=80=99 in the first place? Se= lecting one of > them to be =E2=80=9Ckilled=E2=80=9D results in a no-op anyway, so why giv= e people the > impression that something happens? Killing it isn't a no-op though. When you kill it, you get prompted to save changes, it runs hooks in the background, presumably removes it from active memory, other functions will no longer be able to just switch to it, etc., etc. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 05:23:56 2020 Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 09:23:56 +0000 Received: from localhost ([127.0.0.1]:51824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6VwK-0000Wp-8G for submit@debbugs.gnu.org; Fri, 14 Aug 2020 05:23:56 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:45396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6VwF-0000WW-AG for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 05:23:55 -0400 Received: by mail-ej1-f43.google.com with SMTP id c16so9194906ejx.12 for <38294@debbugs.gnu.org>; Fri, 14 Aug 2020 02:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=vhxfXmu3nz8zQ4vBZFZoTkMBXKGjDdzwkha/pDMa+j0=; b=ob8CSxrUGc9sH662mFEviyNwXbCpDLrZMw7stq//KZArX13LG08b5jVLfVlB1jMmJZ kG1YTRk0E7ClYlnN6BI311Mguz3Rn05tlNH7wJF00ozb8rbgJTL2TtlVbZMHIaWOelyw a4UMAm/9vIwT/yA627w8oznvTezF9LgUDVyux+K27z8cmeZbACVdmM6P6yFH21hudgns UObd+aQ+prOl3APtNWvxEy7DHsflhO5HdFNEx61KJ96PJd+VmvMJk3lJD1pOyJc5KzEo YD/Sp/OmFabpZuMppWEghDcqXuCkifD5J/tckhbAnhddzTTGyyiglis3E1wR/Xzw0hiD c0+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=vhxfXmu3nz8zQ4vBZFZoTkMBXKGjDdzwkha/pDMa+j0=; b=faFDmWjMQy0grJQ//fnao3KsQEesYGeVuIMen6mCMuPRtN0axINM/HCXNsLqor8QAt T8MftCPhiT9762+baySp6ROFZ6bt4JkrmJ/twdZx20Feeutgoo546rlbQ6CKw0YL9C6y 1TOFNCEyueKnciEweAkgH72m+t9Q0UhQa+asGMioVS9NkvL+RRPYPOHeZFZcbdXcKrwq nrF1ywZtngC7LGUzpPSPWpiUjFmQmCDZCjgRmhsz1tllVE8Ypwm5zezUiWZYDo+B8fsU 7+YjWT2s5VIXtzOfUE2OHNJgh6luTo+xgUULtQ8GKHsix2NzFMLb776TNW+POM9Exch5 EWJw== X-Gm-Message-State: AOAM533N4egK8aDTYfLNJjotIe3iDO3AsCr/iuPq/IZy2yaMBdZApoUg rEvO7zJARp7z50531+ppaPl8hbs8fuI= X-Google-Smtp-Source: ABdhPJw47I5lltUf4IHmCLA5iSjqQTu/08Fj3nUiaThHSAi/9a/u1ln7wZ6tWJznu6wkDbrmWojdPQ== X-Received: by 2002:a17:906:4aca:: with SMTP id u10mr1505718ejt.320.1597397025041; Fri, 14 Aug 2020 02:23:45 -0700 (PDT) Received: from ZALANDO-31298 ([79.140.115.173]) by smtp.gmail.com with ESMTPSA id v5sm5986064ede.13.2020.08.14.02.23.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Aug 2020 02:23:44 -0700 (PDT) From: Dario Gjorgjevski To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> Date: Fri, 14 Aug 2020 11:23:43 +0200 In-Reply-To: (Stefan Kangas's message of "Thu, 13 Aug 2020 04:04:16 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Stefan, > Killing it isn't a no-op though. When you kill it, you get prompted to > save changes, it runs hooks in the background, presumably removes it > from active memory, other functions will no longer be able to just > switch to it, etc., etc. Point taken. In that case, my only complaint would be that =E2=80=98ido-kill-buffer-at-head=E2=80=99 does treat killing a virtual buff= er as removing it from =E2=80=98recentf-list=E2=80=99 (just as suggested here), s= o there is some inconsistency. However, I can live with it. Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371' From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 07:01:10 2020 Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 11:01:10 +0000 Received: from localhost ([127.0.0.1]:51951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XSQ-0001Hm-Ai for submit@debbugs.gnu.org; Fri, 14 Aug 2020 07:01:10 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40208) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6XSO-0001HX-OH for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 07:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GXzvfBgR1ktcLf4eOsLP1ygHwkfnFGQvnsTT6y07wh4=; b=lpRGaQjt9h5gJdZf9mx1L+FPEM 3MwRweR7EG3zTN59KGYrF3DkuluJfVGFWd5DdjMYnCmYvLhQYuiMOLjpt1kSP8KUoUrJt3DlF+ORq CGxAklG2bGn4K6N7pRUwIJzuoJ4zhnUGTgGvUbwYo984tfcJ6VqcLYpuj4wezrwEKX2s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6XSE-00011s-8e; Fri, 14 Aug 2020 13:01:01 +0200 From: Lars Ingebrigtsen To: Dario Gjorgjevski Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> Date: Fri, 14 Aug 2020 13:00:56 +0200 In-Reply-To: (Dario Gjorgjevski's message of "Fri, 14 Aug 2020 11:23:43 +0200") Message-ID: <87r1s9a3vb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dario Gjorgjevski writes: > Hi Stefan, > >> Killing it isn't a no-op though. When you kill it, you get prompted to >> save changes, it runs hooks in the background, presumably removes it >> from active memory, other functions [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Stefan Kangas , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: > Hi Stefan, > >> Killing it isn't a no-op though. When you kill it, you get prompted to >> save changes, it runs hooks in the background, presumably removes it >> from active memory, other functions will no longer be able to just >> switch to it, etc., etc. Yeah, but these "virtual buffers" don't really exist, so none of that will happen, I'd have thought? > Point taken. In that case, my only complaint would be that > =E2=80=98ido-kill-buffer-at-head=E2=80=99 does treat killing a virtual bu= ffer as > removing it from =E2=80=98recentf-list=E2=80=99 (just as suggested here),= so there is > some inconsistency. However, I can live with it. Yeah, that is inconsistent: ;;; KILL CURRENT BUFFER (defun ido-kill-buffer-at-head () "Kill the buffer at the head of `ido-matches'. If cursor is not at the end of the user input, delete to end of input." [...] ;; Handle virtual buffers ((assoc buf ido-virtual-buffers) (setq recentf-list (delete (cdr (assoc buf ido-virtual-buffers)) recentf-list)) So now I'm kinda thinking that your original patch is correct. :-) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 12:14:58 2020 Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 16:14:58 +0000 Received: from localhost ([127.0.0.1]:53645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6cM5-00042K-Sm for submit@debbugs.gnu.org; Fri, 14 Aug 2020 12:14:58 -0400 Received: from mail-yb1-f194.google.com ([209.85.219.194]:34002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6cM4-000428-0B for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 12:14:56 -0400 Received: by mail-yb1-f194.google.com with SMTP id c9so5487494ybq.1 for <38294@debbugs.gnu.org>; Fri, 14 Aug 2020 09:14:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=aDW4XUZKbGXIdB70pElekoG1YdkQNPOkrBJOZa8O3Bo=; b=VM3z9Fxm93Um4z6x4fMRxoG5jfIlB9QkHP8nVLtDWA8fbI5OiR30uw3o0ZVtyAM0eh QLntd6s33C96bBc9eGxZH0+DbyHIHcIkaK/opai3zZsYNw2CqwETDpVNccTY2Jpbs6m5 7me4EUDqxrE9Tr9n/LkNP5KR0CPkLTI2lpLNHK8ce3QPN6Nd4vFk8OBLsvvhccfG0MWd wUsUwzZeWBWhpft+ZlA5JH8z8uNvaegTW9bBRdkkw25TNfm9f5Cv0Ieyqq3rFPD+bIrE C5EyZcj+nSzAcGiENmUu7Anau23qaWticjdq5ZuZGIvXDSbuQ3S5djVQ7tpD9GMFhsz+ 45BA== X-Gm-Message-State: AOAM533XJfb0fw1+rEK/XcVnIR1Mkya3eBekN8dl/NBgitVKjdv8Oxuf uzqLhyiAT/Uz1RSenNaL/OAQL7BEOc+p+x9a/Uk= X-Google-Smtp-Source: ABdhPJz7DhdQr/BnvwEjRjZaf68VHwYk1fJR/GzDKLvvySZ2jk4Pziyzp7BG0mCfF9Q+HTo6WTkCNSESDROSFlHeR6s= X-Received: by 2002:a25:9843:: with SMTP id k3mr4725529ybo.466.1597421690443; Fri, 14 Aug 2020 09:14:50 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 09:14:49 -0700 From: Stefan Kangas In-Reply-To: <87r1s9a3vb.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> MIME-Version: 1.0 Date: Fri, 14 Aug 2020 09:14:49 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Lars Ingebrigtsen , Dario Gjorgjevski Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >>> Killing it isn't a no-op though. When you kill it, you get prompted to >>> save changes, it runs hooks in the background, presumably removes it >>> from active memory, other functions will no longer be able to just >>> switch to it, etc., etc. > > Yeah, but these "virtual buffers" don't really exist, so none of that > will happen, I'd have thought? But the virtual buffers are only visible on `C-x C-f', not on `C-x b', right? At least, that's what it looks like when I do: 0. emacs -Q 1. M-x ido-mode 2. (setq ido-virtual-buffers t) 3. C-x C-f existing-file-foo RET 4. C-x k RET 5. C-x k => existing-file-foo is not shown But I may very well be overlooking something... Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 17:58:41 2020 Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 21:58:41 +0000 Received: from localhost ([127.0.0.1]:54020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6hij-0004S2-4U for submit@debbugs.gnu.org; Fri, 14 Aug 2020 17:58:41 -0400 Received: from mail-ed1-f48.google.com ([209.85.208.48]:38232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6hie-0004Rm-FF for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 17:58:39 -0400 Received: by mail-ed1-f48.google.com with SMTP id i6so7888117edy.5 for <38294@debbugs.gnu.org>; Fri, 14 Aug 2020 14:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+VIRHJ3t7oIhdRElVIAkOkO6RnwL/RHa38snqQDW+2c=; b=m6eLxM/m0f6XeCd9D2uFcJqxpT6NmLHcGysMtgO3EH/ei/AYpUsbNwvV4z28GyJun6 KRCfamwMp7VmFrGHfzzQR0pz4Ox2rmxw6pWuWK4+ac7ZFSwnL91JY//Lww2ueVbiUGLc bQhc0QDAXvUzwFo2PU/9XaD6ZTNwmKyPaJjqP4f+jhOUmQDwkU3aItg1+8bkddB5l6vG zfn3Hh1CkrVhbYqLzoUgfXArwIP9BA2qwZ1b7VgwJpbcqcdl+k0ajiq0qE42dy/dlgCB mXJNH4g2pPSKk+u0SlbhCt28XhCS4xHx1Xl4CAHZj+zUEhp+Dg3uRlkRLDhy/QHM850u gNNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+VIRHJ3t7oIhdRElVIAkOkO6RnwL/RHa38snqQDW+2c=; b=Ya7w1sDduuwE9wiERuSVn+p1bnMzLzUO6NLbJUf6sQX5uVcTlx/qR/ewNMh4BMC4nT 0qjTSaSY/uqnymOcFT7r5LAAqT/ALz3thRFKorvUVRYTwjU+dy9s1/mcOm74ef+IQlfj dmLhErXUWXj023fQi0U2Q6mQWilI3IAGuDq03gSSGeeCwbGgUx3CXHzjxtLu5XC+7Uwn eU4OX/Y8JLQSK1KrnEfaT7llJTeB+AO9YCspLf3khRnLICoVt/AGvg9J7l76sk6AhdE8 xvB4q2Qc+x9+eP8HNSIzdp11m0oye0eOuGs7Uy+01MkVk4kKVLwkLgJ1rTGrxRcbBSrL vVnw== X-Gm-Message-State: AOAM532lXRgsJ0PtY1+/2oVjjXMCrYzSJkviJBFQ+kPeEtyYW3hUXz65 g5NV0im/LLMCbLwlMNp1cv3fEN/sDMM= X-Google-Smtp-Source: ABdhPJycEeSdTZl7qO69tJM7ZYZQI2kxKRJoJvwygW9d7AgjOFrHDYEdTvoJXZdFfDtM7a8EGjzGdA== X-Received: by 2002:a05:6402:17bb:: with SMTP id j27mr4141992edy.291.1597442310117; Fri, 14 Aug 2020 14:58:30 -0700 (PDT) Received: from ZALANDO-31298 ([79.140.115.173]) by smtp.gmail.com with ESMTPSA id qn10sm7524669ejb.39.2020.08.14.14.58.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Aug 2020 14:58:29 -0700 (PDT) From: Dario Gjorgjevski To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> Date: Fri, 14 Aug 2020 23:58:27 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 14 Aug 2020 09:14:49 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But the virtual buffers are only visible on `C-x C-f', not on `C-x b', > right? They=E2=80=99re visible everywhere: also on =E2=80=98C-x b=E2=80=99 and =E2= =80=98C-x k=E2=80=99. The latter is what this patch is related to. > 2. (setq ido-virtual-buffers t) The correct variable is =E2=80=98ido-use-virtual-buffers=E2=80=99, not =E2=80=98ido-virtual-buffers=E2=80=99. Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371' From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 14 18:56:17 2020 Received: (at 38294) by debbugs.gnu.org; 14 Aug 2020 22:56:17 +0000 Received: from localhost ([127.0.0.1]:54050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6icT-0005p9-9d for submit@debbugs.gnu.org; Fri, 14 Aug 2020 18:56:17 -0400 Received: from mail-yb1-f196.google.com ([209.85.219.196]:35612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6icQ-0005ov-IM for 38294@debbugs.gnu.org; Fri, 14 Aug 2020 18:56:15 -0400 Received: by mail-yb1-f196.google.com with SMTP id y134so6036548yby.2 for <38294@debbugs.gnu.org>; Fri, 14 Aug 2020 15:56:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc:content-transfer-encoding; bh=/3Pf76JVMHF6ki2SMDw3j0/fOFzm0omX3NdCdonLpnw=; b=UDiHFeVTPEpIagjaqgKLaHO5B9LxSmIxYN/FE5XctUVkzkjlWwIeUOVRx/A+wLhakK 9TY3M0vTfyII+SIP3Ncbz7gpLQiDkFMPSg6gl5hjqH7Q/qgzLZFsDbhvhdVnb2IDimaN Aku/7DvVTk5N21wCrcIy+3G491wTtkAWr2VwgfMIBNVLbmB1D7wko4Dtsz1cnCT4bJAH K1gJU8eqzjQPZuLUUv56L3q/vowPns7xrEwmeJoHF3PbZXmy9rRTTvHRgPdgmov7xNGp 1NjOmiQLyay2ztr/d90ezdJgmpLHaZErpJQIAA2O1jAQsahmvXk4am0t6YG8Y6twsV0W i8cg== X-Gm-Message-State: AOAM5339fcNBs5nyvNwWmmik4dVQvAMgFxwUj0m/774NT0s+sw+Y7qwb kQCZk0/HcCMK6/aQPJPC2rKxxlIlFwLXzGofp5U= X-Google-Smtp-Source: ABdhPJw5AcLuj3XEGvwNOdFODvkYaAvdaPIAwtcWbXw9gMgyHhizZS8DmwIWixGaYwi0dzSDn5J0b6Cvkz09tEbResc= X-Received: by 2002:a25:4609:: with SMTP id t9mr6677457yba.231.1597445769010; Fri, 14 Aug 2020 15:56:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 14 Aug 2020 15:56:08 -0700 From: Stefan Kangas In-Reply-To: References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> MIME-Version: 1.0 Date: Fri, 14 Aug 2020 15:56:08 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Dario Gjorgjevski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: >> But the virtual buffers are only visible on `C-x C-f', not on `C-x b', >> right? > > They=E2=80=99re visible everywhere: also on =E2=80=98C-x b=E2=80=99 and = =E2=80=98C-x k=E2=80=99. The latter is > what this patch is related to. > >> 2. (setq ido-virtual-buffers t) > > The correct variable is =E2=80=98ido-use-virtual-buffers=E2=80=99, not > =E2=80=98ido-virtual-buffers=E2=80=99. Uhm, okay, yes that explains why I didn't see it... But my question is then why this buffer even shows up on `C-x k' if it's a virtual buffer. Instead of making it do something on kill, isn't it better to just never show it if it's not actually open? Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 04:03:11 2020 Received: (at 38294) by debbugs.gnu.org; 15 Aug 2020 08:03:11 +0000 Received: from localhost ([127.0.0.1]:54245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6r9j-0007KV-Bd for submit@debbugs.gnu.org; Sat, 15 Aug 2020 04:03:11 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:45415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6r9h-0007KI-Op for 38294@debbugs.gnu.org; Sat, 15 Aug 2020 04:03:10 -0400 Received: by mail-ej1-f47.google.com with SMTP id c16so12248288ejx.12 for <38294@debbugs.gnu.org>; Sat, 15 Aug 2020 01:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=KRm/eUZZd72K//2golOFY2K828szjpEXzj7/PjcQ+14=; b=mcJo0DFxHGNlwO4gUm5n7zpjjJlh5SBZEIasDK4Cpo88Io8L+/DdC27agzfznKA/YO xhlfkbTV7CTjMXZltDUKi9jljESE7YgEnS5YusidcHLZtRnhHmgLhQ3YCAewnVgYymxe 3Dq3Hj/3VDRvXoODC2BZwcTvm5NuXY9Qk7PUzJKI7FNsL4Gl6GXKmbrtdOVursos8fch EmbEHNmOfU9a1E9sr+yOpWjRrnIT54ebHdvagxF8MoA6hdas7BawiEGNJwM0IPNkhunZ ndloUSlbqFawgdDZiNCQoxOygF4+Vjvbr4PgFG5SF3QsZd/yXnhbKNVvpYJ+51ZS/MIi gw6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KRm/eUZZd72K//2golOFY2K828szjpEXzj7/PjcQ+14=; b=AaU47me0xFtK0yde1ruj7pXFfUmH7IhQxdIeXGq4gXMIgTUK+9QMf4JVq/Yn0PXg5h lCpCqrvuSwkmPeJeW5369912tzRb7Sb6QDD/N20ksRG3YcjNoXg9/K7Wut+lOsN6uxk9 XDsnskoommpQy78UfTAzUU7QELzN4riZleMh9tZsUqzZPbJx9q/h1GHRA/RUxtQ80o3Y iNrC/PTZXc7jdeCKIVMyc3n9CPFlD2xG4RekYI1PMfX2DQeF9zf6I1wypI4Hb+Zxcycf z9lzNlWAG31xi10FSloFpfXzDnUm7n24YaRq9QGIKkFfU0lOR49HDVYydPeTZIQzczmU g0kg== X-Gm-Message-State: AOAM532GIYcZLsqwzbtUNTxTUOCbGCEFNSZVrrEtpUe7NA3WAC3jKT2C 029KYB4LL4KX9I4BzXH392bixbvh2mI= X-Google-Smtp-Source: ABdhPJzjTzXs0rO7jDXqgAqFkm5gaqbYMsvf64D+Rq/kCnLDFoB2EC/JMbZa2T7vo5NZWdd4fb1RCw== X-Received: by 2002:a17:906:cc48:: with SMTP id mm8mr6261389ejb.292.1597478583533; Sat, 15 Aug 2020 01:03:03 -0700 (PDT) Received: from ZALANDO-31298 ([79.140.114.36]) by smtp.gmail.com with ESMTPSA id g19sm8380725ejz.5.2020.08.15.01.03.02 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Aug 2020 01:03:03 -0700 (PDT) From: Dario Gjorgjevski To: Stefan Kangas Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> Date: Sat, 15 Aug 2020 10:03:02 +0200 In-Reply-To: (Stefan Kangas's message of "Fri, 14 Aug 2020 15:56:08 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Lars Ingebrigtsen , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But my question is then why this buffer even shows up on `C-x k' if it's > a virtual buffer. Instead of making it do something on kill, isn't it > better to just never show it if it's not actually open? That=E2=80=99s exactly why I asked =E2=80=9CIn that case, should we prevent= virtual buffers from being listed in =E2=80=98ido-kill-buffer=E2=80=99 in the first= place?=E2=80=9D before. To me, both _not offering virtual buffers to be killed at all_ and _offering them but treating killing as removing from =E2=80=98recentf-list= =E2=80=99_ make sense. The latter I prefer simply for consistency with =E2=80=98ido-kill-buffer-at-head=E2=80=99 (i.e., function that is called wh= en you press =E2=80=98C-k=E2=80=99 on a buffer during =E2=80=98C-x b=E2=80=99). Best regards, Dario --=20 dario.gjorgjevski@gmail.com :: +49 1525 8666837 % gpg --keyserver 'hkps://hkps.pool.sks-keyservers.net' \ \`> --recv-keys '744A4F0B4F1C9371' From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 06:29:36 2020 Received: (at 38294) by debbugs.gnu.org; 15 Aug 2020 10:29:36 +0000 Received: from localhost ([127.0.0.1]:54300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tRQ-0004lt-Fd for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:29:36 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tRO-0004lf-Ja for 38294@debbugs.gnu.org; Sat, 15 Aug 2020 06:29:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=peVuY/rR9yyJksr2ew5suWp/gjpeSoXzpSe/puRAlJE=; b=Uja1ov7zqzCXNbLM9wboyEIQ0k OZZkJ6c98embcD9Mep6nSsTfDY1UetIF4SNgEZ/caJVN2W2CyDnFaGGxr8bvZhq0OIUA6bUA2lj4y eddUdzQ4B/L+z7POkry9VXhAo/jTN89h+mm+rZ30qzq4KZIwPiVQez4MaFFq2ioZOZco=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tRC-0006ZJ-GV; Sat, 15 Aug 2020 12:29:28 +0200 From: Lars Ingebrigtsen To: Dario Gjorgjevski Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> Date: Sat, 15 Aug 2020 12:29:20 +0200 In-Reply-To: (Dario Gjorgjevski's message of "Sat, 15 Aug 2020 10:03:02 +0200") Message-ID: <87eeo819tr.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Dario Gjorgjevski writes: > To me, both _not offering virtual buffers to be killed at all_ and > _offering them but treating killing as removing from ‘recentf-list’_ > make sense. The latter I prefer simply for consistency [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38294 Cc: Stefan Kangas , 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dario Gjorgjevski writes: > To me, both _not offering virtual buffers to be killed at all_ and > _offering them but treating killing as removing from =E2=80=98recentf-lis= t=E2=80=99_ > make sense. The latter I prefer simply for consistency with > =E2=80=98ido-kill-buffer-at-head=E2=80=99 (i.e., function that is called = when you press > =E2=80=98C-k=E2=80=99 on a buffer during =E2=80=98C-x b=E2=80=99). Yeah, I think you're right, and the original patch was the correct solution here: When the user explicitly (and interactively) kills a buffer, then they expect that buffer to go away. (There isn't any other reasonable interpretation for that interactive action.) It's perhaps slightly inconsistent, but I think it's more DWIM. So I'm applying your patch to Emacs 28, and we'll see if any users of this ido setting complains (in which case we should be prepared to revert it). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 06:34:03 2020 Received: (at control) by debbugs.gnu.org; 15 Aug 2020 10:34:03 +0000 Received: from localhost ([127.0.0.1]:54304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tVj-0004tz-0O for submit@debbugs.gnu.org; Sat, 15 Aug 2020 06:34:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6tVg-0004tT-VC for control@debbugs.gnu.org; Sat, 15 Aug 2020 06:34:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=52bWtxqeb1aj2gjvfw2Mq+qJlHklzzlR/rhyPI2fm6A=; b=Jl+JmxH4X/1rdbxZcfY7Pu1S/j MeciM53zK2d59HyOLsdvJJAprrVt9SO1QMMwynOZbr8+lNqDfkNt5SBoQZObai9017tPM+67uYohF ovu9LhraRozZz+d9ySicT+FTi8UUME2EW99yivV+6zLq+/DITP+kWYcIMJLOzk8OVZi8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k6tVY-0006ca-RN for control@debbugs.gnu.org; Sat, 15 Aug 2020 12:33:55 +0200 Date: Sat, 15 Aug 2020 12:33:51 +0200 Message-Id: <87d03s19m8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38294 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38294 fixed close 38294 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38294 fixed close 38294 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 15 10:03:33 2020 Received: (at 38294) by debbugs.gnu.org; 15 Aug 2020 14:03:33 +0000 Received: from localhost ([127.0.0.1]:56068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wmT-0007AQ-AA for submit@debbugs.gnu.org; Sat, 15 Aug 2020 10:03:33 -0400 Received: from mail-yb1-f182.google.com ([209.85.219.182]:37881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k6wmS-0007AF-4X for 38294@debbugs.gnu.org; Sat, 15 Aug 2020 10:03:32 -0400 Received: by mail-yb1-f182.google.com with SMTP id e14so6817556ybf.4 for <38294@debbugs.gnu.org>; Sat, 15 Aug 2020 07:03:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=27Hwmm7vTL5ECO51n3Tzvic4tWIQumquwkcjUmWT8Zg=; b=RTVNkRPLEnO0/sHLmR2+WLYkd2nPq9cjqVZwE1OCiEL5PAz7LOqGUnAxb/VNtWangC owTlBn0jNCSAiRiD9JnjCRq2iDEGRr3XsI69fFAKTctoIq96nKTCxima6+aZILKfMI1r BUgiBC2jucEYXo4J4EGPB+24m7/f2iGbKvkTa40xhC7n3KsoHmEMfCnWJAY1OADmMed/ 7V8gDJLeUuH4yjFz4rQ50WCaFzdvJSwXm/sATThC9XmhBX5SszR9QQW7xPbivPKNegzu gagsdt56wk6FvBpqhIMrmpWB/rHL5l7dEfM3Ac44NNSrxxyxV2Z6HxtgNI8Asm7BSj/Q jpVQ== X-Gm-Message-State: AOAM532RBM6yJyfyjAZYO1Wx5cS6trsM26xWsKWnmEwwuK+YWVFcmkLq +qo0d0JP/F5uxB/KH/j/oDQtJw4smVSzMeVUMQqG0QnVVBQGAA== X-Google-Smtp-Source: ABdhPJzvhQpzdcCDa6DNogDzpFk1DLq0A5JGh/ErfZOGnj0wSpddhEudXLMFXzNKlZtx79Gqg8kKwlUKcu4Oq9iW4Y8= X-Received: by 2002:a25:9843:: with SMTP id k3mr10200249ybo.466.1597500206829; Sat, 15 Aug 2020 07:03:26 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Aug 2020 07:03:26 -0700 From: Stefan Kangas In-Reply-To: <87eeo819tr.fsf@gnus.org> References: <87a76it1hi.fsf@marxist.se> <87wo9jkgrb.fsf@marxist.se> <874kpcrm5q.fsf@gnus.org> <87r1s9a3vb.fsf@gnus.org> <87eeo819tr.fsf@gnus.org> MIME-Version: 1.0 Date: Sat, 15 Aug 2020 07:03:26 -0700 Message-ID: Subject: Re: bug#38294: [PATCH] Handle killing of virtual buffers in Ido To: Lars Ingebrigtsen , Dario Gjorgjevski Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 38294 Cc: 38294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Lars Ingebrigtsen writes: > Yeah, I think you're right, and the original patch was the correct > solution here: When the user explicitly (and interactively) kills a > buffer, then they expect that buffer to go away. (There isn't any other > reasonable interpretation for that interactive action.) > > It's perhaps slightly inconsistent, but I think it's more DWIM. Thanks! From unknown Sat Aug 09 09:34:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Sep 2020 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator