GNU bug report logs - #38286
[PATCH] gnu: Add netcat-openbsd.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38286 in the body.
You can then email your comments to 38286 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add netcat-openbsd.
Date: Wed, 20 Nov 2019 02:10:34 +0000

[Message part 1 (text/plain, inline)]

This patch adds the OpenBSD rewrite of netcat, as ported to GNU/Linux by Debian.

-- 
Alex Griffin

[0001-gnu-Add-netcat-openbsd.patch (text/x-patch, attachment)]

Message #8 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38286 <at> debbugs.gnu.org
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Thu, 21 Nov 2019 10:09:49 +0100

Hello Alex,

"Alex Griffin" <a <at> ajgrf.com> skribis:

> From e46e78bfe12923989e7262eec2116dba7e00299b Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Tue, 19 Nov 2019 19:59:32 -0600
> Subject: [PATCH] gnu: Add netcat-openbsd.
>
> * gnu/packages/admin.scm (netcat-openbsd): New variable.
> * gnu/packages/patches/netcat-openbsd-broadcast-support.patch,
> gnu/packages/patches/netcat-openbsd-build-without-TLS-support.patch,
> gnu/packages/patches/netcat-openbsd-connect-timeout.patch,
> gnu/packages/patches/netcat-openbsd-dccp-support.patch,
> gnu/packages/patches/netcat-openbsd-destination-port-list.patch,
> gnu/packages/patches/netcat-openbsd-get-sev-by-name.patch,
> gnu/packages/patches/netcat-openbsd-misc-failures-and-features.patch,
> gnu/packages/patches/netcat-openbsd-port-to-linux-with-libsd.patch,
> gnu/packages/patches/netcat-openbsd-quit-timer.patch,
> gnu/packages/patches/netcat-openbsd-send-crlf.patch,
> gnu/packages/patches/netcat-openbsd-serialized-handling-multiple-clients.patch,
> gnu/packages/patches/netcat-openbsd-set-TCP-MD5SIG-correctly-for-client-connections.patch,
> gnu/packages/patches/netcat-openbsd-udp-scan-timeout.patch,
> gnu/packages/patches/netcat-openbsd-use-flags-to-specify-listen-address.patch:
> New files.
> * gnu/local.mk (dist_patch_DATA): Add them.

That’s a lot of patches.  :-)

Is there are repo containing this fork?  (Perhaps on salsa.debian.org?)
I’d rather see us pull from such a repo than carry all these patches
around.

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://deb.debian.org/debian/pool/main/n/"

This should be “mirror://debian/…”.

Thanks,
Ludo’.

Message #11 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 38286 <at> debbugs.gnu.org, Alex Griffin <a <at> ajgrf.com>
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Thu, 21 Nov 2019 12:17:55 +0200

[Message part 1 (text/plain, inline)]

On Thu, Nov 21, 2019 at 10:09:49AM +0100, Ludovic Courtès wrote:
> Hello Alex,
> 
> "Alex Griffin" <a <at> ajgrf.com> skribis:
> 
> > From e46e78bfe12923989e7262eec2116dba7e00299b Mon Sep 17 00:00:00 2001
> > From: Alex Griffin <a <at> ajgrf.com>
> > Date: Tue, 19 Nov 2019 19:59:32 -0600
> > Subject: [PATCH] gnu: Add netcat-openbsd.
> >
> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
> > * gnu/packages/patches/netcat-openbsd-broadcast-support.patch,
> > gnu/packages/patches/netcat-openbsd-build-without-TLS-support.patch,
> > gnu/packages/patches/netcat-openbsd-connect-timeout.patch,
> > gnu/packages/patches/netcat-openbsd-dccp-support.patch,
> > gnu/packages/patches/netcat-openbsd-destination-port-list.patch,
> > gnu/packages/patches/netcat-openbsd-get-sev-by-name.patch,
> > gnu/packages/patches/netcat-openbsd-misc-failures-and-features.patch,
> > gnu/packages/patches/netcat-openbsd-port-to-linux-with-libsd.patch,
> > gnu/packages/patches/netcat-openbsd-quit-timer.patch,
> > gnu/packages/patches/netcat-openbsd-send-crlf.patch,
> > gnu/packages/patches/netcat-openbsd-serialized-handling-multiple-clients.patch,
> > gnu/packages/patches/netcat-openbsd-set-TCP-MD5SIG-correctly-for-client-connections.patch,
> > gnu/packages/patches/netcat-openbsd-udp-scan-timeout.patch,
> > gnu/packages/patches/netcat-openbsd-use-flags-to-specify-listen-address.patch:
> > New files.
> > * gnu/local.mk (dist_patch_DATA): Add them.
> 
> That’s a lot of patches.  :-)
> 
> Is there are repo containing this fork?  (Perhaps on salsa.debian.org?)
> I’d rather see us pull from such a repo than carry all these patches
> around.
> 

Here is Debian's packaging repo for netcat-openbsd with their patches
applied: https://salsa.debian.org/debian/netcat-openbsd/tree/debian/1.203-2

> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append "https://deb.debian.org/debian/pool/main/n/"
> 
> This should be “mirror://debian/…”.
> 
> Thanks,
> Ludo’.
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Efraim Flashner" <efraim <at> flashner.co.il>,
 Ludovic Courtès <ludo <at> gnu.org>
Cc: 38286 <at> debbugs.gnu.org
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Thu, 21 Nov 2019 21:49:05 +0000

[Message part 1 (text/plain, inline)]

On Thu, Nov 21, 2019, at 10:17 AM, Efraim Flashner wrote:
> Here is Debian's packaging repo for netcat-openbsd with their patches
> applied: https://salsa.debian.org/debian/netcat-openbsd/tree/debian/1.203-2

Thanks, I was able to simplify the package a lot by fetching that repo instead! The revised patch is attached.

-- 
Alex Griffin

[0001-gnu-Add-netcat-openbsd.patch (text/x-patch, attachment)]

Message #17 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Efraim Flashner" <efraim <at> flashner.co.il>,
 Ludovic Courtès <ludo <at> gnu.org>
Cc: 38286 <at> debbugs.gnu.org
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Thu, 21 Nov 2019 22:09:26 +0000

[Message part 1 (text/plain, inline)]

Sorry, one last revision. There was no point in adding PREFIX=out since the Makefile doesn't install the software. Also, may as well include the example scripts since they're right there in the Debian repo.

-- 
Alex Griffin

On Thu, Nov 21, 2019, at 9:49 PM, Alex Griffin wrote:
> On Thu, Nov 21, 2019, at 10:17 AM, Efraim Flashner wrote:
> > Here is Debian's packaging repo for netcat-openbsd with their patches
> > applied: https://salsa.debian.org/debian/netcat-openbsd/tree/debian/1.203-2
> 
> Thanks, I was able to simplify the package a lot by fetching that repo 
> instead! The revised patch is attached.
> 
> -- 
> Alex Griffin
> 
> Attachments:
> * 0001-gnu-Add-netcat-openbsd.patch

[0001-gnu-Add-netcat-openbsd.patch (text/x-patch, attachment)]

Message #20 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: "Efraim Flashner" <efraim <at> flashner.co.il>,
 Ludovic Courtès <ludo <at> gnu.org>
Cc: 38286 <at> debbugs.gnu.org
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Thu, 21 Nov 2019 22:15:47 +0000

[Message part 1 (text/plain, inline)]

Ugh, sent the wrong patch that time! (I really need to get mu4e working again so I can get off webmail...)

OK, this patch should be good to go now.

-- 
Alex Griffin

On Thu, Nov 21, 2019, at 10:09 PM, Alex Griffin wrote:
> Sorry, one last revision. There was no point in adding PREFIX=out since 
> the Makefile doesn't install the software. Also, may as well include 
> the example scripts since they're right there in the Debian repo.

[0001-gnu-Add-netcat-openbsd.patch (text/x-patch, attachment)]

Message #23 received at 38286 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: "Alex Griffin" <a <at> ajgrf.com>
Cc: 38286 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Sun, 24 Nov 2019 12:03:36 +0100

Hello!

"Alex Griffin" <a <at> ajgrf.com> skribis:

> From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 2001
> From: Alex Griffin <a <at> ajgrf.com>
> Date: Tue, 19 Nov 2019 19:59:32 -0600
> Subject: [PATCH] gnu: Add netcat-openbsd.
>
> * gnu/packages/admin.scm (netcat-openbsd): New variable.

Overall LGTM; I like that we’re not taking responsibility for all these
patches.  :-)

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://salsa.debian.org/debian/netcat-openbsd.git")
> +                    (commit (string-append "debian/" version))))
> +              (sha256
> +               (base32
> +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk3m"))))

I suspect ‘guix lint’ suggests a ‘file-name’ field here.  :-)

> +    (home-page "https://packages.debian.org/sid/netcat-openbsd")
> +    (synopsis "TCP/IP swiss army knife")

Could you make that more factual, like “Read and write data over TCP/IP”
(same as for ‘netcat’ actually)?

> +    (description
> +     "A simple Unix utility which reads and writes data across network
         ^
Please write full sentences.

OK to push with changes along these lines!

Thanks,
Ludo’.

Message #28 received at 38286-done <at> debbugs.gnu.org (full text, mbox):

From: "Alex Griffin" <a <at> ajgrf.com>
To: 38286-done <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#38286] [PATCH] gnu: Add netcat-openbsd.
Date: Mon, 25 Nov 2019 15:50:19 +0000

Pushed as 377606238f0260a849a1f529d94e1546276a5db6.
-- 
Alex Griffin

On Sun, Nov 24, 2019, at 11:03 AM, Ludovic Courtès wrote:
> Hello!
> 
> "Alex Griffin" <a <at> ajgrf.com> skribis:
> 
> > From 41abd13973e20750815b5f395acb9fc4893c6817 Mon Sep 17 00:00:00 2001
> > From: Alex Griffin <a <at> ajgrf.com>
> > Date: Tue, 19 Nov 2019 19:59:32 -0600
> > Subject: [PATCH] gnu: Add netcat-openbsd.
> >
> > * gnu/packages/admin.scm (netcat-openbsd): New variable.
> 
> Overall LGTM; I like that we’re not taking responsibility for all these
> patches.  :-)
> 
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://salsa.debian.org/debian/netcat-openbsd.git")
> > +                    (commit (string-append "debian/" version))))
> > +              (sha256
> > +               (base32
> > +                "0j85gzbjzs6yrhgabh3zkwzd27qkr5s0zjjczl0hah8q7yhrjk3m"))))
> 
> I suspect ‘guix lint’ suggests a ‘file-name’ field here.  :-)
> 
> > +    (home-page "https://packages.debian.org/sid/netcat-openbsd")
> > +    (synopsis "TCP/IP swiss army knife")
> 
> Could you make that more factual, like “Read and write data over TCP/IP”
> (same as for ‘netcat’ actually)?
> 
> > +    (description
> > +     "A simple Unix utility which reads and writes data across network
>          ^
> Please write full sentences.
> 
> OK to push with changes along these lines!
> 
> Thanks,
> Ludo’.
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.