Subject: bug#38272: closed (Re: [bug#38272] [PATCH] gnu: Add emacs-openwith.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 21 Nov 2019 18:37:03 +0000

Your bug report

#38272: [PATCH] gnu: Add emacs-openwith.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
38272: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38272
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#38272] [PATCH] gnu: Add emacs-openwith.
From: Marius Bakke <[email-masked]>
To: David Wilson <[email-masked]>, [email-masked]
Date: Thu, 21 Nov 2019 19:36:49 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

"David Wilson" <[email-masked]> writes:

>> 
>> Maybe "This package lets you associate file name patterns with
>> external applications that are automatically invoked when you use
>> commands like @code{find-file}, etc".
>> 
>
> I've taken your suggestion and improved on it like so:
>
> "This package enables you to associate file name patterns with external
> applications that are automatically invoked when you use commands like
> @code{find-file}.  For example, you can have it open @code{png} files with
> @code{feh} and @code{mp4} files with @code{mpv}.  This is especially useful
> when browsing files with Dired."

Thank you!  That description is much better.  :-)

> Updated patch is attached, thanks again!

I found that 'git-fetch' failed, so I changed the patch to use
'hg-fetch'.  It still produced the same hash.

But, I read in another message that BitBucket is shutting down Mercurial
support in 2020, so I'm not sure what to do about it.  Thoughts?

In any case the patch is applied!

Subject: [PATCH] gnu: Add emacs-openwith.
From: "David Wilson" <[email-masked]>
To: [email-masked]
Date: Tue, 19 Nov 2019 07:17:59 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Guix!

This patch adds the "openwith" package for Emacs to make it easier to launch external applications for configured file types.  I've tested the package and run it through "guix lint", all looks good.

Thanks!

David

From cdd934a91f03450b1eb8fd89aca8272d94438620 Mon Sep 17 00:00:00 2001
From: David Wilson <[email-masked]>
Date: Tue, 19 Nov 2019 06:24:31 -0800
Subject: [PATCH] gnu: Add emacs-openwith.

* gnu/packages/emacs-xyz.scm (emacs-openwith) New variable.
---
 gnu/packages/emacs-xyz.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ea4ab0e6f9..4fab900c7a 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -10248,6 +10248,27 @@ list of commands is displayed in a handy popup.")
 characters from end of lines.")
     (license license:gpl3+)))
 
+(define-public emacs-openwith
+  (let ((commit "1dc89670822966fab6e656f6519fdd7f01e8301a")
+        (revision "0"))
+    (package
+      (name "emacs-openwith")
+      (home-page "https://github.com/emacsmirror/openwith")
+      (version (git-version "0.0.1" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference (url home-page) (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1wl6gnxsyhaad4cl9bxjc0qbc5jzvlwbwjbajs0n1s6qr07d6r01"))))
+      (build-system emacs-build-system)
+      (synopsis "Emacs")
+      (description
+       "This package enables external applications to be launched for
+configured file types when you use commands like @code{find-file}, etc.")
+      (license license:gpl2+))))
+
 (define-public emacs-org-edit-latex
   (package
     (name "emacs-org-edit-latex")
-- 
2.24.0