GNU bug report logs - #38268
[PATCH] Add llvm-9, clang-9 and clang-toolchain-9

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38268 in the body.
You can then email your comments to 38268 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Truby <David.Truby <at> arm.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Cc: nd <nd <at> arm.com>, David Truby <David.Truby <at> arm.com>
Subject: [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Tue, 19 Nov 2019 13:46:44 +0000

---
 gnu/packages/llvm.scm | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index a5170a4f10..c1bb1937a5 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -11,7 +11,7 @@
 ;;; Copyright © 2018 Tim Gesthuizen <tim.gesthuizen <at> yahoo.de>
 ;;; Copyright © 2018 Pierre Neidhardt <mail <at> ambrevar.xyz>
 ;;; Copyright © 2019 Rutger Helling <rhelling <at> mykolab.com>
-;;; Copyright © 2019 David Truby <David.Truby <at> arm.com>
+;;; Copyright © 2019 Arm Ltd. <David.Truby <at> arm.com>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
@@ -458,6 +458,30 @@ with that of libgomp, the GNU Offloading and Multi Processing Library.")
 (define-public clang-toolchain
   (make-clang-toolchain clang))
 
+(define-public llvm-9
+  (package
+    (inherit llvm)
+    (version "9.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://llvm.org/releases/"
+                                  version "/llvm-" version ".src.tar.xz"))
+              (sha256
+               (base32
+                "117ymdz1by2nkfq1c2p9m4050dp848kbjbiv6nsfj8hzy9f5d86n"))))))
+
+(define-public clang-runtime-9
+  (clang-runtime-from-llvm
+   llvm-9
+   "03ni43lbkp63lr3p6sc94dphqmvnz5av5mml0xmk930xvnbcvr2n"))
+
+(define-public clang-9
+  (clang-from-llvm llvm-9 clang-runtime-9
+                   "0426ma80i41qsgzm1qdz81mjskck426diygxi2k5vji2gkpixa3v"))
+
+(define-public clang-toolchain-9
+  (make-clang-toolchain clang-9))
+
 (define-public llvm-7
   (package
     (inherit llvm)
-- 
2.24.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 38268 <at> debbugs.gnu.org, nd <nd <at> arm.com>, David Truby <David.Truby <at> arm.com>
Subject: Re: [bug#38268] [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Tue, 19 Nov 2019 16:58:03 +0100

Hello David,

This patch LGTM. However, you need to write a commit log compliant with
ChangeLog format. See:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.

Can you please send a v2 :) ?

Thanks,

Mathieu

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Truby <David.Truby <at> arm.com>
To: "m.othacehe <at> gmail.com" <m.othacehe <at> gmail.com>, "guix-patches <at> gnu.org"
 <guix-patches <at> gnu.org>
Cc: "38268 <at> debbugs.gnu.org" <38268 <at> debbugs.gnu.org>, nd <nd <at> arm.com>
Subject: Re: [bug#38268] [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Tue, 19 Nov 2019 16:00:10 +0000

Hi Mathieu,

Sorry, I'll read up on the correct format for commit messages and then
send again :).
I also just realised the license has changed for LLVM-9 so I need to
change that in the package too!

David

On Tue, 2019-11-19 at 16:58 +0100, Mathieu Othacehe wrote:
> Hello David,
> 
> This patch LGTM. However, you need to write a commit log compliant
> with
> ChangeLog format. See:
> https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.
> 
> Can you please send a v2 :) ?
> 
> Thanks,
> 
> Mathieu

Message #20 received at 38268 <at> debbugs.gnu.org (full text, mbox):

From: David Truby <David.Truby <at> arm.com>
To: "38268 <at> debbugs.gnu.org" <38268 <at> debbugs.gnu.org>
Cc: nd <nd <at> arm.com>, David Truby <David.Truby <at> arm.com>
Subject: [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Tue, 19 Nov 2019 17:15:42 +0000

* gnu/packages/llvm.scm (llvm-9): New variable.
(clang-9): New variable.
(clang-toolchain-9): New variable.
---
 gnu/packages/llvm.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index 863d43d7d6..082e6e96ca 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -458,6 +458,31 @@ with that of libgomp, the GNU Offloading and Multi Processing Library.")
 (define-public clang-toolchain
   (make-clang-toolchain clang))
 
+(define-public llvm-9
+  (package
+    (inherit llvm)
+    (version "9.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://llvm.org/releases/"
+                                  version "/llvm-" version ".src.tar.xz"))
+              (sha256
+               (base32
+                "117ymdz1by2nkfq1c2p9m4050dp848kbjbiv6nsfj8hzy9f5d86n"))))
+    (license license:asl2.0)))
+
+(define-public clang-runtime-9
+  (clang-runtime-from-llvm
+   llvm-9
+   "03ni43lbkp63lr3p6sc94dphqmvnz5av5mml0xmk930xvnbcvr2n"))
+
+(define-public clang-9
+  (clang-from-llvm llvm-9 clang-runtime-9
+                   "0426ma80i41qsgzm1qdz81mjskck426diygxi2k5vji2gkpixa3v"))
+
+(define-public clang-toolchain-9
+  (make-clang-toolchain clang-9))
+
 (define-public llvm-7
   (package
     (inherit llvm)
-- 
2.24.0

Message #23 received at 38268 <at> debbugs.gnu.org (full text, mbox):

From: David Truby <David.Truby <at> arm.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Cc: "38268 <at> debbugs.gnu.org" <38268 <at> debbugs.gnu.org>, nd <nd <at> arm.com>,
 David Truby <David.Truby <at> arm.com>
Subject: [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Wed, 20 Nov 2019 12:02:39 +0000

* gnu/packages/llvm.scm (llvm-9): New variable.
(clang-9): New variable.
(clang-toolchain-9): New variable.
---
 gnu/packages/llvm.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
index 863d43d7d6..082e6e96ca 100644
--- a/gnu/packages/llvm.scm
+++ b/gnu/packages/llvm.scm
@@ -458,6 +458,31 @@ with that of libgomp, the GNU Offloading and Multi Processing Library.")
 (define-public clang-toolchain
   (make-clang-toolchain clang))
 
+(define-public llvm-9
+  (package
+    (inherit llvm)
+    (version "9.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://llvm.org/releases/"
+                                  version "/llvm-" version ".src.tar.xz"))
+              (sha256
+               (base32
+                "117ymdz1by2nkfq1c2p9m4050dp848kbjbiv6nsfj8hzy9f5d86n"))))
+    (license license:asl2.0)))
+
+(define-public clang-runtime-9
+  (clang-runtime-from-llvm
+   llvm-9
+   "03ni43lbkp63lr3p6sc94dphqmvnz5av5mml0xmk930xvnbcvr2n"))
+
+(define-public clang-9
+  (clang-from-llvm llvm-9 clang-runtime-9
+                   "0426ma80i41qsgzm1qdz81mjskck426diygxi2k5vji2gkpixa3v"))
+
+(define-public clang-toolchain-9
+  (make-clang-toolchain clang-9))
+
 (define-public llvm-7
   (package
     (inherit llvm)
-- 
2.24.0

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: "38268-done <at> debbugs.gnu.org" <38268-done <at> debbugs.gnu.org>, nd <nd <at> arm.com>,
 David Truby <David.Truby <at> arm.com>
Subject: Re: [bug#38268] [PATCH] Add llvm-9, clang-9 and clang-toolchain-9
Date: Wed, 20 Nov 2019 17:10:07 +0100

Hey David,

Pushed with a slightly edited commit title.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.