From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 03:35:41 2019 Received: (at submit) by debbugs.gnu.org; 19 Nov 2019 08:35:41 +0000 Received: from localhost ([127.0.0.1]:46560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWyz7-0003nV-8R for submit@debbugs.gnu.org; Tue, 19 Nov 2019 03:35:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:57835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWyz5-0003nN-RO for submit@debbugs.gnu.org; Tue, 19 Nov 2019 03:35:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52199) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWyz4-0008GU-GL for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 03:35:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWyz3-00023r-F7 for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 03:35:38 -0500 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]:38584) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWyz3-00020y-22 for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 03:35:37 -0500 Received: by mail-pj1-x102c.google.com with SMTP id f7so2393648pjw.5 for ; Tue, 19 Nov 2019 00:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=m7C59C4jsnIdq2YXQa6xCEKRvUE+wTEoq0tQy3+MVjM=; b=wklPQicHXnKoJBkVH4ePCeUDaoGueHYlHUVbzMrQSDW0DotpVnzjII81S/SiB3MIdy 8r5VGPVCP7Su099aSN6mVCF0vBfbjqQbWddBiv/ClaySYLoeR4qCAyoZP+oxeX4zX3q/ +DgKu24BOUb+3ykjY5mhfpUCJQaNFIMC5FCvsOLLmHZjh+Iw2egKe4ufDDrRrvxOg9/L kognoUXsbOppP/kbeQB/0BWC1fKNvP3Q5DYUk9wvW4sNsTbOk4iv+sb4pVkov3TOyzyc AdTLeebwZhBPfX1SWzZarKAdNzRe3Yvr1cD/i9VfxZmvfRnTJyN8SaeYkOC1uH2oQeyn jhaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=m7C59C4jsnIdq2YXQa6xCEKRvUE+wTEoq0tQy3+MVjM=; b=mhqH7OzGY33WxUqsa1qnHhMOPxREUqkCFS5l8HOMkFSsZdaVQMk8GQ/BZiwcvVyrQE MQPLQJjx8C8EMTHSyK+4xS/g4lHzfQyH7/YTHLONqpzv/mb2lwngJpAVc8e6CzqzPEZv Xt67eDJdTFrniXruJaRd7zIjSChBkjDn36ocJlDxH9pf72KJXpcwV0Aryc8guoXkUOet TygDSeLZEUafIJi+LxUC5bhf/BRjUz5EASG5FIyTTTvRArZNU5yUivhso2VYJwN19hrH HU+VbE6q01kDPCsdGGAG4IzwKKJByoUn/RHfi1TX3FOIhydzdLyqNiaZORGV6wZnsEUG D9cA== X-Gm-Message-State: APjAAAVTL3R1tXEEg1pUfF8uvgWNPnb/4pxO1Mzx9PvtB3BLBSqU5dwE HeaHMYZloD2dTvvQrckgAR9eheEjkic= X-Google-Smtp-Source: APXvYqwpk1VjVWdtysO1CWOodLSbE8i/OhotJ/SeHxuAu5qPbJzGtWadW1asZ75ZPwMVFDEVKYqF8A== X-Received: by 2002:a17:902:6846:: with SMTP id f6mr31334221pln.77.1574152535462; Tue, 19 Nov 2019 00:35:35 -0800 (PST) Received: from localhost ([2600:1700:7270:7d1f:fa59:71ff:fe00:10cc]) by smtp.gmail.com with ESMTPSA id x70sm24292608pfd.132.2019.11.19.00.35.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 00:35:34 -0800 (PST) From: Allen Li To: bug-gnu-emacs@gnu.org Subject: 26.3; lock file is too easy to steal Date: Tue, 19 Nov 2019 00:35:34 -0800 Message-ID: <808soc2rhl.fsf@felesatra.moe> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::102c X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The default ask-user-about-lock is too easy to miss. For example, if one were typing "asparagus", they would likely steal the lock without even realizing that it happened (the "a" triggers the prompt on buffer modification and the "s" steals the lock). It would be nice to have the prompt be harder to hit accidentally, such as making all of the keys uppercase or having to type them out like yes/no (but the latter might be too heavyweight). Or the prompt should have a short timeout before allowing the user to respond (like how yes-or-no-p does when you provide an invalid response). In GNU Emacs 26.3 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.10) of 2019-08-29 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.12005000 System Description: Arch Linux From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 17:47:30 2019 Received: (at 38265) by debbugs.gnu.org; 20 Nov 2019 22:47:30 +0000 Received: from localhost ([127.0.0.1]:51032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYl0-000619-CA for submit@debbugs.gnu.org; Wed, 20 Nov 2019 17:47:30 -0500 Received: from bisque.elm.relay.mailchannels.net ([23.83.212.18]:48988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXYkv-00060X-1N for 38265@debbugs.gnu.org; Wed, 20 Nov 2019 17:47:25 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BFFD45A101F; Wed, 20 Nov 2019 22:47:23 +0000 (UTC) Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1F6CA5A1240; Wed, 20 Nov 2019 22:47:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 20 Nov 2019 22:47:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Unite: 2e90d98a150bf787_1574290043540_2864638393 X-MC-Loop-Signature: 1574290043540:45737027 X-MC-Ingress-Time: 1574290043540 Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id 3AD23832D7; Wed, 20 Nov 2019 14:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=CkgsKl rnDpNvSToEa85T699fP6I=; b=O/wG32VyK3fGsrBB3u/Cox9a6aWjZNrWnWaACE ezx0OdGzGqv51hXkCr/xGiaLqiNQrTsfN/Li8SkOCTmVduIipbDPbzca/XxfANum FpmXwrhtagt6G3WkqP3F2Iv8JI2x+Dp/qcoi5KFpmkTeBGcfD6I4DhSApGJAqec4 6LMg0= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id B3599832D5; Wed, 20 Nov 2019 14:47:20 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 From: Juri Linkov To: Allen Li Subject: Re: bug#38265: 26.3; lock file is too easy to steal Organization: LINKOV.NET References: <808soc2rhl.fsf@felesatra.moe> Date: Thu, 21 Nov 2019 00:28:09 +0200 In-Reply-To: <808soc2rhl.fsf@felesatra.moe> (Allen Li's message of "Tue, 19 Nov 2019 00:35:34 -0800") Message-ID: <87v9rep4hy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38265 Cc: 38265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > The default ask-user-about-lock is too easy to miss. > > For example, if one were typing "asparagus", they would likely steal th= e > lock without even realizing that it happened (the "a" triggers the > prompt on buffer modification and the "s" steals the lock). > > It would be nice to have the prompt be harder to hit accidentally, such > as making all of the keys uppercase or having to type them out like > yes/no (but the latter might be too heavyweight). Or the prompt should > have a short timeout before allowing the user to respond (like how > yes-or-no-p does when you provide an invalid response). On the request in https://lists.gnu.org/archive/html/emacs-devel/2019-11/= msg00517.html recently =E2=80=98(discard-input)=E2=80=99 was removed from =E2=80=98read= -char-from-minibuffer=E2=80=99. Should it be put back? ask-user-about-supersession-threat uses read-char-from-minibuffer, so if it contained =E2=80=98(discard-input)=E2=80=99 it could benefit from disc= arding such inadvertent input as "s". But what about the case of keyboard macros like in the link above? What if the user recorded a keyboard macro to input that "s" intentionall= y? From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 17:52:25 2019 Received: (at 38265) by debbugs.gnu.org; 16 Dec 2019 22:52:25 +0000 Received: from localhost ([127.0.0.1]:40458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igzE1-0006xK-26 for submit@debbugs.gnu.org; Mon, 16 Dec 2019 17:52:25 -0500 Received: from bumble.birch.relay.mailchannels.net ([23.83.209.25]:45978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1igzDu-0006x6-Ql for 38265@debbugs.gnu.org; Mon, 16 Dec 2019 17:52:23 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 56F071418E4; Mon, 16 Dec 2019 22:52:17 +0000 (UTC) Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-92-221.trex.outbound.svc.cluster.local [100.96.92.221]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id AC94B141A0B; Mon, 16 Dec 2019 22:52:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 16 Dec 2019 22:52:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wide-Eyed-Daffy: 25966dba58ffae70_1576536737134_3434286995 X-MC-Loop-Signature: 1576536737134:3235342223 X-MC-Ingress-Time: 1576536737134 Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id 69D7D7F035; Mon, 16 Dec 2019 14:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=QREh5P 9Vyt5hbaeNndNN9+74W5Q=; b=1E2desuyuTbBfNCZgNs+YRO1YzG99kJxZK9oiU R3p1vMj32X7FPaJgv1iWmpdg87yfRZMuh1kalg6H8GKQ3yzXWrgrPMhYfiZ8AUqP FzJ1ShqLJM/6QF/1mfmrLVmaG1q8KdLRJacp/LB/Boz2z490p7K7o2DO5pPQG5n4 Q7Jlg= Received: from mail.jurta.org (m91-129-107-186.cust.tele2.ee [91.129.107.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id DA03A7EFC4; Mon, 16 Dec 2019 14:52:08 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a19 From: Juri Linkov To: Allen Li Subject: Re: bug#38265: 26.3; lock file is too easy to steal Organization: LINKOV.NET References: <808soc2rhl.fsf@felesatra.moe> <87v9rep4hy.fsf@mail.linkov.net> <804kyw35tp.fsf@felesatra.moe> Date: Mon, 16 Dec 2019 02:04:39 +0200 In-Reply-To: <804kyw35tp.fsf@felesatra.moe> (Allen Li's message of "Thu, 21 Nov 2019 20:14:58 -0800") Message-ID: <87y2vd16g8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: 0 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrvddtiedgtdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvffuohhfffgjkfgfgggtgfesthekredttderjeenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucffohhmrghinhepghhnuhdrohhrghenucfkphepledurdduvdelrddutdejrddukeeinecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrudekiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurghrkhhfvghlihhnvgesfhgvlhgvshgrthhrrgdrmhhovgenucevlhhushhtvghrufhiiigvpedt Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 38265 Cc: 38265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) >>> The default ask-user-about-lock is too easy to miss. >>> >>> For example, if one were typing "asparagus", they would likely steal = the >>> lock without even realizing that it happened (the "a" triggers the >>> prompt on buffer modification and the "s" steals the lock). >>> >>> It would be nice to have the prompt be harder to hit accidentally, su= ch >>> as making all of the keys uppercase or having to type them out like >>> yes/no (but the latter might be too heavyweight). Or the prompt shou= ld >>> have a short timeout before allowing the user to respond (like how >>> yes-or-no-p does when you provide an invalid response). >> >> On the request in https://lists.gnu.org/archive/html/emacs-devel/2019-= 11/msg00517.html >> recently =E2=80=98(discard-input)=E2=80=99 was removed from =E2=80=98r= ead-char-from-minibuffer=E2=80=99. >> Should it be put back? >> >> ask-user-about-supersession-threat uses read-char-from-minibuffer, so = if >> it contained =E2=80=98(discard-input)=E2=80=99 it could benefit from d= iscarding such >> inadvertent input as "s". >> >> But what about the case of keyboard macros like in the link above? >> What if the user recorded a keyboard macro to input that "s" intention= ally? > > We could check executing-kbd-macro and disable "interactive safety > features". That seems like a valid use case of executing-kbd-macro. Yes, executing-kbd-macro could help. Have you tried it? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 14:22:25 2019 Received: (at 38265) by debbugs.gnu.org; 26 Dec 2019 19:22:25 +0000 Received: from localhost ([127.0.0.1]:56253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikYiH-0003GC-6z for submit@debbugs.gnu.org; Thu, 26 Dec 2019 14:22:25 -0500 Received: from mail-pg1-f174.google.com ([209.85.215.174]:40009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ikYiD-0003Fr-H9 for 38265@debbugs.gnu.org; Thu, 26 Dec 2019 14:22:24 -0500 Received: by mail-pg1-f174.google.com with SMTP id k25so13264984pgt.7 for <38265@debbugs.gnu.org>; Thu, 26 Dec 2019 11:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=felesatra-moe.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=HeK9+y8BcYWNxOsTMpQkKWQSrgogjjLOeIBEy6PTDz0=; b=oFXocliOidiATM6CHf3bKMDr1xQcBgEFTo3N7Rmei2ZVm6DOByOyPLedi7aSVVNVIJ V1bWa/+zZ6VE/lt6AIYM0vetyeKRdFl/uRR0IvT4c5W5oCPRoj2BSSQ0J6hMCTlB0ROK 7FQQI+/aeJLBVmnYmYp8wznl4qJUELeJ1EKP2rsncQCd2K9sf1Qy1LBxkLRxuLVudWlg HWWBPa1/s8uoLhoEurRuxbbCw+zct59IfuGB+kA+Iu83RnrPo7zieIGhqfw/ZsAyfuEg KPpRn8DY1YUreA5Ij6mPjdwRcPVoF/K2VvKlmO+7pCWK6IxOVYlhy2sxKYWGRUC3vx8V oZNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=HeK9+y8BcYWNxOsTMpQkKWQSrgogjjLOeIBEy6PTDz0=; b=OzIAx7cj1CDxrJsP6OnqMlDBmzz0tQMa/fa9et71CbjrHPN5cPlse38R5Bak900w0y KvZ7viX68Hp/K70Oyh3QtbmrGdJLf1tyYAjPZV3JEoirIMfbmpPSEiZxh6xiqkaAlC6u vms44Dfnx8ZXDMU2kqubyLwEK/5KQII8AAbw/fhecV1rHH8esJpEwtep4S7rjF21MPsk KKTfCO9nRWpcZDh1pFy5djLAtiDGxfcXvE6k7kxtNeunZJ0O31ZrWi8R6AjpUI+mrvrX tWz+PwWE5e/Ho9CPUK4H3TfA9ZIFvI3MQaK3hFmYZz99T9Gvq8x+PzEtOFgwTBTVmPQH Ff8Q== X-Gm-Message-State: APjAAAUcEdGmzHPxO0QoaOFzkjPR1VZmpdurAMqgniKwQfrQ59x6imrP +FcJujjCSRvo9JcRwGNOnZHkiw== X-Google-Smtp-Source: APXvYqzsjUjfhb5X7mejsA5SN0shZqEihrIxdND4XVCS6Y2A6x2JPAOpilo6ydIMui9mtnBuZ0et+A== X-Received: by 2002:aa7:8f3d:: with SMTP id y29mr51956766pfr.183.1577388135535; Thu, 26 Dec 2019 11:22:15 -0800 (PST) Received: from localhost ([2600:1700:7270:7d1f:fa59:71ff:fe00:10cc]) by smtp.gmail.com with ESMTPSA id y203sm16848802pfb.65.2019.12.26.11.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Dec 2019 11:22:15 -0800 (PST) From: Allen Li To: Juri Linkov Subject: Re: bug#38265: 26.3; lock file is too easy to steal References: <808soc2rhl.fsf@felesatra.moe> <87v9rep4hy.fsf@mail.linkov.net> <804kyw35tp.fsf@felesatra.moe> <87y2vd16g8.fsf@mail.linkov.net> Date: Thu, 26 Dec 2019 11:22:14 -0800 In-Reply-To: <87y2vd16g8.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 16 Dec 2019 02:04:39 +0200") Message-ID: <80a77eopsp.fsf@felesatra.moe> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38265 Cc: 38265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >>>> The default ask-user-about-lock is too easy to miss. >>>> >>>> For example, if one were typing "asparagus", they would likely steal t= he >>>> lock without even realizing that it happened (the "a" triggers the >>>> prompt on buffer modification and the "s" steals the lock). >>>> >>>> It would be nice to have the prompt be harder to hit accidentally, such >>>> as making all of the keys uppercase or having to type them out like >>>> yes/no (but the latter might be too heavyweight). Or the prompt should >>>> have a short timeout before allowing the user to respond (like how >>>> yes-or-no-p does when you provide an invalid response). >>> >>> On the request in https://lists.gnu.org/archive/html/emacs-devel/2019-1= 1/msg00517.html >>> recently =E2=80=98(discard-input)=E2=80=99 was removed from =E2=80=98re= ad-char-from-minibuffer=E2=80=99. >>> Should it be put back? >>> >>> ask-user-about-supersession-threat uses read-char-from-minibuffer, so if >>> it contained =E2=80=98(discard-input)=E2=80=99 it could benefit from di= scarding such >>> inadvertent input as "s". >>> >>> But what about the case of keyboard macros like in the link above? >>> What if the user recorded a keyboard macro to input that "s" intentiona= lly? >> >> We could check executing-kbd-macro and disable "interactive safety >> features". That seems like a valid use case of executing-kbd-macro. > > Yes, executing-kbd-macro could help. Have you tried it? Tried how? I have not tried to patch the (discard-input) change to check executing-kbd-macro, nor tried whether the (discard-input) change addresses the concern in the original bug. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 08:40:54 2021 Received: (at 38265) by debbugs.gnu.org; 11 Aug 2021 12:40:55 +0000 Received: from localhost ([127.0.0.1]:33817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDnXS-0005Mk-NP for submit@debbugs.gnu.org; Wed, 11 Aug 2021 08:40:54 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDnXQ-0005MT-Gj for 38265@debbugs.gnu.org; Wed, 11 Aug 2021 08:40:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N8PTrA6sexu5/GrTHxkYgLzeXHiiP56g2Kja6aHr8/U=; b=eQgQp9wCXkyL9cCn+XArcmmKw+ Ipijk9Bnp4ZMQdXSzg46bn16ejlnX8xBCFJlqUEiz0qb3TpCYh5YaZQE6yMcrmiIjmJzyYSS2Rq0P PGzcIgxKt59DYMeShTqyDpBAs+arCIaidDVdYvUkszd5boto5PUfmPGi4vkrFR5C2Q50=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDnXG-00082P-4v; Wed, 11 Aug 2021 14:40:46 +0200 From: Lars Ingebrigtsen To: Allen Li Subject: Re: bug#38265: 26.3; lock file is too easy to steal References: <808soc2rhl.fsf@felesatra.moe> Date: Wed, 11 Aug 2021 14:40:40 +0200 In-Reply-To: <808soc2rhl.fsf@felesatra.moe> (Allen Li's message of "Tue, 19 Nov 2019 00:35:34 -0800") Message-ID: <87v94cqhmf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Allen Li writes: > The default ask-user-about-lock is too easy to miss. > > For example, if one were typing "asparagus", they would likely steal the > lock without even realizing that it happened (the "a" triggers the [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38265 Cc: 38265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Allen Li writes: > The default ask-user-about-lock is too easy to miss. > > For example, if one were typing "asparagus", they would likely steal the > lock without even realizing that it happened (the "a" triggers the > prompt on buffer modification and the "s" steals the lock). > > It would be nice to have the prompt be harder to hit accidentally, such > as making all of the keys uppercase or having to type them out like > yes/no (but the latter might be too heavyweight). Or the prompt should > have a short timeout before allowing the user to respond (like how > yes-or-no-p does when you provide an invalid response). I think making the lock prompt more extensive would be pretty annoying -- we only use yes-or-no-p (and related) when doing something destructive or dangerous, and stealing the lock isn't that dangerous. So I think the current level of prompting is fine, and if you want more prompting, then it should be easy enough to redefine/advice ask-user-about-lock to be harder to get past, and I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 11 08:40:58 2021 Received: (at control) by debbugs.gnu.org; 11 Aug 2021 12:40:58 +0000 Received: from localhost ([127.0.0.1]:33820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDnXV-0005Mz-Vs for submit@debbugs.gnu.org; Wed, 11 Aug 2021 08:40:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mDnXU-0005MZ-Ti for control@debbugs.gnu.org; Wed, 11 Aug 2021 08:40:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=K4nVchDL7Ikpd/4sHDZPLDVn75seTIRIMcG01pz7igA=; b=Cgh8k6MCweb4R6/yUGa82Q/hRf H/T4lzXx/v8jgRew1aMI7yZiAczXp22qJNMgUKs8xx8WSwZ8Eqrp6fHZf4IDlEJx3pOR1dhiqIgoO CPAUhSaxIm731Sec0s49DnLsYCIie0QgW0o3cQsh9L6uDmP1Mp0I/dnKdZjtN4vLQ8+Y=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mDnXM-00082X-V8 for control@debbugs.gnu.org; Wed, 11 Aug 2021 14:40:51 +0200 Date: Wed, 11 Aug 2021 14:40:48 +0200 Message-Id: <87tujwqhm7.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38265 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 38265 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 38265 quit From unknown Sat Jun 21 05:03:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 09 Sep 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator