GNU bug report logs - #38248
help-follow-symbol silent when no symbol was found

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#38248: closed (help-follow-symbol silent when no symbol was
 found)
Date: Fri, 22 Nov 2019 20:14:04 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 22 Nov 2019 21:13:03 +0100
with message-id <CAAeL0SRueu_8rEcq0DgPTFBCT3hUgZ10SK8H2q4ssUGNcthgxg <at> mail.gmail.com>
and subject line Re: bug#38248: help-follow-symbol silent when no symbol was found
has caused the debbugs.gnu.org bug report #38248,
regarding help-follow-symbol silent when no symbol was found
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
38248: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38248
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: help-follow-symbol silent when no symbol was found
Date: Sun, 17 Nov 2019 20:40:33 +0100

[Message part 3 (text/plain, inline)]

Package: emacs
Severity: minor
Tags: patch

Currently, help-follow and help-follow-mouse signal an error if there's
nothing to follow. However, help-follow-symbol does not, which means that
C-c C-c in the help buffer when over an arbitrary non-symbol does nothing
and says nothing.

That's not just inconsistent, but a bit disconcerting, as sometimes
following a symbol can be slow. In my build, it takes a second or more to
show the symbol documentation, so when there's no symbol I stand waiting
for something to happen for a couple of seconds.

The following patch fixes that. The only reason against I can think of is
when `help-follow-symbol' is called from elisp, because it will now signal
an error. However, at least in the Emacs sources help-follow-symbol is
never called from elisp, just as a keybinding or menu entry.

[Message part 4 (text/html, inline)]

[0001-lisp-help-mode.el-help-follow-symbol-Signal-no-symbo.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 38248-done <at> debbugs.gnu.org
Subject: Re: bug#38248: help-follow-symbol silent when no symbol was found
Date: Fri, 22 Nov 2019 21:13:03 +0100

[Message part 7 (text/plain, inline)]

Committed as b7d4c5d1d1b55fea8382663f18263e2000678be5

[Message part 8 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.