From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 10:32:48 2019 Received: (at submit) by debbugs.gnu.org; 16 Nov 2019 15:32:49 +0000 Received: from localhost ([127.0.0.1]:39589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW048-00066v-Go for submit@debbugs.gnu.org; Sat, 16 Nov 2019 10:32:48 -0500 Received: from lists.gnu.org ([209.51.188.17]:55295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW047-00066o-2i for submit@debbugs.gnu.org; Sat, 16 Nov 2019 10:32:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53387) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iW045-000201-LG for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 10:32:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iW042-0002su-Tx for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 10:32:44 -0500 Received: from mail-yw1-xc34.google.com ([2607:f8b0:4864:20::c34]:35679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iW041-0002ra-TC for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2019 10:32:42 -0500 Received: by mail-yw1-xc34.google.com with SMTP id r131so4202223ywh.2 for ; Sat, 16 Nov 2019 07:32:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=+ORyIkCKAXwJuMyYRlL64dliQOFWn4OThAVfiBfGYQI=; b=J2oIXClHXFJSWirwwF+zw4sTx723FHQh/I6HlOCDwdBHInZDLgZNrxHdbAn8pxoYA4 MyrN93KlRSCHrnPP8NJ4yrBVLvtkIAhpdCNmHhUhf+E63eFU0GTzRrpfU5oI7uygc5gA ZdDLWefGOdvVTltm2TfftmxE3TxQPTamWWQ8aWM6ZSnWoa6+9qV9gV08p+9jDuk7myBS rggIv7cxdQgxjdVEGX9lnymqfzZkdCef5USY9TQYlTYnBWgn80goYkT0zNXpeR8qCt6H 0Of4wDF9OedZxAkyRIHw+JgGq0lOz8bwLVedIomKxN08ho/MPqhEqcPbA+NM2SD4tVFe /Niw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=+ORyIkCKAXwJuMyYRlL64dliQOFWn4OThAVfiBfGYQI=; b=CMDvV8iQUffGSLc6HoalsAHiZkpeJFzieYu6SnNmN7Tx5YlKKI+p7rboRpV6Lz8SKc Zg7URtUGu06VdUEjUmhIaKDvUsYdAOqHtxQTKJie3ZTWbWnl2mZgA3rb3cIgCfoXaHGP cX+WY2qx4xEnZuinqyxyfOM4ASy4kaVtqJCU0LIzP8aFq3CPgCd3llSGzGwkWA5TMKV1 69Wx/u93JJxT+8gahfZMMMK/mF8Qvvh910VE+vJFz48Cp99sj+bGdZxVuNZBrkGB8yux +eHIKIToFULUsHuQKfUjqpElOwOEu3r4f4wRfrm5XlKDaJMiBfanaonn7+K+hIaVYWKa dweA== X-Gm-Message-State: APjAAAXVyfmrREddpnT4mthvel53ZnDzhzgukC2FPdWx7Jbv8bsSVoN7 W8Vk5DfgeSlBvv6qvM/AsKD7OZnjS5Q= X-Google-Smtp-Source: APXvYqxWUui43Nqm0cFadA6P4OlQAHUdBw6FPupImfJJ5lkkUB4P1DkC8CWCNSW1SWikgK8Wl18B2g== X-Received: by 2002:a81:4609:: with SMTP id t9mr13062170ywa.48.1573918360504; Sat, 16 Nov 2019 07:32:40 -0800 (PST) Received: from [192.168.0.104] (cblmdm134-228-15-233.buckeyecom.net. [134.228.15.233]) by smtp.gmail.com with ESMTPSA id w67sm8116721yww.16.2019.11.16.07.32.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Nov 2019 07:32:40 -0800 (PST) From: JD Smith Content-Type: multipart/alternative; boundary="Apple-Mail=_DFFB44DD-2F6F-4339-A2A3-F74AFE3BDB35" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\)) Subject: ido does not respect `ido-read-file-name-non-ido` on directory reads Message-Id: <12EC0257-0C20-4FB6-9E06-1F9438E6218C@gmail.com> Date: Sat, 16 Nov 2019 10:32:39 -0500 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3594.4.19) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::c34 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_DFFB44DD-2F6F-4339-A2A3-F74AFE3BDB35 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 While working with the tramp maintainer to implement = `tramp-rename-files` (which ido interferes with), I=E2=80=99ve found = that ido does not respect `ido-read-file-name-non-ido` when a directory = is being read instead of a filename. This happens for example if the = `read-file-name` predicate is `file-directory-p`. I can=E2=80=99t see a = use for ignoring specifically named commands for which the user wishes = to disable ido simply because a directory instead of filename is being = read. So this looks like a bug to me.=20 This could be solved easily by adding a check to the first `cond` stanza = of `ido-read-file-name`: (let (filename) (cond ((and (not (memq this-command ido-read-file-name-non-ido)) (or (eq predicate 'file-directory-p) (eq (and (symbolp this-command) (get this-command 'ido)) 'dir) (memq this-command = ido-read-file-name-as-directory-commands)))= --Apple-Mail=_DFFB44DD-2F6F-4339-A2A3-F74AFE3BDB35 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

While working with the = tramp maintainer to implement `tramp-rename-files` (which ido interferes = with), I=E2=80=99ve found that ido does not respect = `ido-read-file-name-non-ido` when a directory is being read instead of a = filename.  This happens for example if the `read-file-name` = predicate is `file-directory-p`.  I can=E2=80=99t see a use for = ignoring specifically named commands for which the user wishes to = disable ido simply because a directory instead of filename is being = read.  So this looks like a bug to me. 
This could be solved easily by adding = a check to the first `cond` stanza of `ido-read-file-name`:

  (let = (filename)
    = (cond
    =  ((and (not (memq this-command = ido-read-file-name-non-ido))
=   (or (eq predicate = 'file-directory-p)
  =     (eq (and (symbolp this-command)
(get this-command = 'ido)) 'dir)
  =     (memq this-command = ido-read-file-name-as-directory-commands)))
= --Apple-Mail=_DFFB44DD-2F6F-4339-A2A3-F74AFE3BDB35-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 04:41:25 2019 Received: (at 38231) by debbugs.gnu.org; 17 Nov 2019 09:41:25 +0000 Received: from localhost ([127.0.0.1]:40323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWH3Z-0007MJ-Oc for submit@debbugs.gnu.org; Sun, 17 Nov 2019 04:41:22 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWH3X-0007Lq-Qk for 38231@debbugs.gnu.org; Sun, 17 Nov 2019 04:41:20 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWH3O-0005Rw-IP; Sun, 17 Nov 2019 10:41:12 +0100 From: Lars Ingebrigtsen To: JD Smith Subject: Re: bug#38231: ido does not respect `ido-read-file-name-non-ido` on directory reads References: <12EC0257-0C20-4FB6-9E06-1F9438E6218C@gmail.com> Date: Sun, 17 Nov 2019 10:41:09 +0100 In-Reply-To: <12EC0257-0C20-4FB6-9E06-1F9438E6218C@gmail.com> (JD Smith's message of "Sat, 16 Nov 2019 10:32:39 -0500") Message-ID: <87pnhq96x6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: JD Smith writes: > While working with the tramp maintainer to implement `tramp-rename-files` > (which ido interferes with), I’ve found that ido does not respect > `ido-read-file-name-non-ido` when a directory is bei [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38231 Cc: 38231@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) JD Smith writes: > While working with the tramp maintainer to implement `tramp-rename-files` > (which ido interferes with), I=E2=80=99ve found that ido does not respect > `ido-read-file-name-non-ido` when a directory is being read instead of a > filename. This happens for example if the `read-file-name` predicate is > `file-directory-p`. I can=E2=80=99t see a use for ignoring specifically = named commands > for which the user wishes to disable ido simply because a directory inste= ad of > filename is being read. So this looks like a bug to me.=20 Makes sense. I've now made a change along the lines suggested by your code snippet. (In the future, please send patches -- they're easier to deal with.) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 04:41:26 2019 Received: (at control) by debbugs.gnu.org; 17 Nov 2019 09:41:26 +0000 Received: from localhost ([127.0.0.1]:40326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWH3d-0007Mg-W9 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 04:41:26 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWH3b-0007M4-Pj for control@debbugs.gnu.org; Sun, 17 Nov 2019 04:41:25 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWH3U-0005S3-7W for control@debbugs.gnu.org; Sun, 17 Nov 2019 10:41:18 +0100 Date: Sun, 17 Nov 2019 10:41:15 +0100 Message-Id: <87o8xa96x0.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38231 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38231 fixed close 38231 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38231 fixed close 38231 27.1 quit From unknown Sun Jun 22 07:31:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 15 Dec 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator