GNU bug report logs - #38223
grep >=2.28 cannot handle -wF correctly under LANG=ja_JP.eucjp

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
Cc: 38223 <at> debbugs.gnu.org
Subject: bug#38223: grep >=2.28 cannot handle -wF correctly under LANG=ja_JP.eucjp
Date: Sun, 1 Dec 2019 06:42:29 +0800

On Sun, Nov 17, 2019 at 2:45 PM Jim Meyering <jim <at> meyering.net> wrote:
>
> On Sat, Nov 16, 2019 at 8:36 PM Jim Meyering <jim <at> meyering.net> wrote:
> > On Sat, Nov 16, 2019 at 4:02 PM Norihiro Tanaka <noritnk <at> kcn.ne.jp> wrote:
> > > On Sat, 16 Nov 2019 11:00:38 -0800
> > > Jim Meyering <jim <at> meyering.net> wrote:
> > >
> > > > I've pushed the complete fix here:
> > > > https://git.savannah.gnu.org/cgit/grep.git/commit/?id=090a4dbe03951e427f03f83be424caacc3303799
> > > >
> > > > I've also fixed the comment and a variable name and updated gnulib to latest.
> > >
> > > After patched, I found extreamly slowdown.
> > >
> > >   yes $(printf %040d 0) | head -1000000 >k
> > >   time -p env LC_ALL=ja_JP.eucjp src/grep -F -w 0 k
> > >
> > > First patch fixes it, and second improves performance more.
> >
> > Nice. Thank you!
> > Those look fine, at first glance, modulo these minor changes that I
> > expect to merge into the latter:
>
> Thanks again, Norihiro Tanaka.
> I have also adjusted commit log wording and added comments for the new
> mbclen parameter. I've attached the two commits that I expect to push
> tomorrow, assuming no objection.

That performance regression deserved a test suite addition, so I've done this:

    tests: add test that would have detected -Fw perf regression
    * tests/mb-non-UTF8-perf-Fw: New file. Detect v3.3-22-g090a4db's
    performance regression.
    * tests/Makefile.am (TESTS): Add it.

Pushed as https://git.sv.gnu.org/cgit/grep.git/commit/?id=fdd45db167c9e5

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.