GNU bug report logs - #38219
Error on leaving Ediff after killing vital buffer

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Richard Copley <rcopley <at> gmail.com>
Subject: bug#38219: closed (Re: bug#38219: Error on leaving Ediff after
 killing vital buffer)
Date: Mon, 18 Nov 2019 21:55:11 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#38219: Error on leaving Ediff after killing vital buffer

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 38219 <at> debbugs.gnu.org.

-- 
38219: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38219
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juri Linkov <juri <at> linkov.net>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Richard Copley <rcopley <at> gmail.com>, 38219-done <at> debbugs.gnu.org
Subject: Re: bug#38219: Error on leaving Ediff after killing vital buffer
Date: Mon, 18 Nov 2019 23:53:29 +0200

>> You could argue that 'ediff' already breaks
>>
>> (defalias 'y-or-n-p 'yes-or-no-p)
>>
>> They would probably say that consulting 'this-command' after a
>> 'y-or-n-p' "has worked ever since".  Guess whose argument wins.
>
> Good example.  This means that 'ediff' is broken, here is the fix:

Now pushed and closed. 

[Message part 3 (message/rfc822, inline)]

From: Richard Copley <rcopley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, Juri Linkov <juri <at> linkov.net>
Subject: Error on leaving Ediff after killing vital buffer
Date: Fri, 15 Nov 2019 13:50:32 +0000

[Message part 4 (text/plain, inline)]

If you kill one of Ediff's vital buffers, then try to leave Ediff (by
typing q in the control window), there is an error.

The error is:
ediff-visible-region: You have killed a vital Ediff buffer---you must leave
Ediff now!

Recipe from 'emacs -Q' (Windows GUI build):

* Visit a file under version control with unstaged changes.
* [M-x ediff-revision RET RET RET RET]
* In the main frame, kill one of the buffers being diffed
* In the Ediff control window frame, type [q y]

Bisected to this commit:

a26a8cc1c85f29fb11209c16d53a8ae4e4ab7ced
Author: Juri Linkov <juri <at> linkov.net>
Date: Sun Nov 10 00:04:13 2019 +0200

'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer (bug#38076)

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.