From unknown Tue Jun 24 01:41:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38219: Error on leaving Ediff after killing vital buffer Resent-From: Richard Copley Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 38219@debbugs.gnu.org, juri@linkov.net X-Debbugs-Original-To: bug-gnu-emacs@gnu.org, Juri Linkov Received: via spool by submit@debbugs.gnu.org id=B.157382586720731 (code B ref -1); Fri, 15 Nov 2019 13:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Nov 2019 13:51:07 +0000 Received: from localhost ([127.0.0.1]:35842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc0A-0005OJ-Kq for submit@debbugs.gnu.org; Fri, 15 Nov 2019 08:51:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:42133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc06-0005O8-Tv for submit@debbugs.gnu.org; Fri, 15 Nov 2019 08:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55477) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVc05-0004pN-Hp for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVc04-0001jc-BQ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:01 -0500 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:43895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVc04-0001iR-6k for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:00 -0500 Received: by mail-oi1-x234.google.com with SMTP id l20so8621220oie.10 for ; Fri, 15 Nov 2019 05:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=FdPvMu0VCy4xU/G4fWzRFWqYW3h0ZcZbUNTqRyB3f6Y=; b=mDwviR6vGn1mLQiN7vcRrozO2fzZGG81eXnVz1dGwuBLHWd9KJgEuyxlm5F/IYmXGQ PMbPiTtXzG3QGyTqPcRKocnTddK1HnXlrK1taSjQLSnK0eGMIOHhwh1T6aT8oEmNyVxr ffd2y7+nwdrsT47ZFklyubjLPDB549vES/k7XuMXKEt+nls+nS/XaMcNHErLxyBm5vAV KiAOvbmJ8AWI2XQ1zDNYwvkKZhIPi/X5JfB3fg/3tc6ZJ2XzozLRYsL6G9+uY7sY9kEh kAXpUWixfIj/GVEaTeaEZ/4ELnrfbHscZ8PqBpXKZYC54TTWtKWNGPUw5LxDXYJokO5Z KLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FdPvMu0VCy4xU/G4fWzRFWqYW3h0ZcZbUNTqRyB3f6Y=; b=DYpxCHi7m6QWr7fd7HsCWGBozsZeGJbtiA7z1V/5l6k89WAVvNCw1qDPik2yjzLiHH ivImH6lQtMvW6BMyEKNYx+v0venZo82x++CR1dSxqBexczweF7VTvKJ0kR34n3jhivoz ZlsTAAve5AL76fjsYoK0raiwixturrsTClAj9igEAFqY42nLtZIJdEUsgH+/6CWdVRBV hb1WXpiS6Vr8J4KqrcTyK6oN53pE0LJx/tKdLW8Czt8E/CNo+u6wbl1/anAmOJnYWWzv JeLgU5YH+T+fCV8+L+vaIGDYSjtK/u345JeMaWiLxlfAjDHigezsu0UQH688eMgxVYyB /E/Q== X-Gm-Message-State: APjAAAWoMRBZWyQf5z1wRzymH/E4XB0g1Kg1bEg3XppsDDQZLVUNqktm hwhHfgGgtSbMABAe7ErYP54m3fJWZEvgklKJZHYkvZts X-Google-Smtp-Source: APXvYqxPNnSc++Oc5p2M9E9R239ZDbV4f0Rx0R79fnicE1yWp7kgNRzlcyxrCdFEGWBZ4UHF3Zn+aHS96w7fbBnRMO8= X-Received: by 2002:a05:6808:352:: with SMTP id j18mr8260701oie.67.1573825858083; Fri, 15 Nov 2019 05:50:58 -0800 (PST) MIME-Version: 1.0 From: Richard Copley Date: Fri, 15 Nov 2019 13:50:32 +0000 Message-ID: Content-Type: multipart/alternative; boundary="00000000000035a0dc059762e3eb" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::234 X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000035a0dc059762e3eb Content-Type: text/plain; charset="UTF-8" If you kill one of Ediff's vital buffers, then try to leave Ediff (by typing q in the control window), there is an error. The error is: ediff-visible-region: You have killed a vital Ediff buffer---you must leave Ediff now! Recipe from 'emacs -Q' (Windows GUI build): * Visit a file under version control with unstaged changes. * [M-x ediff-revision RET RET RET RET] * In the main frame, kill one of the buffers being diffed * In the Ediff control window frame, type [q y] Bisected to this commit: a26a8cc1c85f29fb11209c16d53a8ae4e4ab7ced Author: Juri Linkov Date: Sun Nov 10 00:04:13 2019 +0200 'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer (bug#38076) --00000000000035a0dc059762e3eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If you kill one of Ediff's vital buffers, then try to = leave Ediff (by typing q in the control window), there is an error.

= The error is:
ediff-visible-region: You have killed a vital Ediff buffer= ---you must leave Ediff now!

Recipe from 'emacs -Q' (Windows= GUI build):

* Visit a file under version control with unstaged chan= ges.
* [M-x ediff-revision RET RET RET RET]
* In the main frame, kill= one of the buffers being diffed
* In the Ediff control window frame, ty= pe [q y]

Bisected to this commit:

a26a8cc1c85f29fb11209c16d53= a8ae4e4ab7ced
Author: Juri Linkov <juri@linkov.net>
Date: Sun Nov 10 00:04:13 2019 +0200

= 9;y-or-n-p' now uses the minibuffer to read 'y' or 'n' = answer (bug#38076)
--00000000000035a0dc059762e3eb-- From unknown Tue Jun 24 01:41:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38219: Error on leaving Ediff after killing vital buffer Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Nov 2019 16:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Richard Copley , 38219@debbugs.gnu.org, juri@linkov.net Received: via spool by 38219-submit@debbugs.gnu.org id=B38219.15738357704669 (code B ref 38219); Fri, 15 Nov 2019 16:37:02 +0000 Received: (at 38219) by debbugs.gnu.org; 15 Nov 2019 16:36:10 +0000 Received: from localhost ([127.0.0.1]:37284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVeZu-0001DF-2P for submit@debbugs.gnu.org; Fri, 15 Nov 2019 11:36:10 -0500 Received: from mout.gmx.net ([212.227.15.15]:56501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVeZs-0001Cu-3y for 38219@debbugs.gnu.org; Fri, 15 Nov 2019 11:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1573835758; bh=g3t1114MNngRhOB0AOX6VXJEnI4v8T6JULxOvH2TERw=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=MLypcehSNpK5WZMkn9g2JGio3w2fEij18/uVbCPxEzk4EY7CvrwwH0OcV2l0cSDXw DQjlD1TPaHbQfNbdYIcHKgaLcdg0GtyRd4IujoTISZKGDxuWFII1l6dmaoE5i9QeGc 7a4GhOPUr+LTtzgum7odpsAFFUB6l2WhEMUQ27Qo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([212.95.5.132]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MCKFk-1idw233LvO-009Ttf; Fri, 15 Nov 2019 17:35:57 +0100 References: From: martin rudalics Message-ID: Date: Fri, 15 Nov 2019 17:35:58 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------02B899AF738A7C9F5ABFE397" Content-Language: de-AT X-Provags-ID: V03:K1:Ua1/hH2pBqoR+TeTNQh6tiF2nTrR43Kp3DzueAt8a8O5U+/AhjS ZBPOIsgGEbD94JWgROKf3AE3EGsF5+/S5bplqfKUf40DiwMdEKNLlPP2Xy3PHFpQ6VkxGUg a0rILh6Bq55fJuJV+HdDips9v8TGBzwCWM3tSjW8ykVDBhBElPjqG9sLqCyIcIR9Dooi/MN DCQVM2UCHh939bkV9LjeA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xphdysaJTF8=:t8XbRK6U/qcKAh4+CutDkE tdSWsDAjqWvXYqkqhgC/xHDMpm5sVyP0mb59rvjJhPAw5RGSOEkufV7G1S2zWgO6QDej6ZgVT uJHCXBh7SrUMbEI9UCEgslx1nKhSx7TwzVCaOE59laLUfZcSgF2nECX/T4Vh4USY7XbHODpOz 2+ypert7CFIGbmKmjriTPb2WtUq/zZvCU0mZalinLund6xq62NtqtMJhbt6/9uivgZzZ69Kij gC85G4NdkBoG7qPFeQyTomSNYTw2CZ/HPjcrro/hZTAiZsuS19Dmd+jFt9CWXaekcDigu2OSr sb1aV3nynjsdXPe/IfkEk2X3Rnr+YzPD1/caRqZotWzXVqqgQwCU9fU24X5jY9hCyMCrqCPue iANpyIhlyiZE+EDLAHn0YGCYkwCmevc3H3GKKHrptLGujlfG3Fj6gfVbmCTWS3ez4QsCQ4/NI ke5hMtULBKZ4aTrU/Nb95kUrUDb56v/XIbmUvWNEPgTrlOqS6OjkLgFjRCVqCDKyKmu3ctIpb BbODsBM06IUaF7M/VJOq031icQiOk7z2XjlyOAugiaiyQkIg9lI8hyRqNXkSVd9NQ5WkI/MIH s+IAL2CZBRE3hNHYK8MpGZTbhN5/pQkFEwlY9JNcj2fcIeUMD5XNjQLk24UkXnbdHz0nftVNp ueM/lMWYTnbjidg51dBtaiGshKoebsmR2LRdsTBYwlCno860g+skpGSfYEwo4lWt8/treCYzx wlOdpvRJJtj5H7zIU0cx3DnAzOugas0bV6IMYN5c9sWk3PO44lnYJAp7CLzVFUwQj7yCadT6f miEr5kgN02YBhaxhjLutMMqtANNUgNkWSGRlhAvh31262coM9UB/3EasrrOMdPZ4FOuH4MLVO bE+zH8ryegYjp3Ap2/fvAmTkrbjYV/muLlWGVzO1RTRElnxHrquE/X1N9TpW3bljjL9LgcEiF MjWK7HhYdGc/XNHGEMVqw6kwx7ZJQQ3rrAsmL0YDJdkiNbg3iKqpjzEkqEk4rOerX/+4V9XTE wqmPoejtd4WEjoc8Roo2WzcgXfgHcy9Z3WNQGBG8QwHSomMNwzOuRmZEZXSLY2FVaETGR68/0 8WoAORGnczY92VQjk8B/cY9Zj1UNvm0yByIEpo7FhrmeNx1jtZkzj8nKbV0+vv6B+cjTTcH/k KAZisO8ZKpWFehpRANgs9atICkngKTltD8YEw7T+wURgJ4H7qBsh5h6/vSIb52VnaXd/ALz0d OkLXBJP5FFj+gLcmkuyBMU5gLyGDIaYQ80+vDdQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------02B899AF738A7C9F5ABFE397 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > If you kill one of Ediff's vital buffers, then try to leave Ediff (by > typing q in the control window), there is an error. > > The error is: > ediff-visible-region: You have killed a vital Ediff buffer---you must leave > Ediff now! 'y-or-n-p' mangles 'this-command'. Something like the attached patch should fix that. martin --------------02B899AF738A7C9F5ABFE397 Content-Type: text/plain; charset=UTF-8; name="subr.el.diffs" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="subr.el.diffs" ZGlmZiAtLWdpdCBhL2xpc3Avc3Vici5lbCBiL2xpc3Avc3Vici5lbAppbmRleCBlYWVjMjIz NTg1Li42OGUyNWM5NmQ5IDEwMDY0NAotLS0gYS9saXNwL3N1YnIuZWwKKysrIGIvbGlzcC9z dWJyLmVsCkBAIC0yODI4LDcgKzI4MjgsOCBAQCB5LW9yLW4tcAogCQkgICAgKGNvbmNhdCBw cm9tcHQKIAkJCSAgICAoaWYgKG9yICh6ZXJvcCBsKSAoZXEgP1xzIChhcmVmIHByb21wdCAo MS0gbCkpKSkKIAkJCQkiIiAiICIpCi0JCQkgICAgKGlmIGRpYWxvZyAiIiAiKHkgb3Igbikg IikpKSkpKQorCQkJICAgIChpZiBkaWFsb2cgIiIgIih5IG9yIG4pICIpKSkpKQorICAgICAg ICAob2xkLXRoaXMtY29tbWFuZCB0aGlzLWNvbW1hbmQpKQogICAgIChjb25kCiAgICAgIChu b25pbnRlcmFjdGl2ZQogICAgICAgKHNldHEgcHJvbXB0IChmdW5jYWxsIHBhZGRlZCBwcm9t cHQpKQpAQCAtMjg1OCw2ICsyODU5LDcgQEAgeS1vci1uLXAKICAgICAobGV0ICgocmV0IChl cSBhbnN3ZXIgJ2FjdCkpKQogICAgICAgKHVubGVzcyBub25pbnRlcmFjdGl2ZQogICAgICAg ICAobWVzc2FnZSAiJXMlYyIgcHJvbXB0IChpZiByZXQgP3kgP24pKSkKKyAgICAgIChzZXRx IHRoaXMtY29tbWFuZCBvbGQtdGhpcy1jb21tYW5kKQogICAgICAgcmV0KSkpCiAKIAwK --------------02B899AF738A7C9F5ABFE397-- From unknown Tue Jun 24 01:41:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38219: Error on leaving Ediff after killing vital buffer Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2019 21:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Richard Copley , 38219@debbugs.gnu.org Received: via spool by 38219-submit@debbugs.gnu.org id=B38219.157393844221956 (code B ref 38219); Sat, 16 Nov 2019 21:08:03 +0000 Received: (at 38219) by debbugs.gnu.org; 16 Nov 2019 21:07:22 +0000 Received: from localhost ([127.0.0.1]:39773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5Ht-0005i4-N9 for submit@debbugs.gnu.org; Sat, 16 Nov 2019 16:07:21 -0500 Received: from cadetblue.birch.relay.mailchannels.net ([23.83.209.28]:40219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iW5Hq-0005hv-OI for 38219@debbugs.gnu.org; Sat, 16 Nov 2019 16:07:19 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B366CE0A2F; Sat, 16 Nov 2019 21:07:17 +0000 (UTC) Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-45-206.trex.outbound.svc.cluster.local [100.96.45.206]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3B919E0556; Sat, 16 Nov 2019 21:07:17 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 16 Nov 2019 21:07:17 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Arch-Oafish: 2b77b7643f504f89_1573938437466_2443735945 X-MC-Loop-Signature: 1573938437465:192469534 X-MC-Ingress-Time: 1573938437465 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id 10FBB7F6FA; Sat, 16 Nov 2019 13:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=DTgb4M5JrgTnB9oyPLOoXt01naI=; b= d85okJPrcdS7HfH/aSnchB3jwtzsiQo0P04sQweRGaEY1Qz/u3ZsXOY5OE4PWcAX dKqJij+Z07M6PM5bIYAWcwgLmz6YPw3UT9+eMlHDggolNNq95RG1I97CUCqEaxOx izZBZ6O588YChucjn4RM4CBtMtRZHfe4p5fS2G7pQR8= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id 774C97F700; Sat, 16 Nov 2019 13:07:09 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a75 From: Juri Linkov Organization: LINKOV.NET References: Date: Sat, 16 Nov 2019 22:18:24 +0200 In-Reply-To: (martin rudalics's message of "Fri, 15 Nov 2019 17:35:58 +0100") Message-ID: <87o8xbu3wn.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > 'y-or-n-p' mangles 'this-command'. Something like the attached patch > should fix that. Can the same be said about read-from-minibuffer? Shouldn't read-from-minibuffer mangle 'this-command'? What it some command wants to check if 'this-command' is 'exit-minibuffer' afterwards? Shouldn't this change better to be localized to callers in ediff, instead of adding such hack? > diff --git a/lisp/subr.el b/lisp/subr.el > index eaec223585..68e25c96d9 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -2828,7 +2828,8 @@ y-or-n-p > (concat prompt > (if (or (zerop l) (eq ?\s (aref prompt (1- l)))) > "" " ") > - (if dialog "" "(y or n) ")))))) > + (if dialog "" "(y or n) "))))) > + (old-this-command this-command)) > (cond > (noninteractive > (setq prompt (funcall padded prompt)) > @@ -2858,6 +2859,7 @@ y-or-n-p > (let ((ret (eq answer 'act))) > (unless noninteractive > (message "%s%c" prompt (if ret ?y ?n))) > + (setq this-command old-this-command) > ret))) > > From unknown Tue Jun 24 01:41:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38219: Error on leaving Ediff after killing vital buffer Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 09:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Richard Copley , 38219@debbugs.gnu.org Received: via spool by 38219-submit@debbugs.gnu.org id=B38219.15739813348603 (code B ref 38219); Sun, 17 Nov 2019 09:03:02 +0000 Received: (at 38219) by debbugs.gnu.org; 17 Nov 2019 09:02:14 +0000 Received: from localhost ([127.0.0.1]:40270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGRi-0002ES-Ec for submit@debbugs.gnu.org; Sun, 17 Nov 2019 04:02:14 -0500 Received: from mout.gmx.net ([212.227.17.21]:56797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWGRh-0002AG-0A for 38219@debbugs.gnu.org; Sun, 17 Nov 2019 04:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1573981324; bh=ygzv57vWNZwtRnrUsWcGXyeqWKVKVFO5rIpH7lRW5TI=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=UkUw0IOXJ4XbqjmJFJKr7pTfHw3sIEwDGNivpj1UJK4I2wzcrqFeBuy3Wa7qXLMWB QarS1BMHtREhd5qg9iTmguh575xhQ8sS7NqvZgd9aTGxWcc3nyUgmg3/8GGBWCnCy2 Eri21LIxD++7+v8yjwHfEcxc8wG5gGC7gmot/4VI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.103] ([212.95.5.179]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MLQxX-1iF0q83GCp-00ISy3; Sun, 17 Nov 2019 10:02:03 +0100 References: <87o8xbu3wn.fsf@mail.linkov.net> From: martin rudalics Message-ID: Date: Sun, 17 Nov 2019 10:02:06 +0100 MIME-Version: 1.0 In-Reply-To: <87o8xbu3wn.fsf@mail.linkov.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-AT Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:KvZMU0S8WnAYt2EycgyZm8Fzd8Evc6kHydbrA+b/jtqtawfswH+ qa+uPPizGc4XDDudz1QziP8cQcnhf2nV84OROWWuDDsUQvLJENucJRpd/2eBFWvWQscVs42 Sr9fXn/Rzng8xrehsntt2Hxgl6OlWjjeLYccOtslCG+lQgyxYuHsdUDwQj+kNGsXdwmBRlQ PBWG6aUn22DjwLXx62M7Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:5CKVy99K4Bk=:0Bd2mpjmhLHuvOH9/YCXiu N4w915JVhNkJYWC7CAAaOh3XoAb9B2ETfaseMWkmMRRoQPMZLCM4YwTJ3zYvkHfQ+kMxB3xbv JG0FVzokReWvV1752ASyFzv/13G6CkVCi++Q2sk19oQ+64ZJ588fwBNOVrVswq1yjFn2gLWIt JAWTWKU3vylFZb24tSqrmqN2o/zmxRFvIlvc65Kfv76RA9bYniW2upFRGT7gId45xF1qSb+Oe xbqDvqVbgcVO6qlBiRFMZe+frka6+DJZ3wwO6ZlKCBCagf+chr0KscIWuhyTE3b8EiEHS5S2m rpRTto4kef1k/I1qnG0BcLLc6BDar07I2VrzpWLfHYfxM7VzDsl+oxnt7TholzB6xU5eBe1AK r80tuB/d1M+4VX/mJRVUlk2xeSosaRIjIm1YME9qdqkdaTppcuErJq+8U2V2QY143l8wJ/iZb SfbOUzOgpoTSzBGLAQJzqZ6Y4hgQa8CstVj1GQctMl+t+/T9AhxMK2i4e70xRBHGeIU/8OBtu yRdgzILd+uCjMuGbRkxZkqGox8JojofdOJLqcSoqzCtH9IfYi9jHBPe+MOdR0zjxWQQ8DqCXF VFyXyM/EdowmeRps43X2wDfpb7Bq1Ou8rTk6Jknfi5nMFO6lqSfj2Ks+ShwutOtct0qv25jrj iMxBtuh7DnEojHIEV97H7i24JOs+dLkVLabnMoF44KKdBHWSAlyEAO7PG5h9M60an55CnCnxB GmGbNFy6rn80KU5xoL/0iqL4kzbzbCuGVDSmZVlhV2z6VCM5/yyXN2nVCec4HE/CM2DJwVrfX WiDjmJayCRuLxwnxYuIi4EIoJNVdVmSHMjQYXwzEbek9Oi7ovB8KAQX/mnj1kmp9VP0hfuQeB fUX+TK6Ob4N/NDJbia8dbDvEqXPNBou+bfi8W5hGmgyE/KyX+WrOO+GN+0Sk6msi+02RmPb6h lI4AU0Hs/CQa6TCgr5veKjJaq9dPJpmvb0giIsC72rdX8bs8L44B4BUL+Kut3SKnGCOriCt0Q Phgr/AbW3wwV2FU8TVr835UwVA99I2IEVy1xVsU3nqahvmNTAM44sCAvboeyLHDXukZyjfYS7 dmJbfFMhvajHyxCbNjnlstPt4MrolXknyRpUua4SQVDC8VogeuWnT/PNwVnybt1qBXARnmGqr uJ//aDvT8b/f5ZdEYpQag76lezF/a4GalTtUyAPC3Rml4SHym+P6GvIRyDwkUehJscjJXAtKW pGgJm71R3NgJx3fQcQyQDB+aKTi8d5+kDQUhWi7zMOMj8yFK+JVnIpJarwtY= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Can the same be said about read-from-minibuffer? > Shouldn't read-from-minibuffer mangle 'this-command'? > What it some command wants to check if 'this-command' > is 'exit-minibuffer' afterwards? Shouldn't this change better > to be localized to callers in ediff, instead of adding such hack? You could argue that 'ediff' already breaks (defalias 'y-or-n-p 'yes-or-no-p) They would probably say that consulting 'this-command' after a 'y-or-n-p' "has worked ever since". Guess whose argument wins. martin From unknown Tue Jun 24 01:41:50 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38219: Error on leaving Ediff after killing vital buffer Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 21:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Richard Copley , 38219@debbugs.gnu.org Received: via spool by 38219-submit@debbugs.gnu.org id=B38219.15740263189259 (code B ref 38219); Sun, 17 Nov 2019 21:32:02 +0000 Received: (at 38219) by debbugs.gnu.org; 17 Nov 2019 21:31:58 +0000 Received: from localhost ([127.0.0.1]:42814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWS9G-0002PH-Db for submit@debbugs.gnu.org; Sun, 17 Nov 2019 16:31:58 -0500 Received: from bumble.birch.relay.mailchannels.net ([23.83.209.25]:47716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWS9E-0002P9-Qc for 38219@debbugs.gnu.org; Sun, 17 Nov 2019 16:31:57 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8D995501407; Sun, 17 Nov 2019 21:31:55 +0000 (UTC) Received: from pdx1-sub0-mail-a42.g.dreamhost.com (100-96-169-13.trex.outbound.svc.cluster.local [100.96.169.13]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 12687501173; Sun, 17 Nov 2019 21:31:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a42.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 17 Nov 2019 21:31:55 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abiding-Squirrel: 4f2eb02e0f82f43a_1574026315313_952377247 X-MC-Loop-Signature: 1574026315313:3493407744 X-MC-Ingress-Time: 1574026315312 Received: from pdx1-sub0-mail-a42.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTP id B91428015C; Sun, 17 Nov 2019 13:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=CPPdOktqtKry3PbrlIi3VCsyN6A=; b= pzaEygJWOQDdil1cgccoMAKCj0FsnZfTdvwvJq5JpbBSAXLjBNltm7CQ5Ti7PFsv X4QxNTdARb4/ypOJrySzry1g+6WEj8RK76Tx5AUU/o0AsDVZ7d/B8Cf6SydE3A5a XyEsZYMQfS0O291DUBznueCzvF+N22VJMjrmZuDNucQ= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a42.g.dreamhost.com (Postfix) with ESMTPSA id 0729B80154; Sun, 17 Nov 2019 13:31:46 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a42 From: Juri Linkov Organization: LINKOV.NET References: <87o8xbu3wn.fsf@mail.linkov.net> Date: Sun, 17 Nov 2019 23:28:36 +0200 In-Reply-To: (martin rudalics's message of "Sun, 17 Nov 2019 10:02:06 +0100") Message-ID: <87a78uxke3.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > You could argue that 'ediff' already breaks > > (defalias 'y-or-n-p 'yes-or-no-p) > > They would probably say that consulting 'this-command' after a > 'y-or-n-p' "has worked ever since". Guess whose argument wins. Good example. This means that 'ediff' is broken, here is the fix: diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a481defe29..c85241b2ea 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -1038,6 +1038,7 @@ ediff-toggle-read-only (format "File %s is under version control. Check it out? " (ediff-abbreviate-file-name file)))) + (setq this-command 'ediff-toggle-read-only) ;; if we checked the file out, we should also change the ;; original state of buffer-read-only to nil. If we don't ;; do this, the mode line will show %%, since the file was @@ -2379,6 +2380,7 @@ ediff-quit " & show containing session group" ""))) (progn (message "") + (setq this-command 'ediff-quit) (set-buffer ctl-buf) (ediff-really-quit reverse-default-keep-variants)) (select-frame ctl-frm) From unknown Tue Jun 24 01:41:50 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Richard Copley Subject: bug#38219: closed (Re: bug#38219: Error on leaving Ediff after killing vital buffer) Message-ID: References: <87a78ssvfq.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 38219 X-Gnu-PR-Package: emacs Reply-To: 38219@debbugs.gnu.org Date: Mon, 18 Nov 2019 21:55:11 +0000 Content-Type: multipart/mixed; boundary="----------=_1574114111-20582-1" This is a multi-part message in MIME format... ------------=_1574114111-20582-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #38219: Error on leaving Ediff after killing vital buffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 38219@debbugs.gnu.org. --=20 38219: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38219 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1574114111-20582-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 38219-done) by debbugs.gnu.org; 18 Nov 2019 21:54:14 +0000 Received: from localhost ([127.0.0.1]:46386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWoyL-0005Ku-VB for submit@debbugs.gnu.org; Mon, 18 Nov 2019 16:54:14 -0500 Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:21483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWoyF-0005Kb-HF for 38219-done@debbugs.gnu.org; Mon, 18 Nov 2019 16:54:12 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5E1B8600F55; Mon, 18 Nov 2019 21:54:06 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D3E24600C85; Mon, 18 Nov 2019 21:54:05 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 18 Nov 2019 21:54:06 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Juvenile-Company: 6fd854b858bccebf_1574114046100_1973984659 X-MC-Loop-Signature: 1574114046099:1000464325 X-MC-Ingress-Time: 1574114046099 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 01003A7004; Mon, 18 Nov 2019 13:54:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=5A4ahyDcV27Tutoy4CkRRNMe+k8=; b= YHQEfhtB5IdkP0h2Q3XrVGNNIdXDYtE4LPz4YlQUwLAYZ3HYZ4yeUSR7OQffAdqB KSg3kfxFj4pN0m1wNVX/FrC1El5ZUzsPhq3DQVf8eNYqG4JvXgw3AdRX9H/1Z8/w AV56lhmRur1W7leoeQoN/J2V5JLqeb74HQRqs59TPXc= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id 8FCFDA7011; Mon, 18 Nov 2019 13:54:00 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov To: martin rudalics Subject: Re: bug#38219: Error on leaving Ediff after killing vital buffer Organization: LINKOV.NET References: <87o8xbu3wn.fsf@mail.linkov.net> <87a78uxke3.fsf@mail.linkov.net> Date: Mon, 18 Nov 2019 23:53:29 +0200 In-Reply-To: <87a78uxke3.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 17 Nov 2019 23:28:36 +0200") Message-ID: <87a78ssvfq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38219-done Cc: Richard Copley , 38219-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> You could argue that 'ediff' already breaks >> >> (defalias 'y-or-n-p 'yes-or-no-p) >> >> They would probably say that consulting 'this-command' after a >> 'y-or-n-p' "has worked ever since". Guess whose argument wins. > > Good example. This means that 'ediff' is broken, here is the fix: Now pushed and closed. ------------=_1574114111-20582-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Nov 2019 13:51:07 +0000 Received: from localhost ([127.0.0.1]:35842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc0A-0005OJ-Kq for submit@debbugs.gnu.org; Fri, 15 Nov 2019 08:51:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:42133) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVc06-0005O8-Tv for submit@debbugs.gnu.org; Fri, 15 Nov 2019 08:51:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55477) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVc05-0004pN-Hp for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVc04-0001jc-BQ for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:01 -0500 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]:43895) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVc04-0001iR-6k for bug-gnu-emacs@gnu.org; Fri, 15 Nov 2019 08:51:00 -0500 Received: by mail-oi1-x234.google.com with SMTP id l20so8621220oie.10 for ; Fri, 15 Nov 2019 05:50:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=FdPvMu0VCy4xU/G4fWzRFWqYW3h0ZcZbUNTqRyB3f6Y=; b=mDwviR6vGn1mLQiN7vcRrozO2fzZGG81eXnVz1dGwuBLHWd9KJgEuyxlm5F/IYmXGQ PMbPiTtXzG3QGyTqPcRKocnTddK1HnXlrK1taSjQLSnK0eGMIOHhwh1T6aT8oEmNyVxr ffd2y7+nwdrsT47ZFklyubjLPDB549vES/k7XuMXKEt+nls+nS/XaMcNHErLxyBm5vAV KiAOvbmJ8AWI2XQ1zDNYwvkKZhIPi/X5JfB3fg/3tc6ZJ2XzozLRYsL6G9+uY7sY9kEh kAXpUWixfIj/GVEaTeaEZ/4ELnrfbHscZ8PqBpXKZYC54TTWtKWNGPUw5LxDXYJokO5Z KLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FdPvMu0VCy4xU/G4fWzRFWqYW3h0ZcZbUNTqRyB3f6Y=; b=DYpxCHi7m6QWr7fd7HsCWGBozsZeGJbtiA7z1V/5l6k89WAVvNCw1qDPik2yjzLiHH ivImH6lQtMvW6BMyEKNYx+v0venZo82x++CR1dSxqBexczweF7VTvKJ0kR34n3jhivoz ZlsTAAve5AL76fjsYoK0raiwixturrsTClAj9igEAFqY42nLtZIJdEUsgH+/6CWdVRBV hb1WXpiS6Vr8J4KqrcTyK6oN53pE0LJx/tKdLW8Czt8E/CNo+u6wbl1/anAmOJnYWWzv JeLgU5YH+T+fCV8+L+vaIGDYSjtK/u345JeMaWiLxlfAjDHigezsu0UQH688eMgxVYyB /E/Q== X-Gm-Message-State: APjAAAWoMRBZWyQf5z1wRzymH/E4XB0g1Kg1bEg3XppsDDQZLVUNqktm hwhHfgGgtSbMABAe7ErYP54m3fJWZEvgklKJZHYkvZts X-Google-Smtp-Source: APXvYqxPNnSc++Oc5p2M9E9R239ZDbV4f0Rx0R79fnicE1yWp7kgNRzlcyxrCdFEGWBZ4UHF3Zn+aHS96w7fbBnRMO8= X-Received: by 2002:a05:6808:352:: with SMTP id j18mr8260701oie.67.1573825858083; Fri, 15 Nov 2019 05:50:58 -0800 (PST) MIME-Version: 1.0 From: Richard Copley Date: Fri, 15 Nov 2019 13:50:32 +0000 Message-ID: Subject: Error on leaving Ediff after killing vital buffer To: bug-gnu-emacs@gnu.org, Juri Linkov Content-Type: multipart/alternative; boundary="00000000000035a0dc059762e3eb" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::234 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000035a0dc059762e3eb Content-Type: text/plain; charset="UTF-8" If you kill one of Ediff's vital buffers, then try to leave Ediff (by typing q in the control window), there is an error. The error is: ediff-visible-region: You have killed a vital Ediff buffer---you must leave Ediff now! Recipe from 'emacs -Q' (Windows GUI build): * Visit a file under version control with unstaged changes. * [M-x ediff-revision RET RET RET RET] * In the main frame, kill one of the buffers being diffed * In the Ediff control window frame, type [q y] Bisected to this commit: a26a8cc1c85f29fb11209c16d53a8ae4e4ab7ced Author: Juri Linkov Date: Sun Nov 10 00:04:13 2019 +0200 'y-or-n-p' now uses the minibuffer to read 'y' or 'n' answer (bug#38076) --00000000000035a0dc059762e3eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
If you kill one of Ediff's vital buffers, then try to = leave Ediff (by typing q in the control window), there is an error.

= The error is:
ediff-visible-region: You have killed a vital Ediff buffer= ---you must leave Ediff now!

Recipe from 'emacs -Q' (Windows= GUI build):

* Visit a file under version control with unstaged chan= ges.
* [M-x ediff-revision RET RET RET RET]
* In the main frame, kill= one of the buffers being diffed
* In the Ediff control window frame, ty= pe [q y]

Bisected to this commit:

a26a8cc1c85f29fb11209c16d53= a8ae4e4ab7ced
Author: Juri Linkov <juri@linkov.net>
Date: Sun Nov 10 00:04:13 2019 +0200

= 9;y-or-n-p' now uses the minibuffer to read 'y' or 'n' = answer (bug#38076)
--00000000000035a0dc059762e3eb-- ------------=_1574114111-20582-1--