GNU bug report logs - #38216
[PATCH] vc-hg: don't pass empty string to 'update' command

Previous Next

Package: emacs;

Reported by: Andrii Kolomoiets <andreyk.mad <at> gmail.com>

Date: Fri, 15 Nov 2019 07:52:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 27.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38216 in the body.
You can then email your comments to 38216 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#38216; Package emacs. (Fri, 15 Nov 2019 07:52:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Andrii Kolomoiets <andreyk.mad <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 15 Nov 2019 07:52:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] vc-hg: don't pass empty string to 'update' command
Date: Fri, 15 Nov 2019 09:51:12 +0200

[Message part 1 (text/plain, inline)]
Hello,

Passing empty string to 'update' command leads to error starting from
mercurial 4.6.

mercurial 4.5.3:
  hg up ""
  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

mercurial 4.6:
  hg up ""
  abort: 00changelog.i@: ambiguous identifier!

Empty revision name is used in vc-retrieve-tag to update to the latest
revision but let's pass nil instead of empty string to 'hg update'.


[0001-lisp-vc-vc-hg.el-Don-t-pass-empty-string-to-hg-updat.patch (application/octet-stream, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38216; Package emacs. (Fri, 15 Nov 2019 08:15:02 GMT) Full text and rfc822 format available.

Message #8 received at 38216 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38216 <at> debbugs.gnu.org
Subject: Re: bug#38216: [PATCH] vc-hg: don't pass empty string to 'update'
 command
Date: Fri, 15 Nov 2019 09:14:20 +0100

Andrii Kolomoiets <andreyk.mad <at> gmail.com> writes:

> Passing empty string to 'update' command leads to error starting from
> mercurial 4.6.
>
> mercurial 4.5.3:
>   hg up ""
>   0 files updated, 0 files merged, 0 files removed, 0 files unresolved
>
> mercurial 4.6:
>   hg up ""
>   abort: 00changelog.i@: ambiguous identifier!

Thanks; applied the patch to Emacs 27.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 15 Nov 2019 08:15:03 GMT) Full text and rfc822 format available.
bug marked as fixed in version 27.1, send any further explanations to 38216 <at> debbugs.gnu.org and Andrii Kolomoiets <andreyk.mad <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Fri, 15 Nov 2019 08:15:03 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38216; Package emacs. (Fri, 15 Nov 2019 09:00:02 GMT) Full text and rfc822 format available.

Message #15 received at 38216 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>,
 Andrii Kolomoiets <andreyk.mad <at> gmail.com>
Cc: 38216 <at> debbugs.gnu.org
Subject: Re: bug#38216: [PATCH] vc-hg: don't pass empty string to 'update'
 command
Date: Fri, 15 Nov 2019 09:59:38 +0100

> Thanks; applied the patch to Emacs 27.

Gets me

../../lisp/vc/vc-hg.el:1467:1:Warning: the function `string-empty-p' is not
    known to be defined.

here.

martin
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#38216; Package emacs. (Fri, 15 Nov 2019 09:06:01 GMT) Full text and rfc822 format available.

Message #18 received at 38216 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Andrii Kolomoiets <andreyk.mad <at> gmail.com>, 38216 <at> debbugs.gnu.org
Subject: Re: bug#38216: [PATCH] vc-hg: don't pass empty string to 'update'
 command
Date: Fri, 15 Nov 2019 10:05:27 +0100

martin rudalics <rudalics <at> gmx.at> writes:

>> Thanks; applied the patch to Emacs 27.
>
> Gets me
>
> ../../lisp/vc/vc-hg.el:1467:1:Warning: the function `string-empty-p' is not
>     known to be defined.
>
> here.

Huh; my patch applying function is supposed to do a byte compilation to
catch bugs like that...  but I must have forgotten to actually look at
it.

I've now changed it to avoid this subr-x function.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 13 Dec 2019 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 5 years and 193 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.