From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 03:20:36 2019 Received: (at submit) by debbugs.gnu.org; 14 Nov 2019 08:20:36 +0000 Received: from localhost ([127.0.0.1]:60892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVAMm-0005nQ-5R for submit@debbugs.gnu.org; Thu, 14 Nov 2019 03:20:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:50527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVAMk-0005nJ-Rw for submit@debbugs.gnu.org; Thu, 14 Nov 2019 03:20:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44450) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iVAMj-0004vw-CC for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 03:20:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iVAMh-0002Dp-VI for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 03:20:33 -0500 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:45550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iVAMh-00029J-OR for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2019 03:20:31 -0500 Received: by mail-wr1-x42e.google.com with SMTP id z10so5334649wrs.12 for ; Thu, 14 Nov 2019 00:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ppMNPXJ6i60g0Dn6uPzZCMKuSsBYUjqTJNzuyvl0FPE=; b=UHBMcN+/aRb3kUKrhde/tTAwYMCQd8cgf/FPAgN2ppxTjX//fv8ruIpVPj64LVvkH4 jQKCvOgrU7py4YI+jHC9mZN1KkdmnunjLMxEfnCEAUPEjJVNSbfaER/wTrRHZV7ZiK+F mwyS9yJLRL/q+Ksf4zd0L90uChV82Xtr2Gznh7vxpWkBxMpdFp7lq/dUD7BKAVBdhP24 NoIJsxG4XN2bPun/lsv2BW64S6hr9CjV+EzDCjPntikLtIwds4nY9cp7oeFtcO860Hji yZTVP0fJPrKK87fGCG4tgLBLr95VyWuGt6GL8PrD4HWn9AqPSQKdQwysvI55hIu3PoN4 daSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=ppMNPXJ6i60g0Dn6uPzZCMKuSsBYUjqTJNzuyvl0FPE=; b=RxrwS0DAfZDi89noaNrf17cx08Kyg88ZivhkU61daI9f0RtmMK841rQ85qCYOp75jG pCakcteRo4ZTKtdeKVJ7oUyJoUBmqTHZBybpln+I3Ozsw4h1Hd/g0FVWEz/WpuSt7/Xf Gsskcyp5CvgtRDVWXIAuQwNCp+MN84yc4AyDgeLDWnMNylmDLr1Y1aF7NAegGKZGikDz oY7TGS0HNTwNMzSWEGmvjIfx6AUZ5spfs67fZe2dAUEmkSlQnrsxtoH4vNmtxMYDK+KC dBQP8HvCCDAHP/tlCpwCg1ypUqbVyxyoCY/RnbdTGbedNGRsm+0WQ+qwLR8dMuKspGCi ipXA== X-Gm-Message-State: APjAAAVcxD8L7+BdicIGZ0pxUleWxwPZSjhbpNcDyFbALa7KSqMiKirN NR4nYNJX2HgmDHHFFYjxC06EKzmm X-Google-Smtp-Source: APXvYqxLcFqp1H2slulWgfuKW68sPEwUb3I65KvF3Qo3Y64wej13B3zJMW6+ioVozhBQnbknGInu3A== X-Received: by 2002:adf:cf0c:: with SMTP id o12mr6734531wrj.102.1573719629718; Thu, 14 Nov 2019 00:20:29 -0800 (PST) Received: from gabor.localnet (254C7E66.nat.pool.telekom.hu. [37.76.126.102]) by smtp.gmail.com with ESMTPSA id u187sm5633132wme.15.2019.11.14.00.20.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 00:20:28 -0800 (PST) From: Braun =?ISO-8859-1?Q?G=E1bor?= To: bug-gnu-emacs@gnu.org Subject: 26.1; cl-prettyexpand incorrectly expands pushing to structures Date: Thu, 14 Nov 2019 09:20:19 +0100 Message-ID: <62949967.3QoF1lfsEv@gabor> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::42e X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi, Create file test.el: (require 'cl-lib) (cl-defstruct test slot) (cl-prettyexpand '(push 1 (test-slot foo))) (message "%s" (buffer-string)) Let Emacs evaluate the file: $ emacs -Q -batch -l ./test.el Expanding... =46ormatting... (let* ((v test-slot) (v (or (cl-block test-p (and (memq (type-of foo) cl-struct-test-tags) t)) (signal 'wrong-type-argument (list 'test foo)))) (v (aref foo 1))) (\(setf\ cl-block\) (cons 1 (cl-block v v v)) v v v)) The form in the output is obviously an incorrect expansion of (push 1 (test-slot foo)). Two errors are (1) the reference to (non-existent) free variable `test-slot' in the=20 first line and (2) calling the nonexistent function `(setf cl-block)' in the last line. Best wishes, G=C3=A1bor In GNU Emacs 26.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.4) of 2019-02-03, modified by Debian built on zam904 Windowing system distributor 'The X.Org Foundation', version=20 11.0.12004000 System Description: Debian GNU/Linux 10 (buster) Configured using: 'configure --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/26.1/site- lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/ usr/share/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=3D/usr --sharedstatedir=3D/var/lib --libexecdir=3D/usr/lib --localstatedir=3D/var/lib --infodir=3D/usr/share/info --mandir=3D/usr/share/man --enable-libsystemd --with-pop=3Dyes --enable-locallisppath=3D/etc/emacs:/usr/local/share/emacs/26.1/site- lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.1/site-lisp:/ usr/share/emacs/site-lisp --with-sound=3Dalsa --without-gconf --with-mailutils --with-x=3Dyes --with-x-toolkit=3Dgtk3 --with-toolkit-scroll-bars 'CFLAGS=3D-g -O2 -fdebug-prefix-map=3D/build/emacs-26.1+1=3D. -fstack-protector-strong -Wformat -Werror=3Dformat-security -Wall' 'CPPFLAGS=3D-Wdate-time -D_FORTIFY_SOURCE=3D2' LDFLAGS=3D-Wl,-z,relro' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 THREADS LIBSYSTEMD LCMS2 Important settings: value of $LANG: hu_HU.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. =46eatures: (shadow sort mail-extr emacsbug message rmc puny seq byte-opt bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-extra help-mode easymenu cl-seq cl-macs gv cl-loaddefs cl-lib elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 99333 7644) (symbols 48 20637 2) (miscs 40 53 104) (strings 32 28919 1306) (string-bytes 1 758567) (vectors 16 15133) (vector-slots 8 500702 9540) (floats 8 51 108) (intervals 56 308 6) (buffers 992 12)) From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 14:20:11 2019 Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 19:20:11 +0000 Received: from localhost ([127.0.0.1]:42674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQ5j-0005iy-0d for submit@debbugs.gnu.org; Sun, 17 Nov 2019 14:20:11 -0500 Received: from quimby.gnus.org ([95.216.78.240]:52646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQ5h-0005ij-Nq for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 14:20:10 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWQ5X-0001AR-PC; Sun, 17 Nov 2019 20:20:02 +0100 From: Lars Ingebrigtsen To: Braun =?utf-8?Q?G=C3=A1bor?= Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures References: <62949967.3QoF1lfsEv@gabor> Date: Sun, 17 Nov 2019 20:19:58 +0100 In-Reply-To: <62949967.3QoF1lfsEv@gabor> ("Braun =?utf-8?Q?G=C3=A1bor=22's?= message of "Thu, 14 Nov 2019 09:20:19 +0100") Message-ID: <87imniux7l.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Braun Gábor writes: > (let* ((v test-slot) > (v (or (cl-block test-p > (and (memq (type-of foo) cl-struct-test-tags) t)) > (signal 'wrong-type-argument (list 'test foo)))) > (v (aref foo 1))) > (\(setf\ cl-block\) (cons [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Braun G=C3=A1bor writes: > (let* ((v test-slot) > (v (or (cl-block test-p > (and (memq (type-of foo) cl-struct-test-tags) t)) > (signal 'wrong-type-argument (list 'test foo)))) > (v (aref foo 1))) > (\(setf\ cl-block\) (cons 1 (cl-block v v v)) v v v)) > > The form in the output is obviously an incorrect expansion of > (push 1 (test-slot foo)). Yup. However, if we give a FULL parameter to the function, it gives the correct results: (cl-prettyexpand '(push 1 (test-slot foo)) t) =3D> (progn (or (and (memq (type-of foo) cl-struct-test-tags) t) (signal 'wrong-type-argument (list 'test foo))) (let* ((v foo)) (aset v 1 (cons 1 (aref v 1))))) The definition is (defun cl-prettyexpand (form &optional full) "Expand macros in FORM and insert the pretty-printed result. Optional argument FULL non-nil means to expand all macros, including `cl-block' and `cl-eval-when'." [...] (setq form (macroexpand-all form (and (not full) '((cl-block) (cl-eval-when)= )))) The bug was introduced by a rewrite in 2012, I think, which changed the implementation radically, which made it pass in that list as a totally bogus ENVIRONMENT to macroexpand-all. I think the right change here is to just deprecate the FULL parameter and remove the=20 (and (not full) '((cl-block) (cl-eval-when)= )))) bit. Stefan? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 15:14:09 2019 Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 20:14:09 +0000 Received: from localhost ([127.0.0.1]:42715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQvw-0006zj-RM for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:14:09 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWQvv-0006zV-Dr for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 15:14:07 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 15F4D449EC7; Sun, 17 Nov 2019 15:14:02 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C7C81449EA9; Sun, 17 Nov 2019 15:14:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1574021640; bh=buxQ8NyhIGez9tIpUZcXOfnLwLaYHsqHDcnXBN924z4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Uo+l80Hq5MCr3oMEd+vVWGVjB8lEZyPWYnbEdNlZRC9udtQCYV7fAzEN7UhDe+0N4 FqlcP4ezoUF0AhSoe7FLd+zhds7NP34YJsY8OWb3mSastMEOxH/gYwSl6fwCDvnBQr s+zEjDlsUJ6Qtbnm+rqO167PZSWYas5J2wOLQ+tbXnoxg2gpYO+y07JadluC374QUk A73yZl3c/5S72ODHRJmKTaRoSxz/M+QakG5im8H7kbsird/9LJv2vp/X43Fezhk2LK Eoi9lHZRYwWcnuOulid9KJTCC21bX3WitmTa7BVF07JrWineuNgVT0tZUxk/ubVOs2 ogrHolmysi7zA== Received: from alfajor (unknown [216.154.18.30]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6C2B612084D; Sun, 17 Nov 2019 15:14:00 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Message-ID: References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> Date: Sun, 17 Nov 2019 15:13:56 -0500 In-Reply-To: <87imniux7l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 20:19:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.095 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, Braun =?windows-1252?Q?G=E1bor?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The bug was introduced by a rewrite in 2012, I think, which changed the > implementation radically, which made it pass in that list as a totally > bogus ENVIRONMENT to macroexpand-all. Not sure why you see it that way. `C-x v h` tells me: commit 6fa6c4aedbc9f33cf8ed67fdb7794c3b4ff6660a Author: Stefan Monnier Date: Thu Jun 7 15:48:22 2012 -0400 Move old compatiblity to cl.el. Remove cl-macroexpand-all. [...] diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- a/lisp/emacs-lisp/cl-extra.el +++ b/lisp/emacs-lisp/cl-extra.el @@ -798,2 +681,2 @@ - (setq form (cl-macroexpand-all form - (and (not full) '((cl-block) (cl-eval-when))))) + (setq form (macroexpand-all form + (and (not full) '((cl-block) (cl-eval-when))))) commit 7c1898a7b93053cd0431f46f02d82c0a31bfb8bf Author: Stefan Monnier Date: Sun Jun 3 21:05:17 2012 -0400 * lisp/emacs-lisp/cl-lib.el: Rename from cl.el. * lisp/emacs-lisp/cl.el: New compatibility file. * emacs-lisp/cl-lib.el, lisp/emacs-lisp/cl-seq.el, lisp/emacs-lisp/cl-macs.el: * lisp/emacs-lisp/cl-extra.el: Rename all top-level functions and variables to obey the "cl-" prefix. * lisp/emacs-lisp/macroexp.el (macroexpand-all-1): Adjust to new name. diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- a/lisp/emacs-lisp/cl-extra.el +++ b/lisp/emacs-lisp/cl-extra.el @@ -802,2 +798,2 @@ (setq form (cl-macroexpand-all form - (and (not full) '((block) (eval-when))))) + (and (not full) '((cl-block) (cl-eval-when))))) commit fcd737693e8e320acd70f91ec8e0728563244805 Author: Richard M. Stallman Date: Fri Jul 30 20:15:09 1993 +0000 entered into RCS diff --git a/lisp/emacs-lisp/cl-extra.el b/lisp/emacs-lisp/cl-extra.el --- /dev/null +++ b/lisp/emacs-lisp/cl-extra.el @@ -0,0 +920,2 @@ + (setq form (cl-macroexpand-all form + (and (not full) '((block) (eval-when))))) so it seems that it's been with us since at least 1993. > I think the right change here is to just deprecate the FULL parameter > and remove the > > (and (not full) '((cl-block) (cl-eval-when))))) > > bit. Stefan? 100% agreement. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 15:20:04 2019 Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 20:20:04 +0000 Received: from localhost ([127.0.0.1]:42720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWR1d-00078A-SV for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:20:04 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWR1a-00077o-3L for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 15:20:00 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWR1R-0001bC-3p; Sun, 17 Nov 2019 21:19:51 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> Date: Sun, 17 Nov 2019 21:19:48 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 17 Nov 2019 15:13:56 -0500") Message-ID: <871ru6uufv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > Not sure why you see it that way. `C-x v h` tells me: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, Braun =?utf-8?Q?G=C3=A1bor?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > Not sure why you see it that way. `C-x v h` tells me: [...] > - (setq form (cl-macroexpand-all form > - (and (not full) '((cl-block) (cl-eval-when))))) I just assumed that the parameter was meaningful for cl-macroexpand-all... that is, that the ENV parameter for that function was something other thatn ENVIRONMENT for macroexpand-all. But I see I was wrong now; sorry. I have besmirched your patch. >> I think the right change here is to just deprecate the FULL parameter >> and remove the >> >> (and (not full) '((cl-block) >> (cl-eval-when))))) >> >> bit. Stefan? > > 100% agreement. OK, I'll go ahead and fix that up. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 17:02:58 2019 Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 22:02:58 +0000 Received: from localhost ([127.0.0.1]:42856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWSdF-00058j-Ci for submit@debbugs.gnu.org; Sun, 17 Nov 2019 17:02:58 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:3453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWSdE-00058S-0v for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 17:02:56 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3ADE81003EC; Sun, 17 Nov 2019 17:02:50 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id DCA7F1000F4; Sun, 17 Nov 2019 17:02:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1574028168; bh=xS2FY9PJGoKSeR2xZlNrFl/F7u5kM3RizYF+nuI9kw4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AL7uy77ZeWMwYY+fFz12EsNZp0clU/e7gRSKYEmICcmUMJPLg2KympUbhrVh7pk/g 8vopMmegyhvLABKXEXnwNqYvASMDfF1kloKtWQ3xroqPWkucun+EbsgIzgFrB8RjH+ lrZpTMRp9iUJl2fVRXNObs/WzOLkMXKJ1PaOvE00Ngd/4T5NgzCTnGSCGfCMa6+aQB uehHFLdLB2PDGTO+DSJuNf3ol4bu4e6Wurv6BBLY/KvMIF3EmRCPmqrmXVHTcy4zoZ tTcsmY8FQf7+J11kkfgFXBZ6APzO5Bu5iPyoVtpg5N2SuHM0SVd/aCqc3vphiO40uK 5V+cYd1+VKDjg== Received: from alfajor (unknown [216.154.18.30]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 991C41205E1; Sun, 17 Nov 2019 17:02:48 -0500 (EST) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Message-ID: References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> <871ru6uufv.fsf@gnus.org> Date: Sun, 17 Nov 2019 17:02:46 -0500 In-Reply-To: <871ru6uufv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 21:19:48 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, Braun =?windows-1252?Q?G=E1bor?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I just assumed that the parameter was meaningful for > cl-macroexpand-all... that is, that the ENV parameter for that function > was something other thatn ENVIRONMENT for macroexpand-all. But I see I > was wrong now; sorry. I have besmirched your patch. I just asked my lawyer to see whether it's best to sue you for libel here in Canada or in Norway. Either way, you'll hear from her soon. > OK, I'll go ahead and fix that up. Thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 05:00:18 2019 Received: (at 38206) by debbugs.gnu.org; 18 Nov 2019 10:00:18 +0000 Received: from localhost ([127.0.0.1]:43204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWdpS-0007FA-AN for submit@debbugs.gnu.org; Mon, 18 Nov 2019 05:00:18 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWdpP-0007Eq-Qx for 38206@debbugs.gnu.org; Mon, 18 Nov 2019 05:00:16 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWdpB-0007wr-Nf; Mon, 18 Nov 2019 11:00:08 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> <871ru6uufv.fsf@gnus.org> Date: Mon, 18 Nov 2019 11:00:00 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 17 Nov 2019 17:02:46 -0500") Message-ID: <87pnhpqzbz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > I just asked my lawyer to see whether it's best to sue you for libel > here in Canada or in Norway. Either way, you'll hear from her soon. Your lawyers will hear from my Kuala Lumpan lawyers! Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, Braun =?utf-8?Q?G=C3=A1bor?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: > I just asked my lawyer to see whether it's best to sue you for libel > here in Canada or in Norway. Either way, you'll hear from her soon. Your lawyers will hear from my Kuala Lumpan lawyers! >> OK, I'll go ahead and fix that up. > > Thanks, OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 05:02:50 2019 Received: (at control) by debbugs.gnu.org; 18 Nov 2019 10:02:50 +0000 Received: from localhost ([127.0.0.1]:43208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWdrt-0007Ij-Qt for submit@debbugs.gnu.org; Mon, 18 Nov 2019 05:02:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWdrq-0007IV-HF for control@debbugs.gnu.org; Mon, 18 Nov 2019 05:02:47 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWdri-0007xb-D9 for control@debbugs.gnu.org; Mon, 18 Nov 2019 11:02:40 +0100 Date: Mon, 18 Nov 2019 11:02:37 +0100 Message-Id: <87o8x9qz7m.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38206 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38206 fixed close 38206 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38206 fixed close 38206 27.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 11:26:54 2019 Received: (at 38206) by debbugs.gnu.org; 20 Nov 2019 16:26:54 +0000 Received: from localhost ([127.0.0.1]:50780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSog-000320-G1 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 11:26:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXSof-00031n-MZ for 38206@debbugs.gnu.org; Wed, 20 Nov 2019 11:26:53 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43405) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXSoY-0004Ds-5V; Wed, 20 Nov 2019 11:26:46 -0500 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1iXSoX-0005RM-8a; Wed, 20 Nov 2019 11:26:45 -0500 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Lars Ingebrigtsen In-Reply-To: <87pnhpqzbz.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 18 Nov 2019 11:00:00 +0100) Subject: Re: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> <871ru6uufv.fsf@gnus.org> <87pnhpqzbz.fsf@gnus.org> Message-Id: Date: Wed, 20 Nov 2019 11:26:45 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38206 Cc: 38206@debbugs.gnu.org, braungb88@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > Your lawyers will hear from my Kuala Lumpan lawyers! Do they defend the lumpanproletariat? -- Dr Richard Stallman Founder, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) From unknown Sun Jun 15 08:40:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Dec 2019 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator