From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 16:10:40 2019 Received: (at submit) by debbugs.gnu.org; 12 Nov 2019 21:10:40 +0000 Received: from localhost ([127.0.0.1]:58481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUdQt-0002KZ-Lk for submit@debbugs.gnu.org; Tue, 12 Nov 2019 16:10:39 -0500 Received: from lists.gnu.org ([209.51.188.17]:34930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUdQr-0002KS-QN for submit@debbugs.gnu.org; Tue, 12 Nov 2019 16:10:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59776) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iUdQq-0001Qh-SG for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:10:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,RCVD_IN_DNSWL_NONE, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iUdQp-0006KJ-V6 for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:10:36 -0500 Received: from dragonfly.birch.relay.mailchannels.net ([23.83.209.51]:41662) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iUdQp-0006Jf-MQ for bug-gnu-emacs@gnu.org; Tue, 12 Nov 2019 16:10:35 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5D97A5013AB for ; Tue, 12 Nov 2019 21:10:34 +0000 (UTC) Received: from pdx1-sub0-mail-a75.g.dreamhost.com (100-96-14-250.trex.outbound.svc.cluster.local [100.96.14.250]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B9979501174 for ; Tue, 12 Nov 2019 21:10:33 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a75.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 12 Nov 2019 21:10:34 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Grain-Hysterical: 3f68b3a479bcc43b_1573593033990_4063476812 X-MC-Loop-Signature: 1573593033990:123329725 X-MC-Ingress-Time: 1573593033990 Received: from pdx1-sub0-mail-a75.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTP id CA27F9D7BE for ; Tue, 12 Nov 2019 13:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to :subject:date:message-id:mime-version:content-type; s= linkov.net; bh=0zoLjTa1xff0PxbSauSqJaY7Hcs=; b=CEqshmmUC56D2EBTH PJHUf0giudz8JP9oYapdDyy4U/btE84bH1chnjlfI7oVn3hrTO12Vz4mRlxIH3bx 0tTnJ1WQdsL2vpo/AKZ8edXudKQUOwRmUihHE9ipClHvRvfbIZ2yWBF57evoTZk1 c14sCPZS6CV6hlvD/9Uh2M9DeQ= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a75.g.dreamhost.com (Postfix) with ESMTPSA id A72729D7C2 for ; Tue, 12 Nov 2019 13:10:30 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a75 From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET Date: Tue, 12 Nov 2019 22:38:12 +0200 Message-ID: <87tv79ksuz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 23.83.209.51 X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Tried to use a new recently added useful feature of using C-mouse-wheel to zoom. But it seems it has no effect on images, at least its effect is not visible: it doesn't scale images in image mode. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 07:48:58 2019 Received: (at 38187) by debbugs.gnu.org; 14 Nov 2019 12:48:58 +0000 Received: from localhost ([127.0.0.1]:32838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVEYU-0006Sy-0B for submit@debbugs.gnu.org; Thu, 14 Nov 2019 07:48:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVEYQ-0006Sf-Nd for 38187@debbugs.gnu.org; Thu, 14 Nov 2019 07:48:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iVEYK-0007Fk-7I; Thu, 14 Nov 2019 07:48:49 -0500 Received: from [176.228.60.248] (port=3626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iVEYJ-0005Pz-Ks; Thu, 14 Nov 2019 07:48:48 -0500 Date: Thu, 14 Nov 2019 14:48:31 +0200 Message-Id: <83zhgy62u8.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87tv79ksuz.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 12 Nov 2019 22:38:12 +0200) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Tue, 12 Nov 2019 22:38:12 +0200 > > Tried to use a new recently added useful feature of using C-mouse-wheel to zoom. > > But it seems it has no effect on images, at least its effect is not visible: > it doesn't scale images in image mode. at that spot runs the command mouse-wheel-text-scale (found in global-map), which is an interactive compiled Lisp function in ‘mwheel.el’. It is bound to , . (mouse-wheel-text-scale EVENT) Increase or decrease the height of the default face according to the EVENT. It is documented to increase/decrease the size of _text_ of the default face. It isn't documented to "zoom", which is a much more general action/effect. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 05:05:12 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 10:05:12 +0000 Received: from localhost ([127.0.0.1]:40372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWHQe-0003S9-9d for submit@debbugs.gnu.org; Sun, 17 Nov 2019 05:05:12 -0500 Received: from quimby.gnus.org ([95.216.78.240]:45888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWHQc-0003Rq-DO for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 05:05:10 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWHQS-0005bO-A5; Sun, 17 Nov 2019 11:05:02 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> Date: Sun, 17 Nov 2019 11:04:59 +0100 In-Reply-To: <83zhgy62u8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Nov 2019 14:48:31 +0200") Message-ID: <87y2we7r90.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > It is documented to increase/decrease the size of _text_ of the > default face. It isn't documented to "zoom", which is a much more > general action/effect. But I think it would make sense to bind that event to zoom the image if over an image. It's a trivial change and seems natural. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > It is documented to increase/decrease the size of _text_ of the > default face. It isn't documented to "zoom", which is a much more > general action/effect. But I think it would make sense to bind that event to zoom the image if over an image. It's a trivial change and seems natural. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 11:05:26 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 16:05:26 +0000 Received: from localhost ([127.0.0.1]:42416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN3F-0003V0-LE for submit@debbugs.gnu.org; Sun, 17 Nov 2019 11:05:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN3D-0003Ul-Gu for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 11:05:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWN38-0001hU-4r; Sun, 17 Nov 2019 11:05:18 -0500 Received: from [176.228.60.248] (port=3776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWN33-0006KL-65; Sun, 17 Nov 2019 11:05:14 -0500 Date: Sun, 17 Nov 2019 18:05:15 +0200 Message-Id: <83lfse5w04.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87y2we7r90.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 17 Nov 2019 11:04:59 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Juri Linkov , 38187@debbugs.gnu.org > Date: Sun, 17 Nov 2019 11:04:59 +0100 > > Eli Zaretskii writes: > > > It is documented to increase/decrease the size of _text_ of the > > default face. It isn't documented to "zoom", which is a much more > > general action/effect. > > But I think it would make sense to bind that event to zoom the image if > over an image. It's a trivial change and seems natural. AFAIU, that's not what the OP wanted. He wanted to see _all_ images be scaled proportionally to the text scaling, regardless of where the mouse pointer is located. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 11:07:55 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 16:07:55 +0000 Received: from localhost ([127.0.0.1]:42430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN5e-0003ZM-P7 for submit@debbugs.gnu.org; Sun, 17 Nov 2019 11:07:55 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWN5U-0003Z1-D2 for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 11:07:44 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWN5I-0008CP-NV; Sun, 17 Nov 2019 17:07:35 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> Date: Sun, 17 Nov 2019 17:07:31 +0100 In-Reply-To: <83lfse5w04.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Nov 2019 18:05:15 +0200") Message-ID: <87a78u7ags.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > AFAIU, that's not what the OP wanted. He wanted to see _all_ images > be scaled proportionally to the text scaling, regardless of where the > mouse pointer is located. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > AFAIU, that's not what the OP wanted. He wanted to see _all_ images > be scaled proportionally to the text scaling, regardless of where the > mouse pointer is located. Ah; yes, I agree that that would be confusing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 16:21:07 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 21:21:07 +0000 Received: from localhost ([127.0.0.1]:42797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRyl-00028l-Ej for submit@debbugs.gnu.org; Sun, 17 Nov 2019 16:21:07 -0500 Received: from ted.gofardesign.uk ([67.225.143.91]:35638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWRyk-00027w-77 for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 16:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tqICEkOad4r0app933z0yoZefFP94U6YqOP++11JBRo=; b=XYU6+BakAK0t2kkUNHIDk+hY9M aDerXjZkk4348Fpp4UeUzCTd4R5Mclo0xQnlIMUoeORH+NDelUbAxkNBW8oLw8pU0ZLbT7M8BjRy6 y16F6zmB6GuSCrMHeArT+ZOZvnX5+d0vcOGP9N0r1wejp7UP1W/wjULaX/fQYB58i79+S24GncTtc yy88YXfRx9bYOey7mObADbET2V4EnKChtnEMj3pDjGqcFBQdBYuArybpcHfDzOItWL/M0lfRPohJi wgXLdmpZ0/jJj7KsKh61/ICcmoN7F9rMPpbSvIEHQwhnREolBvJK7Kk9I13D+/SyyPSkQflqRRa5U W0BmR3aQ==; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:38088 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iWRyd-000rOW-V4; Sun, 17 Nov 2019 16:21:00 -0500 From: Stefan Kangas To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images In-Reply-To: <87a78u7ags.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 17 Nov 2019 17:07:31 +0100") References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sun, 17 Nov 2019 22:20:58 +0100 Message-ID: <878soemc79.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Eli Zaretskii writes: > >> AFAIU, that's not what the OP wanted. He wanted to see _all_ images >> be scaled proportionally to the text scaling, regardless of where the >> mouse pointer is located. > > Ah; yes, I agree that that would be confusing. FWIW, I think the opposite. I think that zooming text, images and all buffer content together should be the default. I believe that it would feel both natural and familiar, especially to new users, since that's how e.g. web browsers, LibreOffice and evince, etc. works. And if we do that, why then not call this functionality "zooming"? That nomenclature is fairly well-established and therefore easier to understand for new users, I think. Of course, if we don't do such a change, it makes no sense to introduce the word "zooming". Then "change font size" or "change image size" is a better description of what is going on. (That also reminds me that, IMO, text-scale-increase/decrease should be renamed to font-size-increase/decrease. The current names are not very discoverable; when one wants to change the font size, and says: `M-x font TAB'. At the very least, we should have such defaliases.) Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 18:01:14 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 23:01:14 +0000 Received: from localhost ([127.0.0.1]:42904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTXe-0006Xy-1d for submit@debbugs.gnu.org; Sun, 17 Nov 2019 18:01:14 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTXb-0006Xj-EA for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 18:01:12 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAHMuP02076345; Sun, 17 Nov 2019 23:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=SK3lwzX7GQip4F2m1XH68fkT+i42kX/88qme2Ka39i8=; b=D30LK6lXYt/aAfRGzuBQSQUY+nWTYWLh31PKq+7BnffQWIdJhRwgsFtrmpoMHKq7LQYp BGENU8Tu2DOSr81rvqu7ukQEomuAtmv+Gf5eAcjqNbS/ahBi327asjQbPSYAXtu2V2gx 3duWldyZlsJU0npADkrpifoRXqsJ61IeSPn1GK+WZKBfEBgTZiJLb6JWOQNtweaKHQde kKNQLvFFcNvZXBOEvKlRWTFAQR43tvgXwWW3cR0GMY+SC2pBsvuU7v+yJVb90R12/EBm fQj8cEGLKDeGlBTUbyBIibAr4ppY22Z6SjCDWVPTy97YXeSAlJB4UsoRTPqYAtkeSA+l WA== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2wa8htcnav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 17 Nov 2019 23:01:05 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAHMwBla111688; Sun, 17 Nov 2019 23:01:04 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2watjwcmtm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 17 Nov 2019 23:01:04 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xAHN12ep015222; Sun, 17 Nov 2019 23:01:02 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 17 Nov 2019 15:01:01 -0800 (PST) From: Drew Adams To: Stefan Kangas , Lars Ingebrigtsen Subject: RE: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> In-Reply-To: <878soemc79.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9444 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911170219 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9444 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911170219 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > >> AFAIU, that's not what the OP wanted. He wanted to see _all_ images > >> be scaled proportionally to the text scaling, regardless of where > >> the mouse pointer is located. > > > > Ah; yes, I agree that that would be confusing. >=20 > FWIW, I think the opposite. I think that zooming text, images and all > buffer content together should be the default. I believe that it > would feel both natural and familiar, especially to new users, since > that's how e.g. web browsers, LibreOffice and evince, etc. works. I'm not speaking to that question, of whether the default behavior should be to zoom everything in the buffer or just the text in the buffer or whatever other buffer content there may be. I want to raise a different point, since you pose the question of terminology and "zooming". > And if we do that, why then not call this functionality "zooming"? > That nomenclature is fairly well-established and therefore easier to > understand for new users, I think. >=20 > Of course, if we don't do such a change, it makes no sense to > introduce the word "zooming". Then "change font size" or "change > image size" is a better description of what is going on. >=20 > (That also reminds me that, IMO, text-scale-increase/decrease should > be renamed to font-size-increase/decrease. The current names are not > very discoverable; when one wants to change the font size, and says: > `M-x font TAB'. At the very least, we should have such defaliases.) I didn't coin the verb "zoom", of course, but I did introduce it in the context of Emacs, AFAIK - in 3rd-party code, 15 years ago. I agree that "zoom" is a good way to talk about such behavior. However, what's important here is that the thing you are talking about zooming is the displayed _buffer_ content. When talking about font-size change, it is the (apparent) font size in the _buffer_ that you're talking about. Why do I mention this? Because there are other ways to zoom, and so change font size. In particular, you can zoom a _frame_, as opposed to a _buffer_, by changing the value of the `font' frame parameter. Each is useful: (1) zoom a frame, which means each of its windows, regardless of which buffers are shown there, and (2) zoom a buffer, which means across all windows in all frames. So I'd prefer that names used for the behavior you're referring to make clear that it is about zooming the displayed content of a _buffer_ (whether you mean only text or text+images). It's not about zooming a frame (its font size, scroll-bar, images, etc.). If you do that - make clear just what is being zoomed (text in a buffer, text+images in a buffer, etc.) - then there will be room for talking about zooming other things, with no risk of confusion of terms. Zooming doesn't apply only to a single buffer every place it's displayed. --- FWIW, my library `zoom-frm.el' provides commands that let you zoom either the current buffer or the selected frame (a single command does either). For example, command `zoom-in/out' is a more general replacement for `text-scale-adjust'. I recommend binding it to the keys bound by default to that command: `C-x C-+', `C-x C-=3D', `C-x C--', `C-x C-0'. How is it "more general"? Option `zoom-frame/buffer' says which kind of zooming (frame or buffer) to use by default. Why "by default"? Because you can use a prefix arg with `zoom-in/out' to toggle between zooming the other (frame or buffer) from then on. Besides `zoom-in/out', there are `zoom-in' and `zoom-out', which I recommend binding to `C-wheel-up' and `C-wheel-down' (as for web browsers). `zoom-frm.el' doesn't zoom images. But I agree that an ability to zoom both text and images would be useful - as well as an ability to zoom only text or only images, and zoom a single image as well as all images, whether for a buffer or a frame. https://www.emacswiki.org/emacs/download/zoom-frm.el From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 17 18:04:19 2019 Received: (at 38187) by debbugs.gnu.org; 17 Nov 2019 23:04:19 +0000 Received: from localhost ([127.0.0.1]:42911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTad-0006cK-3y for submit@debbugs.gnu.org; Sun, 17 Nov 2019 18:04:19 -0500 Received: from brown.elm.relay.mailchannels.net ([23.83.212.23]:49492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWTaW-0006c7-BF for 38187@debbugs.gnu.org; Sun, 17 Nov 2019 18:04:17 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 369698C105A; Sun, 17 Nov 2019 23:04:11 +0000 (UTC) Received: from pdx1-sub0-mail-a52.g.dreamhost.com (100-96-86-105.trex.outbound.svc.cluster.local [100.96.86.105]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 944A88C1093; Sun, 17 Nov 2019 23:04:10 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a52.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sun, 17 Nov 2019 23:04:10 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Interest-Sponge: 456711764d29a57a_1574031850860_123671802 X-MC-Loop-Signature: 1574031850860:2131287837 X-MC-Ingress-Time: 1574031850860 Received: from pdx1-sub0-mail-a52.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a52.g.dreamhost.com (Postfix) with ESMTP id 151097FE49; Sun, 17 Nov 2019 15:04:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=linkov.net; bh=gcXaJo T8Le5Suu2/6nt220QlZmU=; b=t0U4WS4/oh05MTKxUIl/k4VERazizBqkB5qrnB G936RINyO2TACKjmD7xNivWJB5dyEDaHCMKCf07p0ZMjuAifG7R/rh/lYHiqIyn4 KldE31Vf7XIoW86bAaN6Rb8hKLP4RFS5oxFY/aiM6OJbobxjHS2faDEYcawuSWa2 OEpwo= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a52.g.dreamhost.com (Postfix) with ESMTPSA id AF0C18189E; Sun, 17 Nov 2019 15:04:02 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a52 From: Juri Linkov To: Stefan Kangas Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> Date: Mon, 18 Nov 2019 00:42:22 +0200 In-Reply-To: <878soemc79.fsf@marxist.se> (Stefan Kangas's message of "Sun, 17 Nov 2019 22:20:58 +0100") Message-ID: <87mucut8ch.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , Eli Zaretskii , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>> AFAIU, that's not what the OP wanted. He wanted to see _all_ images >>> be scaled proportionally to the text scaling, regardless of where the >>> mouse pointer is located. >> >> Ah; yes, I agree that that would be confusing. > > FWIW, I think the opposite. I think that zooming text, images and all > buffer content together should be the default. I believe that it > would feel both natural and familiar, especially to new users, since > that's how e.g. web browsers, LibreOffice and evince, etc. works. Zooming text and images together would be nice too, but I meant something much simpler - zooming images in image-mode with mouse-wheel. In image-mode currently =E2=80=98+=E2=80=99 is bound to the command =E2=80= =98image-increase-size=E2=80=99, the same command could be bound to =E2=80=98=E2=80=99 (C-wheel= -up) as well. Same for =E2=80=98-=E2=80=99 (image-decrease-size) and =E2=80=98=E2=80=99 (C-wheel-down). > (That also reminds me that, IMO, text-scale-increase/decrease should > be renamed to font-size-increase/decrease. The current names are not > very discoverable; when one wants to change the font size, and says: > `M-x font TAB'. At the very least, we should have such defaliases.) Maybe, =E2=80=9Ctext-zoom=E2=80=9D is more discoverable? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 04:08:30 2019 Received: (at 38187) by debbugs.gnu.org; 18 Nov 2019 09:08:30 +0000 Received: from localhost ([127.0.0.1]:43135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWd1G-0003xZ-Tk for submit@debbugs.gnu.org; Mon, 18 Nov 2019 04:08:27 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWd1F-0003xI-Bo for 38187@debbugs.gnu.org; Mon, 18 Nov 2019 04:08:25 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWd13-0007Sf-T8; Mon, 18 Nov 2019 10:08:16 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> Date: Mon, 18 Nov 2019 10:08:13 +0100 In-Reply-To: <878soemc79.fsf@marxist.se> (Stefan Kangas's message of "Sun, 17 Nov 2019 22:20:58 +0100") Message-ID: <87k17xsgaq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > FWIW, I think the opposite. I think that zooming text, images and all > buffer content together should be the default. I believe that it > would feel both natural and familiar, especially to new use [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > FWIW, I think the opposite. I think that zooming text, images and all > buffer content together should be the default. I believe that it > would feel both natural and familiar, especially to new users, since > that's how e.g. web browsers, LibreOffice and evince, etc. works. That's true. I guess the scroll button could change both image-scaling-factor and text-scale-mode-amount... But, on the other hand, I could definitely see people preferring to change just one or the other. So perhaps there should be separate commands that people can bind according to their preference? > (That also reminds me that, IMO, text-scale-increase/decrease should > be renamed to font-size-increase/decrease. The current names are not > very discoverable; when one wants to change the font size, and says: > `M-x font TAB'. At the very least, we should have such defaliases.) Makes sense to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 04:10:51 2019 Received: (at 38187) by debbugs.gnu.org; 18 Nov 2019 09:10:51 +0000 Received: from localhost ([127.0.0.1]:43139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWd3b-000419-EK for submit@debbugs.gnu.org; Mon, 18 Nov 2019 04:10:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWd3X-00040u-9V for 38187@debbugs.gnu.org; Mon, 18 Nov 2019 04:10:47 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWd3N-0007WL-P1; Mon, 18 Nov 2019 10:10:41 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> Date: Mon, 18 Nov 2019 10:10:37 +0100 In-Reply-To: <87mucut8ch.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 18 Nov 2019 00:42:22 +0200") Message-ID: <87ftilsg6q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Zooming text and images together would be nice too, but I meant > something much simpler - zooming images in image-mode with mouse-wheel. > > In image-mode currently ‘+’ is bound to the command [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Zooming text and images together would be nice too, but I meant > something much simpler - zooming images in image-mode with mouse-wheel. > > In image-mode currently =E2=80=98+=E2=80=99 is bound to the command =E2= =80=98image-increase-size=E2=80=99, > the same command could be bound to =E2=80=98=E2=80=99 (C-wheel= -up) as well. > Same for =E2=80=98-=E2=80=99 (image-decrease-size) and =E2=80=98=E2=80=99 (C-wheel-down). Right. I think that's an obvious thing to put in `image-map' to make it easier to change the size of a single image. (It's not just in image-mode -- that map is on all images inserted by `insert-image'.) I don't have a mouse myself, so it'd be nice if somebody with one created a patch so that they could test it. image-map is in image.el. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 16:52:31 2019 Received: (at 38187) by debbugs.gnu.org; 18 Nov 2019 21:52:31 +0000 Received: from localhost ([127.0.0.1]:46376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWowh-0005He-3e for submit@debbugs.gnu.org; Mon, 18 Nov 2019 16:52:31 -0500 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:24627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWowf-0005HV-QX for 38187@debbugs.gnu.org; Mon, 18 Nov 2019 16:52:30 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id AAA5C2114A; Mon, 18 Nov 2019 21:52:28 +0000 (UTC) Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-169-13.trex.outbound.svc.cluster.local [100.96.169.13]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8E1F620B12; Mon, 18 Nov 2019 21:52:27 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Mon, 18 Nov 2019 21:52:28 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Robust-Absorbed: 1b8db67c3058c4d7_1574113947980_3282819105 X-MC-Loop-Signature: 1574113947980:2327320703 X-MC-Ingress-Time: 1574113947980 Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 042ACA7014; Mon, 18 Nov 2019 13:52:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=kGSxUM/YgielRJFu0KG1LdnSw58=; b= yFZktxfDlZ1las9WSWX5ts0r8ZQXySHUxn/v19n17yEhCFN7Ys2vSspdI6lenBiX XwUwoWK1ryv3yD9voti+OJO6VRJ1KHb+qwXe3FtAnKuXGWKrMM0wPAkv3y7e4hS0 fQmMmCsWpfNiwWjleZQG7/eXDiMg4BX8aeYZ6AKOyq4= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id C2231A7011; Mon, 18 Nov 2019 13:52:18 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a6 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> Date: Mon, 18 Nov 2019 23:37:15 +0200 In-Reply-To: <87ftilsg6q.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 18 Nov 2019 10:10:37 +0100") Message-ID: <87r224sw6s.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> In image-mode currently =E2=80=98+=E2=80=99 is bound to the command =E2= =80=98image-increase-size=E2=80=99, >> the same command could be bound to =E2=80=98=E2=80=99 (C-wh= eel-up) as well. >> Same for =E2=80=98-=E2=80=99 (image-decrease-size) and =E2=80=98=E2=80=99 (C-wheel-down). > > Right. I think that's an obvious thing to put in `image-map' to make i= t > easier to change the size of a single image. > > (It's not just in image-mode -- that map is on all images inserted by > `insert-image'.) > > I don't have a mouse myself, so it'd be nice if somebody with one > created a patch so that they could test it. image-map is in image.el. I tested this patch, and it works well: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=mouse-wheel-image-size.patch diff --git a/lisp/image.el b/lisp/image.el index ad2ee6c607..8e8e477865 100644 --- a/lisp/image.el +++ b/lisp/image.el @@ -158,6 +158,10 @@ image-map (let ((map (make-sparse-keymap))) (define-key map "-" 'image-decrease-size) (define-key map "+" 'image-increase-size) + (define-key map [C-wheel-down] 'image-decrease-size) + (define-key map [C-mouse-5] 'image-decrease-size) + (define-key map [C-wheel-up] 'image-increase-size) + (define-key map [C-mouse-4] 'image-increase-size) (define-key map "r" 'image-rotate) (define-key map "o" 'image-save) map)) @@ -993,23 +997,33 @@ imagemagick-enabled-types (imagemagick-register-types) -(defun image-increase-size (n) +(defun image-increase-size (&optional n event) "Increase the image size by a factor of N. If N is 3, then the image size will be increased by 30%. The default is 20%." - (interactive "P") - (image--change-size (if n - (1+ (/ n 10.0)) - 1.2))) + (interactive (list current-prefix-arg last-nonmenu-event)) + (let ((e (and (listp event) (event-start event)))) + (save-window-excursion + (when e + (select-window (posn-window e)) + (goto-char (posn-point e))) + (image--change-size (if n + (1+ (/ (prefix-numeric-value n) 10.0)) + 1.2))))) -(defun image-decrease-size (n) +(defun image-decrease-size (&optional n event) "Decrease the image size by a factor of N. If N is 3, then the image size will be decreased by 30%. The default is 20%." - (interactive "P") - (image--change-size (if n - (- 1 (/ n 10.0)) - 0.8))) + (interactive (list current-prefix-arg last-nonmenu-event)) + (let ((e (and (listp event) (event-start event)))) + (save-window-excursion + (when e + (select-window (posn-window e)) + (goto-char (posn-point e))) + (image--change-size (if n + (- 1 (/ (prefix-numeric-value n) 10.0)) + 0.8))))) (defun image--get-image () "Return the image at point." --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 22:31:17 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 03:31:17 +0000 Received: from localhost ([127.0.0.1]:46488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWuEW-0004sr-SX for submit@debbugs.gnu.org; Mon, 18 Nov 2019 22:31:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWuER-0004sY-Uh for 38187@debbugs.gnu.org; Mon, 18 Nov 2019 22:31:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iWuEM-0006Kr-D3; Mon, 18 Nov 2019 22:31:06 -0500 Received: from [176.228.60.248] (port=2562 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iWuEL-0000fW-KN; Mon, 18 Nov 2019 22:31:06 -0500 Date: Tue, 19 Nov 2019 05:31:11 +0200 Message-Id: <83ftik35kw.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87r224sw6s.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 18 Nov 2019 23:37:15 +0200) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Stefan Kangas , Eli Zaretskii , > 38187@debbugs.gnu.org > Date: Mon, 18 Nov 2019 23:37:15 +0200 > > -(defun image-increase-size (n) > +(defun image-increase-size (&optional n event) Can we avoid mixing numerical argument with a mouse event? It looks unclean to me. How about a simple wrapper that accepts a mouse event and calls image-increase/decrease-size with a suitable arg? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 03:10:25 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 08:10:25 +0000 Received: from localhost ([127.0.0.1]:46536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWyab-0003B8-1w for submit@debbugs.gnu.org; Tue, 19 Nov 2019 03:10:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWyaI-0003AA-NV for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 03:10:06 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWyZe-0002f3-VR; Tue, 19 Nov 2019 09:09:25 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> Date: Tue, 19 Nov 2019 09:09:22 +0100 In-Reply-To: <87r224sw6s.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 18 Nov 2019 23:37:15 +0200") Message-ID: <87zhgsnv7x.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > I tested this patch, and it works well: Great! And I agree with Eli's comment -- a separate wrapper command that just takes an event would be a clearer interface. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > I tested this patch, and it works well: Great! And I agree with Eli's comment -- a separate wrapper command that just takes an event would be a clearer interface. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 09:50:23 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 14:50:23 +0000 Received: from localhost ([127.0.0.1]:46843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX4pi-0005xQ-Hp for submit@debbugs.gnu.org; Tue, 19 Nov 2019 09:50:22 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:33537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX4pT-0005wP-6T for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 09:50:07 -0500 Received: by mail-pf1-f176.google.com with SMTP id c184so12301683pfb.0 for <38187@debbugs.gnu.org>; Tue, 19 Nov 2019 06:50:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pKpz2d0kvyiWStlDC/2aOG9Lsti8bjXLdoBSf8lMGeI=; b=s0BovrpwKKFAMkJIsH7zoGLWI3qaSQDzXmXqM8Oj3XcX5kisL4AYAnzmRYRasZWPh+ VY7Ct9vqYKocTYPB4tLjrW5LCAxb/iUpq0UxgZ1SJMxArBt//2QBOBu0tU+7pb5AMDlN 9QObzXbatPfHMCaC78VLQhnD0nDItuhUYfal66tkZyGaFr5HAblDdFh36kCwHlxmKZbY qFDrBjmSUma9ygs+NAm21+FhgCpgF+YzhhmL2dslFiWh0c10PEMwWfSg0VC5b1K2s+DO gThX78vyAwTEbWDuFRVkKBOHWNROIZdAF25IdOt0v4Yc/L8AErEhoqo84rWFf38xX0DT Y2mw== X-Gm-Message-State: APjAAAWDRG+L4rw9XoHtVW/lnpOvIsJFN1vCI5+H0vC/fExBeUF/jYgH +2OdwFRuRIxQynxUZ45mCmzJQuuC+EGuDVdaaoo= X-Google-Smtp-Source: APXvYqyPZrgVXw9fpeYXsENN62JwULN+wBpGtFItzHr8rWkL5bpnMUtTOKok9+Nzr609WQi8vY6s80nBrWT1Cm0ppDU= X-Received: by 2002:a63:a05c:: with SMTP id u28mr6292581pgn.333.1574175001170; Tue, 19 Nov 2019 06:50:01 -0800 (PST) MIME-Version: 1.0 References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> In-Reply-To: <87k17xsgaq.fsf@gnus.org> From: Stefan Kangas Date: Tue, 19 Nov 2019 15:49:49 +0100 Message-ID: Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000c28b350597b42df4" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000c28b350597b42df4 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: >> FWIW, I think the opposite. I think that zooming text, images and all >> buffer content together should be the default. I believe that it >> would feel both natural and familiar, especially to new users, since >> that's how e.g. web browsers, LibreOffice and evince, etc. works. > > That's true. I guess the scroll button could change both > image-scaling-factor and text-scale-mode-amount... Perhaps we should open a separate issue for that? > But, on the other hand, I could definitely see people preferring to > change just one or the other. So perhaps there should be separate > commands that people can bind according to their preference? 100 % agree. >> (That also reminds me that, IMO, text-scale-increase/decrease should >> be renamed to font-size-increase/decrease. The current names are not >> very discoverable; when one wants to change the font size, and says: >> `M-x font TAB'. At the very least, we should have such defaliases.) > > Makes sense to me. How does the attached patch look? I took the minimal route of just adding convenience aliases. Best regards, Stefan Kangas --000000000000c28b350597b42df4 Content-Type: application/octet-stream; name="0001-Add-aliases-font-size-increase-decrease.patch" Content-Disposition: attachment; filename="0001-Add-aliases-font-size-increase-decrease.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k35z53930 RnJvbSA5OGE3ZTMwZmVhY2NjODg3MzU0YjA1ZmNkZGI3MmM5YmQ3MTViOTViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDE5IE5vdiAyMDE5IDE1OjQ1OjE1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIGFsaWFzZXMgZm9udC1zaXplLXtpbmNyZWFzZSxkZWNyZWFzZX0KCiogbGlzcC9mYWNlLXJl bWFwLmVsIChmb250LXNpemUtaW5jcmVhc2UsIGZvbnQtc2l6ZS1kZWNyZWFzZSk6IE5ldwpjb252 ZW5pZW5jZSBhbGlhc2VzIGZvciAndGV4dC1zY2FsZS1pbmNyZWFzZScgYW5kCid0ZXh0LXNjYWxl LWRlY3JlYXNlJy4KLS0tCiBsaXNwL2ZhY2UtcmVtYXAuZWwgfCA0ICsrKysKIDEgZmlsZSBjaGFu Z2VkLCA0IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2ZhY2UtcmVtYXAuZWwgYi9s aXNwL2ZhY2UtcmVtYXAuZWwKaW5kZXggZjJmZjJlYzZmMS4uMDhlZjkxMWQxZiAxMDA2NDQKLS0t IGEvbGlzcC9mYWNlLXJlbWFwLmVsCisrKyBiL2xpc3AvZmFjZS1yZW1hcC5lbApAQCAtMzEyLDYg KzMxMiwxMCBAQCB0ZXh0LXNjYWxlLWRlY3JlYXNlCiAgIChpbnRlcmFjdGl2ZSAicCIpCiAgICh0 ZXh0LXNjYWxlLWluY3JlYXNlICgtIGRlYykpKQogCis7OyBDb252ZW5pZW5jZSBhbGlhc2VzLgor KGRlZmFsaWFzICdmb250LXNpemUtaW5jcmVhc2UgJ3RleHQtc2NhbGUtaW5jcmVhc2UpCisoZGVm YWxpYXMgJ2ZvbnQtc2l6ZS1kZWNyZWFzZSAndGV4dC1zY2FsZS1kZWNyZWFzZSkKKwogOzs7IyMj YXV0b2xvYWQgKGRlZmluZS1rZXkgY3RsLXgtbWFwIFsoY29udHJvbCA/KyldICd0ZXh0LXNjYWxl LWFkanVzdCkKIDs7OyMjI2F1dG9sb2FkIChkZWZpbmUta2V5IGN0bC14LW1hcCBbKGNvbnRyb2wg Py0pXSAndGV4dC1zY2FsZS1hZGp1c3QpCiA7OzsjIyNhdXRvbG9hZCAoZGVmaW5lLWtleSBjdGwt eC1tYXAgWyhjb250cm9sID89KV0gJ3RleHQtc2NhbGUtYWRqdXN0KQotLSAKMi4yMy4wCgo= --000000000000c28b350597b42df4-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 10:27:56 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 15:27:56 +0000 Received: from localhost ([127.0.0.1]:48233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX5Q4-0007Af-0L for submit@debbugs.gnu.org; Tue, 19 Nov 2019 10:27:56 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:44438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX5Q1-0007AQ-Hh for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 10:27:54 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJFBlpa013563; Tue, 19 Nov 2019 15:27:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=fKs0EXQCJJgZDQ+hUlYgXFyv3gftPZrP+xcpXL1opig=; b=j3XToxmS3Um6RY7rGmFLZbqx5YjFjbA2dkW3Mm4AGq3DzFuJ/VvFyXkajzGFnlptRzdx +WJLpw7lzrSWIPfV/f/mEX2aqlyR38/KN+H1zml5MAdCndEvAObkq3klkwVZjr3/v0mc Hu4GEztwzdP5U3pCQc/vzeB2ICUgwNUAFIKRiK3UvX6iO6eIdV8e7bQ83VhgnXFM39xz y+zro0J0R5mcDjkIYSfwpkDQbz01zrGXQlu3c4/ti4PUx7UUzwu27V4kH1xxbn4neBrq Q8mggmmj3e5fUqmZ4jbnP73QB9nxfl+BXaHzkp5q4kFFwN1e0SsokKjgVMX7xRZLe5sn 0Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2wa9rqfj2j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 15:27:46 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJF9G6C159616; Tue, 19 Nov 2019 15:27:46 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 2wc0agjdf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 15:27:46 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xAJFRhcc024305; Tue, 19 Nov 2019 15:27:44 GMT MIME-Version: 1.0 Message-ID: <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> Date: Tue, 19 Nov 2019 07:27:42 -0800 (PST) From: Drew Adams To: Stefan Kangas , Lars Ingebrigtsen Subject: RE: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190139 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190139 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > How does the attached patch look? I took the minimal route of just > adding convenience aliases. I repeat my objection. `font-size-*' does not make clear that this is about text scaling, which applies to a single _buffer, wherever it is displayed_. "Text scaling" is not a term that suggests changing the font size. OK, that's a disadvantage. But the advantage is that it is an Emacs-specific term, which, when consulted, tells you that it changes the apparent size of the text shown in the buffer, wherever it's shown. The important thing about this is that it is buffer-specific - affects only a single buffer, and it affects all displays of the buffer - in all windows. I contrasted buffer-text scaling with frame zooming, which affects all buffers shown in all windows of a single frame. (It does not affect any of those buffers shown in another frame.) IMO, "buffer" should be in the alias name somewhere. This is not about the default font for a frame; it's about the default face for a buffer. Default font vs default face, frame vs buffer. Big difference. Both kinds of zooming are useful, each in its way. Please add "buffer" to the aliases you're adding. For example: `buffer-font-size-increase'. (And it's not actually "font"; it's "face". But that's OK.) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:08:17 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 16:08:17 +0000 Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX636-0008F7-Sf for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:08:17 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:35324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX634-0008Et-4h for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 11:08:14 -0500 Received: by mail-pj1-f41.google.com with SMTP id s8so2809441pji.2 for <38187@debbugs.gnu.org>; Tue, 19 Nov 2019 08:08:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nYpuWTY+qt1itW1sWVM5W+s4boG6SiY19tFuVWN7/2I=; b=m2O85cc8yNbKJ5J+G7nd424EFpiWiJz7R0xZA/V6RJ1wVk63ebawaaSxQUrTWcF87H NQsr2VO32/NJsqLgjFqZzb3URk5QjBs0NMyo6K5foiSlUKa+ycLi21LnxgLoqtAGcsKc UjGMG5zePr63BAcWCRS07IemlixKAAi5t2nMgbGVqxhJZ7CQiETLTBrw/lSvbz2hKhu0 2/T8WFtZlX/YWNWAWBLMPeABLdbSq3WSQwv41TMLcmPjZ8KtDPjM6U7DafIlpduDVr90 JC+3hwIDA98XCundWdZvJt6kRo4aa5a0Mph7sNpKCoKYaFBJ669TsjtnaMABzAgELaMT WPog== X-Gm-Message-State: APjAAAXpG7qsErLqe5Od7gQEVOYsxeR1zUTm6nCOzC+wlfq676CMVy/Y t9haSORydAAI4MFY51IE1jehi+FYQfjq2hmD/yI= X-Google-Smtp-Source: APXvYqytBg/QuMGbvRi06Yqys763H1yXg22UyOBbQVetPJKyfWjyJjvuqUZufrj/QindjGEeFZTuTOyDiccxf3FkxNg= X-Received: by 2002:a17:902:5985:: with SMTP id p5mr16331839pli.259.1574179688131; Tue, 19 Nov 2019 08:08:08 -0800 (PST) MIME-Version: 1.0 References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> In-Reply-To: <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> From: Stefan Kangas Date: Tue, 19 Nov 2019 17:07:56 +0100 Message-ID: Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: > I repeat my objection. `font-size-*' does not make > clear that this is about text scaling, which applies > to a single _buffer, wherever it is displayed_. Do you agree that it makes it more clear than "increase-text-scale"? > The important thing about this is that it is > buffer-specific - affects only a single buffer, and > it affects all displays of the buffer - in all windows. AFAIK, we currently have no other way of changing the font size in Emacs. I believe that this feature will quickly be obvious to anyone who tries using "text-scale-increase" or "text-scale-decrease". > Please add "buffer" to the aliases you're adding. > For example: `buffer-font-size-increase'. I don't object in principle. But again, we don't have "frame-font-size-increase" or "window-font-size-increase", so I'm not sure if it makes things much better. And to make it discoverable, perhaps it's better if it starts with "font"? > (And it's not actually "font"; it's "face". But > that's OK.) Yes, there is that added confusion. The terminology here seems to be less than great, since the same thing can interchangeably be called "increase font size", "increase text size", or "zoom". See for example this page from Firefox which manages to use all three of these in one page: https://support.mozilla.org/en-US/kb/font-size-and-zoom-increase-size-of-web-pages (IME, it is never called "increase text scale" outside of Emacs.) Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:13:02 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 16:13:02 +0000 Received: from localhost ([127.0.0.1]:48326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX67i-0008ML-17 for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:13:02 -0500 Received: from mail-pf1-f177.google.com ([209.85.210.177]:34623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX67f-0008Ly-LL for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 11:13:00 -0500 Received: by mail-pf1-f177.google.com with SMTP id n13so12417757pff.1 for <38187@debbugs.gnu.org>; Tue, 19 Nov 2019 08:12:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gOcdhr2j9Agsw6JtMwuSaZAX1+qYAWtFQWqN7/sf01E=; b=k0i+B/3b8fUbo6xPxGI9BpOm+TXgHfmJQrZZ64oikUyZF50WwpMOt/aT/qGDYJB6vb LizIX2UGL9b1uYSraiB2mN0kPUKS996ijTwyHZKxlOFiTRkwEhcW4EYL9o6zAUFM7ZTo 6RKqCAgXcFXqdMq4WU/gUP0CR70QDYLblfd20BtUSnYVbfAivmCexqqF0U5SfI9nATDg Mkq+MAIqv2K4ANGZEAXEFPK7z3/WfqyltOgw9q2aGBo0CsdqW02oZ3jm/aml99XGnzNf OZNXtd2TfF2gwXbAI4XO4IRSs4dNIqD0PX57vUnO7R3CJFZ7MjanZcWN+QJ0TBuz1Q8h tGGQ== X-Gm-Message-State: APjAAAV7j2aSMiw+dBzsYRFfx7wSUFCi7boeAiLW59rHdTE8BHfcSkHa vqhdn4BO7nVWXWwAvyrO5Y0iGipB6pG5PV1VVlE= X-Google-Smtp-Source: APXvYqw9DxqNLuWMVIfWhaBnNWrZ0hKXZgddpckgX/AL6+P+GjTVX2Dg1musrozvnKXEb4W7x5SUV+9m+yVHJ1ZDvgY= X-Received: by 2002:a62:7f93:: with SMTP id a141mr6572195pfd.107.1574179973944; Tue, 19 Nov 2019 08:12:53 -0800 (PST) MIME-Version: 1.0 References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> In-Reply-To: From: Stefan Kangas Date: Tue, 19 Nov 2019 17:12:41 +0100 Message-ID: Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Stefan Kangas writes: > AFAIK, we currently have no other way of changing the font size in > Emacs. I believe that this feature will quickly be obvious to anyone > who tries using "text-scale-increase" or "text-scale-decrease". For clarity, I should probably say "changing the font size in a running Emacs", and also excluding things like customizing faces, using menus or dialogs (I never use them), etc. I'm specifically talking about the "temporarily change the font size in this buffer/window/frame" kind of thing. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:27:45 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 16:27:45 +0000 Received: from localhost ([127.0.0.1]:48347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6Lw-0002EQ-Kn for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:27:44 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:50878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6Lt-0002EC-Qg for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 11:27:43 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJG9P4m083791; Tue, 19 Nov 2019 16:27:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=KuPwad8RG5XoyXDLpAinMGI1YnLiQjtnSVedFLPm4VA=; b=WNc0DUkkdxIsSLleLyJMvvX3J+97OpaIiELfcCwD7/mJtLZNRv+VCstIz5Bd7JMcvKDN 2a45Enesz9vfwllfSWjJe/blBG59zpjA7pDdrl8zTAUnz4ZE9CBVR3y/scBIAT5WRqT6 xk6+s6CfdbMew6rozO3qvOVd71LfuRi1jgxAZ05JUgXSGtuOykPl3WWSBLIeQxvHahhz ogOnu+7OtyQ7HJ7Bnfptv0jgxXTTYckmYcjlUebvl8PkxSalAG2/dW5nu/32OUn3RihC hU3WGrAnjlbxXVj7zkbyW9r0MmI4OanZcyA2V541BjIAYSLOZprLgPbqFCIcBWhjEofB kw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2wa92pr13m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 16:27:35 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJGE6Q1132760; Tue, 19 Nov 2019 16:27:35 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2wc09xn7ch-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 16:27:34 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xAJGRWfB002256; Tue, 19 Nov 2019 16:27:32 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 19 Nov 2019 08:27:32 -0800 (PST) From: Drew Adams To: Stefan Kangas Subject: RE: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190145 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9445 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190145 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I repeat my objection. `font-size-*' does not make > > clear that this is about text scaling, which applies > > to a single _buffer, wherever it is displayed_. >=20 > Do you agree that it makes it more clear than "increase-text-scale"? Uh, no. Why would `font-size-*' make it more clear that it's about text scaling? > > The important thing about this is that it is > > buffer-specific - affects only a single buffer, and > > it affects all displays of the buffer - in all windows. >=20 > AFAIK, we currently have no other way of changing the font size in > Emacs. I believe that this feature will quickly be obvious to anyone > who tries using "text-scale-increase" or "text-scale-decrease". But we do. I mentioned library `zoom-frm.el'. And any of that code or similar could be added to vanilla Emacs. I encourage its addition. Letting C-x C-+, C-x C-=3D, C-x C--, C-x C-0 zoom either a frame or a buffer is a plus, with no minus. The point is that text scaling is _one_ way to change the apparent size of text. That way affects a single _buffer_, in all its windows. (And it does that by face remapping.) There are other ways to change displayed text size. The name for this particular feature should, IMO, reflect what it does specifically, especially since we know that there are other possibilities. > > Please add "buffer" to the aliases you're adding. > > For example: `buffer-font-size-increase'. >=20 > I don't object in principle. But again, we don't have > "frame-font-size-increase" or "window-font-size-increase", > so I'm not sure if it makes things much better. And to > make it discoverable, perhaps it's better if it starts > with "font"? >=20 > > (And it's not actually "font"; it's "face". But > > that's OK.) >=20 > Yes, there is that added confusion. The terminology here seems to be > less than great, since the same thing can interchangeably be called > "increase font size", "increase text size", or "zoom". See for > example this page from Firefox which manages to use all three of these > in one page: ... Interchangeably outside Emacs, perhaps. Those are different, non-interchangeable things inside Emacs. > (IME, it is never called "increase text scale" outside of Emacs.) What are faces called outside Emacs? (Trick question) Emacs has face remapping. Does outside Emacs? Emacs has buffers and windows (and frames) as separate kinds of objects that can be, but need not be, used together. Such distinctions don't make sense (at least in most cases) outside Emacs. Inside Emacs, they do. And we are talking about inside Emacs. There are ways to make things discoverable without losing distinctions that are important to Emacs. And adding "buffer" to the alias name doesn't in any way detract from discoverability. Quite the contrary. If and when we do have other ways to zoom (and I hope we do use that term "zoom", including for discoverability), finding _this_ way using the keyword "buffer" will be important for discoverability. (I didn't object to the use of "font" instead of "face" in order to help with discoverability.) Just one opinion. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:31:11 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 16:31:11 +0000 Received: from localhost ([127.0.0.1]:48358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6PH-0002L8-5o for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:31:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6PB-0002KB-AQ for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 11:31:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX6P4-0003xK-5r; Tue, 19 Nov 2019 11:30:59 -0500 Received: from [176.228.60.248] (port=2203 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX6P1-0006DC-BM; Tue, 19 Nov 2019 11:30:57 -0500 Date: Tue, 19 Nov 2019 18:31:01 +0200 Message-Id: <83tv6z25h6.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 19 Nov 2019 17:07:56 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, 38187@debbugs.gnu.org, drew.adams@oracle.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 19 Nov 2019 17:07:56 +0100 > Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, > Juri Linkov > > > Please add "buffer" to the aliases you're adding. > > For example: `buffer-font-size-increase'. > > I don't object in principle. But again, we don't have > "frame-font-size-increase" or "window-font-size-increase", so I'm not > sure if it makes things much better. buffer-font-size-increase indeed is inaccurate, since buffers have no fonts. > And to make it discoverable, perhaps it's better if it starts with > "font"? But which font? The feature doesn't change fonts, it remaps faces. If you think there could be a problem with discoverability, we could add some index entries to the manual, and maybe mention "font" in the doc string of the command. Other than that, I really don't see how this could be hard to discover: we have just added a binding of C-wheel-up and C-wheel-down, something that every application out there supports, haven't we? So what kind of discoverability problems we envision with that binding in place? From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 11:54:29 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 16:54:30 +0000 Received: from localhost ([127.0.0.1]:48407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6lp-0002v3-KF for submit@debbugs.gnu.org; Tue, 19 Nov 2019 11:54:29 -0500 Received: from mail-pf1-f169.google.com ([209.85.210.169]:44069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX6ln-0002up-Ck for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 11:54:27 -0500 Received: by mail-pf1-f169.google.com with SMTP id q26so12434096pfn.11 for <38187@debbugs.gnu.org>; Tue, 19 Nov 2019 08:54:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zd1DJ0yFqwyEWUz+3uV+FX5sLltq29SnEwJEwHRBZQs=; b=Z6DUv9hbZ3Z9drBt2hc9oiWSsmqPtEcqhwG10ockBwdPv9zob4HIExiMuxALeTYtYT wvmtHuJwxXEc3TNeCoRa9pqXZQek/iLgSgOKRs9CPfWLWj6lrgGzQzFemnEKZnFxGP17 NuxV7ROQry9Irnq5ml8B4ivVCJAx8kP6fBq2BsXP0b3mNV+91iNNE1dKhC7wtzBI/GsH AnLaQV28DKxzsy95pcLfKKxvkSx5epuahO1x0hpVVTQLd/ynAccS+WaX2YULUT6C+824 gwCWM9M/WtI89ZilUk7E0+IIZrY++rZpNv0DB53quSeO3u7ZF8FlSiPlHaDXvrdUR2U9 a08Q== X-Gm-Message-State: APjAAAVRewD+E5GVhLjU0WaOSLyLNWnflOwaDjDmhk24dFrH5mMXtiZJ kPPIaXZhffxL6WgR5+yDbXjj6OXP6MMtzJjV4CE= X-Google-Smtp-Source: APXvYqwmVjn8ypm8WHW8uP57kPkw8YZhKsYsL3jALfSI+KrMKwtGMQEouqSsna7oaI5+a2MMlEmFDPjkFpiQVxWUkr4= X-Received: by 2002:a63:7015:: with SMTP id l21mr6221771pgc.200.1574182461365; Tue, 19 Nov 2019 08:54:21 -0800 (PST) MIME-Version: 1.0 References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> <83tv6z25h6.fsf@gnu.org> In-Reply-To: <83tv6z25h6.fsf@gnu.org> From: Stefan Kangas Date: Tue, 19 Nov 2019 17:54:09 +0100 Message-ID: Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Drew Adams , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > If you think there could be a problem with discoverability, we could > add some index entries to the manual, and maybe mention "font" in the > doc string of the command. > > Other than that, I really don't see how this could be hard to > discover: we have just added a binding of C-wheel-up and C-wheel-down, > something that every application out there supports, haven't we? So > what kind of discoverability problems we envision with that binding in > place? That's a very good point. I might be living in the past when we didn't have these key bindings. Since we also can't seem to be able to find a much better command name, I'll retract my defalias proposal and look into your suggestion to add an entry to the index instead. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 12:28:01 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 17:28:01 +0000 Received: from localhost ([127.0.0.1]:48470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX7IH-0003pA-Bi for submit@debbugs.gnu.org; Tue, 19 Nov 2019 12:28:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX7IG-0003ok-0D for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 12:28:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iX7I9-0007al-AT; Tue, 19 Nov 2019 12:27:53 -0500 Received: from [176.228.60.248] (port=2057 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iX7I8-0006Jp-5G; Tue, 19 Nov 2019 12:27:52 -0500 Date: Tue, 19 Nov 2019 19:27:57 +0200 Message-Id: <83o8x722ua.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-reply-to: (message from Stefan Kangas on Tue, 19 Nov 2019 17:07:56 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, 38187@debbugs.gnu.org, drew.adams@oracle.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Tue, 19 Nov 2019 17:07:56 +0100 > Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, > Juri Linkov > > AFAIK, we currently have no other way of changing the font size in > Emacs. Btw, this is inaccurate: we have at least 2 other ways: . S-mouse-1->"Change buffer font...", pops up the font selection dialog, where you can change the size of the font used in the current buffer. . Options->"Set Default Font..." pops up the same font selection dialog, but the selected font size will become the default face's font size. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 18:20:48 2019 Received: (at 38187) by debbugs.gnu.org; 19 Nov 2019 23:20:49 +0000 Received: from localhost ([127.0.0.1]:48708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCng-0004RS-CI for submit@debbugs.gnu.org; Tue, 19 Nov 2019 18:20:48 -0500 Received: from eastern.birch.relay.mailchannels.net ([23.83.209.55]:1514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCnb-0004RG-JS for 38187@debbugs.gnu.org; Tue, 19 Nov 2019 18:20:45 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A1BA6580C25; Tue, 19 Nov 2019 23:20:42 +0000 (UTC) Received: from pdx1-sub0-mail-a94.g.dreamhost.com (100-96-87-246.trex.outbound.svc.cluster.local [100.96.87.246]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 342F4580FEF; Tue, 19 Nov 2019 23:20:42 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a94.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 19 Nov 2019 23:20:42 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Relation: 56aaa7c375acbff6_1574205642469_3306315986 X-MC-Loop-Signature: 1574205642469:4018076696 X-MC-Ingress-Time: 1574205642469 Received: from pdx1-sub0-mail-a94.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTP id 085667FC4D; Tue, 19 Nov 2019 15:20:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=9yEYrpf8fm+FnDQjOebBD5Z2Akw=; b= EWhFao1UWeHI5n5ozLU982pi0hHUoeiCDsT5ke9qe4SRadaaFLjn4TznGT+Fzrzs Fs+cOpeRBOmh1gTprdPEh+EjpScXKFD0IlGm1TzFTfhwd34FV/pUHxV5UqekGf31 fVKDVUBmvTSbwcHwMJvqABtu3+M8u10/kRGgCDn3RkU= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a94.g.dreamhost.com (Postfix) with ESMTPSA id 5B5FB7FC57; Tue, 19 Nov 2019 15:20:32 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a94 From: Juri Linkov To: Stefan Kangas Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> <83tv6z25h6.fsf@gnu.org> Date: Wed, 20 Nov 2019 00:50:16 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 19 Nov 2019 17:54:09 +0100") Message-ID: <871ru3qx7r.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , 38187@debbugs.gnu.org, Lars Ingebrigtsen , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Since we also can't seem to be able to find a much better command > name, I'll retract my defalias proposal and look into your suggestion > to add an entry to the index instead. Yes, adding aliases doesn't help much in discoverability, but adds more confusion because then users might think that these are different commands for different features, and it takes more time to check that these are aliases. Adding an entry to the index helps in discoverability without adding more confusion. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 18:15:36 2019 Received: (at 38187) by debbugs.gnu.org; 20 Nov 2019 23:15:36 +0000 Received: from localhost ([127.0.0.1]:51069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZCA-0006jj-LC for submit@debbugs.gnu.org; Wed, 20 Nov 2019 18:15:35 -0500 Received: from bongo.elm.relay.mailchannels.net ([23.83.212.21]:19237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZC8-0006ja-M8 for 38187@debbugs.gnu.org; Wed, 20 Nov 2019 18:15:33 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7632A581010; Wed, 20 Nov 2019 23:15:31 +0000 (UTC) Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-86-105.trex.outbound.svc.cluster.local [100.96.86.105]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A65FB581249; Wed, 20 Nov 2019 23:15:30 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 20 Nov 2019 23:15:31 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Shoe-Trouble: 4a2adbdc65b98943_1574291730919_204650584 X-MC-Loop-Signature: 1574291730919:181892662 X-MC-Ingress-Time: 1574291730919 Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id D975D832E2; Wed, 20 Nov 2019 15:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=hPzKHRb0houDUVhLwpsLqMxfQ0o=; b= SEbZqtsdBSBub1aMbQbxDGStB3usBrEGJ7oR18chVPaLhLi8fgFj37ID1h5R3VqG voQ8MKG5mMvHuT1e9VJ87/7CIYaaXlrC/RGWEtPF9KArQo3/MBrRMFJGBcwyxuEb eOSOP1B24Sn03eOhsO+1Xr8MHqrhfx5TdkR5EsW6qSc= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id 5A242832D8; Wed, 20 Nov 2019 15:15:22 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> Date: Thu, 21 Nov 2019 01:00:53 +0200 In-Reply-To: <83ftik35kw.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2019 05:31:11 +0200") Message-ID: <87pnhmm9ui.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> -(defun image-increase-size (n) >> +(defun image-increase-size (&optional n event) > > Can we avoid mixing numerical argument with a mouse event? It looks > unclean to me. How about a simple wrapper that accepts a mouse event > and calls image-increase/decrease-size with a suitable arg? So I installed a new patch with wrappers. BTW, while testing it for image scaling on a quite small image file, Emacs consumed several GB of all available memory and almost all swap, before I noticed and evaluated M-: (clear-image-cache) that freed memory. Memory leak? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 18:15:44 2019 Received: (at 38187) by debbugs.gnu.org; 20 Nov 2019 23:15:44 +0000 Received: from localhost ([127.0.0.1]:51072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZCK-0006k6-18 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 18:15:44 -0500 Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:5601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZCG-0006ju-2a for 38187@debbugs.gnu.org; Wed, 20 Nov 2019 18:15:40 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E76246A1764; Wed, 20 Nov 2019 23:15:38 +0000 (UTC) Received: from pdx1-sub0-mail-a44.g.dreamhost.com (100-96-89-221.trex.outbound.svc.cluster.local [100.96.89.221]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 45C5C6A168C; Wed, 20 Nov 2019 23:15:38 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a44.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Wed, 20 Nov 2019 23:15:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abaft-Name: 48fa539c4b8ebc51_1574291738544_3845582683 X-MC-Loop-Signature: 1574291738544:3753294061 X-MC-Ingress-Time: 1574291738544 Received: from pdx1-sub0-mail-a44.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTP id BA306832E1; Wed, 20 Nov 2019 15:15:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=FmgIv+WYS2+lQlUYJshrFNDwqAY=; b= mgcRbRgW9yYZKyWhiFBMCPl9wpdEEV6XvJ5BSity4GN7SelhH3rO+nTVkA4DQFFn kBXnr9OOfgxTn1bweBIpllKCyMNUT1a6smV9vEkjkbR9SZCHDQWqkpuzyQOuLQPQ Guwm/2iHEUb0mxpI3KuCHUJ5j+xwHC/eL9nWheqERfU= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a44.g.dreamhost.com (Postfix) with ESMTPSA id 74FB1832DA; Wed, 20 Nov 2019 15:15:31 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a44 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> Date: Thu, 21 Nov 2019 01:12:17 +0200 In-Reply-To: <87zhgsnv7x.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 Nov 2019 09:09:22 +0100") Message-ID: <87h82ykur6.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain >> I tested this patch, and it works well: > > Great! And I agree with Eli's comment -- a separate wrapper command > that just takes an event would be a clearer interface. I noticed that using the mouse-wheel on images is not responsive enough. It takes too much time when every step of the mouse scrolling wheel needs to scale the image separately for every consecutive rescaling. So I experimented with debouncing - a new macro 'debounce' swallows all intermediate calls in quick succession to 'image--change-size', and executes only the last call in sequence. But actually it requires another better macro 'debounce-reduce' that accumulates the state from all calls by multiplying all intermediate scaling factors, and using the result on the final call: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=debounce-reduce.patch diff --git a/lisp/emacs-lisp/timer.el b/lisp/emacs-lisp/timer.el index 561cc70078..48301fd4fd 100644 --- a/lisp/emacs-lisp/timer.el +++ b/lisp/emacs-lisp/timer.el @@ -488,6 +488,48 @@ y-or-n-p-with-timeout If the user does not answer after SECONDS seconds, return DEFAULT-VALUE." (with-timeout (seconds default-value) (y-or-n-p prompt))) + +(defmacro debounce (secs function) + "Call FUNCTION after SECS seconds have elapsed. +Postpone FUNCTION call until after SECS seconds have elapsed since the +last time it was invoked. On consecutive calls within the interval of +SECS seconds, cancel all previous calls and in quick succession execute +only the last call." + (declare (indent 1) (debug t)) + (let ((timer-sym (make-symbol "timer"))) + `(let (,timer-sym) + (lambda (&rest args) + (when (timerp ,timer-sym) + (cancel-timer ,timer-sym)) + (setq ,timer-sym + (run-with-timer + ,secs nil (lambda () + (apply ,function args)))))))) + +(defmacro debounce-reduce (secs state-function function) + "Call FUNCTION after SECS seconds have elapsed. +Postpone FUNCTION call until after SECS seconds have elapsed since the +last time it was invoked. On consecutive calls within the interval of +SECS seconds, cancel all previous calls and in quick succession execute +only the last call. +STATE-FUNCTION can be used to calculate the state on consecutive calls, +and execute the last call with the collected state." + (declare (indent 1) (debug t)) + (let ((timer-sym (make-symbol "timer")) + (state-sym (make-symbol "state"))) + `(let (,timer-sym ,state-sym) + (lambda (&rest args) + (setq ,state-sym (apply ,state-function ,state-sym args)) + (when (timerp ,timer-sym) + (cancel-timer ,timer-sym)) + (setq ,timer-sym + (run-with-timer + ,secs nil (lambda () + (apply ,function (if (listp ,state-sym) + ,state-sym + (list ,state-sym))) + (setq ,state-sym nil)))))))) + (defconst timer-duration-words (list (cons "microsec" 0.000001) diff --git a/lisp/image.el b/lisp/image.el index e0965c1091..d57ae3a720 100644 --- a/lisp/image.el +++ b/lisp/image.el @@ -1016,18 +1016,20 @@ image-increase-size If N is 3, then the image size will be increased by 30%. The default is 20%." (interactive "P") - (image--change-size (if n - (1+ (/ (prefix-numeric-value n) 10.0)) - 1.2))) + (funcall image--change-size + (if n + (1+ (/ (prefix-numeric-value n) 10.0)) + 1.2))) (defun image-decrease-size (&optional n) "Decrease the image size by a factor of N. If N is 3, then the image size will be decreased by 30%. The default is 20%." (interactive "P") - (image--change-size (if n - (- 1 (/ (prefix-numeric-value n) 10.0)) - 0.8))) + (funcall image--change-size + (if n + (- 1 (/ (prefix-numeric-value n) 10.0)) + 0.8))) (defun image-mouse-increase-size (&optional event) "Increase the image size using the mouse." @@ -1062,12 +1064,16 @@ image--get-imagemagick-and-warn (plist-put (cdr image) :type 'imagemagick)) image)) -(defun image--change-size (factor) - (let* ((image (image--get-imagemagick-and-warn)) - (new-image (image--image-without-parameters image)) - (scale (image--current-scaling image new-image))) - (setcdr image (cdr new-image)) - (plist-put (cdr image) :scale (* scale factor)))) +(defvar image--change-size + (debounce-reduce 0.3 + (lambda (state factor) + (* (or state 1) factor)) + (lambda (factor) + (let* ((image (image--get-imagemagick-and-warn)) + (new-image (image--image-without-parameters image)) + (scale (image--current-scaling image new-image))) + (setcdr image (cdr new-image)) + (plist-put (cdr image) :scale (* scale factor)))))) (defun image--image-without-parameters (image) (cons (pop image) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 19:02:09 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 00:02:10 +0000 Received: from localhost ([127.0.0.1]:51103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZvF-0007wb-Kr for submit@debbugs.gnu.org; Wed, 20 Nov 2019 19:02:09 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:36930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXZvD-0007wB-P4 for 38187@debbugs.gnu.org; Wed, 20 Nov 2019 19:02:08 -0500 Received: by mail-pf1-f170.google.com with SMTP id p24so636597pfn.4 for <38187@debbugs.gnu.org>; Wed, 20 Nov 2019 16:02:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HDf3p0ZdQXJYaemwt6Cl1+5jXmxMMEiVHiNmL4QbJEQ=; b=cJQTzJ1/P0OTBSSLHUtWAWae938m8C6xbA94CqEO9M2GYB5L8wOUsZRcEQOmQ3f/Cf jHDWcLLQX3ZMWcllDd9aH56ETWqGhS9HqPktQS/x8SScB6NlNjz8wdko0DESCefXn4iE Y9LKIN2gpFeWjox3SLAAH1QGq836vIFUnL8JL2eEAqq7Yq8lc3aBZTBreFelz6PRIqTd cy44taTyLRSIot9iQqHx9Zi4L8OwcnJ1EdyYWdnU+yL2XEvZ4jSmtRH0obiIlOzSWXS4 uHwQXkosXv+DlPI9pW/jWWUv0i2O6dXBNhR8xWCk08H4PtBsepXDh4GQrsNEzilYpWwA bPjQ== X-Gm-Message-State: APjAAAW8L5djhfpuxXjQLcccVo05PJeQhyCyEXqOMtwpuGOTdDWOjaTm EcrGD3PCdIb+F3dlSO0A4d3T/oHs//9H11Mi1jU= X-Google-Smtp-Source: APXvYqwEERKpeclReZc1g+0gHry8BgiBklGhiG7/nipbwOpC7HV5ef0t12vtE5tWJ/WbJMSXDSC0jt8JgGlk/eBaB/g= X-Received: by 2002:a63:4948:: with SMTP id y8mr6438156pgk.333.1574294521693; Wed, 20 Nov 2019 16:02:01 -0800 (PST) MIME-Version: 1.0 References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> In-Reply-To: From: Stefan Kangas Date: Thu, 21 Nov 2019 01:01:50 +0100 Message-ID: Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images To: Drew Adams Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Drew Adams writes: > But we do. I mentioned library `zoom-frm.el'. And > any of that code or similar could be added to vanilla > Emacs. I encourage its addition. Letting C-x C-+, > C-x C-=, C-x C--, C-x C-0 zoom either a frame or a > buffer is a plus, with no minus. It would be useful if you could rework that into a patch. I think there would be interest for having such a feature in Emacs. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 19:43:26 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 00:43:26 +0000 Received: from localhost ([127.0.0.1]:51130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXaZC-0000Xh-5W for submit@debbugs.gnu.org; Wed, 20 Nov 2019 19:43:26 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:44380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXaZ9-0000XT-K5 for 38187@debbugs.gnu.org; Wed, 20 Nov 2019 19:43:24 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAL0d0q4085648; Thu, 21 Nov 2019 00:43:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=p4eSGk78jXhmCw/6Pn1yHboUdzqu1Ttwm7putZrtXW8=; b=AYmXH+AC7P13JuFDFcwA/8RFs7zWGtq5Mscv54Gh8NVhlzvSPwY9fw4EDmujGYm3N6pT lPRh+1uUKdXkRFfcPe9Fhu7CPaK5Y3W18f3owf3zMb1UPvysT1WArmmPVwml/QDVurad BnK90PlWyuhNFLmK1Es45wy1xhHpEyLhK8CkBXL48XsscTbHuyAf8AYc2+YBFvcrjHzd TlyqPmRhlq0yzhxiVn8LOIu/N9chUutMwkj+XQvq3PHaU+DVyTvSI0n9rm2s5OLToLFN JCluEf48+j5CZpr9+itkujNm/XT05y6emj87mZVEj9PcFxS7c7AWczi1CAzjLV0I2QEG Mg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2wa92q0xqs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Nov 2019 00:43:17 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAL0cOBU031770; Thu, 21 Nov 2019 00:41:16 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2wd46xbg3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Nov 2019 00:41:16 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xAL0fClT015035; Thu, 21 Nov 2019 00:41:12 GMT MIME-Version: 1.0 Message-ID: Date: Wed, 20 Nov 2019 16:41:11 -0800 (PST) From: Drew Adams To: Stefan Kangas Subject: RE: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87k17xsgaq.fsf@gnus.org> <4d4ce42d-2ae2-4df2-8d9e-0be50fb28dd0@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9447 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=938 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911210002 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9447 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911210002 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , 38187@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > But we do. I mentioned library `zoom-frm.el'. And > > any of that code or similar could be added to vanilla > > Emacs. I encourage its addition. Letting C-x C-+, > > C-x C-=3D, C-x C--, C-x C-0 zoom either a frame or a > > buffer is a plus, with no minus. >=20 > It would be useful if you could rework that into a patch. I think > there would be interest for having such a feature in Emacs. I could. But frankly I've pretty much had it with spending time on patches, just to have them ignored or dismissed summarily. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D37417#11 I'm afraid I'd now have to have some indication that a patch would be applied, before I'd waste more time preparing one. ___ FYI: A patch for what zoom-frm.el offers would need to include functions `enlarge-font' and its helper function `frcmds-enlarged-font-name', both from my library `frame-cmds.el'. Or just the alternative version of `enlarge-font' there (in a comment), which uses `set-face-attribute'. https://www.emacswiki.org/emacs/download/frame-cmds.el From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 22:35:57 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 03:35:57 +0000 Received: from localhost ([127.0.0.1]:51155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXdG9-0004ji-17 for submit@debbugs.gnu.org; Wed, 20 Nov 2019 22:35:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXdG7-0004jU-GC for 38187@debbugs.gnu.org; Wed, 20 Nov 2019 22:35:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52672) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXdG1-0002ea-TT; Wed, 20 Nov 2019 22:35:49 -0500 Received: from [176.228.60.248] (port=3822 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXdG0-0000HJ-SU; Wed, 20 Nov 2019 22:35:49 -0500 Date: Thu, 21 Nov 2019 05:35:59 +0200 Message-Id: <838so9zysg.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87pnhmm9ui.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 21 Nov 2019 01:00:53 +0200) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org > Date: Thu, 21 Nov 2019 01:00:53 +0200 > > BTW, while testing it for image scaling on a quite small image file, > Emacs consumed several GB of all available memory and almost all swap, > before I noticed and evaluated M-: (clear-image-cache) that freed memory. > > Memory leak? Can you show a recipe for reproducing this and report is as a separate bug? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 07:11:19 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 12:11:19 +0000 Received: from localhost ([127.0.0.1]:51468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXlIt-0000W2-Dx for submit@debbugs.gnu.org; Thu, 21 Nov 2019 07:11:19 -0500 Received: from quimby.gnus.org ([95.216.78.240]:58072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXlIr-0000Vq-Um for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 07:11:18 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXlId-0004BC-1F; Thu, 21 Nov 2019 13:11:09 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> <87h82ykur6.fsf@mail.linkov.net> Date: Thu, 21 Nov 2019 13:11:02 +0100 In-Reply-To: <87h82ykur6.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 21 Nov 2019 01:12:17 +0200") Message-ID: <87o8x54eg9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > I noticed that using the mouse-wheel on images is not responsive enough. > It takes too much time when every step of the mouse scrolling wheel > needs to scale the image separately for every consecu [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > I noticed that using the mouse-wheel on images is not responsive enough. > It takes too much time when every step of the mouse scrolling wheel > needs to scale the image separately for every consecutive rescaling. Yeah, users are more likely to issue a bunch of scroll wheel events rapidly than hitting `+' at the same rate, I guess. > So I experimented with debouncing - a new macro 'debounce' swallows > all intermediate calls in quick succession to 'image--change-size', > and executes only the last call in sequence. > > But actually it requires another better macro 'debounce-reduce' > that accumulates the state from all calls by multiplying all > intermediate scaling factors, and using the result on the final call: Makes sense to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 09:25:00 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 14:25:01 +0000 Received: from localhost ([127.0.0.1]:51652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnOG-0000fd-K7 for submit@debbugs.gnu.org; Thu, 21 Nov 2019 09:25:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXnOD-0000fN-Kk for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 09:24:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iXnO8-0004rK-BK; Thu, 21 Nov 2019 09:24:52 -0500 Received: from [176.228.60.248] (port=3457 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iXnO7-0002Wm-Q0; Thu, 21 Nov 2019 09:24:52 -0500 Date: Thu, 21 Nov 2019 16:25:03 +0200 Message-Id: <83zhgpxq68.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87o8x54eg9.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 21 Nov 2019 13:11:02 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> <87h82ykur6.fsf@mail.linkov.net> <87o8x54eg9.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Stefan Kangas , Eli Zaretskii , > 38187@debbugs.gnu.org > Date: Thu, 21 Nov 2019 13:11:02 +0100 > > Juri Linkov writes: > > > So I experimented with debouncing - a new macro 'debounce' swallows > > all intermediate calls in quick succession to 'image--change-size', > > and executes only the last call in sequence. > > > > But actually it requires another better macro 'debounce-reduce' > > that accumulates the state from all calls by multiplying all > > intermediate scaling factors, and using the result on the final call: > > Makes sense to me. Does it help to bind redisplay-dont-pause to a nil value inside image--change-size? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 16:18:44 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 21:18:44 +0000 Received: from localhost ([127.0.0.1]:53407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtqe-00033T-HI for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:18:44 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:35546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtqc-00033G-9P for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 16:18:42 -0500 Received: by mail-wr1-f46.google.com with SMTP id s5so6213452wrw.2 for <38187@debbugs.gnu.org>; Thu, 21 Nov 2019 13:18:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=N2sfhvut0RYTCt+8MGazpW6lb2h+jHh07buaYiEUcHU=; b=YC8KKTmjXPli0KezkLb2GHjY5hFhxu+neqHNQohhRM6vjoGaE4T77ha2+dUHYE5mhy NhN/kf2UTXK9NOemVokrZlVpyOUHbFR2lVEQmQnInTqfPa/TFMMxs70UpU28zEomHYF3 LBld1aTzQIG/U0UDRr7N+nntwof5Ggh67hGVlY49MLIMnycoRMTFPpFKUzirFpPd9yNZ UkLbWyqBfynfzkdOHNe2xlVov2Cw3ljPC0fZhqDJ8zEwWqjn1neuXoqQT8j7zT5BMJPc bF+l257kJqOEzkkWBct0w8R+ucKUzMz7yarAKr1/ZJVREgCqHpFK2wcKRK7GcA0uGKdQ 7gfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=N2sfhvut0RYTCt+8MGazpW6lb2h+jHh07buaYiEUcHU=; b=V2hbAOY/6JoFYwatAAyVWsoBITnEwVEPikc3524eAqhbfe7EyKBslXkvklqfVQ/fFU w3G+8CFRea/37nTbl2MBr0qu4w1E86/DEgrjVY6XNWROp6P6tVejGsilUeYAObqiF5EW /kIJajsX4lYIpibuBcfJfD6cFYSY8LkJ0rHtcZZG16CUpoUmniCDyZCeqJQ0LrdFFAXg piWDcgFOtD3THCQeptmZOV/DRWYmHZxCFXriZowxiduhVgEQONTWK2h34fADxSrKL4RU P9a7kSaXyq6B+Z7WC3zwD+Un+DpWNvPMhYeC6XEweU5S+022rT4rpPHgksWRBYtthqJE keQA== X-Gm-Message-State: APjAAAUhiIfyjuXcSKD1cmm80n0qTNn6VcWO3YqtAnX5WUNdaVA4d3X+ XyMGoM6l6YNhv6qXWGUZ1XU= X-Google-Smtp-Source: APXvYqxhL6forViF/v+dvQGFMnSx7DuBUP4xPTongbVV0WG9fB49NpHkWCAjkkMk9qvHTu3SEofIhA== X-Received: by 2002:adf:f150:: with SMTP id y16mr5187175wro.192.1574371116207; Thu, 21 Nov 2019 13:18:36 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1980-cc6a-4f4e-9c42.holly.idiocy.org. [2001:8b0:3f8:8129:1980:cc6a:4f4e:9c42]) by smtp.gmail.com with ESMTPSA id w13sm4625936wrm.8.2019.11.21.13.18.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 13:18:34 -0800 (PST) Date: Thu, 21 Nov 2019 21:18:32 +0000 From: Alan Third To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Message-ID: <20191121211832.GB96045@breton.holly.idiocy.org> References: <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pnhmm9ui.fsf@mail.linkov.net> User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , stefan@marxist.se, larsi@gnus.org, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Nov 21, 2019 at 01:00:53AM +0200, Juri Linkov wrote: > >> -(defun image-increase-size (n) > >> +(defun image-increase-size (&optional n event) > > > > Can we avoid mixing numerical argument with a mouse event? It looks > > unclean to me. How about a simple wrapper that accepts a mouse event > > and calls image-increase/decrease-size with a suitable arg? > > So I installed a new patch with wrappers. > > BTW, while testing it for image scaling on a quite small image file, > Emacs consumed several GB of all available memory and almost all swap, > before I noticed and evaluated M-: (clear-image-cache) that freed memory. > > Memory leak? Was this on X? Emacs probably keeps a copy of the image in memory for each size until the image cache is cleared or pruned. I’m a little unsure exactly how the image cache works because there appears to be a second level pixmap cache that I think should avoid that, but I’m not sure. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 16:26:49 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 21:26:49 +0000 Received: from localhost ([127.0.0.1]:53415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtyR-0003FX-Ew for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:26:49 -0500 Received: from quimby.gnus.org ([95.216.78.240]:37266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtyN-0003FH-Du for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 16:26:46 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXtyB-0004GZ-4g; Thu, 21 Nov 2019 22:26:33 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> Date: Thu, 21 Nov 2019 22:26:30 +0100 In-Reply-To: <87pnhmm9ui.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 21 Nov 2019 01:00:53 +0200") Message-ID: <87blt4x6nt.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > BTW, while testing it for image scaling on a quite small image file, > Emacs consumed several GB of all available memory and almost all swap, > before I noticed and evaluated M-: (clear-image-cache) [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: linkov.net] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > BTW, while testing it for image scaling on a quite small image file, > Emacs consumed several GB of all available memory and almost all swap, > before I noticed and evaluated M-: (clear-image-cache) that freed memory. > > Memory leak? No, it's just that Emacs' image cache is very primitive. You can easily get Emacs to go out-of-memory by just doing a (dolist (file (directory-files dir-with-lots-of-images)) (erase-buffer) (insert-image (create-image file))) You get the same effect by altering the scaling factor, I think? Each scaled image is cached? So by rolling the wheel ten clicks you get ten cached copies of the image. A better eviction algorithm would be nice. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:04:39 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 23:04:39 +0000 Received: from localhost ([127.0.0.1]:53500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvV9-0005nk-2C for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:39 -0500 Received: from azure.elm.relay.mailchannels.net ([23.83.212.7]:12082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvUl-0005lJ-Hq for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:16 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A09A21A0FE9; Thu, 21 Nov 2019 23:04:13 +0000 (UTC) Received: from pdx1-sub0-mail-a7.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 343451A1A5F; Thu, 21 Nov 2019 23:04:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a7.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:04:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Spicy-Shoe: 22a5a7e266f919e7_1574377453452_3015687287 X-MC-Loop-Signature: 1574377453452:3203240433 X-MC-Ingress-Time: 1574377453452 Received: from pdx1-sub0-mail-a7.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTP id E3AC182B08; Thu, 21 Nov 2019 15:04:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=qpCyvjr/FsWRnOkpJiglW7/CSGI=; b= MhZofAlupYbwJaSysLbJGLvW/y0AES8iD7lmIUHadqQzbtSp3IDQM0+sbF/a5Yuk 1X4QdZHbGjHR1Ox0e+yFVOijVXmvXWMkt+r+gID0Of5kQ/tLW/VcgVgSB7U9VVEg L07ikIdkQY+GV/lI2h0QDdrkPvKqyt1WgxLM20KWZro= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTPSA id 502D582B18; Thu, 21 Nov 2019 15:04:04 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a7 From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> <87h82ykur6.fsf@mail.linkov.net> <87o8x54eg9.fsf@gnus.org> <83zhgpxq68.fsf@gnu.org> Date: Fri, 22 Nov 2019 00:45:50 +0200 In-Reply-To: <83zhgpxq68.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Nov 2019 16:25:03 +0200") Message-ID: <87d0dkhmqp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Lars Ingebrigtsen , stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Does it help to bind redisplay-dont-pause to a nil value inside > image--change-size? I tried let-bind '(redisplay-dont-pause nil)' in image--change-size, compilation said Warning: `redisplay-dont-pause' is an obsolete variable (as of 24.5). but it still has no effect. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:04:48 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 23:04:48 +0000 Received: from localhost ([127.0.0.1]:53504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvVI-0005o5-3K for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:48 -0500 Received: from blue.elm.relay.mailchannels.net ([23.83.212.20]:55637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvUv-0005mn-3M for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:26 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 1DE04212C1; Thu, 21 Nov 2019 23:04:24 +0000 (UTC) Received: from pdx1-sub0-mail-a7.g.dreamhost.com (100-96-14-7.trex.outbound.svc.cluster.local [100.96.14.7]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 81D192139F; Thu, 21 Nov 2019 23:04:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a7.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:04:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Abortive-Glossy: 6d40393224abf361_1574377463814_1793945926 X-MC-Loop-Signature: 1574377463813:946049521 X-MC-Ingress-Time: 1574377463813 Received: from pdx1-sub0-mail-a7.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTP id 124CA82B0E; Thu, 21 Nov 2019 15:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=XBSbhPsSYecmez9XFPliONj5Uig=; b= i/9vAYJAsna5Tv4JHpHx3Hh0aavQocrACgT/2JwkLZ9vpsEYthKffNAkTASaTkx+ pJSy2aXX7ivUsgJdv8v9cIMVE0U690QH994REFE6bBTWtUmXar0JXa9iMPwTBTw/ nCPp4/sQ5Erd2RQybVgHyBK2CC6/F96VeepFu4slIB8= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTPSA id 1090D82ACF; Thu, 21 Nov 2019 15:04:12 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a7 From: Juri Linkov To: Alan Third Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <20191121211832.GB96045@breton.holly.idiocy.org> Date: Fri, 22 Nov 2019 00:51:22 +0200 In-Reply-To: <20191121211832.GB96045@breton.holly.idiocy.org> (Alan Third's message of "Thu, 21 Nov 2019 21:18:32 +0000") Message-ID: <871ru0hmhh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , stefan@marxist.se, larsi@gnus.org, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> BTW, while testing it for image scaling on a quite small image file, >> Emacs consumed several GB of all available memory and almost all swap, >> before I noticed and evaluated M-: (clear-image-cache) that freed memory. >> >> Memory leak? > > Was this on X? Yes, on X. > Emacs probably keeps a copy of the image in memory for each size until > the image cache is cleared or pruned. Could it clear the image cache automatically when it grows over some memory limit? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:05:05 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 23:05:05 +0000 Received: from localhost ([127.0.0.1]:53510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvVX-0005oy-CF for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:05:05 -0500 Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:61548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvV1-0005nJ-2B for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 18:04:31 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 2B574341E58; Thu, 21 Nov 2019 23:04:30 +0000 (UTC) Received: from pdx1-sub0-mail-a7.g.dreamhost.com (100-96-15-77.trex.outbound.svc.cluster.local [100.96.15.77]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B1E31341DBF; Thu, 21 Nov 2019 23:04:29 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a7.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Thu, 21 Nov 2019 23:04:30 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Robust-Eight: 5faf002f5f98a177_1574377469968_457833585 X-MC-Loop-Signature: 1574377469968:703054992 X-MC-Ingress-Time: 1574377469968 Received: from pdx1-sub0-mail-a7.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTP id D494382ACF; Thu, 21 Nov 2019 15:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=OFMZvvQAijLNJ0K6HzdKDWB53+8=; b= WaZXClhGtMLHNPkwgxxK0juCWYTqDIodeJ/ziM2oNTCxHr3monsrdEqluPEsh9wQ 14t+NkKnFc0l1g4GNgJAikuQXbH9LYz2U2h+49IDRhcXlRT1DBhNBWWZY0FhAJg9 gh7xWt1M83sTlnEtm8VqXepu8a2uPwCRWytaHLgX9Os= Received: from mail.jurta.org (m91-129-102-1.cust.tele2.ee [91.129.102.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a7.g.dreamhost.com (Postfix) with ESMTPSA id 755CE82B08; Thu, 21 Nov 2019 15:04:22 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a7 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> Date: Fri, 22 Nov 2019 00:57:24 +0200 In-Reply-To: <87blt4x6nt.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 21 Nov 2019 22:26:30 +0100") Message-ID: <87a78og7mz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> BTW, while testing it for image scaling on a quite small image file, >> Emacs consumed several GB of all available memory and almost all swap, >> before I noticed and evaluated M-: (clear-image-cache) that freed memory. >> >> Memory leak? > > No, it's just that Emacs' image cache is very primitive. You can easily > get Emacs to go out-of-memory by just doing a > > (dolist (file (directory-files dir-with-lots-of-images)) > (erase-buffer) > (insert-image (create-image file))) > > You get the same effect by altering the scaling factor, I think? Each > scaled image is cached? So by rolling the wheel ten clicks you get ten > cached copies of the image. > > A better eviction algorithm would be nice. Currently the default value of image-cache-eviction-delay is 300 seconds. But the documentation also says: "If the cache contains a large number of images, the actual eviction time may be shorter." And code has this comment: /* If the number of cached images has grown unusually large, decrease the cache eviction delay (Bug#6230). */ Does this mean the number of cached images was not large enough? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 18:11:12 2019 Received: (at 38187) by debbugs.gnu.org; 21 Nov 2019 23:11:12 +0000 Received: from localhost ([127.0.0.1]:53530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvbO-0005zK-Jd for submit@debbugs.gnu.org; Thu, 21 Nov 2019 18:11:07 -0500 Received: from quimby.gnus.org ([95.216.78.240]:38668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXvbJ-0005yk-0x for 38187@debbugs.gnu.org; Thu, 21 Nov 2019 18:11:01 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iXvb7-0005GX-Os; Fri, 22 Nov 2019 00:10:52 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <87a78og7mz.fsf@mail.linkov.net> Date: Fri, 22 Nov 2019 00:10:48 +0100 In-Reply-To: <87a78og7mz.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 22 Nov 2019 00:57:24 +0200") Message-ID: <87blt4vn9j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > /* If the number of cached images has grown unusually large, > decrease the cache eviction delay (Bug#6230). */ > > Does this mean the number of cached images was not large enough? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > /* If the number of cached images has grown unusually large, > decrease the cache eviction delay (Bug#6230). */ > > Does this mean the number of cached images was not large enough? I've successfully (ahem) made Linux kill Emacs by looping over images (out of memory killer), so I don't think whatever it does is well-tuned. I haven't looked at the code now, but doesn't it just count images/time and not take image size into account? I may be misremembering. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:31:38 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 07:31:39 +0000 Received: from localhost ([127.0.0.1]:53662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3Pk-00068p-Vb for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:31:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3Pg-00068X-MI for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 02:31:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3Pa-0006eH-SN; Fri, 22 Nov 2019 02:31:26 -0500 Received: from [176.228.60.248] (port=2614 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3PZ-0006jz-Kh; Fri, 22 Nov 2019 02:31:26 -0500 Date: Fri, 22 Nov 2019 09:31:40 +0200 Message-Id: <83y2w8wen7.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87blt4x6nt.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 21 Nov 2019 22:26:30 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org > Date: Thu, 21 Nov 2019 22:26:30 +0100 > > (dolist (file (directory-files dir-with-lots-of-images)) > (erase-buffer) > (insert-image (create-image file))) > > You get the same effect by altering the scaling factor, I think? Each > scaled image is cached? So by rolling the wheel ten clicks you get ten > cached copies of the image. Again, does binding redisplay-dont-pause to nil help in any way here? > A better eviction algorithm would be nice. Such an algorithm would need to detect these "useless" cached images to be effective. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:47:15 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 07:47:15 +0000 Received: from localhost ([127.0.0.1]:53676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3eq-0006V2-Rl for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:47:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3en-0006Up-HQ for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 02:47:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3eh-0002CX-8j; Fri, 22 Nov 2019 02:47:03 -0500 Received: from [176.228.60.248] (port=3569 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3eg-0003ER-7s; Fri, 22 Nov 2019 02:47:03 -0500 Date: Fri, 22 Nov 2019 09:47:15 +0200 Message-Id: <83sgmgwdx8.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <871ru0hmhh.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 22 Nov 2019 00:51:22 +0200) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <20191121211832.GB96045@breton.holly.idiocy.org> <871ru0hmhh.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: alan@idiocy.org, stefan@marxist.se, larsi@gnus.org, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , larsi@gnus.org, stefan@marxist.se, > 38187@debbugs.gnu.org > Date: Fri, 22 Nov 2019 00:51:22 +0200 > > > Emacs probably keeps a copy of the image in memory for each size until > > the image cache is cleared or pruned. > > Could it clear the image cache automatically when it grows > over some memory limit? How would you do that without knowing what each image is used for and whether it is still on display? I don't think we can make the image cache smarter about eviction without adding more information about each cached image. So it isn't just about tuning the current constants or counting the bytes. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:51:31 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 07:51:31 +0000 Received: from localhost ([127.0.0.1]:53687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3iy-0006bV-Bc for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:51:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3iv-0006bH-I9 for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 02:51:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3iq-0003jg-Bs; Fri, 22 Nov 2019 02:51:20 -0500 Received: from [176.228.60.248] (port=3832 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3ip-0003WD-HS; Fri, 22 Nov 2019 02:51:19 -0500 Date: Fri, 22 Nov 2019 09:51:34 +0200 Message-Id: <83pnhkwdq1.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-reply-to: <87a78og7mz.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 22 Nov 2019 00:57:24 +0200) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <87a78og7mz.fsf@mail.linkov.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org > Date: Fri, 22 Nov 2019 00:57:24 +0200 > > Currently the default value of image-cache-eviction-delay is > 300 seconds. > > But the documentation also says: > > "If the cache contains a large number of images, > the actual eviction time may be shorter." > > And code has this comment: > > /* If the number of cached images has grown unusually large, > decrease the cache eviction delay (Bug#6230). */ > > Does this mean the number of cached images was not large enough? Maybe. the only way to answer that is to run the recipe under a debugger with a breakpoint at that place, and have the breakpoint print the number of images in the cache. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:58:17 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 07:58:17 +0000 Received: from localhost ([127.0.0.1]:53694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3pZ-0006kx-AG for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:58:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3pX-0006kk-Kj for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 02:58:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3pS-0007HC-6c; Fri, 22 Nov 2019 02:58:10 -0500 Received: from [176.228.60.248] (port=4244 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3pR-0006rG-0x; Fri, 22 Nov 2019 02:58:09 -0500 Date: Fri, 22 Nov 2019 09:58:22 +0200 Message-Id: <83o8x4wdep.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87blt4vn9j.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 22 Nov 2019 00:10:48 +0100) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <87a78og7mz.fsf@mail.linkov.net> <87blt4vn9j.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , stefan@marxist.se, 38187@debbugs.gnu.org > Date: Fri, 22 Nov 2019 00:10:48 +0100 > > Juri Linkov writes: > > > /* If the number of cached images has grown unusually large, > > decrease the cache eviction delay (Bug#6230). */ > > > > Does this mean the number of cached images was not large enough? > > I've successfully (ahem) made Linux kill Emacs by looping over images > (out of memory killer), so I don't think whatever it does is well-tuned. > I haven't looked at the code now, but doesn't it just count images/time > and not take image size into account? I may be misremembering. You are misremembering. The code counts _redisplay_ cycles, and clears the image cache when that exceeds 101. Any additional cache clearing can only come from Lisp that calls clear-image-cache explicitly. What exactly clearing the cache does depends on the value of image-cache-eviction-delay and on how many images are in the frame's image cache. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 04:50:19 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 09:50:19 +0000 Received: from localhost ([127.0.0.1]:53782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5Zz-0000yb-Br for submit@debbugs.gnu.org; Fri, 22 Nov 2019 04:50:19 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:32916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5Zx-0000yL-AV for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 04:50:18 -0500 Received: by mail-wr1-f52.google.com with SMTP id w9so7873727wrr.0 for <38187@debbugs.gnu.org>; Fri, 22 Nov 2019 01:50:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=G0DnQhDX/9GgZ1p9C1bvtrQpSKrI8CEnRllodc/WNqU=; b=hk+1RxrC86V3k/J9spvae5x2i8qL3VmWAzIh2Gddg2POofOHK/y1yZ3Rn+5Z7GisHL FNXuCMOl7xMI0uk+qXTMIusds1QjViF+blnkSKpbPnJJCtGjwQy9TKh/BYXumRxNBmt6 iPC6Tx2YhPiq5FC32CIbSvmFaw76U5/l+j7D9WxOLxWuGVDJ7Ef93v+uuxKv+/GgmGb4 TLTpQqnh5uRB4wEXPxuHDfgnGRhXM9NAvvGU66hMRyBc7RFBlLG4Nmk0EHb4Td1/YBlv ZbPGKTmCHaFRYfFFd3tFCdxsQs/uN8uvA+hicmTcvFo/keJB8QAfrfJ93jIqY6vonlAE vuyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=G0DnQhDX/9GgZ1p9C1bvtrQpSKrI8CEnRllodc/WNqU=; b=KFL/KJn4zBEnji9udcgwTjojeuzH4Z3q2HiW0sa2qGAhR8l/xcn0C3JmKkREvrFudJ cVHjoYWVAIvz0VPhf0NOKqAr6bQPJck83d5mOJm1GDFVZKTvzvHRfOhia3GHw32RsF2b DgbCirOJB73+JwCw6LBDK4hAKJ8uGVcR+5TSconf4b7JuxsI11VpLnsbJLK8X01xN3Yf K/3YgkQD6alcafF0bvga2OSzn+OSFE7WEqkQbqlksFpaGD69pu6Wx/4WmejTx7iG4a2o TupEYuOqFcGMuCsajAwjBHxpKfGOP2kj9qM2AnjlnXraDh3VASZV1pfaKjiUkmegzlML IbKQ== X-Gm-Message-State: APjAAAWl7bww6A3tjzSnTwmW1q2jA9ewjAyAtRnL8SOoy9MvtxwRdq0X k/BoPPZ3GvJVWgs9HMfP/aM= X-Google-Smtp-Source: APXvYqxXJ41Af4QhMKCOwj1jrtroGQGVoza4R59NotGrpZBXKmgg5gaM9jbitow/uReOXGau381SxQ== X-Received: by 2002:adf:9786:: with SMTP id s6mr17168630wrb.188.1574416211170; Fri, 22 Nov 2019 01:50:11 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1980-cc6a-4f4e-9c42.holly.idiocy.org. [2001:8b0:3f8:8129:1980:cc6a:4f4e:9c42]) by smtp.gmail.com with ESMTPSA id t13sm1139820wrp.36.2019.11.22.01.50.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 01:50:10 -0800 (PST) Date: Fri, 22 Nov 2019 09:50:08 +0000 From: Alan Third To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Message-ID: <20191122095008.GA96578@breton.holly.idiocy.org> References: <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87blt4x6nt.fsf@gnus.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, stefan@marxist.se, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Nov 21, 2019 at 10:26:30PM +0100, Lars Ingebrigtsen wrote: > > You get the same effect by altering the scaling factor, I think? Each > scaled image is cached? So by rolling the wheel ten clicks you get ten > cached copies of the image. > > A better eviction algorithm would be nice. It would be nice if Emacs was able to reuse the actual image data where the only difference is scaling or rotation. A simple ‘solution’ to the mousewheel scaling issue would be to explicitly flush the old image from the cache on each change. I think that’s what image mode does when you zoom. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 05:04:45 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 10:04:45 +0000 Received: from localhost ([127.0.0.1]:53802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5nw-0003IL-LH for submit@debbugs.gnu.org; Fri, 22 Nov 2019 05:04:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY5nt-0003I4-67 for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 05:04:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY5nn-0007uX-Ad; Fri, 22 Nov 2019 05:04:35 -0500 Received: from [176.228.60.248] (port=4042 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY5nm-0002c5-Bl; Fri, 22 Nov 2019 05:04:34 -0500 Date: Fri, 22 Nov 2019 12:04:49 +0200 Message-Id: <83a78ow7jy.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-reply-to: <20191122095008.GA96578@breton.holly.idiocy.org> (message from Alan Third on Fri, 22 Nov 2019 09:50:08 +0000) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <20191122095008.GA96578@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 22 Nov 2019 09:50:08 +0000 > From: Alan Third > Cc: 38187@debbugs.gnu.org, stefan@marxist.se, Juri Linkov > > It would be nice if Emacs was able to reuse the actual image data > where the only difference is scaling or rotation. I think we found that too complicated at the time. > A simple ‘solution’ to the mousewheel scaling issue would be to > explicitly flush the old image from the cache on each change. I think > that’s what image mode does when you zoom. image-mode can do that when it knows the scaled image will replace the previous one, yes. (We will need to add an API for that, I think.) But that's not cache eviction, that's application being smarter about the "garbage" it produces. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 05:33:16 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 10:33:16 +0000 Received: from localhost ([127.0.0.1]:53813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6FU-0003xe-NQ for submit@debbugs.gnu.org; Fri, 22 Nov 2019 05:33:16 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:36980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY6FS-0003xR-T2 for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 05:33:11 -0500 Received: by mail-wm1-f44.google.com with SMTP id f129so5642062wmf.2 for <38187@debbugs.gnu.org>; Fri, 22 Nov 2019 02:33:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=U7H5YYkzu/QH3GcPOBbIVJpmI7XQVwtOKu/iIJSbq8s=; b=AT8ZgBXLBc4Yx9LhjVEesq6Sn+nfxNMt6D7sm0zpGBbsptPxoXg9DoJqKc4DNej2jx T6HqLAPP8eIvY6oyAnxxoKFFeP7BOHqg5+iFcKt/mQNuotnqj+AtvaOyKB2Z0IpxxBTl w4QxQ7YGWlElziB2UssQgA+UgKUzLpF5mBwesXSZuXvuhD8Xrjjy9k7tnQa95Z3xy0Bl 60nOviw99yha48Si72MNCizsFVrHidfJeM0TsBqeWs9S2LlmMv40qSJfgdpcZJ6JSO48 NJQRYhit6ptGCQe4grIMjwxCqFjGzOjq9BV7x1eCbLzWrOCbEyM053QkyfuESHGHUEz1 wjvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=U7H5YYkzu/QH3GcPOBbIVJpmI7XQVwtOKu/iIJSbq8s=; b=N0yTPf8IWa+lCkJofSID3hH2nviUNOqPRNddCMf02Jn75q3aZtKZHny2a9U2qyba3B W2D02L9OmoYjaDJ4x/Acg5XFqEbgRY2kL0rBIesTBWRx6r9t3n7eGbD1CUMcRESy39yD mQ18/AbltU7oQRV4EVMkRoMl5Uug8+ERtGKyDDfOBQTCLLczjLD6tbjccVD1Nsvbs4x8 8W98w86n/9EdRVkhyTNclHOYpmDOWf0U76g+KVB8ZCh8Qp1V/MMUIWvBh1G1IvYjLE/K FqRThLV81N83/EVOzYUZ3H6HofqkK1PtT6r9Znjo54Qxt8kkfxiE+3LRHOd2Ao1rCWFj OmEQ== X-Gm-Message-State: APjAAAWhYFWx9hLe1hui8KDavPNsC2M0epYEWp4j4VxhrnP+avfqZIL4 t07n+viCxANC7PZKI23Upcg= X-Google-Smtp-Source: APXvYqy/zz1eb+pH4A6NqkVqHCN2Gb5dEUI0RHGUH1ypIR7LUS9GY6FBl1424atDriarhU+/fYQ7Jg== X-Received: by 2002:a1c:3b08:: with SMTP id i8mr15285771wma.56.1574418784653; Fri, 22 Nov 2019 02:33:04 -0800 (PST) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1980-cc6a-4f4e-9c42.holly.idiocy.org. [2001:8b0:3f8:8129:1980:cc6a:4f4e:9c42]) by smtp.gmail.com with ESMTPSA id d16sm5402906wrg.27.2019.11.22.02.33.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2019 02:33:03 -0800 (PST) Date: Fri, 22 Nov 2019 10:33:00 +0000 From: Alan Third To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Message-ID: <20191122103300.GA4888@breton.holly.idiocy.org> References: <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <20191122095008.GA96578@breton.holly.idiocy.org> <83a78ow7jy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83a78ow7jy.fsf@gnu.org> User-Agent: Mutt/1.12.0 (2019-05-25) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, Nov 22, 2019 at 12:04:49PM +0200, Eli Zaretskii wrote: > > Date: Fri, 22 Nov 2019 09:50:08 +0000 > > From: Alan Third > > Cc: 38187@debbugs.gnu.org, stefan@marxist.se, Juri Linkov > > > > It would be nice if Emacs was able to reuse the actual image data > > where the only difference is scaling or rotation. > > I think we found that too complicated at the time. Yes, and I’m not sure the pay‐off would be worth it as it really only makes a big difference in situations like these where an image is being scaled repeatedly. But we can consider it a wishlist item. ;) > > A simple ‘solution’ to the mousewheel scaling issue would be to > > explicitly flush the old image from the cache on each change. I think > > that’s what image mode does when you zoom. > > image-mode can do that when it knows the scaled image will replace the > previous one, yes. (We will need to add an API for that, I think.) > But that's not cache eviction, that's application being smarter about > the "garbage" it produces. Actually, now I look at the code, when an image is resized using the mousewheel the previous image should already be flushed. In image.el we have this function: (defun image--get-imagemagick-and-warn () (unless (or (fboundp 'imagemagick-types) (image-transforms-p)) (error "Cannot rescale images on this terminal")) (let ((image (image--get-image))) (image-flush image) ;;; <<--------------- (when (and (fboundp 'imagemagick-types) (not (image-transforms-p))) (plist-put (cdr image) :type 'imagemagick)) image)) which is called every time an image is resized. So perhaps I misunderstand what image-flush does, or we do have a memory leak? -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 07:42:18 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 12:42:18 +0000 Received: from localhost ([127.0.0.1]:53905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8GN-0002YM-Pe for submit@debbugs.gnu.org; Fri, 22 Nov 2019 07:42:17 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8GG-0002Y2-QZ for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 07:42:11 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iY8G7-00032w-M9; Fri, 22 Nov 2019 13:42:02 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <83y2w8wen7.fsf@gnu.org> Date: Fri, 22 Nov 2019 13:41:58 +0100 In-Reply-To: <83y2w8wen7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 22 Nov 2019 09:31:40 +0200") Message-ID: <87o8x4rskp.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Again, does binding redisplay-dont-pause to nil help in any way here? I haven't tested. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: 38187@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Again, does binding redisplay-dont-pause to nil help in any way here? I haven't tested. >> A better eviction algorithm would be nice. > > Such an algorithm would need to detect these "useless" cached images > to be effective. Yup. If there's no reference to the image, that should be communicated back to the image cache, which would require some support from the garbage collection somehow. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 08:26:41 2019 Received: (at 38187) by debbugs.gnu.org; 22 Nov 2019 13:26:41 +0000 Received: from localhost ([127.0.0.1]:53945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8xI-0005ai-2Z for submit@debbugs.gnu.org; Fri, 22 Nov 2019 08:26:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY8xF-0005aV-Tl for 38187@debbugs.gnu.org; Fri, 22 Nov 2019 08:26:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY8x9-0007bb-V5; Fri, 22 Nov 2019 08:26:27 -0500 Received: from [176.228.60.248] (port=4584 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY8x8-0002j3-Uh; Fri, 22 Nov 2019 08:26:27 -0500 Date: Fri, 22 Nov 2019 15:26:42 +0200 Message-Id: <8336egvy7h.fsf@gnu.org> From: Eli Zaretskii To: Alan Third In-reply-to: <20191122103300.GA4888@breton.holly.idiocy.org> (message from Alan Third on Fri, 22 Nov 2019 10:33:00 +0000) Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <83ftik35kw.fsf@gnu.org> <87pnhmm9ui.fsf@mail.linkov.net> <87blt4x6nt.fsf@gnus.org> <20191122095008.GA96578@breton.holly.idiocy.org> <83a78ow7jy.fsf@gnu.org> <20191122103300.GA4888@breton.holly.idiocy.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 38187 Cc: larsi@gnus.org, stefan@marxist.se, 38187@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Date: Fri, 22 Nov 2019 10:33:00 +0000 > From: Alan Third > Cc: larsi@gnus.org, 38187@debbugs.gnu.org, stefan@marxist.se, > juri@linkov.net > > > > A simple ‘solution’ to the mousewheel scaling issue would be to > > > explicitly flush the old image from the cache on each change. I think > > > that’s what image mode does when you zoom. > > > > image-mode can do that when it knows the scaled image will replace the > > previous one, yes. (We will need to add an API for that, I think.) > > But that's not cache eviction, that's application being smarter about > > the "garbage" it produces. > > Actually, now I look at the code, when an image is resized using the > mousewheel the previous image should already be flushed. > > In image.el we have this function: > > (defun image--get-imagemagick-and-warn () > (unless (or (fboundp 'imagemagick-types) (image-transforms-p)) > (error "Cannot rescale images on this terminal")) > (let ((image (image--get-image))) > (image-flush image) ;;; <<--------------- > (when (and (fboundp 'imagemagick-types) > (not (image-transforms-p))) > (plist-put (cdr image) :type 'imagemagick)) > image)) > > which is called every time an image is resized. So perhaps I > misunderstand what image-flush does, or we do have a memory leak? Strange indeed. I suggest to step in a debugger through this and other relevant code in this scenario, and see what happens there. I'd be surprised to know that we have a memory leak in this area. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 17:24:26 2019 Received: (at 38187) by debbugs.gnu.org; 23 Nov 2019 22:24:26 +0000 Received: from localhost ([127.0.0.1]:57929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYdpH-0006Fq-EE for submit@debbugs.gnu.org; Sat, 23 Nov 2019 17:24:24 -0500 Received: from eastern.birch.relay.mailchannels.net ([23.83.209.55]:38504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iYdp9-0006FK-7q for 38187@debbugs.gnu.org; Sat, 23 Nov 2019 17:24:16 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 30053500B05; Sat, 23 Nov 2019 22:24:14 +0000 (UTC) Received: from pdx1-sub0-mail-a34.g.dreamhost.com (100-96-6-199.trex.outbound.svc.cluster.local [100.96.6.199]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 82B9C500A3C; Sat, 23 Nov 2019 22:24:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a34.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Sat, 23 Nov 2019 22:24:13 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Army-Suffer: 6c83074b7243eaf5_1574547853772_3285214905 X-MC-Loop-Signature: 1574547853772:3380189217 X-MC-Ingress-Time: 1574547853771 Received: from pdx1-sub0-mail-a34.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a34.g.dreamhost.com (Postfix) with ESMTP id 8285584069; Sat, 23 Nov 2019 14:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=cydSZEskiySFvWSLmDcoeXk+O58=; b= qAjI1dJPJOxktzpLaNcp7XAGwyCujU7tlDpydrH+ma0O9oM9cdl76vwyISSOdd7g k7czeTLd7z65VNWTJcdCIZXFf4VvIY0SdY8kzSI7xlBEzHXmyKPb1w+op377Bw9B CItzUB1Rzrg6WGBeulbyfUuOLYJ3+10nGeO8RW+tO+c= Received: from mail.jurta.org (m91-129-105-73.cust.tele2.ee [91.129.105.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a34.g.dreamhost.com (Postfix) with ESMTPSA id 63DE084068; Sat, 23 Nov 2019 14:24:09 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a34 From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images Organization: LINKOV.NET References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> <87h82ykur6.fsf@mail.linkov.net> <87o8x54eg9.fsf@gnus.org> Date: Sun, 24 Nov 2019 00:23:05 +0200 In-Reply-To: <87o8x54eg9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 21 Nov 2019 13:11:02 +0100") Message-ID: <877e3q5j1y.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I noticed that using the mouse-wheel on images is not responsive enough. >> It takes too much time when every step of the mouse scrolling wheel >> needs to scale the image separately for every consecutive rescaling. > > Yeah, users are more likely to issue a bunch of scroll wheel events > rapidly than hitting `+' at the same rate, I guess. > >> So I experimented with debouncing - a new macro 'debounce' swallows >> all intermediate calls in quick succession to 'image--change-size', >> and executes only the last call in sequence. >> >> But actually it requires another better macro 'debounce-reduce' >> that accumulates the state from all calls by multiplying all >> intermediate scaling factors, and using the result on the final call: > > Makes sense to me. This is installed now. Not sure if this report can be closed, since the discussion on image memory caching moved to bug#38345. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 06:58:37 2019 Received: (at 38187) by debbugs.gnu.org; 27 Nov 2019 11:58:38 +0000 Received: from localhost ([127.0.0.1]:53533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvxt-00078Z-NI for submit@debbugs.gnu.org; Wed, 27 Nov 2019 06:58:37 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvxr-00078H-Ip for 38187@debbugs.gnu.org; Wed, 27 Nov 2019 06:58:35 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZvxi-0001HL-A5; Wed, 27 Nov 2019 12:58:28 +0100 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#38187: 27.0.50; No mouse-wheel scaling on images References: <87tv79ksuz.fsf@mail.linkov.net> <83zhgy62u8.fsf@gnu.org> <87y2we7r90.fsf@gnus.org> <83lfse5w04.fsf@gnu.org> <87a78u7ags.fsf@gnus.org> <878soemc79.fsf@marxist.se> <87mucut8ch.fsf@mail.linkov.net> <87ftilsg6q.fsf@gnus.org> <87r224sw6s.fsf@mail.linkov.net> <87zhgsnv7x.fsf@gnus.org> <87h82ykur6.fsf@mail.linkov.net> <87o8x54eg9.fsf@gnus.org> <877e3q5j1y.fsf@mail.linkov.net> Date: Wed, 27 Nov 2019 12:58:25 +0100 In-Reply-To: <877e3q5j1y.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 24 Nov 2019 00:23:05 +0200") Message-ID: <87blsxfs4e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > Not sure if this report can be closed, since the discussion > on image memory caching moved to bug#38345. Yeah, I think we can close this one (and I'm now doing so). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38187 Cc: Eli Zaretskii , Stefan Kangas , 38187@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: > Not sure if this report can be closed, since the discussion > on image memory caching moved to bug#38345. Yeah, I think we can close this one (and I'm now doing so). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 06:58:51 2019 Received: (at control) by debbugs.gnu.org; 27 Nov 2019 11:58:51 +0000 Received: from localhost ([127.0.0.1]:53536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvy6-000795-UN for submit@debbugs.gnu.org; Wed, 27 Nov 2019 06:58:51 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZvy4-00078q-Of for control@debbugs.gnu.org; Wed, 27 Nov 2019 06:58:49 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iZvxx-0001HU-5B for control@debbugs.gnu.org; Wed, 27 Nov 2019 12:58:43 +0100 Date: Wed, 27 Nov 2019 12:58:40 +0100 Message-Id: <87a78hfs3z.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38187 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 38187 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 38187 27.1 quit From unknown Mon Aug 18 06:57:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Dec 2019 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator