From unknown Mon Aug 18 04:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38170: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2019 10:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 38170@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15734687771669 (code B ref -1); Mon, 11 Nov 2019 10:40:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2019 10:39:37 +0000 Received: from localhost ([127.0.0.1]:53170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU76f-0000Qq-89 for submit@debbugs.gnu.org; Mon, 11 Nov 2019 05:39:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:48051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU76c-0000Qg-4t for submit@debbugs.gnu.org; Mon, 11 Nov 2019 05:39:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50707) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iU76a-0001OY-81 for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 05:39:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPOOFED_FREEMAIL,URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iU76W-0003yU-5z for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 05:39:29 -0500 Received: from mail-m974.mail.163.com ([123.126.97.4]:57460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iU76U-0003tU-Qu for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2019 05:39:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:Message-ID:From:Subject:MIME-Version; bh=yuXND E6mRkmp0AnZaNv7ObdIaPI3bhs5Usn0bIlM/uc=; b=EkB+2kzZBTnckzg5PGte5 R71EcBgs4BsQVzN0eshDqOFsglgsbAjd3T7MlIehG27s1XvgXPX0rfLxZur67FnU bmU9SDg0LKc4aMk8lsxjFNWdBfApelrDYvDTGKndPrZj9b+0VrKeynLhxdtQb6tC PIWwE/iap5uEwdmdnaBPRY= Received: from archlinux.163.com (unknown [112.93.132.216]) by smtp4 (Coremail) with SMTP id HNxpCgBHj5PNNsldVlziAA--.4S2; Mon, 11 Nov 2019 18:24:16 +0800 (CST) Date: Mon, 11 Nov 2019 18:24:10 +0800 Message-ID: <87eeyed839.wl-all_but_last@163.com> From: Zhu Zihao User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Face: :]]%@R1{oDt0%iKgI@Kga#OZ; ogt+%OOne&J4#E*O,TIlI)yEFw--I\:3s~EV97GI$1.1!}8inmF9UgtUBB@#8>'8NWNC8qg/v*OLfQB; Z:@G3HeNf3u& ,&HpBGv%?p{bzsl'|5T";1&X MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Mon_Nov_11_18:24:10_2019-1" X-CM-TRANSID: HNxpCgBHj5PNNsldVlziAA--.4S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUcS_MUUUUU X-Originating-IP: [112.93.132.216] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiKRBqr1Xlt7XAKQAAsn X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 123.126.97.4 X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --Multipart_Mon_Nov_11_18:24:10_2019-1 Content-Type: text/plain; charset=US-ASCII New rx implementation introduce some bug: 1. (rx char) throw an error "Unknown rx symbol char" 2. (rx (char ?A ?B)) return a regexp match A or B. This patch aims to fix this. --Multipart_Mon_Nov_11_18:24:10_2019-1 Content-Type: text/plain; type=patch; name="0001-rx.el-Fix-misplaced-char-identifiers.patch"; charset=US-ASCII Content-Disposition: attachment; filename="0001-rx.el-Fix-misplaced-char-identifiers.patch" Content-Transfer-Encoding: 7bit >From 1b5d28b8b2bcbf91ad32991d3602de45ef9bef76 Mon Sep 17 00:00:00 2001 From: Zhu Zihao To: bug-gnu-emacs@gnu.org Date: Sun, 10 Nov 2019 20:02:44 +0800 Subject: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. --- lisp/emacs-lisp/rx.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/rx.el b/lisp/emacs-lisp/rx.el index 52a35ffa2a7..c5f341a7b0a 100644 --- a/lisp/emacs-lisp/rx.el +++ b/lisp/emacs-lisp/rx.el @@ -153,7 +153,7 @@ rx--translate-symbol (pcase sym ;; Use `list' instead of a quoted list to wrap the strings here, ;; since the return value may be mutated. - ((or 'nonl 'not-newline 'any) (cons (list ".") t)) + ((or 'nonl 'not-newline 'any 'char) (cons (list ".") t)) ((or 'anychar 'anything) (cons (list "[^z-a]") t)) ('unmatchable (rx--empty)) ((or 'bol 'line-start) (cons (list "^") 'lseq)) @@ -857,7 +857,7 @@ rx--translate-form (pcase (car form) ((or 'seq : 'and 'sequence) (rx--translate-seq body)) ((or 'or '|) (rx--translate-or body)) - ((or 'any 'in 'char) (rx--translate-any nil body)) + ((or 'any 'in) (rx--translate-any nil body)) ('not-char (rx--translate-any t body)) ('not (rx--translate-not nil body)) -- 2.24.0 --Multipart_Mon_Nov_11_18:24:10_2019-1-- From unknown Mon Aug 18 04:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38170: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. References: <87eeyed839.wl-all_but_last@163.com> In-Reply-To: <87eeyed839.wl-all_but_last@163.com> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2019 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 38170@debbugs.gnu.org Cc: Zhu Zihao Received: via spool by 38170-submit@debbugs.gnu.org id=B38170.157347945126672 (code B ref 38170); Mon, 11 Nov 2019 13:38:02 +0000 Received: (at 38170) by debbugs.gnu.org; 11 Nov 2019 13:37:31 +0000 Received: from localhost ([127.0.0.1]:53306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU9sp-0006w8-8r for submit@debbugs.gnu.org; Mon, 11 Nov 2019 08:37:31 -0500 Received: from mail1446c50.megamailservers.eu ([91.136.14.46]:41526 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU9sn-0006vu-L5 for 38170@debbugs.gnu.org; Mon, 11 Nov 2019 08:37:30 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1573479432; bh=llbV5sEJJGCJ4i9pQ+3ws6F7bZbkXxm3lBbh0mkX22s=; h=From:Subject:Date:Cc:To:From; b=d0WY6OVjYSMHZZLd+sEG8GuktnMmIgeWrayH3kEaRgMAsDQl3M0Z99CUfR0xVmpmI oU6Sp4cogYfF1tzTg54kWOa1goGAAgjh0zXl3ZrulwP6XQVtGinpM9WWRY8/rUtMLf CZ/ZiCxVUMjHzzuRD8rTZgf74wqGoUA+rhrBUcao= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-ee54e353.032-75-73746f71.bbcust.telenor.se [83.227.84.238]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xABDb9V5012768; Mon, 11 Nov 2019 13:37:11 +0000 From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: <5BE752A4-367E-4095-9365-174D73DB9DFF@acm.org> Date: Mon, 11 Nov 2019 14:37:09 +0100 X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0209.5DC96408.0025, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=YIzhNiOx c=1 sm=1 tr=0 a=Fmb7hdz85/yTNbhpOvpRKA==:117 a=Fmb7hdz85/yTNbhpOvpRKA==:17 a=kj9zAlcOel0A:10 a=XI0WW8Tv_1QA:10 a=M51BFTxLslgA:10 a=HvTf8JGps6DW5Fr972YA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=n87TN5wuljxrRezIQYnT:22 X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thanks for the report! However, there may be a misunderstanding: (char ...) as an alias for (any ...) was a documented feature of the old implementation and was therefore preserved in the re-write; it cannot be removed without a very good justification. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: megamailservers.eu] 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks for the report! However, there may be a misunderstanding: (char ...) as an alias for (any ...) was a documented feature of the old = implementation and was therefore preserved in the re-write; it cannot be = removed without a very good justification. 'char' as an alias for 'not-newline' was never documented in the first = place and because of the rather intuitive meaning, it was considered to = be an implementation accident and therefore not included. Therefore I'd rather not apply the proposed changes. From unknown Mon Aug 18 04:47:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#38170: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2019 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38170 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 38170@debbugs.gnu.org, Zhu Zihao Received: via spool by 38170-submit@debbugs.gnu.org id=B38170.157348052228297 (code B ref 38170); Mon, 11 Nov 2019 13:56:02 +0000 Received: (at 38170) by debbugs.gnu.org; 11 Nov 2019 13:55:22 +0000 Received: from localhost ([127.0.0.1]:53321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUAA6-0007ML-CG for submit@debbugs.gnu.org; Mon, 11 Nov 2019 08:55:22 -0500 Received: from mail-m971.mail.163.com ([123.126.97.1]:54428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUAA1-0007M2-Gp for 38170@debbugs.gnu.org; Mon, 11 Nov 2019 08:55:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:Message-ID:From:Subject:MIME-Version; bh=sfZNV z7SeoWVugxcNU4GKTe84SyT/t5Jd8SlAjyeHMQ=; b=nbR2+tJyYXKGJ7X9xaGsn diV3ENXQ0/D0ParRsW+friBW185wmi0v5gpGgNYkPr3/nTuIMmWPfWNMZjHdbvbP LIX9fw6nd/VnyJdhpfHzGOow6J1OakrNw0PxJ84TaNscSmqwZXRh8W4pjYD6KY5e ZddHO/QeYcOUCwGYjGXHh8= Received: from archlinux.163.com (unknown [112.93.132.216]) by smtp1 (Coremail) with SMTP id GdxpCgA3d1Y1aMld5WUuAQ--.167S2; Mon, 11 Nov 2019 21:55:04 +0800 (CST) Date: Mon, 11 Nov 2019 21:54:58 +0800 Message-ID: <87woc68qml.wl-all_but_last@163.com> From: Zhu Zihao In-Reply-To: <5BE752A4-367E-4095-9365-174D73DB9DFF@acm.org> References: <5BE752A4-367E-4095-9365-174D73DB9DFF@acm.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-Face: :]]%@R1{oDt0%iKgI@Kga#OZ; ogt+%OOne&J4#E*O,TIlI)yEFw--I\:3s~EV97GI$1.1!}8inmF9UgtUBB@#8>'8NWNC8qg/v*OLfQB; Z:@G3HeNf3u& ,&HpBGv%?p{bzsl'|5T";1&X MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: GdxpCgA3d1Y1aMld5WUuAQ--.167S2 X-Coremail-Antispam: 1Uf129KBjvdXoW5Kry8uFyfJr43AryfuF4xCrg_yoWxArc_Gr 4DAasxZayUtFZ7JF43KF1qyrnxWFs5ury7Zw4xKws29ryrAw47uFsIy3s8ury8WFsakas8 GFnFyrZFk34avjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRMBTY7UUUUU== X-Originating-IP: [112.93.132.216] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/1tbiTxlqr1sGSHaMlgAAsq X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon, 11 Nov 2019 21:37:09 +0800, Mattias Engdeg=E5rd wrote: >=20 > Thanks for the report! However, there may be a misunderstanding: >=20 > (char ...) as an alias for (any ...) was a documented feature of the old = implementation and was therefore preserved in the re-write; it cannot be re= moved without a very good justification. >=20 > 'char' as an alias for 'not-newline' was never documented in the first pl= ace and because of the rather intuitive meaning, it was considered to be an= implementation accident and therefore not included. >=20 > Therefore I'd rather not apply the proposed changes. Thanks for your explanation. I' m going to adjust my code instead :) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 08:58:22 2019 Received: (at control) by debbugs.gnu.org; 11 Nov 2019 13:58:22 +0000 Received: from localhost ([127.0.0.1]:53328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUACz-0007Qr-Tb for submit@debbugs.gnu.org; Mon, 11 Nov 2019 08:58:22 -0500 Received: from mail153c50.megamailservers.eu ([91.136.10.163]:48962 helo=mail50c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iUACx-0007Qh-TR for control@debbugs.gnu.org; Mon, 11 Nov 2019 08:58:20 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1573480697; bh=UdEKQ/Wv0oW3w+HRIHhoAX+OdsQoUYWWH3VPb4muZBg=; h=From:Subject:Date:References:To:In-Reply-To:From; b=hnOkrXSesKF9k0YMluNjgjluwvmRiXWc3F9GOL+pSq8oCqmwiMn4NeoLA5+pYYH5d hevqhzzY3VznvIi0oCiiYFCGtlQmn8Qkzk45/wixz6PCFOm7dyQOz3A+3Y71cV9eBv A2GkeOjnQjOOea5XYHhNZQTzk5higAK3A1T96QXM= Feedback-ID: mattiase@acm.or Received: from [192.168.1.64] (c-ee54e353.032-75-73746f71.bbcust.telenor.se [83.227.84.238]) (authenticated bits=0) by mail50c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xABDwFUH006556 for ; Mon, 11 Nov 2019 13:58:17 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: bug#38170: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. Date: Mon, 11 Nov 2019 14:58:14 +0100 References: <5BE752A4-367E-4095-9365-174D73DB9DFF@acm.org> <87woc68qml.wl-all_but_last@163.com> To: control@debbugs.gnu.org In-Reply-To: <87woc68qml.wl-all_but_last@163.com> Message-Id: <1AF462D8-5BBE-4E1D-B3C1-2F44ECED7F21@acm.org> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020D.5DC968F9.0056, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=N4FX6F1B c=1 sm=1 tr=0 a=Fmb7hdz85/yTNbhpOvpRKA==:117 a=Fmb7hdz85/yTNbhpOvpRKA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mZSrJsU7fibpzBhx3nEA:9 a=CjuIK1q_8ugA:10 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 38170 notabug close 38170