GNU bug report logs - #38170
27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 38170 in the body.
You can then email your comments to 38170 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers. 
Date: Mon, 11 Nov 2019 18:24:10 +0800

[Message part 1 (text/plain, inline)]

New rx implementation introduce some bug:

1. (rx char) throw an error "Unknown rx symbol char"
2. (rx (char ?A ?B)) return a regexp match A or B.

This patch aims to fix this.

[0001-rx.el-Fix-misplaced-char-identifiers.patch (text/plain, attachment)]

Message #8 received at 38170 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattiase <at> acm.org>
To: 38170 <at> debbugs.gnu.org
Cc: Zhu Zihao <all_but_last <at> 163.com>
Subject: bug#38170: 27.0.50; [PATCH] rx.el: Fix misplaced "char" identifiers.
Date: Mon, 11 Nov 2019 14:37:09 +0100

Thanks for the report! However, there may be a misunderstanding:

(char ...) as an alias for (any ...) was a documented feature of the old implementation and was therefore preserved in the re-write; it cannot be removed without a very good justification.

'char' as an alias for 'not-newline' was never documented in the first place and because of the rather intuitive meaning, it was considered to be an implementation accident and therefore not included.

Therefore I'd rather not apply the proposed changes.

Message #11 received at 38170 <at> debbugs.gnu.org (full text, mbox):

From: Zhu Zihao <all_but_last <at> 163.com>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 38170 <at> debbugs.gnu.org, Zhu Zihao <all_but_last <at> 163.com>
Subject: Re: bug#38170: 27.0.50;
 [PATCH] rx.el: Fix misplaced "char" identifiers.
Date: Mon, 11 Nov 2019 21:54:58 +0800

On Mon, 11 Nov 2019 21:37:09 +0800,
Mattias Engdegård wrote:
> 
> Thanks for the report! However, there may be a misunderstanding:
> 
> (char ...) as an alias for (any ...) was a documented feature of the old implementation and was therefore preserved in the re-write; it cannot be removed without a very good justification.
> 
> 'char' as an alias for 'not-newline' was never documented in the first place and because of the rather intuitive meaning, it was considered to be an implementation accident and therefore not included.
> 
> Therefore I'd rather not apply the proposed changes.

Thanks for your explanation. I' m going to adjust my code instead :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.