From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 15:29:38 2019 Received: (at submit) by debbugs.gnu.org; 9 Nov 2019 20:29:38 +0000 Received: from localhost ([127.0.0.1]:50332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTXMX-0005A2-VO for submit@debbugs.gnu.org; Sat, 09 Nov 2019 15:29:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:41809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTXMV-00059s-Ty for submit@debbugs.gnu.org; Sat, 09 Nov 2019 15:29:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTXMU-0001Uk-WD for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: **** X-Spam-Status: No, score=4.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_SBL_CSS autolearn=disabled version=3.3.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTXMU-0003b9-3O for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:34 -0500 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:33165) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTXMT-0003YI-Qa for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2019 15:29:34 -0500 Received: by mail-lf1-x144.google.com with SMTP id d6so6606505lfc.0 for ; Sat, 09 Nov 2019 12:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:mime-version:subject:message-id:date:to; bh=RxGRsERZgGCojQr6g7+y5vaGN9aTQSNbKS2YuW41YsI=; b=iJzT0mdo2AR0+K8sZWnGTsj6UjEnzXZrYpM2juYxfvsHBm0B8PS/npLMDVrQtGuiYu wL+noKXPd/mWV30WqQ2tK9RySOSKASpqCPnuVF9utC6o6CLUjqfMQJ0UR3Ac8Zj0ZOkN +hcza7njluaRZ37M3H5z2SmCFy0SNsaON5qt1e6vQg8x4yqkCBfzONKkMLRU9Kybixv6 MdlrtJP3E7IXUx70zEgpw8ornG3kFmWJuL5kFoh6R5UuFPnAbnhst7aoGjkuKt0vT8LQ chsLdMMqHhCoQ0X9f/UBZl56bG2fy8FE+AZLJ3f+QY41J3VmWOIbHRUXBMmhNL2mJEL5 CbRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=RxGRsERZgGCojQr6g7+y5vaGN9aTQSNbKS2YuW41YsI=; b=iGYg9oU97QUop1HZx3yNPKsbN4sGhI8iUTWGmIK8xyQMHPWHWX0y+YEj+++e3t1MXo lkK7j+YkUGCAemdzsKsFtBNRgLbo5D+I5CCK3jw2gNJyCVIINpWZmZaZGCJ+XQgFCHOl J4tZS6xW7G4j9kx+dwu1/tejpwscH0QhWMca4kVoYuqChHH9eYG3Aot1c+leoYnG56UH aJwJS5CfCNC8bFXFWLJLGEpdSQWMKRIdj1uqGOPgtvUbeiruPPjCyv8P9ZoXrLPD0VMF IbsFNDXVkNq179wzmO39URyYbq9wObTw3Ov2k2594lvGRu062sQ+9+/7WDtzSvHtqwYg Pk2w== X-Gm-Message-State: APjAAAXM1wc9slX/TkicO1SyCNZCsrvnr9QtVQYh5dhhNqTGVanMhi0b yPAhW6nv+nQaC3QT5KxGnBe47d4DW2Q= X-Google-Smtp-Source: APXvYqwSppJQSSqVBGmhtgIRhS+zWj34FZmvK+50Vj+SzZfrCHKVaYPmghSX8mkoAfcZCRh+VxMX6g== X-Received: by 2002:a19:7617:: with SMTP id c23mr215643lff.175.1573331370944; Sat, 09 Nov 2019 12:29:30 -0800 (PST) Received: from [192.168.0.104] ([91.206.110.132]) by smtp.gmail.com with ESMTPSA id e10sm4403615ljp.23.2019.11.09.12.29.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Nov 2019 12:29:30 -0800 (PST) From: Andrii Kolomoiets Content-Type: multipart/mixed; boundary="Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: 27.0.50; [PATCH] VC: ability to skip update buffers prompt Message-Id: Date: Sat, 9 Nov 2019 22:29:28 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3601.0.10) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::144 X-Spam-Score: 2.2 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn vc backends so the answer for "Update any affected buffers?" prompt doesn't matter. This prompt can be omitted. Content analysis details: (2.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [91.206.110.132 listed in zen.spamhaus.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andreyk.mad[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn vc backends so the answer for "Update any affected buffers?" prompt doesn't matter. This prompt can be omitted. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [91.206.110.132 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (andreyk.mad[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hi, The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn vc backends so the answer for "Update any affected buffers?" prompt doesn't matter. This prompt can be omitted. --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3 Content-Disposition: attachment; filename=0001-VC-ability-to-skip-update-buffers-prompt.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-VC-ability-to-skip-update-buffers-prompt.patch" Content-Transfer-Encoding: quoted-printable =46rom=2021d63d3a4c8e3348f590f4189da36798bc6e1bfd=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Andrii=20Kolomoiets=20=0A= Date:=20Sat,=209=20Nov=202019=2022:23:13=20+0200=0ASubject:=20[PATCH]=20= VC:=20ability=20to=20skip=20update=20buffers=20prompt=0A=0AThe=20= `update'=20argument=20of=20`vc-retrieve-tag'=20is=20ignored=20by=20git,=20= hg=20and=20svn=20vc=0Abackends=20so=20the=20answer=20for=20"Update=20any=20= affected=20buffers?"=20prompt=20doesn't=0Amatter.=20=20This=20prompt=20= can=20be=20omitted.=0A=0A*=20lisp/vc/vc.el=20= (vc-default-update-on-retrieve-tag):=20New=20function.=0A= (vc-retrieve-tag):=20Call=20`update-on-retrieve-tag'=20backend=20= function=20to=20determine=0Aif=20prompt=20for=20update=20buffers=20is=20= needed;=20Include=20tag=20name=20into=20the=20"Retrieving=0Atag"=20= message.=0A*=20lisp/vc/vc-git.el=20(vc-git-update-on-retrieve-tag):=0A*=20= lisp/vc/vc-hg.el=20(vc-hg-update-on-retrieve-tag):=0A*=20= lisp/vc/vc-svn.el=20(vc-svn-udate-on-retrieve-tag):=20New=20functions.=20= =20Buffers=0Aupdate=20prompt=20on=20`vc-retrieve-tag'=20is=20omitted.=0A=0A= diff=20--git=20a/lisp/vc/vc-git.el=20b/lisp/vc/vc-git.el=0Aindex=20= 3960f725cf..587a37455e=20100644=0A---=20a/lisp/vc/vc-git.el=0A+++=20= b/lisp/vc/vc-git.el=0A@@=20-47,6=20+47,7=20@@=0A=20;;=20FUNCTION=20NAME=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20STATUS=0A=20;;=20BACKEND=20PROPERTIES=0A=20;;=20= *=20revision-granularity=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20OK=0A+;;=20-=20update-on-retrieve-tag=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A=20= ;;=20STATE-QUERYING=20FUNCTIONS=0A=20;;=20*=20registered=20(file)=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20OK=0A=20;;=20*=20state=20(file)=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A@@=20= -218,6=20+219,7=20@@=20vc-git-history=0A=20=0A=20(defun=20= vc-git-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-git-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-git-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=20= STATE-QUERYING=20FUNCTIONS=0A=20=0Adiff=20--git=20a/lisp/vc/vc-hg.el=20= b/lisp/vc/vc-hg.el=0Aindex=20cc737b30b1..16e5dd6db0=20100644=0A---=20= a/lisp/vc/vc-hg.el=0A+++=20b/lisp/vc/vc-hg.el=0A@@=20-40,6=20+40,7=20@@=0A= =20;;=20FUNCTION=20NAME=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20STATUS=0A=20;;=20BACKEND=20= PROPERTIES=0A=20;;=20*=20revision-granularity=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20OK=0A+;;=20-=20= update-on-retrieve-tag=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20OK=0A=20;;=20STATE-QUERYING=20FUNCTIONS=0A=20;;=20*=20= registered=20(file)=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20OK=0A=20;;=20*=20state=20(file)=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20OK=0A= @@=20-194,6=20+195,7=20@@=20vc-hg-history=0A=20=0A=20(defun=20= vc-hg-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-hg-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-hg-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=20State=20= querying=20functions=0A=20=0Adiff=20--git=20a/lisp/vc/vc-svn.el=20= b/lisp/vc/vc-svn.el=0Aindex=20942dbd5fa5..ed34b357f9=20100644=0A---=20= a/lisp/vc/vc-svn.el=0A+++=20b/lisp/vc/vc-svn.el=0A@@=20-127,6=20+127,7=20= @@=20vc-svn-admin-directory=0A=20=0A=20(defun=20= vc-svn-revision-granularity=20()=20'repository)=0A=20(defun=20= vc-svn-checkout-model=20(_files)=20'implicit)=0A+(defun=20= vc-svn-update-on-retrieve-tag=20()=20nil)=0A=20=0A=20;;;=0A=20;;;=20= State-querying=20functions=0Adiff=20--git=20a/lisp/vc/vc.el=20= b/lisp/vc/vc.el=0Aindex=2020056dec7f..401b39145c=20100644=0A---=20= a/lisp/vc/vc.el=0A+++=20b/lisp/vc/vc.el=0A@@=20-110,6=20+110,12=20@@=0A=20= ;;=20=20=20that=20return=20'file=20have=20per-file=20revision=20= numbering;=20backends=0A=20;;=20=20=20that=20return=20'repository=20have=20= per-repository=20revision=20numbering,=0A=20;;=20=20=20so=20a=20revision=20= level=20implicitly=20identifies=20a=20changeset=0A+;;=0A+;;=20-=20= update-on-retrieve-tag=0A+;;=0A+;;=20=20=20Takes=20no=20arguments.=20=20= Backends=20that=20return=20non-nil=20can=20update=0A+;;=20=20=20buffers=20= on=20`vc-retrieve-tag'=20based=20on=20user=20input.=20=20In=20this=20= case=0A+;;=20=20=20user=20will=20be=20prompted=20to=20update=20buffers=20= on=20`vc-retrieve-tag'.=0A=20=0A=20;;=20STATE-QUERYING=20FUNCTIONS=0A=20= ;;=0A@@=20-2302,14=20+2308,15=20@@=20vc-retrieve-tag=0A=20=20=20=20=20=20= =20(vc-read-revision=20"Tag=20name=20to=20retrieve=20(default=20latest=20= revisions):=20"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20(list=20dir)=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20(vc-responsible-backend=20dir)))))=0A-=20= =20(let=20((update=20(yes-or-no-p=20"Update=20any=20affected=20buffers?=20= "))=0A-=09(msg=20(if=20(or=20(not=20name)=20(string=3D=20name=20""))=0A-=09= =09=20(format=20"Updating=20%s...=20"=20(abbreviate-file-name=20dir))=0A= -=09=20=20=20=20=20=20=20(format=20"Retrieving=20tag=20into=20%s...=20"=0A= -=09=09=20=20=20=20=20=20=20(abbreviate-file-name=20dir)))))=0A+=20=20= (let*=20((backend=20(vc-responsible-backend=20dir))=0A+=20=20=20=20=20=20= =20=20=20(update=20(when=20(vc-call-backend=20backend=20= 'update-on-retrieve-tag)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(yes-or-no-p=20"Update=20any=20affected=20buffers?=20")))=0A= +=09=20(msg=20(if=20(or=20(not=20name)=20(string=3D=20name=20""))=0A+=09=09= =20=20(format=20"Updating=20%s...=20"=20(abbreviate-file-name=20dir))=0A= +=09=20=20=20=20=20=20=20=20(format=20"Retrieving=20tag=20%s=20into=20= %s...=20"=0A+=09=09=20=20=20=20=20=20=20=20name=20(abbreviate-file-name=20= dir)))))=0A=20=20=20=20=20(message=20"%s"=20msg)=0A-=20=20=20=20= (vc-call-backend=20(vc-responsible-backend=20dir)=0A-=09=09=20=20=20=20=20= 'retrieve-tag=20dir=20name=20update)=0A+=20=20=20=20(vc-call-backend=20= backend=20'retrieve-tag=20dir=20name=20update)=0A=20=20=20=20=20= (vc-resynch-buffer=20dir=20t=20t=20t)=0A=20=20=20=20=20(run-hooks=20= 'vc-retrieve-tag-hook)=0A=20=20=20=20=20(message=20"%s"=20(concat=20msg=20= "done"))))=0A@@=20-3025,6=20+3032,10=20@@=20vc-default-receive-file=0A=20= =20=20"Let=20BACKEND=20receive=20FILE=20from=20another=20version=20= control=20system."=0A=20=20=20(vc-call-backend=20backend=20'register=20= (list=20file)=20rev=20""))=0A=20=0A+(defun=20= vc-default-update-on-retrieve-tag=20()=0A+=20=20"Prompt=20for=20update=20= buffers=20on=20`vc-retrieve-tag'."=0A+=20=20t)=0A+=0A=20(defun=20= vc-default-retrieve-tag=20(backend=20dir=20name=20update)=0A=20=20=20(if=20= (string=3D=20name=20"")=0A=20=20=20=20=20=20=20(progn=0A--=20=0A2.15.1=0A= =0A= --Apple-Mail=_FFA8B34B-BDFE-4793-A4BA-47735D4FA1F3-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 00:56:10 2019 Received: (at 38156) by debbugs.gnu.org; 14 Nov 2019 05:56:10 +0000 Received: from localhost ([127.0.0.1]:60688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV86z-0002XF-Oc for submit@debbugs.gnu.org; Thu, 14 Nov 2019 00:56:10 -0500 Received: from quimby.gnus.org ([95.216.78.240]:49732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV86y-0002X2-BS for 38156@debbugs.gnu.org; Thu, 14 Nov 2019 00:56:08 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iV86o-0000nz-OP; Thu, 14 Nov 2019 06:56:01 +0100 From: Lars Ingebrigtsen To: Andrii Kolomoiets Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt References: Date: Thu, 14 Nov 2019 06:55:58 +0100 In-Reply-To: (Andrii Kolomoiets's message of "Sat, 9 Nov 2019 22:29:28 +0200") Message-ID: <878sojq9w1.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andrii Kolomoiets writes: > The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn > vc backends so the answer for "Update any affected buffers?" prompt > doesn't matter. This prompt can be omitted. Content analysis details: (-1.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38156 Cc: 38156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrii Kolomoiets writes: > The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn > vc backends so the answer for "Update any affected buffers?" prompt > doesn't matter. This prompt can be omitted. Would it be possible to make those backends respect the UPDATE argument instead? I had a quick peek at vc-cvs-retrieve-tag (which does respect the argument), and it looks a bit painful, and I'm not sure whether it looks that useful. Anybody got an opinion? I applied the patch anyway, because it provides a way to make the backends say whether they support it or not, which seems generally useful. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 02:13:43 2019 Received: (at 38156) by debbugs.gnu.org; 14 Nov 2019 07:13:44 +0000 Received: from localhost ([127.0.0.1]:60828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV9K3-00049O-Nz for submit@debbugs.gnu.org; Thu, 14 Nov 2019 02:13:43 -0500 Received: from mail-lj1-f174.google.com ([209.85.208.174]:33901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV9K1-00049A-FI for 38156@debbugs.gnu.org; Thu, 14 Nov 2019 02:13:41 -0500 Received: by mail-lj1-f174.google.com with SMTP id 139so5473570ljf.1 for <38156@debbugs.gnu.org>; Wed, 13 Nov 2019 23:13:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=7KF/TIFzl4nvP5S9Rit78QtasTPh3PPozE4sJR5okjI=; b=OAhJMYzH6ULT13xBDG/q9P0NR0hy3AZPvjoIAgB8Qv+LNn/zp/QSIXD4OezeNZhkyw 38Eyh+JtH5oqb5p8nUwFTZ5w96wezlco9W8CtFMjdKstGu0fKI1FXZ202CI2351fCTgh nPNVmjS2pmi+USzDUDEE0kKTZ++7VSI0q8dTVXrdCmrnlYrVK9/xX2kuB7W6TUJBYOBq hx/vX3Vp3qrOGM9/l2RNQKPRBLs2qLyrRjCFiM2o94IY3K8TlPCi4Z03ZvWOgg6If8wO ljS+RIMWLu6mgPFkofAq32Unwf1b8tj1nuP63GmnXYzrHduy424JEDM/CNg+1iGv5R9D 13gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=7KF/TIFzl4nvP5S9Rit78QtasTPh3PPozE4sJR5okjI=; b=IEwdLST9fFlDs3YoANzCAKEjj+h6VKXL15X63/0dNbG8J8W9qA/sy6BPwbNoVpfyuy gATASqR8oaZmiugTJKIZ3I/0sSBPh4vhDXOUMdp4RrdlnxyGU4BL9wqsh9V5DDBZ1LHL iIpS2fuq5AB4e0yxwUtCi9BxIWisGmU4JcxxValr6cBjWe8rMv9dUKQ0aZNuPH2DtBri My01sLOM/Eck9Ja6i/0ZN4rvD+tGmbBUxmbi8RMmZhAbNdlRL38qsmUkii9lrqnAq0iM XYarfn43/qQNV+4+r2YRmgbBtjP1cb8t0oZaAOvWGKQUYdyICi6E0Vw4bsy3592eYtix b0mQ== X-Gm-Message-State: APjAAAXNCO+BzogoZL5d0aYpDx3lZ54QVdRjBGXt+OMLQMYsD3kDZ+2W 7H6RhsirRoMckoyFHxReJlg= X-Google-Smtp-Source: APXvYqwUKXV8F5k9d8AGQ6u7s8wlOyr87tZwvLS2MrKJPx4ypmPiz/4vTK/HfHknKmjlsNzfxM7I4Q== X-Received: by 2002:a2e:9c8f:: with SMTP id x15mr5552902lji.204.1573715615486; Wed, 13 Nov 2019 23:13:35 -0800 (PST) Received: from [10.1.1.147] (188-42-207-82.ip.ukrtel.net. [82.207.42.188]) by smtp.gmail.com with ESMTPSA id y9sm2018689lfl.16.2019.11.13.23.13.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Nov 2019 23:13:34 -0800 (PST) From: Andrii Kolomoiets Message-Id: <9E38A0BD-16D2-48B5-B87A-02A1F3F9986C@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_DB74D5E0-FD84-4F68-AE18-C5F0F576ACD0" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt Date: Thu, 14 Nov 2019 09:13:33 +0200 In-Reply-To: <878sojq9w1.fsf@gnus.org> To: Lars Ingebrigtsen References: <878sojq9w1.fsf@gnus.org> X-Mailer: Apple Mail (2.3601.0.10) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38156 Cc: 38156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_DB74D5E0-FD84-4F68-AE18-C5F0F576ACD0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hi Lars, > On 14 Nov 2019, at 07:55, Lars Ingebrigtsen wrote: > > I applied the patch anyway, because it provides a way to make the > backends say whether they support it or not, which seems generally > useful. Please install attached patch. Totally missed that default vc functions are called with `backend` argument. Thanks. --Apple-Mail=_DB74D5E0-FD84-4F68-AE18-C5F0F576ACD0 Content-Disposition: attachment; filename=0001-lisp-vc-vc.el-vc-default-update-on-retrieve-tag-Acce.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-lisp-vc-vc.el-vc-default-update-on-retrieve-tag-Acce.patch" Content-Transfer-Encoding: quoted-printable =46rom=20dfc40b85d9ff6fbc5344cd6882881c421decee35=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Andrii=20Kolomoiets=20=0A= Date:=20Thu,=2014=20Nov=202019=2009:07:31=20+0200=0ASubject:=20[PATCH]=20= lisp/vc/vc.el=20(vc-default-update-on-retrieve-tag):=20Accept=0A=20= backend=0A=0A*=20lisp/vc/vc.el=20(vc-default-update-on-retrieve-tag):=20= Accept=20backend=20argument=0A=0Adiff=20--git=20a/lisp/vc/vc.el=20= b/lisp/vc/vc.el=0Aindex=20401b39145c..0d29c80d02=20100644=0A---=20= a/lisp/vc/vc.el=0A+++=20b/lisp/vc/vc.el=0A@@=20-3032,7=20+3032,7=20@@=20= vc-default-receive-file=0A=20=20=20"Let=20BACKEND=20receive=20FILE=20= from=20another=20version=20control=20system."=0A=20=20=20= (vc-call-backend=20backend=20'register=20(list=20file)=20rev=20""))=0A=20= =0A-(defun=20vc-default-update-on-retrieve-tag=20()=0A+(defun=20= vc-default-update-on-retrieve-tag=20(_backend)=0A=20=20=20"Prompt=20for=20= update=20buffers=20on=20`vc-retrieve-tag'."=0A=20=20=20t)=0A=20=0A--=20=0A= 2.15.1=0A=0A= --Apple-Mail=_DB74D5E0-FD84-4F68-AE18-C5F0F576ACD0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 02:18:50 2019 Received: (at 38156) by debbugs.gnu.org; 14 Nov 2019 07:18:50 +0000 Received: from localhost ([127.0.0.1]:60832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV9P0-0004HF-BC for submit@debbugs.gnu.org; Thu, 14 Nov 2019 02:18:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:50834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iV9Oy-0004H1-2d for 38156@debbugs.gnu.org; Thu, 14 Nov 2019 02:18:48 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iV9Oo-0001PL-NR; Thu, 14 Nov 2019 08:18:41 +0100 From: Lars Ingebrigtsen To: Andrii Kolomoiets Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt References: <878sojq9w1.fsf@gnus.org> <9E38A0BD-16D2-48B5-B87A-02A1F3F9986C@gmail.com> Date: Thu, 14 Nov 2019 08:18:37 +0100 In-Reply-To: <9E38A0BD-16D2-48B5-B87A-02A1F3F9986C@gmail.com> (Andrii Kolomoiets's message of "Thu, 14 Nov 2019 09:13:33 +0200") Message-ID: <87lfsjncxe.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andrii Kolomoiets writes: > Please install attached patch. Totally missed that default vc functions > are called with `backend` argument. OK; installed. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: ingebrigtsen.no] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38156 Cc: 38156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrii Kolomoiets writes: > Please install attached patch. Totally missed that default vc functions > are called with `backend` argument. OK; installed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 04:54:17 2019 Received: (at 38156) by debbugs.gnu.org; 14 Nov 2019 09:54:17 +0000 Received: from localhost ([127.0.0.1]:60958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVBpQ-00085t-NG for submit@debbugs.gnu.org; Thu, 14 Nov 2019 04:54:16 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVBpO-00085d-WE for 38156@debbugs.gnu.org; Thu, 14 Nov 2019 04:54:15 -0500 Received: by mail-lf1-f67.google.com with SMTP id y186so4540142lfa.1 for <38156@debbugs.gnu.org>; Thu, 14 Nov 2019 01:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xodUfT45iTr7UinE7pZvE2E8Gyt5t+i//62Aa1t53SQ=; b=EJp8ZVp6HW18ttJVqHvrxtEaimb8SSLijc0c+4y67nJf2hQlsecd50P0Llm6wUpeo1 /f3D9bkpfbhQc46VIsNwPhLQuLBsqSAFtwyzQC/CLhgU4MjAQE5W1ot6iqQ4B1O1Fa7E Eu/NYyKk4zVH/mlmi9fj3mHwWHntDXpt4RHDwz8nsuyCEjBupTHj/DW+kntgA5zKHQzy HyTeG6v62Mv31mbax+6BVpr2ddvQm2MxKDLEThOzzYxAw9pqVVjxdhHuDAbK2WUbXwoq EjsXLJaFCq+mSgpHrlQ+FrfmbEHaP/Z29zHKMlMlW8QvhXDTVkPXB7vOCinSsmFsMfne xUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xodUfT45iTr7UinE7pZvE2E8Gyt5t+i//62Aa1t53SQ=; b=BqMwA7hgdmgrxokfpTWQ+SL9Vm2NazKSUwzpY8TjsYAKNDW+Lvz3LeOUgWBJ9hFQgZ tbgt8NYtX3ugvEkKMdR7JvKOcIoVePrkfc9MgZE1lWns2dPXTXU+v3bbCM1ygV7UzO4s oIXCqzPDHwXnAMV1gqghQML8Vb9aa41tMQShx9RR5wfUqhM7QF7vBE9nTIctVit+svEI 5R7XMLyTB6425F+nPVGuMpWGsujj+6YQeA0I4Hd4kOFBlX/9OK+jxjoKYLvv0S8f5FO4 /EMBVVLQ9l5vwuYiZ8AthBbwNeUt3G3iQ987HLUWI26kG5whImIeNMgZ7GHfSUb9r+uS q0Hg== X-Gm-Message-State: APjAAAUbghHBkc1UoeLpafZRXqC5IfltqRu3ZccpmACCzC3TVeTVln05 SIW/L1avlDuQhHPcnB7Z48g= X-Google-Smtp-Source: APXvYqxQP9mZ90kFgUvQ0MpxAKPfzfAPB75lBgsJD4TlMHrnoZQg87H+M/+CB4ddnZt6woZ/sRz++g== X-Received: by 2002:a19:c18d:: with SMTP id r135mr6254234lff.75.1573725248825; Thu, 14 Nov 2019 01:54:08 -0800 (PST) Received: from [10.1.1.147] (188-42-207-82.ip.ukrtel.net. [82.207.42.188]) by smtp.gmail.com with ESMTPSA id b14sm2319068lfa.14.2019.11.14.01.54.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Nov 2019 01:54:08 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3601.0.10\)) Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt From: Andrii Kolomoiets In-Reply-To: <878sojq9w1.fsf@gnus.org> Date: Thu, 14 Nov 2019 11:54:07 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <878sojq9w1.fsf@gnus.org> To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3601.0.10) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38156 Cc: 38156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Lars, > On 14 Nov 2019, at 07:55, Lars Ingebrigtsen wrote: > > Andrii Kolomoiets writes: > >> The `update' argument of `vc-retrieve-tag' is ignored by git, hg and svn >> vc backends so the answer for "Update any affected buffers?" prompt >> doesn't matter. This prompt can be omitted. > > Would it be possible to make those backends respect the UPDATE argument > instead? I had a quick peek at vc-cvs-retrieve-tag (which does respect > the argument), and it looks a bit painful, and I'm not sure whether it > looks that useful. vc-retrieve-tag is already updating buffers by calling (vc-resynch-buffer dir t t t) Maybe this commits are related: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5828f6cacc5 http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f4f2ae4f96 IMO there are nothing more those backends can do with buffers so `update` argument is mean nothing to them. Don't know about cvs backend though. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 02:13:36 2019 Received: (at 38156) by debbugs.gnu.org; 16 Nov 2019 07:13:36 +0000 Received: from localhost ([127.0.0.1]:37645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVsH2-0002og-7o for submit@debbugs.gnu.org; Sat, 16 Nov 2019 02:13:36 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVsH1-0002oS-Et for 38156@debbugs.gnu.org; Sat, 16 Nov 2019 02:13:35 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iVsGs-0007CY-DN; Sat, 16 Nov 2019 08:13:28 +0100 From: Lars Ingebrigtsen To: Andrii Kolomoiets Subject: Re: bug#38156: 27.0.50; [PATCH] VC: ability to skip update buffers prompt References: <878sojq9w1.fsf@gnus.org> Date: Sat, 16 Nov 2019 08:13:25 +0100 In-Reply-To: (Andrii Kolomoiets's message of "Thu, 14 Nov 2019 11:54:07 +0200") Message-ID: <87v9rkgup6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andrii Kolomoiets writes: > vc-retrieve-tag is already updating buffers by calling > (vc-resynch-buffer dir t t t) > > Maybe this commits are related: > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5828f6cacc5 > http: [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: gnu.org] -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 38156 Cc: 38156@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrii Kolomoiets writes: > vc-retrieve-tag is already updating buffers by calling > (vc-resynch-buffer dir t t t) > > Maybe this commits are related: > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5828f6cacc5 > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5f4f2ae4f96 > > IMO there are nothing more those backends can do with buffers so > `update` argument is mean nothing to them. OK; closing. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 02:13:40 2019 Received: (at control) by debbugs.gnu.org; 16 Nov 2019 07:13:40 +0000 Received: from localhost ([127.0.0.1]:37648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVsH6-0002oy-Gs for submit@debbugs.gnu.org; Sat, 16 Nov 2019 02:13:40 -0500 Received: from quimby.gnus.org ([95.216.78.240]:55536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iVsH4-0002oW-QK for control@debbugs.gnu.org; Sat, 16 Nov 2019 02:13:39 -0500 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iVsGx-0007Cf-Af for control@debbugs.gnu.org; Sat, 16 Nov 2019 08:13:33 +0100 Date: Sat, 16 Nov 2019 08:13:30 +0100 Message-Id: <87tv74gup1.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #38156 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 38156 fixed close 38156 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 38156 fixed close 38156 27.1 quit From unknown Sun Jun 22 00:22:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 14 Dec 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator